]> git.sesse.net Git - vlc/blobdiff - modules/gui/macosx/prefs.m
Implement the full/basic switch correctly and completely. Additionally, fixed a rare...
[vlc] / modules / gui / macosx / prefs.m
index c980477353a1f7203615153d6ca0882972087c66..7bdb0e7ea107bd4bdd18cc497f010817e9bffb7f 100644 (file)
@@ -22,7 +22,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
-/* VLCPrefs manages the main preferences dialog 
+/* VLCPrefs manages the main preferences dialog
    the class is related to wxwindows intf, PrefsPanel */
 /* VLCTreeItem should contain:
    - the children of the treeitem
 #include <sys/param.h>                                    /* for MAXPATHLEN */
 #include <string.h>
 
-#include <vlc/vlc.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
 #include <vlc_config_cat.h>
 
-#include "intf.h"
-#include "prefs.h"
-#include "prefs_widgets.h"
-#include "vlc_keys.h"
+#import "intf.h"
+#import "prefs.h"
+#import "simple_prefs.h"
+#import "prefs_widgets.h"
+#import "vlc_keys.h"
 
 /*****************************************************************************
  * VLCPrefs implementation
@@ -108,9 +113,9 @@ static VLCPrefs *_o_sharedMainInstance = nil;
 
 - (void)showPrefs
 {
-    /* load our nib (if not already loaded) */
-    [NSBundle loadNibNamed:@"Preferences" owner:self];
-
+    [[o_basicFull_matrix cellAtRow:0 column:0] setState: NSOffState];
+    [[o_basicFull_matrix cellAtRow:0 column:1] setState: NSOnState];
+    
     [o_prefs_window center];
     [o_prefs_window makeKeyAndOrderFront:self];
 }
@@ -122,6 +127,8 @@ static VLCPrefs *_o_sharedMainInstance = nil;
     [o_cancel_btn setTitle: _NS("Cancel")];
     [o_reset_btn setTitle: _NS("Reset All")];
     [o_advanced_ckb setTitle: _NS("Advanced")];
+    [[o_basicFull_matrix cellAtRow: 0 column: 0] setStringValue: _NS("Basic")];
+    [[o_basicFull_matrix cellAtRow: 0 column: 1] setStringValue: _NS("All")];
 }
 
 - (IBAction)savePrefs: (id)sender
@@ -156,7 +163,7 @@ static VLCPrefs *_o_sharedMainInstance = nil;
         [[VLCTreeItem rootItem] resetView];
         [[o_tree itemAtRow:[o_tree selectedRow]]
             showView:o_prefs_view advancedView:
-            ( [o_advanced_ckb state] == NSOnState ) ? VLC_TRUE : VLC_FALSE];
+            ( [o_advanced_ckb state] == NSOnState ) ? true : false];
     }
 }
 
@@ -166,7 +173,15 @@ static VLCPrefs *_o_sharedMainInstance = nil;
     [o_advanced_ckb setState: b_advanced];
     /* refresh the view of the current treeitem */
     [[o_tree itemAtRow:[o_tree selectedRow]] showView:o_prefs_view advancedView:
-        ( [o_advanced_ckb state] == NSOnState ) ? VLC_TRUE : VLC_FALSE];
+        ( [o_advanced_ckb state] == NSOnState ) ? true : false];
+}
+
+- (IBAction)buttonAction: (id)sender
+{
+    [o_prefs_window orderOut: self];
+    [[o_basicFull_matrix cellAtRow:0 column:0] setState: NSOnState];
+    [[o_basicFull_matrix cellAtRow:0 column:1] setState: NSOffState];
+    [[[VLCMain sharedInstance] getSimplePreferences] showSimplePrefs];
 }
 
 - (void)loadConfigTree
@@ -182,7 +197,7 @@ static VLCPrefs *_o_sharedMainInstance = nil;
 {
     [[o_tree itemAtRow:[o_tree selectedRow]] showView: o_prefs_view
         advancedView:( [o_advanced_ckb state] == NSOnState ) ?
-        VLC_TRUE : VLC_FALSE];
+        true : false];
 }
 
 @end
@@ -196,7 +211,7 @@ static VLCPrefs *_o_sharedMainInstance = nil;
 
 - (BOOL)outlineView:(NSOutlineView *)outlineView isItemExpandable:(id)item
 {
-    return (item == nil) ? YES : ( ([item numberOfChildren] != -1) && 
+    return (item == nil) ? YES : ( ([item numberOfChildren] != -1) &&
                                    ([item numberOfChildren] != 0));
 }
 
@@ -283,8 +298,7 @@ static VLCTreeItem *o_root_item = nil;
 
         /* get parser */
         p_parser = (module_t *)p_list->p_values[i_index].p_object;
-        p_end = p_parser->p_config + p_parser->confsize;
-        
+
         if( [[self getName] isEqualToString: @"main"] )
         {
             /*
@@ -293,7 +307,7 @@ static VLCTreeItem *o_root_item = nil;
             for( i_index = 0; i_index < p_list->i_count; i_index++ )
             {
                 p_module = (module_t *)p_list->p_values[i_index].p_object;
-                if( !strcmp( p_module->psz_object_name, "main" ) )
+                if( !strcmp( module_GetObjName( p_module ), "main" ) )
                     break;
             }
             if( p_module == NULL )
@@ -308,7 +322,9 @@ static VLCTreeItem *o_root_item = nil;
                 /* Enumerate config categories and store a reference so we can
                  * generate their config panel them when it is asked by the user. */
                 VLCTreeItem *p_last_category = NULL;
-                p_item = p_module->p_config;
+                unsigned int i_confsize;
+                p_item = module_GetConfig( p_parser, &i_confsize );
+                p_end = p_item + i_confsize;
                 o_children = [[NSMutableArray alloc] initWithCapacity:10];
                 if( p_item ) do
                 {
@@ -318,7 +334,7 @@ static VLCTreeItem *o_root_item = nil;
                     switch( p_item->i_type )
                     {
                     case CONFIG_CATEGORY:
-                                   if( p_item->value.i == -1 ) break;
+                        if( p_item->value.i == -1 ) break;
 
                         o_child_name = [[VLCMain sharedInstance]
                             localizedString: config_CategoryNameGet( p_item->value.i )];
@@ -334,10 +350,10 @@ static VLCTreeItem *o_root_item = nil;
                             parent:self
                             children:[[NSMutableArray alloc]
                                 initWithCapacity:10]
-                            whithCategory: p_item - p_module->p_config]];
+                            whithCategory: p_item - module_GetConfig( p_module, &i_confsize )]];
                         break;
                     case CONFIG_SUBCATEGORY:
-                                   if( p_item->value.i == -1 ) break;
+                        if( p_item->value.i == -1 ) break;
 
                         if( p_item->value.i != SUBCAT_PLAYLIST_GENERAL &&
                             p_item->value.i != SUBCAT_VIDEO_GENERAL &&
@@ -362,9 +378,9 @@ static VLCTreeItem *o_root_item = nil;
                                 parent:p_last_category
                                 children:[[NSMutableArray alloc]
                                     initWithCapacity:10]
-                                whithCategory: p_item - p_module->p_config]];
+                                whithCategory: p_item - module_GetConfig( p_parser, &i_confsize )]];
                         }
-                        
                         break;
                     default:
                         break;
@@ -376,20 +392,22 @@ static VLCTreeItem *o_root_item = nil;
             /* Add the capabilities */
             for( i_index = 0; i_index < p_list->i_count; i_index++ )
             {
+                unsigned int confsize;
                 p_module = (module_t *)p_list->p_values[i_index].p_object;
 
                 /* Exclude the main module */
-                if( !strcmp( p_module->psz_object_name, "main" ) )
+                if( !strcmp( module_GetObjName( p_module ), "main" ) )
                     continue;
 
                 /* Exclude empty plugins (submodules don't have config */
                 /* options, they are stored in the parent module) */
-                if( p_module->b_submodule )
-                    continue;
-                else
-                    p_item = p_module->p_config;
+// Does not work
+//                if( modules_IsSubModule( p_module ) )
+//                    continue;
+                p_item = module_GetConfig( p_module, &confsize );
 
                 if( !p_item ) continue;
+                if( !p_item->i_type ) break;
                 int i_category = -1;
                 int i_subcategory = -1;
                 int i_options = 0;
@@ -410,7 +428,7 @@ static VLCTreeItem *o_root_item = nil;
                 /* Find the right category item */
 
                 long cookie;
-                vlc_bool_t b_found = VLC_FALSE;
+                bool b_found = false;
                 unsigned int i;
                 VLCTreeItem* p_category_item, * p_subcategory_item;
                 for (i = 0 ; i < [o_children count] ; i++)
@@ -418,14 +436,14 @@ static VLCTreeItem *o_root_item = nil;
                     p_category_item = [o_children objectAtIndex: i];
                     if( p_category_item->i_object_id == i_category )
                     {
-                        b_found = VLC_TRUE;
+                        b_found = true;
                         break;
                     }
                 }
                 if( !b_found ) continue;
 
                 /* Find subcategory item */
-                b_found = VLC_FALSE;
+                b_found = false;
                 cookie = -1;
                 for (i = 0 ; i < [p_category_item->o_children count] ; i++)
                 {
@@ -433,7 +451,7 @@ static VLCTreeItem *o_root_item = nil;
                                             objectAtIndex: i];
                     if( p_subcategory_item->i_object_id == i_subcategory )
                     {
-                        b_found = VLC_TRUE;
+                        b_found = true;
                         break;
                     }
                 }
@@ -442,13 +460,11 @@ static VLCTreeItem *o_root_item = nil;
 
                 [p_subcategory_item->o_children addObject:[[VLCTreeItem alloc]
                     initWithName:[[VLCMain sharedInstance]
-                        localizedString: (char *)p_module->psz_shortname ?
-                        (char *)p_module->psz_shortname : (char *)p_module->psz_object_name ]
+                        localizedString: module_GetName( p_module, false ) ]
                     withTitle:[[VLCMain sharedInstance]
-                        localizedString: (char *)p_module->psz_longname ?
-                        (char *)p_module->psz_longname : (char *)p_module->psz_object_name ]
+                        localizedString:  module_GetLongName( p_module ) ]
                     withHelp: @""
-                    ID: p_module->i_object_id
+                    ID: ((vlc_object_t*)p_module)->i_object_id
                     parent:p_subcategory_item
                     children:IsALeafNode
                     whithCategory: -1]];
@@ -506,9 +522,11 @@ static VLCTreeItem *o_root_item = nil;
     {
         p_parser = (module_t *)p_list->p_values[i_index].p_object ;
 
-        if( !strcmp( p_parser->psz_object_name, psz_module_name ) )
+        if( !strcmp( module_GetObjName( p_parser ), psz_module_name ) )
         {
-            BOOL b_has_prefs = p_parser->i_config_items != 0;
+            unsigned int confsize;
+            module_GetConfig( p_parser, &confsize );
+            BOOL b_has_prefs = confsize != 0;
             vlc_list_release( p_list );
             return( b_has_prefs );
         }
@@ -520,13 +538,13 @@ static VLCTreeItem *o_root_item = nil;
 }
 
 - (NSView *)showView:(NSScrollView *)o_prefs_view
-    advancedView:(vlc_bool_t) b_advanced
+    advancedView:(bool) b_advanced
 {
     NSRect          s_vrc;
     NSView          *o_view;
 
     [[VLCPrefs sharedInstance] setTitle: [self getTitle]];
-    /* NSLog( [self getHelp] ); */ 
+    /* NSLog( [self getHelp] ); */
     s_vrc = [[o_prefs_view contentView] bounds]; s_vrc.size.height -= 4;
     o_view = [[VLCFlippedView alloc] initWithFrame: s_vrc];
     [o_view setAutoresizingMask: NSViewWidthSizable | NSViewMinYMargin |
@@ -540,24 +558,21 @@ static VLCTreeItem *o_root_item = nil;
         vlc_list_t      *p_list;
         module_t        *p_parser = NULL;
         module_config_t *p_item,
-                        *p_end; 
+                        *p_end;
+        unsigned int confsize;
 
         o_subviews = [[NSMutableArray alloc] initWithCapacity:10];
         /* Get a pointer to the module */
         if( i_object_category == -1 )
         {
-            p_parser = (module_t *) vlc_object_get( p_intf, i_object_id );
-            if( !p_parser || p_parser->i_object_type != VLC_OBJECT_MODULE )
+            p_parser = (module_t *) vlc_object_get( i_object_id );
+            if( !p_parser )
             {
                 /* 0OOoo something went really bad */
                 return nil;
             }
-            
-            p_end = p_parser->p_config + p_parser->confsize;
-            
-            p_item = p_parser->p_config;
-
-            p_item = p_parser->p_config + 1;
+            p_item = module_GetConfig( p_parser, &confsize );
+            p_end = p_item + confsize;
 
             do
             {
@@ -594,7 +609,7 @@ static VLCTreeItem *o_root_item = nil;
                 }
             } while( p_item < p_end && p_item++ );
 
-            vlc_object_release( p_parser );
+            vlc_object_release( (vlc_object_t*)p_parser );
         }
         else
         {
@@ -608,7 +623,7 @@ static VLCTreeItem *o_root_item = nil;
             for( i_index = 0; i_index < p_list->i_count; i_index++ )
             {
                 p_parser = (module_t *)p_list->p_values[i_index].p_object;
-                if( !strcmp( p_parser->psz_object_name, "main" ) )
+                if( !strcmp( module_GetObjName( p_parser ), "main" ) )
                     break;
             }
             if( p_parser == NULL )
@@ -616,9 +631,11 @@ static VLCTreeItem *o_root_item = nil;
                 msg_Err( p_intf, "could not load preferences" );
                 return o_view;
             }
-            p_end = p_parser->p_config + p_parser->confsize;
-            
-            p_item = (p_parser->p_config + i_object_category);
+            unsigned int confsize;
+            p_item = module_GetConfig( p_parser, &confsize );
+            p_end = p_item + confsize;
+            p_item += i_object_category;
+
             if( ( p_item->i_type == CONFIG_CATEGORY ) &&
               ( ( p_item->value.i == CAT_PLAYLIST )  ||
                 ( p_item->value.i == CAT_AUDIO )  ||
@@ -631,7 +648,7 @@ static VLCTreeItem *o_root_item = nil;
             do
             {
                 p_item++;
-                if( !p_item )
+                if( !p_item || !p_item->i_type )
                 {
                     msg_Err( p_intf, "invalid preference item found" );
                     break;
@@ -651,10 +668,6 @@ static VLCTreeItem *o_root_item = nil;
                 default:
                 {
                     VLCConfigControl *o_control = nil;
-                   if( p_item->b_internal == VLC_TRUE )
-                   {
-                       break;
-                   }
                     o_control = [VLCConfigControl newControl:p_item
                                                   withView:o_view];
                     if( o_control != nil )
@@ -683,7 +696,7 @@ static VLCTreeItem *o_root_item = nil;
         NSEnumerator *enumerator = [o_subviews objectEnumerator];
         VLCConfigControl *o_widget;
         NSRect o_frame;
-        
         while( ( o_widget = [enumerator nextObject] ) )
             if( ( [o_widget isAdvanced] ) && (! b_advanced) )
                 continue;