/*****************************************************************************
* prefs.m: MacOS X module for vlc
*****************************************************************************
- * Copyright (C) 2002-2005 the VideoLAN team
+ * Copyright (C) 2002-2006 the VideoLAN team
* $Id$
*
* Authors: Jon Lech Johansen <jon-vl@nanocrew.net>
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
*****************************************************************************/
-/* VLCPrefs manages the main preferences dialog
+/* VLCPrefs manages the main preferences dialog
the class is related to wxwindows intf, PrefsPanel */
/* VLCTreeItem should contain:
- the children of the treeitem
#include <sys/param.h> /* for MAXPATHLEN */
#include <string.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <vlc/vlc.h>
#include <vlc_config_cat.h>
- (void)showPrefs
{
- /* load our nib (if not already loaded) */
- [NSBundle loadNibNamed:@"Preferences" owner:self];
-
[o_prefs_window center];
[o_prefs_window makeKeyAndOrderFront:self];
}
- (BOOL)outlineView:(NSOutlineView *)outlineView isItemExpandable:(id)item
{
- return (item == nil) ? YES : ( ([item numberOfChildren] != -1) &&
+ return (item == nil) ? YES : ( ([item numberOfChildren] != -1) &&
([item numberOfChildren] != 0));
}
- (id)outlineView:(NSOutlineView *)outlineView child:(int)index ofItem:(id)item {
return (item == nil) ? [[VLCTreeItem rootItem] childAtIndex:index] :
- [item childAtIndex:index];
+ (id)[item childAtIndex:index];
}
- (id)outlineView:(NSOutlineView *)outlineView
if( [ o_children count] == 0 )
{
intf_thread_t *p_intf = VLCIntf;
- vlc_list_t *p_list;
- module_t *p_module = NULL;
- module_config_t *p_item;
- int i_index;
-
- /* List the modules */
- p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE, FIND_ANYWHERE );
- if( !p_list ) return nil;
-
- if( [[self getName] isEqualToString: @"main"] )
+ int i_index = 0;
+ module_config_t *p_item,
+ *p_end;
+
+ /* Build the tree for the main module */
+ const module_t *p_module = NULL;
+ vlc_list_t *p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE,
+ FIND_ANYWHERE );
+ if( !p_list ) return NULL;
+ for( unsigned i = 0; p_module == NULL; i++ )
{
- /*
- * Find the main module
- */
- for( i_index = 0; i_index < p_list->i_count; i_index++ )
- {
- p_module = (module_t *)p_list->p_values[i_index].p_object;
- if( !strcmp( p_module->psz_object_name, "main" ) )
- break;
- }
- if( p_module == NULL )
- {
- msg_Err( p_intf,
- "could not load the preferences" );
- return nil;
- }
- if( i_index < p_list->i_count )
+ assert (i < (unsigned)p_list->i_count);
+
+ const module_t *p_main = (module_t *)p_list->p_values[i].p_object;
+ if( strcmp( module_GetObjName( p_main ), "main" ) == 0 )
+ p_module = p_main;
+ }
+
+ VLCTreeItem *p_last_category = NULL;
+ unsigned int i_confsize;
+ module_config_t *const p_config = module_GetConfig (p_module, &i_confsize);
+ p_end = p_item + i_confsize;
+
+ for (size_t i = 0; i < i_confsize; i++)
+ {
+ p_item = p_config + i;
+
+ NSString *o_child_name;
+ NSString *o_child_title;
+ NSString *o_child_help;
+
+ switch( p_item->i_type )
{
- /* We found the main module */
- /* Enumerate config categories and store a reference so we can
- * generate their config panel them when it is asked by the user. */
- VLCTreeItem *p_last_category = NULL;
- p_item = p_module->p_config;
- o_children = [[NSMutableArray alloc] initWithCapacity:10];
- if( p_item ) do
- {
- NSString *o_child_name;
- NSString *o_child_title;
- NSString *o_child_help;
- switch( p_item->i_type )
- {
- case CONFIG_CATEGORY:
- if( p_item->i_value == -1 ) break;
- o_child_name = [[VLCMain sharedInstance]
- localizedString: config_CategoryNameGet( p_item->i_value ) ];
- o_child_title = o_child_name;
- o_child_help = [[VLCMain sharedInstance]
- localizedString: config_CategoryHelpGet( p_item->i_value ) ];
- p_last_category = [VLCTreeItem alloc];
- [o_children addObject:[p_last_category
+ case CONFIG_CATEGORY:
+ if( p_item->value.i == -1 ) break;
+
+ o_child_name = [[VLCMain sharedInstance]
+ localizedString: config_CategoryNameGet( p_item->value.i )];
+ o_child_title = o_child_name;
+ o_child_help = [[VLCMain sharedInstance]
+ localizedString: config_CategoryHelpGet( p_item->value.i )];
+ p_last_category = [VLCTreeItem alloc];
+ [o_children addObject:[p_last_category
initWithName: o_child_name
- withTitle: o_child_title
- withHelp: o_child_help
- ID: p_item->i_value
- parent:self
- children:[[NSMutableArray alloc]
+ withTitle: o_child_title
+ withHelp: o_child_help
+ ID: p_item->value.i
+ parent:self
+ children:[[NSMutableArray alloc]
initWithCapacity:10]
- whithCategory: p_item - p_module->p_config]];
- break;
- case CONFIG_SUBCATEGORY:
- if( p_item->i_value == -1 ) break;
+ whithCategory: p_item - module_GetConfig( p_module, &i_confsize )]];
+ break;
+ case CONFIG_SUBCATEGORY:
+ if( p_item->value.i == -1 ) break;
+
+ /* Special cases: move the main subcategories to the parent cat*/
+ if( p_item->value.i != SUBCAT_PLAYLIST_GENERAL &&
+ p_item->value.i != SUBCAT_VIDEO_GENERAL &&
+ p_item->value.i != SUBCAT_INPUT_GENERAL &&
+ p_item->value.i != SUBCAT_INTERFACE_GENERAL &&
+ p_item->value.i != SUBCAT_SOUT_GENERAL &&
+ p_item->value.i != SUBCAT_ADVANCED_MISC &&
+ p_item->value.i != SUBCAT_AUDIO_GENERAL )
+ {
o_child_name = [[VLCMain sharedInstance]
- localizedString: config_CategoryNameGet( p_item->i_value ) ];
+ localizedString: config_CategoryNameGet( p_item->value.i ) ];
o_child_title = o_child_name;
o_child_help = [[VLCMain sharedInstance]
- localizedString: config_CategoryHelpGet( p_item->i_value ) ];
- if( p_item->i_value != SUBCAT_PLAYLIST_GENERAL &&
- p_item->i_value != SUBCAT_VIDEO_GENERAL &&
- p_item->i_value != SUBCAT_AUDIO_GENERAL )
- [p_last_category->o_children
+ localizedString: config_CategoryHelpGet( p_item->value.i ) ];
+
+ [p_last_category->o_children
addObject:[[VLCTreeItem alloc]
initWithName: o_child_name
- withTitle: o_child_title
- withHelp: o_child_help
- ID: p_item->i_value
- parent:p_last_category
- children:[[NSMutableArray alloc]
+ withTitle: o_child_title
+ withHelp: o_child_help
+ ID: p_item->value.i
+ parent:p_last_category
+ children:[[NSMutableArray alloc]
initWithCapacity:10]
- whithCategory: p_item - p_module->p_config]];
- break;
- default:
- break;
+ whithCategory: p_item - module_GetConfig( p_module, &i_confsize )]];
+ continue;
}
- } while( p_item->i_type != CONFIG_HINT_END && p_item++ );
- }
+ break;
- /* Build a tree of the plugins */
- /* Add the capabilities */
- for( i_index = 0; i_index < p_list->i_count; i_index++ )
+ default:
+ break;
+ }
+ }
+ module_PutConfig (p_config);
+
+ /* Build the tree of plugins */
+ /* Build a tree of the plugins */
+ /* Add the capabilities */
+ for( i_index = 0; i_index < p_list->i_count; i_index++ )
+ {
+ unsigned int confsize;
+ p_module = (module_t *)p_list->p_values[i_index].p_object;
+
+ /* Exclude the main module */
+ if( !strcmp( module_GetObjName( p_module ), "main" ) )
+ continue;
+
+ /* Exclude empty plugins (submodules don't have config */
+ /* options, they are stored in the parent module) */
+ // Does not work
+ // if( modules_IsSubModule( p_module ) )
+ // continue;
+ p_item = module_GetConfig( p_module, &confsize );
+
+ if( !p_item ) continue;
+ int i_category = -1;
+ int i_subcategory = -1;
+ int i_options = 0;
+ do
{
- p_module = (module_t *)p_list->p_values[i_index].p_object;
-
- /* Exclude the main module */
- if( !strcmp( p_module->psz_object_name, "main" ) )
- continue;
-
- /* Exclude empty plugins (submodules don't have config */
- /* options, they are stored in the parent module) */
- if( p_module->b_submodule )
- continue;
- else
- p_item = p_module->p_config;
-
- if( !p_item ) continue;
- int i_category = -1;
- int i_subcategory = -1;
- int i_options = 0;
- do
- {
- if( p_item->i_type == CONFIG_CATEGORY )
- i_category = p_item->i_value;
- else if( p_item->i_type == CONFIG_SUBCATEGORY )
- i_subcategory = p_item->i_value;
-
- if( p_item->i_type & CONFIG_ITEM )
- i_options ++;
- if( i_options > 0 && i_category >= 0 && i_subcategory >= 0 )
- break;
- } while( p_item->i_type != CONFIG_HINT_END && p_item++ );
- if( !i_options ) continue;
-
- /* Find the right category item */
-
- long cookie;
- vlc_bool_t b_found = VLC_FALSE;
- unsigned int i;
- VLCTreeItem* p_category_item, * p_subcategory_item;
- for (i = 0 ; i < [o_children count] ; i++)
+ if( p_item->i_type == CONFIG_CATEGORY )
+ i_category = p_item->value.i;
+ else if( p_item->i_type == CONFIG_SUBCATEGORY )
+ i_subcategory = p_item->value.i;
+
+ if( p_item->i_type & CONFIG_ITEM )
+ i_options ++;
+ if( i_options > 0 && i_category >= 0 && i_subcategory >= 0 )
+ break;
+ } while( p_item < p_end && p_item++ );
+ if( !i_options ) continue;
+
+ /* Find the right category item */
+
+ long cookie;
+ vlc_bool_t b_found = VLC_FALSE;
+ unsigned int i;
+ VLCTreeItem* p_category_item, * p_subcategory_item;
+ for (i = 0 ; i < [o_children count] ; i++)
+ {
+ p_category_item = [o_children objectAtIndex: i];
+ if( p_category_item->i_object_id == i_category )
{
- p_category_item = [o_children objectAtIndex: i];
- if( p_category_item->i_object_id == i_category )
- {
- b_found = VLC_TRUE;
- break;
- }
+ b_found = VLC_TRUE;
+ break;
}
- if( !b_found ) continue;
-
- /* Find subcategory item */
- b_found = VLC_FALSE;
- cookie = -1;
- for (i = 0 ; i < [p_category_item->o_children count] ; i++)
- {
- p_subcategory_item = [p_category_item->o_children
+ }
+ if( !b_found ) continue;
+
+ /* Find subcategory item */
+ b_found = VLC_FALSE;
+ cookie = -1;
+ for (i = 0 ; i < [p_category_item->o_children count] ; i++)
+ {
+ p_subcategory_item = [p_category_item->o_children
objectAtIndex: i];
- if( p_subcategory_item->i_object_id == i_subcategory )
- {
- b_found = VLC_TRUE;
- break;
- }
+ if( p_subcategory_item->i_object_id == i_subcategory )
+ {
+ b_found = VLC_TRUE;
+ break;
}
- if( !b_found )
- p_subcategory_item = p_category_item;
-
- [p_subcategory_item->o_children addObject:[[VLCTreeItem alloc]
+ }
+ if( !b_found )
+ p_subcategory_item = p_category_item;
+
+ [p_subcategory_item->o_children addObject:[[VLCTreeItem alloc]
initWithName:[[VLCMain sharedInstance]
- localizedString: p_module->psz_shortname ?
- p_module->psz_shortname : p_module->psz_object_name ]
- withTitle:[[VLCMain sharedInstance]
- localizedString: p_module->psz_longname ?
- p_module->psz_longname : p_module->psz_object_name ]
- withHelp: @""
- ID: p_module->i_object_id
- parent:p_subcategory_item
- children:IsALeafNode
- whithCategory: -1]];
+ localizedString: module_GetName( p_module, VLC_FALSE ) ]
+ withTitle:[[VLCMain sharedInstance]
+ localizedString: module_GetLongName( p_module ) ]
+ withHelp: @""
+ ID: ((vlc_object_t*)p_module)->i_object_id
+ parent:p_subcategory_item
+ children:IsALeafNode
+ whithCategory: -1]];
}
+
+ vlc_list_release( p_list );
}
- vlc_list_release( p_list );
- }
+
+
return o_children;
}
{
p_parser = (module_t *)p_list->p_values[i_index].p_object ;
- if( !strcmp( p_parser->psz_object_name, psz_module_name ) )
+ if( !strcmp( module_GetObjName( p_parser ), psz_module_name ) )
{
- BOOL b_has_prefs = p_parser->i_config_items != 0;
+ unsigned int confsize;
+ module_GetConfig( p_parser, &confsize );
+ BOOL b_has_prefs = confsize != 0;
vlc_list_release( p_list );
return( b_has_prefs );
}
NSView *o_view;
[[VLCPrefs sharedInstance] setTitle: [self getTitle]];
- /* NSLog( [self getHelp] ); */
+ /* NSLog( [self getHelp] ); */
s_vrc = [[o_prefs_view contentView] bounds]; s_vrc.size.height -= 4;
o_view = [[VLCFlippedView alloc] initWithFrame: s_vrc];
[o_view setAutoresizingMask: NSViewWidthSizable | NSViewMinYMargin |
intf_thread_t *p_intf = VLCIntf;
vlc_list_t *p_list;
module_t *p_parser = NULL;
- module_config_t *p_item;
+ module_config_t *p_item,
+ *p_end;
+ unsigned int confsize;
o_subviews = [[NSMutableArray alloc] initWithCapacity:10];
/* Get a pointer to the module */
if( i_object_category == -1 )
{
- p_parser = (module_t *) vlc_object_get( p_intf, i_object_id );
- if( !p_parser || p_parser->i_object_type != VLC_OBJECT_MODULE )
+ p_parser = (module_t *) vlc_object_get( i_object_id );
+ if( !p_parser || ((vlc_object_t*)p_parser)->i_object_type != VLC_OBJECT_MODULE )
{
/* 0OOoo something went really bad */
return nil;
}
- p_item = p_parser->p_config;
- int i = 0;
-
- p_item = p_parser->p_config + 1;
+ p_item = module_GetConfig( p_parser, &confsize );
+ p_end = p_item + confsize;
do
{
msg_Err( p_intf, "invalid preference item found" );
break;
}
+ if( p_item > p_end )
+ break;
switch(p_item->i_type)
{
case CONFIG_SUBCATEGORY:
break;
case CONFIG_SECTION:
break;
- case CONFIG_HINT_END:
- break;
case CONFIG_HINT_USAGE:
break;
default:
}
break;
}
- } while( p_item++->i_type != CONFIG_HINT_END );
+ } while( p_item < p_end && p_item++ );
- vlc_object_release( p_parser );
+ vlc_object_release( (vlc_object_t*)p_parser );
}
else
{
- int i = 0;
int i_index;
p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE, FIND_ANYWHERE );
if( !p_list ) return o_view;
for( i_index = 0; i_index < p_list->i_count; i_index++ )
{
p_parser = (module_t *)p_list->p_values[i_index].p_object;
- if( !strcmp( p_parser->psz_object_name, "main" ) )
+ if( !strcmp( module_GetObjName( p_parser ), "main" ) )
break;
}
if( p_parser == NULL )
msg_Err( p_intf, "could not load preferences" );
return o_view;
}
- p_item = (p_parser->p_config + i_object_category);
+ unsigned int confsize;
+ p_item = module_GetConfig( p_parser, &confsize );
+ p_end = p_item + confsize;
+ p_item += i_object_category;
+
if( ( p_item->i_type == CONFIG_CATEGORY ) &&
- ( ( p_item->i_value == CAT_PLAYLIST ) ||
- ( p_item->i_value == CAT_AUDIO ) ||
- ( p_item->i_value == CAT_VIDEO ) ) )
+ ( ( p_item->value.i == CAT_PLAYLIST ) ||
+ ( p_item->value.i == CAT_AUDIO ) ||
+ ( p_item->value.i == CAT_VIDEO ) ||
+ ( p_item->value.i == CAT_INTERFACE ) ||
+ ( p_item->value.i == CAT_INPUT ) ||
+ ( p_item->value.i == CAT_SOUT ) ) )
p_item++;
do
{
p_item++;
- if( !p_item )
+ if( !p_item || !p_item->i_type )
{
msg_Err( p_intf, "invalid preference item found" );
break;
}
+ if( p_item > p_end )
+ break;
switch( p_item->i_type )
{
case CONFIG_SUBCATEGORY:
break;
case CONFIG_SECTION:
break;
- case CONFIG_HINT_END:
- break;
case CONFIG_HINT_USAGE:
break;
default:
break;
}
}
- } while ( ( p_item->i_type != CONFIG_HINT_END ) &&
+ } while ( ( p_item < p_end ) &&
( p_item->i_type != CONFIG_SUBCATEGORY ) );
vlc_list_release( p_list );
NSEnumerator *enumerator = [o_subviews objectEnumerator];
VLCConfigControl *o_widget;
NSRect o_frame;
-
+
while( ( o_widget = [enumerator nextObject] ) )
if( ( [o_widget isAdvanced] ) && (! b_advanced) )
continue;
projects / vlc / blobdiff