]> git.sesse.net Git - vlc/blobdiff - modules/gui/pda/pda.c
Updated PDA interface.
[vlc] / modules / gui / pda / pda.c
index 641980cab638fc00d9cadec1599a7cadaa4683e4..449fcfbb4f1ad6e5a4118c2dee12e2c84103b2cb 100644 (file)
@@ -2,7 +2,7 @@
  * pda.c : PDA Gtk2 plugin for vlc
  *****************************************************************************
  * Copyright (C) 2002 VideoLAN
- * $Id: pda.c,v 1.4 2003/10/03 18:04:58 jpsaman Exp $
+ * $Id: pda.c,v 1.22 2004/02/29 22:59:59 jpsaman Exp $
  *
  * Authors: Jean-Paul Saman <jpsaman@wxs.nl>
  *          Marc Ariberti <marcari@videolan.org>
 
 #include <gtk/gtk.h>
 
-#ifdef HAVE_GPE_INIT_H
-#include <gpe/init.h>
-#endif
-
 #include "pda_callbacks.h"
 #include "pda_interface.h"
 #include "pda_support.h"
@@ -53,7 +49,7 @@ static void Run          ( intf_thread_t * );
 
 void GtkAutoPlayFile     ( vlc_object_t * );
 static int Manage        ( intf_thread_t *p_intf );
-void E_(GtkDisplayDate)  ( GtkAdjustment *p_adj );
+void E_(GtkDisplayDate)  ( GtkAdjustment *p_adj, gpointer userdata );
 gint E_(GtkModeManage)   ( intf_thread_t * p_intf );
 
 /*****************************************************************************
@@ -67,9 +63,8 @@ gint E_(GtkModeManage)   ( intf_thread_t * p_intf );
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
-    add_category_hint( N_("Miscellaneous"), NULL, VLC_TRUE );
+    set_description( N_("PDA Linux Gtk2+ interface") );
 //    add_bool( "pda-autoplayfile", 1, GtkAutoPlayFile, AUTOPLAYFILE_TEXT, AUTOPLAYFILE_LONGTEXT, VLC_TRUE );
-    set_description( _("PDA Linux Gtk2+ interface") );
     set_capability( "interface", 70 );
     set_callbacks( Open, Close );
     add_shortcut( "pda" );
@@ -149,33 +144,29 @@ static void Run( intf_thread_t *p_intf )
     int    i_args   = 1;
     int    i_dummy;
 #endif
-    GtkCellRenderer   *renderer = NULL;
+    playlist_t        *p_playlist;
+    GtkCellRenderer   *p_renderer = NULL;
+    GtkTreeViewColumn *p_column   = NULL;
+    GtkListStore      *p_filelist = NULL;
+    GtkListStore      *p_playlist_store = NULL;
 
-#ifdef HAVE_GPE_INIT_H
-    /* Initialize GPE interface */
-    msg_Dbg( p_intf, "Starting pda GPE interface" );
-    if (gpe_application_init(&i_args, &pp_args) == FALSE)
-        exit (1);
-#else
+#ifndef NEED_GTK2_MAIN
     gtk_set_locale ();
-#   ifndef NEED_GTK2_MAIN
     msg_Dbg( p_intf, "Starting pda GTK2+ interface" );
     gtk_init( &i_args, &pp_args );
-#   else
+#else
     /* Initialize Gtk+ */
-    msg_Dbg( p_intf, "Starting pda GTK+ interface thread" );
+    msg_Dbg( p_intf, "Starting pda GTK2+ interface thread" );
     gdk_threads_enter();
-#   endif
 #endif
 
     /* Create some useful widgets that will certainly be used */
-// FIXME: magic path
+/* FIXME: magic path */
     add_pixmap_directory("share");
     add_pixmap_directory("/usr/share/vlc");
 
     /* Path for pixmaps under linupy 1.4 */
     add_pixmap_directory("/usr/local/share/pixmaps/vlc");
-
     /* Path for pixmaps under linupy 2.0 */
     add_pixmap_directory("/usr/share/pixmaps/vlc");
 
@@ -185,12 +176,9 @@ static void Run( intf_thread_t *p_intf )
         msg_Err( p_intf, "unable to create pda interface" );
     }
 
-#if 0
-    msg_Dbg( p_intf, "setting main window size ... " );
-    gtk_widget_set_usize(p_intf->p_sys->p_window,
-                         gdk_screen_width() , gdk_screen_height() - 30 );
-    msg_Dbg( p_intf, "setting main window size ... done" );
-#endif
+    /* Store p_intf to keep an eye on it */
+    gtk_object_set_data( GTK_OBJECT(p_intf->p_sys->p_window),
+                         "p_intf", p_intf );
 
     /* Set the title of the main window */
     gtk_window_set_title( GTK_WINDOW(p_intf->p_sys->p_window),
@@ -199,102 +187,130 @@ static void Run( intf_thread_t *p_intf )
     /* Get the notebook object */
     p_intf->p_sys->p_notebook = GTK_NOTEBOOK( gtk_object_get_data(
         GTK_OBJECT( p_intf->p_sys->p_window ), "notebook" ) );
-    p_intf->p_sys->p_mediabook = GTK_NOTEBOOK( gtk_object_get_data(
-        GTK_OBJECT( p_intf->p_sys->p_window ), "mediabook" ) );
 
     /* Get the slider object */
-    p_intf->p_sys->p_slider = GTK_HSCALE( gtk_object_get_data(
-        GTK_OBJECT( p_intf->p_sys->p_window ), "slider" ) );
-    p_intf->p_sys->p_slider_label = GTK_LABEL( gtk_object_get_data(
-        GTK_OBJECT( p_intf->p_sys->p_window ), "slider_label" ) );
+    p_intf->p_sys->p_slider = (GtkHScale*) lookup_widget( p_intf->p_sys->p_window, "timeSlider" );
+    p_intf->p_sys->p_slider_label = (GtkLabel*) lookup_widget( p_intf->p_sys->p_window, "timeLabel" );
+    if (p_intf->p_sys->p_slider == NULL)
+        msg_Err( p_intf, "Time slider widget not found." );
+    if (p_intf->p_sys->p_slider_label == NULL)
+        msg_Err( p_intf, "Time label widget not found." );
 
-#if 0
     /* Connect the date display to the slider */
-    msg_Dbg( p_intf, "setting slider adjustment ... " );
-#define P_SLIDER GTK_RANGE( gtk_object_get_data( \
-                         GTK_OBJECT( p_intf->p_sys->p_window ), "slider" ) )
-    p_intf->p_sys->p_adj = gtk_range_get_adjustment( P_SLIDER );
-
-    gtk_signal_connect ( GTK_OBJECT( p_intf->p_sys->p_adj ), "value_changed",
-                         GTK_SIGNAL_FUNC( E_(GtkDisplayDate) ), NULL );
+    p_intf->p_sys->p_adj = gtk_range_get_adjustment( GTK_RANGE(p_intf->p_sys->p_slider) );
+    if (p_intf->p_sys->p_adj == NULL)
+        msg_Err( p_intf, "Adjustment range not found." );
+    g_signal_connect( GTK_OBJECT( p_intf->p_sys->p_adj ), "value_changed",
+                         G_CALLBACK( E_(GtkDisplayDate) ), p_intf );
     p_intf->p_sys->f_adj_oldvalue = 0;
     p_intf->p_sys->i_adj_oldvalue = 0;
-#undef P_SLIDER
-    msg_Dbg( p_intf, "setting slider adjustment ... done" );
-#endif
 
-    /* Get the GtkTreeView filelist object */
-    msg_Dbg(p_intf, "Getting GtkTreeView FileList" );
+    /* BEGIN OF FILEVIEW GTK_TREE_VIEW */
     p_intf->p_sys->p_tvfile = NULL;
     p_intf->p_sys->p_tvfile = (GtkTreeView *) lookup_widget( p_intf->p_sys->p_window,
                                                              "tvFileList");
     if (NULL == p_intf->p_sys->p_tvfile)
        msg_Err(p_intf, "Error obtaining pointer to File List");
+
+    /* Insert columns 0 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 0, (gchar *) N_("Filename"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvfile, 0 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 0 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 0);
+    /* Insert columns 1 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 1, (gchar *) N_("Permissions"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvfile, 1 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 1 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 1);
+    /* Insert columns 2 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 2, (gchar *) N_("Size"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvfile, 2 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 2 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 2);
+    /* Insert columns 3 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 3, (gchar *) N_("Owner"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvfile, 3 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 3 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 3);
+    /* Insert columns 4 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 4, (gchar *) N_("Group"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvfile, 4 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 4 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 4);
+
     /* Get new directory listing */
-    msg_Dbg(p_intf, "Populating GtkTreeView FileList" );
-    p_intf->p_sys->p_filelist = gtk_list_store_new (5,
-                               G_TYPE_STRING, /* Filename */
-                               G_TYPE_STRING, /* permissions */
-                               G_TYPE_STRING, /* File size */
-                               G_TYPE_STRING, /* Owner */
-                               G_TYPE_STRING);/* Group */
-    ReadDirectory(p_intf, p_intf->p_sys->p_filelist, ".");
-    msg_Dbg(p_intf, "Showing GtkTreeView FileList" );
-    gtk_tree_view_set_model(p_intf->p_sys->p_tvfile, GTK_TREE_MODEL(p_intf->p_sys->p_filelist));
-    /* Insert columns */
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 0, _("Filename"), renderer, NULL);
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 1, _("Permissions"), renderer, NULL);
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 2, _("Size"), renderer, NULL);
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 3, _("Owner"), renderer, NULL);
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvfile, 4, _("Group"), renderer, NULL);
+    p_filelist = gtk_list_store_new (5,
+                G_TYPE_STRING, /* Filename */
+                G_TYPE_STRING, /* permissions */
+                G_TYPE_UINT64, /* File size */
+                G_TYPE_STRING, /* Owner */
+                G_TYPE_STRING);/* Group */
+    ReadDirectory(p_intf, p_filelist, ".");
+    gtk_tree_view_set_model(GTK_TREE_VIEW(p_intf->p_sys->p_tvfile), GTK_TREE_MODEL(p_filelist));
+    g_object_unref(p_filelist);     /* Model will be released by GtkTreeView */
+    gtk_tree_selection_set_mode(gtk_tree_view_get_selection(GTK_TREE_VIEW(p_intf->p_sys->p_tvfile)),GTK_SELECTION_MULTIPLE);
+
     /* Column properties */
     gtk_tree_view_set_headers_visible(p_intf->p_sys->p_tvfile, TRUE);
     gtk_tree_view_columns_autosize(p_intf->p_sys->p_tvfile);
-    gtk_tree_view_set_headers_clickable(p_intf->p_sys->p_tvfile,TRUE);
+    gtk_tree_view_set_headers_clickable(GTK_TREE_VIEW(p_intf->p_sys->p_tvfile),TRUE);
+    /* END OF FILEVIEW GTK_TREE_VIEW */
 
-    /* Get the GtkTreeView playlist object */
-    msg_Dbg(p_intf, "Getting GtkTreeView PlayList" );
+    /* BEGIN OF PLAYLIST GTK_TREE_VIEW */
     p_intf->p_sys->p_tvplaylist = NULL;
-    p_intf->p_sys->p_tvplaylist = (GtkTreeView *) lookup_widget( p_intf->p_sys->p_window,
-                                                             "tvPlaylist");   
+    p_intf->p_sys->p_tvplaylist = (GtkTreeView *) lookup_widget( p_intf->p_sys->p_window, "tvPlaylist");
     if (NULL == p_intf->p_sys->p_tvplaylist)
        msg_Err(p_intf, "Error obtaining pointer to Play List");
-    /* Insert columns */
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvplaylist, 0, _("Filename"), renderer, NULL);
-    renderer = gtk_cell_renderer_text_new ();
-    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvplaylist, 1, _("Time"), renderer, NULL);
+
+    /* Columns 1 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvplaylist, 0, (gchar *) N_("Filename"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvplaylist, 0 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 0 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 0);
+    /* Column 2 */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvplaylist, 1, (gchar *) N_("Time"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvplaylist, 1 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 1 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 1);
+#if 0
+    /* Column 3 - is a hidden column used for reliable deleting items from the underlying playlist */
+    p_renderer = gtk_cell_renderer_text_new ();
+    gtk_tree_view_insert_column_with_attributes(p_intf->p_sys->p_tvplaylist, 2, (gchar *) N_("Index"), p_renderer, NULL);
+    p_column = gtk_tree_view_get_column(p_intf->p_sys->p_tvplaylist, 2 );
+    gtk_tree_view_column_add_attribute(p_column, p_renderer, "text", 2 );
+    gtk_tree_view_column_set_sort_column_id(p_column, 2);
+#endif
     /* update the playlist */
-    msg_Dbg(p_intf, "Populating GtkTreeView Playlist" );
-    p_intf->p_sys->p_playlist = gtk_list_store_new (2,
-                               G_TYPE_STRING, /* Filename */
-                               G_TYPE_STRING);/* Time */
-    PlaylistRebuildListStore( p_intf->p_sys->p_playlist, vlc_object_find( p_intf, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE ));
-    msg_Dbg(p_intf, "Showing GtkTreeView Playlist" );
-    gtk_tree_view_set_model(p_intf->p_sys->p_tvplaylist, GTK_TREE_MODEL(p_intf->p_sys->p_playlist));
+    p_playlist = vlc_object_find( p_intf, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
+    p_playlist_store = gtk_list_store_new (3,
+                G_TYPE_STRING, /* Filename */
+                G_TYPE_STRING, /* Time */
+                G_TYPE_UINT);  /* Hidden index */
+    PlaylistRebuildListStore(p_playlist_store, p_playlist);
+    gtk_tree_view_set_model(GTK_TREE_VIEW(p_intf->p_sys->p_tvplaylist), GTK_TREE_MODEL(p_playlist_store));
+    g_object_unref(p_playlist_store);
+    vlc_object_release(p_playlist); /* Free the playlist */
+    gtk_tree_selection_set_mode(gtk_tree_view_get_selection(GTK_TREE_VIEW(p_intf->p_sys->p_tvplaylist)),GTK_SELECTION_MULTIPLE);
+
     /* Column properties */
     gtk_tree_view_set_headers_visible(p_intf->p_sys->p_tvplaylist, TRUE);
     gtk_tree_view_columns_autosize(p_intf->p_sys->p_tvplaylist);
     gtk_tree_view_set_headers_clickable(p_intf->p_sys->p_tvplaylist, TRUE);
+    /* END OF PLAYLIST GTK_TREE_VIEW */
 
-    p_intf->p_sys->p_mrlentry = GTK_ENTRY( gtk_object_get_data(
-        GTK_OBJECT( p_intf->p_sys->p_window ), "mrl_entry" ) );
+    /* Hide the Preference TAB for now. */
+    GtkWidget *p_preference_tab = NULL;
+    p_preference_tab = gtk_notebook_get_nth_page(p_intf->p_sys->p_notebook,5);
+    if (p_preference_tab != NULL)
+      gtk_widget_hide(p_preference_tab);
 
-#if 0
-    /* Store p_intf to keep an eye on it */
-    msg_Dbg( p_intf, "trying to store p_intf pointer ... " );
-    gtk_object_set_data( GTK_OBJECT(p_intf->p_sys->p_window),
-                         "p_intf", p_intf );
-    gtk_object_set_data( GTK_OBJECT(p_intf->p_sys->p_adj),
-                         "p_intf", p_intf );
-    msg_Dbg( p_intf, "trying to store p_intf pointer ... done" );
-#endif
-    
     /* Show the control window */
     gtk_widget_show( p_intf->p_sys->p_window );
 
@@ -412,29 +428,30 @@ static int Manage( intf_thread_t *p_intf )
                 p_intf->p_sys->b_playing = 1;
 
                 /* update playlist interface */
-                p_playlist = (playlist_t *) vlc_object_find( 
+                p_playlist = (playlist_t *) vlc_object_find(
                         p_intf, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
                 if (p_playlist != NULL)
                 {
-                    msg_Dbg(p_intf, "Manage: Populating GtkTreeView Playlist" );
-                    p_liststore = gtk_list_store_new (2,
+                    p_liststore = gtk_list_store_new (3,
+                                               G_TYPE_STRING,
                                                G_TYPE_STRING,
-                                               G_TYPE_STRING);
+                                               G_TYPE_UINT);  /* Hidden index */
                     PlaylistRebuildListStore(p_liststore, p_playlist);
-                    msg_Dbg(p_intf, "Manage: Updating GtkTreeView Playlist" );
                     gtk_tree_view_set_model(p_intf->p_sys->p_tvplaylist, (GtkTreeModel*) p_liststore);
+                    g_object_unref(p_liststore);
+                    vlc_object_release( p_playlist );
                 }
             }
 
             /* Manage the slider */
+#define p_area p_input->stream.p_selected_area
             if (p_intf->p_libvlc->i_cpu & CPU_CAPABILITY_FPU)
             {
-                /* Manage the slider for CPU_CAPABILITY_FPU hardware */        
+                /* Manage the slider for CPU_CAPABILITY_FPU hardware */
                 if( p_input->stream.b_seekable && p_intf->p_sys->b_playing )
                 {
                     float newvalue = p_intf->p_sys->p_adj->value;
 
-#define p_area p_input->stream.p_selected_area
                     /* If the user hasn't touched the slider since the last time,
                      * then the input can safely change it */
                     if( newvalue == p_intf->p_sys->f_adj_oldvalue )
@@ -443,7 +460,7 @@ static int Manage( intf_thread_t *p_intf )
                         p_intf->p_sys->p_adj->value =
                         p_intf->p_sys->f_adj_oldvalue =
                             ( 100. * p_area->i_tell ) / p_area->i_size;
-                        gtk_signal_emit_by_name( GTK_OBJECT( p_intf->p_sys->p_adj ),
+                        g_signal_emit_by_name( GTK_OBJECT( p_intf->p_sys->p_adj ),
                                                  "value_changed" );
                     }
                     /* Otherwise, send message to the input if the user has
@@ -460,7 +477,6 @@ static int Manage( intf_thread_t *p_intf )
                         /* Update the old value */
                         p_intf->p_sys->f_adj_oldvalue = newvalue;
                     }
-#undef p_area
                 }
             }
             else
@@ -470,7 +486,6 @@ static int Manage( intf_thread_t *p_intf )
                 {
                     off_t newvalue = p_intf->p_sys->p_adj->value;
 
-#define p_area p_input->stream.p_selected_area
                     /* If the user hasn't touched the slider since the last time,
                      * then the input can safely change it */
                     if( newvalue == p_intf->p_sys->i_adj_oldvalue )
@@ -479,7 +494,7 @@ static int Manage( intf_thread_t *p_intf )
                         p_intf->p_sys->p_adj->value =
                         p_intf->p_sys->i_adj_oldvalue =
                             ( 100 * p_area->i_tell ) / p_area->i_size;
-                        gtk_signal_emit_by_name( GTK_OBJECT( p_intf->p_sys->p_adj ),
+                        g_signal_emit_by_name( GTK_OBJECT( p_intf->p_sys->p_adj ),
                                                  "value_changed" );
                     }
                     /* Otherwise, send message to the input if the user has
@@ -496,9 +511,9 @@ static int Manage( intf_thread_t *p_intf )
                         /* Update the old value */
                         p_intf->p_sys->i_adj_oldvalue = newvalue;
                     }
-#undef p_area
                 }
             }
+#undef p_area
         }
         vlc_mutex_unlock( &p_input->stream.stream_lock );
     }
@@ -532,16 +547,18 @@ static int Manage( intf_thread_t *p_intf )
  * the stream. It is called whenever the slider changes its value.
  * The lock has to be taken before you call the function.
  *****************************************************************************/
-void E_(GtkDisplayDate)( GtkAdjustment *p_adj )
+void E_(GtkDisplayDate)( GtkAdjustment *p_adj, gpointer userdata )
 {
     intf_thread_t *p_intf;
 
-    p_intf = gtk_object_get_data( GTK_OBJECT( p_adj ), "p_intf" );
+    p_intf = (intf_thread_t*) userdata;
+    if (p_intf == NULL)
+        return;
 
     if( p_intf->p_sys->p_input )
     {
 #define p_area p_intf->p_sys->p_input->stream.p_selected_area
-        char psz_time[ OFFSETTOTIME_MAX_SIZE ];
+        char psz_time[ MSTRTIME_MAX_SIZE ];
 
         gtk_label_set_text( GTK_LABEL( p_intf->p_sys->p_slider_label ),
                         input_OffsetToTime( p_intf->p_sys->p_input, psz_time,
@@ -558,15 +575,15 @@ void E_(GtkDisplayDate)( GtkAdjustment *p_adj )
  *****************************************************************************/
 gint E_(GtkModeManage)( intf_thread_t * p_intf )
 {
-    GtkWidget *     p_slider;
+    GtkWidget *     p_slider = NULL;
     vlc_bool_t      b_control;
 
-#define GETWIDGET( ptr, name ) GTK_WIDGET( gtk_object_get_data( GTK_OBJECT( \
-                           p_intf->p_sys->ptr ) , ( name ) ) )
-    /* hide slider */
-    p_slider = GTK_WIDGET( gtk_object_get_data( GTK_OBJECT(
-                           p_intf->p_sys->p_window ), "slider" ) );
-    gtk_widget_hide( GTK_WIDGET( p_slider ) );
+    if ( p_intf->p_sys->p_window == NULL )
+        msg_Err( p_intf, "Main widget not found" );
+
+    p_slider = lookup_widget( p_intf->p_sys->p_window, "timeSlider");
+    if (p_slider == NULL)
+        msg_Err( p_intf, "Slider widget not found" );
 
     /* controls unavailable */
     b_control = 0;
@@ -577,14 +594,13 @@ gint E_(GtkModeManage)( intf_thread_t * p_intf )
         /* initialize and show slider for seekable streams */
         if( p_intf->p_sys->p_input->stream.b_seekable )
         {
-            if (p_intf->p_libvlc->i_cpu & CPU_CAPABILITY_FPU)
-                p_intf->p_sys->p_adj->value = p_intf->p_sys->f_adj_oldvalue = 0;
-            else
-                p_intf->p_sys->p_adj->value = p_intf->p_sys->i_adj_oldvalue = 0;
-            gtk_signal_emit_by_name( GTK_OBJECT( p_intf->p_sys->p_adj ),
-                                     "value_changed" );
             gtk_widget_show( GTK_WIDGET( p_slider ) );
         }
+        else
+        {
+            /* hide slider */
+            gtk_widget_hide( GTK_WIDGET( p_slider ) );
+        }
 
         /* control buttons for free pace streams */
         b_control = p_intf->p_sys->p_input->stream.b_pace_control;
@@ -594,11 +610,9 @@ gint E_(GtkModeManage)( intf_thread_t * p_intf )
     }
 
     /* set control items */
-    gtk_widget_set_sensitive( GETWIDGET(p_window, "tbRewind"), b_control );
-    gtk_widget_set_sensitive( GETWIDGET(p_window, "tbPause"), b_control );
-    gtk_widget_set_sensitive( GETWIDGET(p_window, "tbForward"), b_control );
-
-#undef GETWIDGET
+    gtk_widget_set_sensitive( lookup_widget( p_intf->p_sys->p_window, "tbRewind"), b_control );
+    gtk_widget_set_sensitive( lookup_widget( p_intf->p_sys->p_window, "tbPause"), b_control );
+    gtk_widget_set_sensitive( lookup_widget( p_intf->p_sys->p_window, "tbForward"), b_control );
     return TRUE;
 }