]> git.sesse.net Git - vlc/blobdiff - modules/gui/qt4/components/simple_preferences.cpp
Qt4 - Getting rid of useless setCheckState( Qt::Checked ) when setChecked is enough...
[vlc] / modules / gui / qt4 / components / simple_preferences.cpp
index eef694ad8b5a253424cda601711f59a434bfe976..797e0ee9a7648e24ab4c77aed150f32fca589cac 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * simple_preferences.cpp : "Simple preferences"
  ****************************************************************************
- * Copyright (C) 2006 the VideoLAN team
+ * Copyright (C) 2006-2007 the VideoLAN team
  * $Id: preferences.cpp 16348 2006-08-25 21:10:10Z zorglub $
  *
  * Authors: ClĂ©ment Stenac <zorglub@videolan.org>
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
-#include <QString>
-#include <QFont>
-#include <QToolButton>
-#include <QButtonGroup>
-#include <QUrl>
-
 #include "components/simple_preferences.hpp"
 #include "components/preferences_widgets.hpp"
-#include "qt4.hpp"
 
 #include <vlc_config_cat.h>
+#include <vlc_configuration.h>
 
-#include "ui/sprefs_audio.h"
-#include "ui/sprefs_input.h"
-#include "ui/sprefs_video.h"
-#include "ui/sprefs_subtitles.h"
-#include "ui/sprefs_hotkeys.h"
-#include "ui/sprefs_interface.h"
+#include <QString>
+#include <QFont>
+#include <QToolButton>
+#include <QButtonGroup>
+#include <QUrl>
+#include <QVBoxLayout>
 
 #define ICON_HEIGHT 64
-#define BUTTON_HEIGHT 76
+#define BUTTON_HEIGHT 74
 
 /*********************************************************************
  * The List of categories
@@ -99,10 +93,11 @@ void SPrefsCatList::switchPanel( int i )
  * The Panels
  *********************************************************************/
 SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
-                          int number ) : QWidget( _parent ), p_intf( _p_intf )
+                          int _number ) : QWidget( _parent ), p_intf( _p_intf )
 {
     module_config_t *p_config;
     ConfigControl *control;
+    number = _number;
 
 #define CONFIG_GENERIC( option, type, label, qcontrol )                   \
             p_config =  config_FindConfig( VLC_OBJECT(p_intf), option );  \
@@ -135,9 +130,9 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
 #define START_SPREFS_CAT( name , label )    \
         case SPrefs ## name:                \
         {                                   \
-            Ui::SPrefs ## name ui;          \
+            Ui::SPrefs ## name ui;      \
             ui.setupUi( panel );            \
-            panel_label->setText( qtr( label ) );
+            panel_label->setText( label );
 
 #define END_SPREFS_CAT      \
             break;          \
@@ -164,24 +159,25 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
 
     switch( number )
     {
-        /* Video Panel Implementation */
-        START_SPREFS_CAT( Video , "General video settings" );
-         #ifndef WIN32
-            ui.directXBox->setVisible( false );
-         #endif
+        /******************************
+         * VIDEO Panel Implementation *
+         ******************************/
+        START_SPREFS_CAT( Video , qtr("General video settings") );
             CONFIG_GENERIC( "video", Bool, NULL, enableVideo );
 
             CONFIG_GENERIC( "fullscreen", Bool, NULL, fullscreen );
             CONFIG_GENERIC( "overlay", Bool, NULL, overlay );
             CONFIG_GENERIC( "video-on-top", Bool, NULL, alwaysOnTop );
             CONFIG_GENERIC( "video-deco", Bool, NULL, windowDecorations );
-            CONFIG_GENERIC( "skip-frames" , Bool, NULL, skipFrames);
+            CONFIG_GENERIC( "skip-frames" , Bool, NULL, skipFrames );
             CONFIG_GENERIC( "vout", Module, NULL, outputModule );
 
 #ifdef WIN32
             CONFIG_GENERIC( "directx-wallpaper" , Bool , NULL, wallpaperMode );
-            CONFIG_GENERIC( "directx-device", StringList, NULL, 
-                    dXdisplayDevice );
+            CONFIG_GENERIC( "directx-device", StringList, NULL,
+                            dXdisplayDevice );
+#else
+            ui.directXBox->setVisible( false );
 #endif
 
             CONFIG_GENERIC_FILE( "snapshot-path", Directory, NULL,
@@ -193,100 +189,234 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
                             snapshotsFormat );
          END_SPREFS_CAT;
 
-         /* Audio Panel Implementation */
-        START_SPREFS_CAT( Audio,  "General audio settings" );
+        /******************************
+         * AUDIO Panel Implementation *
+         ******************************/
+        START_SPREFS_CAT( Audio, qtr("General audio settings") );
+
+            CONFIG_GENERIC( "audio", Bool, NULL, enableAudio );
+
+            /* and hide if necessary */
+
 #ifdef WIN32
-            ui.OSSBrowse->hide();
-            ui.OSSDevice->hide();
-            ui.OSSLabel->hide();
-            ui.alsaDevice->hide();
-            ui.alsaLabel->hide();
+            ui.OSSControl->hide();
+            ui.alsaControl->hide();
 #else
-            ui.DirectXLabel->setVisible( false );
-            ui.DirectXDevice->setVisible( false );
+            ui.DirectXControl->hide();
 #endif
-         CONFIG_GENERIC( "audio", Bool, NULL, enableAudio );
+            ui.lastfm_user_edit->hide();
+            ui.lastfm_user_label->hide();
+            ui.lastfm_pass_edit->hide();
+            ui.lastfm_pass_label->hide();
+
+            /* General Audio Options */
+            CONFIG_GENERIC_NO_BOOL( "volume" , IntegerRangeSlider, NULL,
+                                     defaultVolume );
+            CONFIG_GENERIC( "audio-language" , String , NULL,
+                            preferredAudioLanguage );
+
+            CONFIG_GENERIC( "spdif", Bool, NULL, spdifBox );
+            CONFIG_GENERIC( "force-dolby-surround" , IntegerList , NULL,
+                            detectionDolby );
+
+            CONFIG_GENERIC( "headphone-dolby" , Bool , NULL, headphoneEffect );
 
-         CONFIG_GENERIC_NO_BOOL( "volume" ,  IntegerRangeSlider, NULL, 
-                 defaultVolume );
-         CONFIG_GENERIC( "audio-language" , StringList , NULL, 
-                    preferredAudioLanguage ); //FIXME
+            CONFIG_GENERIC_NO_BOOL( "norm-max-level" , Float , NULL,
+                                    volNormSpin );
+            CONFIG_GENERIC( "audio-visual" , Module , NULL, visualisation);
 
-         CONFIG_GENERIC( "spdif" , Bool , NULL, spdifBox );
-         CONFIG_GENERIC( "force-dolby-surround" , IntegerList , NULL, 
-                    detectionDolby );
+            /* Audio Output Specifics */
+            CONFIG_GENERIC( "aout", Module, NULL, outputModule );
 
-         CONFIG_GENERIC( "aout" , Module , NULL, outputModule );
+            CONNECT( ui.outputModule, currentIndexChanged( int ), this,
+                             updateAudioOptions( int ) );
+
+        //TODO: use modules_Exists
 #ifndef WIN32
-         CONFIG_GENERIC( "alsadev" , StringList , NULL, alsaDevice );
-         CONFIG_GENERIC_FILE( "dspdev" , File , NULL, OSSDevice, OSSBrowse );
+            CONFIG_GENERIC( "alsadev" , StringList , ui.alsaLabel, alsaDevice );
+            CONFIG_GENERIC_FILE( "dspdev" , File , ui.OSSLabel, OSSDevice,
+                                 OSSBrowse );
 #else
-         CONFIG_GENERIC( "directx-audio-device" , IntegerList, NULL, 
-                 DirectXDevice );
+            CONFIG_GENERIC( "directx-audio-device", IntegerList,
+                    ui.DirectXLabel, DirectXDevice );
 #endif
-         CONFIG_GENERIC_FILE( "audiofile-file" , File , NULL, FileName, 
-                 fileBrowseButton );
-
-         CONFIG_GENERIC( "headphone-dolby" , Bool , NULL, headphoneEffect );
-//         CONFIG_GENERIC( "" , Bool, NULL, ); activation of normalizer //FIXME
-         CONFIG_GENERIC_NO_BOOL( "norm-max-level" , Float , NULL, 
-                 volNormalizer );
-         CONFIG_GENERIC( "audio-visual" , Module , NULL, visualisation);
-        END_SPREFS_CAT;
+        // File exists everywhere
+            CONFIG_GENERIC_FILE( "audiofile-file" , File , ui.fileLabel,
+                                 fileName, fileBrowseButton );
+
+            optionWidgets.append( ui.alsaControl );
+            optionWidgets.append( ui.OSSControl );
+            optionWidgets.append( ui.DirectXControl );
+            optionWidgets.append( ui.fileControl );
+            optionWidgets.append( ui.outputModule );
+            optionWidgets.append( ui.volNormBox );
+            updateAudioOptions( ui.outputModule->currentIndex() );
+
+            /* LastFM */
+            if( module_Exists( p_intf, "Audioscrobbler" ) )
+            {
+                CONFIG_GENERIC( "lastfm-username", String, ui.lastfm_user_label,
+                        lastfm_user_edit );
+                CONFIG_GENERIC( "lastfm-password", String, ui.lastfm_pass_label,
+                        lastfm_pass_edit );
+
+                if( config_ExistIntf( VLC_OBJECT( p_intf ), "audioscrobbler" ) )
+                    ui.lastfm->setChecked( true );
+                else
+                    ui.lastfm->setChecked( false );
+                CONNECT( ui.lastfm, stateChanged( int ), this ,
+                        lastfm_Changed( int ) );
+            }
 
-        /* Input and Codecs Panel Implementation */
-        START_SPREFS_CAT( InputAndCodecs, "Input & Codecs settings"  );
-          /* Disk Devices */
-/*          CONFIG_GENERIC( );*/ //FIXME
+            /* Normalizer */
 
-          CONFIG_GENERIC_NO_BOOL( "server-port", Integer, NULL, UDPPort );
-          CONFIG_GENERIC( "http-proxy", String , NULL, proxy );
+            CONNECT( ui.volNormBox, toggled( bool ), ui.volNormSpin,
+                     setEnabled( bool ) );
+            qs_filter = qfu( config_GetPsz( p_intf, "audio-filter" ) );
+            bool b_normalizer = ( qs_filter.contains( "volnorm" ) );
+            {
+                ui.volNormBox->setChecked( b_normalizer );
+                ui.volNormSpin->setEnabled( b_normalizer );
+            }
 
-          /* Caching */
-/*          CONFIG_GENERIC( );*/ //FIXME
+        END_SPREFS_CAT;
 
-          CONFIG_GENERIC_NO_BOOL( "ffmpeg-pp-q", Integer, NULL, PostProcLevel );
-          CONFIG_GENERIC( "avi-index", IntegerList, NULL, AviRepair );
-          CONFIG_GENERIC( "rtsp-tcp", Bool, NULL, RTSP_TCPBox );
+        /* Input and Codecs Panel Implementation */
+        START_SPREFS_CAT( InputAndCodecs, qtr("Input & Codecs settings") );
+
+            /* Disk Devices */
+            {
+                ui.DVDDevice->setToolTip(
+                    //BUG: make this sentence understandable
+                    qtr( "If this property is blank, then you have\n"
+                         "values for DVD, VCD, and CDDA.\n"
+                         "You can define a unique one or set that in"
+                         "the advanced preferences" ) );
+                char *psz_dvddiscpath = config_GetPsz( p_intf, "dvd" );
+                char *psz_vcddiscpath = config_GetPsz( p_intf, "vcd" );
+                char *psz_cddadiscpath = config_GetPsz( p_intf, "cd-audio" );
+                if( ( *psz_cddadiscpath == *psz_dvddiscpath )
+                   && ( *psz_dvddiscpath == *psz_vcddiscpath ) )
+                {
+                    ui.DVDDevice->setText( qfu( psz_dvddiscpath ) );
+                }
+                delete psz_cddadiscpath; delete psz_dvddiscpath;
+                delete psz_vcddiscpath;
+            }
 
-          CONFIG_GENERIC( "timeshift-force", Bool, NULL, timeshiftBox );
-          CONFIG_GENERIC( "dump-force", Bool, NULL, DumpBox );
-//        CONFIG_GENERIC( "", Bool, NULL, RecordBox ); //FIXME activate record 
-        END_SPREFS_CAT;
+            CONFIG_GENERIC_NO_BOOL( "server-port", Integer, NULL, UDPPort );
+            CONFIG_GENERIC( "http-proxy", String , NULL, proxy );
+            CONFIG_GENERIC_NO_BOOL( "ffmpeg-pp-q", Integer, NULL, PostProcLevel );
+            CONFIG_GENERIC( "avi-index", IntegerList, NULL, AviRepair );
+            CONFIG_GENERIC( "rtsp-tcp", Bool, NULL, RTSP_TCPBox );
+#ifdef WIN32
+            CONFIG_GENERIC( "prefer-system-codecs", Bool, NULL, systemCodecBox );
+#else
+            ui.systemCodecBox->hide();
+#endif
+            /* Access Filters */
+            qs_filter = qfu( config_GetPsz( p_intf, "access-filter" ) );
+            ui.timeshiftBox->setChecked( qs_filter.contains( "timeshift" ) );
+            ui.dumpBox->setChecked( qs_filter.contains( "dump" ) );
+            ui.recordBox->setChecked( qs_filter.contains( "record" ) );
+            ui.bandwidthBox->setChecked( qs_filter.contains( "bandwidth" ) );
+
+            optionWidgets.append( ui.recordBox );
+            optionWidgets.append( ui.dumpBox );
+            optionWidgets.append( ui.bandwidthBox );
+            optionWidgets.append( ui.timeshiftBox );
+            optionWidgets.append( ui.DVDDevice );
+            optionWidgets.append( ui.cachingCombo );
+
+            /* Caching */
+            /* Add the things to the ComboBox */
+            #define addToCachingBox( str, cachingNumber ) \
+                ui.cachingCombo->addItem( str, QVariant( cachingNumber ) );
+            addToCachingBox( "Custom", CachingCustom );
+            addToCachingBox( "Lowest latency", CachingLowest );
+            addToCachingBox( "Low latency", CachingLow );
+            addToCachingBox( "Normal", CachingNormal );
+            addToCachingBox( "High latency", CachingHigh );
+            addToCachingBox( "Higher latency", CachingHigher );
+
+#define TestCaC( name ) \
+    b_cache_equal =  b_cache_equal && ( i_cache == config_GetInt( p_intf, name ) );
+
+#define TestCaCi( name, int ) \
+    b_cache_equal = b_cache_equal &&  \
+    ( ( i_cache * int ) == config_GetInt( p_intf, name ) );
+            /* Select the accurate value of the ComboBox */
+            bool b_cache_equal = true;
+            int i_cache = config_GetInt( p_intf, "file-caching");
+
+            TestCaC( "udp-caching" ) TestCaC( "dvdread-caching" )
+            TestCaC( "dvdnav-caching" ) TestCaC( "tcp-caching" )
+            TestCaC( "fake-caching" ) TestCaC( "cdda-caching" )
+            TestCaC( "screen-caching" ) TestCaC( "vcd-caching" )
+            #ifdef WIN32
+            TestCaC( "dshow-caching" )
+            #else
+            TestCaC( "v4l-caching" ) TestCaC( "jack-input-caching" )
+            TestCaC( "v4l2-caching" ) TestCaC( "pvr-caching" )
+            #endif
+            TestCaCi( "rtsp-caching", 4 ) TestCaCi( "ftp-caching", 2 )
+            TestCaCi( "http-caching", 4 ) TestCaCi( "realrtsp-caching", 10 )
+            TestCaCi( "mms-caching", 19 )
+            if( b_cache_equal ) ui.cachingCombo->setCurrentIndex(
+                ui.cachingCombo->findData( QVariant( i_cache ) ) );
 
-        /* Interface Panel */
-        START_SPREFS_CAT( Interface, "Interface settings" );
+        END_SPREFS_CAT;
+        /*******************
+         * Interface Panel *
+         *******************/
+        START_SPREFS_CAT( Interface, qtr("Interface settings") );
             ui.defaultLabel->setFont( italicFont );
             ui.skinsLabel->setFont( italicFont );
 
-            CONFIG_GENERIC( "language", StringList, NULL, language );//FIXME
-#if !defined( WIN32 ) && !defined( HAVE_DBUS_3 )
-            ui.OneInterfaceBox->hide();
+#if defined( WIN32 ) || defined (__APPLE__)
+            CONFIG_GENERIC( "language", StringList, NULL, language );
+#else
+            ui.language->hide();
+            ui.languageLabel->hide();
 #endif
+
             /* interface */
-/*            p_config = config_FindConfig( VLC_OBJECT(p_intf), "intf" );
-            if( p_config->value.psz && strcmp( p_config->value.psz, "qt4" ))
+            char *psz_intf = config_GetPsz( p_intf, "intf" );
+            if( psz_intf )
+            {
+                msg_Dbg( p_intf, "Interface in config file: %s", psz_intf );
+                if( strstr( psz_intf, "skin" ) )
+                    ui.skins->setChecked( true );
+                else if( strstr( psz_intf, "qt" ) )
                     ui.qt4->setChecked( true );
-            if( p_config->value.psz && strcmp( p_config->value.psz, "skins2" ))
-                    ui.skins->setChecked( true );*/
-/*            CONFIG_GENERIC( "intf", Module, NULL, ??? ); */ //FIXME interface choice
+            }
+            delete psz_intf;
+
+            optionWidgets.append( ui.skins );
+            optionWidgets.append( ui.qt4 );
+
+            CONFIG_GENERIC( "album-art", IntegerList, ui.artFetchLabel, artFetcher );
+            CONFIG_GENERIC( "fetch-meta", Bool, NULL, metaFetcher );
+            CONFIG_GENERIC( "qt-updates-notif", Bool, NULL, qtUpdates );
             CONFIG_GENERIC( "qt-always-video", Bool, NULL, qtAlwaysVideo );
-            CONFIG_GENERIC_FILE( "skins2-last", File, NULL, fileSkin, 
+            CONFIG_GENERIC_FILE( "skins2-last", File, NULL, fileSkin,
                     skinBrowse );
-#if defined( WIN32 ) || defined(HAVE_DBUS_3)
+#if defined( WIN32 ) || defined( HAVE_DBUS_3 )
             CONFIG_GENERIC( "one-instance", Bool, NULL, OneInterfaceMode );
-            CONFIG_GENERIC( "playlist-enqueue", Bool, NULL, 
+            CONFIG_GENERIC( "playlist-enqueue", Bool, NULL,
                     EnqueueOneInterfaceMode );
+#else
+            ui.OneInterfaceBox->hide();
 #endif
         END_SPREFS_CAT;
 
-        START_SPREFS_CAT( Subtitles, "Subtitles & OSD settings" );
+        START_SPREFS_CAT( Subtitles, qtr("Subtitles & OSD settings") );
             CONFIG_GENERIC( "osd", Bool, NULL, OSDBox);
 
             CONFIG_GENERIC( "subsdec-encoding", StringList, NULL, encoding );
-            CONFIG_GENERIC( "sub-language", String, NULL, preferredLanguage );//FIXME
-            CONFIG_GENERIC_FILE( "freetype-font", File, NULL, font, 
-                    fontBrowse ); 
+            CONFIG_GENERIC( "sub-language", String, NULL, preferredLanguage );
+            CONFIG_GENERIC_FILE( "freetype-font", File, NULL, font,
+                            fontBrowse );
             CONFIG_GENERIC( "freetype-color", IntegerList, NULL, fontColor );
             CONFIG_GENERIC( "freetype-rel-fontsize", IntegerList, NULL,
                             fontSize );
@@ -294,29 +424,166 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
 
         END_SPREFS_CAT;
 
-        START_SPREFS_CAT( Hotkeys, "Configure Hotkeys" );
-        //FIMXE
-        END_SPREFS_CAT;
+        case SPrefsHotkeys:
+        {
+            p_config = config_FindConfig( VLC_OBJECT(p_intf), "key-fullscreen" );
+
+            QGridLayout *gLayout = new QGridLayout;
+            panel->setLayout( gLayout );
+            int line = 0;
+
+            KeySelectorControl *ksCtrl =
+                        new KeySelectorControl( VLC_OBJECT(p_intf), p_config ,
+                                                this, gLayout, line );
+
+            panel_label->setText( qtr( "Configure Hotkeys" ) );
+
+            break;
         }
+    }
 
-    panel_layout->addWidget(panel_label);
-    panel_layout->addWidget(title_line);
+    panel_layout->addWidget( panel_label );
+    panel_layout->addWidget( title_line );
     panel_layout->addWidget( panel );
-    panel_layout->addStretch( 2 );
+    if( number != SPrefsHotkeys ) panel_layout->addStretch( 2 );
 
-    this->setLayout(panel_layout);
+    setLayout( panel_layout );
 }
 
+void SPrefsPanel::updateAudioOptions( int number)
+{
+    QString value = qobject_cast<QComboBox *>(optionWidgets[audioOutCoB])
+                                            ->itemData( number ).toString();
+
+#ifndef WIN32
+    optionWidgets[ossW]->setVisible( ( value == "oss" ) );
+    optionWidgets[alsaW]->setVisible( ( value == "alsa" ) );
+#else
+    optionWidgets[directxW]->setVisible( ( value == "directx" ) );
+#endif
+    optionWidgets[fileW]->setVisible( ( value == "aout_file" ) );
+}
+
+/* Function called from the main Preferences dialog on each SPrefs Panel */
 void SPrefsPanel::apply()
 {
+    msg_Dbg( p_intf, "Trying to save the %i simple panel", number );
+
+    /* Generic save for ever panel */
     QList<ConfigControl *>::Iterator i;
     for( i = controls.begin() ; i != controls.end() ; i++ )
     {
         ConfigControl *c = qobject_cast<ConfigControl *>(*i);
         c->doApply( p_intf );
     }
+
+    switch( number )
+    {
+    case SPrefsInputAndCodecs:
+    {
+        /* Device default selection */
+        char *psz_devicepath =
+              qtu( qobject_cast<QLineEdit *>(optionWidgets[inputLE] )->text() );
+        if( !EMPTY_STR( psz_devicepath ) )
+        {
+            config_PutPsz( p_intf, "dvd", psz_devicepath );
+            config_PutPsz( p_intf, "vcd", psz_devicepath );
+            config_PutPsz( p_intf, "cd-audio", psz_devicepath );
+        }
+
+        /* Access filters */
+#define saveBox( name, box ) {\
+        if( box->isChecked() ) { \
+            if( b_first ) { \
+                qs_filter.append( name ); \
+                b_first = false; \
+            } \
+            else qs_filter.append( ":" ).append( name ); \
+        } }
+
+        bool b_first = true;
+        qs_filter.clear();
+        saveBox( "record", qobject_cast<QCheckBox *>(optionWidgets[recordChB]) );
+        saveBox( "dump", qobject_cast<QCheckBox *>(optionWidgets[dumpChB]) );
+        saveBox( "timeshift", qobject_cast<QCheckBox *>(optionWidgets[timeshiftChB]) );
+        saveBox( "bandwidth", qobject_cast<QCheckBox *>(optionWidgets[bandwidthChB] ) );
+        config_PutPsz( p_intf, "access-filter", qtu( qs_filter ) );
+
+#define CaCi( name, int ) config_PutInt( p_intf, name, int * i_comboValue );
+#define CaC( name ) CaCi( name, 1 );
+        /* Caching */
+        QComboBox *cachingCombo = qobject_cast<QComboBox *>(optionWidgets[cachingCoB]);
+        int i_comboValue = cachingCombo->itemData( cachingCombo->currentIndex() ).toInt();
+        if( i_comboValue )
+        {
+            msg_Dbg( p_intf, "Adjusting all cache values at: %i", i_comboValue );
+            CaC( "udp-caching" ); CaC( "dvdread-caching" );
+            CaC( "dvdnav-caching" ); CaC( "tcp-caching" ); CaC( "vcd-caching" );
+            CaC( "fake-caching" ); CaC( "cdda-caching" ); CaC( "file-caching" );
+            CaC( "screen-caching" );
+            CaCi( "rtsp-caching", 4 ); CaCi( "ftp-caching", 2 );
+            CaCi( "http-caching", 4 ); CaCi( "realrtsp-caching", 10 );
+            CaCi( "mms-caching", 19 );
+            #ifdef WIN32
+            CaC( "dshow-caching" );
+            #else
+            CaC( "v4l-caching" ); CaC( "jack-input-caching" );
+            CaC( "v4l2-caching" ); CaC( "pvr-caching" );
+            #endif
+            //CaCi( "dv-caching" ) too short...
+        }
+        break;
+    }
+
+    /* Interfaces */
+    case SPrefsInterface:
+    {
+        if( qobject_cast<QRadioButton *>(optionWidgets[skinRB])->isChecked() )
+            config_PutPsz( p_intf, "intf", "skins2" );
+        if( qobject_cast<QRadioButton *>(optionWidgets[qtRB])->isChecked() )
+            config_PutPsz( p_intf, "intf", "qt4" );
+        break;
+    }
+
+    case SPrefsAudio:
+    {
+        bool b_normChecked =
+            qobject_cast<QCheckBox *>(optionWidgets[normalizerChB])->isChecked();
+        if( qs_filter.isEmpty() )
+        {
+            /* the psz_filter is already empty, so we just append it needed */
+            if( b_normChecked ) qs_filter = "volnorm";
+        }
+        else /* Not Empty */
+        {
+            if( qs_filter.contains( "volnorm" ) )
+            {
+                /* The qs_filter not empty and contains "volnorm"
+                   that we have to remove */
+                if( !b_normChecked )
+                {
+                    /* Ugly :D */
+                    qs_filter.remove( "volnorm:" );
+                    qs_filter.remove( ":volnorm" );
+                    qs_filter.remove( "volnorm" );
+                }
+            }
+            else /* qs_filter not empty, but doesn't have volnorm inside */
+                if( b_normChecked ) qs_filter.append( ":volnorm" );
+        }
+        config_PutPsz( p_intf, "audio-filter", qtu( qs_filter ) );
+        break;
+    }
+    }
 }
 
 void SPrefsPanel::clean()
 {}
 
+void SPrefsPanel::lastfm_Changed( int i_state )
+{
+    if( i_state == Qt::Checked )
+        config_AddIntf( VLC_OBJECT( p_intf ), "audioscrobbler" );
+    else if( i_state == Qt::Unchecked )
+        config_RemoveIntf( VLC_OBJECT( p_intf ), "audioscrobbler" );
+}