]> git.sesse.net Git - vlc/blobdiff - modules/gui/qt4/menus.cpp
Include vlc_services_discovery.h only where needed
[vlc] / modules / gui / qt4 / menus.cpp
index 58676539413cd462917d5b46759562e43fbb5c67..32fda56655a902a54978fe8b037a0aeb7adbc934 100644 (file)
 # include "config.h"
 #endif
 
-#include <vlc_common.h>
-
 #include <vlc_intf_strings.h>
+#include <vlc_services_discovery.h>
 
-#include "main_interface.hpp"
 #include "menus.hpp"
-#include "dialogs_provider.hpp"
-#include "input_manager.hpp"
+
+#include "main_interface.hpp"    /* View modifications */
+#include "dialogs_provider.hpp"  /* Dialogs display */
+#include "input_manager.hpp"     /* Input Management */
+#include "recents.hpp"           /* Recent Items */
 
 #include <QMenu>
 #include <QMenuBar>
@@ -46,6 +47,7 @@
 #include <QActionGroup>
 #include <QSignalMapper>
 #include <QSystemTrayIcon>
+#include <QList>
 
 /*
   This file defines the main menus and the pop-up menu (right-click menu)
@@ -59,8 +61,6 @@
 
   A QSignalMapper decides when to rebuild those menus cf MenuFunc in the .hpp
   Just before one of those menus are aboutToShow(), they are rebuild.
-
-
   */
 
 enum
@@ -76,7 +76,13 @@ static QActionGroup *currentGroup;
  * that doesn't update the QAction checked state when QMenu is hidden */
 QAction *QVLCMenu::minimalViewAction = NULL;
 
-// Add static entries to menus
+QMenu *QVLCMenu::recentsMenu = NULL;
+
+/****************************************************************************
+ * Menu code helpers:
+ ****************************************************************************
+ * Add static entries to DP in menus
+ ***************************************************************************/
 void addDPStaticEntry( QMenu *menu,
                        const QString text,
                        const char *help,
@@ -103,28 +109,9 @@ void addDPStaticEntry( QMenu *menu,
     action->setData( "_static_" );
 }
 
-void addMIMStaticEntry( intf_thread_t *p_intf,
-                        QMenu *menu,
-                        const QString text,
-                        const char *help,
-                        const char *icon,
-                        const char *member )
-{
-    if( strlen( icon ) > 0 )
-    {
-        QAction *action = menu->addAction( text, THEMIM,  member );
-        action->setIcon( QIcon( icon ) );
-    }
-    else
-    {
-        menu->addAction( text, THEMIM, member );
-    }
-}
-
 void EnableDPStaticEntries( QMenu *menu, bool enable = true )
 {
-    if( !menu )
-        return;
+    if( !menu ) return;
 
     QAction *action;
     foreach( action, menu->actions() )
@@ -150,23 +137,45 @@ int DeleteNonStaticEntries( QMenu *menu )
         else
             i_ret++;
     }
+    return i_ret;
+}
+
+/***
+ * Same for MIM
+ ***/
+void addMIMStaticEntry( intf_thread_t *p_intf,
+                        QMenu *menu,
+                        const QString text,
+                        const char *help,
+                        const char *icon,
+                        const char *member )
+{
+    if( strlen( icon ) > 0 )
+    {
+        QAction *action = menu->addAction( text, THEMIM,  member );
+        action->setIcon( QIcon( icon ) );
+    }
+    else
+    {
+        menu->addAction( text, THEMIM, member );
+    }
 }
 
 /*****************************************************************************
  * Definitions of variables for the dynamic menus
  *****************************************************************************/
 #define PUSH_VAR( var ) varnames.push_back( var ); \
-    objects.push_back( p_object ? p_object->i_object_id : 0 )
+    objects.push_back( VLC_OBJECT(p_object) )
 
 #define PUSH_INPUTVAR( var ) varnames.push_back( var ); \
-    objects.push_back( p_input ? p_input->i_object_id : 0 );
+    objects.push_back( VLC_OBJECT(p_input) );
 
 #define PUSH_SEPARATOR if( objects.size() != i_last_separator ) { \
     objects.push_back( 0 ); varnames.push_back( "" ); \
     i_last_separator = objects.size(); }
 
 static int InputAutoMenuBuilder( vlc_object_t *p_object,
-        vector<int> &objects,
+        vector<vlc_object_t *> &objects,
         vector<const char *> &varnames )
 {
     PUSH_VAR( "bookmark" );
@@ -180,7 +189,7 @@ static int InputAutoMenuBuilder( vlc_object_t *p_object,
 
 static int VideoAutoMenuBuilder( vlc_object_t *p_object,
         input_thread_t *p_input,
-        vector<int> &objects,
+        vector<vlc_object_t *> &objects,
         vector<const char *> &varnames )
 {
     PUSH_INPUTVAR( "video-es" );
@@ -196,6 +205,7 @@ static int VideoAutoMenuBuilder( vlc_object_t *p_object,
 #endif
     PUSH_VAR( "video-snapshot" );
 
+    /* Special case for postproc */
     if( p_object )
     {
         /* p_object is the vout, so the decoder is our parent and the
@@ -223,7 +233,7 @@ static int VideoAutoMenuBuilder( vlc_object_t *p_object,
 
 static int AudioAutoMenuBuilder( vlc_object_t *p_object,
         input_thread_t *p_input,
-        vector<int> &objects,
+        vector<vlc_object_t *> &objects,
         vector<const char *> &varnames )
 {
     PUSH_INPUTVAR( "audio-es" );
@@ -273,15 +283,15 @@ void QVLCMenu::createMenuBar( MainInterface *mi,
        gives the QProcess::destroyed timeout issue on Cleanlooks style with
        setDesktopAware set to false */
     QMenuBar *bar = mi->menuBar();
-    BAR_ADD( FileMenu(), qtr( "&Media" ) );
+    BAR_ADD( FileMenu( p_intf ), qtr( "&Media" ) );
 
     BAR_DADD( AudioMenu( p_intf, NULL ), qtr( "&Audio" ), 1 );
     BAR_DADD( VideoMenu( p_intf, NULL ), qtr( "&Video" ), 2 );
     BAR_DADD( NavigMenu( p_intf, NULL ), qtr( "P&layback" ), 3 );
 
-    BAR_ADD( PlaylistMenu( p_intf, mi ), qtr( "&Playlist" ) );
-    BAR_ADD( ToolsMenu( p_intf, NULL, mi, visual_selector_enabled, true ),
-             qtr( "&Tools" ) );
+    BAR_ADD( ToolsMenu( p_intf ), qtr( "&Tools" ) );
+    BAR_ADD( ViewMenu( p_intf, NULL, mi, visual_selector_enabled, true ),
+             qtr( "V&iew" ) );
 
     BAR_ADD( HelpMenu( NULL ), qtr( "&Help" ) );
 }
@@ -292,12 +302,18 @@ void QVLCMenu::createMenuBar( MainInterface *mi,
  * Media ( File ) Menu
  * Opening, streaming and quit
  **/
-QMenu *QVLCMenu::FileMenu()
+QMenu *QVLCMenu::FileMenu( intf_thread_t *p_intf )
 {
     QMenu *menu = new QMenu();
 
     addDPStaticEntry( menu, qtr( "&Open File..." ), "",
-        ":/file-asym", SLOT( openFileDialog() ), "Ctrl+O" );
+#ifdef WIN32
+        ":/file-asym", SLOT( simpleOpenDialog() ), "Ctrl+O" );
+    addDPStaticEntry( menu, qtr( "Advanced Open File..." ), "",
+        ":/file-asym", SLOT( openFileDialog() ), "" );
+#else
+        ":/file-asym", SLOT( openFileDialog() ), "Ctrl+0" );
+#endif
     addDPStaticEntry( menu, qtr( I_OPEN_FOLDER ), "",
         ":/folder-grey", SLOT( PLOpenDir() ), "Ctrl+F" );
     addDPStaticEntry( menu, qtr( "Open &Disc..." ), "",
@@ -307,12 +323,18 @@ QMenu *QVLCMenu::FileMenu()
     addDPStaticEntry( menu, qtr( "Open &Capture Device..." ), "",
         ":/capture-card", SLOT( openCaptureDialog() ),
         "Ctrl+C" );
+
+    menu->addSeparator();
+
+    recentsMenu = new QMenu( qtr( "Recently &Played" ), menu );
+    updateRecents( p_intf );
+    menu->addMenu( recentsMenu );
     menu->addSeparator();
 
     addDPStaticEntry( menu, qtr( "Conve&rt / Save..." ), "", "",
-        SLOT( openThenTranscodingDialogs() ), "Ctrl+R" );
+        SLOT( openAndTranscodingDialogs() ), "Ctrl+R" );
     addDPStaticEntry( menu, qtr( "&Streaming..." ), "",
-        ":/stream", SLOT( openThenStreamingDialogs() ),
+        ":/stream", SLOT( openAndStreamingDialogs() ),
         "Ctrl+S" );
     menu->addSeparator();
 
@@ -322,21 +344,35 @@ QMenu *QVLCMenu::FileMenu()
 }
 
 /* Playlist/MediaLibrary Control */
-QMenu *QVLCMenu::PlaylistMenu( intf_thread_t *p_intf, MainInterface *mi )
+QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf )
 {
     QMenu *menu = new QMenu();
-    menu->addMenu( SDMenu( p_intf ) );
-    menu->addAction( QIcon( ":/playlist_menu" ),
-                     qtr( "Show P&laylist" ), mi, SLOT( togglePlaylist() ) );
+
+    addDPStaticEntry( menu, qtr( I_MENU_EXT ), "", ":/settings",
+            SLOT( extendedDialog() ), "Ctrl+E" );
+    addDPStaticEntry( menu, qtr( I_MENU_MSG ), "",
+        ":/messages", SLOT( messagesDialog() ),
+        "Ctrl+M" );
+    addDPStaticEntry( menu, qtr( "Plugins and extensions" ), "",
+        "", SLOT( pluginDialog() ),
+        "" );
+    addDPStaticEntry( menu, qtr( I_MENU_INFO ) , "", ":/info",
+        SLOT( mediaInfoDialog() ), "Ctrl+I" );
+    addDPStaticEntry( menu, qtr( I_MENU_CODECINFO ) , "",
+        ":/info", SLOT( mediaCodecDialog() ), "Ctrl+J" );
+    addDPStaticEntry( menu, qtr( I_MENU_BOOKMARK ), "","",
+                      SLOT( bookmarksDialog() ), "Ctrl+B" );
+#ifdef ENABLE_VLM
+    addDPStaticEntry( menu, qtr( I_MENU_VLM ), "", "", SLOT( vlmDialog() ),
+        "Ctrl+W" );
+#endif
     menu->addSeparator();
 
-    addDPStaticEntry( menu, qtr( I_PL_LOAD ), "", "", SLOT( openAPlaylist() ),
-        "Ctrl+X" );
-    addDPStaticEntry( menu, qtr( I_PL_SAVE ), "", "", SLOT( saveAPlaylist() ),
-        "Ctrl+Y" );
-    /*menu->addSeparator();
-    menu->addAction( qtr( "Undock from Interface" ), mi,
-                     SLOT( undockPlaylist() ), qtr( "Ctrl+U" ) );*/
+    addDPStaticEntry( menu, qtr( "Customi&ze Interface..." ), "",
+        ":/preferences", SLOT( toolbarDialog() ), "" );
+    addDPStaticEntry( menu, qtr( "&Preferences..." ), "",
+        ":/preferences", SLOT( prefsDialog() ), "Ctrl+P" );
+
     return menu;
 }
 
@@ -346,7 +382,7 @@ QMenu *QVLCMenu::PlaylistMenu( intf_thread_t *p_intf, MainInterface *mi )
  * longer.
  * This menu can be an interface menu but also a right click menu.
  **/
-QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf,
+QMenu *QVLCMenu::ViewMenu( intf_thread_t *p_intf,
                             QMenu *current,
                             MainInterface *mi,
                             bool visual_selector_enabled,
@@ -360,8 +396,17 @@ QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf,
                     mi, SLOT( togglePlaylist() ), qtr( "Ctrl+L" ) );
         act->setData( "_static_" );
     }
-    addDPStaticEntry( menu, qtr( I_MENU_EXT ), "", ":/settings",
-            SLOT( extendedDialog() ), "Ctrl+E" );
+    menu->addMenu( SDMenu( p_intf ) );
+    menu->addSeparator();
+
+    addDPStaticEntry( menu, qtr( I_PL_LOAD ), "", "", SLOT( openAPlaylist() ),
+        "Ctrl+X" );
+    addDPStaticEntry( menu, qtr( I_PL_SAVE ), "", "", SLOT( saveAPlaylist() ),
+        "Ctrl+Y" );
+    /*menu->addSeparator();
+    menu->addAction( qtr( "Undock from Interface" ), mi,
+                     SLOT( undockPlaylist() ), qtr( "Ctrl+U" ) );*/
+
 
     menu->addSeparator();
 
@@ -407,23 +452,6 @@ QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf,
 
     menu->addSeparator();
 
-    addDPStaticEntry( menu, qtr( I_MENU_MSG ), "",
-        ":/messages", SLOT( messagesDialog() ),
-        "Ctrl+M" );
-    addDPStaticEntry( menu, qtr( I_MENU_INFO ) , "", ":/info",
-        SLOT( mediaInfoDialog() ), "Ctrl+I" );
-    addDPStaticEntry( menu, qtr( I_MENU_CODECINFO ) , "",
-        ":/info", SLOT( mediaCodecDialog() ), "Ctrl+J" );
-    addDPStaticEntry( menu, qtr( I_MENU_BOOKMARK ), "","",
-                      SLOT( bookmarksDialog() ), "Ctrl+B" );
-#ifdef ENABLE_VLM
-    addDPStaticEntry( menu, qtr( I_MENU_VLM ), "", "", SLOT( vlmDialog() ),
-        "Ctrl+W" );
-#endif
-
-    menu->addSeparator();
-    addDPStaticEntry( menu, qtr( "&Preferences..." ), "",
-        ":/preferences", SLOT( prefsDialog() ), "Ctrl+P" );
     return menu;
 }
 
@@ -432,11 +460,11 @@ QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf,
  **/
 QMenu *QVLCMenu::InterfacesMenu( intf_thread_t *p_intf, QMenu *current )
 {
-    vector<int> objects;
+    vector<vlc_object_t *> objects;
     vector<const char *> varnames;
     /** \todo add "switch to XXX" */
     varnames.push_back( "intf-add" );
-    objects.push_back( p_intf->i_object_id );
+    objects.push_back( VLC_OBJECT(p_intf) );
 
     return Populate( p_intf, current, varnames, objects );
 }
@@ -446,7 +474,7 @@ QMenu *QVLCMenu::InterfacesMenu( intf_thread_t *p_intf, QMenu *current )
  */
 QMenu *QVLCMenu::AudioMenu( intf_thread_t *p_intf, QMenu * current )
 {
-    vector<int> objects;
+    vector<vlc_object_t *> objects;
     vector<const char *> varnames;
     vlc_object_t *p_aout;
     input_thread_t *p_input;
@@ -464,7 +492,7 @@ QMenu *QVLCMenu::AudioMenu( intf_thread_t *p_intf, QMenu * current )
 
     p_input = THEMIM->getInput();
     if( p_input )
-        vlc_object_yield( p_input );
+        vlc_object_hold( p_input );
     p_aout = ( vlc_object_t * ) vlc_object_find( p_intf,
                                                  VLC_OBJECT_AOUT,
                                                  FIND_ANYWHERE );
@@ -487,7 +515,7 @@ QMenu *QVLCMenu::VideoMenu( intf_thread_t *p_intf, QMenu *current )
 {
     vlc_object_t *p_vout;
     input_thread_t *p_input;
-    vector<int> objects;
+    vector<vlc_object_t *> objects;
     vector<const char *> varnames;
 
     if( !current ) current = new QMenu();
@@ -519,7 +547,7 @@ QMenu *QVLCMenu::VideoMenu( intf_thread_t *p_intf, QMenu *current )
 
     p_input = THEMIM->getInput();
     if( p_input )
-        vlc_object_yield( p_input );
+        vlc_object_hold( p_input );
     p_vout = ( vlc_object_t * )vlc_object_find( p_intf, VLC_OBJECT_VOUT,
             FIND_ANYWHERE );
 
@@ -540,7 +568,7 @@ QMenu *QVLCMenu::VideoMenu( intf_thread_t *p_intf, QMenu *current )
 QMenu *QVLCMenu::NavigMenu( intf_thread_t *p_intf, QMenu *menu )
 {
     vlc_object_t *p_object;
-    vector<int> objects;
+    vector<vlc_object_t *> objects;
     vector<const char *> varnames;
 
     if( !menu ) menu = new QMenu();
@@ -634,7 +662,7 @@ QMenu *QVLCMenu::HelpMenu( QMenu *current )
  *****************************************************************************/
 #define POPUP_BOILERPLATE \
     unsigned int i_last_separator = 0; \
-    vector<int> objects; \
+    vector<vlc_object_t *> objects; \
     vector<const char *> varnames; \
     input_thread_t *p_input = THEMIM->getInput();
 
@@ -713,7 +741,7 @@ void QVLCMenu::VideoPopupMenu( intf_thread_t *p_intf )
     POPUP_BOILERPLATE;
     if( p_input )
     {
-        vlc_object_yield( p_input );
+        vlc_object_hold( p_input );
         vlc_object_t *p_vout = ( vlc_object_t * )vlc_object_find( p_input,
                 VLC_OBJECT_VOUT, FIND_CHILD );
         if( p_vout )
@@ -733,7 +761,7 @@ void QVLCMenu::AudioPopupMenu( intf_thread_t *p_intf )
     POPUP_BOILERPLATE;
     if( p_input )
     {
-        vlc_object_yield( p_input );
+        vlc_object_hold( p_input );
         vlc_object_t *p_aout = ( vlc_object_t * )vlc_object_find( p_input,
                 VLC_OBJECT_AOUT, FIND_ANYWHERE );
         AudioAutoMenuBuilder( p_aout, p_input, objects, varnames );
@@ -753,7 +781,7 @@ void QVLCMenu::MiscPopupMenu( intf_thread_t *p_intf )
 
     if( p_input )
     {
-        vlc_object_yield( p_input );
+        vlc_object_hold( p_input );
         varnames.push_back( "audio-es" );
         InputAutoMenuBuilder( VLC_OBJECT( p_input ), objects, varnames );
         PUSH_SEPARATOR;
@@ -807,14 +835,14 @@ void QVLCMenu::PopupMenu( intf_thread_t *p_intf, bool show )
                 if( b_isFullscreen )
                     CreateAndConnect( menu, "fullscreen",
                             qtr( "Leave Fullscreen" ),"" , ITEM_NORMAL,
-                            p_vout->i_object_id, val, VLC_VAR_BOOL,
+                            VLC_OBJECT(p_vout), val, VLC_VAR_BOOL,
                             b_isFullscreen );
                 vlc_object_release( p_vout );
             }
 
             menu->addSeparator();
 
-            vlc_object_yield( p_input );
+            vlc_object_hold( p_input );
             InputAutoMenuBuilder( VLC_OBJECT( p_input ), objects, varnames );
             vlc_object_release( p_input );
 
@@ -850,6 +878,8 @@ void QVLCMenu::PopupMenu( intf_thread_t *p_intf, bool show )
             }
             addDPStaticEntry( submenu, qtr( I_MENU_EXT ), "",
                 ":/settings", SLOT( extendedDialog() ) );
+            addDPStaticEntry( submenu, qtr( I_MENU_INFO ) , "", ":/info",
+                SLOT( mediaInfoDialog() ), "Ctrl+I" );
             if( mi )
             {
                 action = submenu->addAction( QIcon( "" ),
@@ -866,13 +896,16 @@ void QVLCMenu::PopupMenu( intf_thread_t *p_intf, bool show )
             else /* We are using the skins interface.
                     If not, this entry will not show. */
             {
+                addDPStaticEntry( submenu, qtr( "&Preferences..." ), "",
+                    ":/preferences", SLOT( prefsDialog() ), "Ctrl+P" );
+                submenu->addSeparator();
                 objects.clear();
                 varnames.clear();
                 vlc_object_t *p_object = ( vlc_object_t* )
                      vlc_object_find( p_intf, VLC_OBJECT_INTF, FIND_PARENT );
                 if( p_object )
                 {
-                    objects.push_back( p_object->i_object_id );
+                    objects.push_back( p_object );
                     varnames.push_back( "intf-skins" );
                     Populate( p_intf, submenu, varnames, objects );
                     vlc_object_release( p_object );
@@ -950,7 +983,7 @@ void QVLCMenu::updateSystrayMenu( MainInterface *mi,
 QMenu * QVLCMenu::Populate( intf_thread_t *p_intf,
                             QMenu *current,
                             vector< const char *> & varnames,
-                            vector<int> & objects,
+                            vector<vlc_object_t *> & objects,
                             bool append )
 {
     QMenu *menu = current;
@@ -976,24 +1009,9 @@ QMenu * QVLCMenu::Populate( intf_thread_t *p_intf,
             menu->addSeparator();
             continue;
         }
-
-        if( objects[i] == 0 )
-        {
-            p_object = NULL;
-        }
-        else
-        {
-            p_object = ( vlc_object_t * )vlc_object_get( p_intf->p_libvlc, objects[i] );
-            if( !p_object )
-            {
-                msg_Warn( p_intf, "object %d not found !", objects[i] );
-                continue;
-            }
-        }
+        p_object = objects[i];
 
         UpdateItem( p_intf, menu, varnames[i], p_object, true );
-        if( p_object )
-            vlc_object_release( p_object );
     }
     return menu;
 }
@@ -1141,14 +1159,14 @@ void QVLCMenu::UpdateItem( intf_thread_t *p_intf, QMenu *menu,
         case VLC_VAR_VOID:
             var_Get( p_object, psz_var, &val );
             CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_NORMAL,
-                    p_object->i_object_id, val, i_type );
+                    p_object, val, i_type );
             break;
 
         case VLC_VAR_BOOL:
             var_Get( p_object, psz_var, &val );
             val.b_bool = !val.b_bool;
             CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_CHECK,
-                    p_object->i_object_id, val, i_type, !val.b_bool );
+                    p_object, val, i_type, !val.b_bool );
             break;
     }
     FREENULL( text.psz_string );
@@ -1210,7 +1228,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 another_val.psz_string = strdup( CURVAL.psz_string );
                 menutext = qfu( CURTEXT ? CURTEXT : another_val.psz_string );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
-                        p_object->i_object_id, another_val, i_type,
+                        p_object, another_val, i_type,
                         val.psz_string && !strcmp( val.psz_string, CURVAL.psz_string ) );
 
                 free( val.psz_string );
@@ -1221,7 +1239,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 if( CURTEXT ) menutext = qfu( CURTEXT );
                 else menutext.sprintf( "%d", CURVAL.i_int );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
-                        p_object->i_object_id, CURVAL, i_type,
+                        p_object, CURVAL, i_type,
                         CURVAL.i_int == val.i_int );
                 break;
 
@@ -1230,7 +1248,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 if( CURTEXT ) menutext = qfu( CURTEXT );
                 else menutext.sprintf( "%.2f", CURVAL.f_float );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
-                        p_object->i_object_id, CURVAL, i_type,
+                        p_object, CURVAL, i_type,
                         CURVAL.f_float == val.f_float );
                 break;
 
@@ -1250,7 +1268,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
 
 void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
         QString text, QString help,
-        int i_item_type, int i_object_id,
+        int i_item_type, vlc_object_t *p_obj,
         vlc_value_t val, int i_val_type,
         bool checked )
 {
@@ -1262,7 +1280,7 @@ void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
     }
 
     action->setToolTip( help );
-    action->setEnabled( i_object_id != 0 );
+    action->setEnabled( p_obj != NULL );
 
     if( i_item_type == ITEM_CHECK )
     {
@@ -1278,7 +1296,7 @@ void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
 
     action->setChecked( checked );
 
-    MenuItemData *itemData = new MenuItemData( THEDP->menusMapper, i_object_id, i_val_type,
+    MenuItemData *itemData = new MenuItemData( THEDP->menusMapper, p_obj, i_val_type,
             val, psz_var );
     CONNECT( action, triggered(), THEDP->menusMapper, map() );
     THEDP->menusMapper->setMapping( action, itemData );
@@ -1288,10 +1306,39 @@ void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
 void QVLCMenu::DoAction( intf_thread_t *p_intf, QObject *data )
 {
     MenuItemData *itemData = qobject_cast<MenuItemData *>( data );
-    vlc_object_t *p_object = ( vlc_object_t * )vlc_object_get( p_intf->p_libvlc, itemData->i_object_id );
+    vlc_object_t *p_object = itemData->p_obj;
     if( p_object == NULL ) return;
 
     var_Set( p_object, itemData->psz_var, itemData->val );
-    vlc_object_release( p_object );
 }
 
+void QVLCMenu::updateRecents( intf_thread_t *p_intf )
+{
+    if (recentsMenu)
+    {
+        QAction* action;
+        RecentsMRL* rmrl = RecentsMRL::getInstance( p_intf );
+        QList<QString> l = rmrl->recents();
+
+        recentsMenu->clear();
+        if( !l.size() )
+        {
+            action = recentsMenu->addAction( " - Empty - " );
+            action->setEnabled( false );
+        }
+        else
+        {
+            for( int i = 0; i < l.size(); ++i )
+            {
+                action = recentsMenu->addAction(
+                        QString( "&%1: " ).arg( i + 1 ) + l.at( i ),
+                        rmrl->signalMapper,
+                        SLOT( map() ) );
+                rmrl->signalMapper->setMapping( action, l.at( i ) );
+            }
+
+            recentsMenu->addSeparator();
+            recentsMenu->addAction( "&Clear", rmrl, SLOT( clear() ) );
+        }
+    }
+}