]> git.sesse.net Git - vlc/blobdiff - modules/gui/wxwindows/menus.cpp
* modules/gui/wxwindows/*: workaround uninitialization bug in wxWidgets -> re-enabled...
[vlc] / modules / gui / wxwindows / menus.cpp
index fb4a1053f35885ec1ab09c9a6aa126b2d5453733..38d070f0ccaaf23ea54c02d06ac33edb83dc4039 100644 (file)
@@ -2,9 +2,9 @@
  * menus.cpp : wxWindows plugin for vlc
  *****************************************************************************
  * Copyright (C) 2000-2004 VideoLAN
- * $Id: menus.cpp,v 1.31 2004/02/24 22:15:41 gbazin Exp $
+ * $Id$
  *
- * Authors: Gildas Bazin <gbazin@netcourrier.com>
+ * Authors: Gildas Bazin <gbazin@videolan.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -54,6 +54,29 @@ private:
 
 };
 
+class Menu: public wxMenu
+{
+public:
+    /* Constructor */
+    Menu( intf_thread_t *p_intf, int i_start_id );
+    virtual ~Menu();
+
+    void Populate( int i_count, char **ppsz_names, int *pi_objects );
+    void Clear();
+
+private:
+    wxMenu *Menu::CreateDummyMenu();
+    void   Menu::CreateMenuItem( wxMenu *, char *, vlc_object_t * );
+    wxMenu *Menu::CreateChoicesMenu( char *, vlc_object_t *, bool );
+
+    DECLARE_EVENT_TABLE();
+
+    intf_thread_t *p_intf;
+
+    int i_start_id;
+    int i_item_id;
+};
+
 /*****************************************************************************
  * Event Table.
  *****************************************************************************/
@@ -67,12 +90,22 @@ enum
     OpenFile_Event,
     OpenDisc_Event,
     OpenNet_Event,
+    OpenCapture_Event,
+    MediaInfo_Event,
+    Messages_Event,
+    Preferences_Event,
+    Play_Event,
+    Pause_Event,
+    Previous_Event,
+    Next_Event,
+    Stop_Event,
     FirstAutoGenerated_Event = wxID_HIGHEST + 1999,
     SettingsMenu_Events = wxID_HIGHEST + 5000,
     AudioMenu_Events = wxID_HIGHEST + 2000,
     VideoMenu_Events = wxID_HIGHEST + 3000,
     NavigMenu_Events = wxID_HIGHEST + 4000,
-    PopupMenu_Events = wxID_HIGHEST + 6000
+    PopupMenu_Events = wxID_HIGHEST + 6000,
+    Hotkeys_Events = wxID_HIGHEST + 7000
 };
 
 BEGIN_EVENT_TABLE(Menu, wxMenu)
@@ -83,6 +116,10 @@ BEGIN_EVENT_TABLE(MenuEvtHandler, wxEvtHandler)
     EVT_MENU(OpenFile_Event, MenuEvtHandler::OnShowDialog)
     EVT_MENU(OpenDisc_Event, MenuEvtHandler::OnShowDialog)
     EVT_MENU(OpenNet_Event, MenuEvtHandler::OnShowDialog)
+    EVT_MENU(OpenCapture_Event, MenuEvtHandler::OnShowDialog)
+    EVT_MENU(MediaInfo_Event, MenuEvtHandler::OnShowDialog)
+    EVT_MENU(Messages_Event, MenuEvtHandler::OnShowDialog)
+    EVT_MENU(Preferences_Event, MenuEvtHandler::OnShowDialog)
     EVT_MENU(-1, MenuEvtHandler::OnMenuEvent)
 END_EVENT_TABLE()
 
@@ -93,43 +130,65 @@ wxMenu *OpenStreamMenu( intf_thread_t *p_intf )
     menu->Append( OpenFile_Event, wxU(_("Open &File...")) );
     menu->Append( OpenDisc_Event, wxU(_("Open &Disc...")) );
     menu->Append( OpenNet_Event, wxU(_("Open &Network Stream...")) );
+    menu->Append( OpenCapture_Event, wxU(_("Open &Capture Device...")) );
+    return menu;
+}
+
+wxMenu *MiscMenu( intf_thread_t *p_intf )
+{
+    wxMenu *menu = new wxMenu;
+    menu->Append( MediaInfo_Event, wxU(_("Media &Info...")) );
+    menu->Append( Messages_Event, wxU(_("&Messages...")) );
+    menu->Append( Preferences_Event, wxU(_("&Preferences...")) );
     return menu;
 }
 
 void PopupMenu( intf_thread_t *p_intf, wxWindow *p_parent,
                 const wxPoint& pos )
 {
-#define MAX_POPUP_ITEMS 35
+#define MAX_POPUP_ITEMS 45
 
-    vlc_object_t *p_object;
+    int minimal = config_GetInt( p_intf, "wxwin-minimal" );
+
+    vlc_object_t *p_object, *p_input;
     char *ppsz_varnames[MAX_POPUP_ITEMS];
     int pi_objects[MAX_POPUP_ITEMS];
-    int i = 0;
+    int i = 0, i_last_separator = 0;
 
     /* Initializations */
     memset( pi_objects, 0, MAX_POPUP_ITEMS * sizeof(int) );
 
-    /* Audio menu */
-    ppsz_varnames[i++] = _("Audio menu");
-    ppsz_varnames[i++] = NULL; /* Separator */
-
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_AOUT,
+    /* Input menu */
+    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_INPUT,
                                                 FIND_ANYWHERE );
     if( p_object != NULL )
     {
-        ppsz_varnames[i] = "audio-device";
+        ppsz_varnames[i] = "bookmark";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "audio-channels";
+        ppsz_varnames[i] = "title";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "visual";
+        ppsz_varnames[i] = "chapter";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "program";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "navigation";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "dvd_menus";
+        pi_objects[i++] = p_object->i_object_id;
+
+        ppsz_varnames[i] = "video-es";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "audio-es";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "spu-es";
         pi_objects[i++] = p_object->i_object_id;
-        vlc_object_release( p_object );
     }
+    p_input = p_object;
+    if( !p_input ) goto interfacemenu;
 
     /* Video menu */
-    ppsz_varnames[i++] = NULL; /* Separator */
-    ppsz_varnames[i++] = _("Video menu");
-    ppsz_varnames[i++] = NULL; /* Separator */
+    if( i != i_last_separator ) ppsz_varnames[i++] = NULL; /* Separator */
+    i_last_separator = i;
 
     p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_VOUT,
                                                 FIND_ANYWHERE );
@@ -139,6 +198,8 @@ void PopupMenu( intf_thread_t *p_intf, wxWindow *p_parent,
 
         ppsz_varnames[i] = "fullscreen";
         pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "zoom";
+        pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "deinterlace";
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "aspect-ratio";
@@ -147,6 +208,10 @@ void PopupMenu( intf_thread_t *p_intf, wxWindow *p_parent,
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "video-on-top";
         pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "directx-wallpaper";
+        pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "video-snapshot";
+        pi_objects[i++] = p_object->i_object_id;
 
         p_dec_obj = (vlc_object_t *)vlc_object_find( p_object,
                                                      VLC_OBJECT_DECODER,
@@ -161,71 +226,98 @@ void PopupMenu( intf_thread_t *p_intf, wxWindow *p_parent,
         vlc_object_release( p_object );
     }
 
-    /* Input menu */
-    ppsz_varnames[i++] = NULL; /* Separator */
-    ppsz_varnames[i++] = _("Input menu");
-    ppsz_varnames[i++] = NULL; /* Separator */
+    /* Audio menu */
+    if( i != i_last_separator ) ppsz_varnames[i++] = NULL; /* Separator */
+    i_last_separator  = i;
 
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_INPUT,
+    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_AOUT,
                                                 FIND_ANYWHERE );
     if( p_object != NULL )
     {
-        ppsz_varnames[i] = "title";
-        pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "chapter";
-        pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "program";
-        pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "navigation";
-        pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "dvd_menus";
+        ppsz_varnames[i] = "audio-device";
         pi_objects[i++] = p_object->i_object_id;
-
-        ppsz_varnames[i] = "video-es";
+        ppsz_varnames[i] = "audio-channels";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "audio-es";
+        ppsz_varnames[i] = "visual";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "spu-es";
+        ppsz_varnames[i] = "equalizer";
         pi_objects[i++] = p_object->i_object_id;
-
         vlc_object_release( p_object );
     }
 
+ interfacemenu:
     /* Interface menu */
-    ppsz_varnames[i++] = NULL; /* Separator */
-    ppsz_varnames[i++] = _("Interface menu");
-    ppsz_varnames[i++] = NULL; /* Separator */
+    if( i != i_last_separator ) ppsz_varnames[i++] = NULL; /* Separator */
+    i_last_separator = i;
 
     /* vlc_object_find is needed because of the dialogs provider case */
     p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_INTF,
                                                 FIND_PARENT );
     if( p_object != NULL )
     {
+#if (wxCHECK_VERSION(2,5,0))
         ppsz_varnames[i] = "intf-switch";
         pi_objects[i++] = p_object->i_object_id;
+#endif
         ppsz_varnames[i] = "intf-add";
         pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "intf-skins";
+        pi_objects[i++] = p_object->i_object_id;
 
         vlc_object_release( p_object );
     }
 
     /* Build menu */
-    Menu popupmenu( p_intf, p_parent, i,
-                     ppsz_varnames, pi_objects, PopupMenu_Events );
+    Menu popupmenu( p_intf, PopupMenu_Events );
+    popupmenu.Populate( i, ppsz_varnames, pi_objects );
 
-#if 1
     /* Add static entries */
-    popupmenu.AppendSeparator();
-    popupmenu.Append( MenuDummy_Event, wxU("Open..."),
+    if( p_input != NULL )
+    {
+        vlc_value_t val;
+        popupmenu.InsertSeparator( 0 );
+        if (!minimal)
+        {
+        popupmenu.Insert( 0, Stop_Event, wxU(_("Stop")) );
+        popupmenu.Insert( 0, Previous_Event, wxU(_("Previous")) );
+        popupmenu.Insert( 0, Next_Event, wxU(_("Next")) );
+        }
+
+        var_Get( p_input, "state", &val );
+        if( val.i_int == PAUSE_S )
+            popupmenu.Insert( 0, Play_Event, wxU(_("Play")) );
+        else
+            popupmenu.Insert( 0, Pause_Event, wxU(_("Pause")) );
+
+        vlc_object_release( p_input );
+    }
+    else
+    {
+        playlist_t * p_playlist =
+            (playlist_t *)vlc_object_find( p_intf, VLC_OBJECT_PLAYLIST,
+                                           FIND_ANYWHERE );
+        if( p_playlist && p_playlist->i_size )
+        {
+            popupmenu.InsertSeparator( 0 );
+            popupmenu.Insert( 0, Play_Event, wxU(_("Play")) );
+        }
+        if( p_playlist ) vlc_object_release( p_playlist );
+    }
+
+    popupmenu.Append( MenuDummy_Event, wxU(_("Miscellaneous")),
+                      MiscMenu( p_intf ), wxT("") );
+    if (!minimal)
+    {
+    popupmenu.Append( MenuDummy_Event, wxU(_("Open")),
                       OpenStreamMenu( p_intf ), wxT("") );
-#endif
+    }
 
     p_intf->p_sys->p_popup_menu = &popupmenu;
     p_parent->PopupMenu( &popupmenu, pos.x, pos.y );
     p_intf->p_sys->p_popup_menu = NULL;
 }
 
-wxMenu *AudioMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
+wxMenu *AudioMenu( intf_thread_t *_p_intf, wxWindow *p_parent, wxMenu *p_menu )
 {
 #define MAX_AUDIO_ITEMS 10
 
@@ -256,15 +348,24 @@ wxMenu *AudioMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "visual";
         pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "equalizer";
+        pi_objects[i++] = p_object->i_object_id;
         vlc_object_release( p_object );
     }
 
     /* Build menu */
-    return new Menu( _p_intf, p_parent, i,
-                     ppsz_varnames, pi_objects, AudioMenu_Events );
+    Menu *p_vlc_menu = (Menu *)p_menu;
+    if( !p_vlc_menu )
+        p_vlc_menu = new Menu( _p_intf, AudioMenu_Events );
+    else
+        p_vlc_menu->Clear();
+
+    p_vlc_menu->Populate( i, ppsz_varnames, pi_objects );
+
+    return p_vlc_menu;
 }
 
-wxMenu *VideoMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
+wxMenu *VideoMenu( intf_thread_t *_p_intf, wxWindow *p_parent, wxMenu *p_menu )
 {
 #define MAX_VIDEO_ITEMS 15
 
@@ -295,17 +396,19 @@ wxMenu *VideoMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
 
         ppsz_varnames[i] = "fullscreen";
         pi_objects[i++] = p_object->i_object_id;
+        ppsz_varnames[i] = "zoom";
+        pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "deinterlace";
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "aspect-ratio";
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "crop";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "directx-on-top";
+        ppsz_varnames[i] = "video-on-top";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "xvideo-on-top";
+        ppsz_varnames[i] = "directx-wallpaper";
         pi_objects[i++] = p_object->i_object_id;
-        ppsz_varnames[i] = "x11-on-top";
+        ppsz_varnames[i] = "video-snapshot";
         pi_objects[i++] = p_object->i_object_id;
 
         p_dec_obj = (vlc_object_t *)vlc_object_find( p_object,
@@ -322,13 +425,20 @@ wxMenu *VideoMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
     }
 
     /* Build menu */
-    return new Menu( _p_intf, p_parent, i,
-                     ppsz_varnames, pi_objects, VideoMenu_Events );
+    Menu *p_vlc_menu = (Menu *)p_menu;
+    if( !p_vlc_menu )
+        p_vlc_menu = new Menu( _p_intf, VideoMenu_Events );
+    else
+        p_vlc_menu->Clear();
+
+    p_vlc_menu->Populate( i, ppsz_varnames, pi_objects );
+
+    return p_vlc_menu;
 }
 
-wxMenu *NavigMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
+wxMenu *NavigMenu( intf_thread_t *_p_intf, wxWindow *p_parent, wxMenu *p_menu )
 {
-#define MAX_NAVIG_ITEMS 10
+#define MAX_NAVIG_ITEMS 15
 
     vlc_object_t *p_object;
     char *ppsz_varnames[MAX_NAVIG_ITEMS];
@@ -342,6 +452,8 @@ wxMenu *NavigMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
                                                 FIND_ANYWHERE );
     if( p_object != NULL )
     {
+        ppsz_varnames[i] = "bookmark";
+        pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "title";
         pi_objects[i++] = p_object->i_object_id;
         ppsz_varnames[i] = "chapter";
@@ -366,11 +478,19 @@ wxMenu *NavigMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
     }
 
     /* Build menu */
-    return new Menu( _p_intf, p_parent, i,
-                     ppsz_varnames, pi_objects, NavigMenu_Events );
+    Menu *p_vlc_menu = (Menu *)p_menu;
+    if( !p_vlc_menu )
+        p_vlc_menu = new Menu( _p_intf, NavigMenu_Events );
+    else
+        p_vlc_menu->Clear();
+
+    p_vlc_menu->Populate( i, ppsz_varnames, pi_objects );
+
+    return p_vlc_menu;
 }
 
-wxMenu *SettingsMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
+wxMenu *SettingsMenu( intf_thread_t *_p_intf, wxWindow *p_parent,
+                      wxMenu *p_menu )
 {
 #define MAX_SETTINGS_ITEMS 10
 
@@ -386,32 +506,50 @@ wxMenu *SettingsMenu( intf_thread_t *_p_intf, wxWindow *p_parent )
                                                 FIND_PARENT );
     if( p_object != NULL )
     {
+#if (wxCHECK_VERSION(2,5,0))
         ppsz_varnames[i] = "intf-switch";
         pi_objects[i++] = p_object->i_object_id;
+#endif
         ppsz_varnames[i] = "intf-add";
         pi_objects[i++] = p_object->i_object_id;
         vlc_object_release( p_object );
     }
 
     /* Build menu */
-    return new Menu( _p_intf, p_parent, i,
-                     ppsz_varnames, pi_objects, SettingsMenu_Events );
+    Menu *p_vlc_menu = (Menu *)p_menu;
+    if( !p_vlc_menu )
+        p_vlc_menu = new Menu( _p_intf, SettingsMenu_Events );
+    else
+        p_vlc_menu->Clear();
+
+    p_vlc_menu->Populate( i, ppsz_varnames, pi_objects );
+
+    return p_vlc_menu;
 }
 
 /*****************************************************************************
  * Constructor.
  *****************************************************************************/
-Menu::Menu( intf_thread_t *_p_intf, wxWindow *p_parent,
-            int i_count, char **ppsz_varnames, int *pi_objects,
-            int i_start_id ): wxMenu( )
+Menu::Menu( intf_thread_t *_p_intf, int _i_start_id ) : wxMenu( )
+{
+    /* Initializations */
+    p_intf = _p_intf;
+    i_start_id = _i_start_id;
+}
+
+Menu::~Menu()
+{
+}
+
+/*****************************************************************************
+ * Public methods.
+ *****************************************************************************/
+void Menu::Populate( int i_count, char **ppsz_varnames, int *pi_objects )
 {
     vlc_object_t *p_object;
     vlc_bool_t b_section_empty = VLC_FALSE;
     int i;
 
-    /* Initializations */
-    p_intf = _p_intf;
-
     i_item_id = i_start_id;
 
     for( i = 0; i < i_count; i++ )
@@ -452,8 +590,28 @@ Menu::Menu( intf_thread_t *_p_intf, wxWindow *p_parent,
     }
 }
 
-Menu::~Menu()
+/* Work-around helper for buggy wxGTK */
+static void RecursiveDestroy( wxMenu *menu )
+{
+    wxMenuItemList::Node *node = menu->GetMenuItems().GetFirst();
+    for( ; node; )
+    {
+        wxMenuItem *item = node->GetData();
+        node = node->GetNext();
+
+        /* Delete the submenus */
+        wxMenu *submenu = item->GetSubMenu();
+        if( submenu )
+        {
+            RecursiveDestroy( submenu );
+        }
+        menu->Delete( item );
+    }
+}
+
+void Menu::Clear( )
 {
+    RecursiveDestroy( this );
 }
 
 /*****************************************************************************
@@ -519,6 +677,7 @@ void Menu::CreateMenuItem( wxMenu *menu, char *psz_var,
     case VLC_VAR_VARIABLE:
     case VLC_VAR_STRING:
     case VLC_VAR_INTEGER:
+    case VLC_VAR_FLOAT:
         break;
     default:
         /* Variable doesn't exist or isn't handled */
@@ -531,8 +690,6 @@ void Menu::CreateMenuItem( wxMenu *menu, char *psz_var,
     /* Get the descriptive name of the variable */
     var_Change( p_object, psz_var, VLC_VAR_GETTEXT, &text, NULL );
 
-    var_Get( p_object, psz_var, &val );
-
     if( i_type & VLC_VAR_HASCHOICE )
     {
         menu->Append( MenuDummy_Event,
@@ -548,6 +705,7 @@ void Menu::CreateMenuItem( wxMenu *menu, char *psz_var,
     switch( i_type & VLC_VAR_TYPE )
     {
     case VLC_VAR_VOID:
+        var_Get( p_object, psz_var, &val );
         menuitem = new wxMenuItemExt( menu, ++i_item_id,
                                       wxU(text.psz_string ?
                                         text.psz_string : psz_var),
@@ -557,6 +715,7 @@ void Menu::CreateMenuItem( wxMenu *menu, char *psz_var,
         break;
 
     case VLC_VAR_BOOL:
+        var_Get( p_object, psz_var, &val );
         val.b_bool = !val.b_bool;
         menuitem = new wxMenuItemExt( menu, ++i_item_id,
                                       wxU(text.psz_string ?
@@ -566,13 +725,8 @@ void Menu::CreateMenuItem( wxMenu *menu, char *psz_var,
         menu->Append( menuitem );
         Check( i_item_id, val.b_bool ? FALSE : TRUE );
         break;
-
-    default:
-        if( text.psz_string ) free( text.psz_string );
-        return;
     }
 
-    if( (i_type & VLC_VAR_TYPE) == VLC_VAR_STRING ) free( val.psz_string );
     if( text.psz_string ) free( text.psz_string );
 }
 
@@ -595,21 +749,16 @@ wxMenu *Menu::CreateChoicesMenu( char *psz_var, vlc_object_t *p_object,
     case VLC_VAR_VARIABLE:
     case VLC_VAR_STRING:
     case VLC_VAR_INTEGER:
+    case VLC_VAR_FLOAT:
         break;
     default:
         /* Variable doesn't exist or isn't handled */
         return NULL;
     }
 
-    if( var_Get( p_object, psz_var, &val ) < 0 )
-    {
-        return NULL;
-    }
-
     if( var_Change( p_object, psz_var, VLC_VAR_GETLIST,
                     &val_list, &text_list ) < 0 )
     {
-        if( (i_type & VLC_VAR_TYPE) == VLC_VAR_STRING ) free( val.psz_string );
         return NULL;
     }
 
@@ -632,6 +781,8 @@ wxMenu *Menu::CreateChoicesMenu( char *psz_var, vlc_object_t *p_object,
           break;
 
         case VLC_VAR_STRING:
+          var_Get( p_object, psz_var, &val );
+
           another_val.psz_string =
               strdup(val_list.p_list->p_values[i].psz_string);
           menuitem =
@@ -646,12 +797,17 @@ wxMenu *Menu::CreateChoicesMenu( char *psz_var, vlc_object_t *p_object,
 
           menu->Append( menuitem );
 
-          if( !strcmp( val.psz_string,
+          if( !(i_type & VLC_VAR_ISCOMMAND) && val.psz_string &&
+              !strcmp( val.psz_string,
                        val_list.p_list->p_values[i].psz_string ) )
               menu->Check( i_item_id, TRUE );
+
+          if( val.psz_string ) free( val.psz_string );
           break;
 
         case VLC_VAR_INTEGER:
+          var_Get( p_object, psz_var, &val );
+
           menuitem =
               new wxMenuItemExt( menu, ++i_item_id,
                                  text_list.p_list->p_values[i].psz_string ?
@@ -667,7 +823,31 @@ wxMenu *Menu::CreateChoicesMenu( char *psz_var, vlc_object_t *p_object,
 
           menu->Append( menuitem );
 
-          if( val_list.p_list->p_values[i].i_int == val.i_int )
+          if( !(i_type & VLC_VAR_ISCOMMAND) &&
+              val_list.p_list->p_values[i].i_int == val.i_int )
+              menu->Check( i_item_id, TRUE );
+          break;
+
+        case VLC_VAR_FLOAT:
+          var_Get( p_object, psz_var, &val );
+
+          menuitem =
+              new wxMenuItemExt( menu, ++i_item_id,
+                                 text_list.p_list->p_values[i].psz_string ?
+                                 (wxString)wxU(
+                                   text_list.p_list->p_values[i].psz_string) :
+                                 wxString::Format(wxT("%.2f"),
+                                 val_list.p_list->p_values[i].f_float),wxT(""),
+                                 i_type & VLC_VAR_ISCOMMAND ?
+                                   wxITEM_NORMAL : wxITEM_RADIO,
+                                 strdup(psz_var),
+                                 p_object->i_object_id,
+                                 val_list.p_list->p_values[i], i_type );
+
+          menu->Append( menuitem );
+
+          if( !(i_type & VLC_VAR_ISCOMMAND) &&
+              val_list.p_list->p_values[i].f_float == val.f_float )
               menu->Check( i_item_id, TRUE );
           break;
 
@@ -677,42 +857,11 @@ wxMenu *Menu::CreateChoicesMenu( char *psz_var, vlc_object_t *p_object,
     }
 
     /* clean up everything */
-    if( (i_type & VLC_VAR_TYPE) == VLC_VAR_STRING ) free( val.psz_string );
     var_Change( p_object, psz_var, VLC_VAR_FREELIST, &val_list, &text_list );
 
     return menu;
 }
 
-void Menu::OnShowDialog( wxCommandEvent& event )
-{
-    if( p_intf->p_sys->pf_show_dialog )
-    {
-        int i_id;
-
-        switch( event.GetId() )
-        {
-        case OpenFileSimple_Event:
-            i_id = INTF_DIALOG_FILE_SIMPLE;
-            break;
-        case OpenFile_Event:
-            i_id = INTF_DIALOG_FILE;
-            break;
-        case OpenDisc_Event:
-            i_id = INTF_DIALOG_DISC;
-            break;
-        case OpenNet_Event:
-            i_id = INTF_DIALOG_NET;
-            break;
-        default:
-            i_id = INTF_DIALOG_FILE;
-            break;
-
-        }
-
-        p_intf->p_sys->pf_show_dialog( p_intf, i_id, 1, 0 );
-    }
-}
-
 /*****************************************************************************
  * A small helper class which intercepts all popup menu events
  *****************************************************************************/
@@ -748,6 +897,18 @@ void MenuEvtHandler::OnShowDialog( wxCommandEvent& event )
         case OpenNet_Event:
             i_id = INTF_DIALOG_NET;
             break;
+        case OpenCapture_Event:
+            i_id = INTF_DIALOG_CAPTURE;
+            break;
+        case MediaInfo_Event:
+            i_id = INTF_DIALOG_FILEINFO;
+            break;
+        case Messages_Event:
+            i_id = INTF_DIALOG_MESSAGES;
+            break;
+        case Preferences_Event:
+            i_id = INTF_DIALOG_PREFS;
+            break;
         default:
             i_id = INTF_DIALOG_FILE;
             break;
@@ -761,6 +922,49 @@ void MenuEvtHandler::OnShowDialog( wxCommandEvent& event )
 void MenuEvtHandler::OnMenuEvent( wxCommandEvent& event )
 {
     wxMenuItem *p_menuitem = NULL;
+    int i_hotkey_event = p_intf->p_sys->i_first_hotkey_event;
+    int i_hotkeys = p_intf->p_sys->i_hotkeys;
+
+    if( event.GetId() >= Play_Event && event.GetId() <= Stop_Event )
+    {
+        input_thread_t *p_input;
+        playlist_t * p_playlist =
+            (playlist_t *)vlc_object_find( p_intf, VLC_OBJECT_PLAYLIST,
+                                           FIND_ANYWHERE );
+        if( !p_playlist ) return;
+
+        switch( event.GetId() )
+        {
+        case Play_Event:
+        case Pause_Event:
+            p_input =
+                (input_thread_t *)vlc_object_find( p_intf, VLC_OBJECT_INPUT,
+                                                   FIND_ANYWHERE );
+            if( !p_input ) playlist_Play( p_playlist );
+            else
+            {
+                vlc_value_t val;
+                var_Get( p_input, "state", &val );
+                if( val.i_int != PAUSE_S ) val.i_int = PAUSE_S;
+                else val.i_int = PLAYING_S;
+                var_Set( p_input, "state", val );
+                vlc_object_release( p_input );
+            }
+            break;
+        case Stop_Event:
+            playlist_Stop( p_playlist );
+            break;
+        case Previous_Event:
+            playlist_Prev( p_playlist );
+            break;
+        case Next_Event:
+            playlist_Next( p_playlist );
+            break;
+        }
+
+        vlc_object_release( p_playlist );
+        return;
+    }
 
     /* Check if this is an auto generated menu item */
     if( event.GetId() < FirstAutoGenerated_Event )
@@ -769,13 +973,27 @@ void MenuEvtHandler::OnMenuEvent( wxCommandEvent& event )
         return;
     }
 
+    /* Check if this is an hotkey event */
+    if( event.GetId() >= i_hotkey_event &&
+        event.GetId() < i_hotkey_event + i_hotkeys )
+    {
+        vlc_value_t val;
+
+        val.i_int =
+            p_intf->p_vlc->p_hotkeys[event.GetId() - i_hotkey_event].i_key;
+
+        /* Get the key combination and send it to the hotkey handler */
+        var_Set( p_intf->p_vlc, "key-pressed", val );
+        return;
+    }
+
     if( !p_main_interface ||
         (p_menuitem = p_main_interface->GetMenuBar()->FindItem(event.GetId()))
         == NULL )
     {
         if( p_intf->p_sys->p_popup_menu )
         {
-            p_menuitem = 
+            p_menuitem =
                 p_intf->p_sys->p_popup_menu->FindItem( event.GetId() );
         }
     }
@@ -789,7 +1007,9 @@ void MenuEvtHandler::OnMenuEvent( wxCommandEvent& event )
                                        p_menuitemext->i_object_id );
         if( p_object == NULL ) return;
 
+        wxMutexGuiLeave(); // We don't want deadlocks
         var_Set( p_object, p_menuitemext->psz_var, p_menuitemext->val );
+        //wxMutexGuiEnter();
 
         vlc_object_release( p_object );
     }