]> git.sesse.net Git - vlc/blobdiff - modules/gui/wxwindows/preferences.cpp
- Fix playlist deadlock between Timer and Playlist stuff
[vlc] / modules / gui / wxwindows / preferences.cpp
index 6613a413e438681724e79dbd45f4989444e616c9..7326c0a84b48a0935aeb6d1fa05cc4782db15fd8 100644 (file)
@@ -1,8 +1,8 @@
 /*****************************************************************************
  * preferences.cpp : wxWindows plugin for vlc
  *****************************************************************************
- * Copyright (C) 2000-2001 VideoLAN
- * $Id: preferences.cpp,v 1.2 2003/03/29 01:50:12 gbazin Exp $
+ * Copyright (C) 2000-2004 VideoLAN
+ * $Id$
  *
  * Authors: Gildas Bazin <gbazin@netcourrier.com>
  *
 #include <stdio.h>
 
 #include <vlc/vlc.h>
+#include <vlc/intf.h>
 
-#ifdef WIN32                                                 /* mingw32 hack */
-#undef Yield
-#undef CreateDialog
-#endif
+#include <vlc_config_cat.h>
 
-/* Let vlc take care of the i18n stuff */
-#define WXINTL_NO_GETTEXT_MACRO
+#include "wxwindows.h"
+#include "preferences_widgets.h"
 
-#include <wx/wxprec.h>
-#include <wx/wx.h>
-#include <wx/window.h>
-#include <wx/notebook.h>
-#include <wx/textctrl.h>
 #include <wx/combobox.h>
-#include <wx/spinctrl.h>
 #include <wx/statline.h>
-#include <wx/treectrl.h>
 #include <wx/clntdata.h>
 #include <wx/dynarray.h>
+#include <wx/imaglist.h>
 
-#include <vlc/intf.h>
-
-#include "wxwindows.h"
+#include "bitmaps/type_net.xpm"
+#include "bitmaps/codec.xpm"
+#include "bitmaps/video.xpm"
+#include "bitmaps/type_playlist.xpm"
+#include "bitmaps/advanced.xpm"
+#include "bitmaps/intf.xpm"
+#include "bitmaps/audio.xpm"
 
 #ifndef wxRB_SINGLE
 #   define wxRB_SINGLE 0
 #endif
 
+#define TYPE_CATEGORY 0
+#define TYPE_CATSUBCAT 1  /* Category with embedded subcategory */
+#define TYPE_SUBCATEGORY 2
+#define TYPE_MODULE 3
+
 /*****************************************************************************
  * Classes declarations.
  *****************************************************************************/
+class ConfigTreeData;
 class PrefsTreeCtrl : public wxTreeCtrl
 {
 public:
@@ -71,9 +73,15 @@ public:
                    PrefsDialog *p_prefs_dialog, wxBoxSizer *_p_sizer );
     virtual ~PrefsTreeCtrl();
 
+    void ApplyChanges();
+    void CleanChanges();
+
 private:
     /* Event handlers (these functions should _not_ be virtual) */
     void OnSelectTreeItem( wxTreeEvent& event );
+    void OnAdvanced( wxCommandEvent& event );
+
+    ConfigTreeData *FindModuleConfig( ConfigTreeData *config_data );
 
     DECLARE_EVENT_TABLE()
 
@@ -81,50 +89,61 @@ private:
     PrefsDialog *p_prefs_dialog;
     wxBoxSizer *p_sizer;
     wxWindow *p_parent;
+    vlc_bool_t b_advanced;
+
+    wxTreeItemId root_item;
+    wxTreeItemId plugins_item;
 };
 
-WX_DEFINE_ARRAY(wxEvtHandler *, ArrayOfControls);
+WX_DEFINE_ARRAY(ConfigControl *, ArrayOfConfigControls);
 
-class PrefsPanel : public wxScrolledWindow
+class PrefsPanel : public wxPanel
 {
 public:
 
     PrefsPanel() { }
     PrefsPanel( wxWindow *parent, intf_thread_t *_p_intf,
-                module_t *p_module, char * );
+                PrefsDialog *, ConfigTreeData* );
     virtual ~PrefsPanel() {}
 
-private:
-    void OnFileBrowse( wxCommandEvent& WXUNUSED(event) );
-    void OnDirectoryBrowse( wxCommandEvent& WXUNUSED(event) );
-    DECLARE_EVENT_TABLE()
+    void ApplyChanges();
+    void SwitchAdvanced( vlc_bool_t );
 
+private:
     intf_thread_t *p_intf;
-    ArrayOfControls controls_array;
-};
+    PrefsDialog *p_prefs_dialog;
 
-class ConfigTreeData : public wxTreeItemData
-{
-public:
+    vlc_bool_t b_advanced;
 
-    ConfigTreeData() { panel == NULL; }
-    virtual ~ConfigTreeData() { if( panel ) delete panel; }
+    wxStaticText *hidden_text;
+    wxBoxSizer *config_sizer;
+    wxScrolledWindow *config_window;
 
-    wxWindow *panel;
-    wxBoxSizer *sizer;
+    ArrayOfConfigControls config_array;
 };
 
-class ConfigData : public wxClientData
+class ConfigTreeData : public wxTreeItemData
 {
 public:
-    ConfigData() { b_advanced = VLC_FALSE; }
-    ConfigData( vlc_bool_t _b_advanced ) { b_advanced = _b_advanced; }
-    virtual ~ConfigData() { }
 
-    vlc_bool_t IsAdvanced() { return b_advanced; }
+    ConfigTreeData() { b_submodule = 0; panel = NULL; psz_name = NULL;
+                       psz_help = NULL; }
+    virtual ~ConfigTreeData() {
+                                 if( panel ) delete panel;
+                                 if( psz_name ) free( psz_name );
+                                 if( psz_help ) free( psz_help );
+                              };
 
-private:
-    vlc_bool_t b_advanced;
+    vlc_bool_t b_submodule;
+
+    PrefsPanel *panel;
+    wxBoxSizer *sizer;
+
+    int i_object_id;
+    int i_subcat_id;
+    int i_type;
+    char *psz_name;
+    char *psz_help;
 };
 
 /*****************************************************************************
@@ -136,14 +155,20 @@ enum
 {
     Notebook_Event = wxID_HIGHEST,
     MRL_Event,
-
+    ResetAll_Event,
+    Advanced_Event,
 };
 
-BEGIN_EVENT_TABLE(PrefsDialog, wxDialog)
+BEGIN_EVENT_TABLE(PrefsDialog, wxFrame)
     /* Button events */
     EVT_BUTTON(wxID_OK, PrefsDialog::OnOk)
     EVT_BUTTON(wxID_CANCEL, PrefsDialog::OnCancel)
+    EVT_BUTTON(wxID_SAVE, PrefsDialog::OnSave)
+    EVT_BUTTON(ResetAll_Event, PrefsDialog::OnResetAll)
+    EVT_CHECKBOX(Advanced_Event, PrefsDialog::OnAdvanced)
 
+    /* Don't destroy the window when the user closes it */
+    EVT_CLOSE(PrefsDialog::OnCancel)
 END_EVENT_TABLE()
 
 // menu and control ids
@@ -154,32 +179,19 @@ enum
 
 BEGIN_EVENT_TABLE(PrefsTreeCtrl, wxTreeCtrl)
     EVT_TREE_SEL_CHANGED(PrefsTree_Ctrl, PrefsTreeCtrl::OnSelectTreeItem)
-END_EVENT_TABLE()
-
-enum
-{
-    FileBrowse_Event = wxID_HIGHEST,
-    DirectoryBrowse_Event,
-
-};
-
-BEGIN_EVENT_TABLE(PrefsPanel, wxScrolledWindow)
-    /* Button events */
-    EVT_BUTTON(FileBrowse_Event, PrefsPanel::OnFileBrowse)
-    EVT_BUTTON(DirectoryBrowse_Event, PrefsPanel::OnDirectoryBrowse)
-
+    EVT_COMMAND(Advanced_Event, wxEVT_USER_FIRST, PrefsTreeCtrl::OnAdvanced)
 END_EVENT_TABLE()
 
 /*****************************************************************************
  * Constructor.
  *****************************************************************************/
-PrefsDialog::PrefsDialog( intf_thread_t *_p_intf, Interface *_p_main_interface)
-  :  wxDialog( _p_main_interface, -1, _("Preferences"), wxDefaultPosition,
-               wxSize(600,400), wxDEFAULT_FRAME_STYLE )
+PrefsDialog::PrefsDialog( intf_thread_t *_p_intf, wxWindow *p_parent)
+  :  wxFrame( p_parent, -1, wxU(_("Preferences")), wxDefaultPosition,
+              wxSize(700,450), wxDEFAULT_FRAME_STYLE )
 {
     /* Initializations */
     p_intf = _p_intf;
-    p_main_interface = _p_main_interface;
+    SetIcon( *p_intf->p_sys->p_icon );
 
     /* Create a panel to put everything in */
     wxPanel *panel = new wxPanel( this, -1 );
@@ -187,21 +199,42 @@ PrefsDialog::PrefsDialog( intf_thread_t *_p_intf, Interface *_p_main_interface)
 
     /* Create the preferences tree control */
     wxBoxSizer *controls_sizer = new wxBoxSizer( wxHORIZONTAL );
-    PrefsTreeCtrl *prefs_tree =
+    prefs_tree =
         new PrefsTreeCtrl( panel, p_intf, this, controls_sizer );
 
     /* Separation */
     wxStaticLine *static_line = new wxStaticLine( panel, wxID_OK );
 
     /* Create the buttons */
-    wxButton *ok_button = new wxButton( panel, wxID_OK, _("OK") );
+    wxButton *ok_button = new wxButton( panel, wxID_OK, wxU(_("OK")) );
     ok_button->SetDefault();
-    wxButton *cancel_button = new wxButton( panel, wxID_CANCEL, _("Cancel") );
+    wxButton *cancel_button = new wxButton( panel, wxID_CANCEL,
+                                            wxU(_("Cancel")) );
+    wxButton *save_button = new wxButton( panel, wxID_SAVE, wxU(_("Save")) );
+    wxButton *reset_button = new wxButton( panel, ResetAll_Event,
+                                           wxU(_("Reset All")) );
+
+    wxPanel *dummy_panel = new wxPanel( this, -1 );
+    wxCheckBox *advanced_checkbox =
+        new wxCheckBox( panel, Advanced_Event, wxU(_("Advanced options")) );
+
+    if( config_GetInt( p_intf, "advanced" ) )
+    {
+        advanced_checkbox->SetValue(TRUE);
+        wxCommandEvent dummy_event;
+        dummy_event.SetInt(TRUE);
+        OnAdvanced( dummy_event );
+    }
 
     /* Place everything in sizers */
     wxBoxSizer *button_sizer = new wxBoxSizer( wxHORIZONTAL );
     button_sizer->Add( ok_button, 0, wxALL, 5 );
     button_sizer->Add( cancel_button, 0, wxALL, 5 );
+    button_sizer->Add( save_button, 0, wxALL, 5 );
+    button_sizer->Add( reset_button, 0, wxALL, 5 );
+    button_sizer->Add( dummy_panel, 1, wxALL, 5 );
+    button_sizer->Add( advanced_checkbox, 0, wxALL | wxALIGN_RIGHT |
+                       wxALIGN_CENTER_VERTICAL, 0 );
     button_sizer->Layout();
 
     wxBoxSizer *main_sizer = new wxBoxSizer( wxVERTICAL );
@@ -209,7 +242,7 @@ PrefsDialog::PrefsDialog( intf_thread_t *_p_intf, Interface *_p_main_interface)
     panel_sizer->Add( controls_sizer, 1, wxEXPAND | wxALL, 5 );
     panel_sizer->Add( static_line, 0, wxEXPAND | wxALL, 5 );
     panel_sizer->Add( button_sizer, 0, wxALIGN_LEFT | wxALIGN_BOTTOM |
-                      wxALL, 5 );
+                      wxALL | wxEXPAND, 5 );
     panel_sizer->Layout();
     panel->SetSizer( panel_sizer );
     main_sizer->Add( panel, 1, wxEXPAND, 0 );
@@ -231,59 +264,46 @@ PrefsDialog::~PrefsDialog()
  *****************************************************************************/
 void PrefsDialog::OnOk( wxCommandEvent& WXUNUSED(event) )
 {
+    prefs_tree->ApplyChanges();
     this->Hide();
+    prefs_tree->CleanChanges();
 }
 
 void PrefsDialog::OnCancel( wxCommandEvent& WXUNUSED(event) )
 {
     this->Hide();
+    prefs_tree->CleanChanges();
 }
 
-void PrefsTreeCtrl::OnSelectTreeItem( wxTreeEvent& event )
+void PrefsDialog::OnSave( wxCommandEvent& WXUNUSED(event) )
 {
-    ConfigTreeData *config_data;
-
-    config_data = (ConfigTreeData *)GetItemData( event.GetOldItem() );
-    if( config_data && config_data->panel )
-    {
-        config_data->panel->Hide();
-        p_sizer->Remove( config_data->panel );
-    }
-
-    config_data = (ConfigTreeData *)GetItemData( event.GetItem() );
-    if( config_data && config_data->panel )
-    {
-        config_data->panel->Show();
-        config_data->panel->FitInside();
-        p_sizer->Add( config_data->panel, 2, wxEXPAND | wxALL, 0 );
-        p_sizer->Layout();
-    }
+    prefs_tree->ApplyChanges();
+    config_SaveConfigFile( p_intf, NULL );
+    this->Hide();
 }
 
-void PrefsPanel::OnFileBrowse( wxCommandEvent& WXUNUSED(event) )
+void PrefsDialog::OnResetAll( wxCommandEvent& WXUNUSED(event) )
 {
-    wxFileDialog dialog( this, _("Open file"), "", "", "*.*",
-                         wxOPEN );
+    wxMessageDialog dlg( this,
+        wxU(_("Beware this will reset your VLC media player preferences.\n"
+              "Are you sure you want to continue?")),
+        wxU(_("Reset Preferences")), wxYES_NO|wxNO_DEFAULT|wxCENTRE );
 
-    if( dialog.ShowModal() == wxID_OK )
+    if ( dlg.ShowModal() == wxID_YES )
     {
-#if 0
-        file_combo->SetValue( dialog.GetPath() );      
-#endif
+        /* TODO: need to reset all the controls */
+        config_ResetAll( p_intf );
+        prefs_tree->CleanChanges();
+        config_SaveConfigFile( p_intf, NULL );
     }
 }
 
-void PrefsPanel::OnDirectoryBrowse( wxCommandEvent& WXUNUSED(event) )
+void PrefsDialog::OnAdvanced( wxCommandEvent& event )
 {
-    wxFileDialog dialog( this, _("Open file"), "", "", "*.*",
-                         wxOPEN );
+    wxCommandEvent newevent( wxEVT_USER_FIRST, Advanced_Event );
+    newevent.SetInt( event.GetInt() );
 
-    if( dialog.ShowModal() == wxID_OK )
-    {
-#if 0
-        file_combo->SetValue( dialog.GetPath() );      
-#endif
-    }
+    prefs_tree->AddPendingEvent( newevent );
 }
 
 /*****************************************************************************
@@ -292,12 +312,12 @@ void PrefsPanel::OnDirectoryBrowse( wxCommandEvent& WXUNUSED(event) )
 PrefsTreeCtrl::PrefsTreeCtrl( wxWindow *_p_parent, intf_thread_t *_p_intf,
                               PrefsDialog *_p_prefs_dialog,
                               wxBoxSizer *_p_sizer )
-  : wxTreeCtrl( _p_parent, PrefsTree_Ctrl, wxDefaultPosition, wxDefaultSize,
+  : wxTreeCtrl( _p_parent, PrefsTree_Ctrl, wxDefaultPosition, wxSize(200,-1),
                 wxTR_NO_LINES | wxTR_FULL_ROW_HIGHLIGHT |
                 wxTR_LINES_AT_ROOT | wxTR_HIDE_ROOT |
                 wxTR_HAS_BUTTONS | wxTR_TWIST_BUTTONS | wxSUNKEN_BORDER )
 {
-    vlc_list_t      *p_list;
+    vlc_list_t      *p_list = NULL;;
     module_t        *p_module;
     module_config_t *p_item;
     int i_index;
@@ -307,16 +327,25 @@ PrefsTreeCtrl::PrefsTreeCtrl( wxWindow *_p_parent, intf_thread_t *_p_intf,
     p_prefs_dialog = _p_prefs_dialog;
     p_sizer = _p_sizer;
     p_parent = _p_parent;
+    b_advanced = VLC_FALSE;
 
-    wxTreeItemId root_item = AddRoot( "" );
+    root_item = AddRoot( wxT("") );
+
+    wxImageList *p_images = new wxImageList( 16,16,TRUE );
+    p_images->Add( wxIcon( audio_xpm ) );
+    p_images->Add( wxIcon( video_xpm ) );
+    p_images->Add( wxIcon( codec_xpm ) );
+    p_images->Add( wxIcon( type_net_xpm ) );
+    p_images->Add( wxIcon( advanced_xpm ) );
+    p_images->Add( wxIcon( type_playlist_xpm ) );
+    p_images->Add( wxIcon( intf_xpm ) );
+    AssignImageList( p_images );
 
     /* List the plugins */
     p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE, FIND_ANYWHERE );
     if( !p_list ) return;
 
-    /*
-     * Build a tree of the main options
-     */
+    /* Build the categories list */
     for( i_index = 0; i_index < p_list->i_count; i_index++ )
     {
         p_module = (module_t *)p_list->p_values[i_index].p_object;
@@ -325,86 +354,218 @@ PrefsTreeCtrl::PrefsTreeCtrl( wxWindow *_p_parent, intf_thread_t *_p_intf,
     }
     if( i_index < p_list->i_count )
     {
+        wxTreeItemId current_item;
+        char *psz_help;
         /* We found the main module */
 
-        /* Enumerate config options and add corresponding config boxes */
+        /* Enumerate config categories and store a reference so we can
+         * generate their config panel them when it is asked by the user. */
         p_item = p_module->p_config;
 
         if( p_item ) do
         {
-            if( p_item->b_advanced && !config_GetInt( p_intf, "advanced" ))
-            {
-                continue;
-            }
+            ConfigTreeData *config_data;
             switch( p_item->i_type )
             {
-            case CONFIG_HINT_CATEGORY:
-                ConfigTreeData *config_data = new ConfigTreeData;
-                config_data->panel =
-                    new PrefsPanel( p_parent, p_intf,
-                                    p_module, p_item->psz_text );
-                config_data->panel->Hide();
+            case CONFIG_CATEGORY:
+                config_data = new ConfigTreeData;
+                config_data->psz_name = strdup( config_CategoryNameGet(
+                                                            p_item->i_value ) );
+                psz_help = config_CategoryHelpGet( p_item->i_value );
+                if( psz_help )
+                {
+                    config_data->psz_help = wraptext( strdup( psz_help ),
+                                                      72 , ISUTF8 );
+                }
+                else
+                {
+                    config_data->psz_help = NULL;
+                }
+                config_data->i_type = TYPE_CATEGORY;
+                config_data->i_object_id = p_item->i_value;
 
                 /* Add the category to the tree */
-                AppendItem( root_item, p_item->psz_text, -1, -1, config_data );
+                current_item = AppendItem( root_item,
+                                           wxU( config_data->psz_name ),
+                                           -1, -1, config_data );
+
+                switch( p_item->i_value )
+                {
+                    case CAT_AUDIO:
+                        SetItemImage( current_item, 0 );break;
+                    case CAT_VIDEO:
+                        SetItemImage( current_item, 1 );break;
+                    case CAT_INPUT:
+                        SetItemImage( current_item, 2 );break;
+                    case CAT_SOUT:
+                        SetItemImage( current_item, 3 );break;
+                    case CAT_ADVANCED:
+                        SetItemImage( current_item, 4 );break;
+                    case CAT_PLAYLIST:
+                        SetItemImage( current_item, 5 );break;
+                    case CAT_INTERFACE:
+                        SetItemImage( current_item, 6 );break;
+                }
+                break;
+            case CONFIG_SUBCATEGORY:
+                if( p_item->i_value == SUBCAT_VIDEO_GENERAL ||
+                    p_item->i_value == SUBCAT_AUDIO_GENERAL )
+                {
+                    ConfigTreeData *cd = (ConfigTreeData *)
+                                            GetItemData( current_item );
+                    cd->i_type = TYPE_CATSUBCAT;
+                    cd->i_subcat_id = p_item->i_value;
+                    if( cd->psz_name ) free( cd->psz_name );
+                    cd->psz_name = strdup(  config_CategoryNameGet(
+                                                      p_item->i_value ) );
+                    if( cd->psz_help ) free( cd->psz_help );
+                    char *psz_help = config_CategoryHelpGet( p_item->i_value );
+                    if( psz_help )
+                    {
+                        cd->psz_help = wraptext( strdup( psz_help ),72 ,
+                                                 ISUTF8 );
+                    }
+                    else
+                    {
+                        cd->psz_help = NULL;
+                    }
+                    continue;
+                }
+
+                config_data = new ConfigTreeData;
+
+                config_data->psz_name = strdup(  config_CategoryNameGet(
+                                                           p_item->i_value ) );
+                psz_help = config_CategoryHelpGet( p_item->i_value );
+                if( psz_help )
+                {
+                    config_data->psz_help = wraptext( strdup( psz_help ) ,
+                                                      72 , ISUTF8 );
+                }
+                else
+                {
+                    config_data->psz_help = NULL;
+                }
+                config_data->i_type = TYPE_SUBCATEGORY;
+                config_data->i_object_id = p_item->i_value;
+                AppendItem( current_item, wxU( config_data->psz_name ),
+                            -1, -1, config_data );
                 break;
             }
         }
         while( p_item->i_type != CONFIG_HINT_END && p_item++ );
 
-        SortChildren( root_item );
     }
 
+
     /*
      * Build a tree of all the plugins
      */
-
-    wxTreeItemId plugins_item = AppendItem( root_item, _("Plugins") );
-
     for( i_index = 0; i_index < p_list->i_count; i_index++ )
     {
+        int i_category = -1;
+        int i_subcategory = -1;
+        int i_options = 0;
+
         p_module = (module_t *)p_list->p_values[i_index].p_object;
 
-        /* Find the capabiltiy child item */
-        long cookie; size_t i_child_index;
-        wxTreeItemId capability_item = GetFirstChild( plugins_item, cookie);
-        for( i_child_index = 0;
-             i_child_index < GetChildrenCount( plugins_item, FALSE );
-             i_child_index++ )
+        /* Exclude the main module */
+        if( !strcmp( p_module->psz_object_name, "main" ) )
+            continue;
+
+        /* Exclude empty plugins (submodules don't have config options, they
+         * are stored in the parent module) */
+        if( p_module->b_submodule )
+              continue;
+//            p_item = ((module_t *)p_module->p_parent)->p_config;
+        else
+            p_item = p_module->p_config;
+
+
+        if( !p_item ) continue;
+        do
+        {
+            if( p_item->i_type == CONFIG_CATEGORY )
+            {
+                i_category = p_item->i_value;
+            }
+            else if( p_item->i_type == CONFIG_SUBCATEGORY )
+            {
+                i_subcategory = p_item->i_value;
+            }
+            if( p_item->i_type & CONFIG_ITEM )
+                i_options ++;
+            if( i_options > 0 && i_category >= 0 && i_subcategory >= 0 )
+            {
+                break;
+            }
+        }
+        while( p_item->i_type != CONFIG_HINT_END && p_item++ );
+
+        if( !i_options ) continue;
+
+        /* Find the right category item */
+        long cookie;
+        vlc_bool_t b_found = VLC_FALSE;
+        wxTreeItemId category_item = GetFirstChild( root_item , cookie);
+        while( category_item.IsOk() )
         {
-            if( !GetItemText(capability_item).Cmp(p_module->psz_capability) )
+            ConfigTreeData *config_data =
+                    (ConfigTreeData *)GetItemData( category_item );
+            if( config_data->i_object_id == i_category )
             {
+                b_found = VLC_TRUE;
                 break;
             }
-            capability_item = GetNextChild( plugins_item, cookie );
+            category_item = GetNextChild( root_item, cookie );
         }
 
-        if( i_child_index == GetChildrenCount( plugins_item, FALSE ) )
+        if( !b_found ) continue;
+
+        /* Find subcategory item */
+        b_found = VLC_FALSE;
+        cookie = -1;
+        wxTreeItemId subcategory_item = GetFirstChild( category_item, cookie );
+        while( subcategory_item.IsOk() )
         {
-            /* We didn't find it, add it */
-            capability_item = AppendItem( plugins_item,
-                                          p_module->psz_capability );
+            ConfigTreeData *config_data =
+                    (ConfigTreeData *)GetItemData( subcategory_item );
+            if( config_data->i_object_id == i_subcategory )
+            {
+                b_found = VLC_TRUE;
+                break;
+            }
+            subcategory_item = GetNextChild( category_item, cookie );
+        }
+        if( !b_found )
+        {
+            subcategory_item = category_item;
         }
 
         /* Add the plugin to the tree */
         ConfigTreeData *config_data = new ConfigTreeData;
-        config_data->panel =
-            new PrefsPanel( p_parent, p_intf, p_module, NULL );
-        config_data->panel->Hide();
-        AppendItem( capability_item, p_module->psz_object_name, -1, -1,
+        config_data->b_submodule = p_module->b_submodule;
+        config_data->i_type = TYPE_MODULE;
+        config_data->i_object_id = p_module->b_submodule ?
+            ((module_t *)p_module->p_parent)->i_object_id :
+            p_module->i_object_id;
+        config_data->psz_help = NULL;
+
+        AppendItem( subcategory_item, wxU( p_module->psz_shortname ?
+                       p_module->psz_shortname : p_module->psz_object_name )
+                                    , -1, -1,
                     config_data );
     }
 
     /* Sort all this mess */
     long cookie; size_t i_child_index;
-    SortChildren( plugins_item );
-    wxTreeItemId capability_item = GetFirstChild( plugins_item, cookie);
+    wxTreeItemId capability_item = GetFirstChild( root_item, cookie);
     for( i_child_index = 0;
          i_child_index < GetChildrenCount( plugins_item, FALSE );
          i_child_index++ )
     {
-        capability_item = GetNextChild( plugins_item, cookie );
         SortChildren( capability_item );
+        capability_item = GetNextChild( plugins_item, cookie );
     }
 
     /* Clean-up everything */
@@ -413,174 +574,479 @@ PrefsTreeCtrl::PrefsTreeCtrl( wxWindow *_p_parent, intf_thread_t *_p_intf,
     p_sizer->Add( this, 1, wxEXPAND | wxALL, 0 );
     p_sizer->Layout();
 
+    /* Update Tree Ctrl */
+#ifndef WIN32 /* Workaround a bug in win32 implementation */
+    SelectItem( GetFirstChild( root_item, cookie ) );
+#endif
+
+    Expand( root_item );
 }
 
 PrefsTreeCtrl::~PrefsTreeCtrl()
 {
 }
 
+void PrefsTreeCtrl::ApplyChanges()
+{
+    long cookie, cookie2, cookie3;
+    ConfigTreeData *config_data;
+
+    wxTreeItemId category = GetFirstChild( root_item, cookie );
+    while( category.IsOk() )
+    {
+        wxTreeItemId subcategory = GetFirstChild( category, cookie2 );
+        while( subcategory.IsOk() )
+        {
+            wxTreeItemId module = GetFirstChild( subcategory, cookie3 );
+            while( module.IsOk() )
+            {
+                config_data = (ConfigTreeData *)GetItemData( module );
+                if( config_data && config_data->panel )
+                {
+                    config_data->panel->ApplyChanges();
+                }
+                module = GetNextChild( subcategory, cookie3 );
+            }
+            config_data = (ConfigTreeData *)GetItemData( subcategory );
+            if( config_data && config_data->panel )
+            {
+                config_data->panel->ApplyChanges();
+            }
+            subcategory = GetNextChild( category, cookie2 );
+        }
+        config_data = (ConfigTreeData *)GetItemData( category );
+        if( config_data && config_data->panel )
+        {
+            config_data->panel->ApplyChanges();
+        }
+        category = GetNextChild( root_item, cookie );
+    }
+}
+
+void PrefsTreeCtrl::CleanChanges()
+{
+    long cookie, cookie2, cookie3;
+    ConfigTreeData *config_data;
+
+    config_data = !GetSelection() ? NULL :
+        FindModuleConfig( (ConfigTreeData *)GetItemData( GetSelection() ) );
+    if( config_data  )
+    {
+        config_data->panel->Hide();
+        p_sizer->Remove( config_data->panel );
+    }
+
+    wxTreeItemId category = GetFirstChild( root_item, cookie );
+    while( category.IsOk() )
+    {
+        wxTreeItemId subcategory = GetFirstChild( category, cookie2 );
+        while( subcategory.IsOk() )
+        {
+            wxTreeItemId module = GetFirstChild( subcategory, cookie3 );
+            while( module.IsOk() )
+            {
+                config_data = (ConfigTreeData *)GetItemData( module );
+                if( config_data && config_data->panel )
+                {
+                    delete config_data->panel;
+                    config_data->panel = NULL;
+                }
+                module = GetNextChild( subcategory, cookie3 );
+            }
+            config_data = (ConfigTreeData *)GetItemData( subcategory );
+            if( config_data && config_data->panel )
+            {
+                delete config_data->panel;
+                config_data->panel = NULL;
+            }
+            subcategory = GetNextChild( category, cookie2 );
+        }
+        config_data = (ConfigTreeData *)GetItemData( category );
+        if( config_data && config_data->panel )
+        {
+            delete config_data->panel;
+            config_data->panel = NULL;
+        }
+        category = GetNextChild( root_item, cookie );
+    }
+
+    if( GetSelection() )
+    {
+        wxTreeEvent event;
+        OnSelectTreeItem( event );
+    }
+}
+
+ConfigTreeData *PrefsTreeCtrl::FindModuleConfig( ConfigTreeData *config_data )
+{
+    /* We need this complexity because submodules don't have their own config
+     * options. They use the parent module ones. */
+
+    if( !config_data || !config_data->b_submodule )
+    {
+        return config_data;
+    }
+
+    long cookie, cookie2, cookie3;
+    ConfigTreeData *config_new;
+    wxTreeItemId category = GetFirstChild( root_item, cookie );
+    while( category.IsOk() )
+    {
+        wxTreeItemId subcategory = GetFirstChild( category, cookie2 );
+        while( subcategory.IsOk() )
+        {
+            wxTreeItemId module = GetFirstChild( subcategory, cookie3 );
+            while( module.IsOk() )
+            {
+                config_new = (ConfigTreeData *)GetItemData( module );
+                if( config_new && !config_new->b_submodule &&
+                    config_new->i_object_id == config_data->i_object_id )
+                {
+                    return config_new;
+                }
+                module = GetNextChild( subcategory, cookie3 );
+            }
+            subcategory = GetNextChild( category, cookie2 );
+        }
+        category = GetNextChild( root_item, cookie );
+    }
+
+    /* Found nothing */
+    return NULL;
+}
+
+void PrefsTreeCtrl::OnSelectTreeItem( wxTreeEvent& event )
+{
+    ConfigTreeData *config_data = NULL;
+
+    if( event.GetOldItem() )
+        config_data = FindModuleConfig( (ConfigTreeData *)GetItemData(
+                                        event.GetOldItem() ) );
+    if( config_data && config_data->panel )
+    {
+        config_data->panel->Hide();
+        p_sizer->Remove( config_data->panel );
+    }
+
+    /* Don't use event.GetItem() because we also send fake events */
+    config_data = FindModuleConfig( (ConfigTreeData *)GetItemData(
+                                    GetSelection() ) );
+    if( config_data )
+    {
+        if( !config_data->panel )
+        {
+            /* The panel hasn't been created yet. Let's do it. */
+            config_data->panel =
+                new PrefsPanel( p_parent, p_intf, p_prefs_dialog,
+                                config_data );
+            config_data->panel->SwitchAdvanced( b_advanced );
+        }
+        else
+        {
+            config_data->panel->SwitchAdvanced( b_advanced );
+            config_data->panel->Show();
+        }
+
+        p_sizer->Add( config_data->panel, 3, wxEXPAND | wxALL, 0 );
+        p_sizer->Layout();
+    }
+}
+
+void PrefsTreeCtrl::OnAdvanced( wxCommandEvent& event )
+{
+    b_advanced = event.GetInt();
+
+    ConfigTreeData *config_data = !GetSelection() ? NULL :
+        FindModuleConfig( (ConfigTreeData *)GetItemData( GetSelection() ) );
+    if( config_data  )
+    {
+        config_data->panel->Hide();
+        p_sizer->Remove( config_data->panel );
+    }
+
+    if( GetSelection() )
+    {
+        wxTreeEvent event;
+        OnSelectTreeItem( event );
+    }
+}
+
 /*****************************************************************************
  * PrefsPanel class definition.
  *****************************************************************************/
 PrefsPanel::PrefsPanel( wxWindow* parent, intf_thread_t *_p_intf,
-                        module_t *p_module, char *psz_section )
-  :  wxScrolledWindow( parent, -1, wxDefaultPosition, wxDefaultSize )
+                        PrefsDialog *_p_prefs_dialog,
+                        ConfigTreeData *config_data )
+  :  wxPanel( parent, -1, wxDefaultPosition, wxDefaultSize )
 {
     module_config_t *p_item;
-    vlc_list_t      *p_list;
-    module_t        *p_parser;
+    vlc_list_t *p_list = NULL;;
 
     wxStaticText *label;
-    wxComboBox *combo;
-    wxRadioButton *radio;
-    wxSpinCtrl *spin;
-    wxCheckBox *checkbox;
-    wxTextCtrl *textctrl;
-    wxButton *button;
-    wxStaticLine *static_line;
-    wxBoxSizer *horizontal_sizer;
-    wxSortedArrayString sorted_array;
+    wxStaticText *help;
     wxArrayString array;
 
+    module_t *p_module = NULL;
+
     /* Initializations */
     p_intf = _p_intf;
+    p_prefs_dialog =_p_prefs_dialog,
+
+    b_advanced = VLC_TRUE;
     SetAutoLayout( TRUE );
-    SetScrollRate( 5, 5 );
+    Hide();
 
     wxBoxSizer *sizer = new wxBoxSizer( wxVERTICAL );
 
-    /* Enumerate config options and add corresponding config boxes */
-    p_item = p_module->p_config;
 
-    /* Find the category if it has been specified */
-    if( psz_section && p_item->i_type == CONFIG_HINT_CATEGORY )
+    if( config_data->i_type == TYPE_CATEGORY )
     {
-        while( !p_item->i_type == CONFIG_HINT_CATEGORY ||
-               strcmp( psz_section, p_item->psz_text ) )
+        label = new wxStaticText( this, -1,wxU(_( config_data->psz_name )));
+        wxFont heading_font = label->GetFont();
+        heading_font.SetPointSize( heading_font.GetPointSize() + 5 );
+        label->SetFont( heading_font );
+        sizer->Add( label, 0, wxEXPAND | wxLEFT, 10 );
+        sizer->Add( new wxStaticLine( this, 0 ), 0,
+                    wxEXPAND | wxLEFT | wxRIGHT, 2 );
+
+        hidden_text = NULL;
+        help = new wxStaticText( this, -1, wxU(_( config_data->psz_help ) ) );
+        sizer->Add( help ,0 ,wxEXPAND | wxALL, 5 );
+
+        config_sizer = NULL; config_window = NULL;
+    }
+    else
+    {
+        /* Get a pointer to the module */
+        if( config_data->i_type == TYPE_MODULE )
         {
-            if( p_item->i_type == CONFIG_HINT_END )
-                break;
-            p_item++;
+            p_module = (module_t *)vlc_object_get( p_intf,
+                                                   config_data->i_object_id );
         }
-    }
+        else
+        {
+            /* List the plugins */
+            int i_index;
+            vlc_bool_t b_found = VLC_FALSE;
+            p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE, FIND_ANYWHERE );
+            if( !p_list ) return;
 
-    /* Add a head title to the panel */
-    wxStaticBox *static_box = new wxStaticBox( this, -1, "" );
-    wxStaticBoxSizer *box_sizer = new wxStaticBoxSizer( static_box,
-                                                        wxHORIZONTAL );
-    label = new wxStaticText( this, -1,
-                              psz_section ? p_item->psz_text :
-                              p_module->psz_longname );
+            for( i_index = 0; i_index < p_list->i_count; i_index++ )
+            {
+                p_module = (module_t *)p_list->p_values[i_index].p_object;
+                if( !strcmp( p_module->psz_object_name, "main" ) )
+                {
+                    b_found = VLC_TRUE;
+                    break;
+                }
+            }
+            if( !p_module && !b_found )
+            {
+                msg_Warn( p_intf, "ohoh, unable to find main module" );
+                return;
+            }
+        }
 
-    box_sizer->Add( label, 1, wxALL, 5 );
-    sizer->Add( box_sizer, 0, wxEXPAND | wxALL, 5 );
+        if( p_module->i_object_type != VLC_OBJECT_MODULE )
+        {
+            /* 0OOoo something went really bad */
+            return;
+        }
 
-    if( p_item ) do
-    {
-        if( p_item->b_advanced && !config_GetInt( p_intf, "advanced" ) )
+        /* Enumerate config options and add corresponding config boxes
+         * (submodules don't have config options, they are stored in the
+         *  parent module) */
+        if( p_module->b_submodule )
+            p_item = ((module_t *)p_module->p_parent)->p_config;
+        else
+            p_item = p_module->p_config;
+
+        /* Find the category if it has been specified */
+        if( config_data->i_type == TYPE_SUBCATEGORY ||
+            config_data->i_type == TYPE_CATSUBCAT )
         {
-            continue;
+            do
+            {
+                if( p_item->i_type == CONFIG_SUBCATEGORY &&
+                    ( config_data->i_type == TYPE_SUBCATEGORY &&
+                      p_item->i_value == config_data->i_object_id ) ||
+                    ( config_data->i_type == TYPE_CATSUBCAT &&
+                      p_item->i_value == config_data->i_subcat_id ) )
+                {
+                    break;
+                }
+                if( p_item->i_type == CONFIG_HINT_END )
+                    break;
+            } while( p_item++ );
         }
 
-        /* If a category has been specified, check we finished the job */
-        if( psz_section && p_item->i_type == CONFIG_HINT_CATEGORY &&
-            strcmp( psz_section, p_item->psz_text ) )
-            break;
+        /* Add a head title to the panel */
+        char *psz_head;
+        if( config_data->i_type == TYPE_SUBCATEGORY ||
+            config_data->i_type == TYPE_CATSUBCAT )
+        {
+            psz_head = config_data->psz_name;
+            p_item++;
+        }
+        else
+        {
+            psz_head = p_module->psz_longname;
+        }
 
-        switch( p_item->i_type )
+        label = new wxStaticText( this, -1,
+                      wxU(_( psz_head ? psz_head : _("Unknown") ) ) );
+        wxFont heading_font = label->GetFont();
+        heading_font.SetPointSize( heading_font.GetPointSize() + 5 );
+        label->SetFont( heading_font );
+        sizer->Add( label, 0, wxEXPAND | wxLEFT, 10 );
+        sizer->Add( new wxStaticLine( this, 0 ), 0,
+                    wxEXPAND | wxLEFT | wxRIGHT, 2 );
+
+        /* Now put all the config options into a scrolled window */
+        config_sizer = new wxBoxSizer( wxVERTICAL );
+        config_window = new wxScrolledWindow( this, -1, wxDefaultPosition,
+            wxDefaultSize, wxBORDER_NONE | wxHSCROLL | wxVSCROLL );
+        config_window->SetAutoLayout( TRUE );
+        config_window->SetScrollRate( 5, 5 );
+
+        if( p_item ) do
         {
-        case CONFIG_HINT_CATEGORY:
-#if 0
-            label = new wxStaticText(this, -1, p_item->psz_text);
-            sizer->Add( label, 0, wxALL, 5 );
-#endif
-            break;
+            /* If a category has been specified, check we finished the job */
+            if( ( ( config_data->i_type == TYPE_SUBCATEGORY &&
+                    p_item->i_value != config_data->i_object_id ) ||
+                  ( config_data->i_type == TYPE_CATSUBCAT  &&
+                    p_item->i_value != config_data->i_subcat_id ) ) &&
+                (p_item->i_type == CONFIG_CATEGORY ||
+                  p_item->i_type == CONFIG_SUBCATEGORY ) )
+                break;
 
-        case CONFIG_ITEM_MODULE:
-            label = new wxStaticText(this, -1, p_item->psz_text);
-            combo = new wxComboBox( this, -1, p_item->psz_value,
-                                    wxDefaultPosition, wxSize(200,-1),
-                                    0, NULL );
+            ConfigControl *control =
+                CreateConfigControl( VLC_OBJECT(p_intf),
+                                     p_item, config_window );
 
-            /* build a list of available modules */
-            p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE, FIND_ANYWHERE );
-            for( int i_index = 0; i_index < p_list->i_count; i_index++ )
-            {
-                p_parser = (module_t *)p_list->p_values[i_index].p_object ;
+            /* Don't add items that were not recognized */
+            if( control == NULL ) continue;
 
-                if( !strcmp( p_parser->psz_capability,
-                             p_item->psz_type ) )
-                {
-                    combo->Append( p_parser->psz_longname );
-                }
-            }
+            /* Add the config data to our array so we can keep a trace of it */
+            config_array.Add( control );
 
-            combo->SetToolTip( p_item->psz_longtext );
-            horizontal_sizer = new wxBoxSizer( wxHORIZONTAL );
-            horizontal_sizer->Add( label, 0, wxALL, 5 );
-            horizontal_sizer->Add( combo, 0, wxALL, 5 );
-            sizer->Add( horizontal_sizer, 0, wxALL, 5 );
-            break;
+            config_sizer->Add( control, 0, wxEXPAND | wxALL, 2 );
+        }
+        while( !( p_item->i_type == CONFIG_HINT_END ||
+               ( ( config_data->i_type == TYPE_SUBCATEGORY ||
+                   config_data->i_type == TYPE_CATSUBCAT ) &&
+                 ( p_item->i_type == CONFIG_CATEGORY ||
+                   p_item->i_type == CONFIG_SUBCATEGORY ) ) ) && p_item++ );
+
+
+        config_sizer->Layout();
+        config_window->SetSizer( config_sizer );
+        sizer->Add( config_window, 1, wxEXPAND | wxALL, 5 );
+        hidden_text = new wxStaticText( this, -1,
+                        wxU( _( "Some options are available but hidden. " \
+                                "Check \"Advanced options\" to see them." ) ) );
+        sizer->Add( hidden_text );
+
+        /* And at last put a useful help string if available */
+        if( config_data->psz_help && *config_data->psz_help )
+        {
+            sizer->Add( new wxStaticLine( this, 0 ), 0,
+                        wxEXPAND | wxLEFT | wxRIGHT, 2 );
+            help = new wxStaticText( this, -1, wxU(_(config_data->psz_help)),
+                                     wxDefaultPosition, wxDefaultSize,
+                                     wxALIGN_LEFT,
+                                     wxT("") );
+            sizer->Add( help ,0 ,wxEXPAND | wxALL, 5 );
+        }
 
+        if( config_data->i_type == TYPE_MODULE )
+        {
+            vlc_object_release( p_module );
+        }
+        else
+        {
+            vlc_list_release( p_list );
+        }
+    }
+    sizer->Layout();
+    SetSizer( sizer );
+    Show();
+}
+
+void PrefsPanel::ApplyChanges()
+{
+    vlc_value_t val;
+
+    for( size_t i = 0; i < config_array.GetCount(); i++ )
+    {
+        ConfigControl *control = config_array.Item(i);
+
+        switch( control->GetType() )
+        {
         case CONFIG_ITEM_STRING:
         case CONFIG_ITEM_FILE:
-            label = new wxStaticText(this, -1, p_item->psz_text);
-            textctrl = new wxTextCtrl( this, -1, p_item->psz_value,
-                                       wxDefaultPosition, wxDefaultSize,
-                                       wxTE_PROCESS_ENTER);
-            textctrl->SetToolTip( p_item->psz_longtext );
-            horizontal_sizer = new wxBoxSizer( wxHORIZONTAL );
-            horizontal_sizer->Add( label, 0, wxALL, 5 );
-            horizontal_sizer->Add( textctrl, 0, wxALL, 5 );
-            if( p_item->i_type == CONFIG_ITEM_FILE )
-            {
-                button = new wxButton( this, -1, _("Browse...") );
-                horizontal_sizer->Add( button, 0, wxALL, 5 );
-            }
-            sizer->Add( horizontal_sizer, 0, wxALL, 5 );
+        case CONFIG_ITEM_DIRECTORY:
+        case CONFIG_ITEM_MODULE:
+        case CONFIG_ITEM_MODULE_LIST:
+        case CONFIG_ITEM_MODULE_LIST_CAT:
+            config_PutPsz( p_intf, control->GetName().mb_str(),
+                           control->GetPszValue().mb_str() );
             break;
-
+        case CONFIG_ITEM_KEY:
+            /* So you don't need to restart to have the changes take effect */
+            val.i_int = control->GetIntValue();
+            var_Set( p_intf->p_vlc, control->GetName().mb_str(), val );
         case CONFIG_ITEM_INTEGER:
-            label = new wxStaticText(this, -1, p_item->psz_text);
-            spin = new wxSpinCtrl( this, -1,
-                                   wxString::Format(_("%d"), p_item->i_value),
-                                   wxDefaultPosition, wxDefaultSize,
-                                   wxSP_ARROW_KEYS,
-                                   0, 16000, p_item->i_value);
-            spin->SetToolTip( p_item->psz_longtext );
-            horizontal_sizer = new wxBoxSizer( wxHORIZONTAL );
-            horizontal_sizer->Add( label, 0, wxALL, 5 );
-            horizontal_sizer->Add( spin, 0, wxALL, 5 );
-            sizer->Add( horizontal_sizer, 0, wxALL, 5 );
+        case CONFIG_ITEM_BOOL:
+            config_PutInt( p_intf, control->GetName().mb_str(),
+                           control->GetIntValue() );
             break;
-
         case CONFIG_ITEM_FLOAT:
-            label = new wxStaticText(this, -1, p_item->psz_text);
-            spin = new wxSpinCtrl( this, -1,
-                                   wxString::Format(_("%d"), p_item->i_value),
-                                   wxDefaultPosition, wxDefaultSize,
-                                   wxSP_ARROW_KEYS,
-                                   0, 16000, p_item->i_value);
-            spin->SetToolTip( p_item->psz_longtext );
-            horizontal_sizer = new wxBoxSizer( wxHORIZONTAL );
-            horizontal_sizer->Add( label, 0, wxALL, 5 );
-            horizontal_sizer->Add( spin, 0, wxALL, 5 );
-            sizer->Add( horizontal_sizer, 0, wxALL, 5 );
-            break;
-
-        case CONFIG_ITEM_BOOL:
-            checkbox = new wxCheckBox( this, -1, p_item->psz_text );
-            if( p_item->i_value ) checkbox->SetValue(TRUE);
-            checkbox->SetToolTip( p_item->psz_longtext );
-            horizontal_sizer = new wxBoxSizer( wxHORIZONTAL );
-            horizontal_sizer->Add( checkbox, 0, wxALL, 5 );
-            sizer->Add( horizontal_sizer, 0, wxALL, 5 );
+            config_PutFloat( p_intf, control->GetName().mb_str(),
+                             control->GetFloatValue() );
             break;
         }
     }
-    while( p_item->i_type != CONFIG_HINT_END && p_item++ );
+}
 
+void PrefsPanel::SwitchAdvanced( vlc_bool_t b_new_advanced )
+{
+    bool hidden = false;
 
-    sizer->Layout();
-    SetSizer( sizer );
+    if( b_advanced == b_new_advanced ) 
+    {
+        goto hide;
+    }
+
+    if( config_sizer && config_window )
+    {
+        b_advanced = b_new_advanced;
+
+        for( size_t i = 0; i < config_array.GetCount(); i++ )
+        {
+            ConfigControl *control = config_array.Item(i);
+            if( control->IsAdvanced() )
+            {
+                if( !b_advanced ) hidden = true;
+                control->Show( b_advanced );
+                config_sizer->Show( control, b_advanced );
+            }
+        }
+
+        config_sizer->Layout();
+        config_window->FitInside();
+        config_window->Refresh();
+    }
+hide:
+    if( hidden && hidden_text )
+    {
+        hidden_text->Show( true );
+        config_sizer->Show( hidden_text, true );
+    }
+    else if ( hidden_text )
+    {
+        hidden_text->Show( false );
+        config_sizer->Show( hidden_text, false );
+    }
+    return;
 }