*/
static void ReadMetaFromAPE( APE::Tag* tag, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
{
- APE::Item item;
+ APE::ItemListMap fields ( tag->itemListMap() );
+ APE::ItemListMap::Iterator iter;
- item = tag->itemListMap()["COVER ART (FRONT)"];
- if( !item.isEmpty() )
+ iter = fields.find("COVER ART (FRONT)");
+ if( iter != fields.end()
+ && !iter->second.isEmpty()
+ && !iter->second.type() == APE::Item::Binary)
{
input_attachment_t *p_attachment;
- const ByteVector picture = item.value();
+ const ByteVector picture = iter->second.binaryData();
const char *p_data = picture.data();
unsigned i_data = picture.size();
+ /* Null terminated filename followed by the image data */
size_t desc_len = strnlen(p_data, i_data);
- if (desc_len < i_data) {
+ if( desc_len < i_data && IsUTF8( p_data ) )
+ {
const char *psz_name = p_data;
+ const char *psz_mime = vlc_mime_Ext2Mime( psz_name );
p_data += desc_len + 1; /* '\0' */
i_data -= desc_len + 1;
+
msg_Dbg( p_demux_meta, "Found embedded art: %s (%s) is %u bytes",
- psz_name, "image/jpeg", i_data );
+ psz_name, psz_mime, i_data );
- p_attachment = vlc_input_attachment_New( "cover", "image/jpeg",
+ p_attachment = vlc_input_attachment_New( psz_name, psz_mime,
psz_name, p_data, i_data );
if( p_attachment )
+ {
TAB_APPEND_CAST( (input_attachment_t**),
p_demux_meta->i_attachments, p_demux_meta->attachments,
p_attachment );
- vlc_meta_SetArtURL( p_meta, "attachment://cover" );
+ char *psz_url;
+ if( asprintf( &psz_url, "attachment://%s", p_attachment->psz_name ) != -1 )
+ {
+ vlc_meta_SetArtURL( p_meta, psz_url );
+ free( psz_url );
+ }
+ }
}
+
+ fields.erase(iter);
}
#define SET( keyName, metaName ) \
- item = tag->itemListMap()[keyName]; \
- if( !item.isEmpty() ) vlc_meta_Set##metaName( p_meta, item.toString().toCString( true ) ); \
+ iter = fields.find(keyName); \
+ if( iter != fields.end() && !iter->second.isEmpty() ) { \
+ vlc_meta_Set##metaName( p_meta, iter->second.toString().toCString( true ) ); \
+ fields.erase(iter); \
+ }
+
+#define SET_EXTRA( keyName, metaName ) \
+ iter = fields.find( keyName ); \
+ if( iter != fields.end() && !iter->second.isEmpty() ) { \
+ vlc_meta_AddExtra( p_meta, metaName, iter->second.toString().toCString( true ) ); \
+ fields.erase(iter); \
+ }
SET( "ALBUM", Album );
SET( "ARTIST", Artist );
SET( "COPYRIGHT", Copyright );
SET( "LANGUAGE", Language );
SET( "PUBLISHER", Publisher );
+ SET( "MUSICBRAINZ_TRACKID", TrackID );
+
+ SET_EXTRA( "MUSICBRAINZ_ALBUMID", VLC_META_EXTRA_MB_ALBUMID );
#undef SET
+#undef SET_EXTRA
/* */
- item = tag->itemListMap()["TRACK"];
- if( !item.isEmpty() )
+ iter = fields.find( "TRACK" );
+ if( iter != fields.end() && !iter->second.isEmpty() )
+ {
+ ExtractTrackNumberValues( p_meta, iter->second.toString().toCString( true ) );
+ fields.erase( iter );
+ }
+
+ /* Remainings */
+ for( iter = fields.begin(); iter != fields.end(); ++iter )
{
- ExtractTrackNumberValues( p_meta, item.toString().toCString( true ) );
+ if( iter->second.isEmpty() )
+ continue;
+
+ if( iter->second.type() != APE::Item::Text )
+ continue;
+
+ vlc_meta_AddExtra( p_meta,
+ iter->first.toCString( true ),
+ iter->second.toString().toCString( true ) );
}
}
-#ifdef TAGLIB_HAVE_ASFPICTURE_H
/**
- * Read meta information from APE tags
- * @param tag: the APE tag
+ * Read meta information from ASF tags
+ * @param tag: the ASF tag
* @param p_demux_meta: the demuxer meta
* @param p_meta: the meta
*/
static void ReadMetaFromASF( ASF::Tag* tag, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
{
+
+ ASF::AttributeList list;
+#define SET( keyName, metaName ) \
+ if( tag->attributeListMap().contains(keyName) ) \
+ { \
+ list = tag->attributeListMap()[keyName]; \
+ vlc_meta_Set##metaName( p_meta, list.front().toString().toCString( true ) ); \
+ }
+
+#define SET_EXTRA( keyName, metaName ) \
+ if( tag->attributeListMap().contains(keyName) ) \
+ { \
+ list = tag->attributeListMap()[keyName]; \
+ vlc_meta_AddExtra( p_meta, metaName, list.front().toString().toCString( true ) ); \
+ }
+
+ SET("MusicBrainz/Track Id", TrackID );
+ SET_EXTRA("MusicBrainz/Album Id", VLC_META_EXTRA_MB_ALBUMID );
+
+#undef SET
+#undef SET_EXTRA
+
+#ifdef TAGLIB_HAVE_ASFPICTURE_H
// List the pictures
- ASF::AttributeList list = tag->attributeListMap()["WM/Picture"];
+ list = tag->attributeListMap()["WM/Picture"];
ASF::AttributeList::Iterator iter;
for( iter = list.begin(); iter != list.end(); iter++ )
{
TAB_APPEND_CAST( (input_attachment_t**),
p_demux_meta->i_attachments, p_demux_meta->attachments,
p_attachment );
- free( psz_name );
-
char *psz_url;
- if( asprintf( &psz_url, "attachment://%s",
- p_attachment->psz_name ) == -1 )
- continue;
- vlc_meta_SetArtURL( p_meta, psz_url );
- free( psz_url );
+ if( asprintf( &psz_url, "attachment://%s", psz_name ) != -1 )
+ {
+ vlc_meta_SetArtURL( p_meta, psz_url );
+ free( psz_url );
+ }
+ free( psz_name );
}
-}
#endif
+}
/**
vlc_meta_Set( p_meta, vlc_meta_TrackTotal, p_txxx->fieldList().back().toCString( true ) );
continue;
}
+ if( !strcmp( p_txxx->description().toCString( true ), "MusicBrainz Album Id" ) )
+ {
+ vlc_meta_AddExtra( p_meta, VLC_META_EXTRA_MB_ALBUMID, p_txxx->fieldList().back().toCString( true ) );
+ continue;
+ }
vlc_meta_AddExtra( p_meta, p_txxx->description().toCString( true ),
p_txxx->fieldList().back().toCString( true ) );
}
SET( "TENC", EncodedBy );
SET( "TLAN", Language );
SET( "TPUB", Publisher );
+ SET( "TPE2", AlbumArtist );
+ SET( "TPOS", DiscNumber );
#undef SET
if( list.isEmpty() )
return;
- TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );
for( iter = list.begin(); iter != list.end(); iter++ )
{
ID3v2::AttachedPictureFrame* p_apic =
static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
{
StringList list;
+ bool hasTrackTotal = false;
#define SET( keyName, metaName ) \
list = tag->fieldListMap()[keyName]; \
if( !list.isEmpty() ) \
vlc_meta_Set##metaName( p_meta, (*list.begin()).toCString( true ) );
+#define SET_EXTRA( keyName, metaName ) \
+ list = tag->fieldListMap()[keyName]; \
+ if( !list.isEmpty() ) \
+ vlc_meta_AddExtra( p_meta, keyName, (*list.begin()).toCString( true ) );
+
SET( "COPYRIGHT", Copyright );
+ SET( "ORGANIZATION", Publisher );
+ SET( "DATE", Date );
+ SET( "ENCODER", EncodedBy );
+ SET( "RATING", Rating );
+ SET( "LANGUAGE", Language );
+ SET( "MUSICBRAINZ_TRACKID", TrackID );
+ SET( "ALBUMARTIST", AlbumArtist );
+ SET( "DISCNUMBER", DiscNumber );
+
+ SET_EXTRA( "MUSICBRAINZ_ALBUMID", VLC_META_EXTRA_MB_ALBUMID );
#undef SET
+#undef SET_EXTRA
+
+ list = tag->fieldListMap()["TRACKNUMBER"];
+ if( !list.isEmpty() )
+ {
+ const char *psz_value;
+ unsigned short u_track;
+ unsigned short u_total;
+ psz_value = (*list.begin()).toCString( true );
+ if( sscanf( psz_value, "%hu/%hu", &u_track, &u_total ) == 2)
+ {
+ char str[6];
+ snprintf(str, 6, "%u", u_track);
+ vlc_meta_SetTrackNum( p_meta, str);
+ snprintf(str, 6, "%u", u_total);
+ vlc_meta_SetTrackTotal( p_meta, str);
+ hasTrackTotal = true;
+ }
+ else
+ vlc_meta_SetTrackNum( p_meta, psz_value);
+ }
+ if( !hasTrackTotal )
+ {
+ list = tag->fieldListMap()["TRACKTOTAL"];
+ if( list.isEmpty() )
+ list = tag->fieldListMap()["TOTALTRACKS"];
+ if( !list.isEmpty() )
+ vlc_meta_SetTrackTotal( p_meta, (*list.begin()).toCString( true ) );
+ }
// Try now to get embedded art
StringList mime_list = tag->fieldListMap()[ "COVERARTMIME" ];
&i_cover_score, &i_cover_idx );
}
- TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );
if (p_attachment) {
TAB_APPEND_CAST( (input_attachment_t**),
p_demux_meta->i_attachments, p_demux_meta->attachments,
*/
static void ReadMetaFromMP4( MP4::Tag* tag, demux_meta_t *p_demux_meta, vlc_meta_t* p_meta )
{
+ MP4::Item list;
+#define SET( keyName, metaName ) \
+ if( tag->itemListMap().contains(keyName) ) \
+ { \
+ list = tag->itemListMap()[keyName]; \
+ vlc_meta_Set##metaName( p_meta, list.toStringList().front().toCString( true ) ); \
+ }
+#define SET_EXTRA( keyName, metaName ) \
+ if( tag->itemListMap().contains(keyName) ) \
+ { \
+ list = tag->itemListMap()[keyName]; \
+ vlc_meta_AddExtra( p_meta, metaName, list.toStringList().front().toCString( true ) ); \
+ }
+
+ SET("----:com.apple.iTunes:MusicBrainz Track Id", TrackID );
+ SET_EXTRA("----:com.apple.iTunes:MusicBrainz Album Id", VLC_META_EXTRA_MB_ALBUMID );
+
+#undef SET
+#undef SET_EXTRA
+
if( tag->itemListMap().contains("covr") )
{
MP4::CoverArtList list = tag->itemListMap()["covr"].toCoverArtList();
msg_Dbg( p_demux_meta, "Found embedded art (%s) is %i bytes",
psz_format, list[0].data().size() );
- TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );
input_attachment_t *p_attachment =
vlc_input_attachment_New( "cover", psz_format, "cover",
list[0].data().data(), list[0].data().size() );
#undef SETINT
#undef SET
+ TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );
// Try now to read special tags
#ifdef TAGLIB_HAVE_APEFILE_H
}
else
#endif
-#ifdef TAGLIB_HAVE_ASFPICTURE_H
+#ifdef TAGLIB_WITH_ASF
if( ASF::File* asf = dynamic_cast<ASF::File*>(f.file()) )
{
if( asf->tag() )
}
else if( MPEG::File* mpeg = dynamic_cast<MPEG::File*>(f.file()) )
{
+ if( mpeg->APETag() )
+ ReadMetaFromAPE( mpeg->APETag(), p_demux_meta, p_meta );
if( mpeg->ID3v2Tag() )
ReadMetaFromId3v2( mpeg->ID3v2Tag(), p_demux_meta, p_meta );
- else if( mpeg->APETag() )
- ReadMetaFromAPE( mpeg->APETag(), p_demux_meta, p_meta );
}
else if( dynamic_cast<Ogg::File*>(f.file()) )
{
WRITE( Copyright, "COPYRIGHT" );
WRITE( Language, "LANGUAGE" );
WRITE( Publisher, "PUBLISHER" );
-
+ WRITE( TrackID, "MUSICBRAINZ_TRACKID" );
#undef WRITE
}
WRITE( Publisher, "TPUB" );
#undef WRITE
- /* Track Total as Custom Field */
- psz_meta = input_item_GetTrackTotal( p_item );
- if ( psz_meta )
- {
- ID3v2::FrameList list = tag->frameListMap()["TXXX"];
- ID3v2::UserTextIdentificationFrame *p_txxx;
- for( ID3v2::FrameList::Iterator iter = list.begin(); iter != list.end(); iter++ )
- {
- p_txxx = dynamic_cast<ID3v2::UserTextIdentificationFrame*>(*iter);
- if( !p_txxx )
- continue;
- if( !strcmp( p_txxx->description().toCString( true ), "TRACKTOTAL" ) )
- {
- p_txxx->setText( psz_meta );
- FREENULL( psz_meta );
- break;
- }
- }
- if( psz_meta ) /* not found in existing custom fields */
- {
- ByteVector p_byte( "TXXX", 4 );
- p_txxx = new ID3v2::UserTextIdentificationFrame( p_byte );
- p_txxx->setDescription( "TRACKTOTAL" );
- p_txxx->setText( psz_meta );
- free( psz_meta );
- tag->addFrame( p_txxx );
- }
+ /* Known TXXX frames */
+ ID3v2::FrameList list = tag->frameListMap()["TXXX"];
+
+#define WRITETXXX( metaName, txxName )\
+ psz_meta = input_item_Get##metaName( p_item ); \
+ if ( psz_meta ) \
+ { \
+ ID3v2::UserTextIdentificationFrame *p_txxx; \
+ for( ID3v2::FrameList::Iterator iter = list.begin(); iter != list.end(); iter++ )\
+ { \
+ p_txxx = dynamic_cast<ID3v2::UserTextIdentificationFrame*>(*iter); \
+ if( !p_txxx ) \
+ continue; \
+ if( !strcmp( p_txxx->description().toCString( true ), txxName ) ) \
+ { \
+ p_txxx->setText( psz_meta ); \
+ FREENULL( psz_meta ); \
+ break; \
+ } \
+ } \
+ if( psz_meta ) /* not found in existing custom fields */ \
+ { \
+ ByteVector p_byte( "TXXX", 4 ); \
+ p_txxx = new ID3v2::UserTextIdentificationFrame( p_byte ); \
+ p_txxx->setDescription( txxName ); \
+ p_txxx->setText( psz_meta ); \
+ free( psz_meta ); \
+ tag->addFrame( p_txxx ); \
+ } \
}
+ WRITETXXX( TrackTotal, "TRACKTOTAL" );
+
+#undef WRITETXXX
+
/* Write album art */
char *psz_url = input_item_GetArtworkURL( p_item );
if( psz_url == NULL )
} \
free( psz_meta );
+ WRITE( TrackNum, "TRACKNUMBER" );
+ WRITE( TrackTotal, "TRACKTOTAL" );
WRITE( Copyright, "COPYRIGHT" );
-
+ WRITE( Publisher, "ORGANIZATION" );
+ WRITE( Date, "DATE" );
+ WRITE( EncodedBy, "ENCODER" );
+ WRITE( Rating, "RATING" );
+ WRITE( Language, "LANGUAGE" );
+ WRITE( TrackID, "MUSICBRAINZ_TRACKID" );
#undef WRITE
}
return VLC_SUCCESS;
}
-
projects / vlc / blobdiff