#include <vlc_common.h>
#include <vlc_plugin.h>
-#include <vlc_playlist.h>
#include <vlc_meta.h>
#include <vlc_demux.h>
#include <vlc_strings.h>
#include <vlc_charset.h>
#include <vlc_url.h>
+#include <vlc_input_item.h>
+#include <vlc_input.h> /* for attachment_new */
#ifdef WIN32
# include <io.h>
#include <id3v2tag.h>
#include <xiphcomment.h>
+#include <apefile.h>
#include <flacfile.h>
#include <mpcfile.h>
#include <mpegfile.h>
# include <wavfile.h>
#endif
+#ifdef TAGLIB_WITH_MP4
+# include <mp4file.h>
+#endif
+
#include <speexfile.h>
#include <trueaudiofile.h>
#include <vorbisfile.h>
#include <textidentificationframe.h>
#include <uniquefileidentifierframe.h>
+// taglib is not thread safe
+static vlc_mutex_t taglib_lock = VLC_STATIC_MUTEX;
// Local functions
static int ReadMeta ( vlc_object_t * );
/**
- * Read meta informations from APE tags
+ * Read meta information from APE tags
* @param tag: the APE tag
- * @param p_demux; the demux object
* @param p_demux_meta: the demuxer meta
* @param p_meta: the meta
*/
-static void ReadMetaFromAPE( APE::Tag* tag, demux_t* p_demux, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
+static void ReadMetaFromAPE( APE::Tag* tag, demux_meta_t*, vlc_meta_t* p_meta )
{
APE::Item item;
#define SET( keyName, metaName ) \
/**
* Read meta information from id3v2 tags
* @param tag: the id3v2 tag
- * @param p_demux; the demux object
* @param p_demux_meta: the demuxer meta
* @param p_meta: the meta
*/
-static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
+static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
{
// Get the unique file identifier
ID3v2::FrameList list = tag->frameListMap()["UFID"];
{
ID3v2::UniqueFileIdentifierFrame* p_ufid =
dynamic_cast<ID3v2::UniqueFileIdentifierFrame*>(*iter);
+ if( !p_ufid )
+ continue;
const char *owner = p_ufid->owner().toCString();
if (!strcmp( owner, "http://musicbrainz.org" ))
{
{
ID3v2::UserTextIdentificationFrame* p_txxx =
dynamic_cast<ID3v2::UserTextIdentificationFrame*>(*iter);
+ if( !p_txxx )
+ continue;
vlc_meta_AddExtra( p_meta, p_txxx->description().toCString( true ),
- p_txxx->fieldList().toString().toCString( true ) );
+ p_txxx->fieldList().back().toCString( true ) );
}
- // Get some more informations
+ // Get some more information
#define SET( tagName, metaName ) \
list = tag->frameListMap()[tagName]; \
if( !list.isEmpty() ) \
3, /* Logo of the band or performer. */
2 /* Logo of the publisher (record company). */
};
+ #define PI_COVER_SCORE_SIZE (sizeof (pi_cover_score) / sizeof (pi_cover_score[0]))
int i_score = -1;
// Try now to get embedded art
{
ID3v2::AttachedPictureFrame* p_apic =
dynamic_cast<ID3v2::AttachedPictureFrame*>(*iter);
+ if( !p_apic )
+ continue;
input_attachment_t *p_attachment;
const char *psz_mime;
p_attachment );
free( psz_description );
- if( pi_cover_score[p_apic->type()] > i_score )
+ unsigned i_pic_type = p_apic->type();
+ if( i_pic_type >= PI_COVER_SCORE_SIZE )
+ i_pic_type = 0; // Defaults to "Other"
+
+ if( pi_cover_score[i_pic_type] > i_score )
{
- i_score = pi_cover_score[p_apic->type()];
+ i_score = pi_cover_score[i_pic_type];
char *psz_url;
if( asprintf( &psz_url, "attachment://%s",
p_attachment->psz_name ) == -1 )
/**
- * Read the meta informations from XiphComments
+ * Read the meta information from XiphComments
* @param tag: the Xiph Comment
- * @param p_demux; the demux object
* @param p_demux_meta: the demuxer meta
* @param p_meta: the meta
*/
-static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_t* p_demux, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
+static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta, vlc_meta_t* p_meta )
{
+ StringList list;
#define SET( keyName, metaName ) \
- StringList list = tag->fieldListMap()[keyName]; \
+ list = tag->fieldListMap()[keyName]; \
if( !list.isEmpty() ) \
vlc_meta_Set##metaName( p_meta, (*list.begin()).toCString( true ) );
vlc_meta_SetArtURL( p_meta, "attachment://cover" );
}
-
+#if defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H)
+static void ReadMetaFromMP4( MP4::Tag* tag, demux_meta_t *p_demux_meta, vlc_meta_t* p_meta )
+{
+ if( tag->itemListMap().contains("covr") )
+ {
+ MP4::CoverArtList list = tag->itemListMap()["covr"].toCoverArtList();
+ const char *psz_format = list[0].format() == MP4::CoverArt::PNG ? "image/png" : "image/jpeg";
+
+ msg_Dbg( p_demux_meta, "Found embedded art (%s) is %i bytes",
+ psz_format, list[0].data().size() );
+
+ TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );
+ input_attachment_t *p_attachment =
+ vlc_input_attachment_New( "cover", psz_format, "cover",
+ list[0].data().data(), list[0].data().size() );
+ TAB_APPEND_CAST( (input_attachment_t**),
+ p_demux_meta->i_attachments, p_demux_meta->attachments,
+ p_attachment );
+ vlc_meta_SetArtURL( p_meta, "attachment://cover" );
+ }
+}
+#endif
/**
* Get the tags from the file using TagLib
*/
static int ReadMeta( vlc_object_t* p_this)
{
+ vlc_mutex_locker locker (&taglib_lock);
demux_meta_t* p_demux_meta = (demux_meta_t *)p_this;
demux_t* p_demux = p_demux_meta->p_demux;
vlc_meta_t* p_meta;
FileRef f;
p_demux_meta->p_meta = NULL;
+ if( strcmp( p_demux->psz_access, "file" ) )
+ return VLC_EGENERIC;
+ char *psz_path = strdup( p_demux->psz_file );
+ if( !psz_path )
+ return VLC_ENOMEM;
#if defined(WIN32) || defined (UNDER_CE)
wchar_t wpath[MAX_PATH + 1];
- if( !MultiByteToWideChar( CP_UTF8, 0, p_demux->psz_path, -1, wpath, MAX_PATH) )
+ if( !MultiByteToWideChar( CP_UTF8, 0, psz_path, -1, wpath, MAX_PATH) )
+ {
+ free( psz_path );
return VLC_EGENERIC;
+ }
wpath[MAX_PATH] = L'\0';
f = FileRef( wpath );
#else
- const char* local_name = ToLocale( p_demux->psz_path );
+ const char* local_name = ToLocale( psz_path );
if( !local_name )
+ {
+ free( psz_path );
return VLC_EGENERIC;
+ }
f = FileRef( local_name );
LocaleFree( local_name );
#endif
+ free( psz_path );
if( f.isNull() )
return VLC_EGENERIC;
// Try now to read special tags
- if( FLAC::File* flac = dynamic_cast<FLAC::File*>(f.file()) )
+ if( APE::File* ape = dynamic_cast<APE::File*>(f.file()) )
+ {
+ if( ape->APETag() )
+ ReadMetaFromAPE( ape->APETag(), p_demux_meta, p_meta );
+ }
+ else if( FLAC::File* flac = dynamic_cast<FLAC::File*>(f.file()) )
{
if( flac->ID3v2Tag() )
- ReadMetaFromId3v2( flac->ID3v2Tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromId3v2( flac->ID3v2Tag(), p_demux_meta, p_meta );
else if( flac->xiphComment() )
- ReadMetaFromXiph( flac->xiphComment(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromXiph( flac->xiphComment(), p_demux_meta, p_meta );
}
+#if defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H)
+ else if( MP4::File *mp4 = dynamic_cast<MP4::File*>(f.file()) )
+ {
+ if( mp4->tag() )
+ ReadMetaFromMP4( mp4->tag(), p_demux_meta, p_meta );
+ }
+#endif
else if( MPC::File* mpc = dynamic_cast<MPC::File*>(f.file()) )
{
if( mpc->APETag() )
- ReadMetaFromAPE( mpc->APETag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromAPE( mpc->APETag(), p_demux_meta, p_meta );
}
else if( MPEG::File* mpeg = dynamic_cast<MPEG::File*>(f.file()) )
{
if( mpeg->ID3v2Tag() )
- ReadMetaFromId3v2( mpeg->ID3v2Tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromId3v2( mpeg->ID3v2Tag(), p_demux_meta, p_meta );
else if( mpeg->APETag() )
- ReadMetaFromAPE( mpeg->APETag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromAPE( mpeg->APETag(), p_demux_meta, p_meta );
}
- else if( Ogg::File* ogg = dynamic_cast<Ogg::File*>(f.file()) )
+ else if( dynamic_cast<Ogg::File*>(f.file()) )
{
if( Ogg::FLAC::File* ogg_flac = dynamic_cast<Ogg::FLAC::File*>(f.file()))
- ReadMetaFromXiph( ogg_flac->tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromXiph( ogg_flac->tag(), p_demux_meta, p_meta );
else if( Ogg::Speex::File* ogg_speex = dynamic_cast<Ogg::Speex::File*>(f.file()) )
- ReadMetaFromXiph( ogg_speex->tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromXiph( ogg_speex->tag(), p_demux_meta, p_meta );
else if( Ogg::Vorbis::File* ogg_vorbis = dynamic_cast<Ogg::Vorbis::File*>(f.file()) )
- ReadMetaFromXiph( ogg_vorbis->tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromXiph( ogg_vorbis->tag(), p_demux_meta, p_meta );
}
#ifdef TAGLIB_WITH_ASF
- else if( RIFF::File* riff = dynamic_cast<RIFF::File*>(f.file()) )
+ else if( dynamic_cast<RIFF::File*>(f.file()) )
{
if( RIFF::AIFF::File* riff_aiff = dynamic_cast<RIFF::AIFF::File*>(f.file()) )
- ReadMetaFromId3v2( riff_aiff->tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromId3v2( riff_aiff->tag(), p_demux_meta, p_meta );
else if( RIFF::WAV::File* riff_wav = dynamic_cast<RIFF::WAV::File*>(f.file()) )
- ReadMetaFromId3v2( riff_wav->tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromId3v2( riff_wav->tag(), p_demux_meta, p_meta );
}
#endif
else if( TrueAudio::File* trueaudio = dynamic_cast<TrueAudio::File*>(f.file()) )
{
if( trueaudio->ID3v2Tag() )
- ReadMetaFromId3v2( trueaudio->ID3v2Tag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromId3v2( trueaudio->ID3v2Tag(), p_demux_meta, p_meta );
}
else if( WavPack::File* wavpack = dynamic_cast<WavPack::File*>(f.file()) )
{
if( wavpack->APETag() )
- ReadMetaFromAPE( wavpack->APETag(), p_demux, p_demux_meta, p_meta );
+ ReadMetaFromAPE( wavpack->APETag(), p_demux_meta, p_meta );
}
return VLC_SUCCESS;
/**
- * Write meta informations to APE tags
+ * Write meta information to APE tags
* @param tag: the APE tag
* @param p_item: the input item
*/
/**
- * Write the meta informations to XiphComments
+ * Write the meta information to XiphComments
* @param tag: the Xiph Comment
* @param p_input: the input item
*/
static int WriteMeta( vlc_object_t *p_this )
{
+ vlc_mutex_locker locker (&taglib_lock);
meta_export_t *p_export = (meta_export_t *)p_this;
input_item_t *p_item = p_export->p_item;
FileRef f;
return VLC_EGENERIC;
}
- char *export_file = strdup(p_export->psz_file);
- if( decode_URI( export_file ) == NULL )
- {
- free( export_file );
- return VLC_EGENERIC;
- }
-
#if defined(WIN32) || defined (UNDER_CE)
wchar_t wpath[MAX_PATH + 1];
- if( !MultiByteToWideChar( CP_UTF8, 0, export_file , -1, wpath, MAX_PATH) )
+ if( !MultiByteToWideChar( CP_UTF8, 0, p_export->psz_file, -1, wpath, MAX_PATH) )
return VLC_EGENERIC;
wpath[MAX_PATH] = L'\0';
f = FileRef( wpath );
#else
- const char* local_name = ToLocale( export_file );
+ const char* local_name = ToLocale( p_export->psz_file );
if( !local_name )
- {
- free( export_file );
return VLC_EGENERIC;
- }
f = FileRef( local_name );
LocaleFree( local_name );
#endif
if( f.isNull() || !f.tag() || f.file()->readOnly() )
{
msg_Err( p_this, "File %s can't be opened for tag writing",
- export_file );
- free( export_file );
+ p_export->psz_file );
return VLC_EGENERIC;
}
- msg_Dbg( p_this, "Writing metadata for %s", export_file );
- free( export_file );
+ msg_Dbg( p_this, "Writing metadata for %s", p_export->psz_file );
Tag *p_tag = f.tag();
// Try now to write special tags
- if( FLAC::File* flac = dynamic_cast<FLAC::File*>(f.file()) )
+ if( APE::File* ape = dynamic_cast<APE::File*>(f.file()) )
+ {
+ if( ape->APETag() )
+ WriteMetaToAPE( ape->APETag(), p_item );
+ }
+ else if( FLAC::File* flac = dynamic_cast<FLAC::File*>(f.file()) )
{
if( flac->ID3v2Tag() )
WriteMetaToId3v2( flac->ID3v2Tag(), p_item );
else if( mpeg->APETag() )
WriteMetaToAPE( mpeg->APETag(), p_item );
}
- else if( Ogg::File* ogg = dynamic_cast<Ogg::File*>(f.file()) )
+ else if( dynamic_cast<Ogg::File*>(f.file()) )
{
if( Ogg::FLAC::File* ogg_flac = dynamic_cast<Ogg::FLAC::File*>(f.file()))
WriteMetaToXiph( ogg_flac->tag(), p_item );
WriteMetaToXiph( ogg_vorbis->tag(), p_item );
}
#ifdef TAGLIB_WITH_ASF
- else if( RIFF::File* riff = dynamic_cast<RIFF::File*>(f.file()) )
+ else if( dynamic_cast<RIFF::File*>(f.file()) )
{
if( RIFF::AIFF::File* riff_aiff = dynamic_cast<RIFF::AIFF::File*>(f.file()) )
WriteMetaToId3v2( riff_aiff->tag(), p_item );
projects / vlc / blobdiff