* http://www.audioscrobbler.net/development/protocol/
*
* TODO: "Now Playing" feature (not mandatory)
+ * Update to new API? http://www.lastfm.fr/api
*/
/*****************************************************************************
* Preamble
#define USERNAME_LONGTEXT N_("The username of your last.fm account")
#define PASSWORD_TEXT N_("Password")
#define PASSWORD_LONGTEXT N_("The password of your last.fm account")
-#if 0
- #define URL_TEXT N_("Scrobbler URL")
- #define URL_LONGTEXT N_("The URL set for an alternative scrobbler engine")
-#endif
+#define URL_TEXT N_("Scrobbler URL")
+#define URL_LONGTEXT N_("The URL set for an alternative scrobbler engine")
/* This error value is used when last.fm plugin has to be unloaded. */
#define VLC_AUDIOSCROBBLER_EFATAL -69
USERNAME_TEXT, USERNAME_LONGTEXT, false )
add_password( "lastfm-password", "", NULL,
PASSWORD_TEXT, PASSWORD_LONGTEXT, false )
-#if 0
add_string( "scrobbler-url", "post.audioscrobbler.com", NULL,
- URL_TEXT, URL_LONGTEXT, false )*/
-#endif
+ URL_TEXT, URL_LONGTEXT, false )
set_capability( "interface", 0 )
set_callbacks( Open, Close )
vlc_module_end ()
*****************************************************************************/
static int Open( vlc_object_t *p_this )
{
- playlist_t *p_playlist;
intf_thread_t *p_intf = ( intf_thread_t* ) p_this;
intf_sys_t *p_sys = calloc( 1, sizeof( intf_sys_t ) );
vlc_mutex_init( &p_sys->lock );
vlc_cond_init( &p_sys->wait );
- p_playlist = pl_Hold( p_intf );
- PL_LOCK;
- var_AddCallback( p_playlist, "item-current", ItemChange, p_intf );
- PL_UNLOCK;
- pl_Release( p_intf );
+ var_AddCallback( pl_Get( p_intf ), "item-current", ItemChange, p_intf );
p_intf->pf_run = Run;
*****************************************************************************/
static void Close( vlc_object_t *p_this )
{
- playlist_t *p_playlist;
+ playlist_t *p_playlist = pl_Get( p_this );
input_thread_t *p_input;
intf_thread_t *p_intf = ( intf_thread_t* ) p_this;
intf_sys_t *p_sys = p_intf->p_sys;
- p_playlist = pl_Hold( p_intf );
- if( p_playlist )
- {
-
- var_DelCallback( p_playlist, "item-current", ItemChange, p_intf );
-
- p_input = playlist_CurrentInput( p_playlist );
- if ( p_input )
- {
- if( p_sys->b_state_cb )
- var_DelCallback( p_input, "intf-event", PlayingChange, p_intf );
-
- vlc_object_release( p_input );
- }
+ var_DelCallback( p_playlist, "item-current", ItemChange, p_intf );
- pl_Release( p_intf );
+ p_input = playlist_CurrentInput( p_playlist );
+ if ( p_input )
+ {
+ if( p_sys->b_state_cb )
+ var_DelCallback( p_input, "intf-event", PlayingChange, p_intf );
+ vlc_object_release( p_input );
}
int i;
/* username not set */
dialog_Fatal( p_intf,
_("Last.fm username not set"),
- _("Please set a username or disable the "
+ "%s", _("Please set a username or disable the "
"audioscrobbler plugin, and restart VLC.\n"
"Visit http://www.last.fm/join/ to get an account.")
);
/* we transmit the data */
i_net_ret = net_Printf(
- VLC_OBJECT( p_intf ), i_post_socket, NULL,
+ p_intf, i_post_socket, NULL,
POST_REQUEST, p_sys->psz_submit_file,
(unsigned)strlen( psz_submit ), p_sys->psz_submit_host,
VERSION, psz_submit
static int PlayingChange( vlc_object_t *p_this, const char *psz_var,
vlc_value_t oldval, vlc_value_t newval, void *p_data )
{
+ VLC_UNUSED( oldval );
+
intf_thread_t *p_intf = ( intf_thread_t* ) p_data;
intf_sys_t *p_sys = p_intf->p_sys;
input_thread_t *p_input = ( input_thread_t* )p_this;
if( newval.i_int != INPUT_EVENT_STATE ) return VLC_SUCCESS;
+ if( var_CountChoices( p_input, "video-es" ) )
+ {
+ msg_Dbg( p_this, "Not an audio-only input, not submitting");
+ return VLC_SUCCESS;
+ }
+
state_value.i_int = 0;
var_Get( p_input, "state", &state_value );
else if( state_value.i_int == PAUSE_S )
p_sys->time_pause = mdate();
else if( p_sys->time_pause > 0 && state_value.i_int == PLAYING_S )
+ {
p_sys->time_total_pauses += ( mdate() - p_sys->time_pause );
+ p_sys->time_pause = 0;
+ }
return VLC_SUCCESS;
}
static int ItemChange( vlc_object_t *p_this, const char *psz_var,
vlc_value_t oldval, vlc_value_t newval, void *p_data )
{
- playlist_t *p_playlist;
input_thread_t *p_input;
intf_thread_t *p_intf = ( intf_thread_t* ) p_data;
intf_sys_t *p_sys = p_intf->p_sys;
input_item_t *p_item;
- vlc_value_t video_val;
VLC_UNUSED( p_this ); VLC_UNUSED( psz_var );
VLC_UNUSED( oldval ); VLC_UNUSED( newval );
p_sys->b_meta_read = false;
p_sys->b_submit = false;
- p_playlist = pl_Hold( p_intf );
- p_input = playlist_CurrentInput( p_playlist );
+ p_input = playlist_CurrentInput( pl_Get( p_intf ) );
if( !p_input || p_input->b_dead )
- {
- pl_Release( p_intf );
return VLC_SUCCESS;
- }
-
- pl_Release( p_intf );
p_item = input_GetItem( p_input );
if( !p_item )
return VLC_SUCCESS;
}
- var_Change( p_input, "video-es", VLC_VAR_CHOICESCOUNT, &video_val, NULL );
- if( ( video_val.i_int > 0 ) || p_item->i_type == ITEM_TYPE_NET )
+ if( var_CountChoices( p_input, "video-es" ) )
{
- msg_Dbg( p_this, "Not an audio local file, not submitting");
+ msg_Dbg( p_this, "Not an audio-only input, not submitting");
vlc_object_release( p_input );
return VLC_SUCCESS;
}
intf_thread_t *p_intf = ( intf_thread_t* ) p_this;
intf_sys_t *p_sys = p_this->p_sys;
- psz_username = config_GetPsz( p_this, "lastfm-username" );
+ psz_username = var_InheritString( p_this, "lastfm-username" );
if( !psz_username )
return VLC_ENOMEM;
- psz_password = config_GetPsz( p_this, "lastfm-password" );
+ psz_password = var_InheritString( p_this, "lastfm-password" );
if( !psz_password )
{
free( psz_username );
strncpy( p_sys->psz_auth_token, psz_auth_token, 33 );
free( psz_auth_token );
-#if 0
- psz_scrobbler_url = config_GetPsz( p_this, "scrobbler-url" );
-#else
- psz_scrobbler_url = strdup( "post.audioscrobbler.com" );
-#endif
+ psz_scrobbler_url = var_InheritString( p_this, "scrobbler-url" );
if( !psz_scrobbler_url )
{
free( psz_username );
/* authentication failed, bad username/password combination */
dialog_Fatal( p_this,
_("last.fm: Authentication failed"),
- _("last.fm username or password is incorrect. "
+ "%s", _("last.fm username or password is incorrect. "
"Please verify your settings and relaunch VLC." ) );
return VLC_AUDIOSCROBBLER_EFATAL;
}
*****************************************************************************/
static int ReadMetaData( intf_thread_t *p_this )
{
- playlist_t *p_playlist;
input_thread_t *p_input;
input_item_t *p_item;
intf_sys_t *p_sys = p_this->p_sys;
- p_playlist = pl_Hold( p_this );
- p_input = playlist_CurrentInput( p_playlist );
+ p_input = playlist_CurrentInput( pl_Get( p_this ) );
if( !p_input )
- {
- pl_Release( p_this );
return( VLC_SUCCESS );
- }
-
- pl_Release( p_this );
p_item = input_GetItem( p_input );
if( !p_item )
projects / vlc / blobdiff