]> git.sesse.net Git - vlc/blobdiff - modules/misc/freetype.c
Merge branch 'master' of git@git.videolan.org:vlc
[vlc] / modules / misc / freetype.c
index e9e81591a7bbceff90460644314ac6b7dab1778f..51b3bdd7dd912dfd34fa308e2770d9bfe88fc9e8 100644 (file)
@@ -6,7 +6,7 @@
  *
  * Authors: Sigmund Augdal Helberg <dnumgis@videolan.org>
  *          Gildas Bazin <gbazin@videolan.org>
- *          Bernie Purcell <b dot purcell at adbglobal dot com>
+ *          Bernie Purcell <bitmap@videolan.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
-#include <stdlib.h>                                      /* malloc(), free() */
-#include <string.h>
 
-#ifdef HAVE_LINUX_LIMITS_H
-#   include <linux/limits.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
 #endif
 
 #include <vlc/vlc.h>
 #include <vlc_filter.h>
 #include <vlc_stream.h>
 #include <vlc_xml.h>
+#include <vlc_input.h>
 
 #include <math.h>
-
-#ifdef HAVE_ERRNO_H
-#   include <errno.h>
-#endif
+#include <errno.h>
 
 #include <ft2build.h>
 #include FT_FREETYPE_H
@@ -84,6 +80,8 @@ typedef struct line_desc_t line_desc_t;
 static int  Create ( vlc_object_t * );
 static void Destroy( vlc_object_t * );
 
+static int LoadFontsFromAttachments( filter_t *p_filter );
+
 /* The RenderText call maps to pf_render_string, defined in vlc_filter.h */
 static int RenderText( filter_t *, subpicture_region_t *,
                        subpicture_region_t * );
@@ -91,11 +89,15 @@ static int RenderText( filter_t *, subpicture_region_t *,
 static int RenderHtml( filter_t *, subpicture_region_t *,
                        subpicture_region_t * );
 static char *FontConfig_Select( FcConfig *, const char *,
-                                vlc_bool_t, vlc_bool_t, int * );
+                                bool, bool, int * );
+static int CheckIfFontBuildComplete( filter_t *p_filter );
 #endif
 static line_desc_t *NewLine( int );
 
+static int GetFontSize( filter_t *p_filter );
 static int SetFontSize( filter_t *, int );
+static void YUVFromRGB( uint32_t i_argb,
+                        uint8_t *pi_y, uint8_t *pi_u, uint8_t *pi_v );
 
 /*****************************************************************************
  * Module descriptor
@@ -155,29 +157,29 @@ vlc_module_begin();
     set_subcategory( SUBCAT_VIDEO_SUBPIC );
 
     add_file( "freetype-font", DEFAULT_FONT, NULL, FONT_TEXT, FONT_LONGTEXT,
-              VLC_FALSE );
+              false );
 
     add_integer( "freetype-fontsize", 0, NULL, FONTSIZE_TEXT,
-                 FONTSIZE_LONGTEXT, VLC_TRUE );
+                 FONTSIZE_LONGTEXT, true );
 
     /* opacity valid on 0..255, with default 255 = fully opaque */
     add_integer_with_range( "freetype-opacity", 255, 0, 255, NULL,
-        OPACITY_TEXT, OPACITY_LONGTEXT, VLC_TRUE );
+        OPACITY_TEXT, OPACITY_LONGTEXT, true );
 
     /* hook to the color values list, with default 0x00ffffff = white */
     add_integer( "freetype-color", 0x00FFFFFF, NULL, COLOR_TEXT,
-                 COLOR_LONGTEXT, VLC_FALSE );
+                 COLOR_LONGTEXT, false );
         change_integer_list( pi_color_values, ppsz_color_descriptions, 0 );
 
     add_integer( "freetype-rel-fontsize", 16, NULL, FONTSIZER_TEXT,
-                 FONTSIZER_LONGTEXT, VLC_FALSE );
+                 FONTSIZER_LONGTEXT, false );
         change_integer_list( pi_sizes, ppsz_sizes_text, 0 );
     add_integer( "freetype-effect", 2, NULL, EFFECT_TEXT,
-                 EFFECT_LONGTEXT, VLC_FALSE );
+                 EFFECT_LONGTEXT, false );
         change_integer_list( pi_effects, ppsz_effects_text, 0 );
 
     add_bool( "freetype-yuvp", 0, NULL, YUVP_TEXT,
-              YUVP_LONGTEXT, VLC_TRUE );
+              YUVP_LONGTEXT, true );
     set_capability( "text renderer", 100 );
     add_shortcut( "text" );
     set_callbacks( Create, Destroy );
@@ -193,8 +195,10 @@ struct line_desc_t
      * -- if the rendering mode supports it (RenderYUVA) and
      *  b_new_color_mode is set, then it becomes possible to
      *  have multicoloured text within the subtitles. */
-    uint32_t       *p_rgb;
-    vlc_bool_t      b_new_color_mode;
+    uint32_t       *p_fg_rgb;
+    uint32_t       *p_bg_rgb;
+    uint8_t        *p_fg_bg_ratio; /* 0x00=100% FG --> 0x7F=100% BG */
+    bool      b_new_color_mode;
     /** underline information -- only supplied if text should be underlined */
     uint16_t       *pi_underline_offset;
     uint16_t       *pi_underline_thickness;
@@ -212,8 +216,8 @@ struct font_stack_t
 {
     char          *psz_name;
     int            i_size;
-    int            i_color;
-    int            i_alpha;
+    uint32_t       i_color;            /* ARGB */
+    uint32_t       i_karaoke_bg_color; /* ARGB */
 
     font_stack_t  *p_next;
 };
@@ -221,16 +225,20 @@ struct font_stack_t
 typedef struct
 {
     int         i_font_size;
-    uint32_t    i_font_color; /* ARGB */
-    vlc_bool_t  b_italic;
-    vlc_bool_t  b_bold;
-    vlc_bool_t  b_underline;
+    uint32_t    i_font_color;         /* ARGB */
+    uint32_t    i_karaoke_bg_color;   /* ARGB */
+    bool  b_italic;
+    bool  b_bold;
+    bool  b_underline;
     char       *psz_fontname;
 } ft_style_t;
 
 static int Render( filter_t *, subpicture_region_t *, line_desc_t *, int, int);
 static void FreeLines( line_desc_t * );
 static void FreeLine( line_desc_t * );
+#ifdef HAVE_FONTCONFIG
+static void FontBuilder( vlc_object_t *p_this);
+#endif
 
 /*****************************************************************************
  * filter_sys_t: freetype local data
@@ -242,7 +250,7 @@ struct filter_sys_t
 {
     FT_Library     p_library;   /* handle to library     */
     FT_Face        p_face;      /* handle to face object */
-    vlc_bool_t     i_use_kerning;
+    bool     i_use_kerning;
     uint8_t        i_font_opacity;
     int            i_font_color;
     int            i_font_size;
@@ -252,7 +260,12 @@ struct filter_sys_t
     int            i_display_height;
 #ifdef HAVE_FONTCONFIG
     FcConfig      *p_fontconfig;
+    bool     b_fontconfig_ok;
+    vlc_mutex_t    fontconfig_lock;
 #endif
+
+    input_attachment_t **pp_font_attachments;
+    int                  i_font_attachments;
 };
 
 /*****************************************************************************
@@ -262,11 +275,13 @@ struct filter_sys_t
  *****************************************************************************/
 static int Create( vlc_object_t *p_this )
 {
-    filter_t *p_filter = (filter_t *)p_this;
-    filter_sys_t *p_sys;
-    char *psz_fontfile = NULL;
-    int i_error;
-    vlc_value_t val;
+    filter_t      *p_filter = (filter_t *)p_this;
+    filter_sys_t  *p_sys;
+    char          *psz_fontfile = NULL;
+    int            i_error;
+    vlc_value_t    val;
+    vlc_mutex_t   *lock;
+    vlc_object_t  *p_fontbuilder;
 
     /* Allocate structure */
     p_filter->p_sys = p_sys = malloc( sizeof( filter_sys_t ) );
@@ -303,7 +318,7 @@ static int Create( vlc_object_t *p_this )
     psz_fontfile = val.psz_string;
     if( !psz_fontfile || !*psz_fontfile )
     {
-        if( psz_fontfile ) free( psz_fontfile );
+        free( psz_fontfile );
         psz_fontfile = (char *)malloc( PATH_MAX + 1 );
         if( !psz_fontfile )
         {
@@ -321,12 +336,6 @@ static int Create( vlc_object_t *p_this )
 #endif
     }
 
-#ifdef HAVE_FONTCONFIG
-    if( FcInit() )
-        p_sys->p_fontconfig = FcConfigGetCurrent();
-    else
-        p_sys->p_fontconfig = NULL;
-#endif
     i_error = FT_Init_FreeType( &p_sys->p_library );
     if( i_error )
     {
@@ -353,25 +362,89 @@ static int Create( vlc_object_t *p_this )
         goto error;
     }
 
+#ifdef HAVE_FONTCONFIG
+    vlc_mutex_init( p_filter, &p_sys->fontconfig_lock );
+    p_sys->b_fontconfig_ok = false;
+    p_sys->p_fontconfig    = NULL;
+
+    /* Check for an existing Fontbuilder thread */
+    lock = var_AcquireMutex( "fontbuilder" );
+    p_fontbuilder = vlc_object_find_name( p_filter->p_libvlc,
+                                          "fontlist builder",
+                                          FIND_CHILD );
+
+    if( ! p_fontbuilder )
+    {
+        /* Create the FontBuilder thread as a child of a top-level
+         * object, so that it can survive the destruction of the
+         * freetype object - the fontlist only needs to be built once,
+         * and calling the fontbuild a second time while the first is
+         * still in progress can cause thread instabilities.
+         */
+
+        p_fontbuilder = vlc_object_create( p_filter->p_libvlc,
+                                           VLC_OBJECT_GENERIC );
+        if( p_fontbuilder )
+        {
+            p_fontbuilder->psz_object_name = "fontlist builder";
+            vlc_object_attach( p_fontbuilder, p_filter->p_libvlc );
+
+            var_Create( p_fontbuilder, "build-done", VLC_VAR_BOOL );
+            var_SetBool( p_fontbuilder, "build-done", false );
+
+            if( vlc_thread_create( p_fontbuilder,
+                                   "fontlist builder",
+                                   FontBuilder,
+                                   VLC_THREAD_PRIORITY_LOW,
+                                   false ) )
+            {
+                /* Don't destroy the fontconfig object - we won't be able to do
+                 * italics or bold or change the font face, but we will still
+                 * be able to do underline and change the font size.
+                 */
+                msg_Warn( p_filter, "fontconfig database builder thread can't "
+                        "be launched. Font styling support will be limited." );
+            }
+        }
+        else
+        {
+            vlc_object_release( p_fontbuilder );
+        }
+    }
+    else
+    {
+        vlc_object_release( p_fontbuilder );
+    }
+    vlc_mutex_unlock( lock );
+
+#endif
+
     p_sys->i_use_kerning = FT_HAS_KERNING( p_sys->p_face );
 
     var_Get( p_filter, "freetype-fontsize", &val );
     p_sys->i_default_font_size = val.i_int;
     if( SetFontSize( p_filter, 0 ) != VLC_SUCCESS ) goto error;
 
-    if( psz_fontfile ) free( psz_fontfile );
+    free( psz_fontfile );
+
+    p_sys->pp_font_attachments = NULL;
+    p_sys->i_font_attachments = 0;
+
     p_filter->pf_render_text = RenderText;
 #ifdef HAVE_FONTCONFIG
     p_filter->pf_render_html = RenderHtml;
 #else
     p_filter->pf_render_html = NULL;
 #endif
+
+    LoadFontsFromAttachments( p_filter );
+
     return VLC_SUCCESS;
 
  error:
     if( p_sys->p_face ) FT_Done_Face( p_sys->p_face );
     if( p_sys->p_library ) FT_Done_FreeType( p_sys->p_library );
-    if( psz_fontfile ) free( psz_fontfile );
+    free( psz_fontfile );
     free( p_sys );
     return VLC_EGENERIC;
 }
@@ -386,9 +459,26 @@ static void Destroy( vlc_object_t *p_this )
     filter_t *p_filter = (filter_t *)p_this;
     filter_sys_t *p_sys = p_filter->p_sys;
 
+    if( p_sys->pp_font_attachments )
+    {
+        int   k;
+
+        for( k = 0; k < p_sys->i_font_attachments; k++ )
+        {
+            vlc_input_attachment_Delete( p_sys->pp_font_attachments[k] );
+        }
+
+        free( p_sys->pp_font_attachments );
+    }
+
 #ifdef HAVE_FONTCONFIG
-    FcConfigDestroy( p_sys->p_fontconfig );
-    p_sys->p_fontconfig = NULL;
+    vlc_mutex_destroy( &p_sys->fontconfig_lock );
+
+    if( p_sys->p_fontconfig )
+    {
+        FcConfigDestroy( p_sys->p_fontconfig );
+        p_sys->p_fontconfig = NULL;
+    }
     /* FcFini asserts calling the subfunction FcCacheFini()
      * even if no other library functions have been made since FcInit(),
      * so don't call it. */
@@ -398,6 +488,105 @@ static void Destroy( vlc_object_t *p_this )
     free( p_sys );
 }
 
+#ifdef HAVE_FONTCONFIG
+
+static void FontBuilder( vlc_object_t *p_this )
+{
+    FcConfig      *p_fontconfig = FcInitLoadConfig();
+    vlc_mutex_t   *lock;
+
+    vlc_thread_ready( p_this );
+
+    if( p_fontconfig )
+    {
+        mtime_t    t1, t2;
+
+        msg_Dbg( p_this, "Building font database..." );
+        t1 = mdate();
+        if(! FcConfigBuildFonts( p_fontconfig ))
+        {
+            /* Don't destroy the fontconfig object - we won't be able to do
+             * italics or bold or change the font face, but we will still
+             * be able to do underline and change the font size.
+             */
+            msg_Err( p_this, "fontconfig database can't be built. "
+                                    "Font styling won't be available" );
+        }
+        t2 = mdate();
+
+        msg_Dbg( p_this, "Finished building font database." );
+        msg_Dbg( p_this, "Took %ld seconds", (long)((t2 - t1)/1000000) );
+
+        lock = var_AcquireMutex( "fontbuilder" );
+        var_SetBool( p_this, "build-done", true );
+
+        FcConfigDestroy( p_fontconfig );
+        vlc_mutex_unlock( lock );
+    }
+    vlc_object_detach( p_this );
+    vlc_object_release( p_this );
+}
+
+#endif
+
+/*****************************************************************************
+ * Make any TTF/OTF fonts present in the attachments of the media file
+ * and store them for later use by the FreeType Engine
+ *****************************************************************************/
+static int LoadFontsFromAttachments( filter_t *p_filter )
+{
+    filter_sys_t         *p_sys = p_filter->p_sys;
+    input_thread_t       *p_input;
+    input_attachment_t  **pp_attachments;
+    int                   i_attachments_cnt;
+    int                   k;
+    int                   rv = VLC_SUCCESS;
+
+    p_input = (input_thread_t *)vlc_object_find( p_filter, VLC_OBJECT_INPUT, FIND_PARENT );
+    if( ! p_input )
+        return VLC_EGENERIC;
+
+    if( VLC_SUCCESS != input_Control( p_input, INPUT_GET_ATTACHMENTS, &pp_attachments, &i_attachments_cnt ))
+    {
+        vlc_object_release(p_input);
+        return VLC_EGENERIC;
+    }
+
+    p_sys->i_font_attachments = 0;
+    p_sys->pp_font_attachments = malloc( i_attachments_cnt * sizeof( input_attachment_t * ));
+    if(! p_sys->pp_font_attachments )
+        rv = VLC_ENOMEM;
+
+    for( k = 0; k < i_attachments_cnt; k++ )
+    {
+        input_attachment_t *p_attach = pp_attachments[k];
+
+        if( p_sys->pp_font_attachments )
+        {
+            if(( !strcmp( p_attach->psz_mime, "application/x-truetype-font" ) || // TTF
+                 !strcmp( p_attach->psz_mime, "application/x-font-otf" ) ) &&    // OTF
+               ( p_attach->i_data > 0 ) &&
+               ( p_attach->p_data != NULL ) )
+            {
+                p_sys->pp_font_attachments[ p_sys->i_font_attachments++ ] = p_attach;
+            }
+            else
+            {
+                vlc_input_attachment_Delete( p_attach );
+            }
+        }
+        else
+        {
+            vlc_input_attachment_Delete( p_attach );
+        }
+    }
+    free( pp_attachments );
+
+    vlc_object_release(p_input);
+
+    return rv;
+}
+
 /*****************************************************************************
  * Render: place string in picture
  *****************************************************************************
@@ -486,13 +675,11 @@ static int Render( filter_t *p_filter, subpicture_region_t *p_region,
 
         if( p_line->i_width < i_width )
         {
-            if( ( p_region->p_style && p_region->p_style->i_text_align == SUBPICTURE_ALIGN_RIGHT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT ) )
+            if( (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT )
             {
                 i_align_offset = i_width - p_line->i_width;
             }
-            else if( ( p_region->p_style && p_region->p_style->i_text_align != SUBPICTURE_ALIGN_LEFT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT ) )
+            else if( (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT )
             {
                 i_align_offset = ( i_width - p_line->i_width ) / 2;
             }
@@ -547,11 +734,11 @@ static int Render( filter_t *p_filter, subpicture_region_t *p_region,
     return VLC_SUCCESS;
 }
 
-static void UnderlineGlyphYUVA( int i_line_thickness, int i_line_offset, vlc_bool_t b_ul_next_char,
+static void UnderlineGlyphYUVA( int i_line_thickness, int i_line_offset, bool b_ul_next_char,
                                 FT_BitmapGlyph  p_this_glyph, FT_Vector *p_this_glyph_pos,
                                 FT_BitmapGlyph  p_next_glyph, FT_Vector *p_next_glyph_pos,
                                 int i_glyph_tmax, int i_align_offset,
-                                uint8_t i_y, uint8_t i_u, uint8_t i_v, uint8_t i_alpha,
+                                uint8_t i_y, uint8_t i_u, uint8_t i_v,
                                 subpicture_region_t *p_region)
 {
     int y, x, z;
@@ -578,7 +765,7 @@ static void UnderlineGlyphYUVA( int i_line_thickness, int i_line_offset, vlc_boo
         }
         for( x = 0; x < i_extra; x++ )
         {
-            vlc_bool_t b_ok = VLC_TRUE;
+            bool b_ok = true;
 
             /* break the underline around the tails of any glyphs which cross it */
             for( z = x - i_line_thickness;
@@ -592,7 +779,7 @@ static void UnderlineGlyphYUVA( int i_line_thickness, int i_line_offset, vlc_boo
                     if( ( p_next_glyph->bitmap.rows > i_row ) &&
                         p_next_glyph->bitmap.buffer[p_next_glyph->bitmap.width * i_row + z-i_extra] )
                     {
-                        b_ok = VLC_FALSE;
+                        b_ok = false;
                     }
                 }
                 else if ((z > 0 ) && (z < p_this_glyph->bitmap.width))
@@ -602,7 +789,7 @@ static void UnderlineGlyphYUVA( int i_line_thickness, int i_line_offset, vlc_boo
                     if( ( p_this_glyph->bitmap.rows > i_row ) &&
                         p_this_glyph->bitmap.buffer[p_this_glyph->bitmap.width * i_row + z] )
                     {
-                        b_ok = VLC_FALSE;
+                        b_ok = false;
                     }
                 }
             }
@@ -637,13 +824,11 @@ static void DrawBlack( line_desc_t *p_line, int i_width, subpicture_region_t *p_
 
         if( p_line->i_width < i_width )
         {
-            if( ( p_region->p_style && p_region->p_style->i_text_align == SUBPICTURE_ALIGN_RIGHT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT ) )
+            if( (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT )
             {
                 i_align_offset = i_width - p_line->i_width;
             }
-            else if( ( p_region->p_style && p_region->p_style->i_text_align != SUBPICTURE_ALIGN_LEFT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT ) )
+            else if( (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT )
             {
                 i_align_offset = ( i_width - p_line->i_width ) / 2;
             }
@@ -715,12 +900,10 @@ static int RenderYUVA( filter_t *p_filter, subpicture_region_t *p_region,
     free( p_region_tmp );
 
     /* Calculate text color components */
-    i_y = (uint8_t)__MIN(abs( 2104 * p_line->i_red  + 4130 * p_line->i_green +
-                      802 * p_line->i_blue + 4096 + 131072 ) >> 13, 235);
-    i_u = (uint8_t)__MIN(abs( -1214 * p_line->i_red  + -2384 * p_line->i_green +
-                     3598 * p_line->i_blue + 4096 + 1048576) >> 13, 240);
-    i_v = (uint8_t)__MIN(abs( 3598 * p_line->i_red + -3013 * p_line->i_green +
-                      -585 * p_line->i_blue + 4096 + 1048576) >> 13, 240);
+    YUVFromRGB( (p_line->i_red   << 16) |
+                (p_line->i_green <<  8) |
+                (p_line->i_blue       ),
+                &i_y, &i_u, &i_v);
     i_alpha = p_line->i_alpha;
 
     p_dst_y = p_region->picture.Y_PIXELS;
@@ -789,13 +972,11 @@ static int RenderYUVA( filter_t *p_filter, subpicture_region_t *p_region,
 
         if( p_line->i_width < i_width )
         {
-            if( ( p_region->p_style && p_region->p_style->i_text_align == SUBPICTURE_ALIGN_RIGHT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT ) )
+            if( (p_region->i_align & 0x3) == SUBPICTURE_ALIGN_RIGHT )
             {
                 i_align_offset = i_width - p_line->i_width;
             }
-            else if( ( p_region->p_style && p_region->p_style->i_text_align != SUBPICTURE_ALIGN_LEFT ) ||
-                ( !p_region->p_style && (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT ) )
+            else if( (p_region->i_align & 0x3) != SUBPICTURE_ALIGN_LEFT )
             {
                 i_align_offset = ( i_width - p_line->i_width ) / 2;
             }
@@ -813,22 +994,29 @@ static int RenderYUVA( filter_t *p_filter, subpicture_region_t *p_region,
             if( p_line->b_new_color_mode )
             {
                 /* Every glyph can (and in fact must) have its own color */
-                int i_red   = ( p_line->p_rgb[ i ] & 0x00ff0000 ) >> 16;
-                int i_green = ( p_line->p_rgb[ i ] & 0x0000ff00 ) >>  8;
-                int i_blue  = ( p_line->p_rgb[ i ] & 0x000000ff );
-
-                i_y = (uint8_t)__MIN(abs( 2104 * i_red  + 4130 * i_green +
-                                  802 * i_blue + 4096 + 131072 ) >> 13, 235);
-                i_u = (uint8_t)__MIN(abs( -1214 * i_red  + -2384 * i_green +
-                                 3598 * i_blue + 4096 + 1048576) >> 13, 240);
-                i_v = (uint8_t)__MIN(abs( 3598 * i_red + -3013 * i_green +
-                                  -585 * i_blue + 4096 + 1048576) >> 13, 240);
+                YUVFromRGB( p_line->p_fg_rgb[ i ], &i_y, &i_u, &i_v );
             }
 
             for( y = 0, i_bitmap_offset = 0; y < p_glyph->bitmap.rows; y++ )
             {
                 for( x = 0; x < p_glyph->bitmap.width; x++, i_bitmap_offset++ )
                 {
+                    uint8_t i_y_local = i_y;
+                    uint8_t i_u_local = i_u;
+                    uint8_t i_v_local = i_v;
+
+                    if( p_line->p_fg_bg_ratio != 0x00 )
+                    {
+                        int i_split = p_glyph->bitmap.width *
+                                      p_line->p_fg_bg_ratio[ i ] / 0x7f;
+
+                        if( x > i_split )
+                        {
+                            YUVFromRGB( p_line->p_bg_rgb[ i ],
+                                        &i_y_local, &i_u_local, &i_v_local );
+                        }
+                    }
+
                     if( p_glyph->bitmap.buffer[i_bitmap_offset] )
                     {
                         p_dst_y[i_offset+x] = ((p_dst_y[i_offset+x] *(255-(int)p_glyph->bitmap.buffer[i_bitmap_offset])) +
@@ -852,7 +1040,7 @@ static int RenderYUVA( filter_t *p_filter, subpicture_region_t *p_region,
                                     p_line->pp_glyphs[i], &(p_line->p_glyph_pos[i]),
                                     p_line->pp_glyphs[i+1], &(p_line->p_glyph_pos[i+1]),
                                     i_glyph_tmax, i_align_offset,
-                                    i_y, i_u, i_v, i_alpha,
+                                    i_y, i_u, i_v,
                                     p_region);
             }
         }
@@ -882,6 +1070,8 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
     char *psz_string;
     vlc_iconv_t iconv_handle = (vlc_iconv_t)(-1);
     int i_font_color, i_font_alpha, i_font_size, i_red, i_green, i_blue;
+    vlc_value_t val;
+    int i_scale = 1000;
 
     FT_BBox line;
     FT_BBox glyph_size;
@@ -893,17 +1083,20 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
     psz_string = p_region_in->psz_text;
     if( !psz_string || !*psz_string ) return VLC_EGENERIC;
 
+    if( VLC_SUCCESS == var_Get( p_filter, "scale", &val ))
+        i_scale = val.i_int;
+
     if( p_region_in->p_style )
     {
         i_font_color = __MAX( __MIN( p_region_in->p_style->i_font_color, 0xFFFFFF ), 0 );
         i_font_alpha = __MAX( __MIN( p_region_in->p_style->i_font_alpha, 255 ), 0 );
-        i_font_size  = __MAX( __MIN( p_region_in->p_style->i_font_size, 255 ), 0 );
+        i_font_size  = __MAX( __MIN( p_region_in->p_style->i_font_size, 255 ), 0 ) * i_scale / 1000;
     }
     else
     {
         i_font_color = p_sys->i_font_color;
         i_font_alpha = 255 - p_sys->i_font_opacity;
-        i_font_size  = p_sys->i_default_font_size;
+        i_font_size  = p_sys->i_default_font_size * i_scale / 1000;
     }
 
     if( i_font_color == 0xFFFFFF ) i_font_color = p_sys->i_font_color;
@@ -943,15 +1136,16 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
         i_out_bytes = i_in_bytes * sizeof( uint32_t );
         i_out_bytes_left = i_out_bytes;
         p_out_buffer = (char *)psz_unicode;
-        i_ret = vlc_iconv( iconv_handle, (const char**)&p_in_buffer, &i_in_bytes,
+        i_ret = vlc_iconv( iconv_handle, (const char**)&p_in_buffer,
+                           &i_in_bytes,
                            &p_out_buffer, &i_out_bytes_left );
 
         vlc_iconv_close( iconv_handle );
 
         if( i_in_bytes )
         {
-            msg_Warn( p_filter, "failed to convert string to unicode (%s), "
-                      "bytes left %d", strerror(errno), (int)i_in_bytes );
+            msg_Warn( p_filter, "failed to convert string to unicode (%m), "
+                      "bytes left %u", (unsigned)i_in_bytes );
             goto error;
         }
         *(uint32_t*)p_out_buffer = 0;
@@ -961,7 +1155,7 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
 #if defined(HAVE_FRIBIDI)
     {
         uint32_t *p_fribidi_string;
-        int start_pos, pos = 0;
+        int32_t start_pos, pos = 0;
 
         p_fribidi_string = malloc( (i_string_length + 1) * sizeof(uint32_t) );
         if( !p_fribidi_string )
@@ -971,9 +1165,10 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
         }
 
         /* Do bidi conversion line-by-line */
-        while(pos < i_string_length)
+        while( pos < i_string_length )
         {
-            while(pos < i_string_length) {
+            while( pos < i_string_length ) 
+            {
                 i_char = psz_unicode[pos];
                 if (i_char != '\r' && i_char != '\n')
                     break;
@@ -981,7 +1176,8 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
                 ++pos;
             }
             start_pos = pos;
-            while(pos < i_string_length) {
+            while( pos < i_string_length )
+            {
                 i_char = psz_unicode[pos];
                 if (i_char == '\r' || i_char == '\n')
                     break;
@@ -990,8 +1186,11 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
             if (pos > start_pos)
             {
                 FriBidiCharType base_dir = FRIBIDI_TYPE_LTR;
-                fribidi_log2vis((FriBidiChar*)psz_unicode + start_pos, pos - start_pos,
-                                &base_dir, (FriBidiChar*)p_fribidi_string + start_pos, 0, 0, 0);
+                fribidi_log2vis((FriBidiChar*)psz_unicode + start_pos,
+                                pos - start_pos,
+                                &base_dir,
+                                (FriBidiChar*)p_fribidi_string + start_pos,
+                                0, 0, 0);
             }
         }
 
@@ -1100,11 +1299,22 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
             if( p_prev ) p_prev->p_next = p_line;
             else p_lines = p_line;
 
+            uint32_t *psz_unicode_saved = psz_unicode;
             while( psz_unicode > psz_line_start && *psz_unicode != ' ' )
             {
                 psz_unicode--;
             }
             if( psz_unicode == psz_line_start )
+            {   /* try harder to break that line */
+                psz_unicode = psz_unicode_saved;
+                while( psz_unicode > psz_line_start &&
+                    *psz_unicode != '_'  && *psz_unicode != '/' &&
+                    *psz_unicode != '\\' && *psz_unicode != '.' )
+                {
+                    psz_unicode--;
+                }
+            }
+            if( psz_unicode == psz_line_start )
             {
                 msg_Warn( p_filter, "unbreakable string" );
                 goto error;
@@ -1148,35 +1358,32 @@ static int RenderText( filter_t *p_filter, subpicture_region_t *p_region_out,
     else
         RenderYUVA( p_filter, p_region_out, p_lines, result.x, result.y );
 
-    if( psz_unicode_orig ) free( psz_unicode_orig );
+    free( psz_unicode_orig );
     FreeLines( p_lines );
     return VLC_SUCCESS;
 
  error:
-    if( psz_unicode_orig ) free( psz_unicode_orig );
+    free( psz_unicode_orig );
     FreeLines( p_lines );
     return VLC_EGENERIC;
 }
 
 #ifdef HAVE_FONTCONFIG
 static ft_style_t *CreateStyle( char *psz_fontname, int i_font_size,
-        int i_font_color, int i_font_alpha, vlc_bool_t b_bold,
-        vlc_bool_t b_italic, vlc_bool_t b_uline )
+        uint32_t i_font_color, uint32_t i_karaoke_bg_color, bool b_bold,
+        bool b_italic, bool b_uline )
 {
     ft_style_t  *p_style = malloc( sizeof( ft_style_t ));
 
     if( p_style )
     {
-        p_style->i_font_size  = i_font_size;
-        p_style->i_font_color = ( i_font_color & 0x00ffffff )
-                                | (( i_font_alpha & 0xff ) << 24 );
-        p_style->b_italic     = b_italic;
-        p_style->b_bold       = b_bold;
-        p_style->b_underline  = b_uline;
-        /* p_style has just been malloc'ed in this function -
-         * it CAN'T have a previous assignment, and hence we
-         * don't need to do a free() for any previous value -
-         * which will in fact be undefined. */
+        p_style->i_font_size        = i_font_size;
+        p_style->i_font_color       = i_font_color;
+        p_style->i_karaoke_bg_color = i_karaoke_bg_color;
+        p_style->b_italic           = b_italic;
+        p_style->b_bold             = b_bold;
+        p_style->b_underline        = b_uline;
+
         p_style->psz_fontname = strdup( psz_fontname );
     }
     return p_style;
@@ -1186,18 +1393,17 @@ static void DeleteStyle( ft_style_t *p_style )
 {
     if( p_style )
     {
-        if( p_style->psz_fontname )
-            free( p_style->psz_fontname );
+        free( p_style->psz_fontname );
         free( p_style );
     }
 }
 
-static vlc_bool_t StyleEquals( ft_style_t *s1, ft_style_t *s2 )
+static bool StyleEquals( ft_style_t *s1, ft_style_t *s2 )
 {
     if( !s1 || !s2 )
-        return VLC_FALSE;
+        return false;
     if( s1 == s2 )
-        return VLC_TRUE;
+        return true;
 
     if(( s1->i_font_size  == s2->i_font_size ) &&
        ( s1->i_font_color == s2->i_font_color ) &&
@@ -1206,13 +1412,13 @@ static vlc_bool_t StyleEquals( ft_style_t *s1, ft_style_t *s2 )
        ( s1->b_underline  == s2->b_underline ) &&
        ( !strcmp( s1->psz_fontname, s2->psz_fontname )))
     {
-        return VLC_TRUE;
+        return true;
     }
-    return VLC_FALSE;
+    return false;
 }
 
 static int PushFont( font_stack_t **p_font, const char *psz_name, int i_size,
-                     int i_color, int i_alpha )
+                     uint32_t i_color, uint32_t i_karaoke_bg_color )
 {
     font_stack_t *p_new;
 
@@ -1230,9 +1436,9 @@ static int PushFont( font_stack_t **p_font, const char *psz_name, int i_size,
     else
         p_new->psz_name = NULL;
 
-    p_new->i_size   = i_size;
-    p_new->i_color  = i_color;
-    p_new->i_alpha  = i_alpha;
+    p_new->i_size              = i_size;
+    p_new->i_color             = i_color;
+    p_new->i_karaoke_bg_color  = i_karaoke_bg_color;
 
     if( !*p_font )
     {
@@ -1279,7 +1485,7 @@ static int PopFont( font_stack_t **p_font )
 }
 
 static int PeekFont( font_stack_t **p_font, char **psz_name, int *i_size,
-                     int *i_color, int *i_alpha )
+                     uint32_t *i_color, uint32_t *i_karaoke_bg_color )
 {
     font_stack_t *p_last;
 
@@ -1291,10 +1497,10 @@ static int PeekFont( font_stack_t **p_font, char **psz_name, int *i_size,
          p_last=p_last->p_next )
     ;
 
-    *psz_name = p_last->psz_name;
-    *i_size   = p_last->i_size;
-    *i_color  = p_last->i_color;
-    *i_alpha  = p_last->i_alpha;
+    *psz_name            = p_last->psz_name;
+    *i_size              = p_last->i_size;
+    *i_color             = p_last->i_color;
+    *i_karaoke_bg_color  = p_last->i_karaoke_bg_color;
 
     return VLC_SUCCESS;
 }
@@ -1337,8 +1543,8 @@ static void IconvText( filter_t *p_filter, const char *psz_string,
 
             if( i_in_bytes )
             {
-                msg_Warn( p_filter, "failed to convert string to unicode (%s), "
-                          "bytes left %d", strerror(errno), (int)i_in_bytes );
+                msg_Warn( p_filter, "failed to convert string to unicode (%m), "
+                          "bytes left %u", (unsigned)i_in_bytes );
             }
             else
             {
@@ -1355,34 +1561,35 @@ static void IconvText( filter_t *p_filter, const char *psz_string,
 }
 
 static ft_style_t *GetStyleFromFontStack( filter_sys_t *p_sys,
-        font_stack_t **p_fonts, vlc_bool_t b_bold, vlc_bool_t b_italic, 
-        vlc_bool_t b_uline )
+        font_stack_t **p_fonts, bool b_bold, bool b_italic,
+        bool b_uline )
 {
     ft_style_t   *p_style = NULL;
 
-    char  *psz_fontname = NULL;
-    int    i_font_color = p_sys->i_font_color;
-    int    i_font_alpha = 0;
-    int    i_font_size  = p_sys->i_font_size;
+    char       *psz_fontname = NULL;
+    uint32_t    i_font_color = p_sys->i_font_color & 0x00ffffff;
+    uint32_t    i_karaoke_bg_color = i_font_color;
+    int         i_font_size  = p_sys->i_font_size;
 
     if( VLC_SUCCESS == PeekFont( p_fonts, &psz_fontname, &i_font_size,
-                                 &i_font_color, &i_font_alpha ) )
+                                 &i_font_color, &i_karaoke_bg_color ))
     {
         p_style = CreateStyle( psz_fontname, i_font_size, i_font_color,
-                i_font_alpha, b_bold, b_italic, b_uline );
+                i_karaoke_bg_color, b_bold, b_italic, b_uline );
     }
     return p_style;
 }
 
 static int RenderTag( filter_t *p_filter, FT_Face p_face, int i_font_color,
-                      vlc_bool_t b_uline, line_desc_t *p_line,
-                      uint32_t *psz_unicode, int *pi_pen_x, int i_pen_y,
-                      int *pi_start, FT_Vector *p_result )
+                      bool b_uline, int i_karaoke_bgcolor,
+                      line_desc_t *p_line, uint32_t *psz_unicode,
+                      int *pi_pen_x, int i_pen_y, int *pi_start,
+                      FT_Vector *p_result )
 {
     FT_BBox      line;
     int          i_yMin, i_yMax;
     int          i;
-    vlc_bool_t   b_first_on_line = VLC_TRUE;
+    bool   b_first_on_line = true;
 
     int          i_previous = 0;
     int          i_pen_x_start = *pi_pen_x;
@@ -1408,7 +1615,7 @@ static int RenderTag( filter_t *p_filter, FT_Face p_face, int i_font_color,
     i_yMax = line.yMax;
 
     if( line.xMax > 0 )
-        b_first_on_line = VLC_FALSE;
+        b_first_on_line = false;
 
     while( *psz_unicode && ( *psz_unicode != '\n' ) )
     {
@@ -1464,7 +1671,9 @@ static int RenderTag( filter_t *p_filter, FT_Face p_face, int i_font_color,
                                        ( aSize < 0 ) ? -aSize   : aSize;
         }
         p_line->pp_glyphs[ i ] = (FT_BitmapGlyph)tmp_glyph;
-        p_line->p_rgb[ i ] = i_font_color & 0x00ffffff;
+        p_line->p_fg_rgb[ i ] = i_font_color & 0x00ffffff;
+        p_line->p_bg_rgb[ i ] = i_karaoke_bgcolor & 0x00ffffff;
+        p_line->p_fg_bg_ratio[ i ] = 0x00;
 
         line.xMax = p_line->p_glyph_pos[i].x + glyph_size.xMax -
                     glyph_size.xMin + ((FT_BitmapGlyph)tmp_glyph)->left;
@@ -1539,9 +1748,8 @@ static int RenderTag( filter_t *p_filter, FT_Face p_face, int i_font_color,
     {
         *psz_unicode_start = '\0';
     }
-    else
+    else if( psz_unicode > psz_unicode_start )
     {
-        psz_unicode++;
         for( i=0; psz_unicode[ i ]; i++ )
             psz_unicode_start[ i ] = psz_unicode[ i ];
         psz_unicode_start[ i ] = '\0';
@@ -1551,13 +1759,14 @@ static int RenderTag( filter_t *p_filter, FT_Face p_face, int i_font_color,
 }
 
 static int HandleFontAttributes( xml_reader_t *p_xml_reader,
-                                  font_stack_t **p_fonts )
+                                  font_stack_t **p_fonts, int i_scale )
 {
-    int   rv;
-    char *psz_fontname = NULL;
-    int   i_font_color = 0xffffff;
-    int   i_font_alpha = 0;
-    int   i_font_size  = 24;
+    int        rv;
+    char      *psz_fontname = NULL;
+    uint32_t   i_font_color = 0xffffff;
+    int        i_font_alpha = 0;
+    uint32_t   i_karaoke_bg_color = 0x00ffffff;
+    int        i_font_size  = 24;
 
     /* Default all attributes to the top font in the stack -- in case not
      * all attributes are specified in the sub-font
@@ -1566,21 +1775,24 @@ static int HandleFontAttributes( xml_reader_t *p_xml_reader,
                                  &psz_fontname,
                                  &i_font_size,
                                  &i_font_color,
-                                 &i_font_alpha ))
+                                 &i_karaoke_bg_color ))
     {
         psz_fontname = strdup( psz_fontname );
+        i_font_size = i_font_size * 1000 / i_scale;
     }
+    i_font_alpha = (i_font_color >> 24) & 0xff;
+    i_font_color &= 0x00ffffff;
 
     while ( xml_ReaderNextAttr( p_xml_reader ) == VLC_SUCCESS )
     {
-        char *psz_name = xml_ReaderName ( p_xml_reader );
-        char *psz_value = xml_ReaderValue ( p_xml_reader );
+        char *psz_name = xml_ReaderName( p_xml_reader );
+        char *psz_value = xml_ReaderValue( p_xml_reader );
 
         if( psz_name && psz_value )
         {
             if( !strcasecmp( "face", psz_name ) )
             {
-                if( psz_fontname ) free( psz_fontname );
+                free( psz_fontname );
                 psz_fontname = strdup( psz_value );
             }
             else if( !strcasecmp( "size", psz_name ) )
@@ -1617,9 +1829,9 @@ static int HandleFontAttributes( xml_reader_t *p_xml_reader,
     }
     rv = PushFont( p_fonts,
                    psz_fontname,
-                   i_font_size,
-                   i_font_color,
-                   i_font_alpha );
+                   i_font_size * i_scale / 1000,
+                   (i_font_color & 0xffffff) | ((i_font_alpha & 0xff) << 24),
+                   i_karaoke_bg_color );
 
     free( psz_fontname );
 
@@ -1682,44 +1894,139 @@ static void SetupLine( filter_t *p_filter, const char *psz_text_in,
     if( p_style ) DeleteStyle( p_style );
 }
 
-static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
-                         text_style_t *p_font_style, uint32_t *psz_text,
-                         int *pi_len, uint32_t *pi_runs,
-                         uint32_t **ppi_run_lengths, ft_style_t ***ppp_styles)
+static void SetKaraokeLen( uint32_t i_runs, uint32_t *pi_run_lengths,
+                           uint32_t i_k_runs, uint32_t *pi_k_run_lengths )
+{
+    /* Karaoke tags _PRECEDE_ the text they specify a duration
+     * for, therefore we are working out the length for the
+     * previous tag, and first time through we have nothing
+     */
+    if( pi_k_run_lengths )
+    {
+        int i_chars = 0;
+        uint32_t i;
+
+        /* Work out how many characters are presently in the string
+         */
+        for( i = 0; i < i_runs; i++ )
+            i_chars += pi_run_lengths[ i ];
+
+        /* Subtract away those we've already allocated to other
+         * karaoke tags
+         */
+        for( i = 0; i < i_k_runs; i++ )
+            i_chars -= pi_k_run_lengths[ i ];
+
+        pi_k_run_lengths[ i_k_runs - 1 ] = i_chars;
+    }
+}
+
+static void SetupKaraoke( xml_reader_t *p_xml_reader, uint32_t *pi_k_runs,
+                          uint32_t **ppi_k_run_lengths,
+                          uint32_t **ppi_k_durations )
+{
+    while ( xml_ReaderNextAttr( p_xml_reader ) == VLC_SUCCESS )
+    {
+        char *psz_name = xml_ReaderName( p_xml_reader );
+        char *psz_value = xml_ReaderValue( p_xml_reader );
+
+        if( psz_name && psz_value &&
+            !strcasecmp( "t", psz_name ) )
+        {
+            if( ppi_k_durations && ppi_k_run_lengths )
+            {
+                (*pi_k_runs)++;
+
+                if( *ppi_k_durations )
+                {
+                    *ppi_k_durations = (uint32_t *)
+                        realloc( *ppi_k_durations,
+                                 *pi_k_runs * sizeof( uint32_t ) );
+                }
+                else if( *pi_k_runs == 1 )
+                {
+                    *ppi_k_durations = (uint32_t *)
+                        malloc( *pi_k_runs * sizeof( uint32_t ) );
+                }
+
+                if( *ppi_k_run_lengths )
+                {
+                    *ppi_k_run_lengths = (uint32_t *)
+                        realloc( *ppi_k_run_lengths,
+                                 *pi_k_runs * sizeof( uint32_t ) );
+                }
+                else if( *pi_k_runs == 1 )
+                {
+                    *ppi_k_run_lengths = (uint32_t *)
+                        malloc( *pi_k_runs * sizeof( uint32_t ) );
+                }
+                if( *ppi_k_durations )
+                    (*ppi_k_durations)[ *pi_k_runs - 1 ] = atoi( psz_value );
+
+                if( *ppi_k_run_lengths )
+                    (*ppi_k_run_lengths)[ *pi_k_runs - 1 ] = 0;
+            }
+        }
+        free( psz_name );
+        free( psz_value );
+    }
+}
+
+static int ProcessNodes( filter_t *p_filter,
+                         xml_reader_t *p_xml_reader,
+                         text_style_t *p_font_style,
+                         uint32_t *psz_text,
+                         int *pi_len,
+
+                         uint32_t *pi_runs,
+                         uint32_t **ppi_run_lengths,
+                         ft_style_t ***ppp_styles,
+
+                         bool b_karaoke,
+                         uint32_t *pi_k_runs,
+                         uint32_t **ppi_k_run_lengths,
+                         uint32_t **ppi_k_durations )
 {
     int           rv             = VLC_SUCCESS;
     filter_sys_t *p_sys          = p_filter->p_sys;
     uint32_t     *psz_text_orig  = psz_text;
     font_stack_t *p_fonts        = NULL;
+    vlc_value_t   val;
+    int           i_scale        = 1000;
 
     char *psz_node  = NULL;
 
-    vlc_bool_t b_italic = VLC_FALSE;
-    vlc_bool_t b_bold   = VLC_FALSE;
-    vlc_bool_t b_uline  = VLC_FALSE;
+    bool b_italic = false;
+    bool b_bold   = false;
+    bool b_uline  = false;
+
+    if( VLC_SUCCESS == var_Get( p_filter, "scale", &val ))
+        i_scale = val.i_int;
 
     if( p_font_style )
     {
         rv = PushFont( &p_fonts,
-                       p_font_style->psz_fontname,
-                       p_font_style->i_font_size,
-                       p_font_style->i_font_color,
-                       p_font_style->i_font_alpha );
+               p_font_style->psz_fontname,
+               p_font_style->i_font_size * i_scale / 1000,
+               (p_font_style->i_font_color & 0xffffff) |
+                   ((p_font_style->i_font_alpha & 0xff) << 24),
+               (p_font_style->i_karaoke_background_color & 0xffffff) |
+                   ((p_font_style->i_karaoke_background_alpha & 0xff) << 24));
 
         if( p_font_style->i_style_flags & STYLE_BOLD )
-            b_bold = VLC_TRUE;
+            b_bold = true;
         if( p_font_style->i_style_flags & STYLE_ITALIC )
-            b_italic = VLC_TRUE;
+            b_italic = true;
         if( p_font_style->i_style_flags & STYLE_UNDERLINE )
-            b_uline = VLC_TRUE;
+            b_uline = true;
     }
     else
     {
         rv = PushFont( &p_fonts,
                        FC_DEFAULT_FONT,
                        p_sys->i_font_size,
-                       0xffffff,
-                       0 );
+                       0x00ffffff,
+                       0x00ffffff );
     }
     if( rv != VLC_SUCCESS )
         return rv;
@@ -1738,11 +2045,11 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
                     if( !strcasecmp( "font", psz_node ) )
                         PopFont( &p_fonts );
                     else if( !strcasecmp( "b", psz_node ) )
-                        b_bold   = VLC_FALSE;
+                        b_bold   = false;
                     else if( !strcasecmp( "i", psz_node ) )
-                        b_italic = VLC_FALSE;
+                        b_italic = false;
                     else if( !strcasecmp( "u", psz_node ) )
-                        b_uline  = VLC_FALSE;
+                        b_uline  = false;
 
                     free( psz_node );
                 }
@@ -1752,13 +2059,13 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
                 if( psz_node )
                 {
                     if( !strcasecmp( "font", psz_node ) )
-                        rv = HandleFontAttributes( p_xml_reader, &p_fonts );
+                        rv = HandleFontAttributes( p_xml_reader, &p_fonts, i_scale );
                     else if( !strcasecmp( "b", psz_node ) )
-                        b_bold = VLC_TRUE;
+                        b_bold = true;
                     else if( !strcasecmp( "i", psz_node ) )
-                        b_italic = VLC_TRUE;
+                        b_italic = true;
                     else if( !strcasecmp( "u", psz_node ) )
-                        b_uline = VLC_TRUE;
+                        b_uline = true;
                     else if( !strcasecmp( "br", psz_node ) )
                     {
                         SetupLine( p_filter, "\n", &psz_text,
@@ -1769,6 +2076,20 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
                                                           b_italic,
                                                           b_uline ) );
                     }
+                    else if( !strcasecmp( "k", psz_node ) )
+                    {
+                        /* Only valid in karaoke */
+                        if( b_karaoke )
+                        {
+                            if( *pi_k_runs > 0 )
+                            {
+                                SetKaraokeLen( *pi_runs, *ppi_run_lengths,
+                                               *pi_k_runs, *ppi_k_run_lengths );
+                            }
+                            SetupKaraoke( p_xml_reader, pi_k_runs,
+                                          ppi_k_run_lengths, ppi_k_durations );
+                        }
+                    }
 
                     free( psz_node );
                 }
@@ -1784,12 +2105,12 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
                         int i_whitespace = strspn( s, "\t\r\n " );
 
                         if( i_whitespace > 1 )
-                            memmove( s + 1,
-                                     s + i_whitespace,
+                            memmove( &s[1],
+                                     &s[i_whitespace],
                                      strlen( s ) - i_whitespace + 1 );
-                        *s = ' ';
+                        *s++ = ' ';
 
-                        s = strpbrk( s+1, "\t\r\n " );
+                        s = strpbrk( s, "\t\r\n " );
                     }
                     SetupLine( p_filter, psz_node, &psz_text,
                                pi_runs, ppi_run_lengths, ppp_styles,
@@ -1808,6 +2129,11 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
             break;
         }
     }
+    if( b_karaoke )
+    {
+        SetKaraokeLen( *pi_runs, *ppi_run_lengths,
+                       *pi_k_runs, *ppi_k_run_lengths );
+    }
 
     *pi_len = psz_text - psz_text_orig;
 
@@ -1816,13 +2142,103 @@ static int ProcessNodes( filter_t *p_filter, xml_reader_t *p_xml_reader,
     return rv;
 }
 
-static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
-                         int i_len, uint32_t i_runs,
-                         uint32_t *pi_run_lengths, ft_style_t **pp_styles,
-                         line_desc_t **pp_lines, FT_Vector *p_result )
+static int CheckForEmbeddedFont( filter_sys_t *p_sys, FT_Face *pp_face, ft_style_t *p_style )
+{
+    int k;
+
+    for( k=0; k < p_sys->i_font_attachments; k++ )
+    {
+        input_attachment_t *p_attach   = p_sys->pp_font_attachments[k];
+        int                 i_font_idx = 0;
+        FT_Face             p_face = NULL;
+
+        while( 0 == FT_New_Memory_Face( p_sys->p_library,
+                                        p_attach->p_data,
+                                        p_attach->i_data,
+                                        i_font_idx,
+                                        &p_face ))
+        {
+            if( p_face )
+            {
+                bool match = !strcasecmp( p_face->family_name,
+                                                p_style->psz_fontname );
+
+                if( p_face->style_flags & FT_STYLE_FLAG_BOLD )
+                    match = match && p_style->b_bold;
+                else
+                    match = match && !p_style->b_bold;
+
+                if( p_face->style_flags & FT_STYLE_FLAG_ITALIC )
+                    match = match && p_style->b_italic;
+                else
+                    match = match && !p_style->b_italic;
+
+                if(  match )
+                {
+                    *pp_face = p_face;
+                    return VLC_SUCCESS;
+                }
+
+                FT_Done_Face( p_face );
+            }
+            i_font_idx++;
+        }
+    }
+    return VLC_EGENERIC;
+}
+
+static int CheckIfFontBuildComplete( filter_t *p_filter )
+{
+    filter_sys_t   *p_sys = p_filter->p_sys;
+    vlc_object_t   *p_fb = vlc_object_find_name( p_filter->p_libvlc,
+                                                 "fontlist builder",
+                                                 FIND_CHILD );
+    if( p_fb )
+    {
+        vlc_mutex_t *lock = var_AcquireMutex( "fontbuilder" );
+        vlc_value_t  val;
+
+        if( VLC_SUCCESS == var_Get( p_fb, "build-done", &val ))
+        {
+            p_sys->b_fontconfig_ok = val.b_bool;
+
+            if( p_sys->b_fontconfig_ok )
+            {
+                FcInit();
+                p_sys->p_fontconfig = FcConfigGetCurrent();
+            }
+            else
+                msg_Dbg( p_filter, "Font Build still not complete" );
+        }
+        vlc_mutex_unlock( lock );
+        vlc_object_release( p_fb );
+
+        return VLC_SUCCESS;
+    }
+    return VLC_EGENERIC;
+}
+
+static int ProcessLines( filter_t *p_filter,
+                         uint32_t *psz_text,
+                         int i_len,
+
+                         uint32_t i_runs,
+                         uint32_t *pi_run_lengths,
+                         ft_style_t **pp_styles,
+                         line_desc_t **pp_lines,
+
+                         FT_Vector *p_result,
+
+                         bool b_karaoke,
+                         uint32_t i_k_runs,
+                         uint32_t *pi_k_run_lengths,
+                         uint32_t *pi_k_durations )
 {
     filter_sys_t   *p_sys = p_filter->p_sys;
-    ft_style_t     **pp_char_styles;
+    ft_style_t    **pp_char_styles;
+    int            *p_new_positions = NULL;
+    int8_t         *p_levels = NULL;
+    uint8_t        *pi_karaoke_bar = NULL;
     uint32_t        i, j, k;
     int             i_prev;
 
@@ -1834,6 +2250,15 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
     if( !pp_char_styles )
         return VLC_ENOMEM;
 
+    if( b_karaoke )
+    {
+        pi_karaoke_bar = (uint8_t *) malloc( i_len * sizeof( uint8_t ));
+        /* If we can't allocate sufficient memory for karaoke, continue anyway -
+         * we just won't be able to display the progress bar; at least we'll
+         * get the text.
+         */
+    }
+
     i = 0;
     for( j = 0; j < i_runs; j++ )
         for( k = 0; k < pi_run_lengths[ j ]; k++ )
@@ -1842,32 +2267,36 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
     {
         ft_style_t  **pp_char_styles_new;
-        int         *p_positions;
+        int         *p_old_positions;
         uint32_t    *p_fribidi_string;
         int start_pos, pos = 0;
 
-        p_fribidi_string = malloc( (i_len + 1) * sizeof(uint32_t) );
-        if(! p_fribidi_string )
-        {
-            msg_Err( p_filter, "out of memory" );
-            free( pp_char_styles );
-            return VLC_ENOMEM;
-        }
         pp_char_styles_new  = (ft_style_t **)
-                                       malloc( i_len * sizeof( ft_style_t * ));
-        if(! pp_char_styles_new )
+            malloc( i_len * sizeof( ft_style_t * ));
+
+        p_fribidi_string = (uint32_t *)
+            malloc( (i_len + 1) * sizeof(uint32_t) );
+        p_old_positions = (int *)
+            malloc( (i_len + 1) * sizeof( int ) );
+        p_new_positions = (int *)
+            malloc( (i_len + 1) * sizeof( int ) );
+        p_levels = (int8_t *)
+            malloc( (i_len + 1) * sizeof( int8_t ) );
+
+        if( ! pp_char_styles_new ||
+            ! p_fribidi_string ||
+            ! p_old_positions ||
+            ! p_new_positions ||
+            ! p_levels )
         {
             msg_Err( p_filter, "out of memory" );
+            free( p_levels );
+            free( p_old_positions );
+            free( p_new_positions );
             free( p_fribidi_string );
-            free( pp_char_styles );
-            return VLC_ENOMEM;
-        }
-        p_positions = (int *) malloc( (i_len + 1) * sizeof( int ) );
-        if(! p_positions )
-        {
-            msg_Err( p_filter, "out of memory" );
             free( pp_char_styles_new );
-            free( p_fribidi_string );
+            free( pi_karaoke_bar );
+
             free( pp_char_styles );
             return VLC_ENOMEM;
         }
@@ -1880,6 +2309,8 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
                     break;
                 p_fribidi_string[pos] = psz_text[pos];
                 pp_char_styles_new[pos] = pp_char_styles[pos];
+                p_new_positions[pos] = pos;
+                p_levels[pos] = 0;
                 ++pos;
             }
             start_pos = pos;
@@ -1894,23 +2325,87 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
                 fribidi_log2vis((FriBidiChar*)psz_text + start_pos,
                         pos - start_pos, &base_dir,
                         (FriBidiChar*)p_fribidi_string + start_pos,
-                        0,
-                        p_positions, 0);
-
+                        p_new_positions + start_pos,
+                        p_old_positions,
+                        p_levels + start_pos );
                 for( j = (uint32_t) start_pos; j < (uint32_t) pos; j++ )
                 {
                     pp_char_styles_new[ j ] = pp_char_styles[ start_pos +
-                                                p_positions[ j - start_pos ] ];
+                                                p_old_positions[ j - start_pos ] ];
+                    p_new_positions[ j ] += start_pos;
                 }
             }
         }
-        free( p_positions );
+        free( p_old_positions );
         free( pp_char_styles );
         pp_char_styles = pp_char_styles_new;
         psz_text = p_fribidi_string;
         p_fribidi_string[ i_len ] = 0;
     }
 #endif
+    /* Work out the karaoke */
+    if( pi_karaoke_bar )
+    {
+        int64_t i_last_duration = 0;
+        int64_t i_duration = 0;
+        int64_t i_start_pos = 0;
+        int64_t i_elapsed  = var_GetTime( p_filter, "spu-elapsed" ) / 1000;
+
+        for( k = 0; k< i_k_runs; k++ )
+        {
+             double fraction = 0.0;
+
+             i_duration += pi_k_durations[ k ];
+
+             if( i_duration < i_elapsed )
+             {
+                 /* Completely finished this run-length -
+                  * let it render normally */
+
+                 fraction = 1.0;
+             }
+             else if( i_elapsed < i_last_duration )
+             {
+                 /* Haven't got up to this segment yet -
+                  * render it completely in karaoke BG mode */
+
+                 fraction = 0.0;
+             }
+             else
+             {
+                 /* Partway through this run */
+
+                 fraction = (double)(i_elapsed - i_last_duration) /
+                            (double)pi_k_durations[ k ];
+             }
+             for( i = 0; i < pi_k_run_lengths[ k ]; i++ )
+             {
+                 double shade = pi_k_run_lengths[ k ] * fraction;
+
+                 if( p_new_positions )
+                     j = p_new_positions[ i_start_pos + i ];
+                 else
+                     j = i_start_pos + i;
+
+                 if( i < (uint32_t)shade )
+                     pi_karaoke_bar[ j ] = 0xff;
+                 else if( (double)i > shade )
+                     pi_karaoke_bar[ j ] = 0x00;
+                 else
+                 {
+                     shade -= (int)shade;
+                     pi_karaoke_bar[ j ] = ((int)(shade * 128.0) & 0x7f) |
+                                   ((p_levels ? (p_levels[ j ] % 2) : 0 ) << 7);
+                 }
+             }
+
+             i_last_duration = i_duration;
+             i_start_pos += pi_k_run_lengths[ k ];
+        }
+    }
+    free( p_levels );
+    free( p_new_positions );
+
     FT_Vector tmp_result;
 
     line_desc_t *p_line = NULL;
@@ -1935,24 +2430,63 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
             /* End of the current style run */
             FT_Face p_face = NULL;
             int      i_idx = 0;
-            char *psz_fontfile = FontConfig_Select( p_sys->p_fontconfig,
-                                                    p_style->psz_fontname,
-                                                    p_style->b_bold,
-                                                    p_style->b_italic,
-                                                    &i_idx );
-            if( psz_fontfile )
+
+            /* Look for a match amongst our attachments first */
+            CheckForEmbeddedFont( p_sys, &p_face, p_style );
+
+            if( !p_sys->b_fontconfig_ok )
+            {
+                if( VLC_EGENERIC == CheckIfFontBuildComplete( p_filter ))
+                    msg_Err( p_filter, "Can't find FontBuilder thread!" );
+            }
+
+            if( ! p_face && p_sys->b_fontconfig_ok )
             {
-                if( FT_New_Face( p_sys->p_library,
-                            psz_fontfile ? psz_fontfile : "", i_idx, &p_face ) )
+                char *psz_fontfile;
+                vlc_mutex_lock( &p_sys->fontconfig_lock );
+
+                psz_fontfile = FontConfig_Select( p_sys->p_fontconfig,
+                                                  p_style->psz_fontname,
+                                                  p_style->b_bold,
+                                                  p_style->b_italic,
+                                                  &i_idx );
+                vlc_mutex_unlock( &p_sys->fontconfig_lock );
+
+                if( psz_fontfile && ! *psz_fontfile )
                 {
+                    msg_Warn( p_filter, "Fontconfig was unable to find a font: \"%s\" %s"
+                        " so using default font", p_style->psz_fontname,
+                        ((p_style->b_bold && p_style->b_italic) ? "(Bold,Italic)" :
+                                               (p_style->b_bold ? "(Bold)" :
+                                             (p_style->b_italic ? "(Italic)" : ""))) );
                     free( psz_fontfile );
-                    free( pp_char_styles );
+                    psz_fontfile = NULL;
+                }
+
+                if( psz_fontfile )
+                {
+                    if( FT_New_Face( p_sys->p_library,
+                                psz_fontfile, i_idx, &p_face ) )
+                    {
+                        free( psz_fontfile );
+                        free( pp_char_styles );
 #if defined(HAVE_FRIBIDI)
-                    free( psz_text );
+                        free( psz_text );
 #endif
-                    return VLC_EGENERIC;
+                        free( pi_karaoke_bar );
+                        return VLC_EGENERIC;
+                    }
+                    free( psz_fontfile );
                 }
-                free( psz_fontfile );
+            }
+            if( p_face &&
+                FT_Select_Charmap( p_face, ft_encoding_unicode ) )
+            {
+                /* We've loaded a font face which is unhelpful for actually
+                 * rendering text - fallback to the default one.
+                 */
+                 FT_Done_Face( p_face );
+                 p_face = NULL;
             }
 
             if( FT_Select_Charmap( p_face ? p_face : p_sys->p_face,
@@ -1965,6 +2499,7 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
                 free( psz_text );
 #endif
+                free( pi_karaoke_bar );
                 return VLC_EGENERIC;
             }
             p_sys->i_use_kerning =
@@ -1982,6 +2517,7 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
                 free( psz_text );
 #endif
+                free( pi_karaoke_bar );
                 return VLC_ENOMEM;
             }
             memcpy( psz_unicode, psz_text + i_prev,
@@ -2000,13 +2536,14 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
                         free( psz_text );
 #endif
+                        free( pi_karaoke_bar );
                         return VLC_ENOMEM;
                     }
                     /* New Color mode only works in YUVA rendering mode --
                      * (RGB mode has palette constraints on it). We therefore
                      * need to populate the legacy colour fields also.
                      */
-                    p_line->b_new_color_mode = VLC_TRUE;
+                    p_line->b_new_color_mode = true;
                     p_line->i_alpha = ( p_style->i_font_color & 0xff000000 ) >> 24;
                     p_line->i_red   = ( p_style->i_font_color & 0x00ff0000 ) >> 16;
                     p_line->i_green = ( p_style->i_font_color & 0x0000ff00 ) >>  8;
@@ -2020,8 +2557,10 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
                     if( p_prev ) p_prev->p_next = p_line;
                     else *pp_lines = p_line;
                 }
+
                 if( RenderTag( p_filter, p_face ? p_face : p_sys->p_face,
                                p_style->i_font_color, p_style->b_underline,
+                               p_style->i_karaoke_bg_color,
                                p_line, psz_unicode, &i_pen_x, i_pen_y, &i_posn,
                                &tmp_result ) != VLC_SUCCESS )
                 {
@@ -2031,8 +2570,10 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
                     free( psz_text );
 #endif
+                    free( pi_karaoke_bar );
                     return VLC_EGENERIC;
                 }
+
                 if( *psz_unicode )
                 {
                     p_result->x = __MAX( p_result->x, tmp_result.x );
@@ -2040,6 +2581,16 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 
                     p_prev = p_line;
                     p_line = NULL;
+
+                    if( *psz_unicode == '\n')
+                    {
+                        uint32_t *c_ptr;
+
+                        for( c_ptr = psz_unicode; *c_ptr; c_ptr++ )
+                        {
+                            *c_ptr = *(c_ptr+1);
+                        }
+                    }
                 }
             }
             free( psz_unicode );
@@ -2051,12 +2602,52 @@ static int ProcessLines( filter_t *p_filter, uint32_t *psz_text,
 #if defined(HAVE_FRIBIDI)
     free( psz_text );
 #endif
-
     if( p_line )
     {
         p_result->x = __MAX( p_result->x, tmp_result.x );
         p_result->y += tmp_result.y;
     }
+
+    if( pi_karaoke_bar )
+    {
+        int i = 0;
+        for( p_line = *pp_lines; p_line; p_line=p_line->p_next )
+        {
+            for( k = 0; p_line->pp_glyphs[ k ]; k++, i++ )
+            {
+                if( (pi_karaoke_bar[ i ] & 0x7f) == 0x7f)
+                {
+                    /* do nothing */
+                }
+                else if( (pi_karaoke_bar[ i ] & 0x7f) == 0x00)
+                {
+                    /* 100% BG colour will render faster if we
+                     * instead make it 100% FG colour, so leave
+                     * the ratio alone and copy the value across
+                     */
+                    p_line->p_fg_rgb[ k ] = p_line->p_bg_rgb[ k ];
+                }
+                else
+                {
+                    if( pi_karaoke_bar[ i ] & 0x80 )
+                    {
+                        /* Swap Left and Right sides over for Right aligned
+                         * language text (eg. Arabic, Hebrew)
+                         */
+                        uint32_t i_tmp = p_line->p_fg_rgb[ k ];
+
+                        p_line->p_fg_rgb[ k ] = p_line->p_bg_rgb[ k ];
+                        p_line->p_bg_rgb[ k ] = i_tmp;
+                    }
+                    p_line->p_fg_bg_ratio[ k ] = (pi_karaoke_bar[ i ] & 0x7f);
+                }
+            }
+            /* Jump over the '\n' at the line-end */
+            i++;
+        }
+        free( pi_karaoke_bar );
+    }
+
     return VLC_SUCCESS;
 }
 
@@ -2071,22 +2662,62 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
     if( !p_region_in || !p_region_in->psz_html )
         return VLC_EGENERIC;
 
+    /* Reset the default fontsize in case screen metrics have changed */
+    p_filter->p_sys->i_font_size = GetFontSize( p_filter );
+
     p_sub = stream_MemoryNew( VLC_OBJECT(p_filter),
                               (uint8_t *) p_region_in->psz_html,
                               strlen( p_region_in->psz_html ),
-                              VLC_TRUE );
+                              true );
     if( p_sub )
     {
         p_xml = xml_Create( p_filter );
         if( p_xml )
         {
+            bool b_karaoke = false;
+
             p_xml_reader = xml_ReaderCreate( p_xml, p_sub );
+            if( p_xml_reader )
+            {
+                /* Look for Root Node */
+                if( xml_ReaderRead( p_xml_reader ) == 1 )
+                {
+                    char *psz_node = xml_ReaderName( p_xml_reader );
+
+                    if( !strcasecmp( "karaoke", psz_node ) )
+                    {
+                        /* We're going to have to render the text a number
+                         * of times to show the progress marker on the text.
+                         */
+                        var_SetBool( p_filter, "text-rerender", true );
+                        b_karaoke = true;
+                    }
+                    else if( !strcasecmp( "text", psz_node ) )
+                    {
+                        b_karaoke = false;
+                    }
+                    else
+                    {
+                        /* Only text and karaoke tags are supported */
+                        msg_Dbg( p_filter, "Unsupported top-level tag '%s' ignored.", psz_node );
+                        xml_ReaderDelete( p_xml, p_xml_reader );
+                        p_xml_reader = NULL;
+                        rv = VLC_EGENERIC;
+                    }
+
+                    free( psz_node );
+                }
+            }
+
             if( p_xml_reader )
             {
                 uint32_t   *psz_text;
-                int         i_len;
+                int         i_len = 0;
                 uint32_t    i_runs = 0;
+                uint32_t    i_k_runs = 0;
                 uint32_t   *pi_run_lengths = NULL;
+                uint32_t   *pi_k_run_lengths = NULL;
+                uint32_t   *pi_k_durations = NULL;
                 ft_style_t  **pp_styles = NULL;
                 FT_Vector    result;
                 line_desc_t  *p_lines = NULL;
@@ -2099,15 +2730,19 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
 
                     rv = ProcessNodes( p_filter, p_xml_reader,
                                   p_region_in->p_style, psz_text, &i_len,
-                                  &i_runs, &pi_run_lengths, &pp_styles );
+                                  &i_runs, &pi_run_lengths, &pp_styles,
+                                  b_karaoke, &i_k_runs, &pi_k_run_lengths,
+                                  &pi_k_durations );
 
                     p_region_out->i_x = p_region_in->i_x;
                     p_region_out->i_y = p_region_in->i_y;
 
-                    if( rv == VLC_SUCCESS )
+                    if(( rv == VLC_SUCCESS ) && ( i_len > 0 ))
                     {
                         rv = ProcessLines( p_filter, psz_text, i_len, i_runs,
-                                pi_run_lengths, pp_styles, &p_lines, &result );
+                                pi_run_lengths, pp_styles, &p_lines, &result,
+                                b_karaoke, i_k_runs, pi_k_run_lengths,
+                                pi_k_durations );
                     }
 
                     for( k=0; k<i_runs; k++)
@@ -2119,7 +2754,7 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
                     /* Don't attempt to render text that couldn't be layed out
                      * properly.
                      */
-                    if( rv == VLC_SUCCESS )
+                    if(( rv == VLC_SUCCESS ) && ( i_len > 0 ))
                     {
                         if( config_GetInt( p_filter, "freetype-yuvp" ) )
                         {
@@ -2146,7 +2781,7 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
 }
 
 static char* FontConfig_Select( FcConfig* priv, const char* family,
-                          vlc_bool_t b_bold, vlc_bool_t b_italic, int *i_idx )
+                          bool b_bold, bool b_italic, int *i_idx )
 {
     FcResult result;
     FcPattern *pat, *p_pat;
@@ -2217,7 +2852,9 @@ static void FreeLine( line_desc_t *p_line )
     }
     free( p_line->pp_glyphs );
     free( p_line->p_glyph_pos );
-    free( p_line->p_rgb );
+    free( p_line->p_fg_rgb );
+    free( p_line->p_bg_rgb );
+    free( p_line->p_fg_bg_ratio );
     free( p_line->pi_underline_offset );
     free( p_line->pi_underline_thickness );
     free( p_line );
@@ -2247,60 +2884,73 @@ static line_desc_t *NewLine( int i_count )
 
     p_line->pp_glyphs = malloc( sizeof(FT_BitmapGlyph) * ( i_count + 1 ) );
     p_line->p_glyph_pos = malloc( sizeof( FT_Vector ) * ( i_count + 1 ) );
-    p_line->p_rgb = malloc( sizeof( uint32_t ) * ( i_count + 1 ) );
+    p_line->p_fg_rgb = malloc( sizeof( uint32_t ) * ( i_count + 1 ) );
+    p_line->p_bg_rgb = malloc( sizeof( uint32_t ) * ( i_count + 1 ) );
+    p_line->p_fg_bg_ratio = calloc( i_count + 1, sizeof( uint8_t ) );
     p_line->pi_underline_offset = calloc( i_count + 1, sizeof( uint16_t ) );
     p_line->pi_underline_thickness = calloc( i_count + 1, sizeof( uint16_t ) );
     if( ( p_line->pp_glyphs == NULL ) ||
         ( p_line->p_glyph_pos == NULL ) ||
-        ( p_line->p_rgb == NULL ) ||
+        ( p_line->p_fg_rgb == NULL ) ||
+        ( p_line->p_bg_rgb == NULL ) ||
+        ( p_line->p_fg_bg_ratio == NULL ) ||
         ( p_line->pi_underline_offset == NULL ) ||
         ( p_line->pi_underline_thickness == NULL ) )
     {
-        if( p_line->pi_underline_thickness )
-            free( p_line->pi_underline_thickness );
-        if( p_line->pi_underline_offset ) free( p_line->pi_underline_offset );
-        if( p_line->p_rgb ) free( p_line->p_rgb );
-        if( p_line->p_glyph_pos ) free( p_line->p_glyph_pos );
-        if( p_line->pp_glyphs ) free( p_line->pp_glyphs );
+        free( p_line->pi_underline_thickness );
+        free( p_line->pi_underline_offset );
+        free( p_line->p_fg_rgb );
+        free( p_line->p_bg_rgb );
+        free( p_line->p_fg_bg_ratio );
+        free( p_line->p_glyph_pos );
+        free( p_line->pp_glyphs );
         free( p_line );
         return NULL;
     }
     p_line->pp_glyphs[0] = NULL;
-    p_line->b_new_color_mode = VLC_FALSE;
+    p_line->b_new_color_mode = false;
 
     return p_line;
 }
 
-static int SetFontSize( filter_t *p_filter, int i_size )
+static int GetFontSize( filter_t *p_filter )
 {
     filter_sys_t *p_sys = p_filter->p_sys;
+    vlc_value_t   val;
+    int           i_size = 0;
 
-    if( i_size && i_size == p_sys->i_font_size ) return VLC_SUCCESS;
-
-    if( !i_size )
+    if( p_sys->i_default_font_size )
     {
-        vlc_value_t val;
-
-        if( !p_sys->i_default_font_size &&
-            p_sys->i_display_height == (int)p_filter->fmt_out.video.i_height )
-            return VLC_SUCCESS;
-
-        if( p_sys->i_default_font_size )
-        {
+        if( VLC_SUCCESS == var_Get( p_filter, "scale", &val ))
+            i_size = p_sys->i_default_font_size * val.i_int / 1000;
+        else
             i_size = p_sys->i_default_font_size;
-        }
+    }
+    else
+    {
+        var_Get( p_filter, "freetype-rel-fontsize", &val );
+        i_size = (int)p_filter->fmt_out.video.i_height / val.i_int;
+        p_filter->p_sys->i_display_height =
+            p_filter->fmt_out.video.i_height;
+    }
+    if( i_size <= 0 )
+    {
+        msg_Warn( p_filter, "invalid fontsize, using 12" );
+        if( VLC_SUCCESS == var_Get( p_filter, "scale", &val ))
+            i_size = 12 * val.i_int / 1000;
         else
-        {
-            var_Get( p_filter, "freetype-rel-fontsize", &val );
-            i_size = (int)p_filter->fmt_out.video.i_height / val.i_int;
-            p_filter->p_sys->i_display_height =
-                p_filter->fmt_out.video.i_height;
-        }
-        if( i_size <= 0 )
-        {
-            msg_Warn( p_filter, "invalid fontsize, using 12" );
             i_size = 12;
-        }
+    }
+    return i_size;
+}
+
+static int SetFontSize( filter_t *p_filter, int i_size )
+{
+    filter_sys_t *p_sys = p_filter->p_sys;
+
+    if( !i_size )
+    {
+        i_size = GetFontSize( p_filter );
 
         msg_Dbg( p_filter, "using fontsize: %i", i_size );
     }
@@ -2315,3 +2965,18 @@ static int SetFontSize( filter_t *p_filter, int i_size )
 
     return VLC_SUCCESS;
 }
+
+static void YUVFromRGB( uint32_t i_argb,
+                    uint8_t *pi_y, uint8_t *pi_u, uint8_t *pi_v )
+{
+    int i_red   = ( i_argb & 0x00ff0000 ) >> 16;
+    int i_green = ( i_argb & 0x0000ff00 ) >>  8;
+    int i_blue  = ( i_argb & 0x000000ff );
+
+    *pi_y = (uint8_t)__MIN(abs( 2104 * i_red  + 4130 * i_green +
+                      802 * i_blue + 4096 + 131072 ) >> 13, 235);
+    *pi_u = (uint8_t)__MIN(abs( -1214 * i_red  + -2384 * i_green +
+                     3598 * i_blue + 4096 + 1048576) >> 13, 240);
+    *pi_v = (uint8_t)__MIN(abs( 3598 * i_red + -3013 * i_green +
+                      -585 * i_blue + 4096 + 1048576) >> 13, 240);
+}