/*****************************************************************************
* Includes
*****************************************************************************/
-#define _GNU_SOURCE
-#include <stdlib.h> /* malloc(), free() */
-#include <vlc/vlc.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
+#include <vlc_plugin.h>
#include <vlc_playlist.h>
+#include <vlc_arrays.h>
#include <avahi-client/client.h>
#ifdef HAVE_AVAHI_06
vlc_module_begin();
set_shortname( "Bonjour" );
- set_description( _("Bonjour services") );
+ set_description( N_("Bonjour services") );
set_category( CAT_PLAYLIST );
set_subcategory( SUBCAT_PLAYLIST_SD );
set_capability( "services_discovery", 0 );
struct services_discovery_sys_t
{
- /* playlist node */
- playlist_item_t *p_node_cat, *p_node_one;
- playlist_t *p_playlist;
-
AvahiSimplePoll *simple_poll;
AvahiClient *client;
AvahiServiceBrowser *sb;
+ vlc_dictionary_t services_name_to_input_item;
};
/*****************************************************************************
{
services_discovery_t *p_sd = ( services_discovery_t* )userdata;
services_discovery_sys_t *p_sys = p_sd->p_sys;
+
+ VLC_UNUSED(interface); VLC_UNUSED(host_name);
+#ifdef HAVE_AVAHI_06
+ VLC_UNUSED(flags);
+#endif
#ifdef HAVE_AVAHI_06
if( event == AVAHI_RESOLVER_FAILURE )
avahi_address_snprint(a, (sizeof(a)/sizeof(a[0]))-1, address);
if( protocol == AVAHI_PROTO_INET6 )
- asprintf( &psz_addr, "[%s]", a );
+ if( asprintf( &psz_addr, "[%s]", a ) == -1 )
+ return;
if( txt != NULL )
asl = avahi_string_list_find( txt, "path" );
if( avahi_string_list_get_pair( asl, &key, &value, &size ) == 0 &&
value != NULL )
{
- asprintf( &psz_uri, "http://%s:%d%s",
- psz_addr != NULL ? psz_addr : a, port, value );
+ if( asprintf( &psz_uri, "http://%s:%d%s",
+ psz_addr != NULL ? psz_addr : a, port, value ) == -1 )
+ {
+ free( psz_addr );
+ return;
+ }
}
if( key != NULL )
avahi_free( (void *)key );
}
else
{
- asprintf( &psz_uri, "http://%s:%d",
- psz_addr != NULL ? psz_addr : a, port );
+ if( asprintf( &psz_uri, "http://%s:%d",
+ psz_addr != NULL ? psz_addr : a, port ) == -1 )
+ {
+ free( psz_addr );
+ return;
+ }
}
if( psz_addr != NULL )
}
if( p_input != NULL )
{
- playlist_item_t *p_item;
- p_item = playlist_NodeAddInput( p_sys->p_playlist, p_input,
- p_sys->p_node_cat,
- PLAYLIST_APPEND, PLAYLIST_END,
- VLC_FALSE);
- p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
- p_item->i_flags &= ~PLAYLIST_SAVE_FLAG;
- p_item = playlist_NodeAddInput( p_sys->p_playlist, p_input,
- p_sys->p_node_one,
- PLAYLIST_APPEND, PLAYLIST_END,
- VLC_FALSE );
- p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
- p_item->i_flags &= ~PLAYLIST_SAVE_FLAG;
+ vlc_dictionary_insert( &p_sys->services_name_to_input_item,
+ name, p_input );
+ services_discovery_AddItem( p_sd, p_input, NULL /* no category */ );
+ vlc_gc_decref( p_input );
}
}
#endif
void* userdata )
{
+ VLC_UNUSED(b);
+#ifdef HAVE_AVAHI_06
+ VLC_UNUSED(flags);
+#endif
services_discovery_t *p_sd = ( services_discovery_t* )userdata;
services_discovery_sys_t *p_sys = p_sd->p_sys;
-
if( event == AVAHI_BROWSER_NEW )
{
if( avahi_service_resolver_new( p_sys->client, interface, protocol,
avahi_strerror( avahi_client_errno( p_sys->client ) ) );
}
}
- else
+ else if( name )
{
/** \todo Store the input id and search it, rather than searching the items */
- playlist_item_t *p_item;
- p_item = playlist_ChildSearchName( p_sys->p_node_cat, name );
- if( p_item == NULL )
+ input_item_t *p_item;
+ p_item = vlc_dictionary_value_for_key(
+ &p_sys->services_name_to_input_item,
+ name );
+ if( !p_item )
msg_Err( p_sd, "failed to find service '%s' in playlist", name );
else
{
- playlist_DeleteFromInput( p_sys->p_playlist, p_item->p_input->i_id,
- VLC_FALSE );
+ services_discovery_RemoveItem( p_sd, p_item );
+ vlc_dictionary_remove_value_for_key(
+ &p_sys->services_name_to_input_item,
+ name );
}
}
}
p_sd->p_sys = p_sys = (services_discovery_sys_t *)malloc(
sizeof( services_discovery_sys_t ) );
- if( p_sd->p_sys == NULL )
- {
- msg_Err( p_sd, "out of memory" );
- return VLC_EGENERIC;
- }
+
+ if( !p_sys )
+ return VLC_ENOMEM;
memset( p_sys, 0, sizeof(*p_sys) );
+ vlc_dictionary_init( &p_sys->services_name_to_input_item, 1 );
+
p_sys->simple_poll = avahi_simple_poll_new();
if( p_sys->simple_poll == NULL )
{
goto error;
}
- /* Create our playlist node */
- p_sys->p_playlist = (playlist_t *)vlc_object_find( p_sd,
- VLC_OBJECT_PLAYLIST,
- FIND_ANYWHERE );
- if( !p_sys->p_playlist )
- {
- msg_Warn( p_sd, "unable to find playlist, cancelling");
- goto error;
- }
-
- p_sys->p_node_cat = playlist_NodeCreate( p_sys->p_playlist, _("Bonjour"),
- p_sys->p_playlist->p_root_category, 0 );
- p_sys->p_node_one = playlist_NodeCreate( p_sys->p_playlist, _("Bonjour"),
- p_sys->p_playlist->p_root_onelevel, 0 );
- p_sys->p_node_one->p_input->i_id = p_sys->p_node_cat->p_input->i_id;
-
- p_sys->p_node_one->i_flags |= PLAYLIST_RO_FLAG;
- p_sys->p_node_cat->i_flags |= PLAYLIST_RO_FLAG;
- p_sys->p_node_one->i_flags |= PLAYLIST_SKIP_FLAG;
- p_sys->p_node_cat->i_flags |= PLAYLIST_SKIP_FLAG;
+ services_discovery_SetLocalizedName( p_sd, _("Bonjour") );
p_sd->pf_run = Run;
return VLC_SUCCESS;
error:
- if( p_sys->p_playlist != NULL )
- vlc_object_release( p_sys->p_playlist );
if( p_sys->sb != NULL )
avahi_service_browser_free( p_sys->sb );
if( p_sys->client != NULL )
if( p_sys->simple_poll != NULL )
avahi_simple_poll_free( p_sys->simple_poll );
- free( (void *)p_sys );
+ vlc_dictionary_clear( &p_sys->services_name_to_input_item );
+ free( p_sys );
return VLC_EGENERIC;
}
avahi_client_free( p_sys->client );
avahi_simple_poll_free( p_sys->simple_poll );
- playlist_NodeDelete( p_sys->p_playlist, p_sys->p_node_one, VLC_TRUE, VLC_TRUE );
- playlist_NodeDelete( p_sys->p_playlist, p_sys->p_node_cat, VLC_TRUE, VLC_TRUE );
- vlc_object_release( p_sys->p_playlist );
-
+ vlc_dictionary_clear( &p_sys->services_name_to_input_item );
free( p_sys );
}
{
services_discovery_sys_t *p_sys = p_sd->p_sys;
- while( !p_sd->b_die )
+ while( vlc_object_alive (p_sd) )
{
if( avahi_simple_poll_iterate( p_sys->simple_poll, 100 ) != 0 )
{