]> git.sesse.net Git - vlc/blobdiff - modules/services_discovery/hal.c
Use gettext_noop() consistently
[vlc] / modules / services_discovery / hal.c
index 1657089c25994ce9fbb0d011241191f5cd6faee7..27f0a3136dc58869d98d4773fea240cff2405180 100644 (file)
@@ -2,7 +2,7 @@
  * hal.c :  HAL interface module
  *****************************************************************************
  * Copyright (C) 2004 the VideoLAN team
- * Copyright (C) 2006 Rafaël Carré
+ * Copyright © 2006-2007 Rafaël Carré
  * $Id$
  *
  * Authors: Clément Stenac <zorglub@videolan.org>
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
-#include <vlc/vlc.h>
-#include <vlc/intf.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
 
-#include <vlc/input.h>
+#include <vlc/vlc.h>
+#include <vlc_plugin.h>
+#include <vlc_playlist.h>
 
-#include "network.h"
+#include <vlc_network.h>
 
 #include <errno.h>                                                 /* ENOMEM */
 
 /* store relation between item id and udi for ejection */
 struct udi_input_id_t
 {
-    char    *psz_udi;
-    int     i_id;
+    char            *psz_udi;
+    input_item_t    *p_item;
 };
 #endif
 
 struct services_discovery_sys_t
 {
     LibHalContext           *p_ctx;
-    playlist_item_t         *p_node_cat;
-    playlist_item_t         *p_node_one;
 #ifdef HAVE_HAL_1
     DBusConnection          *p_connection;
     int                     i_devices_number;
@@ -83,7 +84,7 @@ services_discovery_t        *p_sd_global;
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
-    set_description( _("HAL devices detection") );
+    set_description( N_("HAL devices detection") );
     set_category( CAT_PLAYLIST );
     set_subcategory( SUBCAT_PLAYLIST_SD );
 
@@ -101,8 +102,8 @@ static int Open( vlc_object_t *p_this )
     services_discovery_t *p_sd = ( services_discovery_t* )p_this;
     services_discovery_sys_t *p_sys  = malloc(
                                     sizeof( services_discovery_sys_t ) );
-
-    playlist_t          *p_playlist;
+    if( !p_sys )
+        return VLC_ENOMEM;
 
 #ifdef HAVE_HAL_1
     DBusError           dbus_error;
@@ -162,19 +163,7 @@ static int Open( vlc_object_t *p_this )
         }
 #endif
 
-    /* Create our playlist node */
-    p_playlist = (playlist_t *)vlc_object_find( p_sd, VLC_OBJECT_PLAYLIST,
-                                                FIND_ANYWHERE );
-    if( !p_playlist )
-    {
-        msg_Warn( p_sd, "unable to find playlist, cancelling HAL listening");
-        return VLC_EGENERIC;
-    }
-
-    playlist_NodesPairCreate( p_playlist, _("Devices"),
-                              &p_sys->p_node_cat, &p_sys->p_node_one,
-                              VLC_TRUE );
-    vlc_object_release( p_playlist );
+    services_discovery_SetLocalizedName( p_sd, _("Devices") );
 
     return VLC_SUCCESS;
 }
@@ -186,68 +175,51 @@ static void Close( vlc_object_t *p_this )
 {
     services_discovery_t *p_sd = ( services_discovery_t* )p_this;
     services_discovery_sys_t *p_sys  = p_sd->p_sys;
-    playlist_t *p_playlist =  (playlist_t *) vlc_object_find( p_sd,
-                                 VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
-    if( p_playlist )
-    {
-        playlist_NodeDelete( p_playlist, p_sys->p_node_cat, VLC_TRUE,VLC_TRUE );
-        playlist_NodeDelete( p_playlist, p_sys->p_node_one, VLC_TRUE,VLC_TRUE );
-        vlc_object_release( p_playlist );
-    }
-    free( p_sys );
 #ifdef HAVE_HAL_1
+    dbus_connection_unref( p_sys->p_connection );
     struct udi_input_id_t *p_udi_entry;
 
     while( p_sys->i_devices_number > 0 )
     {
         p_udi_entry = p_sys->pp_devices[0];
-        if( p_udi_entry->psz_udi ) free( p_udi_entry->psz_udi );
+        free( p_udi_entry->psz_udi );
         TAB_REMOVE( p_sys->i_devices_number, p_sys->pp_devices,
                 p_sys->pp_devices[0] );
-        if( p_udi_entry ) free( p_udi_entry );
+        free( p_udi_entry );
     }
     p_sys->pp_devices = NULL;
 #endif
+    free( p_sys );
 }
 
 static void AddItem( services_discovery_t *p_sd, input_item_t * p_input
 #ifdef HAVE_HAL_1
-                ,char* psz_device
+                , const char* psz_device
 #endif
                     )
 {
-    playlist_item_t *p_item;
     services_discovery_sys_t *p_sys  = p_sd->p_sys;
-    playlist_t *p_playlist = (playlist_t *)vlc_object_find( p_sd,
-                                        VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
-    if( !p_playlist )
-    {
-        msg_Err( p_sd, "playlist not found" );
-        return;
-    }
-    p_item = playlist_NodeAddInput( p_playlist, p_input,p_sd->p_sys->p_node_cat,
-                                    PLAYLIST_APPEND, PLAYLIST_END );
-    p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
-    p_item = playlist_NodeAddInput( p_playlist, p_input,p_sd->p_sys->p_node_one,
-                                    PLAYLIST_APPEND, PLAYLIST_END );
-    p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
-
-    vlc_object_release( p_playlist );
+    services_discovery_AddItem( p_sd, p_input, NULL /* no category */ );
 
 #ifdef HAVE_HAL_1
     struct udi_input_id_t *p_udi_entry;
     p_udi_entry = malloc( sizeof( struct udi_input_id_t ) );
     if( !p_udi_entry )
+        return;
+    p_udi_entry->psz_udi = strdup( psz_device );
+    if( !p_udi_entry->psz_udi )
     {
+        free( p_udi_entry );
         return;
     }
-    p_udi_entry->i_id = p_item->i_id;
-    p_udi_entry->psz_udi = strdup( psz_device );
+
+    vlc_gc_incref( p_input );
+    p_udi_entry->p_item = p_input;
     TAB_APPEND( p_sys->i_devices_number, p_sys->pp_devices, p_udi_entry );
 #endif
 }
 
-static void AddDvd( services_discovery_t *p_sd, char *psz_device )
+static void AddDvd( services_discovery_t *p_sd, const char *psz_device )
 {
     char *psz_name;
     char *psz_uri;
@@ -264,7 +236,8 @@ static void AddDvd( services_discovery_t *p_sd, char *psz_device )
     psz_blockdevice = hal_device_get_property_string( p_sd->p_sys->p_ctx,
                                                  psz_device, "block.device" );
 #endif
-    asprintf( &psz_uri, "dvd://%s", psz_blockdevice );
+    if( asprintf( &psz_uri, "dvd://%s", psz_blockdevice ) == -1 )
+        return;
     /* Create the playlist item here */
     p_input = input_ItemNew( p_sd, psz_uri, psz_name );
     free( psz_uri );
@@ -277,37 +250,30 @@ static void AddDvd( services_discovery_t *p_sd, char *psz_device )
 #else
     AddItem( p_sd, p_input );
 #endif
+    vlc_gc_decref( p_input );
 }
 
 #ifdef HAVE_HAL_1
-static void DelItem( services_discovery_t *p_sd, char* psz_udi )
+static void DelItem( services_discovery_t *p_sd, const char* psz_udi )
 {
     services_discovery_sys_t    *p_sys  = p_sd->p_sys;
-    int                         i;
-
-    playlist_t *p_playlist = (playlist_t *)vlc_object_find( p_sd,
-                                        VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
-    if( !p_playlist )
-    {
-        msg_Err( p_sd, "playlist not found" );
-        return;
-    }
 
+    int i;
     for( i = 0; i < p_sys->i_devices_number; i++ )
-    {
+    { /*  looks for a matching udi */
         if( strcmp( psz_udi, p_sys->pp_devices[i]->psz_udi ) == 0 )
-        {
-            playlist_DeleteFromItemId( p_playlist, p_sys->pp_devices[i]->i_id );
+        { /* delete the corresponding item */    
+            services_discovery_RemoveItem( p_sd, p_sys->pp_devices[i]->p_item );
+            vlc_gc_decref( p_sys->pp_devices[i]->p_item );
+            free( p_sys->pp_devices[i]->psz_udi );
             TAB_REMOVE( p_sys->i_devices_number, p_sys->pp_devices,
                     p_sys->pp_devices[i] );
         }
     }
-
-    vlc_object_release( p_playlist );
 }
 #endif
 
-static void AddCdda( services_discovery_t *p_sd, char *psz_device )
+static void AddCdda( services_discovery_t *p_sd, const char *psz_device )
 {
     char *psz_uri;
     char *psz_blockdevice;
@@ -319,8 +285,9 @@ static void AddCdda( services_discovery_t *p_sd, char *psz_device )
     psz_blockdevice = hal_device_get_property_string( p_sd->p_sys->p_ctx,
                                                  psz_device, "block.device" );
 #endif
-    asprintf( &psz_uri, "cdda://%s", psz_blockdevice );
-    /* Create the playlist item here */
+    if( asprintf( &psz_uri, "cdda://%s", psz_blockdevice ) == -1 )
+        return;
+    /* Create the item here */
     p_input = input_ItemNew( p_sd, psz_uri, "Audio CD" );
     free( psz_uri );
     if( !p_input )
@@ -330,9 +297,10 @@ static void AddCdda( services_discovery_t *p_sd, char *psz_device )
 #else
     AddItem( p_sd, p_input );
 #endif
+    vlc_gc_decref( p_input );
 }
 
-static void ParseDevice( services_discovery_t *p_sd, char *psz_device )
+static void ParseDevice( services_discovery_t *p_sd, const char *psz_device )
 {
     char *psz_disc_type;
     services_discovery_sys_t    *p_sys  = p_sd->p_sys;
@@ -352,7 +320,7 @@ static void ParseDevice( services_discovery_t *p_sd, char *psz_device )
                                                         psz_device,
                                                         "volume.disc.type" );
 #endif
-        if( !strcmp( psz_disc_type, "dvd_rom" ) )
+        if( !strncmp( psz_disc_type, "dvd_r", 5 ) )
         {
 #ifdef HAVE_HAL_1
             /* hal 0.2.9.7 (HAVE_HAL) has not is_videodvd
@@ -362,7 +330,7 @@ static void ParseDevice( services_discovery_t *p_sd, char *psz_device )
 #endif
             AddDvd( p_sd, psz_device );
         }
-        else if( !strcmp( psz_disc_type, "cd_rom" ) )
+        else if( !strncmp( psz_disc_type, "cd_r", 4 ) )
         {
 #ifdef HAVE_HAL_1
             if( libhal_device_get_property_bool( p_sys->p_ctx, psz_device,
@@ -419,11 +387,13 @@ static void Run( services_discovery_t *p_sd )
 #ifdef HAVE_HAL_1
 void DeviceAdded( LibHalContext *p_ctx, const char *psz_udi )
 {
-        ParseDevice( p_sd_global, (char*) psz_udi );
+    VLC_UNUSED(p_ctx);
+    ParseDevice( p_sd_global, psz_udi );
 }
 void DeviceRemoved( LibHalContext *p_ctx, const char *psz_udi )
 {
-        DelItem( p_sd_global, (char*) psz_udi );
+    VLC_UNUSED(p_ctx);
+    DelItem( p_sd_global, psz_udi );
 }
 #endif