]> git.sesse.net Git - vlc/blobdiff - modules/stream_out/transcode.c
Added RGBA and YUVA support (it will enhance subtitle scaling).
[vlc] / modules / stream_out / transcode.c
index ae717d996019793c8d325b3f31c24b7b5c258c37..eceda3bd81e10c9df0a1be2ddbbd03aa867534f1 100644 (file)
@@ -7,6 +7,7 @@
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *          Gildas Bazin <gbazin@videolan.org>
  *          Jean-Paul Saman <jpsaman #_at_# m2x dot nl>
+ *          Antoine Cellerier <dionoea at videolan dot org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -261,6 +262,7 @@ static void audio_del_buffer( decoder_t *, aout_buffer_t * );
 
 static int  transcode_video_new    ( sout_stream_t *, sout_stream_id_t * );
 static void transcode_video_close  ( sout_stream_t *, sout_stream_id_t * );
+static void transcode_video_encoder_init( sout_stream_t *, sout_stream_id_t *);
 static int  transcode_video_encoder_open( sout_stream_t *, sout_stream_id_t *);
 static int  transcode_video_process( sout_stream_t *, sout_stream_id_t *,
                                      block_t *, block_t ** );
@@ -298,7 +300,6 @@ static int pi_channels_maps[6] =
 
 #define PICTURE_RING_SIZE 64
 #define SUBPICTURE_RING_SIZE 20
-#define TRANSCODE_FILTERS 10
 
 #define ENC_FRAMERATE (25 * 1000 + .5)
 #define ENC_FRAMERATE_BASE 1000
@@ -322,9 +323,8 @@ struct sout_stream_sys_t
     uint32_t        i_sample_rate;
     uint32_t        i_channels;
     int             i_abitrate;
-    char            *psz_afilters[TRANSCODE_FILTERS];
-    config_chain_t  *p_afilters_cfg[TRANSCODE_FILTERS];
-    int             i_afilters;
+
+    char            *psz_af2;
 
     /* Video */
     vlc_fourcc_t    i_vcodec;   /* codec video (0 if not transcode) */
@@ -335,20 +335,19 @@ struct sout_stream_sys_t
     double          f_fps;
     unsigned int    i_width, i_maxwidth;
     unsigned int    i_height, i_maxheight;
-    bool      b_deinterlace;
+    bool            b_deinterlace;
     char            *psz_deinterlace;
     config_chain_t  *p_deinterlace_cfg;
     int             i_threads;
-    bool      b_high_priority;
-    bool      b_hurry_up;
-    char            *psz_vfilters[TRANSCODE_FILTERS];
-    config_chain_t  *p_vfilters_cfg[TRANSCODE_FILTERS];
-    int             i_vfilters;
+    bool            b_high_priority;
+    bool            b_hurry_up;
+
+    char            *psz_vf2;
 
     /* SPU */
     vlc_fourcc_t    i_scodec;   /* codec spu (0 if not transcode) */
     char            *psz_senc;
-    bool      b_soverlay;
+    bool            b_soverlay;
     config_chain_t  *p_spu_cfg;
     spu_t           *p_spu;
 
@@ -356,10 +355,10 @@ struct sout_stream_sys_t
     vlc_fourcc_t    i_osdcodec; /* codec osd menu (0 if not transcode) */
     char            *psz_osdenc;
     config_chain_t  *p_osd_cfg;
-    bool      b_osd;   /* true when osd es is registered */
+    bool            b_osd;   /* true when osd es is registered */
 
     /* Sync */
-    bool      b_master_sync;
+    bool            b_master_sync;
     mtime_t         i_master_drift;
 };
 
@@ -446,27 +445,12 @@ static int Open( vlc_object_t *p_this )
     }
 
     var_Get( p_stream, SOUT_CFG_PREFIX "afilter", &val );
-    p_sys->i_afilters = 0;
     if( val.psz_string && *val.psz_string )
+        p_sys->psz_af2 = val.psz_string;
+    else
     {
-        char *psz_parser = val.psz_string;
-
-        while( (psz_parser != NULL) && (*psz_parser != '\0')
-                && (p_sys->i_afilters < TRANSCODE_FILTERS) )
-        {
-            psz_parser = config_ChainCreate(
-                                   &p_sys->psz_afilters[p_sys->i_afilters],
-                                   &p_sys->p_afilters_cfg[p_sys->i_afilters],
-                                   psz_parser );
-            p_sys->i_afilters++;
-            if( (psz_parser != NULL) && (*psz_parser != '\0') ) psz_parser++;
-        }
-    }
-    free( val.psz_string );
-    if( p_sys->i_afilters < TRANSCODE_FILTERS-1 )
-    {
-        p_sys->psz_afilters[p_sys->i_afilters] = NULL;
-        p_sys->p_afilters_cfg[p_sys->i_afilters] = NULL;
+        free( val.psz_string );
+        p_sys->psz_af2 = NULL;
     }
 
     /* Video transcoding parameters */
@@ -518,27 +502,12 @@ static int Open( vlc_object_t *p_this )
     p_sys->i_maxheight = val.i_int;
 
     var_Get( p_stream, SOUT_CFG_PREFIX "vfilter", &val );
-    p_sys->i_vfilters = 0;
     if( val.psz_string && *val.psz_string )
+        p_sys->psz_vf2 = val.psz_string;
+    else
     {
-        char *psz_parser = val.psz_string;
-
-        while( (psz_parser != NULL) && (*psz_parser != '\0')
-                && (p_sys->i_vfilters < TRANSCODE_FILTERS) )
-        {
-            psz_parser = config_ChainCreate(
-                                   &p_sys->psz_vfilters[p_sys->i_vfilters],
-                                   &p_sys->p_vfilters_cfg[p_sys->i_vfilters],
-                                   psz_parser );
-            p_sys->i_vfilters++;
-            if( psz_parser != NULL && *psz_parser != '\0' ) psz_parser++;
-        }
-    }
-    free( val.psz_string );
-    if( p_sys->i_vfilters < TRANSCODE_FILTERS-1 )
-    {
-        p_sys->psz_vfilters[p_sys->i_vfilters] = NULL;
-        p_sys->p_vfilters_cfg[p_sys->i_vfilters] = NULL;
+        free( val.psz_string );
+        p_sys->psz_vf2 = NULL;
     }
 
     var_Get( p_stream, SOUT_CFG_PREFIX "deinterlace", &val );
@@ -672,12 +641,7 @@ static void Close( vlc_object_t * p_this )
 
     sout_StreamDelete( p_sys->p_out );
 
-    while( p_sys->i_afilters )
-    {
-        p_sys->i_afilters--;
-        free( p_sys->psz_afilters[p_sys->i_afilters] );
-        free( p_sys->p_afilters_cfg[p_sys->i_afilters] );
-    }
+    free( p_sys->psz_af2 );
 
     while( p_sys->p_audio_cfg != NULL )
     {
@@ -691,12 +655,7 @@ static void Close( vlc_object_t * p_this )
     }
     free( p_sys->psz_aenc );
 
-    while( p_sys->i_vfilters )
-    {
-        p_sys->i_vfilters--;
-        free( p_sys->psz_vfilters[p_sys->i_vfilters] );
-        free( p_sys->p_vfilters_cfg[p_sys->i_vfilters] );
-    }
+    free( p_sys->psz_vf2 );
 
     while( p_sys->p_video_cfg != NULL )
     {
@@ -762,11 +721,9 @@ struct sout_stream_id_t
     decoder_t       *p_decoder;
 
     /* Filters */
-    filter_t        *pp_filter[TRANSCODE_FILTERS];
-    int             i_filter;
+    filter_chain_t  *p_f_chain;
     /* User specified filters */
-    filter_t        *pp_ufilter[TRANSCODE_FILTERS];
-    int             i_ufilter;
+    filter_chain_t  *p_uf_chain;
 
     /* Encoder */
     encoder_t       *p_encoder;
@@ -782,10 +739,7 @@ static sout_stream_id_t *Add( sout_stream_t *p_stream, es_format_t *p_fmt )
 
     id = malloc( sizeof( sout_stream_id_t ) );
     if( !id )
-    {
-        msg_Err( p_stream, "out of memory" );
         goto error;
-    }
     memset( id, 0, sizeof(sout_stream_id_t) );
 
     id->id = NULL;
@@ -795,10 +749,7 @@ static sout_stream_id_t *Add( sout_stream_t *p_stream, es_format_t *p_fmt )
     /* Create decoder object */
     id->p_decoder = vlc_object_create( p_stream, VLC_OBJECT_DECODER );
     if( !id->p_decoder )
-    {
-        msg_Err( p_stream, "out of memory" );
         goto error;
-    }
     vlc_object_attach( id->p_decoder, p_stream );
     id->p_decoder->p_module = NULL;
     id->p_decoder->fmt_in = *p_fmt;
@@ -807,10 +758,7 @@ static sout_stream_id_t *Add( sout_stream_t *p_stream, es_format_t *p_fmt )
     /* Create encoder object */
     id->p_encoder = vlc_object_create( p_stream, VLC_OBJECT_ENCODER );
     if( !id->p_encoder )
-    {
-        msg_Err( p_stream, "out of memory" );
         goto error;
-    }
     vlc_object_attach( id->p_encoder, p_stream );
     id->p_encoder->p_module = NULL;
 
@@ -974,23 +922,26 @@ static sout_stream_id_t *Add( sout_stream_t *p_stream, es_format_t *p_fmt )
 
     return id;
 
- error:
-    if( id->p_decoder )
+error:
+    if( id )
     {
-        vlc_object_detach( id->p_decoder );
-        vlc_object_release( id->p_decoder );
-        id->p_decoder = NULL;
-    }
+        if( id->p_decoder )
+        {
+            vlc_object_detach( id->p_decoder );
+            vlc_object_release( id->p_decoder );
+            id->p_decoder = NULL;
+        }
 
-    if( id->p_encoder )
-    {
-        vlc_object_detach( id->p_encoder );
-        es_format_Clean( &id->p_encoder->fmt_out );
-        vlc_object_release( id->p_encoder );
-        id->p_encoder = NULL;
-    }
+        if( id->p_encoder )
+        {
+            vlc_object_detach( id->p_encoder );
+            es_format_Clean( &id->p_encoder->fmt_out );
+            vlc_object_release( id->p_encoder );
+            id->p_encoder = NULL;
+        }
 
-    free( id );
+        free( id );
+    }
     return NULL;
 }
 
@@ -1136,79 +1087,18 @@ static inline void audio_timer_close( encoder_t * p_encoder )
  * decoder reencoder part
  ****************************************************************************/
 
-static int audio_BitsPerSample( vlc_fourcc_t i_format )
-{
-    switch( i_format )
-    {
-    case VLC_FOURCC('u','8',' ',' '):
-    case VLC_FOURCC('s','8',' ',' '):
-        return 8;
-
-    case VLC_FOURCC('u','1','6','l'):
-    case VLC_FOURCC('s','1','6','l'):
-    case VLC_FOURCC('u','1','6','b'):
-    case VLC_FOURCC('s','1','6','b'):
-        return 16;
-
-    case VLC_FOURCC('u','2','4','l'):
-    case VLC_FOURCC('s','2','4','l'):
-    case VLC_FOURCC('u','2','4','b'):
-    case VLC_FOURCC('s','2','4','b'):
-        return 24;
-
-    case VLC_FOURCC('u','3','2','l'):
-    case VLC_FOURCC('s','3','2','l'):
-    case VLC_FOURCC('u','3','2','b'):
-    case VLC_FOURCC('s','3','2','b'):
-    case VLC_FOURCC('f','l','3','2'):
-    case VLC_FOURCC('f','i','3','2'):
-        return 32;
-
-    case VLC_FOURCC('f','l','6','4'):
-        return 64;
-    }
-
-    return 0;
-}
-
-static block_t *transcode_audio_alloc (filter_t *filter, int size)
+static block_t *transcode_audio_alloc( filter_t *p_filter, int size )
 {
-    return block_New (filter, size);
+    VLC_UNUSED( p_filter );
+    return block_Alloc( size );
 }
 
-static filter_t *transcode_audio_filter_new( sout_stream_t *p_stream,
-                                             sout_stream_id_t *id,
-                                             es_format_t *p_fmt_in,
-                                             es_format_t *p_fmt_out,
-                                             char *psz_name )
+static int transcode_audio_filter_allocation_init( filter_t *p_filter,
+                                                   void *data )
 {
-    sout_stream_sys_t *p_sys = p_stream->p_sys;
-    filter_t *p_filter = vlc_object_create( p_stream, VLC_OBJECT_FILTER );
-
-    vlc_object_attach( p_filter, p_stream );
+    VLC_UNUSED(data);
     p_filter->pf_audio_buffer_new = transcode_audio_alloc;
-
-    p_filter->fmt_in = *p_fmt_in;
-    p_filter->fmt_out = *p_fmt_out;
-    if( psz_name )
-        p_filter->p_cfg = p_sys->p_afilters_cfg[id->i_ufilter];
-
-    p_filter->p_module = module_Need( p_filter, "audio filter2", psz_name,
-                                      true );
-    if( p_filter->p_module )
-    {
-        p_filter->fmt_out.audio.i_bitspersample =
-            audio_BitsPerSample( p_filter->fmt_out.i_codec );
-        *p_fmt_in = p_filter->fmt_out;
-    }
-    else
-    {
-        vlc_object_detach( p_filter );
-        vlc_object_release( p_filter );
-        p_filter = 0;
-    }
-
-    return p_filter;
+    return VLC_SUCCESS;
 }
 
 static int transcode_audio_new( sout_stream_t *p_stream,
@@ -1239,7 +1129,7 @@ static int transcode_audio_new( sout_stream_t *p_stream,
         return VLC_EGENERIC;
     }
     id->p_decoder->fmt_out.audio.i_bitspersample =
-        audio_BitsPerSample( id->p_decoder->fmt_out.i_codec );
+        aout_BitsPerSample( id->p_decoder->fmt_out.i_codec );
     fmt_last = id->p_decoder->fmt_out;
     /* Fix AAC SBR changing number of channels and sampling rate */
     if( !(id->p_decoder->fmt_in.i_codec == VLC_FOURCC('m','p','4','a') &&
@@ -1256,11 +1146,7 @@ static int transcode_audio_new( sout_stream_t *p_stream,
                     id->p_decoder->fmt_out.i_codec );
     id->p_encoder->fmt_in.audio.i_format = id->p_decoder->fmt_out.i_codec;
 
-    if( ( id->p_encoder->fmt_out.i_codec == VLC_FOURCC('s','a','m','r') ) ||
-        ( id->p_encoder->fmt_out.i_codec == VLC_FOURCC('s','a','w','b') ) )
-         id->p_encoder->fmt_in.audio.i_rate = id->p_encoder->fmt_out.audio.i_rate;
-    else
-        id->p_encoder->fmt_in.audio.i_rate = fmt_last.audio.i_rate;
+    id->p_encoder->fmt_in.audio.i_rate = id->p_encoder->fmt_out.audio.i_rate;
     id->p_encoder->fmt_in.audio.i_physical_channels =
         id->p_encoder->fmt_out.audio.i_physical_channels;
     id->p_encoder->fmt_in.audio.i_original_channels =
@@ -1268,7 +1154,7 @@ static int transcode_audio_new( sout_stream_t *p_stream,
     id->p_encoder->fmt_in.audio.i_channels =
         id->p_encoder->fmt_out.audio.i_channels;
     id->p_encoder->fmt_in.audio.i_bitspersample =
-        audio_BitsPerSample( id->p_encoder->fmt_in.i_codec );
+        aout_BitsPerSample( id->p_encoder->fmt_in.i_codec );
 
     id->p_encoder->p_cfg = p_stream->p_sys->p_audio_cfg;
     id->p_encoder->p_module =
@@ -1284,37 +1170,33 @@ static int transcode_audio_new( sout_stream_t *p_stream,
     }
     id->p_encoder->fmt_in.audio.i_format = id->p_encoder->fmt_in.i_codec;
     id->p_encoder->fmt_in.audio.i_bitspersample =
-        audio_BitsPerSample( id->p_encoder->fmt_in.i_codec );
+        aout_BitsPerSample( id->p_encoder->fmt_in.i_codec );
+
+    /* Init filter chain */
+    id->p_f_chain = filter_chain_New( p_stream, "audio filter2", true,
+                    transcode_audio_filter_allocation_init, NULL, NULL );
+    filter_chain_Reset( id->p_f_chain, &fmt_last, &id->p_encoder->fmt_in );
 
     /* Load conversion filters */
     if( fmt_last.audio.i_channels != id->p_encoder->fmt_in.audio.i_channels ||
         fmt_last.audio.i_rate != id->p_encoder->fmt_in.audio.i_rate )
     {
         /* We'll have to go through fl32 first */
-        es_format_t fmt_out = id->p_encoder->fmt_in;
-        fmt_out.i_codec = fmt_out.audio.i_format = VLC_FOURCC('f','l','3','2');
-
-        id->pp_filter[id->i_filter] =
-            transcode_audio_filter_new( p_stream, id, &fmt_last, &fmt_out, NULL );
-
-        if( id->pp_filter[id->i_filter] ) id->i_filter++;
+        fmt_last.i_codec = fmt_last.audio.i_format = VLC_FOURCC('f','l','3','2');
+        fmt_last.audio.i_bitspersample = aout_BitsPerSample( fmt_last.i_codec );
+        filter_chain_AppendFilter( id->p_f_chain, NULL, NULL, NULL, &fmt_last );
+        fmt_last = *filter_chain_GetFmtOut( id->p_f_chain );
     }
 
-    for( i = 0; i < TRANSCODE_FILTERS; i++ )
+    for( i = 0; i < 4; i++ )
     {
         if( (fmt_last.audio.i_channels !=
             id->p_encoder->fmt_in.audio.i_channels) ||
             (fmt_last.audio.i_rate != id->p_encoder->fmt_in.audio.i_rate) ||
             (fmt_last.i_codec != id->p_encoder->fmt_in.i_codec) )
         {
-            id->pp_filter[id->i_filter] =
-                transcode_audio_filter_new( p_stream, id, &fmt_last,
-                                            &id->p_encoder->fmt_in, NULL );
-
-            if( id->pp_filter[id->i_filter] )
-                id->i_filter++;
-            else
-                break;
+            filter_chain_AppendFilter( id->p_f_chain, NULL, NULL, &fmt_last, &id->p_encoder->fmt_in );
+            fmt_last = *filter_chain_GetFmtOut( id->p_f_chain );
         }
     }
 
@@ -1329,18 +1211,12 @@ static int transcode_audio_new( sout_stream_t *p_stream,
     }
 
     /* Load user specified audio filters now */
-    for( i = 0; (i < p_sys->i_afilters) &&
-                (id->i_ufilter < TRANSCODE_FILTERS); i++ )
+    if( p_sys->psz_af2 )
     {
-        id->pp_ufilter[id->i_ufilter] =
-            transcode_audio_filter_new( p_stream, id, &fmt_last,
-                                        &id->p_encoder->fmt_in,
-                                        p_sys->psz_afilters[i] );
-
-        if( id->pp_ufilter[id->i_ufilter] )
-            id->i_ufilter++;
-        else
-            break;
+        id->p_uf_chain = filter_chain_New( p_stream, "audio filter2", false,
+                       transcode_audio_filter_allocation_init, NULL, NULL );
+        filter_chain_Reset( id->p_uf_chain, &fmt_last, &id->p_encoder->fmt_in );
+        filter_chain_AppendFromString( id->p_uf_chain, p_sys->psz_af2 );
     }
 
     if( fmt_last.audio.i_channels != id->p_encoder->fmt_in.audio.i_channels )
@@ -1379,7 +1255,7 @@ static int transcode_audio_new( sout_stream_t *p_stream,
         }
         id->p_encoder->fmt_in.audio.i_format = id->p_encoder->fmt_in.i_codec;
         id->p_encoder->fmt_in.audio.i_bitspersample =
-            audio_BitsPerSample( id->p_encoder->fmt_in.i_codec );
+            aout_BitsPerSample( id->p_encoder->fmt_in.i_codec );
 #else
         msg_Err( p_stream, "no audio filter found for mixing from"
                  " %i to %i channels", fmt_last.audio.i_channels,
@@ -1414,8 +1290,6 @@ static int transcode_audio_new( sout_stream_t *p_stream,
 
 static void transcode_audio_close( sout_stream_id_t *id )
 {
-    int i;
-
     audio_timer_close( id->p_encoder );
 
     /* Close decoder */
@@ -1429,23 +1303,10 @@ static void transcode_audio_close( sout_stream_id_t *id )
     id->p_encoder->p_module = NULL;
 
     /* Close filters */
-    for( i = 0; i < id->i_filter; i++ )
-    {
-        vlc_object_detach( id->pp_filter[i] );
-        if( id->pp_filter[i]->p_module )
-            module_Unneed( id->pp_filter[i], id->pp_filter[i]->p_module );
-        vlc_object_release( id->pp_filter[i] );
-    }
-    id->i_filter = 0;
-
-    for( i = 0; i < id->i_ufilter; i++ )
-    {
-        vlc_object_detach( id->pp_ufilter[i] );
-        if( id->pp_ufilter[i]->p_module )
-            module_Unneed( id->pp_ufilter[i], id->pp_ufilter[i]->p_module );
-        vlc_object_release( id->pp_ufilter[i] );
-    }
-    id->i_ufilter = 0;
+    if( id->p_f_chain )
+        filter_chain_Delete( id->p_f_chain );
+    if( id->p_uf_chain )
+        filter_chain_Delete( id->p_uf_chain );
 }
 
 static int transcode_audio_process( sout_stream_t *p_stream,
@@ -1455,7 +1316,6 @@ static int transcode_audio_process( sout_stream_t *p_stream,
     sout_stream_sys_t *p_sys = p_stream->p_sys;
     aout_buffer_t *p_audio_buf;
     block_t *p_block, *p_audio_block;
-    int i;
     *out = NULL;
 
     while( (p_audio_buf = id->p_decoder->pf_decode_audio( id->p_decoder,
@@ -1487,21 +1347,9 @@ static int transcode_audio_process( sout_stream_t *p_stream,
         p_audio_block->i_samples = p_audio_buf->i_nb_samples;
 
         /* Run filter chain */
-        for( i = 0; i < id->i_filter; i++ )
-        {
-            p_audio_block =
-                id->pp_filter[i]->pf_audio_filter( id->pp_filter[i],
-                                                   p_audio_block );
-        }
-
-        /* Run user specified filter chain */
-        for( i = 0; i < id->i_ufilter; i++ )
-        {
-            p_audio_block =
-                id->pp_ufilter[i]->pf_audio_filter( id->pp_ufilter[i],
-                                                    p_audio_block );
-        }
-
+        p_audio_block = filter_chain_AudioFilter( id->p_f_chain, p_audio_block );
+        if( id->p_uf_chain )
+            p_audio_block = filter_chain_AudioFilter( id->p_uf_chain, p_audio_block );
         assert( p_audio_block );
 
         p_audio_buf->p_buffer = p_audio_block->p_buffer;
@@ -1575,65 +1423,30 @@ static void audio_del_buffer( decoder_t *p_dec, aout_buffer_t *p_buffer )
  * video
  */
 
-static filter_t *transcode_video_filter_new( sout_stream_t *p_stream,
-                                             es_format_t *p_fmt_in,
-                                             es_format_t *p_fmt_out,
-                                             config_chain_t  *p_cfg,
-                                             const char *psz_name )
+static int transcode_video_filter_allocation_init( filter_t *p_filter,
+                                                   void *p_data )
 {
-    sout_stream_sys_t *p_sys = p_stream->p_sys;
-    filter_t *p_filter;
+    sout_stream_sys_t *p_sys = (sout_stream_sys_t*)p_data;
     int i;
 
-    if( !p_stream || !p_fmt_in || !p_fmt_out ) return NULL;
-
-    p_filter = vlc_object_create( p_stream, VLC_OBJECT_FILTER );
-    vlc_object_attach( p_filter, p_stream );
-
     p_filter->pf_vout_buffer_new = video_new_buffer_filter;
     p_filter->pf_vout_buffer_del = video_del_buffer_filter;
 
-    es_format_Copy( &p_filter->fmt_in,  p_fmt_in );
-    es_format_Copy( &p_filter->fmt_out, p_fmt_out );
-    p_filter->p_cfg = p_cfg;
-
-    p_filter->p_module = module_Need( p_filter, "video filter2",
-                                      psz_name, true );
-    if( !p_filter->p_module )
-    {
-        msg_Dbg( p_stream, "no video filter found" );
-        vlc_object_detach( p_filter );
-        vlc_object_release( p_filter );
-        return NULL;
-    }
-
     p_filter->p_owner = malloc( sizeof(filter_owner_sys_t) );
     if( !p_filter->p_owner )
-    {
-        module_Unneed( p_filter,p_filter->p_module );
-        vlc_object_detach( p_filter );
-        vlc_object_release( p_filter );
-        return NULL;
-    }
+        return VLC_EGENERIC;
 
     for( i = 0; i < PICTURE_RING_SIZE; i++ )
         p_filter->p_owner->pp_pics[i] = 0;
     p_filter->p_owner->p_sys = p_sys;
 
-    return p_filter;
+    return VLC_SUCCESS;
 }
 
-static void transcode_video_filter_close( sout_stream_t *p_stream,
-                                          filter_t *p_filter )
+static void transcode_video_filter_allocation_clear( filter_t *p_filter )
 {
     int j;
 
-    if( !p_stream || !p_filter ) return;
-
-    vlc_object_detach( p_filter );
-    if( p_filter->p_module )
-        module_Unneed( p_filter, p_filter->p_module );
-
     /* Clean-up pictures ring buffer */
     for( j = 0; j < PICTURE_RING_SIZE; j++ )
     {
@@ -1642,8 +1455,6 @@ static void transcode_video_filter_close( sout_stream_t *p_stream,
                               p_filter->p_owner->pp_pics[j] );
     }
     free( p_filter->p_owner );
-    vlc_object_release( p_filter );
-    p_filter = NULL;
 }
 
 static int transcode_video_new( sout_stream_t *p_stream, sout_stream_id_t *id )
@@ -1753,34 +1564,34 @@ static int transcode_video_new( sout_stream_t *p_stream, sout_stream_id_t *id )
     return VLC_SUCCESS;
 }
 
-static int transcode_video_encoder_open( sout_stream_t *p_stream,
-                                         sout_stream_id_t *id )
+static void transcode_video_encoder_init( sout_stream_t *p_stream,
+                                          sout_stream_id_t *id )
 {
-     sout_stream_sys_t *p_sys = p_stream->p_sys;
+    sout_stream_sys_t *p_sys = p_stream->p_sys;
 
-     /* Calculate scaling
-      * width/height of source */
-     int i_src_width = id->p_decoder->fmt_out.video.i_width;
-     int i_src_height = id->p_decoder->fmt_out.video.i_height;
+    /* Calculate scaling
+     * width/height of source */
+    int i_src_width = id->p_decoder->fmt_out.video.i_width;
+    int i_src_height = id->p_decoder->fmt_out.video.i_height;
 
-     /* with/height scaling */
-     float f_scale_width = 1;
-     float f_scale_height = 1;
+    /* with/height scaling */
+    float f_scale_width = 1;
+    float f_scale_height = 1;
 
-     /* width/height of output stream */
-     int i_dst_width;
-     int i_dst_height;
+    /* width/height of output stream */
+    int i_dst_width;
+    int i_dst_height;
 
-     /* aspect ratio */
-     float f_aspect = (float)id->p_decoder->fmt_out.video.i_aspect /
-                             VOUT_ASPECT_FACTOR;
+    /* aspect ratio */
+    float f_aspect = (float)id->p_decoder->fmt_out.video.i_aspect /
+                            VOUT_ASPECT_FACTOR;
 
-     msg_Dbg( p_stream, "decoder aspect is %i:%i",
-                  id->p_decoder->fmt_out.video.i_aspect, VOUT_ASPECT_FACTOR );
+    msg_Dbg( p_stream, "decoder aspect is %i:%i",
+                 id->p_decoder->fmt_out.video.i_aspect, VOUT_ASPECT_FACTOR );
 
-     /* Change f_aspect from source frame to source pixel */
-     f_aspect = f_aspect * i_src_height / i_src_width;
-     msg_Dbg( p_stream, "source pixel aspect is %f:1", f_aspect );
+    /* Change f_aspect from source frame to source pixel */
+    f_aspect = f_aspect * i_src_height / i_src_width;
+    msg_Dbg( p_stream, "source pixel aspect is %f:1", f_aspect );
 
     /* Calculate scaling factor for specified parameters */
     if( id->p_encoder->fmt_out.video.i_width <= 0 &&
@@ -1855,11 +1666,15 @@ static int transcode_video_encoder_open( sout_stream_t *p_stream,
      f_aspect = f_aspect * i_dst_width / i_dst_height;
 
      /* Store calculated values */
-     id->p_encoder->fmt_out.video.i_width = i_dst_width;
-     id->p_encoder->fmt_out.video.i_height = i_dst_height;
+     id->p_encoder->fmt_out.video.i_width =
+     id->p_encoder->fmt_out.video.i_visible_width = i_dst_width;
+     id->p_encoder->fmt_out.video.i_height =
+     id->p_encoder->fmt_out.video.i_visible_height = i_dst_height;
 
-     id->p_encoder->fmt_in.video.i_width = i_dst_width;
-     id->p_encoder->fmt_in.video.i_height = i_dst_height;
+     id->p_encoder->fmt_in.video.i_width =
+     id->p_encoder->fmt_in.video.i_visible_width = i_dst_width;
+     id->p_encoder->fmt_in.video.i_height =
+     id->p_encoder->fmt_in.video.i_visible_height = i_dst_height;
 
      msg_Dbg( p_stream, "source %ix%i, destination %ix%i",
          i_src_width, i_src_height,
@@ -1907,6 +1722,19 @@ static int transcode_video_encoder_open( sout_stream_t *p_stream,
     msg_Dbg( p_stream, "encoder aspect is %i:%i",
              id->p_encoder->fmt_out.video.i_aspect, VOUT_ASPECT_FACTOR );
 
+    id->p_encoder->fmt_in.video.i_chroma = id->p_encoder->fmt_in.i_codec;
+}
+
+static int transcode_video_encoder_open( sout_stream_t *p_stream,
+                                         sout_stream_id_t *id )
+{
+    sout_stream_sys_t *p_sys = p_stream->p_sys;
+
+
+    msg_Dbg( p_stream, "destination (after video filters) %ix%i",
+             id->p_encoder->fmt_in.video.i_width,
+             id->p_encoder->fmt_in.video.i_height );
+
     id->p_encoder->p_module =
         module_Need( id->p_encoder, "encoder", p_sys->psz_venc, true );
     if( !id->p_encoder->p_module )
@@ -1976,19 +1804,10 @@ static void transcode_video_close( sout_stream_t *p_stream,
         module_Unneed( id->p_encoder, id->p_encoder->p_module );
 
     /* Close filters */
-    for( i = 0; i < id->i_filter; i++ )
-    {
-        transcode_video_filter_close( p_stream, id->pp_filter[i] );
-        id->pp_filter[i] = NULL;
-    }
-    id->i_filter = 0;
-
-    for( i = 0; i < id->i_ufilter; i++ )
-    {
-        transcode_video_filter_close( p_stream, id->pp_ufilter[i] );
-        id->pp_ufilter[i] = NULL;
-    }
-    id->i_ufilter = 0;
+    if( id->p_f_chain )
+        filter_chain_Delete( id->p_f_chain );
+    if( id->p_uf_chain )
+        filter_chain_Delete( id->p_uf_chain );
 }
 
 static int transcode_video_process( sout_stream_t *p_stream,
@@ -1996,7 +1815,7 @@ static int transcode_video_process( sout_stream_t *p_stream,
                                     block_t *in, block_t **out )
 {
     sout_stream_sys_t *p_sys = p_stream->p_sys;
-    int i_duplicate = 1, i;
+    int i_duplicate = 1;
     picture_t *p_pic, *p_pic2 = NULL;
     *out = NULL;
 
@@ -2059,26 +1878,22 @@ static int transcode_video_process( sout_stream_t *p_stream,
 
         if( !id->p_encoder->p_module )
         {
-            if( transcode_video_encoder_open( p_stream, id ) != VLC_SUCCESS )
-            {
-                p_pic->pf_release( p_pic );
-                transcode_video_close( p_stream, id );
-                id->b_transcode = false;
-                return VLC_EGENERIC;
-            }
+            transcode_video_encoder_init( p_stream, id );
+
+            id->p_f_chain = filter_chain_New( p_stream, "video filter2",
+                                              false,
+                               transcode_video_filter_allocation_init,
+                               transcode_video_filter_allocation_clear,
+                               p_stream->p_sys );
 
             /* Deinterlace */
             if( p_stream->p_sys->b_deinterlace )
             {
-                id->pp_filter[id->i_filter] =
-                    transcode_video_filter_new( p_stream,
-                            &id->p_decoder->fmt_out,
-                            &id->p_decoder->fmt_out,
-                            p_sys->p_deinterlace_cfg,
-                            p_sys->psz_deinterlace );
-
-                if( id->pp_filter[id->i_filter] )
-                    id->i_filter++;
+                filter_chain_AppendFilter( id->p_f_chain,
+                                           p_sys->psz_deinterlace,
+                                           p_sys->p_deinterlace_cfg,
+                                           &id->p_decoder->fmt_out,
+                                           &id->p_decoder->fmt_out );
             }
 
             /* Take care of the scaling and chroma conversions */
@@ -2089,38 +1904,46 @@ static int transcode_video_process( sout_stream_t *p_stream,
                 ( id->p_decoder->fmt_out.video.i_height !=
                   id->p_encoder->fmt_in.video.i_height ) )
             {
-                id->pp_filter[id->i_filter] =
-                    transcode_video_filter_new( p_stream,
-                        &id->p_decoder->fmt_out, &id->p_encoder->fmt_in,
-                        NULL, NULL );
-                if( !id->pp_filter[id->i_filter] )
-                {
-                    p_pic->pf_release( p_pic );
-                    transcode_video_close( p_stream, id );
-                    id->b_transcode = false;
-                    return VLC_EGENERIC;
-                }
-                id->i_filter++;
+                filter_chain_AppendFilter( id->p_f_chain,
+                                           NULL, NULL,
+                                           &id->p_decoder->fmt_out,
+                                           &id->p_encoder->fmt_in );
+            }
+
+            if( p_sys->psz_vf2 )
+            {
+                const es_format_t *p_fmt_out;
+                id->p_uf_chain = filter_chain_New( p_stream, "video filter2",
+                                                   true,
+                                   transcode_video_filter_allocation_init,
+                                   transcode_video_filter_allocation_clear,
+                                   p_stream->p_sys );
+                filter_chain_Reset( id->p_uf_chain, &id->p_encoder->fmt_in,
+                                    &id->p_encoder->fmt_in );
+                filter_chain_AppendFromString( id->p_uf_chain, p_sys->psz_vf2 );
+                p_fmt_out = filter_chain_GetFmtOut( id->p_uf_chain );
+                es_format_Copy( &id->p_encoder->fmt_in, p_fmt_out );
+                id->p_encoder->fmt_out.video.i_width =
+                    id->p_encoder->fmt_in.video.i_width;
+                id->p_encoder->fmt_out.video.i_height =
+                    id->p_encoder->fmt_in.video.i_height;
             }
 
-            for( i = 0; (i < p_sys->i_vfilters) && (id->i_ufilter < TRANSCODE_FILTERS); i++ )
+            if( transcode_video_encoder_open( p_stream, id ) != VLC_SUCCESS )
             {
-                id->pp_ufilter[id->i_ufilter] =
-                    transcode_video_filter_new( p_stream,
-                            &id->p_decoder->fmt_out, &id->p_encoder->fmt_in,
-                            p_sys->p_vfilters_cfg[i], p_sys->psz_vfilters[i] );
-                if( id->pp_ufilter[id->i_filter] )
-                    id->i_ufilter++;
-                else
-                    id->pp_ufilter[id->i_ufilter] = NULL;
+                filter_chain_Delete( id->p_f_chain );
+                if( id->p_uf_chain )
+                    filter_chain_Delete( id->p_uf_chain );
+                p_pic->pf_release( p_pic );
+                transcode_video_close( p_stream, id );
+                id->b_transcode = false;
+                return VLC_EGENERIC;
             }
         }
 
         /* Run filter chain */
-        for( i = 0; i < id->i_filter; i++ )
-        {
-            p_pic = id->pp_filter[i]->pf_video_filter(id->pp_filter[i], p_pic);
-        }
+        if( id->p_f_chain )
+            p_pic = filter_chain_VideoFilter( id->p_f_chain, p_pic );
 
         /*
          * Encoding
@@ -2138,14 +1961,14 @@ static int transcode_video_process( sout_stream_t *p_stream,
         if( p_subpic )
         {
             int i_scale_width, i_scale_height;
-            video_format_t *p_fmt;
+            video_format_t fmt;
 
             i_scale_width = id->p_encoder->fmt_in.video.i_width * 1000 /
                 id->p_decoder->fmt_out.video.i_width;
             i_scale_height = id->p_encoder->fmt_in.video.i_height * 1000 /
                 id->p_decoder->fmt_out.video.i_height;
 
-            if( p_pic->i_refcount && !id->i_filter )
+            if( p_pic->i_refcount && !filter_chain_GetLength( id->p_f_chain ) )
             {
                 /* We can't modify the picture, we need to duplicate it */
                 picture_t *p_tmp = video_new_buffer_decoder( id->p_decoder );
@@ -2157,26 +1980,22 @@ static int transcode_video_process( sout_stream_t *p_stream,
                 }
             }
 
-            if( id->i_filter )
-                p_fmt = &id->pp_filter[id->i_filter -1]->fmt_out.video;
+            if( filter_chain_GetLength( id->p_f_chain ) > 0 )
+                fmt = filter_chain_GetFmtOut( id->p_f_chain )->video;
             else
-                p_fmt = &id->p_decoder->fmt_out.video;
+                fmt = id->p_decoder->fmt_out.video;
 
             /* FIXME (shouldn't have to be done here) */
-            p_fmt->i_sar_num = p_fmt->i_aspect *
-                p_fmt->i_height / p_fmt->i_width;
-            p_fmt->i_sar_den = VOUT_ASPECT_FACTOR;
+            fmt.i_sar_num = fmt.i_aspect * fmt.i_height / fmt.i_width;
+            fmt.i_sar_den = VOUT_ASPECT_FACTOR;
 
-            spu_RenderSubpictures( p_sys->p_spu, p_fmt, p_pic, p_pic, p_subpic,
+            spu_RenderSubpictures( p_sys->p_spu, &fmt, p_pic, p_pic, p_subpic,
                                    i_scale_width, i_scale_height );
         }
 
         /* Run user specified filter chain */
-        for( i = 0; i < id->i_ufilter; i++ )
-        {
-            p_pic = id->pp_ufilter[i]->pf_video_filter( id->pp_ufilter[i],
-                                                        p_pic );
-        }
+        if( id->p_uf_chain )
+            p_pic = filter_chain_VideoFilter( id->p_uf_chain, p_pic );
 
         if( p_sys->i_threads == 0 )
         {
@@ -2264,7 +2083,7 @@ static int EncoderThread( sout_stream_sys_t *p_sys )
     sout_stream_id_t *id = p_sys->id_video;
     picture_t *p_pic;
 
-    while( !p_sys->b_die && !p_sys->b_error )
+    while( vlc_object_alive (p_sys) && !p_sys->b_error )
     {
         block_t *p_block;
 
@@ -2272,9 +2091,9 @@ static int EncoderThread( sout_stream_sys_t *p_sys )
         while( p_sys->i_last_pic == p_sys->i_first_pic )
         {
             vlc_cond_wait( &p_sys->cond, &p_sys->lock_out );
-            if( p_sys->b_die || p_sys->b_error ) break;
+            if( !vlc_object_alive (p_sys) || p_sys->b_error ) break;
         }
-        if( p_sys->b_die || p_sys->b_error )
+        if( !vlc_object_alive (p_sys) || p_sys->b_error )
         {
             vlc_mutex_unlock( &p_sys->lock_out );
             break;