#define OSD_UPDATE_MAX 1000
vlc_module_begin ()
+ set_capability( "sub filter", 100 )
+ set_description( N_("On Screen Display menu") )
+ set_shortname( N_("OSD menu") )
+ add_shortcut( "osdmenu" )
+
+ set_category( CAT_VIDEO )
+ set_subcategory( SUBCAT_VIDEO_SUBPIC )
+
+ set_callbacks( CreateFilter, DestroyFilter )
+
add_integer( OSD_CFG "x", -1, NULL, POSX_TEXT, POSX_LONGTEXT, false )
add_integer( OSD_CFG "y", -1, NULL, POSY_TEXT, POSY_LONGTEXT, false )
add_integer( OSD_CFG "position", 8, NULL, POS_TEXT, POS_LONGTEXT,
add_integer_with_range( OSD_CFG "alpha", 255, 0, 255, NULL,
OSD_ALPHA_TEXT, OSD_ALPHA_LONGTEXT, true )
- set_capability( "sub filter", 100 )
- set_description( N_("On Screen Display menu") )
- set_shortname( N_("OSD menu") )
- add_shortcut( "osdmenu" )
-
- set_category( CAT_VIDEO )
- set_subcategory( SUBCAT_VIDEO_SUBPIC )
-
- set_callbacks( CreateFilter, DestroyFilter )
vlc_module_end ()
/*****************************************************************************
if( p_sys->p_menu == NULL )
goto error;
+ /* FIXME: this plugin is not at all thread-safe w.r.t. callbacks */
p_sys->p_menu->i_position = p_sys->i_position;
/* Check if menu position was overridden */
var_DelCallback( p_filter, OSD_CFG "update", OSDMenuCallback, p_sys );
var_DelCallback( p_filter, OSD_CFG "alpha", OSDMenuCallback, p_sys );
- if( p_sys )
+ if( p_sys ) /* FIXME: <-- WTF??? what about the 4 ones above? */
{
var_DelCallback( p_sys->p_menu, "osd-menu-update",
OSDMenuUpdateEvent, p_filter );