Revert the so-called whitelisting commits that are actually blacklisting

[vlc] / modules / video_filter / sharpen.c

diff --git a/modules/video_filter/sharpen.c b/modules/video_filter/sharpen.c
index 0ab4a8550701819bc7f08f83888fe41dba22c9ef..753bf40621fb00b4e40d0d70db9dff3d7dfd3556 100644 (file)
--- a/modules/video_filter/sharpen.c
+++ b/modules/video_filter/sharpen.c
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * sharpen.c: Sharpen video filter
  *****************************************************************************
- * Copyright (C) 2003 the VideoLAN team
+ * Copyright (C) 2003-2007 the VideoLAN team
  * $Id: sharpen.c 18062 2006-11-26 14:20:34Z zorglub $
  *
  * Author: Jérémy DEMEULE <dj_mulder at djduron dot no-ip dot org>
@@ -32,8 +32,6 @@
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
-#include <stdlib.h>                                      /* malloc(), free() */
-#include <string.h>
 
 #include <vlc/vlc.h>
 #include <vlc_vout.h>
@@ -50,6 +48,10 @@ static int  Create    ( vlc_object_t * );
 static void Destroy   ( vlc_object_t * );
 
 static picture_t *Filter( filter_t *, picture_t * );
+static int SharpenCallback( vlc_object_t *, char const *,
+                            vlc_value_t, vlc_value_t, void * );
+
+#define FILTER_PREFIX "sharpen-"
 
 /*****************************************************************************
  * Module descriptor
@@ -66,6 +68,10 @@ vlc_module_begin();
     set_callbacks( Create, Destroy );
 vlc_module_end();
 
+static const char *ppsz_filter_options[] = {
+    "sigma", NULL
+};
+
 /*****************************************************************************
  * filter_sys_t: Sharpen video filter descriptor
  *****************************************************************************
@@ -76,6 +82,7 @@ vlc_module_end();
 struct filter_sys_t
 {
     float f_sigma;
+    int tab_precalc[512];
 };
 
 /*****************************************************************************
@@ -86,6 +93,16 @@ inline static int32_t clip( int32_t a )
     return (a > 255) ? 255 : (a < 0) ? 0 : a;
 }
 
+static void init_precalc_table(filter_sys_t *p_filter)
+{
+    float sigma = p_filter->f_sigma;
+ 
+    for(int i = 0; i < 512; ++i)
+    {
+        p_filter->tab_precalc[i] = (i - 256) * sigma;
+    }
+}
+
 /*****************************************************************************
  * Create: allocates Sharpen video thread output method
  *****************************************************************************
@@ -105,7 +122,15 @@ static int Create( vlc_object_t *p_this )
 
     p_filter->pf_video_filter = Filter;
 
-    p_filter->p_sys->f_sigma = var_GetFloat(p_this, "sharpen-sigma");
+    config_ChainParse( p_filter, FILTER_PREFIX, ppsz_filter_options,
+                   p_filter->p_cfg );
+
+    p_filter->p_sys->f_sigma =
+        var_CreateGetFloatCommand( p_filter, FILTER_PREFIX "sigma" );
+    var_AddCallback( p_filter, FILTER_PREFIX "sigma",
+                     SharpenCallback, p_filter->p_sys );
+
+    init_precalc_table(p_filter->p_sys);
 
     return VLC_SUCCESS;
 }
@@ -133,7 +158,6 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
 {
     picture_t *p_outpic;
     int i, j;
-    vlc_value_t val;
     uint8_t *p_src = NULL;
     uint8_t *p_out = NULL;
     int i_src_pitch;
@@ -160,7 +184,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
     if( !p_src || !p_out )
     {
         msg_Warn( p_filter, "can't get Y plane" );
-        if( p_pic->pf_release ) 
+        if( p_pic->pf_release )
             p_pic->pf_release( p_pic );
         return NULL;
     }
@@ -194,8 +218,9 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
                   (p_src[(i + 1) * i_src_pitch + j    ] * v1) +
                   (p_src[(i + 1) * i_src_pitch + j + 1] * v1);
 
-            p_out[i * i_src_pitch + j] =  clip( p_src[i * i_src_pitch + j] +
-                        (p_filter->p_sys->f_sigma * pix) );
+        pix = pix >= 0 ? clip(pix) : -clip(pix * -1);
+        p_out[i * i_src_pitch + j] = clip( p_src[i * i_src_pitch + j] +
+            p_filter->p_sys->tab_precalc[pix + 256] );
         }
     }
 
@@ -220,3 +245,14 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
 
     return p_outpic;
 }
+
+static int SharpenCallback( vlc_object_t *p_this, char const *psz_var,
+                            vlc_value_t oldval, vlc_value_t newval,
+                            void *p_data )
+{
+    filter_sys_t *p_sys = (filter_sys_t *)p_data;
+    if( !strcmp( psz_var, FILTER_PREFIX "sigma" ) )
+        p_sys->f_sigma = __MIN( 2., __MAX( 0., newval.f_float ) );
+    init_precalc_table(p_sys);
+    return VLC_SUCCESS;
+}