]> git.sesse.net Git - vlc/blobdiff - modules/video_output/fb.c
Fix memleak in lua module.
[vlc] / modules / video_output / fb.c
index 66b54de6e206610f6ccb7c1a821676d5fc2c0e8b..95ea2fe1a317b5df5284080e885488a52eb07b65 100644 (file)
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
+
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
 #include <errno.h>                                                 /* ENOMEM */
 #include <signal.h>                                      /* SIGUSR1, SIGUSR2 */
 #include <fcntl.h>                                                 /* open() */
@@ -38,7 +43,8 @@
 #include <linux/vt.h>                                                /* VT_* */
 #include <linux/kd.h>                                                 /* KD* */
 
-#include <vlc/vlc.h>
+#include <vlc_common.h>
+#include <vlc_plugin.h>
 #include <vlc_vout.h>
 
 /*****************************************************************************
@@ -51,6 +57,10 @@ static int  Init      ( vout_thread_t * );
 static void End       ( vout_thread_t * );
 static int  Manage    ( vout_thread_t * );
 static void Display   ( vout_thread_t *, picture_t * );
+static int  Control   ( vout_thread_t *, int, va_list );
+
+static int  NewPicture     ( vout_thread_t *, picture_t * );
+static void FreePicture    ( vout_thread_t *, picture_t * );
 
 static int  OpenDisplay    ( vout_thread_t * );
 static void CloseDisplay   ( vout_thread_t * );
@@ -58,6 +68,8 @@ static void SwitchDisplay  ( int i_signal );
 static void TextMode       ( int i_tty );
 static void GfxMode        ( int i_tty );
 
+#define MAX_DIRECTBUFFERS 1
+
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
@@ -70,7 +82,7 @@ static void GfxMode        ( int i_tty );
 #define TTY_TEXT N_("Run fb on current tty.")
 #define TTY_LONGTEXT N_( \
     "Run framebuffer on current TTY device (default enabled). " \
-    "(disable tty handling with caution)" );
+    "(disable tty handling with caution)" )
 
 #define CHROMA_TEXT N_("Chroma used.")
 #define CHROMA_LONGTEXT N_( \
@@ -80,18 +92,33 @@ static void GfxMode        ( int i_tty );
 #define ASPECT_RATIO_LONGTEXT N_( \
     "Aspect ratio of the video image (4:3, 16:9). Default is square pixels." )
 
+#define FB_MODE_TEXT N_("Framebuffer resolution to use.")
+#define FB_MODE_LONGTEXT N_( \
+    "Select the resolution for the framebuffer. Currently it supports " \
+    "the values 0=QCIF 1=CIF 2=NTSC 3=PAL, 4=auto (default 4=auto)" )
+
+#define HW_ACCEL_TEXT N_("Framebuffer uses hw acceleration.")
+#define HW_ACCEL_LONGTEXT N_( \
+    "If your framebuffer supports hardware acceleration or does double buffering " \
+    "in hardware then you must disable this option. It then does double buffering " \
+    "in software." )
+
 vlc_module_begin();
     set_shortname( "Framebuffer" );
     set_category( CAT_VIDEO );
     set_subcategory( SUBCAT_VIDEO_VOUT );
     add_file( FB_DEV_VAR, "/dev/fb0", NULL, DEVICE_TEXT, DEVICE_LONGTEXT,
-              VLC_FALSE );
-    add_bool( "fb-tty", 1, NULL, TTY_TEXT, TTY_LONGTEXT, VLC_TRUE );
+              false );
+    add_bool( "fb-tty", 1, NULL, TTY_TEXT, TTY_LONGTEXT, true );
     add_string( "fb-chroma", NULL, NULL, CHROMA_TEXT, CHROMA_LONGTEXT,
-                VLC_TRUE );
+                true );
     add_string( "fb-aspect-ratio", NULL, NULL, ASPECT_RATIO_TEXT,
-                ASPECT_RATIO_LONGTEXT, VLC_TRUE );
-    set_description( _("GNU/Linux console framebuffer video output") );
+                ASPECT_RATIO_LONGTEXT, true );
+    add_integer( "fb-mode", 4, NULL, FB_MODE_TEXT, FB_MODE_LONGTEXT,
+                 true );
+    add_bool( "fb-hw-accel", true, NULL, HW_ACCEL_TEXT, HW_ACCEL_LONGTEXT,
+              true );
+    set_description( N_("GNU/Linux console framebuffer video output") );
     set_capability( "video output", 30 );
     set_callbacks( Create, Destroy );
 vlc_module_end();
@@ -106,7 +133,7 @@ struct vout_sys_t
 {
     /* System information */
     int                 i_tty;                          /* tty device handle */
-    vlc_bool_t          b_tty;
+    bool                b_tty;
     struct termios      old_termios;
 
     /* Original configuration information */
@@ -118,22 +145,29 @@ struct vout_sys_t
     int                         i_fd;                       /* device handle */
     struct fb_var_screeninfo    old_info;       /* original mode information */
     struct fb_var_screeninfo    var_info;        /* current mode information */
-    vlc_bool_t                  b_pan;     /* does device supports panning ? */
+    bool                        b_pan;     /* does device supports panning ? */
     struct fb_cmap              fb_cmap;                /* original colormap */
     uint16_t                    *p_palette;              /* original palette */
+    bool                        b_hw_accel;          /* has hardware support */
 
     /* Video information */
-    int i_width;
-    int i_height;
-    int i_aspect;
-    int i_bytes_per_pixel;
+    uint32_t i_width;
+    uint32_t i_height;
+    int      i_aspect;
+    int      i_bytes_per_pixel;
+    bool     b_auto;       /* Automatically adjust video size to fb size */
     vlc_fourcc_t i_chroma;
 
     /* Video memory */
-    byte_t *    p_video;                                      /* base adress */
+    uint8_t    *p_video;                                      /* base adress */
     size_t      i_page_size;                                    /* page size */
 };
 
+struct picture_sys_t
+{
+    uint8_t *    p_data;                                      /* base adress */
+};
+
 /*****************************************************************************
  * Create: allocates FB video thread output method
  *****************************************************************************
@@ -145,6 +179,7 @@ static int Create( vlc_object_t *p_this )
     vout_sys_t    *p_sys;
     char          *psz_chroma;
     char          *psz_aspect;
+    int           i_mode;
     struct sigaction    sig_tty;                 /* sigaction for tty change */
     struct vt_mode      vt_mode;                          /* vt current mode */
     struct termios      new_termios;
@@ -152,10 +187,7 @@ static int Create( vlc_object_t *p_this )
     /* Allocate instance and initialize some members */
     p_vout->p_sys = p_sys = malloc( sizeof( vout_sys_t ) );
     if( p_vout->p_sys == NULL )
-    {
-        msg_Err( p_vout, "out of memory" );
         return VLC_ENOMEM;
-    };
     memset( p_sys, 0, sizeof(vout_sys_t) );
 
     p_vout->pf_init = Init;
@@ -163,6 +195,10 @@ static int Create( vlc_object_t *p_this )
     p_vout->pf_manage = Manage;
     p_vout->pf_render = NULL;
     p_vout->pf_display = Display;
+    p_vout->pf_control = Control;
+
+    /* Does the framebuffer uses hw acceleration? */
+    p_sys->b_hw_accel = var_CreateGetBool( p_vout, "fb-hw-accel" );
 
     /* Set tty and fb devices */
     p_sys->i_tty = 0; /* 0 == /dev/tty0 == current console */
@@ -170,7 +206,7 @@ static int Create( vlc_object_t *p_this )
 #ifndef WIN32
 #if defined(HAVE_ISATTY)
     /* Check that stdin is a TTY */
-    if( !p_sys->b_tty && !isatty( 0 ) )
+    if( p_sys->b_tty && !isatty( 0 ) )
     {
         msg_Warn( p_vout, "fd 0 is not a TTY" );
         return VLC_EGENERIC;
@@ -222,6 +258,32 @@ static int Create( vlc_object_t *p_this )
         psz_aspect = NULL;
     }
 
+    p_sys->b_auto = false;
+    i_mode = var_CreateGetInteger( p_vout, "fb-mode" );
+    switch( i_mode )
+    {
+        case 0: /* QCIF */
+            p_sys->i_width  = 176;
+            p_sys->i_height = 144;
+            break;
+        case 1: /* CIF */
+            p_sys->i_width  = 352;
+            p_sys->i_height = 288;
+            break;
+        case 2: /* NTSC */
+            p_sys->i_width  = 640;
+            p_sys->i_height = 480;
+            break;
+        case 3: /* PAL */
+            p_sys->i_width  = 704;
+            p_sys->i_height = 576;
+            break;
+        case 4:
+        default:
+            p_sys->b_auto = true;
+            break;
+     }
+
     /* tty handling */
     if( p_sys->b_tty )
     {
@@ -260,7 +322,7 @@ static int Create( vlc_object_t *p_this )
         if( sigaction( SIGUSR1, &sig_tty, &p_vout->p_sys->sig_usr1 ) ||
             sigaction( SIGUSR2, &sig_tty, &p_vout->p_sys->sig_usr2 ) )
         {
-            msg_Err( p_vout, "cannot set signal handler (%s)", strerror(errno) );
+            msg_Err( p_vout, "cannot set signal handler (%m)" );
             tcsetattr(0, 0, &p_vout->p_sys->old_termios);
             TextMode( p_sys->i_tty );
             free( p_vout->p_sys );
@@ -270,7 +332,7 @@ static int Create( vlc_object_t *p_this )
         /* Set-up tty according to new signal handler */
         if( -1 == ioctl( p_sys->i_tty, VT_GETMODE, &p_vout->p_sys->vt_mode ) )
         {
-            msg_Err( p_vout, "cannot get terminal mode (%s)", strerror(errno) );
+            msg_Err( p_vout, "cannot get terminal mode (%m)" );
             sigaction( SIGUSR1, &p_vout->p_sys->sig_usr1, NULL );
             sigaction( SIGUSR2, &p_vout->p_sys->sig_usr2, NULL );
             tcsetattr(0, 0, &p_vout->p_sys->old_termios);
@@ -286,7 +348,7 @@ static int Create( vlc_object_t *p_this )
 
         if( -1 == ioctl( p_sys->i_tty, VT_SETMODE, &vt_mode ) )
         {
-            msg_Err( p_vout, "cannot set terminal mode (%s)", strerror(errno) );
+            msg_Err( p_vout, "cannot set terminal mode (%m)" );
             sigaction( SIGUSR1, &p_vout->p_sys->sig_usr1, NULL );
             sigaction( SIGUSR2, &p_vout->p_sys->sig_usr2, NULL );
             tcsetattr(0, 0, &p_vout->p_sys->old_termios);
@@ -313,6 +375,102 @@ static int Create( vlc_object_t *p_this )
     return VLC_SUCCESS;
 }
 
+
+/*****************************************************************************
+ * Destroy: destroy FB video thread output method
+ *****************************************************************************
+ * Terminate an output method created by Create
+ *****************************************************************************/
+static void Destroy( vlc_object_t *p_this )
+{
+    vout_thread_t *p_vout = (vout_thread_t *)p_this;
+
+    CloseDisplay( p_vout );
+
+    if( p_vout->p_sys->b_tty )
+    {
+        /* Reset the terminal */
+        ioctl( p_vout->p_sys->i_tty, VT_SETMODE, &p_vout->p_sys->vt_mode );
+
+        /* Remove signal handlers */
+        sigaction( SIGUSR1, &p_vout->p_sys->sig_usr1, NULL );
+        sigaction( SIGUSR2, &p_vout->p_sys->sig_usr2, NULL );
+
+        /* Reset the keyboard state */
+        tcsetattr( 0, 0, &p_vout->p_sys->old_termios );
+
+        /* Return to text mode */
+        TextMode( p_vout->p_sys->i_tty );
+    }
+
+    /* Destroy structure */
+    free( p_vout->p_sys );
+}
+
+/*****************************************************************************
+ * NewPicture: allocate a picture
+ *****************************************************************************
+ * Returns 0 on success, -1 otherwise
+ *****************************************************************************/
+static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
+{
+    /* We know the chroma, allocate a buffer which will be used
+     * directly by the decoder */
+    p_pic->p_sys = malloc( sizeof( picture_sys_t ) );
+    if( p_pic->p_sys == NULL )
+    {
+        return VLC_ENOMEM;
+    }
+
+    /* Fill in picture_t fields */
+    vout_InitPicture( VLC_OBJECT(p_vout), p_pic, p_vout->output.i_chroma,
+                      p_vout->output.i_width, p_vout->output.i_height,
+                      p_vout->output.i_aspect );
+
+    p_pic->p_sys->p_data = malloc( p_vout->p_sys->i_page_size );
+    if( !p_pic->p_sys->p_data )
+    {
+        free( p_pic->p_sys );
+        p_pic->p_sys = NULL;
+        return VLC_ENOMEM;
+    }
+
+    p_pic->p->p_pixels = (uint8_t*) p_pic->p_sys->p_data;
+
+    p_pic->p->i_pixel_pitch = p_vout->p_sys->i_bytes_per_pixel;
+    p_pic->p->i_lines = p_vout->p_sys->var_info.yres;
+    p_pic->p->i_visible_lines = p_vout->p_sys->var_info.yres;
+
+    if( p_vout->p_sys->var_info.xres_virtual )
+    {
+        p_pic->p->i_pitch = p_vout->p_sys->var_info.xres_virtual
+                             * p_vout->p_sys->i_bytes_per_pixel;
+    }
+    else
+    {
+        p_pic->p->i_pitch = p_vout->p_sys->var_info.xres
+                             * p_vout->p_sys->i_bytes_per_pixel;
+    }
+
+    p_pic->p->i_visible_pitch = p_vout->p_sys->var_info.xres
+                                 * p_vout->p_sys->i_bytes_per_pixel;
+    p_pic->i_planes = 1;
+
+    return VLC_SUCCESS;
+}
+
+/*****************************************************************************
+ * FreePicture: destroy a picture allocated with NewPicture
+ *****************************************************************************
+ * Destroy Image AND associated data.
+ *****************************************************************************/
+static void FreePicture( vout_thread_t *p_vout, picture_t *p_pic )
+{
+    free( p_pic->p_sys->p_data );
+    free( p_pic->p_sys );
+    p_pic->p_sys = NULL;
+}
+
 /*****************************************************************************
  * Init: initialize framebuffer video thread output method
  *****************************************************************************/
@@ -320,10 +478,15 @@ static int Init( vout_thread_t *p_vout )
 {
     vout_sys_t *p_sys = p_vout->p_sys;
     int i_index;
-    picture_t *p_pic;
+    picture_t *p_pic = NULL;
 
     I_OUTPUTPICTURES = 0;
 
+    p_vout->output.i_width  = p_vout->render.i_width;
+    p_vout->output.i_height = p_vout->render.i_height;
+    p_vout->output.i_aspect = p_vout->render.i_aspect;
+
+    p_vout->fmt_out = p_vout->fmt_in;
     if( p_sys->i_chroma == 0 )
     {
         /* Initialize the output structure: RGB with square pixels, whatever
@@ -362,8 +525,12 @@ static int Init( vout_thread_t *p_vout )
     }
     p_vout->fmt_out.i_chroma = p_vout->output.i_chroma;
 
-    p_vout->output.i_width  = p_sys->i_width;
-    p_vout->output.i_height = p_sys->i_height;
+    p_vout->output.i_width =
+    p_vout->fmt_out.i_width =
+    p_vout->fmt_out.i_visible_width = p_sys->i_width;
+    p_vout->output.i_height =
+    p_vout->fmt_out.i_height =
+    p_vout->fmt_out.i_visible_height = p_sys->i_height;
 
     /* Assume we have square pixels */
     if( p_sys->i_aspect < 0 )
@@ -374,59 +541,92 @@ static int Init( vout_thread_t *p_vout )
     else p_vout->output.i_aspect = p_sys->i_aspect;
 
     p_vout->fmt_out.i_sar_num = p_vout->fmt_out.i_sar_den = 1;
-    p_vout->fmt_out.i_aspect  = p_vout->output.i_aspect;
+    p_vout->fmt_out.i_aspect  = p_vout->render.i_aspect = p_vout->output.i_aspect;
+    p_vout->fmt_out.i_x_offset= p_vout->fmt_out.i_y_offset = 0;
 
     /* Clear the screen */
     memset( p_sys->p_video, 0, p_sys->i_page_size );
 
-    /* Try to initialize 1 direct buffer */
-    p_pic = NULL;
-
-    /* Find an empty picture slot */
-    for( i_index = 0 ; i_index < VOUT_MAX_PICTURES ; i_index++ )
+    if( !p_sys->b_hw_accel )
     {
-        if( p_vout->p_picture[ i_index ].i_status == FREE_PICTURE )
+        /* Try to initialize up to MAX_DIRECTBUFFERS direct buffers */
+        while( I_OUTPUTPICTURES < MAX_DIRECTBUFFERS )
         {
-            p_pic = p_vout->p_picture + i_index;
-            break;
+            p_pic = NULL;
+
+            /* Find an empty picture slot */
+            for( i_index = 0 ; i_index < VOUT_MAX_PICTURES ; i_index++ )
+            {
+            if( p_vout->p_picture[ i_index ].i_status == FREE_PICTURE )
+                {
+                    p_pic = p_vout->p_picture + i_index;
+                    break;
+                }
+            }
+
+            /* Allocate the picture */
+            if( p_pic == NULL || NewPicture( p_vout, p_pic ) )
+            {
+                break;
+            }
+
+            p_pic->i_status = DESTROYED_PICTURE;
+            p_pic->i_type   = DIRECT_PICTURE;
+
+            PP_OUTPUTPICTURE[ I_OUTPUTPICTURES ] = p_pic;
+
+            I_OUTPUTPICTURES++;
         }
     }
-
-    /* Allocate the picture */
-    if( p_pic == NULL )
+    else
     {
-        return VLC_EGENERIC;
-    }
+        /* Try to initialize 1 direct buffer */
+        p_pic = NULL;
 
-    /* We know the chroma, allocate a buffer which will be used
-     * directly by the decoder */
-    p_pic->p->p_pixels = p_vout->p_sys->p_video;
-    p_pic->p->i_pixel_pitch = p_vout->p_sys->i_bytes_per_pixel;
-    p_pic->p->i_lines = p_vout->p_sys->var_info.yres;
-    p_pic->p->i_visible_lines = p_vout->p_sys->var_info.yres;
+        /* Find an empty picture slot */
+        for( i_index = 0 ; i_index < VOUT_MAX_PICTURES ; i_index++ )
+        {
+            if( p_vout->p_picture[ i_index ].i_status == FREE_PICTURE )
+            {
+                p_pic = p_vout->p_picture + i_index;
+                break;
+            }
+        }
 
-    if( p_vout->p_sys->var_info.xres_virtual )
-    {
-        p_pic->p->i_pitch = p_vout->p_sys->var_info.xres_virtual
-                             * p_vout->p_sys->i_bytes_per_pixel;
-    }
-    else
-    {
-        p_pic->p->i_pitch = p_vout->p_sys->var_info.xres
-                             * p_vout->p_sys->i_bytes_per_pixel;
-    }
+        /* Allocate the picture */
+        if( p_pic == NULL )
+        {
+            return VLC_EGENERIC;
+        }
 
-    p_pic->p->i_visible_pitch = p_vout->p_sys->var_info.xres
-                                 * p_vout->p_sys->i_bytes_per_pixel;
+        /* We know the chroma, allocate a buffer which will be used
+        * directly by the decoder */
+        p_pic->p->p_pixels = p_vout->p_sys->p_video;
+        p_pic->p->i_pixel_pitch = p_vout->p_sys->i_bytes_per_pixel;
+        p_pic->p->i_lines = p_vout->p_sys->var_info.yres;
+        p_pic->p->i_visible_lines = p_vout->p_sys->var_info.yres;
 
-    p_pic->i_planes = 1;
+        if( p_vout->p_sys->var_info.xres_virtual )
+        {
+            p_pic->p->i_pitch = p_vout->p_sys->var_info.xres_virtual
+                                * p_vout->p_sys->i_bytes_per_pixel;
+        }
+        else
+        {
+            p_pic->p->i_pitch = p_vout->p_sys->var_info.xres
+                                * p_vout->p_sys->i_bytes_per_pixel;
+        }
 
-    p_pic->i_status = DESTROYED_PICTURE;
-    p_pic->i_type   = DIRECT_PICTURE;
+        p_pic->p->i_visible_pitch = p_vout->p_sys->var_info.xres
+                                    * p_vout->p_sys->i_bytes_per_pixel;
+        p_pic->i_planes = 1;
+        p_pic->i_status = DESTROYED_PICTURE;
+        p_pic->i_type   = DIRECT_PICTURE;
 
-    PP_OUTPUTPICTURE[ I_OUTPUTPICTURES ] = p_pic;
+        PP_OUTPUTPICTURE[ I_OUTPUTPICTURES ] = p_pic;
 
-    I_OUTPUTPICTURES++;
+        I_OUTPUTPICTURES++;
+    }
 
     return VLC_SUCCESS;
 }
@@ -436,39 +636,32 @@ static int Init( vout_thread_t *p_vout )
  *****************************************************************************/
 static void End( vout_thread_t *p_vout )
 {
+    if( !p_vout->p_sys->b_hw_accel )
+    {
+        int i_index;
+
+        /* Free the direct buffers we allocated */
+        for( i_index = I_OUTPUTPICTURES ; i_index ; )
+        {
+            i_index--;
+            FreePicture( p_vout, PP_OUTPUTPICTURE[ i_index ] );
+        }
+
+    }
     /* Clear the screen */
     memset( p_vout->p_sys->p_video, 0, p_vout->p_sys->i_page_size );
 }
 
 /*****************************************************************************
- * Destroy: destroy FB video thread output method
- *****************************************************************************
- * Terminate an output method created by Create
+ * Control: control facility for the vout
  *****************************************************************************/
-static void Destroy( vlc_object_t *p_this )
+static int Control( vout_thread_t *p_vout, int i_query, va_list args )
 {
-    vout_thread_t *p_vout = (vout_thread_t *)p_this;
-
-    CloseDisplay( p_vout );
-
-    if( p_vout->p_sys->b_tty )
+    switch( i_query )
     {
-        /* Reset the terminal */
-        ioctl( p_vout->p_sys->i_tty, VT_SETMODE, &p_vout->p_sys->vt_mode );
-
-        /* Remove signal handlers */
-        sigaction( SIGUSR1, &p_vout->p_sys->sig_usr1, NULL );
-        sigaction( SIGUSR2, &p_vout->p_sys->sig_usr2, NULL );
-
-        /* Reset the keyboard state */
-        tcsetattr( 0, 0, &p_vout->p_sys->old_termios );
-
-        /* Return to text mode */
-        TextMode( p_vout->p_sys->i_tty );
+       default:
+            return vout_vaControlDefault( p_vout, i_query, args );
     }
-
-    /* Destroy structure */
-    free( p_vout->p_sys );
 }
 
 /*****************************************************************************
@@ -548,11 +741,17 @@ static int panned=0;
 
         if( panned < 0 )
         {
-                ioctl( p_vout->p_sys->i_fd,
-                       FBIOPAN_DISPLAY, &p_vout->p_sys->var_info );
-                panned++;
+            ioctl( p_vout->p_sys->i_fd,
+                   FBIOPAN_DISPLAY, &p_vout->p_sys->var_info );
+            panned++;
         }
     }
+
+    if( !p_vout->p_sys->b_hw_accel )
+    {
+        vlc_memcpy( p_vout->p_sys->p_video, p_pic->p->p_pixels,
+                    p_vout->p_sys->i_page_size );
+    }
 }
 
 #if 0
@@ -572,6 +771,7 @@ static void SetPalette( vout_thread_t *p_vout, uint16_t *red, uint16_t *green,
  *****************************************************************************/
 static int OpenDisplay( vout_thread_t *p_vout )
 {
+    vout_sys_t *p_sys = (vout_sys_t *) p_vout->p_sys;
     char *psz_device;                             /* framebuffer device path */
     struct fb_fix_screeninfo    fix_info;     /* framebuffer fix information */
 
@@ -582,10 +782,10 @@ static int OpenDisplay( vout_thread_t *p_vout )
         return VLC_EGENERIC;
     }
 
-    p_vout->p_sys->i_fd = open( psz_device, O_RDWR);
-    if( p_vout->p_sys->i_fd == -1 )
+    p_sys->i_fd = open( psz_device, O_RDWR);
+    if( p_sys->i_fd == -1 )
     {
-        msg_Err( p_vout, "cannot open %s (%s)", psz_device, strerror(errno) );
+        msg_Err( p_vout, "cannot open %s (%m)", psz_device );
         free( psz_device );
         return VLC_EGENERIC;
     }
@@ -593,137 +793,149 @@ static int OpenDisplay( vout_thread_t *p_vout )
     psz_device = NULL;
 
     /* Get framebuffer device information */
-    if( ioctl( p_vout->p_sys->i_fd,
-               FBIOGET_VSCREENINFO, &p_vout->p_sys->var_info ) )
+    if( ioctl( p_sys->i_fd, FBIOGET_VSCREENINFO, &p_sys->var_info ) )
     {
-        msg_Err( p_vout, "cannot get fb info (%s)", strerror(errno) );
-        close( p_vout->p_sys->i_fd );
+        msg_Err( p_vout, "cannot get fb info (%m)" );
+        close( p_sys->i_fd );
         return VLC_EGENERIC;
     }
 
-    memcpy( &p_vout->p_sys->old_info, &p_vout->p_sys->var_info,
+    memcpy( &p_sys->old_info, &p_sys->var_info,
             sizeof( struct fb_var_screeninfo ) );
 
+    /* Get some info on the framebuffer itself */
+    if( !p_sys->b_auto )
+    {
+        p_sys->var_info.xres = p_sys->var_info.xres_virtual = p_sys->i_width;
+        p_sys->var_info.yres = p_sys->var_info.yres_virtual = p_sys->i_height;
+        p_vout->fmt_out.i_width = p_sys->i_width;
+        p_vout->fmt_out.i_height = p_sys->i_height;
+    }
+
     /* Set some attributes */
-    p_vout->p_sys->var_info.activate = FB_ACTIVATE_NXTOPEN;
-    p_vout->p_sys->var_info.xoffset =  0;
-    p_vout->p_sys->var_info.yoffset =  0;
+    p_sys->var_info.activate = p_sys->b_tty
+                               ? FB_ACTIVATE_NXTOPEN
+                               : FB_ACTIVATE_NOW;
+    p_sys->var_info.xoffset =  0;
+    p_sys->var_info.yoffset =  0;
 
-    if( ioctl( p_vout->p_sys->i_fd,
-               FBIOPUT_VSCREENINFO, &p_vout->p_sys->var_info ) )
+    if( ioctl( p_sys->i_fd, FBIOPUT_VSCREENINFO, &p_sys->var_info ) )
     {
-        msg_Err( p_vout, "cannot set fb info (%s)", strerror(errno) );
-        close( p_vout->p_sys->i_fd );
+        msg_Err( p_vout, "cannot set fb info (%m)" );
+        close( p_sys->i_fd );
         return VLC_EGENERIC;
     }
 
     /* Get some information again, in the definitive configuration */
-    if( ioctl( p_vout->p_sys->i_fd, FBIOGET_FSCREENINFO, &fix_info )
-         || ioctl( p_vout->p_sys->i_fd,
-                   FBIOGET_VSCREENINFO, &p_vout->p_sys->var_info ) )
+    if( ioctl( p_sys->i_fd, FBIOGET_FSCREENINFO, &fix_info )
+         || ioctl( p_sys->i_fd, FBIOGET_VSCREENINFO, &p_sys->var_info ) )
     {
-        msg_Err( p_vout, "cannot get additional fb info (%s)",
-                          strerror(errno) );
+        msg_Err( p_vout, "cannot get additional fb info (%m)" );
 
         /* Restore fb config */
-        ioctl( p_vout->p_sys->i_fd,
-               FBIOPUT_VSCREENINFO, &p_vout->p_sys->old_info );
+        ioctl( p_sys->i_fd, FBIOPUT_VSCREENINFO, &p_sys->old_info );
 
-        close( p_vout->p_sys->i_fd );
+        close( p_sys->i_fd );
         return VLC_EGENERIC;
     }
 
+    /* If the fb has limitations on mode change,
+     * then keep the resolution of the fb */
+    if( (p_sys->i_height != p_sys->var_info.yres) ||
+        (p_sys->i_width != p_sys->var_info.xres) )
+    {
+        p_sys->b_auto = true;
+        msg_Warn( p_vout,
+                  "using framebuffer native resolution instead of requested (%ix%i)",
+                  p_sys->i_width, p_sys->i_height );
+    }
+    p_sys->i_height = p_sys->var_info.yres;
+    p_sys->i_width  = p_sys->var_info.xres_virtual
+                               ? p_sys->var_info.xres_virtual
+                               : p_sys->var_info.xres;
+
     /* FIXME: if the image is full-size, it gets cropped on the left
      * because of the xres / xres_virtual slight difference */
-    msg_Dbg( p_vout, "%ix%i (virtual %ix%i)",
-             p_vout->p_sys->var_info.xres, p_vout->p_sys->var_info.yres,
-             p_vout->p_sys->var_info.xres_virtual,
-             p_vout->p_sys->var_info.yres_virtual );
+    msg_Dbg( p_vout, "%ix%i (virtual %ix%i) (request %ix%i)",
+             p_sys->var_info.xres, p_sys->var_info.yres,
+             p_sys->var_info.xres_virtual,
+             p_sys->var_info.yres_virtual,
+             p_sys->i_width, p_sys->i_height );
 
-    p_vout->p_sys->i_height = p_vout->p_sys->var_info.yres;
-    p_vout->p_sys->i_width  = p_vout->p_sys->var_info.xres_virtual
-                               ? p_vout->p_sys->var_info.xres_virtual
-                               : p_vout->p_sys->var_info.xres;
+    p_sys->p_palette = NULL;
+    p_sys->b_pan = ( fix_info.ypanstep || fix_info.ywrapstep );
 
-    p_vout->p_sys->p_palette = NULL;
-    p_vout->p_sys->b_pan = ( fix_info.ypanstep || fix_info.ywrapstep );
-
-    switch( p_vout->p_sys->var_info.bits_per_pixel )
+    switch( p_sys->var_info.bits_per_pixel )
     {
     case 8:
-        p_vout->p_sys->p_palette = malloc( 8 * 256 * sizeof( uint16_t ) );
-        if( !p_vout->p_sys->p_palette )
+        p_sys->p_palette = malloc( 8 * 256 * sizeof( uint16_t ) );
+        if( !p_sys->p_palette )
         {
-            msg_Err( p_vout, "out of memory" );
-
             /* Restore fb config */
-            ioctl( p_vout->p_sys->i_fd,
-                   FBIOPUT_VSCREENINFO, &p_vout->p_sys->old_info );
+            ioctl( p_sys->i_fd, FBIOPUT_VSCREENINFO, &p_sys->old_info );
 
-            close( p_vout->p_sys->i_fd );
+            close( p_sys->i_fd );
             return VLC_ENOMEM;
         }
-        p_vout->p_sys->fb_cmap.start = 0;
-        p_vout->p_sys->fb_cmap.len = 256;
-        p_vout->p_sys->fb_cmap.red = p_vout->p_sys->p_palette;
-        p_vout->p_sys->fb_cmap.green = p_vout->p_sys->p_palette + 256 * sizeof( uint16_t );
-        p_vout->p_sys->fb_cmap.blue = p_vout->p_sys->p_palette + 2 * 256 * sizeof( uint16_t );
-        p_vout->p_sys->fb_cmap.transp = p_vout->p_sys->p_palette + 3 * 256 * sizeof( uint16_t );
+        p_sys->fb_cmap.start = 0;
+        p_sys->fb_cmap.len = 256;
+        p_sys->fb_cmap.red = p_sys->p_palette;
+        p_sys->fb_cmap.green = p_sys->p_palette + 256 * sizeof( uint16_t );
+        p_sys->fb_cmap.blue = p_sys->p_palette + 2 * 256 * sizeof( uint16_t );
+        p_sys->fb_cmap.transp = p_sys->p_palette + 3 * 256 * sizeof( uint16_t );
 
         /* Save the colormap */
-        ioctl( p_vout->p_sys->i_fd, FBIOGETCMAP, &p_vout->p_sys->fb_cmap );
+        ioctl( p_sys->i_fd, FBIOGETCMAP, &p_sys->fb_cmap );
 
-        p_vout->p_sys->i_bytes_per_pixel = 1;
+        p_sys->i_bytes_per_pixel = 1;
         break;
 
     case 15:
     case 16:
-        p_vout->p_sys->i_bytes_per_pixel = 2;
+        p_sys->i_bytes_per_pixel = 2;
         break;
 
     case 24:
-        p_vout->p_sys->i_bytes_per_pixel = 3;
+        p_sys->i_bytes_per_pixel = 3;
         break;
 
     case 32:
-        p_vout->p_sys->i_bytes_per_pixel = 4;
+        p_sys->i_bytes_per_pixel = 4;
         break;
 
     default:
         msg_Err( p_vout, "screen depth %d is not supported",
-                         p_vout->p_sys->var_info.bits_per_pixel );
+                         p_sys->var_info.bits_per_pixel );
 
         /* Restore fb config */
-        ioctl( p_vout->p_sys->i_fd,
-               FBIOPUT_VSCREENINFO, &p_vout->p_sys->old_info );
+        ioctl( p_sys->i_fd, FBIOPUT_VSCREENINFO, &p_sys->old_info );
 
-        close( p_vout->p_sys->i_fd );
+        close( p_sys->i_fd );
         return VLC_EGENERIC;
     }
 
-    p_vout->p_sys->i_page_size = p_vout->p_sys->i_width *
-                p_vout->p_sys->i_height * p_vout->p_sys->i_bytes_per_pixel;
+    p_sys->i_page_size = p_sys->i_width * p_sys->i_height *
+                         p_sys->i_bytes_per_pixel;
 
     /* Map a framebuffer at the beginning */
-    p_vout->p_sys->p_video = mmap( 0, p_vout->p_sys->i_page_size,
-                                   PROT_READ | PROT_WRITE, MAP_SHARED,
-                                   p_vout->p_sys->i_fd, 0 );
+    p_sys->p_video = mmap( 0, p_sys->i_page_size,
+                              PROT_READ | PROT_WRITE, MAP_SHARED,
+                              p_sys->i_fd, 0 );
 
-    if( p_vout->p_sys->p_video == ((void*)-1) )
+    if( p_sys->p_video == ((void*)-1) )
     {
-        msg_Err( p_vout, "cannot map video memory (%s)", strerror(errno) );
+        msg_Err( p_vout, "cannot map video memory (%m)" );
 
-        if( p_vout->p_sys->var_info.bits_per_pixel == 8 )
+        if( p_sys->var_info.bits_per_pixel == 8 )
         {
-            free( p_vout->p_sys->p_palette );
-            p_vout->p_sys->p_palette = NULL;
+            free( p_sys->p_palette );
+            p_sys->p_palette = NULL;
         }
 
         /* Restore fb config */
-        ioctl( p_vout->p_sys->i_fd,
-               FBIOPUT_VSCREENINFO, &p_vout->p_sys->old_info );
+        ioctl( p_sys->i_fd, FBIOPUT_VSCREENINFO, &p_vout->p_sys->old_info );
 
-        close( p_vout->p_sys->i_fd );
+        close( p_sys->i_fd );
         return VLC_EGENERIC;
     }
 
@@ -764,7 +976,7 @@ static void CloseDisplay( vout_thread_t *p_vout )
  * This function activates or deactivates the output of the thread. It is
  * called by the VT driver, on terminal change.
  *****************************************************************************/
-static void SwitchDisplay(int i_signal)
+static void SwitchDisplay( int i_signal )
 {
 #if 0
     vout_thread_t *p_vout;