]> git.sesse.net Git - vlc/blobdiff - modules/video_output/sdl.c
add mutex to the sdl video_output
[vlc] / modules / video_output / sdl.c
index d140d593523e3f660f9b9c3b08e97492bee5432b..a04b949247bfbc86623cf672698ec95eb391ca4b 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * sdl.c: SDL video output display method
  *****************************************************************************
- * Copyright (C) 1998-2001 VideoLAN (Centrale Réseaux) and its contributors
+ * Copyright (C) 1998-2001 the VideoLAN team
  * $Id$
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
 #include <errno.h>                                                 /* ENOMEM */
-#include <stdlib.h>                                                /* free() */
-#include <string.h>                                            /* strerror() */
 
 #include <vlc/vlc.h>
-#include <vlc/intf.h>
-#include <vlc/vout.h>
-#include <vlc/aout.h>
+#include <vlc_interface.h>
+#include <vlc_playlist.h>
+#include <vlc_vout.h>
+#include <vlc_keys.h>
+//#include <vlc_aout.h>
 
 #include <sys/types.h>
 #ifndef WIN32
@@ -42,7 +42,8 @@
 
 #include SDL_INCLUDE_FILE
 
-#define SDL_MAX_DIRECTBUFFERS 10
+/* SDL is not able to crop overlays - so use only 1 direct buffer */
+#define SDL_MAX_DIRECTBUFFERS 1
 #define SDL_DEFAULT_BPP 16
 
 /*****************************************************************************
@@ -68,6 +69,8 @@ struct vout_sys_t
     vlc_bool_t  b_cursor_autohidden;
     mtime_t     i_lastmoved;
     mtime_t     i_lastpressed;                        /* to track dbl-clicks */
+
+    vlc_mutex_t lock;
 };
 
 /*****************************************************************************
@@ -97,6 +100,14 @@ static int  NewPicture      ( vout_thread_t *, picture_t * );
 static void SetPalette      ( vout_thread_t *,
                               uint16_t *, uint16_t *, uint16_t * );
 
+static int ConvertKey( SDLKey );
+
+
+#define CHROMA_TEXT N_("SDL chroma format")
+#define CHROMA_LONGTEXT N_( \
+    "Force the SDL renderer to use a specific chroma format instead of " \
+    "trying to improve performances by using the most efficient one.")
+
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
@@ -107,9 +118,8 @@ vlc_module_begin();
     set_description( _("Simple DirectMedia Layer video output") );
     set_capability( "video output", 60 );
     add_shortcut( "sdl" );
+    add_string( "sdl-chroma", NULL, NULL, CHROMA_TEXT, CHROMA_LONGTEXT, VLC_TRUE );
     set_callbacks( Open, Close );
-    /* XXX: check for conflicts with the SDL audio output */
-    var_Create( p_module->p_libvlc, "sdl", VLC_VAR_MUTEX );
 #if defined( __i386__ ) || defined( __x86_64__ )
     /* On i386, SDL is linked against svgalib */
     linked_with_a_crap_library_which_uses_atexit();
@@ -126,30 +136,34 @@ vlc_module_end();
 static int Open ( vlc_object_t *p_this )
 {
     vout_thread_t * p_vout = (vout_thread_t *)p_this;
-    vlc_value_t lockval;
+    /* XXX: check for conflicts with the SDL audio output */
+    vlc_mutex_t *lock = var_AcquireMutex( "sdl" );
 
 #ifdef HAVE_SETENV
     char *psz_method;
 #endif
 
-    var_Get( p_this->p_libvlc, "sdl", &lockval );
-    vlc_mutex_lock( lockval.p_address );
-
-    if( SDL_WasInit( SDL_INIT_VIDEO ) != 0 )
-    {
-        vlc_mutex_unlock( lockval.p_address );
-        return VLC_EGENERIC;
-    }
+    if( lock == NULL )
+        return VLC_ENOMEM;
 
-    /* Allocate structure */
     p_vout->p_sys = malloc( sizeof( vout_sys_t ) );
     if( p_vout->p_sys == NULL )
     {
-        msg_Err( p_vout, "out of memory" );
-        vlc_mutex_unlock( lockval.p_address );
+        vlc_mutex_unlock( lock );
         return VLC_ENOMEM;
     }
 
+    vlc_mutex_init( p_vout, &p_vout->p_sys->lock );
+
+    /* Check if SDL video module has been initialized */
+    if( SDL_WasInit( SDL_INIT_VIDEO ) != 0 )
+    {
+        vlc_mutex_unlock( lock );
+        free( p_vout->p_sys );
+        return VLC_EGENERIC;
+    }
+
+    /* Allocate structure */
     p_vout->pf_init = Init;
     p_vout->pf_end = End;
     p_vout->pf_manage = Manage;
@@ -187,11 +201,14 @@ static int Open ( vlc_object_t *p_this )
     {
         msg_Err( p_vout, "cannot initialize SDL (%s)", SDL_GetError() );
         free( p_vout->p_sys );
-        vlc_mutex_unlock( lockval.p_address );
+        vlc_mutex_unlock( lock );
         return VLC_EGENERIC;
     }
 
-    vlc_mutex_unlock( lockval.p_address );
+    /* Translate keys into unicode */
+    SDL_EnableUNICODE(1);
+
+    vlc_mutex_unlock( lock );
 
     p_vout->p_sys->b_cursor = 1;
     p_vout->p_sys->b_cursor_autohidden = 0;
@@ -313,6 +330,8 @@ static void Close ( vlc_object_t *p_this )
     CloseDisplay( p_vout );
     SDL_QuitSubSystem( SDL_INIT_VIDEO );
 
+    vlc_mutex_destroy( &p_vout->p_sys->lock );
+
     free( p_vout->p_sys );
 }
 
@@ -326,10 +345,12 @@ static int Manage( vout_thread_t *p_vout )
 {
     SDL_Event event;                                            /* SDL event */
     vlc_value_t val;
-    int i_width, i_height, i_x, i_y;
+    unsigned int i_width, i_height, i_x, i_y;
+
+    vlc_mutex_lock( &p_vout->p_sys->lock );
 
     /* Process events */
-    while( SDL_PollEvent(&event) )
+    while( SDL_PollEvent( &event ) )
     {
         switch( event.type )
         {
@@ -340,6 +361,7 @@ static int Manage( vout_thread_t *p_vout )
             p_vout->i_window_height = p_vout->p_sys->i_height = event.resize.h;
             break;
 
+        /* Mouse move */
         case SDL_MOUSEMOTION:
             vout_PlacePicture( p_vout, p_vout->p_sys->i_width,
                                p_vout->p_sys->i_height,
@@ -370,17 +392,48 @@ static int Manage( vout_thread_t *p_vout )
             }
             break;
 
+        /* Mouse button released */
         case SDL_MOUSEBUTTONUP:
             switch( event.button.button )
             {
             case SDL_BUTTON_LEFT:
+                var_Get( p_vout, "mouse-button-down", &val );
+                val.i_int &= ~1;
+                var_Set( p_vout, "mouse-button-down", val );
+
                 val.b_bool = VLC_TRUE;
                 var_Set( p_vout, "mouse-clicked", val );
                 break;
 
+            case SDL_BUTTON_MIDDLE:
+                {
+                    playlist_t *p_playlist;
+
+                    var_Get( p_vout, "mouse-button-down", &val );
+                    val.i_int &= ~2;
+                    var_Set( p_vout, "mouse-button-down", val );
+
+                    p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
+                                              FIND_ANYWHERE );
+                    if( p_playlist != NULL )
+                    {
+                        vlc_value_t val;
+                        var_Get( p_playlist, "intf-show", &val );
+                        val.b_bool = !val.b_bool;
+                        var_Set( p_playlist, "intf-show", val );
+                        vlc_object_release( p_playlist );
+                    }
+                }
+                break;
+
             case SDL_BUTTON_RIGHT:
                 {
                     intf_thread_t *p_intf;
+                    playlist_t *p_playlist;
+
+                    var_Get( p_vout, "mouse-button-down", &val );
+                    val.i_int &= ~4;
+                    var_Set( p_vout, "mous-button-down", val );
                     p_intf = vlc_object_find( p_vout, VLC_OBJECT_INTF,
                                                       FIND_ANYWHERE );
                     if( p_intf )
@@ -388,17 +441,30 @@ static int Manage( vout_thread_t *p_vout )
                         p_intf->b_menu_change = 1;
                         vlc_object_release( p_intf );
                     }
+
+                    p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
+                                                FIND_ANYWHERE );
+
+                    if( p_playlist != NULL )
+                    {
+                        vlc_value_t val;
+                        val.b_bool = VLC_TRUE;
+                        var_Set( p_playlist, "intf-popupmenu", val );
+                        vlc_object_release( p_playlist );
+                    }
                 }
                 break;
             }
             break;
 
+        /* Mouse button pressed */
         case SDL_MOUSEBUTTONDOWN:
             switch( event.button.button )
             {
             case SDL_BUTTON_LEFT:
-                /* In this part we will eventually manage
-                 * clicks for DVD navigation for instance. */
+                var_Get( p_vout, "mouse-button-down", &val );
+                val.i_int |= 1;
+                var_Set( p_vout, "mouse-button-down", val );
 
                 /* detect double-clicks */
                 if( ( mdate() - p_vout->p_sys->i_lastpressed ) < 300000 )
@@ -407,118 +473,60 @@ static int Manage( vout_thread_t *p_vout )
                 p_vout->p_sys->i_lastpressed = mdate();
                 break;
 
-            case 4:
+            case SDL_BUTTON_MIDDLE:
+                var_Get( p_vout, "mouse-button-down", &val );
+                val.i_int |= 2;
+                var_Set( p_vout, "mouse-button-down", val );
                 break;
 
-            case 5:
+            case SDL_BUTTON_RIGHT:
+                var_Get( p_vout, "mouse-button-down", &val );
+                val.i_int |= 4;
+                var_Set( p_vout, "mouse-button-down", val );
                 break;
             }
             break;
 
+        /* Quit event (close the window) */
         case SDL_QUIT:
-            p_vout->p_vlc->b_die = 1;
+            {
+                playlist_t *p_playlist = (playlist_t *)vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
+                if( p_playlist != NULL )
+                {
+                    playlist_Stop( p_playlist );
+                    vlc_object_release( p_playlist );
+                }
+            }
             break;
 
-        case SDL_KEYDOWN:                             /* if a key is pressed */
+        /* Key pressed */
+        case SDL_KEYDOWN:
+            val.i_int = ConvertKey( event.key.keysym.sym );
 
-            switch( event.key.keysym.sym )
+            if( !val.i_int )
             {
-            case SDLK_ESCAPE:
-                if( p_vout->b_fullscreen )
-                {
-                    p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-                }
-                else
+                if( ( event.key.keysym.unicode & 0xff80 ) == 0 )
                 {
-                    p_vout->p_vlc->b_die = 1;
+                    val.i_int = event.key.keysym.unicode & 0x7f;
                 }
-                break;
-
-            case SDLK_q:                                             /* quit */
-                p_vout->p_vlc->b_die = 1;
-                break;
-
-            case SDLK_f:                             /* switch to fullscreen */
-                p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-                break;
-
-            case SDLK_c:                                 /* toggle grayscale */
-                p_vout->b_grayscale = ! p_vout->b_grayscale;
-                p_vout->i_changes |= VOUT_GRAYSCALE_CHANGE;
-                break;
-
-            case SDLK_i:                                      /* toggle info */
-                p_vout->b_info = ! p_vout->b_info;
-                p_vout->i_changes |= VOUT_INFO_CHANGE;
-                break;
-
-            case SDLK_s:                                   /* toggle scaling */
-                p_vout->b_scale = ! p_vout->b_scale;
-                p_vout->i_changes |= VOUT_SCALE_CHANGE;
-                break;
-
-            case SDLK_SPACE:                             /* toggle interface */
-                p_vout->b_interface = ! p_vout->b_interface;
-                p_vout->i_changes |= VOUT_INTF_CHANGE;
-                break;
+            }
 
-            case SDLK_MENU:
+            if( val.i_int )
+            {
+                if( ( event.key.keysym.mod & KMOD_SHIFT ) )
                 {
-                    intf_thread_t *p_intf;
-                    p_intf = vlc_object_find( p_vout, VLC_OBJECT_INTF,
-                                                      FIND_ANYWHERE );
-                    if( p_intf != NULL )
-                    {
-                        p_intf->b_menu_change = 1;
-                        vlc_object_release( p_intf );
-                    }
+                    val.i_int |= KEY_MODIFIER_SHIFT;
                 }
-                break;
-
-            case SDLK_LEFT:
-                break;
-
-            case SDLK_RIGHT:
-                break;
-
-            case SDLK_UP:
-                break;
-
-            case SDLK_DOWN:
-                break;
-
-            case SDLK_b:
+                if( ( event.key.keysym.mod & KMOD_CTRL ) )
                 {
-                    audio_volume_t i_volume;
-                    if ( !aout_VolumeDown( p_vout, 1, &i_volume ) )
-                    {
-                        msg_Dbg( p_vout, "audio volume is now %d", i_volume );
-                    }
-                    else
-                    {
-                        msg_Dbg( p_vout, "audio volume: operation not supported" );
-                    }
+                    val.i_int |= KEY_MODIFIER_CTRL;
                 }
-                break;
-
-            case SDLK_n:
+                if( ( event.key.keysym.mod & KMOD_ALT ) )
                 {
-                    audio_volume_t i_volume;
-                    if ( !aout_VolumeUp( p_vout, 1, &i_volume ) )
-                    {
-                        msg_Dbg( p_vout, "audio volume is now %d", i_volume );
-                    }
-                    else
-                    {
-                        msg_Dbg( p_vout, "audio volume: operation not supported" );
-                    }
+                    val.i_int |= KEY_MODIFIER_ALT;
                 }
-                break;
-
-             default:
-                break;
+                var_Set( p_vout->p_libvlc, "key-pressed", val );
             }
-            break;
 
         default:
             break;
@@ -528,7 +536,14 @@ static int Manage( vout_thread_t *p_vout )
     /* Fullscreen change */
     if( p_vout->i_changes & VOUT_FULLSCREEN_CHANGE )
     {
-        p_vout->b_fullscreen = ! p_vout->b_fullscreen;
+        vlc_value_t val_fs;
+
+        /* Update the object variable and trigger callback */
+        val_fs.b_bool = !p_vout->b_fullscreen;
+        p_vout->b_fullscreen = !p_vout->b_fullscreen;
+        var_Set( p_vout, "fullscreen", val_fs );
+
+        /*TODO: add the "always on top" code here !*/
 
         p_vout->p_sys->b_cursor_autohidden = 0;
         SDL_ShowCursor( p_vout->p_sys->b_cursor &&
@@ -538,9 +553,26 @@ static int Manage( vout_thread_t *p_vout )
         p_vout->i_changes |= VOUT_SIZE_CHANGE;
     }
 
-    /*
-     * Size change
-     */
+    /* Crop or Aspect Ratio Changes */
+    if( p_vout->i_changes & VOUT_CROP_CHANGE ||
+        p_vout->i_changes & VOUT_ASPECT_CHANGE )
+    {
+        p_vout->i_changes &= ~VOUT_CROP_CHANGE;
+        p_vout->i_changes &= ~VOUT_ASPECT_CHANGE;
+
+        p_vout->fmt_out.i_x_offset = p_vout->fmt_in.i_x_offset;
+        p_vout->fmt_out.i_y_offset = p_vout->fmt_in.i_y_offset;
+        p_vout->fmt_out.i_visible_width = p_vout->fmt_in.i_visible_width;
+        p_vout->fmt_out.i_visible_height = p_vout->fmt_in.i_visible_height;
+        p_vout->fmt_out.i_aspect = p_vout->fmt_in.i_aspect;
+        p_vout->fmt_out.i_sar_num = p_vout->fmt_in.i_sar_num;
+        p_vout->fmt_out.i_sar_den = p_vout->fmt_in.i_sar_den;
+        p_vout->output.i_aspect = p_vout->fmt_in.i_aspect;
+
+        p_vout->i_changes |= VOUT_SIZE_CHANGE;
+    }
+
+    /* Size change */
     if( p_vout->i_changes & VOUT_SIZE_CHANGE )
     {
         msg_Dbg( p_vout, "video display resized (%dx%d)",
@@ -553,7 +585,6 @@ static int Manage( vout_thread_t *p_vout )
          * we can handle rescaling ourselves */
         if( p_vout->p_sys->p_overlay != NULL )
             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
-
     }
 
     /* Pointer change */
@@ -565,9 +596,77 @@ static int Manage( vout_thread_t *p_vout )
         SDL_ShowCursor( 0 );
     }
 
+    vlc_mutex_unlock( &p_vout->p_sys->lock );
+
     return VLC_SUCCESS;
 }
 
+/*****************************************************************************
+ * Key events handling
+ *****************************************************************************/
+static struct
+{
+    SDLKey sdl_key;
+    int i_vlckey;
+} sdlkeys_to_vlckeys[] =
+{
+    { SDLK_F1,  KEY_F1 },
+    { SDLK_F2,  KEY_F2 },
+    { SDLK_F3,  KEY_F3 },
+    { SDLK_F4,  KEY_F4 },
+    { SDLK_F5,  KEY_F5 },
+    { SDLK_F6,  KEY_F6 },
+    { SDLK_F7,  KEY_F7 },
+    { SDLK_F8,  KEY_F8 },
+    { SDLK_F9,  KEY_F9 },
+    { SDLK_F10, KEY_F10 },
+    { SDLK_F11, KEY_F11 },
+    { SDLK_F12, KEY_F12 },
+
+    { SDLK_RETURN, KEY_ENTER },
+    { SDLK_KP_ENTER, KEY_ENTER },
+    { SDLK_SPACE, KEY_SPACE },
+    { SDLK_ESCAPE, KEY_ESC },
+
+    { SDLK_MENU, KEY_MENU },
+    { SDLK_LEFT, KEY_LEFT },
+    { SDLK_RIGHT, KEY_RIGHT },
+    { SDLK_UP, KEY_UP },
+    { SDLK_DOWN, KEY_DOWN },
+
+    { SDLK_HOME, KEY_HOME },
+    { SDLK_END, KEY_END },
+    { SDLK_PAGEUP, KEY_PAGEUP },
+    { SDLK_PAGEDOWN,  KEY_PAGEDOWN },
+
+    { SDLK_INSERT, KEY_INSERT },
+    { SDLK_DELETE, KEY_DELETE },
+    /*TODO: find a equivalent for SDL 
+    { , KEY_MEDIA_NEXT_TRACK }
+    { , KEY_MEDIA_PREV_TRACK }
+    { , KEY_VOLUME_MUTE }
+    { , KEY_VOLUME_DOWN }
+    { , KEY_VOLUME_UP }
+    { , KEY_MEDIA_PLAY_PAUSE }
+    { , KEY_MEDIA_PLAY_PAUSE }*/
+
+    { 0, 0 }
+};
+
+static int ConvertKey( SDLKey sdl_key )
+{
+    int i;
+    for( i=0; sdlkeys_to_vlckeys[i].sdl_key != 0; i++ )
+    {
+        if( sdlkeys_to_vlckeys[i].sdl_key == sdl_key )
+        {
+            return sdlkeys_to_vlckeys[i].i_vlckey;
+        }
+    }
+    return 0;
+}
+
+
 /*****************************************************************************
  * Display: displays previously rendered output
  *****************************************************************************
@@ -575,9 +674,11 @@ static int Manage( vout_thread_t *p_vout )
  *****************************************************************************/
 static void Display( vout_thread_t *p_vout, picture_t *p_pic )
 {
-    int x, y, w, h;
+    unsigned int x, y, w, h;
     SDL_Rect disp;
 
+    vlc_mutex_lock( &p_vout->p_sys->lock );
+
     vout_PlacePicture( p_vout, p_vout->p_sys->i_width, p_vout->p_sys->i_height,
                        &x, &y, &w, &h );
     disp.x = x;
@@ -597,6 +698,8 @@ static void Display( vout_thread_t *p_vout, picture_t *p_pic )
         SDL_DisplayYUVOverlay( p_pic->p_sys->p_overlay , &disp );
         SDL_LockYUVOverlay( p_pic->p_sys->p_overlay);
     }
+
+    vlc_mutex_unlock( &p_vout->p_sys->lock );
 }
 
 /* following functions are local */
@@ -614,6 +717,8 @@ static int OpenDisplay( vout_thread_t *p_vout )
 
     /* SDL fucked up fourcc definitions on bigendian machines */
     uint32_t i_sdl_chroma;
+    char *psz_chroma = NULL;
+    uint32_t i_chroma = 0;
 
     /* Set main window's size */
     p_vout->p_sys->i_width = p_vout->b_fullscreen ? p_vout->output.i_width :
@@ -645,37 +750,59 @@ static int OpenDisplay( vout_thread_t *p_vout )
 
     SDL_LockSurface( p_vout->p_sys->p_display );
 
+    if( ( psz_chroma = config_GetPsz( p_vout, "sdl-chroma" ) ) )
+    {
+        if( strlen( psz_chroma ) >= 4 )
+        {
+            memcpy(&i_chroma, psz_chroma, 4);
+            msg_Dbg( p_vout, "Forcing chroma to 0x%.8x (%4.4s)", i_chroma, (char*)&i_chroma );
+        }
+        else
+        {
+            free( psz_chroma );
+            psz_chroma = NULL;
+        }
+    }
+
     /* Choose the chroma we will try first. */
-    switch( p_vout->render.i_chroma )
+    do
     {
-        case VLC_FOURCC('Y','U','Y','2'):
-        case VLC_FOURCC('Y','U','N','V'):
-            p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2');
-            i_sdl_chroma = SDL_YUY2_OVERLAY;
-            break;
-        case VLC_FOURCC('U','Y','V','Y'):
-        case VLC_FOURCC('U','Y','N','V'):
-        case VLC_FOURCC('Y','4','2','2'):
-            p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y');
-            i_sdl_chroma = SDL_UYVY_OVERLAY;
-            break;
-        case VLC_FOURCC('Y','V','Y','U'):
-            p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U');
-            i_sdl_chroma = SDL_YVYU_OVERLAY;
-            break;
-        case VLC_FOURCC('Y','V','1','2'):
-        case VLC_FOURCC('I','4','2','0'):
-        case VLC_FOURCC('I','Y','U','V'):
-        default:
-            p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2');
-            i_sdl_chroma = SDL_YV12_OVERLAY;
-            break;
+        if( !psz_chroma ) i_chroma = 0;
+        switch( i_chroma ? i_chroma : p_vout->render.i_chroma )
+        {
+            case VLC_FOURCC('Y','U','Y','2'):
+            case VLC_FOURCC('Y','U','N','V'):
+                p_vout->output.i_chroma = VLC_FOURCC('Y','U','Y','2');
+                i_sdl_chroma = SDL_YUY2_OVERLAY;
+                break;
+            case VLC_FOURCC('U','Y','V','Y'):
+            case VLC_FOURCC('U','Y','N','V'):
+            case VLC_FOURCC('Y','4','2','2'):
+                p_vout->output.i_chroma = VLC_FOURCC('U','Y','V','Y');
+                i_sdl_chroma = SDL_UYVY_OVERLAY;
+                break;
+            case VLC_FOURCC('Y','V','Y','U'):
+                p_vout->output.i_chroma = VLC_FOURCC('Y','V','Y','U');
+                i_sdl_chroma = SDL_YVYU_OVERLAY;
+                break;
+            case VLC_FOURCC('Y','V','1','2'):
+            case VLC_FOURCC('I','4','2','0'):
+            case VLC_FOURCC('I','Y','U','V'):
+            default:
+                p_vout->output.i_chroma = VLC_FOURCC('Y','V','1','2');
+                i_sdl_chroma = SDL_YV12_OVERLAY;
+                break;
+        }
+        free( psz_chroma ); psz_chroma = NULL;
+
+        p_vout->p_sys->p_overlay =
+            SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma,
+                                  p_vout->p_sys->p_display );
+        /* FIXME: if the first overlay we find is software, don't stop,
+         * because we may find a hardware one later ... */
     }
+    while( i_chroma && !p_vout->p_sys->p_overlay );
 
-    p_vout->p_sys->p_overlay =
-        SDL_CreateYUVOverlay( 32, 32, i_sdl_chroma, p_vout->p_sys->p_display );
-    /* FIXME: if the first overlay we find is software, don't stop,
-     * because we may find a hardware one later ... */
 
     /* If this best choice failed, fall back to other chromas */
     if( p_vout->p_sys->p_overlay == NULL )
@@ -929,7 +1056,7 @@ static void SetPalette( vout_thread_t *p_vout,
     /* Set palette */
     if( SDL_SetColors( p_vout->p_sys->p_display, colors, 0, 256 ) == 0 )
     {
-        msg_Err( p_vout, "failed setting palette" );
+        msg_Err( p_vout, "failed to set palette" );
     }
 }