Yet more cloning fixes for PHP. *sigh*

[xml-template] / php / xml-template.php

diff --git a/php/xml-template.php b/php/xml-template.php
index dc28a2d0040bcbc2132e123f375c50f4fe9102b2..1a7434ae99947db0d62c56f411ea10cdd8f30484 100644 (file)
--- a/php/xml-template.php
+++ b/php/xml-template.php
@@ -18,12 +18,10 @@ function XML_Template_process($node, $obj, $clean = 1)
                        $obj = $obj->document_element();
                }
 
-               $newobj = $obj->clone_node(true);
+               $newobj = own_clone_node($obj, $node->owner_document());
                $node->append_child($newobj);
 
-               if ($clean) {
-                       clean($newobj);
-               }
+               XML_Template_process($newobj, array(), $clean);
        } else if (!is_array($obj)) {                         # overwrite
                foreach ($node->child_nodes() as $child) {
                        $node->remove_child($child);
@@ -42,7 +40,8 @@ function XML_Template_process($node, $obj, $clean = 1)
                                                if ($attr->namespace_uri() == 'http://template.sesse.net/' && $attr->name() == 'id') {
                                                        $id = $attr->value();
                                                        if ($clean) {
-                                                               $child->remove_attribute($attr->name());
+                                                               // FIXME: this won't work since we're not in the right namespace
+                                                               // $child->remove_attribute($attr->name());
                                                        }
                                                }
                                        }
@@ -81,7 +80,7 @@ function XML_Template_process($node, $obj, $clean = 1)
                }
 
                foreach ($obj as $instance) {
-                       $newnode = $frag->clone_node(true);
+                       $newnode = own_clone_node($frag, $frag->owner_document());
                        $node->append_child($newnode);
                        XML_Template_process($newnode, $instance, $clean);
                        if ($clean) {
@@ -100,8 +99,6 @@ function XML_Template_process($node, $obj, $clean = 1)
                        }
                        $node->remove_child($child);
                }       
-
-               return;
        }
 
        if ($clean) {
@@ -140,6 +137,40 @@ function XML_Template_alternate($tag, $array, $elems)
 
        return $array;
 }
+               
+# Ideally, this would be "return $obj->clone_node(true)". But surprise, surprise,
+# PHP is buggy (at least PHP4); it removes the prefix information from all attributes
+# during a clone. IOW, we'll have to clone evverything ourselves.
+function own_clone_node($node, $doc)
+{
+       // we only need these two
+       if ($node->node_type() == XML_ELEMENT_NODE) {
+               $nsuri = $node->namespace_uri();
+               if (isset($nsuri)) {
+                       $newnode = $doc->create_element_ns($node->namespace_uri(), $node->node_name(), $node->prefix());
+               } else {
+                       $newnode = $doc->create_element($node->node_name());
+               }
+               
+               $attrs = $node->attributes();
+               if (isset($attrs)) {
+                       foreach ($node->attributes() as $attr) {
+                               $attr2 = $doc->create_attribute($attr->name(), $attr->value());
+                               $nsuri = $attr->namespace_uri();
+                               if (isset($nsuri)) {
+                                       $attr2->set_namespace($nsuri, $attr->prefix());
+                               }
+                               $newnode->append_child($attr2);
+                       }
+               }
+               foreach ($node->child_nodes() as $child) {
+                       $newnode->append_child(own_clone_node($child, $doc));
+               }
+               return $newnode;
+       } else {
+               return $node->clone_node(true);
+       }
+}
 
 function is_associative_array($arr)
 {