]> git.sesse.net Git - nageru/blobdiff - player.cpp
Fix fades that are not between clips with the same start pts.
[nageru] / player.cpp
index 0e5b225798988be9c9c8615c56b8ca8c74b24091..b3cc76997e74b6e39f632088509315d31d64fdd9 100644 (file)
@@ -55,16 +55,29 @@ void Player::thread_func(bool also_output_to_stream)
        double next_clip_fade_time = -1.0;
 
        for ( ;; ) {
+               bool clip_ready;
+               steady_clock::time_point before_sleep = steady_clock::now();
+
                // Wait until we're supposed to play something.
                {
                        unique_lock<mutex> lock(queue_state_mu);
-                       new_clip_changed.wait(lock, [this]{
+                       clip_ready = new_clip_changed.wait_for(lock, milliseconds(100), [this]{
                                return new_clip_ready && current_clip.pts_in != -1;
                        });
                        new_clip_ready = false;
                        playing = true;
                }
 
+               steady_clock::duration time_slept = steady_clock::now() - before_sleep;
+               pts += duration_cast<duration<size_t, TimebaseRatio>>(time_slept).count();
+
+               if (!clip_ready) {
+                       if (video_stream != nullptr) {
+                               video_stream->schedule_refresh_frame(pts);
+                       }
+                       continue;
+               }
+
                Clip clip;
                unsigned stream_idx;
                {
@@ -72,12 +85,14 @@ void Player::thread_func(bool also_output_to_stream)
                        clip = current_clip;
                        stream_idx = current_stream_idx;
                }
-got_clip:
                steady_clock::time_point origin = steady_clock::now();
                int64_t in_pts_origin = clip.pts_in;
+got_clip:
                int64_t out_pts_origin = pts;
 
                // Start playing exactly at a frame.
+               // TODO: Snap secondary (fade-to) clips in the same fashion
+               // so that we don't get jank here).
                {
                        lock_guard<mutex> lock(frame_mu);
 
@@ -93,6 +108,7 @@ got_clip:
                // TODO: Lock to a rational multiple of the frame rate if possible.
                double speed = 0.5;
 
+               int64_t in_pts_start_next_clip = -1;
                for (int frameno = 0; ; ++frameno) {  // Ends when the clip ends.
                        double out_pts = out_pts_origin + TIMEBASE * frameno / output_framerate;
                        steady_clock::time_point next_frame_start =
@@ -116,23 +132,34 @@ got_clip:
 
                                        double duration_next_clip = (next_clip.pts_out - next_clip.pts_in) / TIMEBASE / speed;
                                        next_clip_fade_time = std::min(time_left_this_clip, duration_next_clip);
-                                       fprintf(stderr, "decided on %.3f seconds fade time [%f %f]\n", next_clip_fade_time, time_left_this_clip, duration_next_clip);
+                                       in_pts_start_next_clip = next_clip.pts_in + lrint(next_clip_fade_time * TIMEBASE * speed);
                                }
                        }
 
-                       // TODO: If more than half-way through the fade, interpolate the next clip
-                       // instead of the current one.
-
+                       int primary_stream_idx = stream_idx;
                        int secondary_stream_idx = -1;
-                       int64_t secondary_pts = -1;
                        float fade_alpha = 0.0f;
                        if (got_next_clip) {
+                               secondary_stream_idx = next_clip.stream_idx;
+                               fade_alpha = 1.0f - time_left_this_clip / next_clip_fade_time;
+
+                               // If more than half-way through the fade, interpolate the next clip
+                               // instead of the current one, since it's more visible.
+                               if (fade_alpha >= 0.5f) {
+                                       swap(primary_stream_idx, secondary_stream_idx);
+                                       fade_alpha = 1.0f - fade_alpha;
+                               }
+                       }
+
+                       int64_t secondary_pts = -1;
+                       if (got_next_clip) {
+                               int64_t in_pts_secondary = lrint(next_clip.pts_in + TIMEBASE * frameno * speed / output_framerate);
                                int64_t in_pts_lower, in_pts_upper;
-                               bool ok = find_surrounding_frames(in_pts, next_clip.stream_idx, &in_pts_lower, &in_pts_upper);
+                               bool ok = find_surrounding_frames(in_pts_secondary, secondary_stream_idx, &in_pts_lower, &in_pts_upper);
                                if (ok) {
-                                       secondary_stream_idx = next_clip.stream_idx;
                                        secondary_pts = in_pts_lower;
-                                       fade_alpha = 1.0f - time_left_this_clip / next_clip_fade_time;
+                               } else {
+                                       secondary_stream_idx = -1;
                                }
                        }
 
@@ -144,7 +171,7 @@ got_clip:
                        }
 
                        int64_t in_pts_lower, in_pts_upper;
-                       bool ok = find_surrounding_frames(in_pts, stream_idx, &in_pts_lower, &in_pts_upper);
+                       bool ok = find_surrounding_frames(in_pts, primary_stream_idx, &in_pts_lower, &in_pts_upper);
                        if (!ok || in_pts_upper >= clip.pts_out) {
                                break;
                        }
@@ -164,12 +191,12 @@ got_clip:
                        }
 
                        if (in_pts_lower == in_pts_upper) {
-                               destination->setFrame(stream_idx, in_pts_lower, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
+                               destination->setFrame(primary_stream_idx, in_pts_lower, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
                                if (video_stream != nullptr) {
                                        if (secondary_stream_idx == -1) {
-                                               video_stream->schedule_original_frame(pts, stream_idx, in_pts_lower);
+                                               video_stream->schedule_original_frame(pts, primary_stream_idx, in_pts_lower);
                                        } else {
-                                               video_stream->schedule_faded_frame(pts, stream_idx, in_pts_lower, secondary_stream_idx, secondary_pts, fade_alpha);
+                                               video_stream->schedule_faded_frame(pts, primary_stream_idx, in_pts_lower, secondary_stream_idx, secondary_pts, fade_alpha);
                                        }
                                }
                                continue;
@@ -177,16 +204,17 @@ got_clip:
 
                        // Snap to input frame: If we can do so with less than 1% jitter
                        // (ie., move less than 1% of an _output_ frame), do so.
+                       // TODO: Snap secondary (fade-to) clips in the same fashion.
                        bool snapped = false;
                        for (int64_t snap_pts : { in_pts_lower, in_pts_upper }) {
                                double snap_pts_as_frameno = (snap_pts - in_pts_origin) * output_framerate / TIMEBASE / speed;
                                if (fabs(snap_pts_as_frameno - frameno) < 0.01) {
-                                       destination->setFrame(stream_idx, snap_pts, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
+                                       destination->setFrame(primary_stream_idx, snap_pts, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
                                        if (video_stream != nullptr) {
                                                if (secondary_stream_idx == -1) {
-                                                       video_stream->schedule_original_frame(pts, stream_idx, snap_pts);
+                                                       video_stream->schedule_original_frame(pts, primary_stream_idx, snap_pts);
                                                } else {
-                                                       video_stream->schedule_faded_frame(pts, stream_idx, snap_pts, secondary_stream_idx, secondary_pts, fade_alpha);
+                                                       video_stream->schedule_faded_frame(pts, primary_stream_idx, snap_pts, secondary_stream_idx, secondary_pts, fade_alpha);
                                                }
                                        }
                                        in_pts_origin += snap_pts - in_pts;
@@ -209,12 +237,12 @@ got_clip:
                        if (video_stream == nullptr) {
                                // Previews don't do any interpolation.
                                assert(secondary_stream_idx == -1);
-                               destination->setFrame(stream_idx, in_pts_lower, /*interpolated=*/false, fade_alpha);
+                               destination->setFrame(primary_stream_idx, in_pts_lower, /*interpolated=*/false);
                        } else {
                                // Calculate the interpolated frame. When it's done, the destination
                                // will be unblocked.
-                               destination->setFrame(stream_idx, pts, /*interpolated=*/true, secondary_stream_idx, secondary_pts, fade_alpha);
-                               video_stream->schedule_interpolated_frame(pts, stream_idx, in_pts_lower, in_pts_upper, alpha, secondary_stream_idx, secondary_pts, fade_alpha);
+                               destination->setFrame(primary_stream_idx, pts, /*interpolated=*/true, secondary_stream_idx, secondary_pts, fade_alpha);
+                               video_stream->schedule_interpolated_frame(pts, primary_stream_idx, in_pts_lower, in_pts_upper, alpha, secondary_stream_idx, secondary_pts, fade_alpha);
                        }
                }
 
@@ -225,6 +253,7 @@ got_clip:
                        next_clip = next_clip_callback();
                        if (next_clip.pts_in != -1) {
                                got_next_clip = true;
+                               in_pts_start_next_clip = next_clip.pts_in;
                        }
                }
 
@@ -236,6 +265,10 @@ got_clip:
                                done_callback();
                        }
                        got_next_clip = false;
+
+                       // Start the next clip from the point where the fade went out.
+                       origin = steady_clock::now();
+                       in_pts_origin = in_pts_start_next_clip;
                        goto got_clip;
                }