]> git.sesse.net Git - nageru/blobdiff - player.cpp
Fix fades that are not between clips with the same start pts.
[nageru] / player.cpp
index bb2377a643c729cd4c5c8703140f2a4054e30a0b..b3cc76997e74b6e39f632088509315d31d64fdd9 100644 (file)
@@ -50,18 +50,34 @@ void Player::thread_func(bool also_output_to_stream)
 
        constexpr double output_framerate = 60000.0 / 1001.0;  // FIXME: make configurable
        int64_t pts = 0;
+       Clip next_clip;
+       bool got_next_clip = false;
+       double next_clip_fade_time = -1.0;
 
        for ( ;; ) {
+               bool clip_ready;
+               steady_clock::time_point before_sleep = steady_clock::now();
+
                // Wait until we're supposed to play something.
                {
                        unique_lock<mutex> lock(queue_state_mu);
-                       new_clip_changed.wait(lock, [this]{
+                       clip_ready = new_clip_changed.wait_for(lock, milliseconds(100), [this]{
                                return new_clip_ready && current_clip.pts_in != -1;
                        });
                        new_clip_ready = false;
                        playing = true;
                }
 
+               steady_clock::duration time_slept = steady_clock::now() - before_sleep;
+               pts += duration_cast<duration<size_t, TimebaseRatio>>(time_slept).count();
+
+               if (!clip_ready) {
+                       if (video_stream != nullptr) {
+                               video_stream->schedule_refresh_frame(pts);
+                       }
+                       continue;
+               }
+
                Clip clip;
                unsigned stream_idx;
                {
@@ -71,9 +87,12 @@ void Player::thread_func(bool also_output_to_stream)
                }
                steady_clock::time_point origin = steady_clock::now();
                int64_t in_pts_origin = clip.pts_in;
+got_clip:
                int64_t out_pts_origin = pts;
 
                // Start playing exactly at a frame.
+               // TODO: Snap secondary (fade-to) clips in the same fashion
+               // so that we don't get jank here).
                {
                        lock_guard<mutex> lock(frame_mu);
 
@@ -89,7 +108,7 @@ void Player::thread_func(bool also_output_to_stream)
                // TODO: Lock to a rational multiple of the frame rate if possible.
                double speed = 0.5;
 
-               bool aborted = false;
+               int64_t in_pts_start_next_clip = -1;
                for (int frameno = 0; ; ++frameno) {  // Ends when the clip ends.
                        double out_pts = out_pts_origin + TIMEBASE * frameno / output_framerate;
                        steady_clock::time_point next_frame_start =
@@ -104,8 +123,55 @@ void Player::thread_func(bool also_output_to_stream)
                                continue;
                        }
 
+                       double time_left_this_clip = double(clip.pts_out - in_pts) / TIMEBASE / speed;
+                       if (!got_next_clip && next_clip_callback != nullptr && time_left_this_clip <= clip.fade_time_seconds) {
+                               // Find the next clip so that we can begin a fade.
+                               next_clip = next_clip_callback();
+                               if (next_clip.pts_in != -1) {
+                                       got_next_clip = true;
+
+                                       double duration_next_clip = (next_clip.pts_out - next_clip.pts_in) / TIMEBASE / speed;
+                                       next_clip_fade_time = std::min(time_left_this_clip, duration_next_clip);
+                                       in_pts_start_next_clip = next_clip.pts_in + lrint(next_clip_fade_time * TIMEBASE * speed);
+                               }
+                       }
+
+                       int primary_stream_idx = stream_idx;
+                       int secondary_stream_idx = -1;
+                       float fade_alpha = 0.0f;
+                       if (got_next_clip) {
+                               secondary_stream_idx = next_clip.stream_idx;
+                               fade_alpha = 1.0f - time_left_this_clip / next_clip_fade_time;
+
+                               // If more than half-way through the fade, interpolate the next clip
+                               // instead of the current one, since it's more visible.
+                               if (fade_alpha >= 0.5f) {
+                                       swap(primary_stream_idx, secondary_stream_idx);
+                                       fade_alpha = 1.0f - fade_alpha;
+                               }
+                       }
+
+                       int64_t secondary_pts = -1;
+                       if (got_next_clip) {
+                               int64_t in_pts_secondary = lrint(next_clip.pts_in + TIMEBASE * frameno * speed / output_framerate);
+                               int64_t in_pts_lower, in_pts_upper;
+                               bool ok = find_surrounding_frames(in_pts_secondary, secondary_stream_idx, &in_pts_lower, &in_pts_upper);
+                               if (ok) {
+                                       secondary_pts = in_pts_lower;
+                               } else {
+                                       secondary_stream_idx = -1;
+                               }
+                       }
+
+                       if (progress_callback != nullptr) {
+                               // NOTE: None of this will take into account any snapping done below.
+                               double played_this_clip = double(in_pts - clip.pts_in) / TIMEBASE / speed;
+                               double total_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / speed;
+                               progress_callback(played_this_clip, total_length);
+                       }
+
                        int64_t in_pts_lower, in_pts_upper;
-                       bool ok = find_surrounding_frames(in_pts, stream_idx, &in_pts_lower, &in_pts_upper);
+                       bool ok = find_surrounding_frames(in_pts, primary_stream_idx, &in_pts_lower, &in_pts_upper);
                        if (!ok || in_pts_upper >= clip.pts_out) {
                                break;
                        }
@@ -124,38 +190,39 @@ void Player::thread_func(bool also_output_to_stream)
                                }
                        }
 
-                       if (progress_callback != nullptr) {
-                               // NOTE: None of this will take into account any snapping done below.
-                               double played_this_clip = double(in_pts - clip.pts_in) / TIMEBASE / speed;
-                               double total_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / speed;
-                               progress_callback(played_this_clip, total_length);
-                       }
-
                        if (in_pts_lower == in_pts_upper) {
-                               destination->setFrame(stream_idx, in_pts_lower, /*interpolated=*/false);
+                               destination->setFrame(primary_stream_idx, in_pts_lower, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
                                if (video_stream != nullptr) {
-                                       video_stream->schedule_original_frame(lrint(out_pts), stream_idx, in_pts_lower);
+                                       if (secondary_stream_idx == -1) {
+                                               video_stream->schedule_original_frame(pts, primary_stream_idx, in_pts_lower);
+                                       } else {
+                                               video_stream->schedule_faded_frame(pts, primary_stream_idx, in_pts_lower, secondary_stream_idx, secondary_pts, fade_alpha);
+                                       }
                                }
                                continue;
                        }
 
                        // Snap to input frame: If we can do so with less than 1% jitter
                        // (ie., move less than 1% of an _output_ frame), do so.
-                       double in_pts_lower_as_frameno = (in_pts_lower - in_pts_origin) * output_framerate / TIMEBASE / speed;
-                       double in_pts_upper_as_frameno = (in_pts_upper - in_pts_origin) * output_framerate / TIMEBASE / speed;
-                       if (fabs(in_pts_lower_as_frameno - frameno) < 0.01) {
-                               destination->setFrame(stream_idx, in_pts_lower, /*interpolated=*/false);
-                               if (video_stream != nullptr) {
-                                       video_stream->schedule_original_frame(lrint(out_pts), stream_idx, in_pts_lower);
+                       // TODO: Snap secondary (fade-to) clips in the same fashion.
+                       bool snapped = false;
+                       for (int64_t snap_pts : { in_pts_lower, in_pts_upper }) {
+                               double snap_pts_as_frameno = (snap_pts - in_pts_origin) * output_framerate / TIMEBASE / speed;
+                               if (fabs(snap_pts_as_frameno - frameno) < 0.01) {
+                                       destination->setFrame(primary_stream_idx, snap_pts, /*interpolated=*/false, secondary_stream_idx, secondary_pts, fade_alpha);
+                                       if (video_stream != nullptr) {
+                                               if (secondary_stream_idx == -1) {
+                                                       video_stream->schedule_original_frame(pts, primary_stream_idx, snap_pts);
+                                               } else {
+                                                       video_stream->schedule_faded_frame(pts, primary_stream_idx, snap_pts, secondary_stream_idx, secondary_pts, fade_alpha);
+                                               }
+                                       }
+                                       in_pts_origin += snap_pts - in_pts;
+                                       snapped = true;
+                                       break;
                                }
-                               in_pts_origin += in_pts_lower - in_pts;
-                               continue;
-                       } else if (fabs(in_pts_upper_as_frameno - frameno) < 0.01) {
-                               destination->setFrame(stream_idx, in_pts_upper, /*interpolated=*/false);
-                               if (video_stream != nullptr) {
-                                       video_stream->schedule_original_frame(lrint(out_pts), stream_idx, in_pts_upper);
-                               }
-                               in_pts_origin += in_pts_upper - in_pts;
+                       }
+                       if (snapped) {
                                continue;
                        }
 
@@ -169,20 +236,47 @@ void Player::thread_func(bool also_output_to_stream)
 
                        if (video_stream == nullptr) {
                                // Previews don't do any interpolation.
-                               destination->setFrame(stream_idx, in_pts_lower, /*interpolated=*/false);
+                               assert(secondary_stream_idx == -1);
+                               destination->setFrame(primary_stream_idx, in_pts_lower, /*interpolated=*/false);
                        } else {
                                // Calculate the interpolated frame. When it's done, the destination
                                // will be unblocked.
-                               destination->setFrame(stream_idx, lrint(out_pts), /*interpolated=*/true);
-                               video_stream->schedule_interpolated_frame(lrint(out_pts), stream_idx, in_pts_lower, in_pts_upper, alpha);
+                               destination->setFrame(primary_stream_idx, pts, /*interpolated=*/true, secondary_stream_idx, secondary_pts, fade_alpha);
+                               video_stream->schedule_interpolated_frame(pts, primary_stream_idx, in_pts_lower, in_pts_upper, alpha, secondary_stream_idx, secondary_pts, fade_alpha);
+                       }
+               }
+
+               // The clip ended.
+
+               // Last-ditch effort to get the next clip (if e.g. the fade time was zero seconds).
+               if (!got_next_clip && next_clip_callback != nullptr) {
+                       next_clip = next_clip_callback();
+                       if (next_clip.pts_in != -1) {
+                               got_next_clip = true;
+                               in_pts_start_next_clip = next_clip.pts_in;
                        }
                }
 
+               // Switch to next clip if we got it.
+               if (got_next_clip) {
+                       clip = next_clip;
+                       stream_idx = next_clip.stream_idx;  // Override is used for previews only, and next_clip is used for live ony.
+                       if (done_callback != nullptr) {
+                               done_callback();
+                       }
+                       got_next_clip = false;
+
+                       // Start the next clip from the point where the fade went out.
+                       origin = steady_clock::now();
+                       in_pts_origin = in_pts_start_next_clip;
+                       goto got_clip;
+               }
+
                {
                        unique_lock<mutex> lock(queue_state_mu);
                        playing = false;
                }
-               if (done_callback != nullptr && !aborted) {
+               if (done_callback != nullptr) {
                        done_callback();
                }
        }