]> git.sesse.net Git - vlc/blobdiff - plugins/sdl/vout_sdl.c
* Ported Glide and MGA plugins to the new module API. MGA never worked,
[vlc] / plugins / sdl / vout_sdl.c
index 42aa5dc8ecb64b7da83581bd3f8a75e4ee5a1897..73a8a24137383c4201a7810f59a8f287ca9177c9 100644 (file)
@@ -3,7 +3,9 @@
  *****************************************************************************
  * Copyright (C) 1998, 1999, 2000 VideoLAN
  *
- * Authors:
+ * Authors: Samuel Hocevar <sam@zoy.org>
+ *          Pierre Baillet <oct@zoy.org>
+ *          Arnaud de Bossoreille de Ribou <bozo@via.ecp.fr>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -20,6 +22,9 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
  *****************************************************************************/
 
+#define MODULE_NAME sdl
+#include "modules_inner.h"
+
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
 #include "common.h"
 #include "threads.h"
 #include "mtime.h"
-#include "plugins.h"
+#include "tests.h"
+#include "modules.h"
 
 #include "video.h"
 #include "video_output.h"
 
 #include "intf_msg.h"
+#include "interface.h"
+/* FIXME: get rid of this */
+#include "keystrokes.h"
+#include "main.h"
+
+/*****************************************************************************
+ * FIXME: this file is ...                                                   *
+ *                                                                           *
+ *              XXX   XXX     FIXME     XXX     XXX   XXX   XXX              *
+ *              XXX   XXX   XXX   XXX   XXX     XXX   XXX   XXX              *
+ *              XXX   XXX   XXX         XXX       FIXME     XXX              *
+ *              XXX   XXX   XXX  TODO   XXX        XXX      XXX              *
+ *              XXX   XXX   XXX   XXX   XXX        XXX                       *
+ *                FIXME       FIXME       FIXME    XXX      XXX              *
+ *                                                                           *
+ *****************************************************************************/
 
 /*****************************************************************************
  * vout_sys_t: video output SDL method descriptor
@@ -55,183 +77,403 @@ typedef struct vout_sys_s
     SDL_Surface *   p_display;                             /* display device */
     SDL_Overlay *   p_overlay;                             /* overlay device */
     boolean_t   b_fullscreen;
+    boolean_t   b_overlay;
+    boolean_t   b_cursor;
     boolean_t   b_reopen_display;
-    Uint8   *   p_buffer[2];
-                                                     /* Buffers informations */
-    boolean_t   b_must_acquire;           /* must be acquired before writing */
-}   vout_sys_t;
+    Uint8   *   p_sdl_buf[2];                          /* Buffer information */
+} vout_sys_t;
+
+/*****************************************************************************
+ * Local prototypes.
+ *****************************************************************************/
+static int  vout_Probe     ( probedata_t *p_data );
+static int  vout_Create    ( struct vout_thread_s * );
+static int  vout_Init      ( struct vout_thread_s * );
+static void vout_End       ( struct vout_thread_s * );
+static void vout_Destroy   ( struct vout_thread_s * );
+static int  vout_Manage    ( struct vout_thread_s * );
+static void vout_Display   ( struct vout_thread_s * );
+static void vout_SetPalette( p_vout_thread_t p_vout, u16 *red, u16 *green,
+                             u16 *blue, u16 *transp );
+
+static int  SDLOpenDisplay      ( vout_thread_t *p_vout );
+static void SDLCloseDisplay     ( vout_thread_t *p_vout );
 
 /*****************************************************************************
- * Local prototypes
+ * Functions exported as capabilities. They are declared as static so that
+ * we don't pollute the namespace too much.
  *****************************************************************************/
-static int     SDLOpenDisplay   ( vout_thread_t *p_vout );
-static void    SDLCloseDisplay  ( vout_thread_t *p_vout );
+void _M( vout_getfunctions )( function_list_t * p_function_list )
+{
+    p_function_list->pf_probe = vout_Probe;
+    p_function_list->functions.vout.pf_create     = vout_Create;
+    p_function_list->functions.vout.pf_init       = vout_Init;
+    p_function_list->functions.vout.pf_end        = vout_End;
+    p_function_list->functions.vout.pf_destroy    = vout_Destroy;
+    p_function_list->functions.vout.pf_manage     = vout_Manage;
+    p_function_list->functions.vout.pf_display    = vout_Display;
+    p_function_list->functions.vout.pf_setpalette = vout_SetPalette;
+}
 
 /*****************************************************************************
- * vout_SDLCreate: allocate SDL video thread output method
+ * vout_Probe: probe the video driver and return a score
+ *****************************************************************************
+ * This function tries to initialize SDL and returns a score to the
+ * plugin manager so that it can select the best plugin.
+ *****************************************************************************/
+static int vout_Probe( probedata_t *p_data )
+{
+    if( TestMethod( VOUT_METHOD_VAR, "sdl" ) )
+    {
+        return( 999 );
+    }
+
+    return( 100 );
+}
+
+/*****************************************************************************
+ * vout_Create: allocate SDL video thread output method
  *****************************************************************************
  * This function allocate and initialize a SDL vout method. It uses some of the
  * vout properties to choose the correct mode, and change them according to the
  * mode actually used.
  *****************************************************************************/
-int vout_SDLCreate( vout_thread_t *p_vout, char *psz_display,
-                    int i_root_window, void *p_data )
+static int vout_Create( vout_thread_t *p_vout )
 {
     /* Allocate structure */
     p_vout->p_sys = malloc( sizeof( vout_sys_t ) );
     if( p_vout->p_sys == NULL )
     {
-        intf_ErrMsg( "error: %s", strerror(ENOMEM) );
+        intf_ErrMsg( "vout error: can't create p_sys (%s)", strerror(ENOMEM) );
         return( 1 );
     }
 
-    p_vout->p_sys->p_display = NULL;
-    p_vout->p_sys->p_overlay = NULL;
-    p_vout->p_sys->b_must_acquire = 0;
-
     /* Initialize library */
-    if( SDL_Init(SDL_INIT_VIDEO) < 0 )
+    if( SDL_Init(SDL_INIT_VIDEO | SDL_INIT_EVENTTHREAD | SDL_INIT_NOPARACHUTE)
+            < 0 )
     {
-        intf_ErrMsg( "error: can't initialize SDL library: %s",
-                     SDL_GetError() );
+        intf_ErrMsg( "vout error: can't initialize SDL (%s)", SDL_GetError() );
         free( p_vout->p_sys );
         return( 1 );
     }
 
-    /* Force the software yuv even if it is not used */
-    /* If we don't do this, p_vout is not correctly initialized
-       and it's impossible to switch between soft/hard yuv */
-    p_vout->b_need_render = 1;
-
-    if(psz_display != NULL && strcmp(psz_display,"fullscreen")==0)
-    {
-        p_vout->p_sys->b_fullscreen = 1;
-    }
-    else
-    {
-        p_vout->p_sys->b_fullscreen = 0;
-    }
+    p_vout->p_sys->b_cursor = 1; /* TODO should be done with a main_GetInt.. */
+    p_vout->p_sys->b_fullscreen = main_GetIntVariable( VOUT_FULLSCREEN_VAR,
+                                VOUT_FULLSCREEN_DEFAULT );
+    p_vout->p_sys->b_overlay = main_GetIntVariable( VOUT_OVERLAY_VAR,
+                                VOUT_OVERLAY_DEFAULT );
+    p_vout->p_sys->i_width = main_GetIntVariable( VOUT_WIDTH_VAR, 
+                                VOUT_WIDTH_DEFAULT );
+    p_vout->p_sys->i_height = main_GetIntVariable( VOUT_HEIGHT_VAR,
+                                VOUT_HEIGHT_DEFAULT );
 
-    p_vout->p_sys->i_width = VOUT_WIDTH_DEFAULT;
-    p_vout->p_sys->i_height = VOUT_HEIGHT_DEFAULT;
-
-    p_vout->p_sys->b_reopen_display = 0;
+    p_vout->p_sys->p_display = NULL;
+    p_vout->p_sys->p_overlay = NULL;
 
     if( SDLOpenDisplay(p_vout) )
     {
-        intf_ErrMsg( "error: can't initialize SDL library: %s",
-                     SDL_GetError() );
+        intf_ErrMsg( "vout error: can't set up SDL (%s)", SDL_GetError() );
         free( p_vout->p_sys );
         return( 1 );
     }
 
+    /* FIXME: get rid of this ASAP, it's FUCKING UGLY */
+    { intf_thread_t * p_intf = p_main->p_intf;
+    intf_AssignKey(p_intf, SDLK_q,      INTF_KEY_QUIT, 0);
+    intf_AssignKey(p_intf, SDLK_ESCAPE, INTF_KEY_QUIT, 0);
+    /* intf_AssignKey(p_intf,3,'Q'); */
+    intf_AssignKey(p_intf, SDLK_0,      INTF_KEY_SET_CHANNEL,0);
+    intf_AssignKey(p_intf, SDLK_1,      INTF_KEY_SET_CHANNEL,1);
+    intf_AssignKey(p_intf, SDLK_2,      INTF_KEY_SET_CHANNEL,2);
+    intf_AssignKey(p_intf, SDLK_3,      INTF_KEY_SET_CHANNEL,3);
+    intf_AssignKey(p_intf, SDLK_4,      INTF_KEY_SET_CHANNEL,4);
+    intf_AssignKey(p_intf, SDLK_5,      INTF_KEY_SET_CHANNEL,5);
+    intf_AssignKey(p_intf, SDLK_6,      INTF_KEY_SET_CHANNEL,6);
+    intf_AssignKey(p_intf, SDLK_7,      INTF_KEY_SET_CHANNEL,7);
+    intf_AssignKey(p_intf, SDLK_8,      INTF_KEY_SET_CHANNEL,8);
+    intf_AssignKey(p_intf, SDLK_9,      INTF_KEY_SET_CHANNEL,9);
+    intf_AssignKey(p_intf, SDLK_PLUS,   INTF_KEY_INC_VOLUME, 0);
+    intf_AssignKey(p_intf, SDLK_MINUS,  INTF_KEY_DEC_VOLUME, 0);
+    intf_AssignKey(p_intf, SDLK_m,      INTF_KEY_TOGGLE_VOLUME, 0);
+    /* intf_AssignKey(p_intf,'M','M'); */
+    intf_AssignKey(p_intf, SDLK_g,      INTF_KEY_DEC_GAMMA, 0);
+    /* intf_AssignKey(p_intf,'G','G'); */
+    intf_AssignKey(p_intf, SDLK_c,      INTF_KEY_TOGGLE_GRAYSCALE, 0);
+    intf_AssignKey(p_intf, SDLK_SPACE,  INTF_KEY_TOGGLE_INTERFACE, 0);
+    intf_AssignKey(p_intf, SDLK_i,      INTF_KEY_TOGGLE_INFO, 0);
+    intf_AssignKey(p_intf, SDLK_s,      INTF_KEY_TOGGLE_SCALING, 0); }
+
     return( 0 );
 }
 
 /*****************************************************************************
- * vout_SDLInit: initialize SDL video thread output method
+ * vout_Init: initialize SDL video thread output method
  *****************************************************************************
  * This function initialize the SDL display device.
  *****************************************************************************/
-int vout_SDLInit( vout_thread_t *p_vout )
+static int vout_Init( vout_thread_t *p_vout )
 {
-    /* Acquire first buffer */
-    if( p_vout->p_sys->b_must_acquire )
-    {
-        SDL_LockSurface(p_vout->p_sys->p_display);
-    }
+    /* This hack is hugly, but hey, you are, too. */
+
+    SDL_Overlay *   p_overlay;
+
+    p_overlay = SDL_CreateYUVOverlay( VOUT_WIDTH_DEFAULT, VOUT_HEIGHT_DEFAULT,
+                                      SDL_YV12_OVERLAY, 
+                                      p_vout->p_sys->p_display );
+    intf_Msg( "vout: YUV acceleration %s",
+              p_overlay->hw_overlay ? "activated" : "unavailable !" ); 
+    p_vout->b_need_render = !p_overlay->hw_overlay;
+
+    SDL_FreeYUVOverlay( p_overlay );
 
     return( 0 );
 }
 
 /*****************************************************************************
- * vout_SDLEnd: terminate Sys video thread output method
+ * vout_End: terminate Sys video thread output method
  *****************************************************************************
  * Terminate an output method created by vout_SDLCreate
  *****************************************************************************/
-void vout_SDLEnd( vout_thread_t *p_vout )
+static void vout_End( vout_thread_t *p_vout )
 {
-    /* Release buffer */
-    if( p_vout->p_sys->b_must_acquire )
-    {
-        SDL_UnlockSurface ( p_vout->p_sys->p_display );
-    }
-    free( p_vout->p_sys );
+    SDLCloseDisplay( p_vout );
+    SDL_Quit();
 }
 
 /*****************************************************************************
- * vout_SDLDestroy: destroy Sys video thread output method
+ * vout_Destroy: destroy Sys video thread output method
  *****************************************************************************
  * Terminate an output method created by vout_SDLCreate
  *****************************************************************************/
-void vout_SDLDestroy( vout_thread_t *p_vout )
+static void vout_Destroy( vout_thread_t *p_vout )
 {
-    SDLCloseDisplay( p_vout );
     free( p_vout->p_sys );
 }
 
 /*****************************************************************************
- * vout_SDLManage: handle Sys events
+ * vout_Manage: handle Sys events
  *****************************************************************************
  * This function should be called regularly by video output thread. It returns
  * a non null value if an error occured.
  *****************************************************************************/
-int vout_SDLManage( vout_thread_t *p_vout )
+static int vout_Manage( vout_thread_t *p_vout )
 {
-    /* If the display has to be reopened we do so */
-    if( p_vout->p_sys->b_reopen_display )
+    SDL_Event event;                                            /* SDL event */
+    Uint8   i_key;
+
+    /* Process events */
+    while( SDL_PollEvent(&event) )
     {
-        p_vout->p_sys->b_must_acquire = 0;
-        if( p_vout->p_sys->p_display )
+        switch( event.type )
         {
-            if( p_vout->p_sys->p_overlay )
+        case SDL_VIDEORESIZE:                          /* Resizing of window */
+            p_vout->i_width = event.resize.w;
+            p_vout->i_height = event.resize.h;
+            p_vout->i_changes |= VOUT_SIZE_CHANGE;
+            break;
+
+        case SDL_MOUSEBUTTONUP:
+            switch( event.button.button )
+            {
+            case SDL_BUTTON_RIGHT:
+                p_main->p_intf->b_menu_change = 1;
+                break;
+            }
+            break;
+
+        case SDL_MOUSEBUTTONDOWN:
+            switch( event.button.button )
+            {
+            case SDL_BUTTON_MIDDLE:
+                p_vout->i_changes |= VOUT_CURSOR_CHANGE;
+                break;
+            }
+            break;
+
+        case SDL_QUIT:
+            intf_ProcessKey( p_main->p_intf, SDLK_q );
+            break;
+
+        case SDL_KEYDOWN:                             /* if a key is pressed */
+            i_key = event.key.keysym.sym;
+
+            switch( i_key )
             {
-                SDL_FreeYUVOverlay(p_vout->p_sys->p_overlay);
-                p_vout->p_sys->p_overlay = NULL;
+            case SDLK_f:                             /* switch to fullscreen */
+                p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
+                break;
+
+            case SDLK_y:                               /* switch to hard YUV */
+                p_vout->i_changes |= VOUT_YUV_CHANGE;
+                break;
+
+            case SDLK_c:                                 /* toggle grayscale */
+                p_vout->b_grayscale = ! p_vout->b_grayscale;
+                p_vout->i_changes |= VOUT_GRAYSCALE_CHANGE;
+                break;
+
+            case SDLK_i:                                      /* toggle info */
+                p_vout->b_info = ! p_vout->b_info;
+                p_vout->i_changes |= VOUT_INFO_CHANGE;
+                break;
+
+            case SDLK_s:                                   /* toggle scaling */
+                p_vout->b_scale = ! p_vout->b_scale;
+                p_vout->i_changes |= VOUT_SCALE_CHANGE;
+                break;
+
+            case SDLK_SPACE:                             /* toggle interface */
+                p_vout->b_interface = ! p_vout->b_interface;
+                p_vout->i_changes |= VOUT_INTF_CHANGE;
+                break;
+
+            default:
+                if( intf_ProcessKey( p_main->p_intf, (char )i_key ) )
+                {
+                   intf_DbgMsg( "unhandled key '%c' (%i)", (char)i_key, i_key );                }
+                break;
             }
-            SDL_FreeSurface( p_vout->p_sys->p_display );
-            p_vout->p_sys->p_display = NULL;
+            break;
+
+        default:
+            break;
         }
+    }
 
-        if( SDLOpenDisplay(p_vout) )
+    /*
+     * Size Change 
+     */
+    if( p_vout->i_changes & VOUT_SIZE_CHANGE )
+    {
+        p_vout->p_sys->i_width = p_vout->i_width;
+        p_vout->p_sys->i_height = p_vout->i_height;
+
+        /* Need to reopen display */
+        SDLCloseDisplay( p_vout );
+        if( SDLOpenDisplay( p_vout ) )
+        {
+          intf_ErrMsg( "vout error: can't reopen display after resize" );
+          return( 1 );
+        }
+        p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
+    }
+    
+    /*
+     * YUV Change 
+     */
+    if( p_vout->i_changes & VOUT_YUV_CHANGE )
+    {
+        p_vout->b_need_render = ! p_vout->b_need_render;
+        
+        /* Need to reopen display */
+        SDLCloseDisplay( p_vout );
+        if( SDLOpenDisplay( p_vout ) )
         {
-            intf_ErrMsg( "error: can't open DISPLAY default display" );
-            return( 1 );
+          intf_ErrMsg( "error: can't reopen display after YUV change" );
+          return( 1 );
         }
-        p_vout->p_sys->b_reopen_display = 0;
+        p_vout->i_changes &= ~VOUT_YUV_CHANGE;
     }
+
+    /*
+     * Fullscreen change
+     */
+    if( p_vout->i_changes & VOUT_FULLSCREEN_CHANGE )
+    {
+        p_vout->p_sys->b_fullscreen = ! p_vout->p_sys->b_fullscreen;
+
+        if( p_vout->p_sys->b_fullscreen )
+        {
+            p_vout->p_sys->b_fullscreen = 0;
+            p_vout->p_sys->b_cursor = 1;
+            SDL_ShowCursor( 1 );
+        }
+        else
+        {
+            p_vout->p_sys->b_fullscreen = 1;
+            p_vout->p_sys->b_cursor = 0;
+            SDL_ShowCursor( 0 );
+        }
+
+        SDL_WM_ToggleFullScreen(p_vout->p_sys->p_display);
+
+        p_vout->i_changes &= ~VOUT_FULLSCREEN_CHANGE;
+    }
+
+    /*
+     * Pointer change
+     */
+    if( p_vout->i_changes & VOUT_CURSOR_CHANGE )
+    {
+        if( p_vout->p_sys->b_cursor )
+        {
+            SDL_ShowCursor( 0 );
+            p_vout->p_sys->b_cursor = 0;
+        }
+        else
+        {
+            SDL_ShowCursor( 1 );
+            p_vout->p_sys->b_cursor = 1;
+        }
+        p_vout->i_changes &= ~VOUT_CURSOR_CHANGE;
+    }
+    
     return( 0 );
 }
 
 /*****************************************************************************
- * vout_SDLDisplay: displays previously rendered output
+ * vout_SetPalette: sets an 8 bpp palette
+ *****************************************************************************
+ * This function sets the palette given as an argument. It does not return
+ * anything, but could later send information on which colors it was unable
+ * to set.
+ *****************************************************************************/
+static void vout_SetPalette( p_vout_thread_t p_vout, u16 *red, u16 *green,
+                         u16 *blue, u16 *transp)
+{
+     /* Create a display surface with a grayscale palette */
+    SDL_Color colors[256];
+    int i;
+  
+    /* Fill colors with color information */
+    for( i = 0; i < 256; i++ )
+    {
+        colors[ i ].r = red[ i ] >> 8;
+        colors[ i ].g = green[ i ] >> 8;
+        colors[ i ].b = blue[ i ] >> 8;
+    }
+    
+    /* Set palette */
+    if( SDL_SetColors( p_vout->p_sys->p_display, colors, 0, 256 ) == 0 )
+    {
+        intf_ErrMsg( "vout error: failed setting palette" );
+    }
+
+}
+
+/*****************************************************************************
+ * vout_Display: displays previously rendered output
  *****************************************************************************
  * This function send the currently rendered image to the display, wait until
  * it is displayed and switch the two rendering buffer, preparing next frame.
  *****************************************************************************/
-void vout_SDLDisplay( vout_thread_t *p_vout )
+static void vout_Display( vout_thread_t *p_vout )
 {
     SDL_Rect    disp;
-    if(p_vout->b_need_render)
-    {  
-        /* Change display frame */
-        if( p_vout->p_sys->b_must_acquire )
-        {
-            
+    if((p_vout->p_sys->p_display != NULL) && !p_vout->p_sys->b_reopen_display)
+    {
+        if( p_vout->b_need_render )
+        {  
+            /* Change display frame */
             SDL_Flip( p_vout->p_sys->p_display );
-            
-            /* Swap buffers and change write frame */
-            SDL_LockSurface ( p_vout->p_sys->p_display );
         }
-     }
-     else
-     {
-        
-        /*
-         * p_vout->p_rendered_pic->p_y/u/v contains the YUV buffers to render 
-         */
-        if( p_vout->p_sys->b_must_acquire )
+        else
         {
+        
+            /*
+             * p_vout->p_rendered_pic->p_y/u/v contains the YUV buffers to
+             * render 
+             */
             /* TODO: support for streams other than 4:2:0 */
             /* create the overlay if necessary */
             if( p_vout->p_sys->p_overlay == NULL )
@@ -242,8 +484,9 @@ void vout_SDLDisplay( vout_thread_t *p_vout )
                                              SDL_YV12_OVERLAY, 
                                              p_vout->p_sys->p_display
                                            );
-                intf_Msg("[YUV acceleration] : %d,",
-                            p_vout->p_sys->p_overlay->hw_overlay); 
+                intf_Msg("vout: YUV acceleration %s",
+                            p_vout->p_sys->p_overlay->hw_overlay
+                            ? "activated" : "unavailable !" ); 
             }
 
             SDL_LockYUVOverlay(p_vout->p_sys->p_overlay);
@@ -293,7 +536,7 @@ static int SDLOpenDisplay( vout_thread_t *p_vout )
      */
 
     /* init flags and cursor */
-    flags = SDL_ANYFORMAT;
+    flags = SDL_ANYFORMAT | SDL_HWPALETTE;
 
     if( p_vout->p_sys->b_fullscreen )
         flags |= SDL_FULLSCREEN;
@@ -305,13 +548,13 @@ static int SDLOpenDisplay( vout_thread_t *p_vout )
     else
         flags |= SDL_SWSURFACE; /* save video memory */
 
-    bpp = SDL_VideoModeOK(p_vout->p_sys->i_width,
-                          p_vout->p_sys->i_height,
-                          p_vout->i_screen_depth, flags);
+    bpp = SDL_VideoModeOK( p_vout->p_sys->i_width,
+                           p_vout->p_sys->i_height,
+                           p_vout->i_screen_depth, flags );
 
     if(bpp == 0)
     {
-        intf_ErrMsg( "error: can't open DISPLAY default display" );
+        intf_ErrMsg( "vout error: no video mode available" );
         return( 1 );
     }
 
@@ -321,23 +564,26 @@ static int SDLOpenDisplay( vout_thread_t *p_vout )
 
     if( p_vout->p_sys->p_display == NULL )
     {
-        intf_ErrMsg( "error: can't open DISPLAY default display" );
+        intf_ErrMsg( "vout error: cannot set video mode" );
         return( 1 );
     }
 
+    SDL_LockSurface(p_vout->p_sys->p_display);
+
     if( p_vout->p_sys->b_fullscreen )
         SDL_ShowCursor( 0 );
     else
         SDL_ShowCursor( 1 );
 
-    SDL_WM_SetCaption( VOUT_TITLE , VOUT_TITLE );
-    SDL_EventState(SDL_KEYUP , SDL_IGNORE); /* ignore keys up */
+    SDL_WM_SetCaption( VOUT_TITLE " (SDL output)",
+                       VOUT_TITLE " (SDL output)" );
+    SDL_EventState(SDL_KEYUP , SDL_IGNORE);                /* ignore keys up */
 
     if( p_vout->b_need_render )
     {
-        p_vout->p_sys->p_buffer[ 0 ] = p_vout->p_sys->p_display->pixels;
+        p_vout->p_sys->p_sdl_buf[ 0 ] = p_vout->p_sys->p_display->pixels;
         SDL_Flip(p_vout->p_sys->p_display);
-        p_vout->p_sys->p_buffer[ 1 ] = p_vout->p_sys->p_display->pixels;
+        p_vout->p_sys->p_sdl_buf[ 1 ] = p_vout->p_sys->p_display->pixels;
         SDL_Flip(p_vout->p_sys->p_display);
 
         /* Set clipping for text */
@@ -363,27 +609,24 @@ static int SDLOpenDisplay( vout_thread_t *p_vout )
 
         /* FIXME: palette in 8bpp ?? */
         /* Set and initialize buffers */
-        vout_SetBuffers( p_vout, p_vout->p_sys->p_buffer[ 0 ],
-                                 p_vout->p_sys->p_buffer[ 1 ] );
+        vout_SetBuffers( p_vout, p_vout->p_sys->p_sdl_buf[ 0 ],
+                                 p_vout->p_sys->p_sdl_buf[ 1 ] );
     }
     else
     {
-        p_vout->p_sys->p_buffer[ 0 ] = p_vout->p_sys->p_display->pixels;
-        p_vout->p_sys->p_buffer[ 1 ] = p_vout->p_sys->p_display->pixels;
+        p_vout->p_sys->p_sdl_buf[ 0 ] = p_vout->p_sys->p_display->pixels;
+        p_vout->p_sys->p_sdl_buf[ 1 ] = p_vout->p_sys->p_display->pixels;
 
         /* Set thread information */
         p_vout->i_width =           p_vout->p_sys->p_display->w;
         p_vout->i_height =          p_vout->p_sys->p_display->h;
         p_vout->i_bytes_per_line =  p_vout->p_sys->p_display->pitch;
 
-        vout_SetBuffers( p_vout, p_vout->p_sys->p_buffer[ 0 ],
-                                 p_vout->p_sys->p_buffer[ 1 ] );
+        vout_SetBuffers( p_vout, p_vout->p_sys->p_sdl_buf[ 0 ],
+                                 p_vout->p_sys->p_sdl_buf[ 1 ] );
     }
 
-    p_vout->i_changes |= VOUT_YUV_CHANGE;
-
-    /* Check buffers properties */
-    p_vout->p_sys->b_must_acquire = 1; /* always acquire */
+    p_vout->p_sys->b_reopen_display = 0;
 
     return( 0 );
 }
@@ -396,19 +639,17 @@ static int SDLOpenDisplay( vout_thread_t *p_vout )
  *****************************************************************************/
 static void SDLCloseDisplay( vout_thread_t *p_vout )
 {
-    if( p_vout->p_sys->p_display )
+    if( p_vout->p_sys->p_display != NULL )
     {
-        p_vout->p_sys->b_must_acquire = 0;
-        if( p_vout->p_sys->p_overlay )
-        {
-            SDL_FreeYUVOverlay(p_vout->p_sys->p_overlay);
+        if( p_vout->p_sys->p_overlay != NULL )
+        {            
+            SDL_FreeYUVOverlay( p_vout->p_sys->p_overlay );
             p_vout->p_sys->p_overlay = NULL;
         }
-        SDL_UnlockSurface(p_vout->p_sys->p_display);
+
+        SDL_UnlockSurface ( p_vout->p_sys->p_display );
         SDL_FreeSurface( p_vout->p_sys->p_display );
         p_vout->p_sys->p_display = NULL;
     }
-
-    SDL_Quit();
 }