]> git.sesse.net Git - vlc/blobdiff - plugins/x11/xcommon.c
* ALL: got rid of p_object->p_this which is now useless.
[vlc] / plugins / x11 / xcommon.c
index 937767986b3368c15e3fe58c4152b43d81e73428..451e77c38cb15a72a13f8833445be07b8f8082da 100644 (file)
@@ -2,11 +2,12 @@
  * xcommon.c: Functions common to the X11 and XVideo plugins
  *****************************************************************************
  * Copyright (C) 1998-2001 VideoLAN
- * $Id: xcommon.c,v 1.7 2002/01/05 03:49:18 sam Exp $
+ * $Id: xcommon.c,v 1.37 2002/06/01 18:04:49 sam Exp $
  *
  * Authors: Vincent Seguin <seguin@via.ecp.fr>
  *          Samuel Hocevar <sam@zoy.org>
  *          David Kennedy <dkennedy@tinytoad.com>
+ *          Gildas Bazin <gbazin@netcourrier.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 #include <stdlib.h>                                                /* free() */
 #include <string.h>                                            /* strerror() */
 
-#include <videolan/vlc.h>
+#include <vlc/vlc.h>
+#include <vlc/intf.h>
+#include <vlc/vout.h>
 
 #ifdef HAVE_MACHINE_PARAM_H
-/* BSD */
-#include <machine/param.h>
-#include <sys/types.h>                                     /* typedef ushort */
-#include <sys/ipc.h>
+    /* BSD */
+#   include <machine/param.h>
+#   include <sys/types.h>                                  /* typedef ushort */
+#   include <sys/ipc.h>
 #endif
 
 #ifndef WIN32
-#include <netinet/in.h>                               /* BSD: struct in_addr */
+#   include <netinet/in.h>                            /* BSD: struct in_addr */
+#endif
+
+#ifdef HAVE_SYS_SHM_H
+#   include <sys/shm.h>                                /* shmget(), shmctl() */
 #endif
 
-#include <sys/shm.h>                                   /* shmget(), shmctl() */
 #include <X11/Xlib.h>
 #include <X11/Xutil.h>
 #include <X11/keysym.h>
-#include <X11/extensions/XShm.h>
-#include <X11/extensions/dpms.h>
+#ifdef HAVE_SYS_SHM_H
+#   include <X11/extensions/XShm.h>
+#endif
+#ifdef DPMSINFO_IN_DPMS_H
+#   include <X11/extensions/dpms.h>
+#endif
 
 #ifdef MODULE_NAME_IS_xvideo
 #   include <X11/extensions/Xv.h>
 #   include <X11/extensions/Xvlib.h>
 #endif
 
-#include "video.h"
-#include "video_output.h"
 #include "xcommon.h"
 
-#include "interface.h"
 #include "netutils.h"                                 /* network_ChannelJoin */
 
-#include "stream_control.h"                 /* needed by input_ext-intf.h... */
-#include "input_ext-intf.h"
-
 #ifdef MODULE_NAME_IS_xvideo
 #   define IMAGE_TYPE     XvImage
 #   define EXTRA_ARGS     int i_xvport, int i_chroma
@@ -82,7 +86,6 @@
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
-static int  vout_Probe     ( probedata_t * );
 static int  vout_Create    ( vout_thread_t * );
 static void vout_Destroy   ( vout_thread_t * );
 static void vout_Render    ( vout_thread_t *, picture_t * );
@@ -99,8 +102,12 @@ static void DestroyWindow  ( vout_thread_t * );
 static int  NewPicture     ( vout_thread_t *, picture_t * );
 static void FreePicture    ( vout_thread_t *, picture_t * );
 
-static IMAGE_TYPE *CreateImage    ( Display *, EXTRA_ARGS, int, int );
-static IMAGE_TYPE *CreateShmImage ( Display *, EXTRA_ARGS_SHM, int, int );
+static IMAGE_TYPE *CreateImage    ( vout_thread_t *, 
+                                    Display *, EXTRA_ARGS, int, int );
+#ifdef HAVE_SYS_SHM_H
+static IMAGE_TYPE *CreateShmImage ( vout_thread_t *,
+                                    Display *, EXTRA_ARGS_SHM, int, int );
+#endif
 
 static void ToggleFullScreen      ( vout_thread_t * );
 
@@ -112,8 +119,12 @@ static void DestroyCursor  ( vout_thread_t * );
 static void ToggleCursor   ( vout_thread_t * );
 
 #ifdef MODULE_NAME_IS_xvideo
-static int  XVideoGetPort         ( Display *, u32, u32 * );
-static void XVideoReleasePort     ( Display *, int );
+static int  XVideoGetPort         ( vout_thread_t *, u32, u32 * );
+static void XVideoReleasePort     ( vout_thread_t *, int );
+#endif
+
+#ifdef MODULE_NAME_IS_x11
+static void SetPalette     ( vout_thread_t *, u16 *, u16 *, u16 * );
 #endif
 
 /*****************************************************************************
@@ -122,21 +133,22 @@ static void XVideoReleasePort     ( Display *, int );
  * This structure is part of the video output thread descriptor.
  * It describes the X11 and XVideo specific properties of an output thread.
  *****************************************************************************/
-typedef struct vout_sys_s
+struct vout_sys_s
 {
     /* Internal settings and properties */
     Display *           p_display;                        /* display pointer */
 
     Visual *            p_visual;                          /* visual pointer */
     int                 i_screen;                           /* screen number */
-    Window              window;                               /* root window */
     GC                  gc;              /* graphic context instance handler */
+    Window              window;                               /* root window */
+    Window              video_window;     /* sub-window for displaying video */
 
-    boolean_t           b_shm;               /* shared memory extension flag */
+#ifdef HAVE_SYS_SHM_H
+    vlc_bool_t          b_shm;               /* shared memory extension flag */
+#endif
 
 #ifdef MODULE_NAME_IS_xvideo
-    Window              yuv_window;   /* sub-window for displaying yuv video
-                                                                        data */
     int                 i_xvport;
 #else
     Colormap            colormap;               /* colormap used (8bpp only) */
@@ -144,9 +156,6 @@ typedef struct vout_sys_s
     int                 i_screen_depth;
     int                 i_bytes_per_pixel;
     int                 i_bytes_per_line;
-    int                 i_red_mask;
-    int                 i_green_mask;
-    int                 i_blue_mask;
 #endif
 
     /* X11 generic properties */
@@ -155,27 +164,34 @@ typedef struct vout_sys_s
 
     int                 i_width;                     /* width of main window */
     int                 i_height;                   /* height of main window */
+    vlc_bool_t          b_altfullscreen;          /* which fullscreen method */
 
     /* Backup of window position and size before fullscreen switch */
     int                 i_width_backup;
     int                 i_height_backup;
     int                 i_xpos_backup;
     int                 i_ypos_backup;
+    int                 i_width_backup_2;
+    int                 i_height_backup_2;
+    int                 i_xpos_backup_2;
+    int                 i_ypos_backup_2;
 
     /* Screen saver properties */
     int                 i_ss_timeout;                             /* timeout */
     int                 i_ss_interval;           /* interval between changes */
     int                 i_ss_blanking;                      /* blanking mode */
     int                 i_ss_exposure;                      /* exposure mode */
+#ifdef DPMSINFO_IN_DPMS_H
     BOOL                b_ss_dpms;                              /* DPMS mode */
+#endif
 
     /* Mouse pointer properties */
-    boolean_t           b_mouse_pointer_visible;
+    vlc_bool_t          b_mouse_pointer_visible;
     mtime_t             i_time_mouse_last_moved; /* used to auto-hide pointer*/
     Cursor              blank_cursor;                   /* the hidden cursor */
+    mtime_t             i_time_button_last_pressed;   /* to track dbl-clicks */
     Pixmap              cursor_pixmap;
-
-} vout_sys_t;
+};
 
 /*****************************************************************************
  * picture_sys_t: direct buffer method descriptor
@@ -183,13 +199,14 @@ typedef struct vout_sys_s
  * This structure is part of the picture descriptor, it describes the
  * XVideo specific properties of a direct buffer.
  *****************************************************************************/
-typedef struct picture_sys_s
+struct picture_sys_s
 {
     IMAGE_TYPE *        p_image;
 
+#ifdef HAVE_SYS_SHM_H
     XShmSegmentInfo     shminfo;       /* shared memory zone information */
-
-} picture_sys_t;
+#endif
+};
 
 /*****************************************************************************
  * mwmhints_t: window manager hints
@@ -212,36 +229,17 @@ typedef struct mwmhints_s
  * Chroma defines
  *****************************************************************************/
 #ifdef MODULE_NAME_IS_xvideo
-#   define MAX_DIRECTBUFFERS 5
+#   define MAX_DIRECTBUFFERS 10
 #else
 #   define MAX_DIRECTBUFFERS 2
 #endif
 
-/*****************************************************************************
- * Seeking function TODO: put this in a generic location !
- *****************************************************************************/
-static __inline__ void vout_Seek( off_t i_seek )
-{
-#define area p_main->p_intf->p_input->stream.p_selected_area
-    off_t i_tell = area->i_tell;
-
-    i_tell += i_seek * (off_t)50 * p_main->p_intf->p_input->stream.i_mux_rate;
-
-    i_tell = ( i_tell <= 0/*area->i_start*/ ) ? 0/*area->i_start*/
-           : ( i_tell >= area->i_size ) ? area->i_size
-           : i_tell;
-
-    input_Seek( p_main->p_intf->p_input, i_tell );
-#undef area
-}
-
 /*****************************************************************************
  * Functions exported as capabilities. They are declared as static so that
  * we don't pollute the namespace too much.
  *****************************************************************************/
 void _M( vout_getfunctions )( function_list_t * p_function_list )
 {
-    p_function_list->pf_probe = vout_Probe;
     p_function_list->functions.vout.pf_create     = vout_Create;
     p_function_list->functions.vout.pf_init       = vout_Init;
     p_function_list->functions.vout.pf_end        = vout_End;
@@ -251,62 +249,6 @@ void _M( vout_getfunctions )( function_list_t * p_function_list )
     p_function_list->functions.vout.pf_display    = vout_Display;
 }
 
-/*****************************************************************************
- * vout_Probe: probe the video driver and return a score
- *****************************************************************************
- * This function tries to initialize SDL and returns a score to the
- * plugin manager so that it can select the best plugin.
- *****************************************************************************/
-static int vout_Probe( probedata_t *p_data )
-{
-    Display *p_display;                                   /* display pointer */
-    char    *psz_display;
-#ifdef MODULE_NAME_IS_xvideo
-    int      i_xvport, i_dummy;
-#endif
-
-    /* Open display, unsing 'vlc_display' or DISPLAY environment variable */
-    psz_display = XDisplayName( main_GetPszVariable(VOUT_DISPLAY_VAR, NULL) );
-    p_display = XOpenDisplay( psz_display );
-    if( p_display == NULL )                                         /* error */
-    {
-        intf_WarnMsg( 3, "vout: cannot open display %s", psz_display );
-        return( 0 );
-    }
-
-#ifdef MODULE_NAME_IS_xvideo
-    /* Check that there is an available XVideo port for this format */
-    i_xvport = XVideoGetPort( p_display, p_data->vout.i_chroma, &i_dummy );
-    if( i_xvport < 0 )
-    {
-        /* It failed, but it's not completely lost ! We try to open an
-         * XVideo port for a YUY2 picture */
-        i_xvport = XVideoGetPort( p_display, FOURCC_YUY2, &i_dummy );
-        if( i_xvport < 0 )
-        {
-            /* It failed, but it's not completely lost ! We try to open an
-             * XVideo port for a simple 16bpp RGB picture */
-            i_xvport = XVideoGetPort( p_display, FOURCC_RV16, &i_dummy );
-            if( i_xvport < 0 )
-            {
-                XCloseDisplay( p_display );
-                return( 0 );
-            }
-        }
-    }
-    XVideoReleasePort( p_display, i_xvport );
-#endif
-
-    /* Clean-up everyting */
-    XCloseDisplay( p_display );
-
-#ifdef MODULE_NAME_IS_xvideo 
-    return( 150 );
-#else
-    return( 50 );
-#endif
-}
-
 /*****************************************************************************
  * vout_Create: allocate X11 video thread output method
  *****************************************************************************
@@ -316,48 +258,91 @@ static int vout_Probe( probedata_t *p_data )
  *****************************************************************************/
 static int vout_Create( vout_thread_t *p_vout )
 {
-    char *psz_display;
+    char *     psz_display;
+#ifdef MODULE_NAME_IS_xvideo
+    char *     psz_chroma;
+    u32        i_chroma = 0;
+    vlc_bool_t b_chroma = 0;
+#endif
 
     /* Allocate structure */
     p_vout->p_sys = malloc( sizeof( vout_sys_t ) );
     if( p_vout->p_sys == NULL )
     {
-        intf_ErrMsg( "vout error: %s", strerror(ENOMEM) );
+        msg_Err( p_vout, "out of memory" );
         return( 1 );
     }
 
-    /* Open display, unsing 'vlc_display' or DISPLAY environment variable */
-    psz_display = XDisplayName( main_GetPszVariable( VOUT_DISPLAY_VAR, NULL ) );
+    /* Open display, unsing the "display" config variable or the DISPLAY
+     * environment variable */
+    psz_display = config_GetPsz( p_vout, MODULE_STRING "-display" );
+
     p_vout->p_sys->p_display = XOpenDisplay( psz_display );
 
     if( p_vout->p_sys->p_display == NULL )                          /* error */
     {
-        intf_ErrMsg( "vout error: cannot open display %s", psz_display );
+        msg_Err( p_vout, "cannot open display %s",
+                         XDisplayName( psz_display ) );
         free( p_vout->p_sys );
+        if( psz_display ) free( psz_display );
         return( 1 );
     }
+    if( psz_display ) free( psz_display );
+
     p_vout->p_sys->i_screen = DefaultScreen( p_vout->p_sys->p_display );
 
 #ifdef MODULE_NAME_IS_xvideo
+    psz_chroma = config_GetPsz( p_vout, "xvideo-chroma" );
+    if( psz_chroma )
+    {
+        if( strlen( psz_chroma ) >= 4 )
+        {
+            i_chroma  = (unsigned char)psz_chroma[0] <<  0;
+            i_chroma |= (unsigned char)psz_chroma[1] <<  8;
+            i_chroma |= (unsigned char)psz_chroma[2] << 16;
+            i_chroma |= (unsigned char)psz_chroma[3] << 24;
+
+            b_chroma = 1;
+        }
+
+        free( psz_chroma );
+    }
+
+    if( b_chroma )
+    {
+        msg_Dbg( p_vout, "forcing chroma 0x%.8x (%4.4s)", 
+                 i_chroma, (char*)&i_chroma );
+    }
+    else
+    {
+        i_chroma = p_vout->render.i_chroma;
+    }
+
     /* Check that we have access to an XVideo port providing this chroma */
-    p_vout->p_sys->i_xvport = XVideoGetPort( p_vout->p_sys->p_display,
-                                             p_vout->render.i_chroma,
+    p_vout->p_sys->i_xvport = XVideoGetPort( p_vout, i_chroma,
                                              &p_vout->output.i_chroma );
     if( p_vout->p_sys->i_xvport < 0 )
     {
+        /* If a specific chroma format was requested, then we don't try to
+         * be cleverer than the user. He knows pretty well what he wants. */
+        if( b_chroma )
+        {
+            XCloseDisplay( p_vout->p_sys->p_display );
+            free( p_vout->p_sys );
+            return 1;
+        }
+
         /* It failed, but it's not completely lost ! We try to open an
          * XVideo port for an YUY2 picture. We'll need to do an YUV
          * conversion, but at least it has got scaling. */
-        p_vout->p_sys->i_xvport = XVideoGetPort( p_vout->p_sys->p_display,
-                                                 FOURCC_YUY2,
+        p_vout->p_sys->i_xvport = XVideoGetPort( p_vout, FOURCC_YUY2,
                                                  &p_vout->output.i_chroma );
         if( p_vout->p_sys->i_xvport < 0 )
         {
             /* It failed, but it's not completely lost ! We try to open an
              * XVideo port for a simple 16bpp RGB picture. We'll need to do
              * an YUV conversion, but at least it has got scaling. */
-            p_vout->p_sys->i_xvport = XVideoGetPort( p_vout->p_sys->p_display,
-                                                     FOURCC_RV16,
+            p_vout->p_sys->i_xvport = XVideoGetPort( p_vout, FOURCC_RV16,
                                                      &p_vout->output.i_chroma );
             if( p_vout->p_sys->i_xvport < 0 )
             {
@@ -370,6 +355,7 @@ static int vout_Create( vout_thread_t *p_vout )
 #endif
 
     /* Create blank cursor (for mouse cursor autohiding) */
+    p_vout->p_sys->i_time_mouse_last_moved = mdate();
     p_vout->p_sys->b_mouse_pointer_visible = 1;
     CreateCursor( p_vout );
 
@@ -377,7 +363,7 @@ static int vout_Create( vout_thread_t *p_vout )
      * but also command buttons, subtitles and other indicators */
     if( CreateWindow( p_vout ) )
     {
-        intf_ErrMsg( "vout error: cannot create X11 window" );
+        msg_Err( p_vout, "cannot create X11 window" );
         DestroyCursor( p_vout );
         XCloseDisplay( p_vout->p_sys->p_display );
         free( p_vout->p_sys );
@@ -387,7 +373,7 @@ static int vout_Create( vout_thread_t *p_vout )
     /* Open and initialize device. */
     if( InitDisplay( p_vout ) )
     {
-        intf_ErrMsg( "vout error: cannot initialize X11 display" );
+        msg_Err( p_vout, "cannot initialize X11 display" );
         DestroyCursor( p_vout );
         DestroyWindow( p_vout );
         XCloseDisplay( p_vout->p_sys->p_display );
@@ -395,9 +381,13 @@ static int vout_Create( vout_thread_t *p_vout )
         return( 1 );
     }
 
-    /* Disable screen saver and return */
+    /* Disable screen saver */
     DisableXScreenSaver( p_vout );
 
+    /* Misc init */
+    p_vout->p_sys->b_altfullscreen = 0;
+    p_vout->p_sys->i_time_button_last_pressed = 0;
+
     return( 0 );
 }
 
@@ -414,16 +404,14 @@ static void vout_Destroy( vout_thread_t *p_vout )
         ToggleCursor( p_vout );
     }
 
-#ifdef MODULE_NAME_IS_xvideo   
-    XVideoReleasePort( p_vout->p_sys->p_display, p_vout->p_sys->i_xvport );
-#else
-#if 0
+#ifdef MODULE_NAME_IS_x11
     /* Destroy colormap */
-    if( p_vout->p_sys->i_screen_depth == 8 )
+    if( XDefaultDepth(p_vout->p_sys->p_display, p_vout->p_sys->i_screen) == 8 )
     {
         XFreeColormap( p_vout->p_sys->p_display, p_vout->p_sys->colormap );
     }
-#endif
+#else
+    XVideoReleasePort( p_vout, p_vout->p_sys->i_xvport );
 #endif
 
     DestroyCursor( p_vout );
@@ -457,32 +445,49 @@ static int vout_Init( vout_thread_t *p_vout )
     p_vout->output.i_height = p_vout->render.i_height;
     p_vout->output.i_aspect = p_vout->render.i_aspect;
 
+    switch( p_vout->output.i_chroma )
+    {
+        case FOURCC_RV15:
+            p_vout->output.i_rmask = 0x001f;
+            p_vout->output.i_gmask = 0x07e0;
+            p_vout->output.i_bmask = 0xf800;
+            break;
+        case FOURCC_RV16:
+            p_vout->output.i_rmask = 0x001f;
+            p_vout->output.i_gmask = 0x03e0;
+            p_vout->output.i_bmask = 0x7c00;
+            break;
+    }
+
 #else
     /* Initialize the output structure: RGB with square pixels, whatever
      * the input format is, since it's the only format we know */
     switch( p_vout->p_sys->i_screen_depth )
     {
         case 8: /* FIXME: set the palette */
-            p_vout->output.i_chroma = FOURCC_BI_RGB; break;
+            p_vout->output.i_chroma = FOURCC_RGB2; break;
         case 15:
             p_vout->output.i_chroma = FOURCC_RV15; break;
         case 16:
             p_vout->output.i_chroma = FOURCC_RV16; break;
         case 24:
-            p_vout->output.i_chroma = FOURCC_BI_BITFIELDS; break;
+            p_vout->output.i_chroma = FOURCC_RV24; break;
         case 32:
-            p_vout->output.i_chroma = FOURCC_BI_BITFIELDS; break;
+            p_vout->output.i_chroma = FOURCC_RV24; break;
         default:
-            intf_ErrMsg( "vout error: unknown screen depth" );
+            msg_Err( p_vout, "unknown screen depth %i",
+                     p_vout->p_sys->i_screen_depth );
             return( 0 );
     }
 
-    p_vout->output.i_width = p_vout->p_sys->i_width;
-    p_vout->output.i_height = p_vout->p_sys->i_height;
+    vout_PlacePicture( p_vout, p_vout->p_sys->i_width,
+                       p_vout->p_sys->i_height,
+                       &i_index, &i_index,
+                       &p_vout->output.i_width, &p_vout->output.i_height );
 
     /* Assume we have square pixels */
-    p_vout->output.i_aspect = p_vout->p_sys->i_width
-                               * VOUT_ASPECT_FACTOR / p_vout->p_sys->i_height;
+    p_vout->output.i_aspect = p_vout->output.i_width
+                               * VOUT_ASPECT_FACTOR / p_vout->output.i_height;
 #endif
 
     /* Try to initialize up to MAX_DIRECTBUFFERS direct buffers */
@@ -493,7 +498,7 @@ static int vout_Init( vout_thread_t *p_vout )
         /* Find an empty picture slot */
         for( i_index = 0 ; i_index < VOUT_MAX_PICTURES ; i_index++ )
         {
-            if( p_vout->p_picture[ i_index ].i_status == FREE_PICTURE )
+          if( p_vout->p_picture[ i_index ].i_status == FREE_PICTURE )
             {
                 p_pic = p_vout->p_picture + i_index;
                 break;
@@ -538,43 +543,45 @@ static void vout_Display( vout_thread_t *p_vout, picture_t *p_pic )
     vout_PlacePicture( p_vout, p_vout->p_sys->i_width, p_vout->p_sys->i_height,
                        &i_x, &i_y, &i_width, &i_height );
 
+#ifdef HAVE_SYS_SHM_H
     if( p_vout->p_sys->b_shm )
     {
         /* Display rendered image using shared memory extension */
-#ifdef MODULE_NAME_IS_xvideo
+#   ifdef MODULE_NAME_IS_xvideo
         XvShmPutImage( p_vout->p_sys->p_display, p_vout->p_sys->i_xvport,
-                       p_vout->p_sys->yuv_window, p_vout->p_sys->gc,
+                       p_vout->p_sys->video_window, p_vout->p_sys->gc,
                        p_pic->p_sys->p_image, 0 /*src_x*/, 0 /*src_y*/,
                        p_vout->output.i_width, p_vout->output.i_height,
                        0 /*dest_x*/, 0 /*dest_y*/, i_width, i_height,
                        False /* Don't put True here or you'll waste your CPU */ );
-#else
-        XShmPutImage( p_vout->p_sys->p_display, p_vout->p_sys->window,
+#   else
+        XShmPutImage( p_vout->p_sys->p_display, p_vout->p_sys->video_window,
                       p_vout->p_sys->gc, p_pic->p_sys->p_image,
                       0 /*src_x*/, 0 /*src_y*/, 0 /*dest_x*/, 0 /*dest_y*/,
                       p_vout->output.i_width, p_vout->output.i_height,
                       False /* Don't put True here ! */ );
-#endif
+#   endif
     }
     else
+#endif /* HAVE_SYS_SHM_H */
     {
         /* Use standard XPutImage -- this is gonna be slow ! */
 #ifdef MODULE_NAME_IS_xvideo
         XvPutImage( p_vout->p_sys->p_display, p_vout->p_sys->i_xvport,
-                    p_vout->p_sys->yuv_window, p_vout->p_sys->gc,
+                    p_vout->p_sys->video_window, p_vout->p_sys->gc,
                     p_pic->p_sys->p_image, 0 /*src_x*/, 0 /*src_y*/,
                     p_vout->output.i_width, p_vout->output.i_height,
                     0 /*dest_x*/, 0 /*dest_y*/, i_width, i_height );
 #else
-        XPutImage( p_vout->p_sys->p_display, p_vout->p_sys->window,
+        XPutImage( p_vout->p_sys->p_display, p_vout->p_sys->video_window,
                    p_vout->p_sys->gc, p_pic->p_sys->p_image,
                    0 /*src_x*/, 0 /*src_y*/, 0 /*dest_x*/, 0 /*dest_y*/,
                    p_vout->output.i_width, p_vout->output.i_height );
 #endif
     }
 
-    /* Make sure the command is sent now */
-    XFlush( p_vout->p_sys->p_display );
+    /* Make sure the command is sent now - do NOT use XFlush !*/
+    XSync( p_vout->p_sys->p_display, False );
 }
 
 /*****************************************************************************
@@ -587,7 +594,6 @@ static void vout_Display( vout_thread_t *p_vout, picture_t *p_pic )
 static int vout_Manage( vout_thread_t *p_vout )
 {
     XEvent      xevent;                                         /* X11 event */
-    boolean_t   b_resized;                        /* window has been resized */
     char        i_key;                                    /* ISO Latin-1 key */
     KeySym      x_key_symbol;
 
@@ -596,7 +602,6 @@ static int vout_Manage( vout_thread_t *p_vout )
      * window is mapped (and if the display is useful), and ClientMessages
      * to intercept window destruction requests */
 
-    b_resized = 0;
     while( XCheckWindowEvent( p_vout->p_sys->p_display, p_vout->p_sys->window,
                               StructureNotifyMask | KeyPressMask |
                               ButtonPressMask | ButtonReleaseMask | 
@@ -604,32 +609,15 @@ static int vout_Manage( vout_thread_t *p_vout )
            == True )
     {
         /* ConfigureNotify event: prepare  */
-        if( (xevent.type == ConfigureNotify)
-          && ((xevent.xconfigure.width != p_vout->p_sys->i_width)
-             || (xevent.xconfigure.height != p_vout->p_sys->i_height)) )
+        if( xevent.type == ConfigureNotify )
         {
-            /* Update dimensions */
-            b_resized = 1;
-            p_vout->i_changes |= VOUT_SIZE_CHANGE;
-            p_vout->p_sys->i_width = xevent.xconfigure.width;
-            p_vout->p_sys->i_height = xevent.xconfigure.height;
-        }
-        /* MapNotify event: change window status and disable screen saver */
-        else if( xevent.type == MapNotify)
-        {
-            if( (p_vout != NULL) && !p_vout->b_active )
-            {
-                DisableXScreenSaver( p_vout );
-                p_vout->b_active = 1;
-            }
-        }
-        /* UnmapNotify event: change window status and enable screen saver */
-        else if( xevent.type == UnmapNotify )
-        {
-            if( (p_vout != NULL) && p_vout->b_active )
+            if( (xevent.xconfigure.width != p_vout->p_sys->i_width)
+                 || (xevent.xconfigure.height != p_vout->p_sys->i_height) )
             {
-                EnableXScreenSaver( p_vout );
-                p_vout->b_active = 0;
+                /* Update dimensions */
+                p_vout->i_changes |= VOUT_SIZE_CHANGE;
+                p_vout->p_sys->i_width = xevent.xconfigure.width;
+                p_vout->p_sys->i_height = xevent.xconfigure.height;
             }
         }
         /* Keyboard event */
@@ -640,80 +628,91 @@ static int vout_Manage( vout_thread_t *p_vout )
                                              xevent.xkey.keycode, 0 );
             switch( x_key_symbol )
             {
-                 case XK_Escape:
-                     p_main->p_intf->b_die = 1;
-                     break;
-                 case XK_Menu:
-                     p_main->p_intf->b_menu_change = 1;
-                     break;
-                 case XK_Left:
-                     vout_Seek( -5 );
-                     break;
-                 case XK_Right:
-                     vout_Seek( 5 );
-                     break;
-                 case XK_Up:
-                     vout_Seek( 60 );
-                     break;
-                 case XK_Down:
-                     vout_Seek( -60 );
-                     break;
-                 case XK_Home:
-                     input_Seek( p_main->p_intf->p_input,
-                     p_main->p_intf->p_input->stream.p_selected_area->i_start );
-                     break;
-                 case XK_End:
-                     input_Seek( p_main->p_intf->p_input,
-                     p_main->p_intf->p_input->stream.p_selected_area->i_size );
-                     break;
-                 case XK_Page_Up:
-                     vout_Seek( 900 );
-                     break;
-                 case XK_Page_Down:
-                     vout_Seek( -900 );
-                     break;
-                 case XK_space:
-                     input_SetStatus( p_main->p_intf->p_input,
-                                      INPUT_STATUS_PAUSE );
-                     break;
-
-                 default:
-                     /* "Normal Keys"
-                      * The reason why I use this instead of XK_0 is that 
-                      * with XLookupString, we don't have to care about
-                      * keymaps. */
-
-                    if( XLookupString( &xevent.xkey, &i_key, 1, NULL, NULL ) )
+            case XK_Escape:
+                if( p_vout->b_fullscreen )
+                {
+                    p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
+                }
+                else
+                {
+                    p_vout->p_vlc->b_die = 1;
+                }
+                break;
+            case XK_Menu:
+                {
+                    intf_thread_t *p_intf;
+                    p_intf = vlc_object_find( p_vout->p_vlc, VLC_OBJECT_INTF,
+                                                             FIND_CHILD );
+                    if( p_intf )
                     {
-                        /* FIXME: handle stuff here */
-                        switch( i_key )
-                        {
-                        case 'q':
-                        case 'Q':
-                            p_main->p_intf->b_die = 1;
-                            break;
-                        case 'f':
-                        case 'F':
-                            p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-                            break;
-
-                        case '0': network_ChannelJoin( 0 ); break;
-                        case '1': network_ChannelJoin( 1 ); break;
-                        case '2': network_ChannelJoin( 2 ); break;
-                        case '3': network_ChannelJoin( 3 ); break;
-                        case '4': network_ChannelJoin( 4 ); break;
-                        case '5': network_ChannelJoin( 5 ); break;
-                        case '6': network_ChannelJoin( 6 ); break;
-                        case '7': network_ChannelJoin( 7 ); break;
-                        case '8': network_ChannelJoin( 8 ); break;
-                        case '9': network_ChannelJoin( 9 ); break;
-
-                        default:
-                            intf_DbgMsg( "vout: unhandled key '%c' (%i)", 
-                                         (char)i_key, i_key );
-                            break;
-                        }
+                        p_intf->b_menu_change = 1;
+                        vlc_object_release( p_intf );
+                    }
+                }
+                break;
+            case XK_Left:
+                input_Seek( p_vout, -5, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_Right:
+                input_Seek( p_vout, 5, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_Up:
+                input_Seek( p_vout, 60, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_Down:
+                input_Seek( p_vout, -60, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_Home:
+                input_Seek( p_vout, 0, INPUT_SEEK_BYTES | INPUT_SEEK_SET );
+                break;
+            case XK_End:
+                input_Seek( p_vout, 0, INPUT_SEEK_BYTES | INPUT_SEEK_END );
+                break;
+            case XK_Page_Up:
+                input_Seek( p_vout, 900, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_Page_Down:
+                input_Seek( p_vout, -900, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                break;
+            case XK_space:
+                input_SetStatus( p_vout, INPUT_STATUS_PAUSE );
+                break;
+
+            default:
+                /* "Normal Keys"
+                 * The reason why I use this instead of XK_0 is that 
+                 * with XLookupString, we don't have to care about
+                 * keymaps. */
+
+                if( XLookupString( &xevent.xkey, &i_key, 1, NULL, NULL ) )
+                {
+                    /* FIXME: handle stuff here */
+                    switch( i_key )
+                    {
+                    case 'q':
+                    case 'Q':
+                        p_vout->p_vlc->b_die = 1;
+                        break;
+                    case 'f':
+                    case 'F':
+                        p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
+                        break;
+
+                    case '0': network_ChannelJoin( p_vout, 0 ); break;
+                    case '1': network_ChannelJoin( p_vout, 1 ); break;
+                    case '2': network_ChannelJoin( p_vout, 2 ); break;
+                    case '3': network_ChannelJoin( p_vout, 3 ); break;
+                    case '4': network_ChannelJoin( p_vout, 4 ); break;
+                    case '5': network_ChannelJoin( p_vout, 5 ); break;
+                    case '6': network_ChannelJoin( p_vout, 6 ); break;
+                    case '7': network_ChannelJoin( p_vout, 7 ); break;
+                    case '8': network_ChannelJoin( p_vout, 8 ); break;
+                    case '9': network_ChannelJoin( p_vout, 9 ); break;
+
+                    default:
+                        break;
                     }
+                }
                 break;
             }
         }
@@ -724,18 +723,25 @@ static int vout_Manage( vout_thread_t *p_vout )
             {
                 case Button1:
                     /* In this part we will eventually manage
-                     * clicks for DVD navigation for instance. For the
-                     * moment just pause the stream. */
-                    input_SetStatus( p_main->p_intf->p_input,
-                                     INPUT_STATUS_PAUSE );
+                     * clicks for DVD navigation for instance. */
+
+                    /* detect double-clicks */
+                    if( ( ((XButtonEvent *)&xevent)->time -
+                          p_vout->p_sys->i_time_button_last_pressed ) < 300 )
+                    {
+                        p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
+                    }
+
+                    p_vout->p_sys->i_time_button_last_pressed =
+                        ((XButtonEvent *)&xevent)->time;
                     break;
 
                 case Button4:
-                    vout_Seek( 15 );
+                    input_Seek( p_vout, 15, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                     break;
 
                 case Button5:
-                    vout_Seek( -15 );
+                    input_Seek( p_vout, -15, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                     break;
             }
         }
@@ -745,8 +751,16 @@ static int vout_Manage( vout_thread_t *p_vout )
             switch( ((XButtonEvent *)&xevent)->button )
             {
                 case Button3:
-                    /* FIXME: need locking ! */
-                    p_main->p_intf->b_menu_change = 1;
+                    {
+                        intf_thread_t *p_intf;
+                        p_intf = vlc_object_find( p_vout->p_vlc,
+                                          VLC_OBJECT_INTF, FIND_CHILD );
+                        if( p_intf )
+                        {
+                            p_intf->b_menu_change = 1;
+                            vlc_object_release( p_intf );
+                        }
+                    }
                     break;
             }
         }
@@ -759,17 +773,21 @@ static int vout_Manage( vout_thread_t *p_vout )
                 ToggleCursor( p_vout ); 
             }
         }
+        /* Reparent move -- XXX: why are we getting this ? */
+        else if( xevent.type == ReparentNotify )
+        {
+            ;
+        }
         /* Other event */
         else
         {
-            intf_WarnMsg( 3, "vout: unhandled event %d received", xevent.type );
+            msg_Warn( p_vout, "unhandled event %d received", xevent.type );
         }
     }
 
-#ifdef MODULE_NAME_IS_xvideo
-    /* Handle events for YUV video output sub-window */
+    /* Handle events for video output sub-window */
     while( XCheckWindowEvent( p_vout->p_sys->p_display,
-                              p_vout->p_sys->yuv_window,
+                              p_vout->p_sys->video_window,
                               ExposureMask, &xevent ) == True )
     {
         /* Window exposed (only handled if stream playback is paused) */
@@ -778,18 +796,19 @@ static int vout_Manage( vout_thread_t *p_vout )
             if( ((XExposeEvent *)&xevent)->count == 0 )
             {
                 /* (if this is the last a collection of expose events...) */
-                if( p_main->p_intf->p_input != NULL )
+#if 0
+                if( p_vout->p_vlc->p_input_bank->pp_input[0] != NULL )
                 {
-                    if( PAUSE_S ==
-                            p_main->p_intf->p_input->stream.control.i_status )
+                    if( PAUSE_S == p_vout->p_vlc->p_input_bank->pp_input[0]
+                                                   ->stream.control.i_status )
                     {
-/*                        XVideoDisplay( p_vout )*/;
+                        /* XVideoDisplay( p_vout )*/;
                     }
                 }
+#endif
             }
         }
     }
-#endif
 
     /* ClientMessage event - only WM_PROTOCOLS with WM_DELETE_WINDOW data
      * are handled - according to the man pages, the format is always 32
@@ -800,11 +819,7 @@ static int vout_Manage( vout_thread_t *p_vout )
         if( (xevent.xclient.message_type == p_vout->p_sys->wm_protocols)
             && (xevent.xclient.data.l[0] == p_vout->p_sys->wm_delete_window ) )
         {
-            p_main->p_intf->b_die = 1;
-        }
-        else
-        {
-            intf_DbgMsg( "vout: unhandled ClientMessage received" );
+            p_vout->p_vlc->b_die = 1;
         }
     }
 
@@ -818,72 +833,11 @@ static int vout_Manage( vout_thread_t *p_vout )
 
     }
 
-
-#ifdef MODULE_NAME_IS_x11
-    /*
-     * Handle vout window resizing
-     */
-#if 0
-    if( b_resized )
-    {
-        /* If interface window has been resized, change vout size */
-        intf_DbgMsg( "vout: resizing output window" );
-        p_vout->i_width =  p_vout->p_sys->i_width;
-        p_vout->i_height = p_vout->p_sys->i_height;
-        p_vout->i_changes |= VOUT_SIZE_CHANGE;
-    }
-    else if( (p_vout->i_width  != p_vout->p_sys->i_width) ||
-             (p_vout->i_height != p_vout->p_sys->i_height) )
-    {
-        /* If video output size has changed, change interface window size */
-        intf_DbgMsg( "vout: resizing output window" );
-        p_vout->p_sys->i_width =    p_vout->i_width;
-        p_vout->p_sys->i_height =   p_vout->i_height;
-        XResizeWindow( p_vout->p_sys->p_display, p_vout->p_sys->window,
-                       p_vout->p_sys->i_width, p_vout->p_sys->i_height );
-    }
-    /*
-     * Color/Grayscale or gamma change: in 8bpp, just change the colormap
-     */
-    if( (p_vout->i_changes & VOUT_GRAYSCALE_CHANGE)
-        && (p_vout->i_screen_depth == 8) )
-    {
-        /* FIXME: clear flags ?? */
-    }
-
-    /*
-     * Size change
-     */
-    if( p_vout->i_changes & VOUT_SIZE_CHANGE )
-    {
-        intf_DbgMsg( "vout info: resizing window" );
-        p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
-
-        /* Resize window */
-        XResizeWindow( p_vout->p_sys->p_display, p_vout->p_sys->window,
-                       p_vout->i_width, p_vout->i_height );
-
-        /* Destroy XImages to change their size */
-        vout_End( p_vout );
-
-        /* Recreate XImages. If SysInit failed, the thread can't go on. */
-        if( vout_Init( p_vout ) )
-        {
-            intf_ErrMsg( "vout error: cannot resize display" );
-            return( 1 );
-       }
-
-        /* Tell the video output thread that it will need to rebuild YUV
-         * tables. This is needed since conversion buffer size may have
-         * changed */
-        p_vout->i_changes |= VOUT_YUV_CHANGE;
-        intf_Msg( "vout: video display resized (%dx%d)",
-                  p_vout->i_width, p_vout->i_height);
-    }
-#endif /* #if 0 */
-#else
     /*
      * Size change
+     *
+     * (Needs to be placed after VOUT_FULLSREEN_CHANGE because we can activate
+     *  the size flag inside the fullscreen routine)
      */
     if( p_vout->i_changes & VOUT_SIZE_CHANGE )
     {
@@ -891,22 +845,25 @@ static int vout_Manage( vout_thread_t *p_vout )
 
         p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
 
-        intf_WarnMsg( 3, "vout: video display resized (%dx%d)",
-                      p_vout->p_sys->i_width,
-                      p_vout->p_sys->i_height );
+        msg_Dbg( p_vout, "video display resized (%dx%d)",
+                         p_vout->p_sys->i_width, p_vout->p_sys->i_height );
  
+#ifdef MODULE_NAME_IS_x11
+        /* We need to signal the vout thread about the size change because it
+         * is doing the rescaling */
+        p_vout->i_changes |= VOUT_SIZE_CHANGE;
+#endif
+
         vout_PlacePicture( p_vout, p_vout->p_sys->i_width,
                            p_vout->p_sys->i_height,
                            &i_x, &i_y, &i_width, &i_height );
 
-        XResizeWindow( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window,
+        XResizeWindow( p_vout->p_sys->p_display, p_vout->p_sys->video_window,
                        i_width, i_height );
         
-        XMoveWindow( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window,
+        XMoveWindow( p_vout->p_sys->p_display, p_vout->p_sys->video_window,
                      i_x, i_y );
-
     }
-#endif
 
     /* Autohide Cursour */
     if( mdate() - p_vout->p_sys->i_time_mouse_last_moved > 2000000 )
@@ -914,7 +871,7 @@ static int vout_Manage( vout_thread_t *p_vout )
         /* Hide the mouse automatically */
         if( p_vout->p_sys->b_mouse_pointer_visible )
         {
-            ToggleCursor( p_vout ); 
+            ToggleCursor( p_vout );
         }
     }
 
@@ -951,38 +908,13 @@ static int CreateWindow( vout_thread_t *p_vout )
     XGCValues               xgcvalues;
     XEvent                  xevent;
 
-    boolean_t               b_expose;
-    boolean_t               b_configure_notify;
-    boolean_t               b_map_notify;
+    vlc_bool_t              b_expose;
+    vlc_bool_t              b_configure_notify;
+    vlc_bool_t              b_map_notify;
 
     /* Set main window's size */
-    if( p_vout->render.i_height * p_vout->render.i_aspect
-        >= p_vout->render.i_width * VOUT_ASPECT_FACTOR )
-    {
-        p_vout->p_sys->i_width = p_vout->render.i_height
-          * p_vout->render.i_aspect / VOUT_ASPECT_FACTOR;
-        p_vout->p_sys->i_height = p_vout->render.i_height;
-    }
-    else
-    {
-        p_vout->p_sys->i_width = p_vout->render.i_width;
-        p_vout->p_sys->i_height = p_vout->render.i_width
-          * VOUT_ASPECT_FACTOR / p_vout->render.i_aspect;
-    }
-
-#if 0
-    if( p_vout->p_sys->i_width <= 300 && p_vout->p_sys->i_height <= 300 )
-    {
-        p_vout->p_sys->i_width <<= 1;
-        p_vout->p_sys->i_height <<= 1;
-    }
-    else if( p_vout->p_sys->i_width <= 400
-             && p_vout->p_sys->i_height <= 400 )
-    {
-        p_vout->p_sys->i_width += p_vout->p_sys->i_width >> 1;
-        p_vout->p_sys->i_height += p_vout->p_sys->i_height >> 1;
-    }
-#endif
+    p_vout->p_sys->i_width = p_vout->i_window_width;
+    p_vout->p_sys->i_height = p_vout->i_window_height;
 
     /* Prepare window manager hints and properties */
     xsize_hints.base_width          = p_vout->p_sys->i_width;
@@ -1019,8 +951,11 @@ static int CreateWindow( vout_thread_t *p_vout )
      * window's name, and accepted protocols */
     XSetWMNormalHints( p_vout->p_sys->p_display, p_vout->p_sys->window,
                        &xsize_hints );
+    /* XXX: DISABLED! makes browsers crash */
+#if 0
     XSetCommand( p_vout->p_sys->p_display, p_vout->p_sys->window,
-                 p_main->ppsz_argv, p_main->i_argc );
+                 p_vout->p_vlc->ppsz_argv, p_vout->p_vlc->i_argc );
+#endif
     XStoreName( p_vout->p_sys->p_display, p_vout->p_sys->window,
 #ifdef MODULE_NAME_IS_x11
                 VOUT_TITLE " (X11 output)"
@@ -1035,7 +970,7 @@ static int CreateWindow( vout_thread_t *p_vout )
                              &p_vout->p_sys->wm_delete_window, 1 ) )
     {
         /* WM_DELETE_WINDOW is not supported by window manager */
-        intf_Msg( "vout error: missing or bad window manager" );
+        msg_Warn( p_vout, "missing or bad window manager" );
     } 
 
     /* Creation of a graphic context that doesn't generate a GraphicsExpose
@@ -1098,25 +1033,30 @@ static int CreateWindow( vout_thread_t *p_vout )
                                  CWColormap, &xwindow_attributes );
     }
 
-#else
-    /* Create YUV output sub-window. */
-    p_vout->p_sys->yuv_window = XCreateSimpleWindow( p_vout->p_sys->p_display,
-                         p_vout->p_sys->window, 0, 0,
-                         p_vout->p_sys->i_width,
-                         p_vout->p_sys->i_height,
-                         0,
-                         BlackPixel( p_vout->p_sys->p_display,
-                                         p_vout->p_sys->i_screen ),
-                         WhitePixel( p_vout->p_sys->p_display,
-                                         p_vout->p_sys->i_screen ) );
-    
-    XSetWindowBackground( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window,
-             BlackPixel(p_vout->p_sys->p_display, p_vout->p_sys->i_screen ) );
+#endif
+    /* Create video output sub-window. */
+    p_vout->p_sys->video_window =  XCreateSimpleWindow(
+                                      p_vout->p_sys->p_display,
+                                      p_vout->p_sys->window, 0, 0,
+                                      p_vout->p_sys->i_width,
+                                      p_vout->p_sys->i_height,
+                                      0,
+                                      BlackPixel( p_vout->p_sys->p_display,
+                                                  p_vout->p_sys->i_screen ),
+                                      WhitePixel( p_vout->p_sys->p_display,
+                                                  p_vout->p_sys->i_screen ) );
+
+    XSetWindowBackground( p_vout->p_sys->p_display,
+                          p_vout->p_sys->video_window,
+                          BlackPixel( p_vout->p_sys->p_display,
+                                      p_vout->p_sys->i_screen ) );
     
-    XMapWindow( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window );
-    XSelectInput( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window,
+    XMapWindow( p_vout->p_sys->p_display, p_vout->p_sys->video_window );
+    XSelectInput( p_vout->p_sys->p_display, p_vout->p_sys->video_window,
                   ExposureMask );
-#endif
+
+    /* make sure the video window will be centered in the next vout_Manage() */
+    p_vout->i_changes |= VOUT_SIZE_CHANGE;
 
     /* If the cursor was formerly blank than blank it again */
     if( !p_vout->p_sys->b_mouse_pointer_visible )
@@ -1125,6 +1065,7 @@ static int CreateWindow( vout_thread_t *p_vout )
         ToggleCursor( p_vout );
     }
 
+    /* Do NOT use XFlush here ! */
     XSync( p_vout->p_sys->p_display, False );
 
     /* At this stage, the window is open, displayed, and ready to
@@ -1140,12 +1081,10 @@ static int CreateWindow( vout_thread_t *p_vout )
  *****************************************************************************/
 static void DestroyWindow( vout_thread_t *p_vout )
 {
+    /* Do NOT use XFlush here ! */
     XSync( p_vout->p_sys->p_display, False );
 
-#ifdef MODULE_NAME_IS_xvideo
-    XDestroyWindow( p_vout->p_sys->p_display, p_vout->p_sys->yuv_window );
-#endif
-
+    XDestroyWindow( p_vout->p_sys->p_display, p_vout->p_sys->video_window );
     XUnmapWindow( p_vout->p_sys->p_display, p_vout->p_sys->window );
     XFreeGC( p_vout->p_sys->p_display, p_vout->p_sys->gc );
     XDestroyWindow( p_vout->p_sys->p_display, p_vout->p_sys->window );
@@ -1167,29 +1106,29 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
         return -1;
     }
 
+#ifdef HAVE_SYS_SHM_H
     if( p_vout->p_sys->b_shm )
     {
         /* Create image using XShm extension */
         p_pic->p_sys->p_image =
-            CreateShmImage( p_vout->p_sys->p_display,
-#ifdef MODULE_NAME_IS_xvideo
-                            p_vout->p_sys->i_xvport,
-                            p_vout->output.i_chroma,
-#else
+            CreateShmImage( p_vout, p_vout->p_sys->p_display,
+#   ifdef MODULE_NAME_IS_xvideo
+                            p_vout->p_sys->i_xvport, p_vout->output.i_chroma,
+#   else
                             p_vout->p_sys->p_visual,
                             p_vout->p_sys->i_screen_depth,
-#endif
+#   endif
                             &p_pic->p_sys->shminfo,
                             p_vout->output.i_width, p_vout->output.i_height );
     }
     else
+#endif /* HAVE_SYS_SHM_H */
     {
         /* Create image without XShm extension */
         p_pic->p_sys->p_image =
-            CreateImage( p_vout->p_sys->p_display,
+            CreateImage( p_vout, p_vout->p_sys->p_display,
 #ifdef MODULE_NAME_IS_xvideo
-                         p_vout->p_sys->i_xvport,
-                         p_vout->output.i_chroma,
+                         p_vout->p_sys->i_xvport, p_vout->output.i_chroma,
 #else
                          p_vout->p_sys->p_visual,
                          p_vout->p_sys->i_screen_depth, 
@@ -1220,15 +1159,15 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
                                + p_pic->p_sys->p_image->offsets[1];
             p_pic->p[U_PLANE].i_lines = p_vout->output.i_height / 2;
             p_pic->p[U_PLANE].i_pitch = p_pic->p_sys->p_image->pitches[1];
-            p_pic->p[Y_PLANE].i_pixel_bytes = 1;
-            p_pic->p[Y_PLANE].b_margin = 0;
+            p_pic->p[U_PLANE].i_pixel_bytes = 1;
+            p_pic->p[U_PLANE].b_margin = 0;
 
             p_pic->V_PIXELS = p_pic->p_sys->p_image->data
                                + p_pic->p_sys->p_image->offsets[2];
             p_pic->p[V_PLANE].i_lines = p_vout->output.i_height / 2;
             p_pic->p[V_PLANE].i_pitch = p_pic->p_sys->p_image->pitches[2];
-            p_pic->p[Y_PLANE].i_pixel_bytes = 1;
-            p_pic->p[Y_PLANE].b_margin = 0;
+            p_pic->p[V_PLANE].i_pixel_bytes = 1;
+            p_pic->p[V_PLANE].b_margin = 0;
 
             p_pic->i_planes = 3;
             break;
@@ -1246,15 +1185,15 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
                                + p_pic->p_sys->p_image->offsets[2];
             p_pic->p[U_PLANE].i_lines = p_vout->output.i_height / 2;
             p_pic->p[U_PLANE].i_pitch = p_pic->p_sys->p_image->pitches[2];
-            p_pic->p[Y_PLANE].i_pixel_bytes = 1;
-            p_pic->p[Y_PLANE].b_margin = 0;
+            p_pic->p[U_PLANE].i_pixel_bytes = 1;
+            p_pic->p[U_PLANE].b_margin = 0;
 
             p_pic->V_PIXELS = p_pic->p_sys->p_image->data
                                + p_pic->p_sys->p_image->offsets[1];
             p_pic->p[V_PLANE].i_lines = p_vout->output.i_height / 2;
             p_pic->p[V_PLANE].i_pitch = p_pic->p_sys->p_image->pitches[1];
-            p_pic->p[Y_PLANE].i_pixel_bytes = 1;
-            p_pic->p[Y_PLANE].b_margin = 0;
+            p_pic->p[V_PLANE].i_pixel_bytes = 1;
+            p_pic->p[V_PLANE].b_margin = 0;
 
             p_pic->i_planes = 3;
             break;
@@ -1294,10 +1233,6 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
             p_pic->p->i_pixel_bytes = 2;
             p_pic->p->b_margin = 0;
 
-            p_pic->p->i_red_mask   = 0x001f;
-            p_pic->p->i_green_mask = 0x07e0;
-            p_pic->p->i_blue_mask  = 0xf800;
-
             p_pic->i_planes = 1;
             break;
 
@@ -1310,15 +1245,35 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
             p_pic->p->i_pixel_bytes = 2;
             p_pic->p->b_margin = 0;
 
-            p_pic->p->i_red_mask   = 0x001f;
-            p_pic->p->i_green_mask = 0x03e0;
-            p_pic->p->i_blue_mask  = 0x7c00;
-
             p_pic->i_planes = 1;
             break;
 
 #else
+        case FOURCC_RGB2:
+
+            p_pic->p->p_pixels = p_pic->p_sys->p_image->data
+                                  + p_pic->p_sys->p_image->xoffset;
+            p_pic->p->i_lines = p_pic->p_sys->p_image->height;
+            p_pic->p->i_pitch = p_pic->p_sys->p_image->bytes_per_line;
+            p_pic->p->i_pixel_bytes = p_pic->p_sys->p_image->depth;
+
+            if( p_pic->p->i_pitch == p_pic->p_sys->p_image->width )
+            {
+                p_pic->p->b_margin = 0;
+            }
+            else
+            {
+                p_pic->p->b_margin = 1;
+                p_pic->p->b_hidden = 1;
+                p_pic->p->i_visible_bytes = p_pic->p_sys->p_image->width;
+            }
+
+            p_pic->i_planes = 1;
+
+            break;
+
         case FOURCC_RV16:
+        case FOURCC_RV15:
 
             p_pic->p->p_pixels = p_pic->p_sys->p_image->data
                                   + p_pic->p_sys->p_image->xoffset;
@@ -1337,9 +1292,29 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
                 p_pic->p->i_visible_bytes = 2 * p_pic->p_sys->p_image->width;
             }
 
-            p_pic->p->i_red_mask   = p_pic->p_sys->p_image->red_mask;
-            p_pic->p->i_green_mask = p_pic->p_sys->p_image->green_mask;
-            p_pic->p->i_blue_mask  = p_pic->p_sys->p_image->blue_mask;
+            p_pic->i_planes = 1;
+
+            break;
+
+        case FOURCC_RV32:
+        case FOURCC_RV24:
+
+            p_pic->p->p_pixels = p_pic->p_sys->p_image->data
+                                  + p_pic->p_sys->p_image->xoffset;
+            p_pic->p->i_lines = p_pic->p_sys->p_image->height;
+            p_pic->p->i_pitch = p_pic->p_sys->p_image->bytes_per_line;
+            p_pic->p->i_pixel_bytes = p_pic->p_sys->p_image->depth;
+
+            if( p_pic->p->i_pitch == 4 * p_pic->p_sys->p_image->width )
+            {
+                p_pic->p->b_margin = 0;
+            }
+            else
+            {
+                p_pic->p->b_margin = 1;
+                p_pic->p->b_hidden = 1;
+                p_pic->p->i_visible_bytes = 4 * p_pic->p_sys->p_image->width;
+            }
 
             p_pic->i_planes = 1;
 
@@ -1350,9 +1325,8 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
             /* Unknown chroma, tell the guy to get lost */
             IMAGE_FREE( p_pic->p_sys->p_image );
             free( p_pic->p_sys );
-            intf_ErrMsg( "vout error: never heard of chroma 0x%.8x (%4.4s)",
-                         p_vout->output.i_chroma,
-                         (char*)&p_vout->output.i_chroma );
+            msg_Err( p_vout, "never heard of chroma 0x%.8x (%4.4s)",
+                     p_vout->output.i_chroma, (char*)&p_vout->output.i_chroma );
             p_pic->i_planes = 0;
             return -1;
     }
@@ -1371,6 +1345,7 @@ static int NewPicture( vout_thread_t *p_vout, picture_t *p_pic )
 static void FreePicture( vout_thread_t *p_vout, picture_t *p_pic )
 {
     /* The order of operations is correct */
+#ifdef HAVE_SYS_SHM_H
     if( p_vout->p_sys->b_shm )
     {
         XShmDetach( p_vout->p_sys->p_display, &p_pic->p_sys->shminfo );
@@ -1379,15 +1354,17 @@ static void FreePicture( vout_thread_t *p_vout, picture_t *p_pic )
         shmctl( p_pic->p_sys->shminfo.shmid, IPC_RMID, 0 );
         if( shmdt( p_pic->p_sys->shminfo.shmaddr ) )
         {
-            intf_ErrMsg( "vout error: cannot detach shared memory (%s)",
-                         strerror(errno) );
+            msg_Err( p_vout, "cannot detach shared memory (%s)",
+                             strerror(errno) );
         }
     }
     else
+#endif
     {
         IMAGE_FREE( p_pic->p_sys->p_image );
     }
 
+    /* Do NOT use XFlush here ! */
     XSync( p_vout->p_sys->p_display, False );
 
     free( p_pic->p_sys );
@@ -1397,122 +1374,222 @@ static void FreePicture( vout_thread_t *p_vout, picture_t *p_pic )
  * ToggleFullScreen: Enable or disable full screen mode
  *****************************************************************************
  * This function will switch between fullscreen and window mode.
- *
  *****************************************************************************/
 static void ToggleFullScreen ( vout_thread_t *p_vout )
 {
-  Atom prop;
-  mwmhints_t mwmhints;
-  int i_xpos, i_ypos, i_width, i_height;
-
-  p_vout->b_fullscreen = !p_vout->b_fullscreen;
-
-  if( p_vout->b_fullscreen )
-  {
-      Window next_parent, parent, *p_dummy, dummy1;
-      unsigned int dummy2, dummy3;
-     
-      intf_WarnMsg( 3, "vout: entering fullscreen mode" );
-
-      /* Save current window coordinates so they can be restored when
-       * we exit from fullscreen mode */
-
-      /* find the real parent, which means the which is a direct child of
-       * the root window */
-      next_parent = parent = p_vout->p_sys->window;
-      while( next_parent != DefaultRootWindow( p_vout->p_sys->p_display ) )
-      {
-          parent = next_parent;
-          XQueryTree( p_vout->p_sys->p_display,
-                      parent,
+    Atom prop;
+    mwmhints_t mwmhints;
+    int i_xpos, i_ypos, i_width, i_height;
+    XSetWindowAttributes attributes;
+
+    p_vout->b_fullscreen = !p_vout->b_fullscreen;
+
+    if( p_vout->b_fullscreen )
+    {
+        Window next_parent, parent, *p_dummy, dummy1;
+        unsigned int dummy2, dummy3;
+
+        msg_Dbg( p_vout, "entering fullscreen mode" );
+
+        /* Only check the fullscreen method when we actually go fullscreen,
+         * because to go back to window mode we need to know in which
+         * fullscreen mode we where */
+        p_vout->p_sys->b_altfullscreen =
+            config_GetInt( p_vout, MODULE_STRING "-altfullscreen" );
+
+        /* Save current window coordinates so they can be restored when
+         * we exit from fullscreen mode. This is the tricky part because
+         * this heavily depends on the behaviour of the window manager.
+         * When you use XMoveWindow some window managers will adjust the top
+         * of the window to the coordinates you gave, but others will instead
+         * adjust the top of the client area to the coordinates
+         * (don't forget windows have decorations). */
+
+        /* First, get the position and size of the client area */
+        XGetGeometry( p_vout->p_sys->p_display,
+                      p_vout->p_sys->window,
                       &dummy1,
-                      &next_parent,
-                      &p_dummy,
-                      &dummy2 );
-          XFree((void *)p_dummy);
-      }
-
-      XGetGeometry( p_vout->p_sys->p_display,
-                    p_vout->p_sys->window,
-                    &dummy1,
-                    &dummy2,
-                    &dummy3,
-                    &p_vout->p_sys->i_width_backup,
-                    &p_vout->p_sys->i_height_backup,
-                    &dummy2, &dummy3 );
-
-      XTranslateCoordinates( p_vout->p_sys->p_display,
-                             parent,
-                             DefaultRootWindow( p_vout->p_sys->p_display ),
-                             0,
-                             0,
-                             &p_vout->p_sys->i_xpos_backup,
-                             &p_vout->p_sys->i_ypos_backup,
-                             &dummy1 );
-
-      mwmhints.flags = MWM_HINTS_DECORATIONS;
-      mwmhints.decorations = 0;
-
-      i_xpos = 0;
-      i_ypos = 0;
-      i_width = DisplayWidth( p_vout->p_sys->p_display,
-                              p_vout->p_sys->i_screen );
-      i_height = DisplayHeight( p_vout->p_sys->p_display,
+                      &dummy2,
+                      &dummy3,
+                      &p_vout->p_sys->i_width_backup_2,
+                      &p_vout->p_sys->i_height_backup_2,
+                      &dummy2, &dummy3 );
+        XTranslateCoordinates( p_vout->p_sys->p_display,
+                               p_vout->p_sys->window,
+                               DefaultRootWindow( p_vout->p_sys->p_display ),
+                               0,
+                               0,
+                               &p_vout->p_sys->i_xpos_backup_2,
+                               &p_vout->p_sys->i_ypos_backup_2,
+                               &dummy1 );
+
+        /* Then try to get the position and size of the whole window */
+
+        /* find the real parent of our window (created by the window manager),
+         * the one which is a direct child of the root window */
+        next_parent = parent = p_vout->p_sys->window;
+        while( next_parent != DefaultRootWindow( p_vout->p_sys->p_display ) )
+        {
+            parent = next_parent;
+            XQueryTree( p_vout->p_sys->p_display,
+                        parent,
+                        &dummy1,
+                        &next_parent,
+                        &p_dummy,
+                        &dummy2 );
+            XFree((void *)p_dummy);
+        }
+
+        XGetGeometry( p_vout->p_sys->p_display,
+                      p_vout->p_sys->window,
+                      &dummy1,
+                      &dummy2,
+                      &dummy3,
+                      &p_vout->p_sys->i_width_backup,
+                      &p_vout->p_sys->i_height_backup,
+                      &dummy2, &dummy3 );
+
+        XTranslateCoordinates( p_vout->p_sys->p_display,
+                               parent,
+                               DefaultRootWindow( p_vout->p_sys->p_display ),
+                               0,
+                               0,
+                               &p_vout->p_sys->i_xpos_backup,
+                               &p_vout->p_sys->i_ypos_backup,
+                               &dummy1 );
+
+        /* fullscreen window size and position */
+        i_xpos = 0;
+        i_ypos = 0;
+        i_width = DisplayWidth( p_vout->p_sys->p_display,
                                 p_vout->p_sys->i_screen );
+        i_height = DisplayHeight( p_vout->p_sys->p_display,
+                                  p_vout->p_sys->i_screen );
 
-#if 0
-      /* Being a transient window allows us to really be fullscreen (display
-       * over the taskbar for instance) but then we end-up with the same
-       * result as with the brute force method */
-      XSetTransientForHint( p_vout->p_sys->p_display,
-                            p_vout->p_sys->window, None );
-#endif
-  }
-  else
-  {
-      intf_WarnMsg( 3, "vout: leaving fullscreen mode" );
-      
-      mwmhints.flags = MWM_HINTS_DECORATIONS;
-      mwmhints.decorations = 1;
-
-      i_xpos = p_vout->p_sys->i_xpos_backup;
-      i_ypos = p_vout->p_sys->i_ypos_backup;
-      i_width = p_vout->p_sys->i_width_backup;
-      i_height = p_vout->p_sys->i_height_backup;
-  }
-
-  /* To my knowledge there are two ways to create a borderless window.
-   * There's the generic way which is to tell x to bypass the window manager,
-   * but this creates problems with the focus of other applications.
-   * The other way is to use the motif property "_MOTIF_WM_HINTS" which
-   * luckily seems to be supported by most window managers.
-   */
-  prop = XInternAtom( p_vout->p_sys->p_display, "_MOTIF_WM_HINTS",
-                      False );
-  XChangeProperty( p_vout->p_sys->p_display, p_vout->p_sys->window,
-                   prop, prop, 32, PropModeReplace,
-                   (unsigned char *)&mwmhints,
-                   PROP_MWM_HINTS_ELEMENTS );
-#if 0 /* brute force way to remove decorations */
-  XSetWindowAttributes attributes;
-  attributes.override_redirect = True;
-  XChangeWindowAttributes( p_vout->p_sys->p_display,
-                           p_vout->p_sys->window,
-                           CWOverrideRedirect,
-                           &attributes);
-#endif
+    }
+    else
+    {
+        msg_Dbg( p_vout, "leaving fullscreen mode" );
+
+        i_xpos = p_vout->p_sys->i_xpos_backup;
+        i_ypos = p_vout->p_sys->i_ypos_backup;
+        i_width = p_vout->p_sys->i_width_backup;
+        i_height = p_vout->p_sys->i_height_backup;
+    }
+
+    /* To my knowledge there are two ways to create a borderless window.
+     * There's the generic way which is to tell x to bypass the window manager,
+     * but this creates problems with the focus of other applications.
+     * The other way is to use the motif property "_MOTIF_WM_HINTS" which
+     * luckily seems to be supported by most window managers.
+     */
+    if( !p_vout->p_sys->b_altfullscreen )
+    {
+        mwmhints.flags = MWM_HINTS_DECORATIONS;
+        mwmhints.decorations = !p_vout->b_fullscreen;
+
+        prop = XInternAtom( p_vout->p_sys->p_display, "_MOTIF_WM_HINTS",
+                            False );
+        XChangeProperty( p_vout->p_sys->p_display, p_vout->p_sys->window,
+                         prop, prop, 32, PropModeReplace,
+                         (unsigned char *)&mwmhints,
+                         PROP_MWM_HINTS_ELEMENTS );
+    }
+    else
+    {
+        /* brute force way to remove decorations */
+        attributes.override_redirect = p_vout->b_fullscreen;
+        XChangeWindowAttributes( p_vout->p_sys->p_display,
+                                 p_vout->p_sys->window,
+                                 CWOverrideRedirect,
+                                 &attributes);
+    }
 
-  /* We need to unmap and remap the window if we want the window 
-   * manager to take our changes into effect */
-  XUnmapWindow( p_vout->p_sys->p_display, p_vout->p_sys->window);
-  XMapRaised( p_vout->p_sys->p_display, p_vout->p_sys->window);
-  XMoveResizeWindow( p_vout->p_sys->p_display,
+    /* We need to reparent the window if we want the window 
+     * manager to take our changes into effect. We also resize the window
+     * twice to avoid an annoying flickering. */
+    if( !p_vout->b_fullscreen )
+        XMoveResizeWindow( p_vout->p_sys->p_display,
+                           p_vout->p_sys->window,
+                           i_xpos,
+                           i_ypos,
+                           i_width,
+                           i_height );
+    XReparentWindow( p_vout->p_sys->p_display,
                      p_vout->p_sys->window,
-                     i_xpos,
-                     i_ypos,
-                     i_width,
-                     i_height );
-  XFlush( p_vout->p_sys->p_display );
+                     DefaultRootWindow( p_vout->p_sys->p_display ),
+                     0, 0 );
+    XMoveResizeWindow( p_vout->p_sys->p_display,
+                       p_vout->p_sys->window,
+                       i_xpos,
+                       i_ypos,
+                       i_width,
+                       i_height );
+    XSync( p_vout->p_sys->p_display, True );
+
+    /* We need to check that the window was really restored where we wanted */
+    if( !p_vout->b_fullscreen )
+    {
+        Window dummy1;
+        unsigned int dummy2, dummy3, dummy4, dummy5;
+
+        /* Check the position */
+        XTranslateCoordinates( p_vout->p_sys->p_display,
+                               p_vout->p_sys->window,
+                               DefaultRootWindow( p_vout->p_sys->p_display ),
+                               0,
+                               0,
+                               &dummy2,
+                               &dummy3,
+                               &dummy1 );
+        if( dummy2 != p_vout->p_sys->i_xpos_backup_2 ||
+            dummy3 != p_vout->p_sys->i_ypos_backup_2 )
+        {
+            /* Ok it didn't work... second try */
+
+            XMoveWindow( p_vout->p_sys->p_display,
+                         p_vout->p_sys->window,
+                         p_vout->p_sys->i_xpos_backup_2,
+                         p_vout->p_sys->i_ypos_backup_2 );
+
+            XSync( p_vout->p_sys->p_display, True );
+        }
+
+        /* Check the size */
+        XGetGeometry( p_vout->p_sys->p_display,
+                      p_vout->p_sys->window,
+                      &dummy1,
+                      &dummy2,
+                      &dummy3,
+                      &dummy4,
+                      &dummy5,
+                      &dummy2, &dummy3 );
+
+        if( dummy4 != p_vout->p_sys->i_width_backup_2 ||
+            dummy5 != p_vout->p_sys->i_height_backup_2 )
+        {
+            /* Ok it didn't work... third try */
+
+            XResizeWindow( p_vout->p_sys->p_display,
+                         p_vout->p_sys->window,
+                         p_vout->p_sys->i_width_backup_2,
+                         p_vout->p_sys->i_height_backup_2 );
+
+            XSync( p_vout->p_sys->p_display, True );
+        }
+    }
+
+    if( p_vout->p_sys->b_altfullscreen && p_vout->b_fullscreen )
+        XSetInputFocus(p_vout->p_sys->p_display,
+                       p_vout->p_sys->window,
+                       RevertToParent,
+                       CurrentTime);
+
+    /* signal that the size needs to be updated */
+    p_vout->p_sys->i_width = i_width;
+    p_vout->p_sys->i_height = i_height;
+    p_vout->i_changes |= VOUT_SIZE_CHANGE;
+
 }
 
 /*****************************************************************************
@@ -1525,15 +1602,17 @@ static void ToggleFullScreen ( vout_thread_t *p_vout )
  *****************************************************************************/
 static void EnableXScreenSaver( vout_thread_t *p_vout )
 {
+#ifdef DPMSINFO_IN_DPMS_H
     int dummy;
+#endif
 
-    intf_DbgMsg( "vout: enabling screen saver" );
     XSetScreenSaver( p_vout->p_sys->p_display, p_vout->p_sys->i_ss_timeout,
                      p_vout->p_sys->i_ss_interval,
                      p_vout->p_sys->i_ss_blanking,
                      p_vout->p_sys->i_ss_exposure );
 
     /* Restore DPMS settings */
+#ifdef DPMSINFO_IN_DPMS_H
     if( DPMSQueryExtension( p_vout->p_sys->p_display, &dummy, &dummy ) )
     {
         if( p_vout->p_sys->b_ss_dpms )
@@ -1541,6 +1620,7 @@ static void EnableXScreenSaver( vout_thread_t *p_vout )
             DPMSEnable( p_vout->p_sys->p_display );
         }
     }
+#endif
 }
 
 /*****************************************************************************
@@ -1550,7 +1630,9 @@ static void EnableXScreenSaver( vout_thread_t *p_vout )
  *****************************************************************************/
 static void DisableXScreenSaver( vout_thread_t *p_vout )
 {
+#ifdef DPMSINFO_IN_DPMS_H
     int dummy;
+#endif
 
     /* Save screen saver informations */
     XGetScreenSaver( p_vout->p_sys->p_display, &p_vout->p_sys->i_ss_timeout,
@@ -1559,22 +1641,22 @@ static void DisableXScreenSaver( vout_thread_t *p_vout )
                      &p_vout->p_sys->i_ss_exposure );
 
     /* Disable screen saver */
-    intf_DbgMsg( "vout: disabling screen saver" );
     XSetScreenSaver( p_vout->p_sys->p_display, 0,
                      p_vout->p_sys->i_ss_interval,
                      p_vout->p_sys->i_ss_blanking,
                      p_vout->p_sys->i_ss_exposure );
 
     /* Disable DPMS */
+#ifdef DPMSINFO_IN_DPMS_H
     if( DPMSQueryExtension( p_vout->p_sys->p_display, &dummy, &dummy ) )
     {
-        CARD16 dummy;
+        CARD16 unused;
         /* Save DPMS current state */
-        DPMSInfo( p_vout->p_sys->p_display, &dummy,
+        DPMSInfo( p_vout->p_sys->p_display, &unused,
                   &p_vout->p_sys->b_ss_dpms );
-        intf_DbgMsg( "vout: disabling DPMS" );
         DPMSDisable( p_vout->p_sys->p_display );
    }
+#endif
 }
 
 /*****************************************************************************
@@ -1640,52 +1722,54 @@ static void ToggleCursor( vout_thread_t *p_vout )
 /*****************************************************************************
  * XVideoGetPort: get YUV12 port
  *****************************************************************************/
-static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
+static int XVideoGetPort( vout_thread_t *p_vout,
+                          u32 i_chroma, u32 *pi_newchroma )
 {
     XvAdaptorInfo *p_adaptor;
     unsigned int i;
     int i_adaptor, i_num_adaptors, i_requested_adaptor;
     int i_selected_port;
 
-    switch( XvQueryExtension( dpy, &i, &i, &i, &i, &i ) )
+    switch( XvQueryExtension( p_vout->p_sys->p_display, &i, &i, &i, &i, &i ) )
     {
         case Success:
             break;
 
         case XvBadExtension:
-            intf_WarnMsg( 3, "vout error: XvBadExtension" );
+            msg_Warn( p_vout, "XvBadExtension" );
             return( -1 );
 
         case XvBadAlloc:
-            intf_WarnMsg( 3, "vout error: XvBadAlloc" );
+            msg_Warn( p_vout, "XvBadAlloc" );
             return( -1 );
 
         default:
-            intf_WarnMsg( 3, "vout error: XvQueryExtension failed" );
+            msg_Warn( p_vout, "XvQueryExtension failed" );
             return( -1 );
     }
 
-    switch( XvQueryAdaptors( dpy, DefaultRootWindow( dpy ),
+    switch( XvQueryAdaptors( p_vout->p_sys->p_display,
+                             DefaultRootWindow( p_vout->p_sys->p_display ),
                              &i_num_adaptors, &p_adaptor ) )
     {
         case Success:
             break;
 
         case XvBadExtension:
-            intf_WarnMsg( 3, "vout error: XvBadExtension for XvQueryAdaptors" );
+            msg_Warn( p_vout, "XvBadExtension for XvQueryAdaptors" );
             return( -1 );
 
         case XvBadAlloc:
-            intf_WarnMsg( 3, "vout error: XvBadAlloc for XvQueryAdaptors" );
+            msg_Warn( p_vout, "XvBadAlloc for XvQueryAdaptors" );
             return( -1 );
 
         default:
-            intf_WarnMsg( 3, "vout error: XvQueryAdaptors failed" );
+            msg_Warn( p_vout, "XvQueryAdaptors failed" );
             return( -1 );
     }
 
     i_selected_port = -1;
-    i_requested_adaptor = main_GetIntVariable( VOUT_XVADAPTOR_VAR, -1 );
+    i_requested_adaptor = config_GetInt( p_vout, "xvideo-adaptor" );
 
     for( i_adaptor = 0; i_adaptor < i_num_adaptors; ++i_adaptor )
     {
@@ -1708,17 +1792,21 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
         }
 
         /* Check that adaptor supports our requested format... */
-        p_formats = XvListImageFormats( dpy, p_adaptor[i_adaptor].base_id,
+        p_formats = XvListImageFormats( p_vout->p_sys->p_display,
+                                        p_adaptor[i_adaptor].base_id,
                                         &i_num_formats );
 
         for( i_format = 0;
              i_format < i_num_formats && ( i_selected_port == -1 );
              i_format++ )
         {
+            /* Code removed, we can get this through xvinfo anyway */
+#if 0
             XvEncodingInfo  *p_enc;
             int             i_enc, i_num_encodings;
             XvAttribute     *p_attr;
             int             i_attr, i_num_attributes;
+#endif
 
             /* If this is not the format we want, or at least a
              * similar one, forget it */
@@ -1734,7 +1822,8 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
                    && ( i_selected_port == -1 );
                  i_port++ )
             {
-                if( XvGrabPort( dpy, i_port, CurrentTime ) == Success )
+                if( XvGrabPort( p_vout->p_sys->p_display, i_port, CurrentTime )
+                     == Success )
                 {
                     i_selected_port = i_port;
                     *pi_newchroma = p_formats[ i_format ].id;
@@ -1748,32 +1837,31 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
             }
 
             /* If we found a port, print information about it */
-            intf_WarnMsg( 3, "vout: found adaptor %i, port %i, "
-                             "image format 0x%x (%4.4s) %s",
-                             i_adaptor, i_selected_port,
-                             p_formats[ i_format ].id,
-                             (char *)&p_formats[ i_format ].id,
-                             ( p_formats[ i_format ].format
-                                == XvPacked ) ? "packed" : "planar" );
+            msg_Dbg( p_vout, "adaptor %i, port %i, format 0x%x (%4.4s) %s",
+                     i_adaptor, i_selected_port, p_formats[ i_format ].id,
+                     (char *)&p_formats[ i_format ].id,
+                     ( p_formats[ i_format ].format == XvPacked ) ?
+                         "packed" : "planar" );
 
-            intf_WarnMsg( 10, " encoding list:" );
+#if 0
+            msg_Dbg( p_vout, " encoding list:" );
 
-            if( XvQueryEncodings( dpy, i_selected_port,
+            if( XvQueryEncodings( p_vout->p_sys->p_display, i_selected_port,
                                   &i_num_encodings, &p_enc )
                  != Success )
             {
-                intf_WarnMsg( 10, "  XvQueryEncodings failed" );
+                msg_Dbg( p_vout, "  XvQueryEncodings failed" );
                 continue;
             }
 
             for( i_enc = 0; i_enc < i_num_encodings; i_enc++ )
             {
-                intf_WarnMsg( 10, "  id=%ld, name=%s, size=%ldx%ld,"
-                                  " numerator=%d, denominator=%d",
-                              p_enc[i_enc].encoding_id, p_enc[i_enc].name,
-                              p_enc[i_enc].width, p_enc[i_enc].height,
-                              p_enc[i_enc].rate.numerator,
-                              p_enc[i_enc].rate.denominator );
+                msg_Dbg( p_vout, "  id=%ld, name=%s, size=%ldx%ld,"
+                                      " numerator=%d, denominator=%d",
+                             p_enc[i_enc].encoding_id, p_enc[i_enc].name,
+                             p_enc[i_enc].width, p_enc[i_enc].height,
+                             p_enc[i_enc].rate.numerator,
+                             p_enc[i_enc].rate.denominator );
             }
 
             if( p_enc != NULL )
@@ -1781,13 +1869,13 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
                 XvFreeEncodingInfo( p_enc );
             }
 
-            intf_WarnMsg( 10, " attribute list:" );
-            p_attr = XvQueryPortAttributes( dpy, i_selected_port,
+            msg_Dbg( p_vout, " attribute list:" );
+            p_attr = XvQueryPortAttributes( p_vout->p_sys->p_display,
+                                            i_selected_port,
                                             &i_num_attributes );
             for( i_attr = 0; i_attr < i_num_attributes; i_attr++ )
             {
-                intf_WarnMsg( 10,
-                      "  name=%s, flags=[%s%s ], min=%i, max=%i",
+                msg_Dbg( p_vout, "  name=%s, flags=[%s%s ], min=%i, max=%i",
                       p_attr[i_attr].name,
                       (p_attr[i_attr].flags & XvGettable) ? " get" : "",
                       (p_attr[i_attr].flags & XvSettable) ? " set" : "",
@@ -1798,6 +1886,7 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
             {
                 XFree( p_attr );
             }
+#endif
         }
 
         if( p_formats != NULL )
@@ -1816,14 +1905,14 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
     {
         if( i_requested_adaptor == -1 )
         {
-            intf_WarnMsg( 3, "vout: no free XVideo port found for format "
-                             "0x%.8x (%4.4s)", i_chroma, (char*)&i_chroma );
+            msg_Warn( p_vout, "no free XVideo port found for format "
+                       "0x%.8x (%4.4s)", i_chroma, (char*)&i_chroma );
         }
         else
         {
-            intf_WarnMsg( 3, "vout: XVideo adaptor %i does not have a free "
-                             "XVideo port for format 0x%.8x (%4.4s)",
-                             i_requested_adaptor, i_chroma, (char*)&i_chroma );
+            msg_Warn( p_vout, "XVideo adaptor %i does not have a free "
+                       "XVideo port for format 0x%.8x (%4.4s)",
+                       i_requested_adaptor, i_chroma, (char*)&i_chroma );
         }
     }
 
@@ -1833,9 +1922,9 @@ static int XVideoGetPort( Display *dpy, u32 i_chroma, u32 *pi_newchroma )
 /*****************************************************************************
  * XVideoReleasePort: release YUV12 port
  *****************************************************************************/
-static void XVideoReleasePort( Display *dpy, int i_port )
+static void XVideoReleasePort( vout_thread_t *p_vout, int i_port )
 {
-    XvUngrabPort( dpy, i_port, CurrentTime );
+    XvUngrabPort( p_vout->p_sys->p_display, i_port, CurrentTime );
 }
 #endif
 
@@ -1854,16 +1943,18 @@ static int InitDisplay( vout_thread_t *p_vout )
     int                         i_count;                       /* array size */
 #endif
 
-#ifdef SYS_DARWIN
+#ifdef HAVE_SYS_SHM_H
+#   ifdef SYS_DARWIN
     /* FIXME : As of 2001-03-16, XFree4 for MacOS X does not support Xshm. */
     p_vout->p_sys->b_shm = 0;
-#else
+#   else
     p_vout->p_sys->b_shm = ( XShmQueryExtension( p_vout->p_sys->p_display )
                               == True );
-#endif
+#   endif
     if( !p_vout->p_sys->b_shm )
+#endif
     {
-        intf_WarnMsg( 1, "vout warning: XShm video extension is unavailable" );
+        msg_Warn( p_vout, "XShm video extension is unavailable" );
     }
 
 #ifdef MODULE_NAME_IS_xvideo
@@ -1895,10 +1986,11 @@ static int InitDisplay( vout_thread_t *p_vout )
                                     &xvisual_template, &i_count );
         if( p_xvisual == NULL )
         {
-            intf_ErrMsg( "vout error: no PseudoColor visual available" );
+            msg_Err( p_vout, "no PseudoColor visual available" );
             return( 1 );
         }
         p_vout->p_sys->i_bytes_per_pixel = 1;
+        p_vout->output.pf_setpalette = SetPalette;
         break;
     case 15:
     case 16:
@@ -1914,12 +2006,13 @@ static int InitDisplay( vout_thread_t *p_vout )
                                     &xvisual_template, &i_count );
         if( p_xvisual == NULL )
         {
-            intf_ErrMsg( "vout error: no TrueColor visual available" );
+            msg_Err( p_vout, "no TrueColor visual available" );
             return( 1 );
         }
-        p_vout->p_sys->i_red_mask =        p_xvisual->red_mask;
-        p_vout->p_sys->i_green_mask =      p_xvisual->green_mask;
-        p_vout->p_sys->i_blue_mask =       p_xvisual->blue_mask;
+
+        p_vout->output.i_rmask = p_xvisual->red_mask;
+        p_vout->output.i_gmask = p_xvisual->green_mask;
+        p_vout->output.i_bmask = p_xvisual->blue_mask;
 
         /* There is no difference yet between 3 and 4 Bpp. The only way
          * to find the actual number of bytes per pixel is to list supported
@@ -1950,6 +2043,7 @@ static int InitDisplay( vout_thread_t *p_vout )
     return( 0 );
 }
 
+#ifdef HAVE_SYS_SHM_H
 /*****************************************************************************
  * CreateShmImage: create an XImage or XvImage using shared memory extension
  *****************************************************************************
@@ -1958,7 +2052,8 @@ static int InitDisplay( vout_thread_t *p_vout )
  * document by J.Corbet and K.Packard. Most of the parameters were copied from
  * there. See http://ftp.xfree86.org/pub/XFree86/4.0/doc/mit-shm.TXT
  *****************************************************************************/
-static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
+static IMAGE_TYPE * CreateShmImage( vout_thread_t *p_vout,
+                                    Display* p_display, EXTRA_ARGS_SHM,
                                     int i_width, int i_height )
 {
     IMAGE_TYPE *p_image;
@@ -1973,7 +2068,7 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
 #endif
     if( p_image == NULL )
     {
-        intf_ErrMsg( "vout error: image creation failed." );
+        msg_Err( p_vout, "image creation failed" );
         return( NULL );
     }
 
@@ -1982,8 +2077,8 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
     p_shm->shmid = shmget( IPC_PRIVATE, DATA_SIZE(p_image), IPC_CREAT | 0776 );
     if( p_shm->shmid < 0 )
     {
-        intf_ErrMsg( "vout error: cannot allocate shared image data (%s)",
-                     strerror( errno ) );
+        msg_Err( p_vout, "cannot allocate shared image data (%s)",
+                         strerror( errno ) );
         IMAGE_FREE( p_image );
         return( NULL );
     }
@@ -1992,8 +2087,8 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
     p_shm->shmaddr = p_image->data = shmat( p_shm->shmid, 0, 0 );
     if(! p_shm->shmaddr )
     {
-        intf_ErrMsg( "vout error: cannot attach shared memory (%s)",
-                    strerror(errno));
+        msg_Err( p_vout, "cannot attach shared memory (%s)",
+                         strerror(errno));
         IMAGE_FREE( p_image );
         shmctl( p_shm->shmid, IPC_RMID, 0 );
         return( NULL );
@@ -2005,7 +2100,7 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
     /* Attach shared memory segment to X server */
     if( XShmAttach( p_display, p_shm ) == False )
     {
-        intf_ErrMsg( "vout error: cannot attach shared memory to X server" );
+        msg_Err( p_vout, "cannot attach shared memory to X server" );
         IMAGE_FREE( p_image );
         shmctl( p_shm->shmid, IPC_RMID, 0 );
         shmdt( p_shm->shmaddr );
@@ -2013,7 +2108,8 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
     }
 
     /* Send image to X server. This instruction is required, since having
-     * built a Shm XImage and not using it causes an error on XCloseDisplay */
+     * built a Shm XImage and not using it causes an error on XCloseDisplay,
+     * and remember NOT to use XFlush ! */
     XSync( p_display, False );
 
 #if 0
@@ -2024,13 +2120,15 @@ static IMAGE_TYPE * CreateShmImage( Display* p_display, EXTRA_ARGS_SHM,
 
     return( p_image );
 }
+#endif
 
 /*****************************************************************************
  * CreateImage: create an XImage or XvImage
  *****************************************************************************
  * Create a simple image used as a buffer.
  *****************************************************************************/
-static IMAGE_TYPE * CreateImage( Display *p_display, EXTRA_ARGS,
+static IMAGE_TYPE * CreateImage( vout_thread_t *p_vout,
+                                 Display *p_display, EXTRA_ARGS,
                                  int i_width, int i_height )
 {
     byte_t *    p_data;                           /* image data storage zone */
@@ -2049,7 +2147,7 @@ static IMAGE_TYPE * CreateImage( Display *p_display, EXTRA_ARGS,
 #endif
     if( !p_data )
     {
-        intf_ErrMsg( "vout error: %s", strerror(ENOMEM));
+        msg_Err( p_vout, "out of memory" );
         return( NULL );
     }
 
@@ -2080,7 +2178,7 @@ static IMAGE_TYPE * CreateImage( Display *p_display, EXTRA_ARGS,
 #endif
     if( p_image == NULL )
     {
-        intf_ErrMsg( "vout error: XCreateImage() failed" );
+        msg_Err( p_vout, "XCreateImage() failed" );
         free( p_data );
         return( NULL );
     }
@@ -2088,3 +2186,33 @@ static IMAGE_TYPE * CreateImage( Display *p_display, EXTRA_ARGS,
     return p_image;
 }
 
+#ifdef MODULE_NAME_IS_x11
+/*****************************************************************************
+ * SetPalette: sets an 8 bpp palette
+ *****************************************************************************
+ * This function sets the palette given as an argument. It does not return
+ * anything, but could later send information on which colors it was unable
+ * to set.
+ *****************************************************************************/
+static void SetPalette( vout_thread_t *p_vout, u16 *red, u16 *green, u16 *blue )
+{
+    int i;
+    XColor p_colors[255];
+
+    /* allocate palette */
+    for( i = 0; i < 255; i++ )
+    {
+        /* kludge: colors are indexed reversely because color 255 seems
+         * to be reserved for black even if we try to set it to white */
+        p_colors[ i ].pixel = 255 - i;
+        p_colors[ i ].pad   = 0;
+        p_colors[ i ].flags = DoRed | DoGreen | DoBlue;
+        p_colors[ i ].red   = red[ 255 - i ];
+        p_colors[ i ].blue  = blue[ 255 - i ];
+        p_colors[ i ].green = green[ 255 - i ];
+    }
+
+    XStoreColors( p_vout->p_sys->p_display,
+                  p_vout->p_sys->colormap, p_colors, 255 );
+}
+#endif