]> git.sesse.net Git - vlc/blobdiff - projects/mozilla/vlcplugin.cpp
Release the display mode when we are done with it.
[vlc] / projects / mozilla / vlcplugin.cpp
index 0ea739c0d86505651c04e1217fb955649546e1c4..2fabfc049959edb76109911db9c7d90bb1d5aee1 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * vlcplugin.cpp: a VLC plugin for Mozilla
  *****************************************************************************
- * Copyright (C) 2002-2009 the VideoLAN team
+ * Copyright (C) 2002-2010 the VideoLAN team
  * $Id$
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *****************************************************************************/
 #include "config.h"
 
-#ifdef HAVE_MOZILLA_CONFIG_H
-#   include <mozilla-config.h>
-#endif
-
 #include "vlcplugin.h"
+
 #include "control/npolibvlc.h"
 
 #include <ctype.h>
-#include <pthread.h>
+
+#if defined(XP_UNIX)
+#   include <pthread.h>
+#elif defined(XP_WIN)
+    /* windows headers */
+#   include <winbase.h>
+#else
+#warning "locking not implemented for this platform"
+#endif
+
 #include <stdio.h>
+#include <assert.h>
+#include <stdlib.h>
 
 /*****************************************************************************
- * VlcPlugin constructor and destructor
+ * utilitiy functions
  *****************************************************************************/
-VlcPlugin::VlcPlugin( NPP instance, uint16 mode ) :
-    i_npmode(mode),
-    b_stream(0),
-    b_autoplay(1),
-    b_toolbar(0),
-    psz_text(NULL),
-    psz_target(NULL),
-    playlist_index(-1),
-    libvlc_instance(NULL),
-    libvlc_media_list(NULL),
-    libvlc_media_player(NULL),
-    p_scriptClass(NULL),
-    p_browser(instance),
-    psz_baseURL(NULL)
-#if defined(XP_WIN)
-    ,pf_wndproc(NULL)
-#endif
+static void plugin_lock_init(plugin_lock_t *lock)
+{
+    assert(lock);
+
 #if defined(XP_UNIX)
-    ,i_width((unsigned)-1)
-    ,i_height((unsigned)-1)
-    ,i_tb_width(0)
-    ,i_tb_height(0)
-    ,i_last_position(0)
-    ,p_btnPlay(NULL)
-    ,p_btnPause(NULL)
-    ,p_btnStop(NULL)
-    ,p_btnMute(NULL)
-    ,p_btnUnmute(NULL)
-    ,p_btnFullscreen(NULL)
-    ,p_btnTime(NULL)
-    ,p_timeline(NULL)
+    pthread_mutex_init(&lock->mutex, NULL);
+#elif defined(XP_WIN)
+    InitializeCriticalSection(&lock->cs);
+#else
+#warning "locking not implemented in this platform"
 #endif
+}
+
+static void plugin_lock_destroy(plugin_lock_t *lock)
 {
-    memset(&npwindow, 0, sizeof(NPWindow));
+    assert(lock);
+
 #if defined(XP_UNIX)
-    memset(&npvideo, 0, sizeof(Window));
-    memset(&npcontrol, 0, sizeof(Window));
+    pthread_mutex_destroy(&lock->mutex);
+#elif defined(XP_WIN)
+    DeleteCriticalSection(&lock->cs);
+#else
+#warning "locking not implemented in this platform"
 #endif
 }
 
-static bool boolValue(const char *value) {
-    return ( !strcmp(value, "1") ||
-             !strcasecmp(value, "true") ||
-             !strcasecmp(value, "yes") );
-}
+static void plugin_lock(plugin_lock_t *lock)
+{
+    assert(lock);
 
+#if defined(XP_UNIX)
+    pthread_mutex_lock(&lock->mutex);
+#elif defined(XP_WIN)
+    EnterCriticalSection(&lock->cs);
+#else
+#warning "locking not implemented in this platform"
+#endif
+}
 
-void EventObj::deliver(NPP browser)
+static void plugin_unlock(plugin_lock_t *lock)
 {
-    NPVariant result;
-    NPVariant params[1];
+    assert(lock);
 
-    pthread_mutex_lock(&mutex);
+#if defined(XP_UNIX)
+    pthread_mutex_unlock(&lock->mutex);
+#elif defined(XP_WIN)
+    LeaveCriticalSection(&lock->cs);
+#else
+#warning "locking not implemented in this platform"
+#endif
+}
 
-    for( ev_l::iterator i=_elist.begin();i!=_elist.end();++i )
+/*****************************************************************************
+ * Event Object
+ *****************************************************************************/
+static void handle_input_event(const libvlc_event_t* event, void *param);
+static void handle_changed_event(const libvlc_event_t* event, void *param);
+
+static vlcplugin_event_t vlcevents[] = {
+    { "MediaPlayerMediaChanged", libvlc_MediaPlayerMediaChanged, handle_input_event },
+    { "MediaPlayerNothingSpecial", libvlc_MediaPlayerNothingSpecial, handle_input_event },
+    { "MediaPlayerOpening", libvlc_MediaPlayerOpening, handle_input_event },
+    { "MediaPlayerBuffering", libvlc_MediaPlayerBuffering, handle_changed_event },
+    { "MediaPlayerPlaying", libvlc_MediaPlayerPlaying, handle_input_event },
+    { "MediaPlayerPaused", libvlc_MediaPlayerPaused, handle_input_event },
+    { "MediaPlayerStopped", libvlc_MediaPlayerStopped, handle_input_event },
+    { "MediaPlayerForward", libvlc_MediaPlayerForward, handle_input_event },
+    { "MediaPlayerBackward", libvlc_MediaPlayerBackward, handle_input_event },
+    { "MediaPlayerEndReached", libvlc_MediaPlayerEndReached, handle_input_event },
+    { "MediaPlayerEncounteredError", libvlc_MediaPlayerEncounteredError, handle_input_event },
+    { "MediaPlayerTimeChanged", libvlc_MediaPlayerTimeChanged, handle_changed_event },
+    { "MediaPlayerPositionChanged", libvlc_MediaPlayerPositionChanged, handle_changed_event },
+    { "MediaPlayerSeekableChanged", libvlc_MediaPlayerSeekableChanged, handle_changed_event },
+    { "MediaPlayerPausableChanged", libvlc_MediaPlayerPausableChanged, handle_changed_event },
+    { "MediaPlayerTitleChanged", libvlc_MediaPlayerTitleChanged, handle_changed_event },
+    { "MediaPlayerLengthChanged", libvlc_MediaPlayerLengthChanged, handle_changed_event },
+};
+
+static void handle_input_event(const libvlc_event_t* event, void *param)
+{
+    VlcPlugin *plugin = (VlcPlugin*)param;
+    switch( event->type )
     {
-        libvlc_event_type_t event = *i;
-        STRINGZ_TO_NPVARIANT(libvlc_event_type_name(event), params[0]);
+        case libvlc_MediaPlayerNothingSpecial:
+        case libvlc_MediaPlayerOpening:
+        case libvlc_MediaPlayerPlaying:
+        case libvlc_MediaPlayerPaused:
+        case libvlc_MediaPlayerStopped:
+        case libvlc_MediaPlayerForward:
+        case libvlc_MediaPlayerBackward:
+        case libvlc_MediaPlayerEndReached:
+        case libvlc_MediaPlayerEncounteredError:
+            plugin->event_callback(event, NULL, 0, param);
+            break;
+        default: /* ignore all other libvlc_event_type_t */
+            break;
+    }
+}
 
-        // Invalid events aren't supposed to be queued up.
-        // if( !have_event(event) ) continue;
+static void handle_changed_event(const libvlc_event_t* event, void *param)
+{
+    uint32_t   npcount = 1;
+    NPVariant *npparam = (NPVariant *) NPN_MemAlloc( sizeof(NPVariant) * npcount );
 
-        for( lr_l::iterator j=_llist.begin();j!=_llist.end();++j )
-        {
-            if (j->get(event))
-            {
-                NPN_InvokeDefault(browser, j->listener(), params, 1, &result);
-                NPN_ReleaseVariantValue(&result);
-            }
-        }
+    VlcPlugin *plugin = (VlcPlugin*)param;
+    switch( event->type )
+    {
+        case libvlc_MediaPlayerBuffering:
+            DOUBLE_TO_NPVARIANT(event->u.media_player_buffering.new_cache, npparam[0]);
+            break;
+        case libvlc_MediaPlayerTimeChanged:
+            DOUBLE_TO_NPVARIANT(event->u.media_player_time_changed.new_time, npparam[0]);
+            break;
+        case libvlc_MediaPlayerPositionChanged:
+            DOUBLE_TO_NPVARIANT(event->u.media_player_position_changed.new_position, npparam[0]);
+            break;
+        case libvlc_MediaPlayerSeekableChanged:
+            BOOLEAN_TO_NPVARIANT(event->u.media_player_seekable_changed.new_seekable, npparam[0]);
+            break;
+        case libvlc_MediaPlayerPausableChanged:
+            BOOLEAN_TO_NPVARIANT(event->u.media_player_pausable_changed.new_pausable, npparam[0]);
+            break;
+        case libvlc_MediaPlayerTitleChanged:
+            BOOLEAN_TO_NPVARIANT(event->u.media_player_title_changed.new_title, npparam[0]);
+            break;
+        case libvlc_MediaPlayerLengthChanged:
+            DOUBLE_TO_NPVARIANT(event->u.media_player_length_changed.new_length, npparam[0]);
+            break;
+        default: /* ignore all other libvlc_event_type_t */
+            NPN_MemFree( npparam );
+            return;
     }
-    _elist.clear();
+    plugin->event_callback(event, npparam, npcount, param);
+}
 
-    pthread_mutex_unlock(&mutex);
+bool EventObj::init()
+{
+    plugin_lock_init(&lock);
+    return true;
 }
 
-void VlcPlugin::eventAsync(void *param)
+EventObj::~EventObj()
 {
-    VlcPlugin *plugin = (VlcPlugin*)param;
-    plugin->events.deliver(plugin->getBrowser());
+    plugin_lock_destroy(&lock);
 }
 
-void EventObj::callback(const libvlc_event_t* event)
+void EventObj::deliver(NPP browser)
 {
-    pthread_mutex_lock(&mutex);
+    plugin_lock(&lock);
+
+    for( ev_l::iterator iter = _elist.begin(); iter != _elist.end(); ++iter )
+    {
+        for( lr_l::iterator j = _llist.begin(); j != _llist.end(); ++j )
+        {
+            if( j->event_type() == iter->event_type() )
+            {
+                NPVariant result;
+                NPVariant *params = iter->params();
+                uint32_t   count  = iter->count();
+
+                NPObject *listener = j->listener();
+                assert( listener );
+
+                NPN_InvokeDefault( browser, listener, params, count, &result );
+                NPN_ReleaseVariantValue( &result );
 
-    if( have_event(event->type) )
-        _elist.push_back(event->type);
+                for( uint32_t n = 0; n < count; n++ )
+                {
+                    if( NPVARIANT_IS_STRING(params[n]) )
+                        NPN_MemFree( (void*) NPVARIANT_TO_STRING(params[n]).UTF8Characters );
+                    else if( NPVARIANT_IS_OBJECT(params[n]) )
+                    {
+                        NPN_ReleaseObject( NPVARIANT_TO_OBJECT(params[n]) );
+                        NPN_MemFree( (void*)NPVARIANT_TO_OBJECT(params[n]) );
+                    }
+                }
+                if (params) NPN_MemFree( params );
+            }
+        }
+    }
+    _elist.clear();
 
-    pthread_mutex_unlock(&mutex);
+    plugin_unlock(&lock);
 }
 
-void VlcPlugin::event_callback(const libvlc_event_t* event, void *param)
+void EventObj::callback(const libvlc_event_t* event,
+                        NPVariant *npparams, uint32_t count)
 {
-    VlcPlugin *plugin = (VlcPlugin*)param;
-#ifdef XP_UNIX
-    plugin->events.callback(event);
-    NPN_PluginThreadAsyncCall(plugin->getBrowser(), eventAsync, plugin);
-#else
-#warning NPN_PluginThreadAsyncCall not implemented yet.
-    printf("%s","No NPN_PluginThreadAsyncCall(), doing nothing.");
-#endif
+    plugin_lock(&lock);
+    _elist.push_back(VLCEvent(event->type, npparams, count));
+    plugin_unlock(&lock);
 }
 
-inline EventObj::event_t EventObj::find_event(const char *s) const
+vlcplugin_event_t *EventObj::find_event(const char *s) const
 {
-    event_t i;
-    for(i=0;i<maxbit();++i)
-        if(!strcmp(s,libvlc_event_type_name(i)))
-            break;
-    return i;
+    for( int i = 0; i < ARRAY_SIZE(vlcevents); i++ )
+    {
+        if( strncmp(vlcevents[i].name, s, strlen(vlcevents[i].name)) == 0 )
+            return &vlcevents[i];
+    }
+    return NULL;
 }
 
-bool EventObj::insert(const NPString &s, NPObject *l, bool b)
+const char *EventObj::find_name(const libvlc_event_t *event)
 {
-    event_t e = find_event(s.utf8characters);
-    if( e>=maxbit() )
-        return false;
+    for( int i = 0; i < ARRAY_SIZE(vlcevents); i++ )
+    {
+        if( vlcevents[i].libvlc_type == event->type )
+            return vlcevents[i].name;
+    }
+    return NULL;
+}
 
-    if( !have_event(e) && !ask_for_event(e) )
+bool EventObj::insert(const NPString &name, NPObject *listener, bool bubble)
+{
+    vlcplugin_event_t *event = find_event(name.UTF8Characters);
+    if( !event )
         return false;
 
-    lr_l::iterator i;
-    for(i=_llist.begin();i!=_llist.end();++i)
-        if(i->listener()==l && i->bubble()==b)
+    lr_l::iterator iter;
+    for( iter = _llist.begin(); iter != _llist.end(); ++iter )
+        if( iter->listener() == listener && iter->bubble() == bubble )
             break;
 
-    if( i == _llist.end() ) {
-        _llist.push_back(Listener(e,l,b));
-    } else {
-        if( i->get(e) )
-            return false;
-        i->get(e);
+    if( iter == _llist.end() )
+    {
+        _llist.push_back(Listener(event, listener, bubble));
+        return true;
     }
-}
 
+    return false;
+}
 
-bool EventObj::remove(const NPString &s, NPObject *l, bool b)
+bool EventObj::remove(const NPString &name, NPObject *listener, bool bubble)
 {
-    event_t e = find_event(s.utf8characters);
-    if( e>=maxbit() || !get(e) )
+    vlcplugin_event_t *event = find_event(name.UTF8Characters);
+    if( !event )
         return false;
 
-    bool any=false;
-    for(lr_l::iterator i=_llist.begin();i!=_llist.end();)
+    for( lr_l::iterator iter = _llist.begin(); iter !=_llist.end(); iter++ )
     {
-        if(i->listener()!=l || i->bubble()!=b)
-            any|=i->get(e);
-        else
+        if( iter->event_type() == event->libvlc_type &&
+            iter->listener() == listener &&
+            iter->bubble() == bubble )
         {
-            i->reset(e);
-            if(i->empty())
-            {
-                i=_llist.erase(i);
-                continue;
-            }
+            iter = _llist.erase(iter);
+            return true;
         }
-        ++i;
     }
-    if(!any)
-        unask_for_event(e);
-}
 
+    return false;
+}
 
-void EventObj::hook_manager(libvlc_event_manager_t *em,
-                            libvlc_callback_t cb, void *udata)
+void EventObj::hook_manager( libvlc_event_manager_t *em, void *userdata )
 {
-    _em = em; _cb = cb; _ud = udata;
-    if( !_em )
-        return;
-    for(size_t i=0;i<maxbit();++i)
-        if(get(i))
-            libvlc_event_attach(_em, i, _cb, _ud);
+    _em = em;
+
+    if( _em )
+    {
+        /* attach all libvlc events we care about */
+        for( int i = 0; i < ARRAY_SIZE(vlcevents); i++ )
+        {
+            libvlc_event_attach( _em, vlcevents[i].libvlc_type,
+                                      vlcevents[i].libvlc_callback,
+                                      userdata );
+        }
+    }
 }
 
-void EventObj::unhook_manager()
+void EventObj::unhook_manager( void *userdata )
 {
-    if( !_em )
-    return;
-    for(size_t i=0;i<maxbit();++i)
-        if(get(i))
-            libvlc_event_detach(_em, i, _cb, _ud);
+    if( _em )
+    {
+               /* detach all libvlc events we cared about */
+        for( int i = 0; i < ARRAY_SIZE(vlcevents); i++ )
+        {
+            libvlc_event_detach( _em, vlcevents[i].libvlc_type,
+                                      vlcevents[i].libvlc_callback,
+                                      userdata );
+        }
+    }
 }
 
-
-bool EventObj::ask_for_event(event_t e)
+/*****************************************************************************
+ * VlcPlugin constructor and destructor
+ *****************************************************************************/
+#if (((NP_VERSION_MAJOR << 8) + NP_VERSION_MINOR) < 20)
+VlcPlugin::VlcPlugin( NPP instance, uint16 mode ) :
+#else
+VlcPlugin::VlcPlugin( NPP instance, uint16_t mode ) :
+#endif
+    i_npmode(mode),
+    b_stream(0),
+    b_autoplay(1),
+    b_toolbar(0),
+    psz_text(NULL),
+    psz_target(NULL),
+    playlist_index(-1),
+    libvlc_instance(NULL),
+    libvlc_media_list(NULL),
+    libvlc_media_player(NULL),
+    p_scriptClass(NULL),
+    p_browser(instance),
+    psz_baseURL(NULL)
+#if defined(XP_WIN)
+    ,pf_wndproc(NULL)
+#endif
+#if defined(XP_UNIX)
+    ,i_width((unsigned)-1)
+    ,i_height((unsigned)-1)
+    ,i_tb_width(0)
+    ,i_tb_height(0)
+    ,i_last_position(0)
+    ,p_btnPlay(NULL)
+    ,p_btnPause(NULL)
+    ,p_btnStop(NULL)
+    ,p_btnMute(NULL)
+    ,p_btnUnmute(NULL)
+    ,p_btnFullscreen(NULL)
+    ,p_btnTime(NULL)
+    ,p_timeline(NULL)
+#endif
 {
-    return _em?0==libvlc_event_attach(_em, e, _cb, _ud):false;
+    memset(&npwindow, 0, sizeof(NPWindow));
+#if defined(XP_UNIX)
+    memset(&npvideo, 0, sizeof(Window));
+    memset(&npcontrol, 0, sizeof(Window));
+#endif
 }
 
+static bool boolValue(const char *value) {
+    return ( !strcmp(value, "1") ||
+             !strcasecmp(value, "true") ||
+             !strcasecmp(value, "yes") );
+}
 
-void EventObj::unask_for_event(event_t e)
+void VlcPlugin::eventAsync(void *param)
 {
-    if(_em) libvlc_event_detach(_em, e, _cb, _ud);
+    VlcPlugin *plugin = (VlcPlugin*)param;
+    plugin->events.deliver(plugin->getBrowser());
 }
 
+void VlcPlugin::event_callback(const libvlc_event_t* event,
+                NPVariant *npparams, uint32_t npcount, void *userdata)
+{
+    VlcPlugin *plugin = (VlcPlugin*)userdata;
+#if defined(XP_UNIX)
+    plugin->events.callback(event, npparams, npcount);
+    NPN_PluginThreadAsyncCall(plugin->getBrowser(), eventAsync, plugin);
+#else
+#warning NPN_PluginThreadAsyncCall not implemented yet.
+    printf("No NPN_PluginThreadAsyncCall(), doing nothing.\n");
+#endif
+}
 
 NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
 {
@@ -251,7 +417,7 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
 
     /* locate VLC module path */
 #ifdef XP_MACOSX
-    ppsz_argv[ppsz_argc++] = "--plugin-path=/Library/Internet\\ Plug-Ins/VLC\\ Plugin.plugin/Contents/MacOS/modules";
+    ppsz_argv[ppsz_argc++] = "--plugin-path=/Library/Internet\\ Plug-Ins/VLC\\ Plugin.plugin/Contents/MacOS/plugins";
     ppsz_argv[ppsz_argc++] = "--vout=minimal_macosx";
 #elif defined(XP_WIN)
     HKEY h_key;
@@ -282,6 +448,7 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
     ppsz_argv[ppsz_argc++] = "--no-media-library";
     ppsz_argv[ppsz_argc++] = "--intf=dummy";
     ppsz_argv[ppsz_argc++] = "--no-video-title-show";
+    ppsz_argv[ppsz_argc++] = "--no-xlib";
 
     const char *progid = NULL;
 
@@ -353,6 +520,8 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
     }
 
     libvlc_instance = libvlc_new(ppsz_argc, ppsz_argv);
+    if( !libvlc_instance )
+        return NPERR_GENERIC_ERROR;
     libvlc_media_list = libvlc_media_list_new(libvlc_instance);
 
     /*
@@ -371,8 +540,8 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
         NPString script;
         NPVariant result;
 
-        script.utf8characters = docLocHref;
-        script.utf8length = sizeof(docLocHref)-1;
+        script.UTF8Characters = docLocHref;
+        script.UTF8Length = sizeof(docLocHref)-1;
 
         if( NPN_Evaluate(p_browser, plugin, &script, &result) )
         {
@@ -380,11 +549,11 @@ NPError VlcPlugin::init(int argc, char* const argn[], char* const argv[])
             {
                 NPString &location = NPVARIANT_TO_STRING(result);
 
-                psz_baseURL = (char *) malloc(location.utf8length+1);
+                psz_baseURL = (char *) malloc(location.UTF8Length+1);
                 if( psz_baseURL )
                 {
-                    strncpy(psz_baseURL, location.utf8characters, location.utf8length);
-                    psz_baseURL[location.utf8length] = '\0';
+                    strncpy(psz_baseURL, location.UTF8Characters, location.UTF8Length);
+                    psz_baseURL[location.UTF8Length] = '\0';
                 }
             }
             NPN_ReleaseVariantValue(&result);
@@ -417,13 +586,15 @@ VlcPlugin::~VlcPlugin()
 
     if( libvlc_media_player )
     {
-        events.unhook_manager();
+        if( playlist_isplaying() )
+            playlist_stop();
+        events.unhook_manager( this );
         libvlc_media_player_release( libvlc_media_player );
     }
     if( libvlc_media_list )
         libvlc_media_list_release( libvlc_media_list );
     if( libvlc_instance )
-        libvlc_release(libvlc_instance);
+        libvlc_release( libvlc_instance );
 }
 
 /*****************************************************************************
@@ -433,7 +604,7 @@ void VlcPlugin::set_player_window()
 {
 #ifdef XP_UNIX
     libvlc_media_player_set_xwindow(libvlc_media_player,
-                                    (libvlc_drawable_t)getVideoWindow());
+                                    (uint32_t)getVideoWindow());
 #endif
 #ifdef XP_MACOSX
     // XXX FIXME insert appropriate call here
@@ -444,16 +615,15 @@ void VlcPlugin::set_player_window()
 #endif
 }
 
-int VlcPlugin::playlist_add( const char *mrl, libvlc_exception_t *ex )
+int VlcPlugin::playlist_add( const char *mrl )
 {
     int item = -1;
-    libvlc_media_t *p_m = libvlc_media_new(libvlc_instance,mrl,ex);
-    if( libvlc_exception_raised(ex) )
+    libvlc_media_t *p_m = libvlc_media_new_location(libvlc_instance,mrl);
+    if( !p_m )
         return -1;
-
+    assert( libvlc_media_list );
     libvlc_media_list_lock(libvlc_media_list);
-    libvlc_media_list_add_media(libvlc_media_list,p_m,ex);
-    if( !libvlc_exception_raised(ex) )
+    if( !libvlc_media_list_add_media(libvlc_media_list,p_m) )
         item = libvlc_media_list_count(libvlc_media_list)-1;
     libvlc_media_list_unlock(libvlc_media_list);
 
@@ -463,19 +633,22 @@ int VlcPlugin::playlist_add( const char *mrl, libvlc_exception_t *ex )
 }
 
 int VlcPlugin::playlist_add_extended_untrusted( const char *mrl, const char *name,
-                    int optc, const char **optv, libvlc_exception_t *ex )
+                    int optc, const char **optv )
 {
-    libvlc_media_t *p_m = libvlc_media_new(libvlc_instance, mrl,ex);
+    libvlc_media_t *p_m;
     int item = -1;
-    if( libvlc_exception_raised(ex) )
+
+    assert( libvlc_media_list );
+
+    p_m = libvlc_media_new_location(libvlc_instance, mrl);
+    if( !p_m )
         return -1;
 
     for( int i = 0; i < optc; ++i )
         libvlc_media_add_option_flag(p_m, optv[i], libvlc_media_option_unique);
 
     libvlc_media_list_lock(libvlc_media_list);
-    libvlc_media_list_add_media(libvlc_media_list,p_m,ex);
-    if( !libvlc_exception_raised(ex) )
+    if( !libvlc_media_list_add_media(libvlc_media_list,p_m) )
         item = libvlc_media_list_count(libvlc_media_list)-1;
     libvlc_media_list_unlock(libvlc_media_list);
     libvlc_media_release(p_m);
@@ -483,57 +656,64 @@ int VlcPlugin::playlist_add_extended_untrusted( const char *mrl, const char *nam
     return item;
 }
 
-bool VlcPlugin::playlist_select( int idx, libvlc_exception_t *ex )
+bool VlcPlugin::playlist_select( int idx )
 {
     libvlc_media_t *p_m = NULL;
 
+    assert( libvlc_media_list );
+
     libvlc_media_list_lock(libvlc_media_list);
 
     int count = libvlc_media_list_count(libvlc_media_list);
-
     if( idx<0||idx>=count )
         goto bad_unlock;
 
     playlist_index = idx;
 
-    p_m = libvlc_media_list_item_at_index(libvlc_media_list,playlist_index,ex);
+    p_m = libvlc_media_list_item_at_index(libvlc_media_list,playlist_index);
     libvlc_media_list_unlock(libvlc_media_list);
 
-    if( libvlc_exception_raised(ex) )
+    if( !p_m )
         return false;
 
     if( libvlc_media_player )
     {
-        events.unhook_manager();
+        if( playlist_isplaying() )
+            playlist_stop();
+        events.unhook_manager( this );
         libvlc_media_player_release( libvlc_media_player );
         libvlc_media_player = NULL;
     }
 
-    libvlc_media_player = libvlc_media_player_new_from_media(p_m);
+    libvlc_media_player = libvlc_media_player_new_from_media( p_m );
     if( libvlc_media_player )
     {
         set_player_window();
-        events.hook_manager(
-                      libvlc_media_player_event_manager(libvlc_media_player),
-                      event_callback, this);
+
+        libvlc_event_manager_t *p_em;
+        p_em = libvlc_media_player_event_manager( libvlc_media_player );
+        events.hook_manager( p_em, this );
     }
 
     libvlc_media_release( p_m );
     return true;
 
 bad_unlock:
-    libvlc_media_list_unlock(libvlc_media_list);
+    libvlc_media_list_unlock( libvlc_media_list );
     return false;
 }
 
-void VlcPlugin::playlist_delete_item( int idx, libvlc_exception_t *ex )
+int VlcPlugin::playlist_delete_item( int idx )
 {
+    if( !libvlc_media_list )
+        return -1;
     libvlc_media_list_lock(libvlc_media_list);
-    libvlc_media_list_remove_index(libvlc_media_list,idx,ex);
+    int ret = libvlc_media_list_remove_index(libvlc_media_list,idx);
     libvlc_media_list_unlock(libvlc_media_list);
+    return ret;
 }
 
-void VlcPlugin::playlist_clear( libvlc_exception_t *ex )
+void VlcPlugin::playlist_clear()
 {
     if( libvlc_media_list )
         libvlc_media_list_release(libvlc_media_list);
@@ -543,31 +723,35 @@ void VlcPlugin::playlist_clear( libvlc_exception_t *ex )
 int VlcPlugin::playlist_count()
 {
     int items_count = 0;
+    if( !libvlc_media_list )
+        return items_count;
     libvlc_media_list_lock(libvlc_media_list);
     items_count = libvlc_media_list_count(libvlc_media_list);
     libvlc_media_list_unlock(libvlc_media_list);
     return items_count;
 }
 
-void VlcPlugin::toggle_fullscreen( libvlc_exception_t *ex )
+void VlcPlugin::toggle_fullscreen()
 {
     if( playlist_isplaying() )
-        libvlc_toggle_fullscreen(libvlc_media_player,ex);
+        libvlc_toggle_fullscreen(libvlc_media_player);
 }
-void VlcPlugin::set_fullscreen( int yes, libvlc_exception_t *ex )
+
+void VlcPlugin::set_fullscreen( int yes )
 {
     if( playlist_isplaying() )
-        libvlc_set_fullscreen(libvlc_media_player,yes,ex);
+        libvlc_set_fullscreen(libvlc_media_player,yes);
 }
-int  VlcPlugin::get_fullscreen( libvlc_exception_t *ex )
+
+int  VlcPlugin::get_fullscreen()
 {
     int r = 0;
     if( playlist_isplaying() )
-        r = libvlc_get_fullscreen(libvlc_media_player,ex);
+        r = libvlc_get_fullscreen(libvlc_media_player);
     return r;
 }
 
-bool  VlcPlugin::player_has_vout( libvlc_exception_t *ex )
+bool  VlcPlugin::player_has_vout()
 {
     bool r = false;
     if( playlist_isplaying() )
@@ -882,7 +1066,7 @@ void VlcPlugin::redrawToolbar()
     unsigned int i_tb_width, i_tb_height;
 
     /* This method does nothing if toolbar is hidden. */
-    if( !b_toolbar )
+    if( !b_toolbar || !libvlc_media_player )
         return;
 
     const NPWindow& window = getWindow();
@@ -891,7 +1075,6 @@ void VlcPlugin::redrawToolbar()
 
     getToolbarSize( &i_tb_width, &i_tb_height );
 
-
     /* get mute info */
     b_mute = libvlc_audio_get_mute( libvlc_media_player );
 
@@ -997,7 +1180,8 @@ vlc_toolbar_clicked_t VlcPlugin::getToolbarButtonClicked( int i_xpos, int i_ypos
     is_playing = playlist_isplaying();
 
     /* get mute info */
-    b_mute = libvlc_audio_get_mute( libvlc_media_player );
+    if( libvlc_media_player )
+        b_mute = libvlc_audio_get_mute( libvlc_media_player );
 
     /* is Pause of Play button clicked */
     if( (is_playing != 1) &&
@@ -1068,4 +1252,3 @@ bool VlcPlugin::canUseEventListener()
         return true;
     return false;
 }
-