Fix crash when enabling a proxy clip

[kdenlive] / src / abstractclipitem.h

diff --git a/src/abstractclipitem.h b/src/abstractclipitem.h
index f42bcdd3ed8d7a5d5ecebd6d60f4cc66c40080ac..c621c8cdcf1d361e4900979cb1a1e163d68ca64a 100644 (file)
--- a/src/abstractclipitem.h
+++ b/src/abstractclipitem.h
@@ -42,15 +42,15 @@ class AbstractClipItem : public QObject, public QGraphicsRectItem
 #endif
 
 public:
-    AbstractClipItem(const ItemInfo info, const QRectF& rect, double fps);
+    AbstractClipItem(const ItemInfo &info, const QRectF& rect, double fps);
     virtual ~ AbstractClipItem();
     void updateSelectedKeyFrame();
 
     /** @brief Move the selected keyframe (does not influence the effect, only the display in timeline).
     * @param pos new Position
     * @param value new Value */
-    void updateKeyFramePos(const GenTime pos, const double value);
-    int addKeyFrame(const GenTime pos, const double value);
+    void updateKeyFramePos(const GenTime &pos, const double value);
+    int addKeyFrame(const GenTime &pos, const double value);
     bool hasKeyFrames() const;
     int editedKeyFramePos() const;
     int selectedKeyFramePos() const;
@@ -75,6 +75,11 @@ public:
     virtual int track() const ;
     virtual GenTime cropStart() const ;
     virtual GenTime cropDuration() const ;
+    /** @brief Return the current item's height */
+    static int itemHeight();
+    /** @brief Return the current item's vertical offset
+     *         For example transitions are drawn at 1/3 of track height */
+    static int itemOffset();
 
     /** @brief Resizes the clip from the start.
     * @param posx Absolute position of new in point
@@ -101,13 +106,22 @@ protected:
         GenTime m_startPos;*/
     GenTime m_maxDuration;
     QMap <int, int> m_keyframes;
+    /** @brief Strech factor so that keyframes display on the full clip height. */
     double m_keyframeFactor;
+    /** @brief Offset factor so that keyframes minimum value are displaed at the bottom of the clip. */
+    double m_keyframeOffset;
+    /** @brief Default reset value for keyframe. */
     double m_keyframeDefault;
     /** The (keyframe) parameter that is visible and editable in timeline (on the clip) */
     int m_visibleParam;
     double m_fps;
-    //QRect visibleRect();
-    void drawKeyFrames(QPainter *painter, QRectF exposedRect);
+    /** @brief Draw the keyframes of a clip
+      * @param painter The painter device for the clip
+      * @param limitedKeyFrames The keyframes can be of type "keyframe" or "simplekeyframe". In the
+      *        "simplekeyframe" type, the effect always starts on clip start and ends on clip end. With the
+      *        "keyframe" type, the effect starts on the first keyframe and ends on the last keyframe
+      */
+    void drawKeyFrames(QPainter *painter, bool limitedKeyFrames);
     int mouseOverKeyFrames(QPointF pos, double maxOffset);
     virtual void mousePressEvent(QGraphicsSceneMouseEvent * event);