]> git.sesse.net Git - vlc/blobdiff - src/control/mediacontrol_audio_video.c
Thanks and news (see previous commit)
[vlc] / src / control / mediacontrol_audio_video.c
index 1d0288533d013e5fbcdaf40cbb67cb0f0c10c968..99af4d8f3d05c4f761fed4547737c9da143af42d 100644 (file)
@@ -18,7 +18,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
 #include <mediacontrol_internal.h>
 
 #include <vlc_osd.h>
 
-#define HAS_SNAPSHOT 1
-
-#ifdef HAS_SNAPSHOT
 #include <snapshot.h>
-#endif
 
 #include <stdlib.h>                                      /* malloc(), free() */
 #include <string.h>
@@ -63,200 +59,68 @@ mediacontrol_snapshot( mediacontrol_Instance *self,
                        const mediacontrol_Position * a_position,
                        mediacontrol_Exception *exception )
 {
-    mediacontrol_RGBPicture *retval = NULL;
-    input_thread_t* p_input = self->p_playlist->p_input;
-    vout_thread_t *p_vout = NULL;
-    int i_datasize;
-    snapshot_t **pointer;
-    vlc_value_t val;
-    int i_index;
-    snapshot_t *p_best_snapshot;
-    long searched_date;
-#ifdef HAS_SNAPSHOT
-    int i_cachesize;
-#endif
+    vlc_object_t* p_cache;
+    vout_thread_t* p_vout;
+    mediacontrol_RGBPicture *p_pic = NULL;
+    char path[256];
+    snapshot_t *p_snapshot;
 
     exception=mediacontrol_exception_init( exception );
 
-    /*
-       if( var_Get( self->p_vlc, "snapshot-id", &val ) == VLC_SUCCESS )
-       p_vout = vlc_object_get( self->p_vlc, val.i_int );
-    */
-
-    /* FIXME: if in p_libvlc, we cannot have multiple video outputs */
-    /* Once corrected, search for snapshot-id to modify all instances */
-    if( var_Get( p_input, "snapshot-id", &val ) != VLC_SUCCESS )
-    {
-        RAISE( mediacontrol_InternalException, "No snapshot-id in p_input" );
-        return NULL;
-    }
-    p_vout = vlc_object_get( self->p_vlc, val.i_int );
-
+    p_vout = vlc_object_find( self->p_playlist, VLC_OBJECT_VOUT, FIND_CHILD );
     if( ! p_vout )
     {
-        RAISE( mediacontrol_InternalException, "No snapshot module" );
+        RAISE( mediacontrol_InternalException, "No video output" );
         return NULL;
     }
-
-#ifdef HAS_SNAPSHOT
-    /* We test if the vout is a snapshot module. We cannot test
-       pvout_psz_object_name( which is NULL ). But we can check if
-       there are snapshot-specific variables */
-    if( var_Get( p_vout, "snapshot-datasize", &val ) != VLC_SUCCESS )
+    p_cache = vlc_object_create( self->p_playlist, VLC_OBJECT_GENERIC );
+    if( p_cache == NULL )
     {
-        RAISE( mediacontrol_InternalException, "No snapshot module" );
         vlc_object_release( p_vout );
+        msg_Err( self->p_playlist, "out of memory" );
+        RAISE( mediacontrol_InternalException, "Out of memory" );
         return NULL;
     }
-    i_datasize = val.i_int;
-
-    /* Handle the a_position parameter */
-    if( ! ( a_position->origin == mediacontrol_RelativePosition
-            && a_position->value == 0 ) )
-    {
-        /* The position is not the current one. Go to it. */
-        mediacontrol_set_media_position( self,
-                                         ( mediacontrol_Position* ) a_position,
-                                         exception );
-        if( exception->code )
-        {
-            vlc_object_release( p_vout );
-            return NULL;
-        }
-    }
-
-    /* FIXME: We should not go further until we got past the position
-       ( which means that we had the possibility to capture the right
-       picture ). */
+    snprintf( path, 255, "object:%d", p_cache->i_object_id );
+    var_SetString( p_vout, "snapshot-path", path );
+    var_SetString( p_vout, "snapshot-format", "png" );
 
-    vlc_mutex_lock( &p_vout->picture_lock );
-
-    searched_date = mediacontrol_position2microsecond( p_input,
-                                                       ( mediacontrol_Position * ) a_position );
-
-    var_Get( p_vout, "snapshot-cache-size", &val );
-    i_cachesize = val.i_int  ;
+    vlc_mutex_lock( &p_cache->object_lock );
+    vout_Control( p_vout, VOUT_SNAPSHOT );
+    vlc_cond_wait( &p_cache->object_wait, &p_cache->object_lock );
+    vlc_object_release( p_vout );
 
-    var_Get( p_vout, "snapshot-list-pointer", &val );
-    pointer = ( snapshot_t ** )val.p_address;
+    p_snapshot = ( snapshot_t* ) p_cache->p_private;
+    vlc_object_destroy( p_cache );
 
-    if( ! pointer )
+    if( p_snapshot )
     {
-        RAISE( mediacontrol_InternalException, "No available snapshot" );
-
-        vlc_mutex_unlock( &p_vout->picture_lock );
-        vlc_object_release( p_vout );
-        return NULL;
+        p_pic = _mediacontrol_createRGBPicture( p_snapshot->i_width,
+                                                p_snapshot->i_height,
+                                               VLC_FOURCC( 'p','n','g',' ' ),
+                                                p_snapshot->date,
+                                                p_snapshot->p_data,
+                                                p_snapshot->i_datasize );
+        if( !p_pic )
+            RAISE( mediacontrol_InternalException, "Out of memory" );
+        free( p_snapshot->p_data );
+        free( p_snapshot );
     }
-
-    /* Find the more appropriate picture, based on date */
-    p_best_snapshot = pointer[0];
-
-    for( i_index = 1 ; i_index < i_cachesize ; i_index++ )
+    else
     {
-        long l_diff = pointer[i_index]->date - searched_date;
-        if( l_diff > 0 && l_diff < abs( p_best_snapshot->date - searched_date ))
-        {
-            /* This one is closer, and _after_ the requested position */
-            p_best_snapshot = pointer[i_index];
-        }
+        RAISE( mediacontrol_InternalException, "Snapshot exception" );
     }
-
-    /* FIXME: add a test for the case that no picture matched the test
-       ( we have p_best_snapshot == pointer[0] */
-    retval = _mediacontrol_createRGBPicture( p_best_snapshot->i_width,
-                                             p_best_snapshot->i_height,
-                                             p_vout->output.i_chroma,
-                                             p_best_snapshot->date,
-                                             p_best_snapshot->p_data,
-                                             i_datasize );
-
-    vlc_mutex_unlock( &p_vout->picture_lock );
-    vlc_object_release( p_vout );
-
-#endif
-
-    return retval;
+    return p_pic;
 }
 
 mediacontrol_RGBPicture **
 mediacontrol_all_snapshots( mediacontrol_Instance *self,
                             mediacontrol_Exception *exception )
 {
-    mediacontrol_RGBPicture **retval = NULL;
-    vout_thread_t *p_vout = NULL;
-    int i_datasize;
-    int i_cachesize;
-    vlc_value_t val;
-    int i_index;
-#ifdef HAS_SNAPSHOT
-    snapshot_t **pointer;
-#endif
-
     exception=mediacontrol_exception_init( exception );
 
-    if( var_Get( self->p_playlist->p_input, "snapshot-id", &val ) == VLC_SUCCESS )
-        p_vout = vlc_object_get( self->p_vlc, val.i_int );
-
-    if( ! p_vout )
-    {
-        RAISE( mediacontrol_InternalException, "No snapshot module" );
-        return NULL;
-    }
-#ifdef HAS_SNAPSHOT
-    /* We test if the vout is a snapshot module. We cannot test
-       pvout_psz_object_name( which is NULL ). But we can check if
-       there are snapshot-specific variables */
-    if( var_Get( p_vout, "snapshot-datasize", &val ) != VLC_SUCCESS )
-    {
-        RAISE( mediacontrol_InternalException, "No snapshot module" );
-        vlc_object_release( p_vout );
-        return NULL;
-    }
-    i_datasize = val.i_int;
-
-    vlc_mutex_lock( &p_vout->picture_lock );
-
-    var_Get( p_vout, "snapshot-cache-size", &val );
-    i_cachesize = val.i_int  ;
-
-    var_Get( p_vout, "snapshot-list-pointer", &val );
-    pointer = ( snapshot_t ** )val.p_address;
-
-    if( ! pointer )
-    {
-        RAISE( mediacontrol_InternalException, "No available picture" );
-
-        vlc_mutex_unlock( &p_vout->picture_lock );
-        vlc_object_release( p_vout );
-        return NULL;
-    }
-
-    retval = ( mediacontrol_RGBPicture** )malloc( (i_cachesize + 1 ) * sizeof( char* ));
-
-    for( i_index = 0 ; i_index < i_cachesize ; i_index++ )
-    {
-        snapshot_t *p_s = pointer[i_index];
-        mediacontrol_RGBPicture *p_rgb;
-
-        p_rgb = _mediacontrol_createRGBPicture( p_s->i_width,
-                                                p_s->i_height,
-                                                p_vout->output.i_chroma,
-                                                p_s->date,
-                                                p_s->p_data,
-                                                i_datasize );
-
-        retval[i_index] = p_rgb;
-    }
-
-    retval[i_cachesize] = NULL;
-
-    vlc_mutex_unlock( &p_vout->picture_lock );
-    vlc_object_release( p_vout );
-
-#endif
-
-    return retval;
+    RAISE( mediacontrol_InternalException, "Unsupported method" );
+    return NULL;
 }
 
 int mediacontrol_showtext( vout_thread_t *p_vout, int i_channel,
@@ -333,7 +197,7 @@ mediacontrol_display_text( mediacontrol_Instance *self,
         end->origin == mediacontrol_RelativePosition )
     {
         mtime_t i_duration = 0;
-       mtime_t i_now = mdate();
+        mtime_t i_now = mdate();
 
         i_duration = 1000 * mediacontrol_unit_convert( self->p_playlist->p_input,
                                                        end->key,
@@ -359,7 +223,7 @@ mediacontrol_display_text( mediacontrol_Instance *self,
         /* FIXME */
         /* i_now = input_ClockGetTS( p_input, NULL, 0 ); */
         i_now = mdate();
-        
+
         i_debut = mediacontrol_position2microsecond( p_input,
                                                      ( mediacontrol_Position* ) begin );
         i_debut += i_now;
@@ -401,14 +265,13 @@ mediacontrol_sound_set_volume( mediacontrol_Instance *self,
     if( !self->p_intf )
     {
         RAISE( mediacontrol_InternalException, "No interface module" );
-        return;
     }
-    aout_VolumeSet( self->p_intf,( audio_volume_t )volume );
+    else aout_VolumeSet( self->p_intf,( audio_volume_t )volume );
 }
 
 vlc_bool_t mediacontrol_set_visual( mediacontrol_Instance *self,
-                                   WINDOWHANDLE visual_id,
-                                   mediacontrol_Exception *exception )
+                                    WINDOWHANDLE visual_id,
+                                    mediacontrol_Exception *exception )
 {
     vlc_value_t value;
     int ret;
@@ -416,10 +279,10 @@ vlc_bool_t mediacontrol_set_visual( mediacontrol_Instance *self,
     if( !self->p_vlc )
     {
         RAISE( mediacontrol_InternalException, "No vlc reference" );
-        return 0;
+        return VLC_FALSE;
     }
     value.i_int=visual_id;
     ret = var_Set(self->p_vlc, "drawable", value);
-    
+
     return (ret == VLC_SUCCESS);
 }