remove useless locks

[kdenlive] / src / effectslist.cpp

diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index 91b7693647aed91b7e7c9942200f8d87c543bf3b..696fa44402b9803d6bfa33b59dae4d825ddb2ee9 100644 (file)
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -38,8 +38,8 @@ QDomElement EffectsList::getEffectByName(const QString & name) const
     QDomNodeList effects = m_baseElement.childNodes();
     for (int i = 0; i < effects.count(); i++) {
         QDomElement effect =  effects.at(i).toElement();
-        QDomNode namenode = effect.elementsByTagName("name").item(0);
-        if (!namenode.isNull()) effectName = i18n(namenode.toElement().text().toUtf8().data());
+        QDomElement namenode = effect.firstChildElement("name");
+        if (!namenode.isNull()) effectName = i18n(namenode.text().toUtf8().data());
         if (name == effectName) {
             QDomNodeList params = effect.elementsByTagName("parameter");
             for (int i = 0; i < params.count(); i++) {
@@ -100,8 +100,8 @@ QStringList EffectsList::effectIdInfo(const int ix) const
 {
     QStringList info;
     QDomElement effect = m_baseElement.childNodes().at(ix).toElement();
-    QDomNode namenode = effect.elementsByTagName("name").item(0);
-    info << i18n(namenode.toElement().text().toUtf8().data()) << effect.attribute("tag") << effect.attribute("id");
+    QDomElement namenode = effect.firstChildElement("name");
+    info << i18n(namenode.text().toUtf8().data()) << effect.attribute("tag") << effect.attribute("id");
     return info;
 }
 
@@ -111,8 +111,8 @@ QStringList EffectsList::effectNames()
     QDomNodeList effects = m_baseElement.childNodes();
     for (int i = 0; i < effects.count(); i++) {
         QDomElement effect =  effects.at(i).toElement();
-        QDomNode namenode = effect.elementsByTagName("name").item(0);
-        if (!namenode.isNull()) list.append(i18n(namenode.toElement().text().toUtf8().data()));
+        QDomElement namenode = effect.firstChildElement("name");
+        if (!namenode.isNull()) list.append(i18n(namenode.text().toUtf8().data()));
     }
     return list;
 }
@@ -120,26 +120,30 @@ QStringList EffectsList::effectNames()
 QString EffectsList::getInfo(const QString & tag, const QString & id) const
 {
     QString info;
-    QDomElement effect = getEffectByTag(tag, id);
-    QDomNode namenode = effect.elementsByTagName("description").item(0);
+    return getEffectInfo(getEffectByTag(tag, id));
+}
+
+QString EffectsList::getInfoFromIndex(const int ix) const
+{
+    QString info;
+    return getEffectInfo(m_baseElement.childNodes().at(ix).toElement());
+}
+
+QString EffectsList::getEffectInfo(const QDomElement effect) const
+{
+    QString info;
+    QDomElement namenode = effect.firstChildElement("description");
     if (!namenode.isNull())
         info = i18n(namenode.firstChild().nodeValue().simplified().toUtf8().data());
 
-    namenode = effect.elementsByTagName("author").item(0);
+    namenode = effect.firstChildElement("author");
     if (!namenode.isNull())
-        info.append("<br /><strong>" + i18n("Author:") + " </strong>" + i18n(namenode.toElement().text().toUtf8().data()));
+        info.append("<br /><strong>" + i18n("Author:") + " </strong>" + i18n(namenode.text().toUtf8().data()));
 
-    return info;
-}
+    namenode = effect.firstChildElement("version");
+    if (!namenode.isNull())
+        info.append(QString(" (%1)").arg(namenode.text()));
 
-QString EffectsList::getInfoFromIndex(const int ix) const
-{
-    QString info;
-    QDomElement effect = m_baseElement.childNodes().at(ix).toElement();
-    QDomNode namenode = effect.elementsByTagName("description").item(0);
-    if (!namenode.isNull()) info = i18n(namenode.toElement().text().toUtf8().data());
-    namenode = effect.elementsByTagName("author").item(0);
-    if (!namenode.isNull()) info.append("<br /><strong>" + i18n("Author:") + " </strong>" + i18n(namenode.toElement().text().toUtf8().data()));
     return info;
 }
 
@@ -177,7 +181,7 @@ bool EffectsList::hasGeometryKeyFrames(QDomElement effect)
     return false;
 }
 
-void EffectsList::clone(const EffectsList original)
+void EffectsList::clone(const EffectsList &original)
 {
     setContent(original.toString());
     m_baseElement = documentElement();
@@ -219,6 +223,7 @@ QString EffectsList::parameter(QDomElement effect, const QString &name)
 void EffectsList::setProperty(QDomElement effect, const QString &name, const QString &value)
 {
     QDomNodeList params = effect.elementsByTagName("property");
+    // Update property if it already exists
     for (int i = 0; i < params.count(); i++) {
         QDomElement e = params.item(i).toElement();
         if (e.attribute("name") == name) {
@@ -228,6 +233,20 @@ void EffectsList::setProperty(QDomElement effect, const QString &name, const QSt
     }
 }
 
+// static
+void EffectsList::renameProperty(QDomElement effect, const QString &oldName, const QString &newName)
+{
+    QDomNodeList params = effect.elementsByTagName("property");
+    // Update property if it already exists
+    for (int i = 0; i < params.count(); i++) {
+        QDomElement e = params.item(i).toElement();
+        if (e.attribute("name") == oldName) {
+            e.setAttribute("name", newName);
+            break;
+        }
+    }
+}
+
 // static
 QString EffectsList::property(QDomElement effect, const QString &name)
 {
@@ -266,7 +285,7 @@ int EffectsList::count() const
 
 bool EffectsList::isEmpty() const
 {
-    return m_baseElement.childNodes().count() == 0;
+    return !m_baseElement.hasChildNodes();
 }
 
 const QDomElement EffectsList::at(int ix) const