Show filter version in filter info box

[kdenlive] / src / effectslist.cpp

diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index f3ac8877b8876cf0721374c42df330774d7063d3..d01b46e404ed96beac02488582b982b58f25b2d2 100644 (file)
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -38,7 +38,7 @@ QDomElement EffectsList::getEffectByName(const QString & name) const
     QDomNodeList effects = m_baseElement.childNodes();
     for (int i = 0; i < effects.count(); i++) {
         QDomElement effect =  effects.at(i).toElement();
-        QDomNode namenode = effect.elementsByTagName("name").item(0);
+        QDomNode namenode = effect.firstChildElement("name");
         if (!namenode.isNull()) effectName = i18n(namenode.toElement().text().toUtf8().data());
         if (name == effectName) {
             QDomNodeList params = effect.elementsByTagName("parameter");
@@ -100,7 +100,7 @@ QStringList EffectsList::effectIdInfo(const int ix) const
 {
     QStringList info;
     QDomElement effect = m_baseElement.childNodes().at(ix).toElement();
-    QDomNode namenode = effect.elementsByTagName("name").item(0);
+    QDomNode namenode = effect.firstChildElement("name");
     info << i18n(namenode.toElement().text().toUtf8().data()) << effect.attribute("tag") << effect.attribute("id");
     return info;
 }
@@ -111,7 +111,7 @@ QStringList EffectsList::effectNames()
     QDomNodeList effects = m_baseElement.childNodes();
     for (int i = 0; i < effects.count(); i++) {
         QDomElement effect =  effects.at(i).toElement();
-        QDomNode namenode = effect.elementsByTagName("name").item(0);
+        QDomNode namenode = effect.firstChildElement("name");
         if (!namenode.isNull()) list.append(i18n(namenode.toElement().text().toUtf8().data()));
     }
     return list;
@@ -120,26 +120,30 @@ QStringList EffectsList::effectNames()
 QString EffectsList::getInfo(const QString & tag, const QString & id) const
 {
     QString info;
-    QDomElement effect = getEffectByTag(tag, id);
-    QDomNode namenode = effect.elementsByTagName("description").item(0);
+    return getEffectInfo(getEffectByTag(tag, id));
+}
+
+QString EffectsList::getInfoFromIndex(const int ix) const
+{
+    QString info;
+    return getEffectInfo(m_baseElement.childNodes().at(ix).toElement());
+}
+
+QString EffectsList::getEffectInfo(const QDomElement effect) const
+{
+    QString info;
+    QDomNode namenode = effect.firstChildElement("description");
     if (!namenode.isNull())
         info = i18n(namenode.firstChild().nodeValue().simplified().toUtf8().data());
 
-    namenode = effect.elementsByTagName("author").item(0);
+    namenode = effect.firstChildElement("author");
     if (!namenode.isNull())
         info.append("<br /><strong>" + i18n("Author:") + " </strong>" + i18n(namenode.toElement().text().toUtf8().data()));
 
-    return info;
-}
+    namenode = effect.firstChildElement("version");
+    if (!namenode.isNull())
+        info.append(QString(" (%1)").arg(namenode.toElement().text()));
 
-QString EffectsList::getInfoFromIndex(const int ix) const
-{
-    QString info;
-    QDomElement effect = m_baseElement.childNodes().at(ix).toElement();
-    QDomNode namenode = effect.elementsByTagName("description").item(0);
-    if (!namenode.isNull()) info = i18n(namenode.toElement().text().toUtf8().data());
-    namenode = effect.elementsByTagName("author").item(0);
-    if (!namenode.isNull()) info.append("<br /><strong>" + i18n("Author:") + " </strong>" + i18n(namenode.toElement().text().toUtf8().data()));
     return info;
 }