Correctly update monitor when changing a title clip duration

[kdenlive] / src / effectslistview.cpp

diff --git a/src/effectslistview.cpp b/src/effectslistview.cpp
index b0aa78698a24a4fb9484a56c7fd00fb9711bb69e..0c313cf3b8a5ea7357b723ad636233d634c36088 100644 (file)
--- a/src/effectslistview.cpp
+++ b/src/effectslistview.cpp
@@ -17,34 +17,39 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA          *
  ***************************************************************************/
 
-#include <QMenu>
-#include <QMenu>
-#include <QDir>
+
+#include "effectslistview.h"
+#include "effectslistwidget.h"
+#include "effectslist.h"
+#include "kdenlivesettings.h"
 
 #include <KDebug>
 #include <KLocale>
 #include <KStandardDirs>
 
-#include "effectslistview.h"
-#include "effectslistwidget.h"
-#include "effectslist.h"
+#include <QMenu>
+#include <QDir>
 
-EffectsListView::EffectsListView(QWidget *parent)
-        : QWidget(parent) {
-    ui.setupUi(this);
+EffectsListView::EffectsListView(QWidget *parent) :
+        QWidget(parent)
+{
+    m_ui.setupUi(this);
 
     QMenu *menu = new QMenu(this);
     m_effectsList = new EffectsListWidget(menu);
-    QVBoxLayout *lyr = new QVBoxLayout(ui.effectlistframe);
+    QVBoxLayout *lyr = new QVBoxLayout(m_ui.effectlistframe);
     lyr->addWidget(m_effectsList);
     lyr->setContentsMargins(0, 0, 0, 0);
-    ui.search_effect->setListWidget(m_effectsList);
-    ui.buttonInfo->setIcon(KIcon("help-about"));
-    ui.infopanel->hide();
+    m_ui.search_effect->setListWidget(m_effectsList);
+    m_ui.buttonInfo->setIcon(KIcon("help-about"));
+
+    if (KdenliveSettings::showeffectinfo()) {
+        m_ui.buttonInfo->setDown(true);
+    } else m_ui.infopanel->hide();
     menu->addAction(KIcon("edit-delete"), i18n("Delete effect"), this, SLOT(slotRemoveEffect()));
 
-    connect(ui.type_combo, SIGNAL(currentIndexChanged(int)), this, SLOT(filterList(int)));
-    connect(ui.buttonInfo, SIGNAL(clicked()), this, SLOT(showInfoPanel()));
+    connect(m_ui.type_combo, SIGNAL(currentIndexChanged(int)), this, SLOT(filterList(int)));
+    connect(m_ui.buttonInfo, SIGNAL(clicked()), this, SLOT(showInfoPanel()));
     connect(m_effectsList, SIGNAL(itemSelectionChanged()), this, SLOT(slotUpdateInfo()));
     connect(m_effectsList, SIGNAL(doubleClicked(QListWidgetItem *, const QPoint &)), this, SLOT(slotEffectSelected()));
 
@@ -52,7 +57,8 @@ EffectsListView::EffectsListView(QWidget *parent)
 }
 
 
-void EffectsListView::filterList(int pos) {
+void EffectsListView::filterList(int pos)
+{
     QListWidgetItem *item;
     for (int i = 0; i < m_effectsList->count(); i++) {
         item = m_effectsList->item(i);
@@ -64,41 +70,48 @@ void EffectsListView::filterList(int pos) {
     if (item) {
         if (item->isHidden()) {
             int i;
-            for (i = 0; i < m_effectsList->count() && m_effectsList->item(i)->isHidden(); i++);
+            for (i = 0; i < m_effectsList->count() && m_effectsList->item(i)->isHidden(); i++) /*do nothing*/;
             m_effectsList->setCurrentRow(i);
         } else m_effectsList->scrollToItem(item);
     }
 }
 
-void EffectsListView::showInfoPanel() {
-    if (ui.infopanel->isVisible()) {
-        ui.infopanel->setVisible(false);
-        ui.buttonInfo->setDown(false);
+void EffectsListView::showInfoPanel()
+{
+    if (m_ui.infopanel->isVisible()) {
+        m_ui.infopanel->setVisible(false);
+        m_ui.buttonInfo->setDown(false);
+        KdenliveSettings::setShoweffectinfo(false);
     } else {
-        ui.infopanel->setVisible(true);
-        ui.buttonInfo->setDown(true);
+        m_ui.infopanel->setVisible(true);
+        m_ui.buttonInfo->setDown(true);
+        KdenliveSettings::setShoweffectinfo(true);
     }
 }
 
-void EffectsListView::slotEffectSelected() {
-    QDomElement effect = m_effectsList->currentEffect().cloneNode().toElement();
+void EffectsListView::slotEffectSelected()
+{
+    QDomElement effect = m_effectsList->currentEffect();
     if (!effect.isNull()) emit addEffect(effect);
 }
 
-void EffectsListView::slotUpdateInfo() {
-    QString info = m_effectsList->currentInfo();
-    ui.infopanel->setText(info);
+void EffectsListView::slotUpdateInfo()
+{
+    m_ui.infopanel->setText(m_effectsList->currentInfo());
 }
 
-KListWidget *EffectsListView::listView() {
+KListWidget *EffectsListView::listView()
+{
     return m_effectsList;
 }
 
-void EffectsListView::reloadEffectList() {
+void EffectsListView::reloadEffectList()
+{
     m_effectsList->initList();
 }
 
-void EffectsListView::slotRemoveEffect() {
+void EffectsListView::slotRemoveEffect()
+{
     QListWidgetItem *item = m_effectsList->currentItem();
     QString effectId = item->text();
     QString path = KStandardDirs::locateLocal("appdata", "effects/", true);
@@ -108,7 +121,7 @@ void EffectsListView::slotRemoveEffect() {
     filter << "*.xml";
     const QStringList fileList = directory.entryList(filter, QDir::Files);
     QString itemName;
-    foreach(const QString filename, fileList) {
+    foreach(const QString &filename, fileList) {
         itemName = KUrl(path + filename).path();
         QDomDocument doc;
         QFile file(itemName);