remove useless locks

[kdenlive] / src / effectslistwidget.cpp

diff --git a/src/effectslistwidget.cpp b/src/effectslistwidget.cpp
index 12643ed3a6e0f33da046cb05b2221024654ddabd..e9a260dc0089611d3944b678120b1b7e719331bc 100644 (file)
--- a/src/effectslistwidget.cpp
+++ b/src/effectslistwidget.cpp
@@ -24,6 +24,7 @@
 
 #include <KDebug>
 #include <KStandardDirs>
+#include <KAction>
 
 #include <QApplication>
 #include <QMouseEvent>
@@ -39,9 +40,9 @@ const int TypeRole = Qt::UserRole;
 const int IdRole = TypeRole + 1;
 
 
-EffectsListWidget::EffectsListWidget(QMenu *menu, QWidget *parent) :
+EffectsListWidget::EffectsListWidget(QMenu *contextMenu, QWidget *parent) :
         QTreeWidget(parent),
-        m_menu(menu)
+        m_menu(contextMenu)
 {
     setColumnCount(1);
     setDragEnabled(true);
@@ -49,13 +50,13 @@ EffectsListWidget::EffectsListWidget(QMenu *menu, QWidget *parent) :
     setHeaderHidden(true);
     setFrameShape(QFrame::NoFrame);
     setAutoFillBackground(false);
-    setRootIsDecorated(false);
+    setRootIsDecorated(true);
+    setIndentation(10);
     //setSelectionMode(QAbstractItemView::ExtendedSelection);
     setDragDropMode(QAbstractItemView::DragOnly);
     QPalette p = palette();
     p.setBrush(QPalette::Base, Qt::NoBrush);
     setPalette(p);
-    initList();
     connect(this, SIGNAL(activated(const QModelIndex &)), this, SLOT(slotExpandItem(const QModelIndex &)));
 }
 
@@ -68,14 +69,14 @@ void EffectsListWidget::slotExpandItem(const QModelIndex & index)
     setExpanded(index, !isExpanded(index));
 }
 
-void EffectsListWidget::initList()
+void EffectsListWidget::initList(QMenu *effectsMenu, KActionCategory *effectActions)
 {
     QString current;
     QString currentFolder;
     QTreeWidgetItem *item = NULL;
-    QTreeWidgetItem *parentItem;
     bool found = false;
-
+    effectsMenu->clear();
+    
     if (currentItem()) {
         current = currentItem()->text(0);
         if (currentItem()->parent())
@@ -84,8 +85,6 @@ void EffectsListWidget::initList()
             currentFolder = currentItem()->text(0);
     }
 
-    KIcon folderIcon("folder");
-
     QString effectCategory = KStandardDirs::locate("config", "kdenliveeffectscategory.rc");
     QDomDocument doc;
     QFile file(effectCategory);
@@ -95,7 +94,7 @@ void EffectsListWidget::initList()
     QStringList folderNames;
     QDomNodeList groups = doc.documentElement().elementsByTagName("group");
     for (int i = 0; i < groups.count(); i++) {
-        folderNames << groups.at(i).firstChild().firstChild().nodeValue();
+        folderNames << i18n(groups.at(i).firstChild().firstChild().nodeValue().toUtf8().constData());
     }
     for (int i = 0; i < topLevelItemCount(); i++) {
         topLevelItem(i)->takeChildren();
@@ -112,10 +111,10 @@ void EffectsListWidget::initList()
             item->setData(0, IdRole, groups.at(i).toElement().attribute("list"));
         } else {
             item = new QTreeWidgetItem((QTreeWidget*)0, QStringList(folderNames.at(i)));
-            item->setIcon(0, folderIcon);
             item->setData(0, TypeRole, QString::number((int) EFFECT_FOLDER));
             item->setData(0, IdRole, groups.at(i).toElement().attribute("list"));
             item->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
+            item->setChildIndicatorPolicy(QTreeWidgetItem::DontShowIndicatorWhenChildless);
             insertTopLevelItem(0, item);
         }
         folders.append(item);
@@ -124,7 +123,6 @@ void EffectsListWidget::initList()
     QTreeWidgetItem *misc = findFolder(i18n("Misc"));
     if (misc == NULL) {
         misc = new QTreeWidgetItem((QTreeWidget*)0, QStringList(i18n("Misc")));
-        misc->setIcon(0, folderIcon);
         misc->setData(0, TypeRole, QString::number((int) EFFECT_FOLDER));
         misc->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
         insertTopLevelItem(0, misc);
@@ -133,7 +131,6 @@ void EffectsListWidget::initList()
     QTreeWidgetItem *audio = findFolder(i18n("Audio"));
     if (audio == NULL) {
         audio = new QTreeWidgetItem((QTreeWidget*)0, QStringList(i18n("Audio")));
-        audio->setIcon(0, folderIcon);
         audio->setData(0, TypeRole, QString::number((int) EFFECT_FOLDER));
         audio->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
         insertTopLevelItem(0, audio);
@@ -142,7 +139,6 @@ void EffectsListWidget::initList()
     QTreeWidgetItem *custom = findFolder(i18nc("Folder Name", "Custom"));
     if (custom == NULL) {
         custom = new QTreeWidgetItem((QTreeWidget*)0, QStringList(i18nc("Folder Name", "Custom")));
-        custom->setIcon(0, folderIcon);
         custom->setData(0, TypeRole, QString::number((int) EFFECT_FOLDER));
         custom->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
         insertTopLevelItem(0, custom);
@@ -152,7 +148,7 @@ void EffectsListWidget::initList()
 
     loadEffects(&MainWindow::videoEffects, KIcon("kdenlive-show-video"), misc, &folders, QString::number((int) EFFECT_VIDEO), current, &found);
     loadEffects(&MainWindow::audioEffects, KIcon("kdenlive-show-audio"), audio, &folders, QString::number((int) EFFECT_AUDIO), current, &found);
-    loadEffects(&MainWindow::customEffects, KIcon("kdenlive-custom-effect"), custom, &QList<QTreeWidgetItem *>(), QString::number((int) EFFECT_CUSTOM), current, &found);
+    loadEffects(&MainWindow::customEffects, KIcon("kdenlive-custom-effect"), custom, static_cast<QList<QTreeWidgetItem *> *>(0), QString::number((int) EFFECT_CUSTOM), current, &found);
 
     if (!found && !currentFolder.isEmpty()) {
         // previously selected effect was removed, focus on its parent folder
@@ -166,6 +162,25 @@ void EffectsListWidget::initList()
     }
     setSortingEnabled(true);
     sortByColumn(0, Qt::AscendingOrder);
+
+    // populate effects menu
+    for (int i = 0; i < topLevelItemCount(); i++) {
+        if (!topLevelItem(i)->childCount())
+            continue;
+        QMenu *sub = new QMenu(topLevelItem(i)->text(0), effectsMenu);
+        effectsMenu->addMenu(sub);
+        for (int j = 0; j < topLevelItem(i)->childCount(); j++) {
+                QTreeWidgetItem *item = topLevelItem(i)->child(j);
+                KAction *a = new KAction(KIcon(item->icon(0)), item->text(0), sub);
+                QStringList data = item->data(0, IdRole).toStringList();
+                QString id = data.at(1);
+                if (id.isEmpty()) id = data.at(0);
+                a->setData(data);
+                a->setIconVisibleInMenu(false);
+                sub->addAction(a);
+                effectActions->addAction("video_effect_" + id, a);
+        }
+    }
 }
 
 void EffectsListWidget::loadEffects(const EffectsList *effectlist, KIcon icon, QTreeWidgetItem *defaultFolder, const QList<QTreeWidgetItem *> *folders, const QString type, const QString current, bool *found)
@@ -177,13 +192,16 @@ void EffectsListWidget::loadEffects(const EffectsList *effectlist, KIcon icon, Q
 
     for (int ix = 0; ix < ct; ix ++) {
         effectInfo = effectlist->effectIdInfo(ix);
+        effectInfo.append(type);
         parentItem = NULL;
 
-        for (int i = 0; i < folders->count(); i++) {
-            l = folders->at(i)->data(0, IdRole).toString().split(',', QString::SkipEmptyParts);
-            if (l.contains(effectInfo.at(2))) {
-                parentItem = folders->at(i);
-                break;
+        if (folders) {
+            for (int i = 0; i < folders->count(); i++) {
+                l = folders->at(i)->data(0, IdRole).toString().split(',', QString::SkipEmptyParts);
+                if (l.contains(effectInfo.at(2))) {
+                    parentItem = folders->at(i);
+                    break;
+                }
             }
         }
         if (parentItem == NULL)
@@ -194,6 +212,7 @@ void EffectsListWidget::loadEffects(const EffectsList *effectlist, KIcon icon, Q
             item->setIcon(0, icon);
             item->setData(0, TypeRole, type);
             item->setData(0, IdRole, effectInfo);
+            item->setToolTip(0, effectlist->getInfo(effectInfo.at(0), effectInfo.at(1)));
             if (item->text(0) == current) {
                 setCurrentItem(item);
                 *found = true;