]> git.sesse.net Git - mlt/blobdiff - src/framework/mlt_consumer.c
Improve reliability of real_time=1 frame-dropping.
[mlt] / src / framework / mlt_consumer.c
index 7fba55641b3b211589e2bb95bcee220f8da16755..fda0fee1e59504682ab6237df24cc7d45a8a327f 100644 (file)
@@ -154,7 +154,7 @@ static void apply_profile_properties( mlt_consumer self, mlt_profile profile, ml
 
 static void mlt_consumer_property_changed( mlt_properties owner, mlt_consumer self, char *name )
 {
-       if ( !strcmp( name, "profile" ) )
+       if ( !strcmp( name, "mlt_profile" ) )
        {
                // Get the properies
                mlt_properties properties = MLT_CONSUMER_PROPERTIES( self );
@@ -391,6 +391,9 @@ int mlt_consumer_connect( mlt_consumer self, mlt_service producer )
 
 int mlt_consumer_start( mlt_consumer self )
 {
+       if ( !mlt_consumer_is_stopped( self ) )
+               return 0;
+
        // Stop listening to the property-changed event
        mlt_event_block( self->event_listener );
 
@@ -635,12 +638,14 @@ static void *consumer_read_ahead_thread( void *arg )
        struct timeval ante;
 
        // Average time for get_frame and get_image
-       int count = 1;
+       int count = 0;
        int skipped = 0;
-       int64_t time_wait = 0;
-       int64_t time_frame = 0;
        int64_t time_process = 0;
        int skip_next = 0;
+       mlt_position pos = 0;
+       mlt_position start_pos = 0;
+       mlt_position last_pos = 0;
+       int frame_duration = mlt_properties_get_int( properties, "frame_duration" );
 
        if ( preview_off && preview_format != 0 )
                self->format = preview_format;
@@ -648,21 +653,25 @@ static void *consumer_read_ahead_thread( void *arg )
        // Get the first frame
        frame = mlt_consumer_get_frame( self );
 
-       // Get the image of the first frame
-       if ( !video_off )
+       if ( frame )
        {
-               mlt_events_fire( MLT_CONSUMER_PROPERTIES( self ), "consumer-frame-render", frame, NULL );
-               mlt_frame_get_image( frame, &image, &self->format, &width, &height, 0 );
-       }
+               // Get the image of the first frame
+               if ( !video_off )
+               {
+                       mlt_events_fire( MLT_CONSUMER_PROPERTIES( self ), "consumer-frame-render", frame, NULL );
+                       mlt_frame_get_image( frame, &image, &self->format, &width, &height, 0 );
+               }
 
-       if ( !audio_off )
-       {
-               samples = mlt_sample_calculator( fps, frequency, counter++ );
-               mlt_frame_get_audio( frame, &audio, &afmt, &frequency, &channels, &samples );
-       }
+               if ( !audio_off )
+               {
+                       samples = mlt_sample_calculator( fps, frequency, counter++ );
+                       mlt_frame_get_audio( frame, &audio, &afmt, &frequency, &channels, &samples );
+               }
 
-       // Mark as rendered
-       mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "rendered", 1 );
+               // Mark as rendered
+               mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "rendered", 1 );
+               last_pos = start_pos = pos = mlt_frame_get_position( frame );
+       }
 
        // Get the starting time (can ignore the times above)
        gettimeofday( &ante, NULL );
@@ -670,10 +679,6 @@ static void *consumer_read_ahead_thread( void *arg )
        // Continue to read ahead
        while ( self->ahead )
        {
-               // Fetch width/height again
-               width = mlt_properties_get_int( properties, "width" );
-               height = mlt_properties_get_int( properties, "height" );
-
                // Put the current frame into the queue
                pthread_mutex_lock( &self->queue_mutex );
                while( self->ahead && mlt_deque_count( self->queue ) >= buffer )
@@ -682,58 +687,59 @@ static void *consumer_read_ahead_thread( void *arg )
                pthread_cond_broadcast( &self->queue_cond );
                pthread_mutex_unlock( &self->queue_mutex );
 
-               time_wait += time_difference( &ante );
-
                // Get the next frame
                frame = mlt_consumer_get_frame( self );
-               time_frame += time_difference( &ante );
 
                // If there's no frame, we're probably stopped...
                if ( frame == NULL )
                        continue;
+               pos = mlt_frame_get_position( frame );
 
-               // Increment the count
+               // Increment the counter used for averaging processing cost
                count ++;
 
-               // All non normal playback frames should be shown
+               // All non-normal playback frames should be shown
                if ( mlt_properties_get_int( MLT_FRAME_PROPERTIES( frame ), "_speed" ) != 1 )
                {
 #ifdef DEINTERLACE_ON_NOT_NORMAL_SPEED
                        mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "consumer_deinterlace", 1 );
 #endif
-                       skipped = 0;
-                       time_frame = 0;
-                       time_process = 0;
-                       time_wait = 0;
-                       count = 1;
-                       skip_next = 0;
+                       // Indicate seeking or trick-play
+                       start_pos = pos;
                }
 
-               // Get the image
+               // If skip flag not set or frame-dropping disabled
                if ( !skip_next || self->real_time == -1 )
                {
-                       // Get the image, mark as rendered and time it
                        if ( !video_off )
                        {
+                               // Reset width/height - could have been changed by previous mlt_frame_get_image
+                               width = mlt_properties_get_int( properties, "width" );
+                               height = mlt_properties_get_int( properties, "height" );
+
+                               // Get the image
                                mlt_events_fire( MLT_CONSUMER_PROPERTIES( self ), "consumer-frame-render", frame, NULL );
                                mlt_frame_get_image( frame, &image, &self->format, &width, &height, 0 );
                        }
+
+                       // Indicate the rendered image is available.
                        mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "rendered", 1 );
+
+                       // Reset consecutively-skipped counter
+                       skipped = 0;
                }
-               else
+               else // Skip image processing
                {
-                       // Increment the number of sequentially skipped frames
-                       skipped ++;
-                       skip_next = 0;
+                       // Increment the number of consecutively-skipped frames
+                       skipped++;
 
-                       // If we've reached an unacceptable level, reset everything
-                       if ( skipped > fps * 2 )
+                       // If too many (1 sec) consecutively-skipped frames
+                       if ( skipped > fps )
                        {
-                               skipped = 0;
-                               time_frame = 0;
+                               // Reset cost tracker
                                time_process = 0;
-                               time_wait = 0;
                                count = 1;
+                               mlt_log_verbose( self, "too many frames dropped - forcing next frame\n" );
                        }
                }
 
@@ -744,15 +750,48 @@ static void *consumer_read_ahead_thread( void *arg )
                        mlt_frame_get_audio( frame, &audio, &afmt, &frequency, &channels, &samples );
                }
 
-               // Increment the time take for self frame
-               time_process += time_difference( &ante );
+               // Get the time to process this frame
+               int64_t time_current = time_difference( &ante );
+
+               // If the current time is not suddenly some large amount
+               if ( time_current < time_process / count * 20 || !time_process || count < 5 )
+               {
+                       // Accumulate the cost for processing this frame
+                       time_process += time_current;
+               }
+               else
+               {
+                       mlt_log_debug( self, "current %"PRId64" threshold %"PRId64" count %d\n",
+                               time_current, (int64_t) (time_process / count * 20), count );
+                       // Ignore the cost of this frame's time
+                       count--;
+               }
+
+               // Determine if we started, resumed, or seeked
+               if ( pos != last_pos + 1 )
+                       start_pos = pos;
+               last_pos = pos;
+
+               // Do not skip the first 20% of buffer at start, resume, or seek
+               if ( pos - start_pos <= buffer / 5 + 1 )
+               {
+                       // Reset cost tracker
+                       time_process = 0;
+                       count = 1;
+               }
+
+               // Reset skip flag
+               skip_next = 0;
 
-               // Determine if the next frame should be skipped
-               if ( mlt_deque_count( self->queue ) <= 5 )
+               // Only consider skipping if the buffer level is low (or really small)
+               if ( mlt_deque_count( self->queue ) <= buffer / 5 + 1 )
                {
-                       int frame_duration = mlt_properties_get_int( properties, "frame_duration" );
-                       if ( ( ( time_wait + time_frame + time_process ) / count ) > frame_duration )
+                       // Skip next frame if average cost exceeds frame duration.
+                       if ( time_process / count > frame_duration )
                                skip_next = 1;
+                       if ( skip_next )
+                               mlt_log_debug( self, "avg usec %"PRId64" (%"PRId64"/%d) duration %d\n",
+                                       time_process/count, time_process, count, frame_duration);
                }
        }
 
@@ -1184,7 +1223,7 @@ static mlt_frame worker_get_frame( mlt_consumer self, mlt_properties properties
        // Adapt the worker process head to the runtime conditions.
        if ( self->real_time > 0 )
        {
-               if ( mlt_properties_get_int( MLT_FRAME_PROPERTIES( frame ), "rendered" ) )
+               if ( frame && mlt_properties_get_int( MLT_FRAME_PROPERTIES( frame ), "rendered" ) )
                {
                        self->consecutive_dropped = 0;
                        if ( self->process_head > size && self->consecutive_rendered >= self->process_head )