]> git.sesse.net Git - mlt/blobdiff - src/framework/mlt_frame.c
Return and handle errors on failure to produce image (kdenlive-1312).
[mlt] / src / framework / mlt_frame.c
index 64ec68dfd194c8c96c26f2e99d380ad0c024f6f6..976cecf0e7d37a1903b617a72ae1a2a9f6582a49 100644 (file)
-/*
- * mlt_frame.c -- interface for all frame classes
- * Copyright (C) 2003-2004 Ushodaya Enterprises Limited
- * Author: Charles Yates <charles.yates@pandora.be>
+/**
+ * \file mlt_frame.c
+ * \brief interface for all frame classes
+ * \see mlt_frame_s
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
+ * Copyright (C) 2003-2009 Ushodaya Enterprises Limited
+ * \author Charles Yates <charles.yates@pandora.be>
  *
- * This program is distributed in the hope that it will be useful,
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#include "config.h"
 #include "mlt_frame.h"
+#include "mlt_producer.h"
+#include "mlt_factory.h"
+#include "mlt_profile.h"
+#include "mlt_log.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-typedef struct
-{
-       mlt_image_format vfmt;
-       int width;
-       int height;
-       uint8_t *image;
-       uint8_t *alpha;
-       mlt_audio_format afmt;
-       int16_t *audio;
-}
-frame_test;
-
-static frame_test test_card = { mlt_image_none, 0, 0, NULL, NULL, mlt_audio_none, NULL };
-
-/** Constructor for a frame.
-*/
+/** Construct a frame object.
+ *
+ * \public \memberof mlt_frame_s
+ * \param service the pointer to any service that can provide access to the profile
+ * \return a frame object on success or NULL if there was an allocation error
+ */
 
-mlt_frame mlt_frame_init( )
+mlt_frame mlt_frame_init( mlt_service service )
 {
        // Allocate a frame
        mlt_frame this = calloc( sizeof( struct mlt_frame_s ), 1 );
 
        if ( this != NULL )
        {
+               mlt_profile profile = mlt_service_profile( service );
+
                // Initialise the properties
                mlt_properties properties = &this->parent;
                mlt_properties_init( properties, this );
 
                // Set default properties on the frame
-               mlt_properties_set_timecode( properties, "timecode", 0.0 );
+               mlt_properties_set_position( properties, "_position", 0.0 );
                mlt_properties_set_data( properties, "image", NULL, 0, NULL, NULL );
-               mlt_properties_set_int( properties, "width", 720 );
-               mlt_properties_set_int( properties, "height", 576 );
-               mlt_properties_set_double( properties, "aspect_ratio", 4.0 / 3.0 );
+               mlt_properties_set_int( properties, "width", profile? profile->width : 720 );
+               mlt_properties_set_int( properties, "height", profile? profile->height : 576 );
+               mlt_properties_set_int( properties, "normalised_width", profile? profile->width : 720 );
+               mlt_properties_set_int( properties, "normalised_height", profile? profile->height : 576 );
+               mlt_properties_set_double( properties, "aspect_ratio", mlt_profile_sar( NULL ) );
                mlt_properties_set_data( properties, "audio", NULL, 0, NULL, NULL );
                mlt_properties_set_data( properties, "alpha", NULL, 0, NULL, NULL );
+
+               // Construct stacks for frames and methods
+               this->stack_image = mlt_deque_init( );
+               this->stack_audio = mlt_deque_init( );
+               this->stack_service = mlt_deque_init( );
        }
+
        return this;
 }
 
-/** Fetch the frames properties.
-*/
+/** Get a frame's properties.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return the frame's properties or NULL if an invalid frame is supplied
+ */
 
 mlt_properties mlt_frame_properties( mlt_frame this )
 {
-       return &this->parent;
+       return this != NULL ? &this->parent : NULL;
 }
 
-/** Check if we have a way to derive something other than a test card.
-*/
+/** Determine if the frame will produce a test card image.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return true (non-zero) if this will produce from a test card
+ */
 
 int mlt_frame_is_test_card( mlt_frame this )
 {
-       return this->stack_get_image_size == 0;
+       return mlt_deque_count( this->stack_image ) == 0 || mlt_properties_get_int( MLT_FRAME_PROPERTIES( this ), "test_image" );
+}
+
+/** Determine if the frame will produce audio from a test card.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return true (non-zero) if this will produce from a test card
+ */
+
+int mlt_frame_is_test_audio( mlt_frame this )
+{
+       return mlt_deque_count( this->stack_audio ) == 0 || mlt_properties_get_int( MLT_FRAME_PROPERTIES( this ), "test_audio" );
 }
 
-/** Get the aspect ratio of the frame.
-*/
+/** Get the sample aspect ratio of the frame.
+ *
+ * \public \memberof  mlt_frame_s
+ * \param this a frame
+ * \return the aspect ratio
+ */
 
 double mlt_frame_get_aspect_ratio( mlt_frame this )
 {
-       mlt_properties properties = mlt_frame_properties( this );
-       return mlt_properties_get_double( properties, "aspect_ratio" );
+       return mlt_properties_get_double( MLT_FRAME_PROPERTIES( this ), "aspect_ratio" );
 }
 
-/** Set the aspect ratio of the frame.
-*/
+/** Set the sample aspect ratio of the frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param value the new image sample aspect ratio
+ * \return true if error
+ */
 
 int mlt_frame_set_aspect_ratio( mlt_frame this, double value )
 {
-       mlt_properties properties = mlt_frame_properties( this );
-       return mlt_properties_set_double( properties, "aspect_ratio", value );
+       return mlt_properties_set_double( MLT_FRAME_PROPERTIES( this ), "aspect_ratio", value );
 }
 
-/** Get the timecode of this frame.
-*/
+/** Get the time position of this frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return the position
+ */
 
-mlt_timecode mlt_frame_get_timecode( mlt_frame this )
+mlt_position mlt_frame_get_position( mlt_frame this )
 {
-       mlt_properties properties = mlt_frame_properties( this );
-       return mlt_properties_get_timecode( properties, "timecode" );
+       int pos = mlt_properties_get_position( MLT_FRAME_PROPERTIES( this ), "_position" );
+       return pos < 0 ? 0 : pos;
 }
 
-/** Set the timecode of this frame.
-*/
+/** Set the time position of this frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param value the position
+ * \return true if error
+ */
 
-int mlt_frame_set_timecode( mlt_frame this, mlt_timecode value )
+int mlt_frame_set_position( mlt_frame this, mlt_position value )
 {
-       mlt_properties properties = mlt_frame_properties( this );
-       return mlt_properties_set_timecode( properties, "timecode", value );
+       return mlt_properties_set_position( MLT_FRAME_PROPERTIES( this ), "_position", value );
 }
 
 /** Stack a get_image callback.
-*/
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param the get_image callback
+ * \return true if error
+ */
 
 int mlt_frame_push_get_image( mlt_frame this, mlt_get_image get_image )
 {
-       int ret = this->stack_get_image_size >= 10;
-       if ( ret == 0 )
-               this->stack_get_image[ this->stack_get_image_size ++ ] = get_image;
-       return ret;
+       return mlt_deque_push_back( this->stack_image, get_image );
 }
 
 /** Pop a get_image callback.
-*/
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return the get_image callback
+ */
 
 mlt_get_image mlt_frame_pop_get_image( mlt_frame this )
 {
-       mlt_get_image result = NULL;
-       if ( this->stack_get_image_size > 0 )
-               result = this->stack_get_image[ -- this->stack_get_image_size ];
-       return result;
+       return mlt_deque_pop_back( this->stack_image );
 }
 
 /** Push a frame.
-*/
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param that the frame to push onto \p this
+ * \return true if error
+ */
 
 int mlt_frame_push_frame( mlt_frame this, mlt_frame that )
 {
-       int ret = this->stack_frame_size >= 10;
-       if ( ret == 0 )
-               this->stack_frame[ this->stack_frame_size ++ ] = that;
-       return ret;
+       return mlt_deque_push_back( this->stack_image, that );
 }
 
 /** Pop a frame.
-*/
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return a frame that was previously pushed
+ */
 
 mlt_frame mlt_frame_pop_frame( mlt_frame this )
 {
-       mlt_frame result = NULL;
-       if ( this->stack_frame_size > 0 )
-               result = this->stack_frame[ -- this->stack_frame_size ];
-       return result;
+       return mlt_deque_pop_back( this->stack_image );
 }
 
-int mlt_frame_get_image( mlt_frame this, uint8_t **buffer, mlt_image_format *format, int *width, int *height, int writable )
+/** Push a service.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param that an opaque pointer
+ * \return true if error
+ */
+
+int mlt_frame_push_service( mlt_frame this, void *that )
 {
-       mlt_properties properties = mlt_frame_properties( this );
-       mlt_get_image get_image = mlt_frame_pop_get_image( this );
-       
-       if ( get_image != NULL )
-       {
-               return get_image( this, buffer, format, width, height, writable );
-       }
-       else if ( mlt_properties_get_data( properties, "image", NULL ) != NULL )
-       {
-               *format = mlt_image_yuv422;
-               *buffer = mlt_properties_get_data( properties, "image", NULL );
-               *width = mlt_properties_get_int( properties, "width" );
-               *height = mlt_properties_get_int( properties, "height" );
-       }
-       else
-       {
-               if ( test_card.vfmt != *format )
-               {
-                       uint8_t *p;
-                       uint8_t *q;
-                       
-                       test_card.vfmt = *format;
-                       test_card.width = *width == 0 ? 720 : *width;
-                       test_card.height = *height == 0 ? 576 : *height;
-
-                       switch( *format )
-                       {
-                               case mlt_image_none:
-                                       break;
-                               case mlt_image_rgb24:
-                                       test_card.image = realloc( test_card.image, test_card.width * test_card.height * 3 );
-                                       memset( test_card.image, 255, test_card.width * test_card.height * 3 );
-                                       break;
-                               case mlt_image_rgb24a:
-                                       test_card.image = realloc( test_card.image, test_card.width * test_card.height * 4 );
-                                       memset( test_card.image, 255, test_card.width * test_card.height * 4 );
-                                       break;
-                               case mlt_image_yuv422:
-                                       test_card.image = realloc( test_card.image, test_card.width * test_card.height * 2 );
-                                       p = test_card.image;
-                                       q = test_card.image + test_card.width * test_card.height * 2;
-                                       while ( p != q )
-                                       {
-                                               *p ++ = 255;
-                                               *p ++ = 128;
-                                       }
-                                       break;
-                               case mlt_image_yuv420p:
-                                       test_card.image = realloc( test_card.image, test_card.width * test_card.height * 3 / 2 );
-                                       memset( test_card.image, 255, test_card.width * test_card.height * 3 / 2 );
-                                       break;
-                       }
-               }
+       return mlt_deque_push_back( this->stack_image, that );
+}
 
-               *width = test_card.width;
-               *height = test_card.height;
-               *buffer = test_card.image;
-       }
+/** Pop a service.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return an opaque pointer to something previously pushed
+ */
 
-       return 0;
+void *mlt_frame_pop_service( mlt_frame this )
+{
+       return mlt_deque_pop_back( this->stack_image );
 }
 
-uint8_t *mlt_frame_get_alpha_mask( mlt_frame this )
+/** Push a number.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param that an integer
+ * \return true if error
+ */
+
+int mlt_frame_push_service_int( mlt_frame this, int that )
 {
-       if ( this->get_alpha_mask != NULL )
-               return this->get_alpha_mask( this );
-       return test_card.alpha;
+       return mlt_deque_push_back_int( this->stack_image, that );
 }
 
-int mlt_frame_get_audio( mlt_frame this, int16_t **buffer, mlt_audio_format *format, int *frequency, int *channels, int *samples )
+/** Pop a number.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return an integer that was previously pushed
+ */
+
+int mlt_frame_pop_service_int( mlt_frame this )
 {
-       if ( this->get_audio != NULL )
-       {
-               return this->get_audio( this, buffer, format, frequency, channels, samples );
-       }
-       else
-       {
-               if ( *samples <= 0 )
-                       *samples = 1920;
-               if ( *channels <= 0 )
-                       *channels = 2;
-               if ( *frequency <= 0 )
-                       *frequency = 48000;
-               if ( test_card.afmt != *format )
-               {
-                       test_card.afmt = *format;
-                       test_card.audio = realloc( test_card.audio, *samples * *channels * sizeof( int16_t ) );
-                       memset( test_card.audio, 0, *samples * *channels * sizeof( int16_t ) );
-               }
-               
-               *buffer = test_card.audio;
-       }
-       return 0;
+       return mlt_deque_pop_back_int( this->stack_image );
 }
 
-void mlt_frame_close( mlt_frame this )
+/** Push an audio item on the stack.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param that an opaque pointer
+ * \return true if error
+ */
+
+int mlt_frame_push_audio( mlt_frame this, void *that )
 {
-       mlt_frame frame = mlt_frame_pop_frame( this );
-       
-       while ( frame != NULL )
+       return mlt_deque_push_back( this->stack_audio, that );
+}
+
+/** Pop an audio item from the stack
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return an opaque pointer to something that was pushed onto the frame's audio stack
+ */
+
+void *mlt_frame_pop_audio( mlt_frame this )
+{
+       return mlt_deque_pop_back( this->stack_audio );
+}
+
+/** Return the service stack
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return the service stack
+ */
+
+mlt_deque mlt_frame_service_stack( mlt_frame this )
+{
+       return this->stack_service;
+}
+
+/** Replace image stack with the information provided.
+ *
+ * This might prove to be unreliable and restrictive - the idea is that a transition
+ * which normally uses two images may decide to only use the b frame (ie: in the case
+ * of a composite where the b frame completely obscures the a frame).
+ *
+ * The image must be writable and the destructor for the image itself must be taken
+ * care of on another frame and that frame cannot have a replace applied to it...
+ * Further it assumes that no alpha mask is in use.
+ *
+ * For these reasons, it can only be used in a specific situation - when you have
+ * multiple tracks each with their own transition and these transitions are applied
+ * in a strictly reversed order (ie: highest numbered [lowest track] is processed
+ * first).
+ *
+ * More reliable approach - the cases should be detected during the process phase
+ * and the upper tracks should simply not be invited to stack...
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param image a new image
+ * \param format the image format
+ * \param width the width of the new image
+ * \param height the height of the new image
+ */
+
+void mlt_frame_replace_image( mlt_frame this, uint8_t *image, mlt_image_format format, int width, int height )
+{
+       // Remove all items from the stack
+       while( mlt_deque_pop_back( this->stack_image ) ) ;
+
+       // Update the information
+       mlt_properties_set_data( MLT_FRAME_PROPERTIES( this ), "image", image, 0, NULL, NULL );
+       mlt_properties_set_int( MLT_FRAME_PROPERTIES( this ), "width", width );
+       mlt_properties_set_int( MLT_FRAME_PROPERTIES( this ), "height", height );
+       mlt_properties_set_int( MLT_FRAME_PROPERTIES( this ), "format", format );
+       this->get_alpha_mask = NULL;
+}
+
+/** Get the short name for an image format.
+ *
+ * \public \memberof mlt_frame_s
+ * \param format the image format
+ * \return a string
+ */
+
+const char * mlt_image_format_name( mlt_image_format format )
+{
+       switch ( format )
        {
-               mlt_frame_close( frame);
-               frame = mlt_frame_pop_frame( this );
+               case mlt_image_none:    return "none";
+               case mlt_image_rgb24:   return "rgb24";
+               case mlt_image_rgb24a:  return "rgb24a";
+               case mlt_image_yuv422:  return "yuv422";
+               case mlt_image_yuv420p: return "yuv420p";
+               case mlt_image_opengl:  return "opengl";
        }
-       
-       mlt_properties_close( &this->parent );
-
-       free( this );
+       return "invalid";
 }
 
-/***** convenience functions *****/
-#define RGB2YUV(r, g, b, y, u, v)\
-  y = (306*r + 601*g + 117*b)  >> 10;\
-  u = ((-172*r - 340*g + 512*b) >> 10)  + 128;\
-  v = ((512*r - 429*g - 83*b) >> 10) + 128;\
-  y = y < 0 ? 0 : y;\
-  u = u < 0 ? 0 : u;\
-  v = v < 0 ? 0 : v;\
-  y = y > 255 ? 255 : y;\
-  u = u > 255 ? 255 : u;\
-  v = v > 255 ? 255 : v
-
-int mlt_convert_rgb24a_to_yuv422( uint8_t *rgba, int width, int height, int stride, uint8_t *yuv, uint8_t *alpha )
+/** Get the image associated to the frame.
+ *
+ * You should express the desired format, width, and height as inputs. As long
+ * as the loader producer was used to generate this or the imageconvert filter
+ * was attached, then you will get the image back in the format you desire.
+ * However, you do not always get the width and height you request depending
+ * on properties and filters. You do not need to supply a pre-allocated
+ * buffer, but you should always supply the desired image format.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param[out] buffer an image buffer
+ * \param[in,out] format the image format
+ * \param[in,out] width the horizontal size in pixels
+ * \param[in,out] height the vertical size in pixels
+ * \param writable whether or not you will need to be able to write to the memory returned in \p buffer
+ * \return true if error
+ * \todo Better describe the width and height as inputs.
+ */
+
+int mlt_frame_get_image( mlt_frame this, uint8_t **buffer, mlt_image_format *format, int *width, int *height, int writable )
 {
-       int ret = 0;
-       register int y0, y1, u0, u1, v0, v1;
-       register int r, g, b;
-       register uint8_t *d = yuv;
-       register int i, j;
+       mlt_properties properties = MLT_FRAME_PROPERTIES( this );
+       mlt_get_image get_image = mlt_frame_pop_get_image( this );
+       mlt_producer producer = mlt_properties_get_data( properties, "test_card_producer", NULL );
+       mlt_image_format requested_format = *format;
+       int error = 0;
 
-       for ( i = 0; i < height; i++ )
+       if ( get_image )
        {
-               register uint8_t *s = rgba + ( stride * i );
-               for ( j = 0; j < ( width / 2 ); j++ )
+               mlt_properties_set_int( properties, "image_count", mlt_properties_get_int( properties, "image_count" ) - 1 );
+               error = get_image( this, buffer, format, width, height, writable );
+               if ( !error )
                {
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       *alpha++ = *s++;
-                       RGB2YUV (r, g, b, y0, u0 , v0);
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       *alpha++ = *s++;
-                       RGB2YUV (r, g, b, y1, u1 , v1);
-                       *d++ = y0;
-                       *d++ = (u0+u1) >> 1;
-                       *d++ = y1;
-                       *d++ = (v0+v1) >> 1;
+                       mlt_properties_set_int( properties, "width", *width );
+                       mlt_properties_set_int( properties, "height", *height );
+                       mlt_properties_set_int( properties, "format", *format );
+                       if ( this->convert_image )
+                               this->convert_image( this, buffer, format, requested_format );
                }
-               if ( width % 2 )
+               else
                {
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       *alpha++ = *s++;
-                       RGB2YUV (r, g, b, y0, u0 , v0);
-                       *d++ = y0;
-                       *d++ = u0;
+                       // Cause the image to be loaded from test card or fallback (white) below.
+                       mlt_frame_get_image( this, buffer, format, width, height, writable );
                }
        }
-       return ret;
-}
-
-int mlt_convert_rgb24_to_yuv422( uint8_t *rgb, int width, int height, int stride, uint8_t *yuv )
-{
-       int ret = 0;
-       register int y0, y1, u0, u1, v0, v1;
-       register int r, g, b;
-       register uint8_t *d = yuv;
-       register int i, j;
-
-       for ( i = 0; i < height; i++ )
+       else if ( mlt_properties_get_data( properties, "image", NULL ) )
        {
-               register uint8_t *s = rgb + ( stride * i );
-               for ( j = 0; j < ( width / 2 ); j++ )
+               *format = mlt_properties_get_int( properties, "format" );
+               *buffer = mlt_properties_get_data( properties, "image", NULL );
+               *width = mlt_properties_get_int( properties, "width" );
+               *height = mlt_properties_get_int( properties, "height" );
+               if ( this->convert_image )
+                       this->convert_image( this, buffer, format, requested_format );
+       }
+       else if ( producer )
+       {
+               mlt_frame test_frame = NULL;
+               mlt_service_get_frame( MLT_PRODUCER_SERVICE( producer ), &test_frame, 0 );
+               if ( test_frame )
                {
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       RGB2YUV (r, g, b, y0, u0 , v0);
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       RGB2YUV (r, g, b, y1, u1 , v1);
-                       *d++ = y0;
-                       *d++ = (u0+u1) >> 1;
-                       *d++ = y1;
-                       *d++ = (v0+v1) >> 1;
+                       mlt_properties test_properties = MLT_FRAME_PROPERTIES( test_frame );
+                       mlt_properties_set_double( test_properties, "consumer_aspect_ratio", mlt_properties_get_double( properties, "consumer_aspect_ratio" ) );
+                       mlt_properties_set( test_properties, "rescale.interp", mlt_properties_get( properties, "rescale.interp" ) );
+                       mlt_frame_get_image( test_frame, buffer, format, width, height, writable );
+                       mlt_properties_set_data( properties, "test_card_frame", test_frame, 0, ( mlt_destructor )mlt_frame_close, NULL );
+                       mlt_properties_set_double( properties, "aspect_ratio", mlt_frame_get_aspect_ratio( test_frame ) );
+//                     mlt_properties_set_data( properties, "image", *buffer, *width * *height * 2, NULL, NULL );
+//                     mlt_properties_set_int( properties, "width", *width );
+//                     mlt_properties_set_int( properties, "height", *height );
+//                     mlt_properties_set_int( properties, "format", *format );
                }
-               if ( width % 2 )
+               else
                {
-                       r = *s++;
-                       g = *s++;
-                       b = *s++;
-                       RGB2YUV (r, g, b, y0, u0 , v0);
-                       *d++ = y0;
-                       *d++ = u0;
+                       mlt_properties_set_data( properties, "test_card_producer", NULL, 0, NULL, NULL );
+                       mlt_frame_get_image( this, buffer, format, width, height, writable );
                }
        }
-       return ret;
-}
-
-int mlt_convert_yuv420p_to_yuv422( uint8_t *yuv420p, int width, int height, int stride, uint8_t *yuv )
-{
-       int ret = 0;
-       register int i, j;
-
-       int half = width >> 1;
-
-       uint8_t *Y = yuv420p;
-       uint8_t *U = Y + width * height;
-       uint8_t *V = U + width * height / 4;
+       else
+       {
+               register uint8_t *p;
+               register uint8_t *q;
+               int size = 0;
 
-       register uint8_t *d = yuv;
+               *width = *width == 0 ? 720 : *width;
+               *height = *height == 0 ? 576 : *height;
+               size = *width * *height;
 
-       for ( i = 0; i < height; i++ )
-       {
-               register uint8_t *u = U + ( i / 2 ) * ( half );
-               register uint8_t *v = V + ( i / 2 ) * ( half );
+               mlt_properties_set_int( properties, "format", *format );
+               mlt_properties_set_int( properties, "width", *width );
+               mlt_properties_set_int( properties, "height", *height );
+               mlt_properties_set_int( properties, "aspect_ratio", 0 );
 
-               for ( j = 0; j < half; j++ )
+               switch( *format )
                {
-                       *d ++ = *Y ++;
-                       *d ++ = *u ++;
-                       *d ++ = *Y ++;
-                       *d ++ = *v ++;
+                       case mlt_image_none:
+                               size = 0;
+                               *buffer = NULL;
+                               break;
+                       case mlt_image_rgb24:
+                               size *= 3;
+                               size += *width * 3;
+                               *buffer = mlt_pool_alloc( size );
+                               if ( *buffer )
+                                       memset( *buffer, 255, size );
+                               break;
+                       case mlt_image_rgb24a:
+                       case mlt_image_opengl:
+                               size *= 4;
+                               size += *width * 4;
+                               *buffer = mlt_pool_alloc( size );
+                               if ( *buffer )
+                                       memset( *buffer, 255, size );
+                               break;
+                       case mlt_image_yuv422:
+                               size *= 2;
+                               size += *width * 2;
+                               *buffer = mlt_pool_alloc( size );
+                               p = *buffer;
+                               q = p + size;
+                               while ( p != NULL && p != q )
+                               {
+                                       *p ++ = 235;
+                                       *p ++ = 128;
+                               }
+                               break;
+                       case mlt_image_yuv420p:
+                               size = size * 3 / 2;
+                               *buffer = mlt_pool_alloc( size );
+                               if ( *buffer )
+                                       memset( *buffer, 255, size );
+                               break;
                }
-       }
-       return ret;
-}
-
-int mlt_frame_composite_yuv( mlt_frame this, mlt_frame that, int x, int y, float weight )
-{
-       int ret = 0;
-       int width_src = 0, height_src = 0;
-       int width_dest = 0, height_dest = 0;
-       mlt_image_format format_src = mlt_image_yuv422, format_dest = mlt_image_yuv422;
-       uint8_t *p_src, *p_dest;
-       int i, j;
-       int stride_src;
-       int stride_dest;
-       int x_src = 0, y_src = 0;
-
-       // optimization point - no work to do
-       if ( ( x < 0 && -x >= width_src ) || ( y < 0 && -y >= height_src ) )
-               return ret;
-
-       format_src = mlt_image_yuv422;
-       format_dest = mlt_image_yuv422;
-
-       //fprintf( stderr, "call get_image on frame a\n"), fflush( stderr );
-       mlt_frame_get_image( this, &p_dest, &format_dest, &width_dest, &height_dest, 1 /* writable */ );
-       //fprintf( stderr, "call get_image on frame b\n"), fflush( stderr );
-       mlt_frame_get_image( that, &p_src, &format_src, &width_src, &height_src, 0 /* writable */ );
-
-       //fprintf( stderr, "mlt_frame_composite_yuv %dx%d -> %dx%d\n", width_src, height_src, width_dest, height_dest );
-       //fflush(stderr);
-       //return ret;
-       stride_src = width_src * 2;
-       stride_dest = width_dest * 2;
-       
-       // crop overlay off the left edge of frame
-       if ( x < 0 )
-       {
-               x_src = -x;
-               width_src -= x_src;
-               x = 0;
-       }
-       
-       // crop overlay beyond right edge of frame
-       else if ( x + width_src > width_dest )
-               width_src = width_dest - x;
 
-       // crop overlay off the top edge of the frame
-       if ( y < 0 )
-       {
-               y_src = -y;
-               height_src -= y_src;
+               mlt_properties_set_data( properties, "image", *buffer, size, ( mlt_destructor )mlt_pool_release, NULL );
+               mlt_properties_set_int( properties, "test_image", 1 );
        }
-       // crop overlay below bottom edge of frame
-       else if ( y + height_src > height_dest )
-               height_src = height_dest - y;
 
-       // offset pointer into overlay buffer based on cropping
-       p_src += x_src * 2 + y_src * stride_src;
+       mlt_properties_set_int( properties, "scaled_width", *width );
+       mlt_properties_set_int( properties, "scaled_height", *height );
 
-       // offset pointer into frame buffer based upon positive, even coordinates only!
-//     if ( interlaced && y % 2 )
-//             ++y;
-       p_dest += ( x < 0 ? 0 : x ) * 2 + ( y < 0 ? 0 : y ) * stride_dest;
-
-       // Get the alpha channel of the overlay
-       uint8_t *p_alpha = mlt_frame_get_alpha_mask( that );
+       return error;
+}
 
-       // offset pointer into alpha channel based upon cropping
-       if ( p_alpha )
-               p_alpha += x_src + y_src * stride_src / 2;
+/** Get the alpha channel associated to the frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return the alpha channel
+ */
 
-       // now do the compositing only to cropped extents
-       for ( i = 0; i < height_src; i++ )
+uint8_t *mlt_frame_get_alpha_mask( mlt_frame this )
+{
+       uint8_t *alpha = NULL;
+       if ( this != NULL )
        {
-               uint8_t *p = p_src;
-               uint8_t *q = p_dest;
-               uint8_t *o = p_dest;
-               uint8_t *z = p_alpha;
-
-               for ( j = 0; j < width_src; j ++ )
+               if ( this->get_alpha_mask != NULL )
+                       alpha = this->get_alpha_mask( this );
+               if ( alpha == NULL )
+                       alpha = mlt_properties_get_data( &this->parent, "alpha", NULL );
+               if ( alpha == NULL )
                {
-                               uint8_t y = *p ++;
-                               uint8_t uv = *p ++;
-                               uint8_t a = ( z == NULL ) ? 255 : *z ++;
-                               float value = ( weight * ( float ) a / 255.0 );
-                               *o ++ = (uint8_t)( y * value + *q++ * ( 1 - value ) );
-                               *o ++ = (uint8_t)( uv * value + *q++ * ( 1 - value ) );
+                       int size = mlt_properties_get_int( &this->parent, "scaled_width" ) * mlt_properties_get_int( &this->parent, "scaled_height" );
+                       alpha = mlt_pool_alloc( size );
+                       memset( alpha, 255, size );
+                       mlt_properties_set_data( &this->parent, "alpha", alpha, size, mlt_pool_release, NULL );
                }
-
-               p_src += stride_src;
-               p_dest += stride_dest;
-               if ( p_alpha )
-                       p_alpha += stride_src / 2;
        }
-
-       return ret;
+       return alpha;
 }
 
-void *memfill( void *dst, void *src, int l, int elements )
-{
-       int i = 0;
-       for ( i = 0; i < elements; i ++ )
-               dst = memcpy( dst, src, l ) + l;
-       return dst;
-}
+/** Get the short name for an audio format.
+ *
+ * You do not need to deallocate the returned string.
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param format an image format enum
+ * \return a string for the name of the image format
+ */
 
-void mlt_resize_yuv422( uint8_t *output, int owidth, int oheight, uint8_t *input, int iwidth, int iheight )
+const char * mlt_audio_format_name( mlt_audio_format format )
 {
-       // Calculate strides
-       int istride = iwidth * 2;
-       int ostride = owidth * 2;
-
-       iwidth = iwidth - ( iwidth % 4 );
-       owidth = owidth - ( owidth % 4 );
-       iheight = iheight - ( iheight % 2 );
-       oheight = oheight - ( oheight % 2 );
-
-       // Coordinates (0,0 is middle of output)
-       int y;
-
-       // Calculate ranges
-       int out_x_range = owidth / 2;
-       int out_y_range = oheight / 2;
-       int in_x_range = iwidth / 2 < out_x_range ? iwidth / 2 : out_x_range;
-       int in_y_range = iheight / 2 < out_y_range ? iheight / 2 : out_y_range;
-
-       // Output pointers
-       uint8_t *out_line = output;
-       uint8_t *out_ptr = out_line;
-
-       // Calculate a middle and possibly invalid pointer in the input
-       uint8_t *in_middle = input + istride * ( iheight / 2 ) + ( iwidth / 2 ) * 2;
-       int in_line = - in_y_range * istride - in_x_range * 2;
+       switch ( format )
+       {
+               case mlt_audio_none:   return "none";
+               case mlt_audio_s16:    return "s16";
+               case mlt_audio_s32:    return "s32";
+               case mlt_audio_float:  return "float";
+       }
+       return "invalid";
+}
 
-       uint8_t black[ 2 ] = { 16, 128 };
+/** Get the audio associated to the frame.
+ *
+ * You should express the desired format, frequency, channels, and samples as inputs. As long
+ * as the loader producer was used to generate this or the audioconvert filter
+ * was attached, then you will get the audio back in the format you desire.
+ * However, you do not always get the channels and samples you request depending
+ * on properties and filters. You do not need to supply a pre-allocated
+ * buffer, but you should always supply the desired audio format.
+ * The audio is always in interleaved format.
+ * You should use the \p mlt_sample_calculator to determine the number of samples you want.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param[out] buffer an audio buffer
+ * \param[in,out] format the audio format
+ * \param[in,out] frequency the sample rate
+ * \param[in,out] channels
+ * \param[in,out] samples the number of samples per frame
+ * \return true if error
+ */
 
-       // Loop for the entirety of our output height.
-       for ( y = - out_y_range; y < out_y_range ; y ++ )
-       {
-               // Start at the beginning of the line
-               out_ptr = out_line;
+int mlt_frame_get_audio( mlt_frame this, void **buffer, mlt_audio_format *format, int *frequency, int *channels, int *samples )
+{
+       mlt_get_audio get_audio = mlt_frame_pop_audio( this );
+       mlt_properties properties = MLT_FRAME_PROPERTIES( this );
+       int hide = mlt_properties_get_int( properties, "test_audio" );
+       mlt_audio_format requested_format = *format;
 
-               if ( abs( y ) < iheight / 2 )
+       if ( hide == 0 && get_audio != NULL )
+       {
+               get_audio( this, buffer, format, frequency, channels, samples );
+               mlt_properties_set_int( properties, "audio_frequency", *frequency );
+               mlt_properties_set_int( properties, "audio_channels", *channels );
+               mlt_properties_set_int( properties, "audio_samples", *samples );
+               mlt_properties_set_int( properties, "audio_format", *format );
+               if ( this->convert_audio )
+                       this->convert_audio( this, buffer, format, requested_format );
+       }
+       else if ( mlt_properties_get_data( properties, "audio", NULL ) )
+       {
+               *buffer = mlt_properties_get_data( properties, "audio", NULL );
+               *format = mlt_properties_get_int( properties, "audio_format" );
+               *frequency = mlt_properties_get_int( properties, "audio_frequency" );
+               *channels = mlt_properties_get_int( properties, "audio_channels" );
+               *samples = mlt_properties_get_int( properties, "audio_samples" );
+               if ( this->convert_audio )
+                       this->convert_audio( this, buffer, format, requested_format );
+       }
+       else
+       {
+               int size = 0;
+               *samples = *samples <= 0 ? 1920 : *samples;
+               *channels = *channels <= 0 ? 2 : *channels;
+               *frequency = *frequency <= 0 ? 48000 : *frequency;
+               mlt_properties_set_int( properties, "audio_frequency", *frequency );
+               mlt_properties_set_int( properties, "audio_channels", *channels );
+               mlt_properties_set_int( properties, "audio_samples", *samples );
+               mlt_properties_set_int( properties, "audio_format", *format );
+
+               switch( *format )
                {
-                       // Fill the outer part with black
-                       out_ptr = memfill( out_ptr, black, 2, out_x_range - in_x_range );
-
-                       // We're in the input range for this row.
-                       memcpy( out_ptr, in_middle + in_line, 2 * iwidth );
-                       out_ptr += 2 * iwidth;
+                       case mlt_image_none:
+                               size = 0;
+                               *buffer = NULL;
+                               break;
+                       case mlt_audio_s16:
+                               size = *samples * *channels * sizeof( int16_t );
+                               break;
+                       case mlt_audio_s32:
+                               size = *samples * *channels * sizeof( int32_t );
+                               break;
+                       case mlt_audio_float:
+                               size = *samples * *channels * sizeof( float );
+                               break;
+               }
+               if ( size )
+                       *buffer = mlt_pool_alloc( size );
+               if ( *buffer )
+                       memset( *buffer, 0, size );
+               mlt_properties_set_data( properties, "audio", *buffer, size, ( mlt_destructor )mlt_pool_release, NULL );
+               mlt_properties_set_int( properties, "test_audio", 1 );
+       }
 
-                       // Fill the outer part with black
-                       out_ptr = memfill( out_ptr, black, 2, out_x_range - in_x_range );
+       // TODO: This does not belong here
+       if ( *format == mlt_audio_s16 && mlt_properties_get( properties, "meta.volume" ) )
+       {
+               double value = mlt_properties_get_double( properties, "meta.volume" );
 
-                       // Move to next input line
-                       in_line += istride;
+               if ( value == 0.0 )
+               {
+                       memset( *buffer, 0, *samples * *channels * 2 );
                }
-               else
+               else if ( value != 1.0 )
                {
-                       // Fill whole line with black
-                       out_ptr = memfill( out_ptr, black, 2, owidth );
+                       int total = *samples * *channels;
+                       int16_t *p = *buffer;
+                       while ( total -- )
+                       {
+                               *p = *p * value;
+                               p ++;
+                       }
                }
 
-               // Move to next output line
-               out_line += ostride;
-       }
+               mlt_properties_set( properties, "meta.volume", NULL );
+       }
+
+       return 0;
 }
 
-/** A resizing function for yuv422 frames - this does not rescale, but simply
-       resizes. It assumes yuv422 images available on the frame so use with care.
-*/
+/** Set the audio on a frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param buffer an buffer containing audio samples
+ * \param format the format of the audio in the \p buffer
+ * \param size the total size of the buffer (optional)
+ * \param destructor a function that releases or deallocates the \p buffer
+ * \return true if error
+ */
 
-uint8_t *mlt_frame_resize_yuv422( mlt_frame this, int owidth, int oheight )
+int mlt_frame_set_audio( mlt_frame this, void *buffer, mlt_audio_format format, int size, mlt_destructor destructor )
 {
-       // Get properties
-       mlt_properties properties = mlt_frame_properties( this );
+       mlt_properties_set_int( MLT_FRAME_PROPERTIES( this ), "audio_format", format );
+       return mlt_properties_set_data( MLT_FRAME_PROPERTIES( this ), "audio", buffer, size, destructor, NULL );
+}
 
-       // Get the input image, width and height
-       uint8_t *input = mlt_properties_get_data( properties, "image", NULL );
-       int iwidth = mlt_properties_get_int( properties, "width" );
-       int iheight = mlt_properties_get_int( properties, "height" );
+/** Get audio on a frame as a waveform image.
+ *
+ * This generates an 8-bit grayscale image representation of the audio in a
+ * frame. Currently, this only really works for 2 channels.
+ * This allocates the bitmap using mlt_pool so you should release the return
+ * value with \p mlt_pool_release.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \param w the width of the image
+ * \param h the height of the image to create
+ * \return a pointer to a new bitmap
+ */
 
-       // If width and height are correct, don't do anything
-       if ( iwidth != owidth || iheight != oheight )
+unsigned char *mlt_frame_get_waveform( mlt_frame this, int w, int h )
+{
+       int16_t *pcm = NULL;
+       mlt_properties properties = MLT_FRAME_PROPERTIES( this );
+       mlt_audio_format format = mlt_audio_s16;
+       int frequency = 32000; // lower frequency available?
+       int channels = 2;
+       double fps = mlt_profile_fps( NULL );
+       int samples = mlt_sample_calculator( fps, frequency, mlt_frame_get_position( this ) );
+
+       // Get the pcm data
+       mlt_frame_get_audio( this, (void**)&pcm, &format, &frequency, &channels, &samples );
+
+       // Make an 8-bit buffer large enough to hold rendering
+       int size = w * h;
+       unsigned char *bitmap = ( unsigned char* )mlt_pool_alloc( size );
+       if ( bitmap != NULL )
+               memset( bitmap, 0, size );
+       mlt_properties_set_data( properties, "waveform", bitmap, size, ( mlt_destructor )mlt_pool_release, NULL );
+
+       // Render vertical lines
+       int16_t *ubound = pcm + samples * channels;
+       int skip = samples / w - 1;
+       int i, j, k;
+
+       // Iterate sample stream and along x coordinate
+       for ( i = 0; i < w && pcm < ubound; i++ )
        {
-               // Create the output image
-               uint8_t *output = malloc( owidth * oheight * 2 );
-
-               // Call the generic resize
-               mlt_resize_yuv422( output, owidth, oheight, input, iwidth, iheight );
-
-               // Now update the frame
-               mlt_properties_set_data( properties, "image", output, owidth * oheight * 2, free, NULL );
-               mlt_properties_set_int( properties, "width", owidth );
-               mlt_properties_set_int( properties, "height", oheight );
-
-               // Return the output
-               return output;
+               // pcm data has channels interleaved
+               for ( j = 0; j < channels; j++ )
+               {
+                       // Determine sample's magnitude from 2s complement;
+                       int pcm_magnitude = *pcm < 0 ? ~(*pcm) + 1 : *pcm;
+                       // The height of a line is the ratio of the magnitude multiplied by
+                       // half the vertical resolution
+                       int height = ( int )( ( double )( pcm_magnitude ) / 32768 * h / 2 );
+                       // Determine the starting y coordinate - left channel above center,
+                       // right channel below - currently assumes 2 channels
+                       int displacement = ( h / 2 ) - ( 1 - j ) * height;
+                       // Position buffer pointer using y coordinate, stride, and x coordinate
+                       unsigned char *p = &bitmap[ i + displacement * w ];
+
+                       // Draw vertical line
+                       for ( k = 0; k < height; k++ )
+                               p[ w * k ] = 0xFF;
+
+                       pcm++;
+               }
+               pcm += skip * channels;
        }
 
-       // No change, return input
-       return input;
+       return bitmap;
 }
 
-/** A rescaling function for yuv422 frames - low quality, and provided for testing
-       only. It assumes yuv422 images available on the frame so use with care.
-*/
+/** Get the end service that produced this frame.
+ *
+ * This fetches the first producer of the frame and not any producers that
+ * encapsulate it.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ * \return a producer
+ */
 
-uint8_t *mlt_frame_rescale_yuv422( mlt_frame this, int owidth, int oheight )
+mlt_producer mlt_frame_get_original_producer( mlt_frame this )
 {
-       // Get properties
-       mlt_properties properties = mlt_frame_properties( this );
-
-       // Get the input image, width and height
-       uint8_t *input = mlt_properties_get_data( properties, "image", NULL );
-       int iwidth = mlt_properties_get_int( properties, "width" );
-       int iheight = mlt_properties_get_int( properties, "height" );
-
-       // If width and height are correct, don't do anything
-       if ( iwidth != owidth || iheight != oheight )
-       {
-               // Create the output image
-               uint8_t *output = malloc( owidth * oheight * 2 );
-
-               // Calculate strides
-               int istride = iwidth * 2;
-               int ostride = owidth * 2;
-
-               iwidth = iwidth - ( iwidth % 4 );
-
-       // Coordinates (0,0 is middle of output)
-       int y, x;
-
-               // Derived coordinates
-               int dy, dx;
-
-       // Calculate ranges
-       int out_x_range = owidth / 2;
-       int out_y_range = oheight / 2;
-       int in_x_range = iwidth / 2;
-       int in_y_range = iheight / 2;
-
-       // Output pointers
-       uint8_t *out_line = output;
-       uint8_t *out_ptr;
-
-       // Calculate a middle pointer
-       uint8_t *in_middle = input + istride * in_y_range + in_x_range * 2;
-       uint8_t *in_line;
-               uint8_t *in_ptr;
-
-               // Generate the affine transform scaling values
-               float scale_width = ( float )iwidth / ( float )owidth;
-               float scale_height = ( float )iheight / ( float )oheight;
-
-       // Loop for the entirety of our output height.
-       for ( y = - out_y_range; y < out_y_range ; y ++ )
-       {
-                       // Calculate the derived y value
-                       dy = scale_height * y;
-
-               // Start at the beginning of the line
-               out_ptr = out_line;
-       
-               // Pointer to the middle of the input line
-               in_line = in_middle + dy * istride;
-       
-               // Loop for the entirety of our output row.
-               for ( x = - out_x_range; x < out_x_range; x += 1 )
-               {
-                               // Calculated the derived x
-                               dx = scale_width * x;
-
-               // Check if x and y are in the valid input range.
-               if ( abs( dx ) < in_x_range && abs( dy ) < in_y_range  )
-               {
-                       // We're in the input range for this row.
-                                       in_ptr = in_line + ( dx >> 1 ) * 4 + 2 * ( x & 1 );
-                       *out_ptr ++ = *in_ptr ++;
-                       *out_ptr ++ = *in_ptr ++;
-               }
-               else
-               {
-                       // We're not in the input range for this row.
-                       *out_ptr ++ = 16;
-                       *out_ptr ++ = 128;
-               }
-               }
-
-               // Move to next output line
-               out_line += ostride;
-       }
-
-               // Now update the frame
-               mlt_properties_set_data( properties, "image", output, owidth * oheight * 2, free, NULL );
-               mlt_properties_set_int( properties, "width", owidth );
-               mlt_properties_set_int( properties, "height", oheight );
-
-               // Return the output
-               return output;
-       }
-
-       // No change, return input
-       return input;
+       if ( this != NULL )
+               return mlt_properties_get_data( MLT_FRAME_PROPERTIES( this ), "_producer", NULL );
+       return NULL;
 }
 
-int mlt_frame_mix_audio( mlt_frame this, mlt_frame that, float weight, int16_t **buffer, mlt_audio_format *format, int *frequency, int *channels, int *samples )
+/** Destroy the frame.
+ *
+ * \public \memberof mlt_frame_s
+ * \param this a frame
+ */
+
+void mlt_frame_close( mlt_frame this )
 {
-       int ret = 0;
-       int16_t *p_src, *p_dest;
-       int16_t *src, *dest;
-       static int16_t *extra_src = NULL, *extra_dest = NULL;
-       static int extra_src_samples = 0, extra_dest_samples = 0;
-       int frequency_src = 0, frequency_dest = 0;
-       int channels_src = 0, channels_dest = 0;
-       int samples_src = 0, samples_dest = 0;
-       int i, j;
-
-       mlt_frame_get_audio( this, &p_dest, format, &frequency_dest, &channels_dest, &samples_dest );
-       //fprintf( stderr, "frame dest samples %d channels %d timecode %f\n", samples_dest, channels_dest, mlt_properties_get_timecode( mlt_frame_properties( this ), "timecode" ) );
-       mlt_frame_get_audio( that, &p_src, format, &frequency_src, &channels_src, &samples_src );
-       //fprintf( stderr, "frame src  samples %d channels %d\n", samples_src, channels_src );
-       if ( channels_src > 6 )
-               channels_src = 0;
-       if ( channels_dest > 6 )
-               channels_dest = 0;
-       if ( samples_src > 4000 )
-               samples_src = 0;
-       if ( samples_dest > 4000 )
-               samples_dest = 0;
-
-#if 0
-       // Append new samples to leftovers
-       if ( extra_dest_samples > 0 )
+       if ( this != NULL && mlt_properties_dec_ref( MLT_FRAME_PROPERTIES( this ) ) <= 0 )
        {
-               fprintf( stderr, "prepending %d samples to dest\n", extra_dest_samples );
-               dest = realloc( extra_dest, ( samples_dest + extra_dest_samples ) * 2 * channels_dest );
-               memcpy( &extra_dest[ extra_dest_samples * channels_dest ], p_dest, samples_dest * 2 * channels_dest );
-       }
-       else
-               dest = p_dest;
-       if ( extra_src_samples > 0 )
-       {
-               fprintf( stderr, "prepending %d samples to src\n", extra_src_samples );
-               src = realloc( extra_src, ( samples_src + extra_src_samples ) * 2 * channels_src );
-               memcpy( &extra_src[ extra_src_samples * channels_src ], p_src, samples_src * 2 * channels_src );
-       }
-       else
-               src = p_src;
-#else
-       src = p_src;
-       dest = p_dest;
-#endif
-
-       // determine number of samples to process       
-       if ( samples_src + extra_src_samples < samples_dest + extra_dest_samples )
-               *samples = samples_src + extra_src_samples;
-       else if ( samples_dest + extra_dest_samples < samples_src + extra_src_samples )
-               *samples = samples_dest + extra_dest_samples;
-       
-       *channels = channels_src < channels_dest ? channels_src : channels_dest;
-       *buffer = p_dest;
-
-       // Mixdown
-       for ( i = 0; i < *samples; i++ )
-       {
-               for ( j = 0; j < *channels; j++ )
-               {
-                       double d = (double) dest[ i * channels_dest + j ];
-                       double s = (double) src[ i * channels_src + j ];
-                       dest[ i * channels_dest + j ] = s * weight + d * ( 1.0 - weight );
-               }
+               mlt_deque_close( this->stack_image );
+               mlt_deque_close( this->stack_audio );
+               while( mlt_deque_peek_back( this->stack_service ) )
+                       mlt_service_close( mlt_deque_pop_back( this->stack_service ) );
+               mlt_deque_close( this->stack_service );
+               mlt_properties_close( &this->parent );
+               free( this );
        }
+}
 
-       // We have to copy --sigh
-       if ( dest != p_dest )
-               memcpy( p_dest, dest, *samples * 2 * *channels );
+/***** convenience functions *****/
 
-#if 0
-       // Store the leftovers
-       if ( samples_src + extra_src_samples < samples_dest + extra_dest_samples )
-       {
-               extra_dest_samples = ( samples_dest + extra_dest_samples ) - ( samples_src + extra_src_samples );
-               size_t size = extra_dest_samples * 2 * channels_dest;
-               fprintf( stderr, "storing %d samples from dest\n", extra_dest_samples );
-               if ( extra_dest )
-                       free( extra_dest );
-               extra_dest = malloc( size );
-               if ( extra_dest )
-                       memcpy( extra_dest, &p_dest[ ( samples_dest - extra_dest_samples - 1 ) * channels_dest ], size );
-               else
-                       extra_dest_samples = 0;
-       }
-       else if ( samples_dest + extra_dest_samples < samples_src + extra_src_samples )
-       {
-               extra_src_samples = ( samples_src + extra_src_samples ) - ( samples_dest + extra_dest_samples );
-               size_t size = extra_src_samples * 2 * channels_src;
-               fprintf( stderr, "storing %d samples from src\n", extra_dest_samples );
-               if ( extra_src )
-                       free( extra_src );
-               extra_src = malloc( size );
-               if ( extra_src )
-                       memcpy( extra_src, &p_src[ ( samples_src - extra_src_samples - 1 ) * channels_src ], size );
-               else
-                       extra_src_samples = 0;
-       }
-#endif
-       
-       return ret;
-}
+/** Determine the number of samples that belong in a frame at a time position.
+ *
+ * \public \memberof mlt_frame_s
+ * \param fps the frame rate
+ * \param frequency the sample rate
+ * \param position the time position
+ * \return the number of samples per channel
+ */
 
 int mlt_sample_calculator( float fps, int frequency, int64_t position )
 {
        int samples = 0;
 
-       if ( fps > 29 && fps <= 30 )
+       if ( fps )
        {
-               samples = frequency / 30;
-
-               switch ( frequency )
-               {
-                       case 48000:
-                               if ( position % 5 != 0 )
-                                       samples += 2;
-                               break;
-                       case 44100:
-                               if ( position % 300 == 0 )
-                                       samples = 1471;
-                               else if ( position % 30 == 0 )
-                                       samples = 1470;
-                               else if ( position % 2 == 0 )
-                                       samples = 1472;
-                               else
-                                       samples = 1471;
-                               break;
-                       case 32000:
-                               if ( position % 30 == 0 )
-                                       samples = 1068;
-                               else if ( position % 29 == 0 )
-                                       samples = 1067;
-                               else if ( position % 4 == 2 )
-                                       samples = 1067;
-                               else
-                                       samples = 1068;
-                               break;
-                       default:
-                               samples = 0;
-               }
+               /* Compute the cumulative number of samples until the start of this frame and the
+               cumulative number of samples until the start of the next frame. Round each to the
+               nearest integer and take the difference to determine the number of samples in
+               this frame.
+
+               This approach should prevent rounding errors that can accumulate over a large number
+               of frames causing A/V sync problems. */
+
+               int64_t samples_at_this =
+                       (int64_t)( (double) position * (double) frequency / (double) fps +
+                       ( position < 0 ? -0.5 : 0.5 ) );
+               int64_t samples_at_next =
+                       (int64_t)( (double) (position + 1) * (double) frequency / (double) fps +
+                       ( position < 0 ? -0.5 : 0.5 ) );
+               samples = (int)( samples_at_next - samples_at_this );
        }
-       else if ( fps != 0 )
+
+       return samples;
+}
+
+/** Determine the number of samples that belong before a time position.
+ *
+ * \public \memberof mlt_frame_s
+ * \param fps the frame rate
+ * \param frequency the sample rate
+ * \param position the time position
+ * \return the number of samples per channel
+ * \bug Will this break when mlt_position is converted to double?
+ */
+
+int64_t mlt_sample_calculator_to_now( float fps, int frequency, int64_t position )
+{
+       int64_t samples = 0;
+
+       if ( fps )
        {
-               samples = frequency / fps;
+               samples = (int64_t)( (double) position * (double) frequency / (double) fps +
+                       ( position < 0 ? -0.5 : 0.5 ) );
        }
 
        return samples;
 }
-