]> git.sesse.net Git - vlc/blobdiff - src/input/input.c
Small stats improvements
[vlc] / src / input / input.c
index efc227c7a95a39b07868fd90e9351b7991a68dbb..2086f2a0b8c8ec1f3b194373f43df9e8ab16a418 100644 (file)
@@ -40,6 +40,8 @@
 #include "vlc_interface.h"
 #include "vlc_interaction.h"
 
+#include "charset.h"
+
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
@@ -57,7 +59,6 @@ static inline int ControlPopNoLock( input_thread_t *, int *, vlc_value_t * );
 static void       ControlReduce( input_thread_t * );
 static vlc_bool_t Control( input_thread_t *, int, vlc_value_t );
 
-
 static int  UpdateFromAccess( input_thread_t * );
 static int  UpdateFromDemux( input_thread_t * );
 static int  UpdateMeta( input_thread_t *, vlc_bool_t );
@@ -76,7 +77,7 @@ static void InputSourceClean( input_thread_t *, input_source_t * );
 static void SlaveDemux( input_thread_t *p_input );
 static void SlaveSeek( input_thread_t *p_input );
 
-static vlc_meta_t *InputMetaUser( input_thread_t *p_input );
+static void InputMetaUser( input_thread_t *p_input );
 
 /*****************************************************************************
  * This function creates a new input, and returns a pointer
@@ -150,6 +151,8 @@ static input_thread_t *Create( vlc_object_t *p_parent, input_item_t *p_item,
     p_input->input.b_eof = VLC_FALSE;
     p_input->input.i_cr_average = 0;
 
+    if( !p_input->input.p_item->p_meta )
+        p_input->input.p_item->p_meta = vlc_meta_New();
     stats_ReinitInputStats( p_item->p_stats );
 
     /* No slave */
@@ -332,16 +335,9 @@ int __input_Preparse( vlc_object_t *p_parent, input_item_t *p_item )
     /* Clean up master */
     InputSourceClean( p_input, &p_input->input );
 
-    /* Kill access and demux */
-    if( p_input->input.p_access ) p_input->input.p_access->b_die = VLC_TRUE;
-    if( p_input->input.p_demux ) p_input->input.p_access->b_die = VLC_TRUE;
-
     /* Unload all modules */
     if( p_input->p_es_out ) input_EsOutDelete( p_input->p_es_out );
 
-    /* Delete meta */
-    if( p_input->p_meta ) vlc_meta_Delete( p_input->p_meta );
-
     vlc_object_detach( p_input );
     vlc_object_destroy( p_input );
 
@@ -671,7 +667,7 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
     char *psz_subtitle;
     vlc_value_t val;
     double f_fps;
-    vlc_meta_t *p_meta, *p_meta_tmp;
+    vlc_meta_t *p_meta;
     int i_es_out_mode;
     int i, i_delay;
 
@@ -685,29 +681,31 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
     if( !b_quick )
     {
         /* Prepare statistics */
-        counter_t *p_counter;
-        stats_Create( p_input, "read_bytes", STATS_READ_BYTES,
-                      VLC_VAR_INTEGER, STATS_COUNTER );
-        stats_Create( p_input, "read_packets", STATS_READ_PACKETS,
-                      VLC_VAR_INTEGER, STATS_COUNTER );
-        stats_Create( p_input, "demux_read", STATS_DEMUX_READ,
-                      VLC_VAR_INTEGER, STATS_COUNTER );
-        stats_Create( p_input, "input_bitrate", STATS_INPUT_BITRATE,
-                      VLC_VAR_FLOAT, STATS_DERIVATIVE );
-        stats_Create( p_input, "demux_bitrate", STATS_DEMUX_BITRATE,
-                      VLC_VAR_FLOAT,  STATS_DERIVATIVE );
-
-        p_counter = stats_CounterGet( p_input, p_input->i_object_id,
-                                      STATS_INPUT_BITRATE );
-        if( p_counter ) p_counter->update_interval = 1000000;
-        p_counter = stats_CounterGet( p_input, p_input->i_object_id,
-                                      STATS_DEMUX_BITRATE );
-        if( p_counter ) p_counter->update_interval = 1000000;
-
-        stats_Create( p_input, "played_abuffers", STATS_PLAYED_ABUFFERS,
-                      VLC_VAR_INTEGER, STATS_COUNTER );
-        stats_Create( p_input, "lost_abuffers", STATS_LOST_ABUFFERS,
-                      VLC_VAR_INTEGER, STATS_COUNTER );
+#define INIT_COUNTER( p, type, compute ) p_input->counters.p_##p = \
+     stats_CounterCreate( p_input, VLC_VAR_##type, STATS_##compute);
+        if( p_this->p_libvlc->b_stats )
+        {
+            INIT_COUNTER( read_bytes, INTEGER, COUNTER );
+            INIT_COUNTER( read_packets, INTEGER, COUNTER );
+            INIT_COUNTER( demux_read, INTEGER, COUNTER );
+            INIT_COUNTER( input_bitrate, FLOAT, DERIVATIVE );
+            INIT_COUNTER( demux_bitrate, FLOAT, DERIVATIVE );
+            INIT_COUNTER( played_abuffers, INTEGER, COUNTER );
+            INIT_COUNTER( lost_abuffers, INTEGER, COUNTER );
+            INIT_COUNTER( displayed_pictures, INTEGER, COUNTER );
+            INIT_COUNTER( lost_pictures, INTEGER, COUNTER );
+            INIT_COUNTER( decoded_audio, INTEGER, COUNTER );
+            INIT_COUNTER( decoded_video, INTEGER, COUNTER );
+            INIT_COUNTER( decoded_sub, INTEGER, COUNTER );
+            p_input->counters.p_sout_send_bitrate = NULL;
+            p_input->counters.p_sout_sent_packets = NULL;
+            p_input->counters.p_sout_sent_bytes = NULL;
+            if( p_input->counters.p_demux_bitrate )
+                p_input->counters.p_demux_bitrate->update_interval = 1000000;
+            if( p_input->counters.p_input_bitrate )
+                p_input->counters.p_input_bitrate->update_interval = 1000000;
+        }
+        vlc_mutex_init( p_input, &p_input->counters.counters_lock );
 
         /* handle sout */
         psz = var_GetString( p_input, "sout" );
@@ -721,6 +719,15 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
                 free( psz );
                 return VLC_EGENERIC;
             }
+            if( p_input->p_libvlc->b_stats )
+            {
+                INIT_COUNTER( sout_sent_packets, INTEGER, COUNTER );
+                INIT_COUNTER (sout_sent_bytes, INTEGER, COUNTER );
+                INIT_COUNTER( sout_send_bitrate, FLOAT, DERIVATIVE );
+                if( p_input->counters.p_sout_send_bitrate )
+                     p_input->counters.p_sout_send_bitrate->update_interval =
+                             1000000;
+            }
         }
         free( psz );
     }
@@ -730,6 +737,9 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
     es_out_Control( p_input->p_es_out, ES_OUT_SET_ACTIVE, VLC_FALSE );
     es_out_Control( p_input->p_es_out, ES_OUT_SET_MODE, ES_OUT_MODE_NONE );
 
+    var_Create( p_input, "bit-rate", VLC_VAR_INTEGER );
+    var_Create( p_input, "sample-rate", VLC_VAR_INTEGER );
+
     if( InputSourceInit( p_input, &p_input->input,
                          p_input->input.p_item->psz_uri, NULL, b_quick ) )
     {
@@ -852,38 +862,8 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
         psz_subtitle = var_GetString( p_input, "sub-file" );
         if( *psz_subtitle )
         {
-            input_source_t *sub;
-            vlc_value_t count;
-            vlc_value_t list;
-
             msg_Dbg( p_input, "forced subtitle: %s", psz_subtitle );
-
-            var_Change( p_input, "spu-es", VLC_VAR_CHOICESCOUNT, &count, NULL );
-
-            /* */
-            sub = InputSourceNew( p_input );
-            if( !InputSourceInit( p_input, sub, psz_subtitle, "subtitle",
-                                  VLC_FALSE ) )
-            {
-                TAB_APPEND( p_input->i_slave, p_input->slave, sub );
-
-                /* Select the ES */
-                if( !var_Change( p_input, "spu-es", VLC_VAR_GETLIST, &list,
-                                 NULL ) )
-                {
-                    if( count.i_int == 0 )
-                        count.i_int++;
-                        /* if it was first one, there is disable too */
-
-                    if( count.i_int < list.p_list->i_count )
-                    {
-                        input_ControlPush( p_input, INPUT_CONTROL_SET_ES,
-                                          &list.p_list->p_values[count.i_int] );
-                    }
-                    var_Change( p_input, "spu-es", VLC_VAR_FREELIST, &list,
-                                NULL );
-                }
-            }
+            input_AddSubtitles( p_input, psz_subtitle, VLC_FALSE );
         }
 
         var_Get( p_input, "sub-autodetect-file", &val );
@@ -894,7 +874,19 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
                                             p_input->input.p_item->psz_uri );
             input_source_t *sub;
 
-            for( i = 0; subs && subs[i]; i++ )
+            i = 0;
+
+            /* Try to autoselect the first autodetected subtitles file
+             * if no subtitles file was specified */
+            if( *psz_subtitle == 0 && subs && subs[0] )
+            {
+                input_AddSubtitles( p_input, subs[0], VLC_FALSE );
+                free( subs[0] );
+                i = 1;
+            }
+
+            /* Then, just add the following subtitles files */
+            for( ; subs && subs[i]; i++ )
             {
                 if( strcmp( psz_subtitle, subs[i] ) )
                 {
@@ -902,7 +894,7 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
                     if( !InputSourceInit( p_input, sub, subs[i], "subtitle",
                                           VLC_FALSE ) )
                     {
-                         TAB_APPEND( p_input->i_slave, p_input->slave, sub );
+                        TAB_APPEND( p_input->i_slave, p_input->slave, sub );
                     }
                 }
                 free( subs[i] );
@@ -1018,79 +1010,32 @@ static int Init( input_thread_t * p_input, vlc_bool_t b_quick )
         }
     }
 
+    p_meta = p_input->input.p_item->p_meta;
     /* Get meta data from users */
-    p_meta_tmp = InputMetaUser( p_input );
-
+    InputMetaUser( p_input );
     /* Get meta data from master input */
-    if( demux2_Control( p_input->input.p_demux, DEMUX_GET_META, &p_meta ) )
-        p_meta = NULL;
-
-    /* Merge them */
-    if( p_meta == NULL )
-    {
-        p_meta = p_meta_tmp;
-    }
-    else if( p_meta_tmp )
-    {
-        vlc_meta_Merge( p_meta, p_meta_tmp );
-        vlc_meta_Delete( p_meta_tmp );
-    }
+    demux2_Control( p_input->input.p_demux, DEMUX_GET_META, p_meta );
 
     /* Access_file does not give any meta, and there are no slave */
     if( !b_quick )
     {
-        if( !p_input->input.p_access ||
+        if( p_input->input.p_access )
             access2_Control( p_input->input.p_access, ACCESS_GET_META,
-                             &p_meta_tmp))
-            p_meta_tmp = NULL;
-
-        if( p_meta == NULL )
-        {
-            p_meta = p_meta_tmp;
-        }
-        else if( p_meta_tmp )
-        {
-            vlc_meta_Merge( p_meta, p_meta_tmp );
-            vlc_meta_Delete( p_meta_tmp );
-        }
+                             p_meta );
 
         /* Get meta data from slave input */
         for( i = 0; i < p_input->i_slave; i++ )
         {
-            vlc_meta_t *p_meta_slave;
-
-            if( !demux2_Control( p_input->slave[i]->p_demux,
-                                 DEMUX_GET_META, &p_meta_slave ) )
-            {
-                if( p_meta == NULL )
-                {
-                    p_meta = p_meta_slave;
-                }
-                else if( p_meta_slave )
-                {
-                    vlc_meta_Merge( p_meta, p_meta_slave );
-                    vlc_meta_Delete( p_meta_slave );
-                }
-            }
-
-            if( p_input->slave[i]->p_access &&
-                !access2_Control( p_input->slave[i]->p_access,
-                                  ACCESS_GET_META, &p_meta_slave ) )
+            demux2_Control( p_input->slave[i]->p_demux,
+                            DEMUX_GET_META, p_meta );
+            if( p_input->slave[i]->p_access )
             {
-                if( p_meta == NULL )
-                {
-                    p_meta = p_meta_slave;
-                }
-                else if( p_meta_slave )
-                {
-                    vlc_meta_Merge( p_meta, p_meta_slave );
-                    vlc_meta_Delete( p_meta_slave );
-                }
+                access2_Control( p_input->slave[i]->p_access,
+                                 ACCESS_GET_META, p_meta );
             }
         }
     }
 
-    p_input->p_meta = p_meta;
     UpdateMeta( p_input, b_quick );
 
     if( !b_quick )
@@ -1173,6 +1118,21 @@ static void End( input_thread_t * p_input )
     if( p_input->p_es_out )
         input_EsOutDelete( p_input->p_es_out );
 
+#define CL_CO( c ) stats_CounterClean( p_input->counters.p_##c )
+
+        CL_CO( read_bytes );
+        CL_CO( read_packets );
+        CL_CO( demux_read );
+        CL_CO( input_bitrate );
+        CL_CO( demux_bitrate );
+        CL_CO( played_abuffers );
+        CL_CO( lost_abuffers );
+        CL_CO( displayed_pictures );
+        CL_CO( lost_pictures );
+        CL_CO( decoded_audio) ;
+        CL_CO( decoded_video );
+        CL_CO( decoded_sub) ;
+
     /* Close optional stream output instance */
     if( p_input->p_sout )
     {
@@ -1180,6 +1140,10 @@ static void End( input_thread_t * p_input )
             vlc_object_find( p_input, VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
         vlc_value_t keep;
 
+        CL_CO( sout_sent_packets );
+        CL_CO( sout_sent_bytes );
+        CL_CO( sout_send_bitrate );
+
         if( var_Get( p_input, "sout-keep", &keep ) >= 0 && keep.b_bool && p_pl )
         {
             /* attach sout to the playlist */
@@ -1196,10 +1160,7 @@ static void End( input_thread_t * p_input )
             vlc_object_release( p_pl );
     }
 
-    /* Delete meta */
-    if( p_input->p_meta )
-        vlc_meta_Delete( p_input->p_meta );
-
+#undef CL_CO
     /* Tell we're dead */
     p_input->b_dead = VLC_TRUE;
 }
@@ -1670,8 +1631,7 @@ static vlc_bool_t Control( input_thread_t *p_input, int i_type,
                 if( !InputSourceInit( p_input, slave, val.psz_string, NULL,
                                       VLC_FALSE ) )
                 {
-                    vlc_meta_t *p_meta_new = NULL;
-                    vlc_meta_t *p_meta;
+                    vlc_meta_t *p_meta = p_input->input.p_item->p_meta;
                     int64_t i_time;
 
                     /* Add the slave */
@@ -1696,38 +1656,11 @@ static vlc_bool_t Control( input_thread_t *p_input, int i_type,
                         break;
                     }
 
-
                     /* Get meta (access and demux) */
-                    if( access2_Control( slave->p_access,
-                                          ACCESS_GET_META, &p_meta_new ) )
-                        p_meta_new = NULL;
-                    if( !demux2_Control( slave->p_demux,
-                                         DEMUX_GET_META, &p_meta ) )
-                    {
-                        if( p_meta_new )
-                        {
-                            vlc_meta_Merge( p_meta_new, p_meta );
-                            vlc_meta_Delete( p_meta );
-                        }
-                        else
-                        {
-                            p_meta_new = p_meta;
-                        }
-                    }
-                    /* Update meta */
-                    if( p_meta_new )
-                    {
-                        if( p_input->p_meta )
-                        {
-                            vlc_meta_Merge( p_input->p_meta, p_meta_new );
-                            vlc_meta_Delete( p_meta_new );
-                        }
-                        else
-                        {
-                            p_input->p_meta = p_meta_new;
-                        }
-                        UpdateMeta( p_input, VLC_FALSE );
-                    }
+                    access2_Control( slave->p_access, ACCESS_GET_META,
+                                     p_meta );
+                    demux2_Control( slave->p_demux, DEMUX_GET_META, p_meta );
+                    UpdateMeta( p_input, VLC_FALSE );
 
                     TAB_APPEND( p_input->i_slave, p_input->slave, slave );
                 }
@@ -1826,28 +1759,15 @@ static int UpdateFromAccess( input_thread_t *p_input )
     {
         v.i_int = p_access->info.i_seekpoint;
         var_Change( p_input, "chapter", VLC_VAR_SETVALUE, &v, NULL);
-
         p_access->info.i_update &= ~INPUT_UPDATE_SEEKPOINT;
     }
     if( p_access->info.i_update & INPUT_UPDATE_META )
     {
         /* TODO maybe multi - access ? */
-        vlc_meta_t *p_meta;
-        if( !access2_Control( p_input->input.p_access,ACCESS_GET_META,&p_meta))
-        {
-            if( p_input->p_meta )
-            {
-                vlc_meta_Merge( p_input->p_meta, p_meta );
-                vlc_meta_Delete( p_meta );
-            }
-            else
-            {
-                p_input->p_meta = p_meta;
-            }
-
-            UpdateMeta( p_input, VLC_FALSE );
-            var_SetBool( p_input, "item-change", p_input->input.p_item->i_id );
-        }
+        vlc_meta_t *p_meta = p_input->input.p_item->p_meta;
+        access2_Control( p_input->input.p_access,ACCESS_GET_META, p_meta );
+        UpdateMeta( p_input, VLC_FALSE );
+        var_SetBool( p_input, "item-change", p_input->input.p_item->i_id );
         p_access->info.i_update &= ~INPUT_UPDATE_META;
     }
 
@@ -1885,58 +1805,14 @@ static int UpdateFromAccess( input_thread_t *p_input )
  *****************************************************************************/
 static int  UpdateMeta( input_thread_t *p_input, vlc_bool_t b_quick )
 {
-    vlc_meta_t *p_meta = p_input->p_meta;
-    int i;
-
-    if( !p_meta || p_meta->i_meta == 0 )
+    vlc_meta_t *p_meta = p_input->input.p_item->p_meta;
+    if( !p_meta )
         return VLC_SUCCESS;
 
-    if( !b_quick ) msg_Dbg( p_input, "meta information:" );
-    for( i = 0; i < p_meta->i_meta; i++ )
-    {
-        if( !b_quick )
-            msg_Dbg( p_input, "  - '%s' = '%s'",
-                     _(p_meta->name[i]), p_meta->value[i] );
-
-        if( !strcmp(p_meta->name[i], _(VLC_META_TITLE)) && p_meta->value[i] &&
-            !p_input->input.p_item->b_fixed_name )
-            input_Control( p_input, INPUT_SET_NAME, p_meta->value[i] );
+    if( p_meta->psz_title && !p_input->input.p_item->b_fixed_name )
+        input_Control( p_input, INPUT_SET_NAME, p_meta->psz_title );
 
-        if( !strcmp( p_meta->name[i], _(VLC_META_AUTHOR) ) )
-            input_Control( p_input, INPUT_ADD_INFO, _("General"),
-                           _(VLC_META_AUTHOR), p_meta->value[i] );
-
-        input_Control( p_input, INPUT_ADD_INFO, _(VLC_META_INFO_CAT),
-                      _(p_meta->name[i]), "%s", p_meta->value[i] );
-    }
-
-    for( i = 0; i < p_meta->i_track; i++ )
-    {
-        vlc_meta_t *tk = p_meta->track[i];
-        int j;
-
-        if( tk->i_meta > 0 )
-        {
-            char *psz_cat = malloc( strlen(_("Stream")) + 10 );
-
-            msg_Dbg( p_input, "  - track[%d]:", i );
-
-            sprintf( psz_cat, "%s %d", _("Stream"), i );
-            for( j = 0; j < tk->i_meta; j++ )
-            {
-                msg_Dbg( p_input, "     - '%s' = '%s'", _(tk->name[j]),
-                         tk->value[j] );
-
-                input_Control( p_input, INPUT_ADD_INFO, psz_cat,
-                               _(tk->name[j]), "%s", tk->value[j] );
-            }
-        }
-    }
-
-    if( p_input->p_sout && p_input->p_sout->p_meta == NULL )
-    {
-        p_input->p_sout->p_meta = vlc_meta_Duplicate( p_meta );
-    }
+    /** \todo handle sout meta */
 
     return VLC_SUCCESS;
 }
@@ -2063,7 +1939,7 @@ static int InputSourceInit( input_thread_t *p_input,
     else
     {
         psz_path = psz_mrl;
-        msg_Dbg( p_input, "trying to preparse %s",  psz_path );
+        msg_Dbg( p_input, "trying to pre-parse %s",  psz_path );
         psz_demux = strdup( "" );
         psz_access = strdup( "file" );
     }
@@ -2356,32 +2232,31 @@ static void SlaveSeek( input_thread_t *p_input )
 /*****************************************************************************
  * InputMetaUser:
  *****************************************************************************/
-static vlc_meta_t *InputMetaUser( input_thread_t *p_input )
+static void InputMetaUser( input_thread_t *p_input )
 {
-    vlc_meta_t *p_meta;
+    vlc_meta_t *p_meta = p_input->input.p_item->p_meta;
     vlc_value_t val;
 
-    if( ( p_meta = vlc_meta_New() ) == NULL )
-        return NULL;
+    if( !p_meta ) return;
 
     /* Get meta information from user */
-#define GET_META( c, s ) \
+#define GET_META( field, s ) \
     var_Get( p_input, (s), &val );  \
-    if( *val.psz_string )       \
-        vlc_meta_Add( p_meta, _(c), val.psz_string ); \
+    if( *val.psz_string ) { \
+        if( p_meta->psz_ ## field ) free ( p_meta->psz_ ## field ); \
+        p_meta->psz_ ## field = strdup( val.psz_string ); \
+    } \
     free( val.psz_string )
 
-    GET_META( VLC_META_TITLE, "meta-title" );
-    GET_META( VLC_META_AUTHOR, "meta-author" );
-    GET_META( VLC_META_ARTIST, "meta-artist" );
-    GET_META( VLC_META_GENRE, "meta-genre" );
-    GET_META( VLC_META_COPYRIGHT, "meta-copyright" );
-    GET_META( VLC_META_DESCRIPTION, "meta-description" );
-    GET_META( VLC_META_DATE, "meta-date" );
-    GET_META( VLC_META_URL, "meta-url" );
+    GET_META( title, "meta-title" );
+    GET_META( author, "meta-author" );
+    GET_META( artist, "meta-artist" );
+    GET_META( genre, "meta-genre" );
+    GET_META( copyright, "meta-copyright" );
+    GET_META( description, "meta-description" );
+    GET_META( date, "meta-date" );
+    GET_META( url, "meta-url" );
 #undef GET_META
-
-    return p_meta;
 }
 
 /*****************************************************************************
@@ -2444,7 +2319,7 @@ void MRLSplit( vlc_object_t *p_input, char *psz_dup,
 #if defined( WIN32 ) || defined( UNDER_CE )
     if( psz - psz_dup == 1 )
     {
-        msg_Warn( p_input, "drive letter %c: found in source", *psz_dup );
+        msg_Dbg( p_input, "drive letter %c: found in source", *psz_dup );
         psz_path = psz_dup;
     }
     else
@@ -2548,113 +2423,67 @@ static void MRLSections( input_thread_t *p_input, char *psz_source,
              *pi_title_end, *pi_chapter_end );
 }
 
-
-/***********************************************************************
- * Info management functions
- ***********************************************************************/
-/**
- * Get a info item from a given category in a given input item.
- *
- * \param p_i The input item to get info from
- * \param psz_cat String representing the category for the info
- * \param psz_name String representing the name of the desired info
- * \return A pointer to the string with the given info if found, or an
- *         empty string otherwise. The caller should free the returned
- *         pointer.
- */
-char *vlc_input_item_GetInfo( input_item_t *p_i,
-                              const char *psz_cat,
-                              const char *psz_name )
+/*****************************************************************************
+ * input_AddSubtitles: add a subtitles file and enable it
+ *****************************************************************************/
+vlc_bool_t input_AddSubtitles( input_thread_t *p_input, char *psz_subtitle,
+                               vlc_bool_t b_check_extension )
 {
-    int i,j;
-
-    vlc_mutex_lock( &p_i->lock );
+    input_source_t *sub;
+    vlc_value_t count;
+    vlc_value_t list;
+    char *psz_path, *psz_extension;
 
-    for( i = 0 ; i< p_i->i_categories  ; i++ )
+    if( b_check_extension && !subtitles_Filter( psz_subtitle ) )
     {
-        info_category_t *p_cat = p_i->pp_categories[i];
-
-        if( !psz_cat || strcmp( p_cat->psz_name, psz_cat ) )
-            continue;
+        return VLC_FALSE;
+    }
 
-        for( j = 0; j < p_cat->i_infos ; j++ )
+    /* if we are provided a subtitle.sub file,
+     * see if we don't have a subtitle.idx and use it instead */
+    psz_path = strdup( psz_subtitle );
+    if( psz_path )
+    {
+        psz_extension = strrchr( psz_path, '.');
+        if( psz_extension && strcmp( psz_extension, ".sub" ) == 0 )
         {
-            if( !strcmp( p_cat->pp_infos[j]->psz_name, psz_name ) )
+            FILE *f;
+
+            strcpy( psz_extension, ".idx" );
+            /* FIXME: a portable wrapper for stat() or access() would be more suited */
+            if( ( f = utf8_fopen( psz_path, "rt" ) ) )
             {
-                char *psz_ret = strdup( p_cat->pp_infos[j]->psz_value );
-                vlc_mutex_unlock( &p_i->lock );
-                return psz_ret;
+                fclose( f );
+                msg_Dbg( p_input, "using %s subtitles file instead of %s",
+                         psz_path, psz_subtitle );
+                strcpy( psz_subtitle, psz_path );
             }
         }
+        free( psz_path );
     }
-    vlc_mutex_unlock( &p_i->lock );
-    return strdup( "" );
-}
 
-int vlc_input_item_AddInfo( input_item_t *p_i,
-                            const char *psz_cat,
-                            const char *psz_name,
-                            const char *psz_format, ... )
-{
-    va_list args;
-    int i;
-    info_t *p_info = NULL;
-    info_category_t *p_cat = NULL ;
+    var_Change( p_input, "spu-es", VLC_VAR_CHOICESCOUNT, &count, NULL );
 
-    vlc_mutex_lock( &p_i->lock );
-
-    for( i = 0 ; i < p_i->i_categories ; i ++ )
-    {
-        if( !strcmp( p_i->pp_categories[i]->psz_name, psz_cat ) )
-        {
-            p_cat = p_i->pp_categories[i];
-            break;
-        }
-    }
-    if( !p_cat )
+    sub = InputSourceNew( p_input );
+    if( !InputSourceInit( p_input, sub, psz_subtitle, "subtitle", VLC_FALSE ) )
     {
-        if( !(p_cat = (info_category_t *)malloc( sizeof(info_category_t) )) )
-        {
-            vlc_mutex_unlock( &p_i->lock );
-            return VLC_EGENERIC;
-        }
-        p_cat->psz_name = strdup( psz_cat );
-        p_cat->i_infos = 0;
-        p_cat->pp_infos = 0;
-        INSERT_ELEM( p_i->pp_categories, p_i->i_categories, p_i->i_categories,
-                     p_cat );
-    }
+        TAB_APPEND( p_input->i_slave, p_input->slave, sub );
 
-    for( i = 0; i< p_cat->i_infos; i++ )
-    {
-        if( !strcmp( p_cat->pp_infos[i]->psz_name, psz_name ) )
+        /* Select the ES */
+        if( !var_Change( p_input, "spu-es", VLC_VAR_GETLIST, &list, NULL ) )
         {
-            p_info = p_cat->pp_infos[i];
-            break;
-        }
-    }
+            if( count.i_int == 0 )
+                count.i_int++;
+            /* if it was first one, there is disable too */
 
-    if( !p_info )
-    {
-        if( ( p_info = (info_t *)malloc( sizeof( info_t ) ) ) == NULL )
-        {
-            vlc_mutex_unlock( &p_i->lock );
-            return VLC_EGENERIC;
+            if( count.i_int < list.p_list->i_count )
+            {
+                input_ControlPush( p_input, INPUT_CONTROL_SET_ES,
+                                   &list.p_list->p_values[count.i_int] );
+            }
+            var_Change( p_input, "spu-es", VLC_VAR_FREELIST, &list, NULL );
         }
-        INSERT_ELEM( p_cat->pp_infos, p_cat->i_infos, p_cat->i_infos, p_info );
-        p_info->psz_name = strdup( psz_name );
-    }
-    else
-    {
-        if( p_info->psz_value ) free( p_info->psz_value );
     }
 
-    va_start( args, psz_format );
-    vasprintf( &p_info->psz_value, psz_format, args);
-    va_end( args );
-
-    vlc_mutex_unlock( &p_i->lock );
-
-    return VLC_SUCCESS;
+    return VLC_TRUE;
 }
-