#include <assert.h>
#include "input_internal.h"
+#include "es_out.h"
+#include "access.h"
+#include "demux.h"
+#include "stream.h"
#include <vlc_sout.h>
#include "../stream_output/stream_output.h"
static void End ( input_thread_t *p_input );
static void MainLoop( input_thread_t *p_input );
-static inline int ControlPopNoLock( input_thread_t *, int *, vlc_value_t * );
+static inline int ControlPopNoLock( input_thread_t *, int *, vlc_value_t *, mtime_t i_deadline );
static void ControlReduce( input_thread_t * );
static bool Control( input_thread_t *, int, vlc_value_t );
static void InputMetaUser( input_thread_t *p_input, vlc_meta_t *p_meta );
static void InputUpdateMeta( input_thread_t *p_input, vlc_meta_t *p_meta );
+static char *InputGetExtraFiles( input_thread_t *p_input,
+ const char *psz_access, const char *psz_path );
static void DemuxMeta( input_thread_t *p_input, vlc_meta_t *p_meta, demux_t *p_demux );
static void AccessMeta( input_thread_t * p_input, vlc_meta_t *p_meta );
static void AppendAttachment( int *pi_attachment, input_attachment_t ***ppp_attachment,
int i_new, input_attachment_t **pp_new );
+static void SubtitleAdd( input_thread_t *p_input, char *psz_subtitle, bool b_forced );
+
/*****************************************************************************
* This function creates a new input, and returns a pointer
* to its description. On error, it returns NULL.
* - intf-change
* - intf-change-vout for when a vout is created or destroyed
* - rate-change for when playback rate changes
+ * - stats-change for when statistics are updated
* TODO explain when Callback is called
* TODO complete this list (?)
*****************************************************************************/
stats_TimerStart( p_input, psz_timer_name,
STATS_TIMER_INPUT_LAUNCHING );
- MALLOC_NULL( p_input->p, input_thread_private_t );
- memset( p_input->p, 0, sizeof( input_thread_private_t ) );
+ p_input->p = calloc( 1, sizeof( input_thread_private_t ) );
+ if( !p_input->p )
+ return NULL;
/* One "randomly" selected input thread is responsible for computing
* the global stats. Check if there is already someone doing this */
/* Init control buffer */
vlc_mutex_init( &p_input->p->lock_control );
+ vlc_cond_init( &p_input->p->wait_control );
p_input->p->i_control = 0;
/* Parse input options */
input_ControlVarInit( p_input );
/* */
- p_input->p->pts_adjust.b_auto_adjust = var_GetBool( p_input, "auto-adjust-pts-delay" );
p_input->p->input.i_cr_average = var_GetInteger( p_input, "cr-average" );
if( !p_input->b_preparsing )
psz_parser = val.psz_string;
while( (psz_start = strchr( psz_parser, '{' ) ) )
{
- seekpoint_t *p_seekpoint = vlc_seekpoint_New();
+ seekpoint_t *p_seekpoint;
char backup;
psz_start++;
psz_end = strchr( psz_start, '}' );
backup = *psz_parser;
*psz_parser = 0;
*psz_end = ',';
+
+ p_seekpoint = vlc_seekpoint_New();
while( (psz_end = strchr( psz_start, ',' ) ) )
{
*psz_end = 0;
vlc_mutex_destroy( &p_input->p->counters.counters_lock );
+ vlc_cond_destroy( &p_input->p->wait_control );
vlc_mutex_destroy( &p_input->p->lock_control );
free( p_input->p );
}
/* Create thread and wait for its readiness. */
if( vlc_thread_create( p_input, "input", Run,
- VLC_THREAD_PRIORITY_INPUT, true ) )
+ VLC_THREAD_PRIORITY_INPUT, false ) )
{
input_ChangeState( p_input, ERROR_S );
msg_Err( p_input, "cannot create input thread" );
* \param p_parent a vlc_object
* \param p_item an input item
* \param b_block should we block until read is finished ?
- * \return the input object id if non blocking, an error code else
+ * \return an error code, VLC_SUCCESS on success
*/
int __input_Read( vlc_object_t *p_parent, input_item_t *p_item,
bool b_block )
else
{
if( vlc_thread_create( p_input, "input", RunAndDestroy,
- VLC_THREAD_PRIORITY_INPUT, true ) )
+ VLC_THREAD_PRIORITY_INPUT, false ) )
{
input_ChangeState( p_input, ERROR_S );
msg_Err( p_input, "cannot create input thread" );
return VLC_EGENERIC;
}
}
- return p_input->i_object_id;
+ return VLC_SUCCESS;
}
/**
sout_instance_t * input_DetachSout( input_thread_t *p_input )
{
+ assert( p_input->b_dead );
sout_instance_t *p_sout = p_input->p->p_sout;
vlc_object_detach( p_sout );
p_input->p->p_sout = NULL;
input_thread_t *p_input = (input_thread_t *)p_this;
const int canc = vlc_savecancel();
- /* Signal that the thread is launched */
- vlc_thread_ready( p_input );
-
if( Init( p_input ) )
{
/* If we failed, wait before we are killed, and exit */
WaitDie( p_input );
-
- /* Tell we're dead */
- p_input->b_dead = true;
-
- vlc_restorecancel( canc );
- return NULL;
+ goto exit;
}
MainLoop( p_input );
/* Wait until we are asked to die */
if( !p_input->b_die )
- {
WaitDie( p_input );
- }
/* Clean up */
End( p_input );
+
+exit:
+ p_input->b_dead = true;
vlc_restorecancel( canc );
return NULL;
}
input_thread_t *p_input = (input_thread_t *)p_this;
const int canc = vlc_savecancel();
- /* Signal that the thread is launched */
- vlc_thread_ready( p_input );
-
if( Init( p_input ) )
goto exit;
stats_ComputeGlobalStats( p_input->p_libvlc,
p_input->p_libvlc->p_stats );
}
+ var_SetBool( p_input, "stats-change", true );
}
/**
static void MainLoop( input_thread_t *p_input )
{
mtime_t i_start_mdate = mdate();
- int64_t i_intf_update = 0;
- int i_updates = 0;
+ mtime_t i_intf_update = 0;
+ mtime_t i_statistic_update = 0;
/* Start the timer */
stats_TimerStop( p_input, STATS_TIMER_INPUT_LAUNCHING );
bool b_force_update;
int i_type;
vlc_value_t val;
-
- /* Do the read */
- if( p_input->i_state != PAUSE_S )
+ mtime_t i_current;
+ mtime_t i_deadline;
+ mtime_t i_wakeup;
+ bool b_paused;
+
+ /* Demux data */
+ b_force_update = false;
+ i_wakeup = 0;
+ /* FIXME if p_input->i_state == PAUSE_S the access/access_demux
+ * is paused -> this may cause problem with some of them
+ * The same problem can be seen when seeking while paused */
+ input_EsOutLock( p_input->p->p_es_out );
+ b_paused = p_input->i_state == PAUSE_S &&
+ !input_EsOutIsBuffering( p_input->p->p_es_out );
+ input_EsOutUnlock( p_input->p->p_es_out );
+
+ if( !b_paused )
{
MainLoopDemux( p_input, &b_force_update, &i_start_mdate );
- }
- else
- {
- /* Small wait */
- b_force_update = false;
- msleep( 10*1000 );
- }
- /* Handle control */
- vlc_mutex_lock( &p_input->p->lock_control );
- ControlReduce( p_input );
- while( !ControlPopNoLock( p_input, &i_type, &val ) )
- {
- msg_Dbg( p_input, "control type=%d", i_type );
- if( Control( p_input, i_type, val ) )
- b_force_update = true;
+ i_wakeup = es_out_GetWakeup( p_input->p->p_es_out );
}
- vlc_mutex_unlock( &p_input->p->lock_control );
- if( b_force_update || i_intf_update < mdate() )
- {
- MainLoopInterface( p_input );
- i_intf_update = mdate() + INT64_C(150000);
- }
+ /* */
+ do {
+ i_deadline = i_wakeup;
+ if( b_paused )
+ i_deadline = __MIN( i_intf_update, i_statistic_update );
+
+ /* Handle control */
+ vlc_mutex_lock( &p_input->p->lock_control );
+ ControlReduce( p_input );
+ while( !ControlPopNoLock( p_input, &i_type, &val, i_deadline ) )
+ {
+ msg_Dbg( p_input, "control type=%d", i_type );
+
+ if( Control( p_input, i_type, val ) )
+ b_force_update = true;
+ }
+ vlc_mutex_unlock( &p_input->p->lock_control );
+
+ /* Update interface and statistics */
+ i_current = mdate();
+ if( i_intf_update < i_current || b_force_update )
+ {
+ MainLoopInterface( p_input );
+ i_intf_update = i_current + INT64_C(250000);
+ b_force_update = false;
+ }
+ if( i_statistic_update < i_current )
+ {
+ MainLoopStatistic( p_input );
+ i_statistic_update = i_current + INT64_C(1000000);
+ }
- /* 150ms * 8 = ~ 1 second */
- if( ++i_updates % 8 == 0 )
- MainLoopStatistic( p_input );
+ /* Check if i_wakeup is still valid */
+ if( i_wakeup != 0 )
+ {
+ mtime_t i_new_wakeup = es_out_GetWakeup( p_input->p->p_es_out );
+ if( !i_new_wakeup )
+ i_wakeup = 0;
+ }
+ } while( i_current < i_wakeup );
}
if( !p_input->b_eof && !p_input->b_error && p_input->p->input.b_eof )
{
/* We have finish to demux data but not to play them */
- while( !p_input->b_die )
+ while( vlc_object_alive( p_input ) )
{
- if( input_EsOutDecodersEmpty( p_input->p->p_es_out ) )
+ input_EsOutLock( p_input->p->p_es_out );
+ bool b_empty = input_EsOutDecodersIsEmpty( p_input->p->p_es_out );
+ input_EsOutUnlock( p_input->p->p_es_out );
+
+ if( b_empty )
break;
msg_Dbg( p_input, "waiting decoder fifos to empty" );
/* If the desynchronisation requested by the user is < 0, we need to
* cache more data. */
var_Get( p_input, "audio-desync", &val );
- if( val.i_int < 0 ) p_input->i_pts_delay -= (val.i_int * 1000);
+ if( val.i_int < 0 )
+ p_input->i_pts_delay -= (val.i_int * 1000);
/* Update cr_average depending on the caching */
p_input->p->input.i_cr_average *= (10 * p_input->i_pts_delay / 200000);
{
double f_fps;
vlc_value_t val;
- int i, i_delay;
+ int i_delay;
char *psz;
char *psz_subtitle;
int64_t i_length;
if( psz_subtitle != NULL )
{
msg_Dbg( p_input, "forced subtitle: %s", psz_subtitle );
- input_AddSubtitles( p_input, psz_subtitle, false );
+ SubtitleAdd( p_input, psz_subtitle, true );
}
var_Get( p_input, "sub-autodetect-file", &val );
if( val.b_bool )
{
char *psz_autopath = var_GetNonEmptyString( p_input, "sub-autodetect-path" );
- char **subs = subtitles_Detect( p_input, psz_autopath,
- p_input->p->input.p_item->psz_uri );
- input_source_t *sub;
- i = 0;
- if( psz_autopath == NULL )
- psz_autopath = strdup("");
+ char **ppsz_subs = subtitles_Detect( p_input, psz_autopath,
+ p_input->p->input.p_item->psz_uri );
+ free( psz_autopath );
- /* Try to autoselect the first autodetected subtitles file
- * if no subtitles file was specified */
- if( ( psz_subtitle == NULL ) && subs && subs[0] )
+ for( int i = 0; ppsz_subs && ppsz_subs[i]; i++ )
{
- input_AddSubtitles( p_input, subs[0], false );
- free( subs[0] );
- i = 1;
- }
+ /* Try to autoselect the first autodetected subtitles file
+ * if no subtitles file was specified */
+ bool b_forced = i == 0 && !psz_subtitle;
- /* Then, just add the following subtitles files */
- for( ; subs && subs[i]; i++ )
- {
- if( !psz_subtitle || strcmp( psz_subtitle, subs[i] ) )
- {
- sub = InputSourceNew( p_input );
- if( !InputSourceInit( p_input, sub, subs[i], "subtitle" ) )
- {
- TAB_APPEND( p_input->p->i_slave, p_input->p->slave, sub );
- }
- else free( sub );
- }
- free( subs[i] );
+ if( !psz_subtitle || strcmp( psz_subtitle, ppsz_subs[i] ) )
+ SubtitleAdd( p_input, ppsz_subs[i], b_forced );
+
+ free( ppsz_subs[i] );
}
- free( subs );
- free( psz_autopath );
+ free( ppsz_subs );
}
free( psz_subtitle );
input_ChangeState( p_input, ERROR_S );
if( p_input->p->p_es_out )
- input_EsOutDelete( p_input->p->p_es_out );
+ es_out_Delete( p_input->p->p_es_out );
#ifdef ENABLE_SOUT
if( p_input->p->p_sout )
{
static void WaitDie( input_thread_t *p_input )
{
input_ChangeState( p_input, p_input->b_error ? ERROR_S : END_S );
- while( !p_input->b_die )
- {
- /* Sleep a while */
- msleep( INPUT_IDLE_SLEEP );
- }
+
+ /* Wait a die order */
+ vlc_object_lock( p_input );
+ while( vlc_object_alive( p_input ) )
+ vlc_object_wait( p_input );
+ vlc_object_unlock( p_input );
}
/*****************************************************************************
/* Unload all modules */
if( p_input->p->p_es_out )
- input_EsOutDelete( p_input->p->p_es_out );
+ es_out_Delete( p_input->p->p_es_out );
if( !p_input->b_preparsing )
{
* Control
*****************************************************************************/
static inline int ControlPopNoLock( input_thread_t *p_input,
- int *pi_type, vlc_value_t *p_val )
+ int *pi_type, vlc_value_t *p_val,
+ mtime_t i_deadline )
{
- if( p_input->p->i_control <= 0 )
+
+ while( p_input->p->i_control <= 0 )
{
- return VLC_EGENERIC;
+ if( !vlc_object_alive( p_input ) )
+ return VLC_EGENERIC;
+
+ if( i_deadline < 0 )
+ return VLC_EGENERIC;
+
+ if( vlc_cond_timedwait( &p_input->p->wait_control, &p_input->p->lock_control, i_deadline ) )
+ return VLC_EGENERIC;
}
*pi_type = p_input->p->control[0].i_type;
}
}
}
+/* Pause input */
+static void ControlPause( input_thread_t *p_input, mtime_t i_control_date )
+{
+ int i_ret;
+ int i_state;
+ if( p_input->p->input.p_access )
+ i_ret = access_Control( p_input->p->input.p_access,
+ ACCESS_SET_PAUSE_STATE, true );
+ else
+ i_ret = demux_Control( p_input->p->input.p_demux,
+ DEMUX_SET_PAUSE_STATE, true );
+
+ i_state = PAUSE_S;
+ if( i_ret )
+ {
+ msg_Warn( p_input, "cannot set pause state" );
+ i_state = p_input->i_state;
+ }
+
+ /* Switch to new state */
+ input_ChangeStateWithVarCallback( p_input, i_state, false );
+
+ /* */
+ if( !i_ret )
+ input_EsOutChangePause( p_input->p->p_es_out, true, i_control_date );
+}
+static void ControlUnpause( input_thread_t *p_input, mtime_t i_control_date )
+{
+ int i_ret;
+ if( p_input->p->input.p_access )
+ i_ret = access_Control( p_input->p->input.p_access,
+ ACCESS_SET_PAUSE_STATE, false );
+ else
+ i_ret = demux_Control( p_input->p->input.p_demux,
+ DEMUX_SET_PAUSE_STATE, false );
+
+ if( i_ret )
+ {
+ /* FIXME What to do ? */
+ msg_Warn( p_input, "cannot unset pause -> EOF" );
+ vlc_mutex_unlock( &p_input->p->lock_control );
+ input_ControlPush( p_input, INPUT_CONTROL_SET_DIE, NULL );
+ vlc_mutex_lock( &p_input->p->lock_control );
+ }
+
+ /* Switch to play */
+ input_ChangeStateWithVarCallback( p_input, PLAYING_S, false );
+
+ /* */
+ if( !i_ret )
+ input_EsOutChangePause( p_input->p->p_es_out, false, i_control_date );
+}
static bool Control( input_thread_t *p_input, int i_type,
vlc_value_t val )
{
+ const mtime_t i_control_date = mdate();
bool b_force_update = false;
- if( !p_input ) return b_force_update;
+ if( !p_input )
+ return b_force_update;
+
+ input_EsOutLock( p_input->p->p_es_out );
switch( i_type )
{
if( ( val.i_int == PLAYING_S && p_input->i_state == PAUSE_S ) ||
( val.i_int == PAUSE_S && p_input->i_state == PAUSE_S ) )
{
- int i_ret;
- if( p_input->p->input.p_access )
- i_ret = access_Control( p_input->p->input.p_access,
- ACCESS_SET_PAUSE_STATE, false );
- else
- i_ret = demux_Control( p_input->p->input.p_demux,
- DEMUX_SET_PAUSE_STATE, false );
-
- if( i_ret )
- {
- /* FIXME What to do ? */
- msg_Warn( p_input, "cannot unset pause -> EOF" );
- vlc_mutex_unlock( &p_input->p->lock_control );
- input_ControlPush( p_input, INPUT_CONTROL_SET_DIE, NULL );
- vlc_mutex_lock( &p_input->p->lock_control );
- }
+ ControlUnpause( p_input, i_control_date );
b_force_update = true;
-
- /* Switch to play */
- input_ChangeStateWithVarCallback( p_input, PLAYING_S, false );
-
- /* */
- if( !i_ret )
- input_EsOutChangeState( p_input->p->p_es_out );
}
else if( val.i_int == PAUSE_S && p_input->i_state == PLAYING_S &&
p_input->p->b_can_pause )
{
- int i_ret, state;
- if( p_input->p->input.p_access )
- i_ret = access_Control( p_input->p->input.p_access,
- ACCESS_SET_PAUSE_STATE, true );
- else
- i_ret = demux_Control( p_input->p->input.p_demux,
- DEMUX_SET_PAUSE_STATE, true );
+ ControlPause( p_input, i_control_date );
b_force_update = true;
-
- if( i_ret )
- {
- msg_Warn( p_input, "cannot set pause state" );
- state = p_input->i_state;
- }
- else
- {
- state = PAUSE_S;
- }
-
- /* Switch to new state */
- input_ChangeStateWithVarCallback( p_input, state, false );
-
- /* */
- if( !i_ret )
- input_EsOutChangeState( p_input->p->p_es_out );
}
else if( val.i_int == PAUSE_S && !p_input->p->b_can_pause )
{
}
break;
+ case INPUT_CONTROL_ADD_SUBTITLE:
+ if( val.psz_string )
+ {
+ SubtitleAdd( p_input, val.psz_string, true );
+ free( val.psz_string );
+ }
+ break;
+
case INPUT_CONTROL_ADD_SLAVE:
if( val.psz_string )
{
break;
}
if( demux_Control( slave->p_demux,
- DEMUX_SET_TIME, i_time ) )
+ DEMUX_SET_TIME, i_time ) )
{
msg_Err( p_input, "seek failed for new slave" );
InputSourceClean( slave );
}
break;
+ case INPUT_CONTROL_SET_FRAME_NEXT:
+ if( !p_input->p->b_can_pause )
+ break;
+
+ if( p_input->i_state == PAUSE_S )
+ {
+ input_EsOutFrameNext( p_input->p->p_es_out );
+ }
+ else if( p_input->i_state == PLAYING_S )
+ {
+ ControlPause( p_input, i_control_date );
+ }
+ else
+ {
+ msg_Err( p_input, "invalid state for frame next" );
+ }
+ b_force_update = true;
+ break;
+
case INPUT_CONTROL_SET_BOOKMARK:
default:
msg_Err( p_input, "not yet implemented" );
break;
}
+ input_EsOutUnlock( p_input->p->p_es_out );
+
return b_force_update;
}
InputUpdateMeta( p_input, p_meta );
p_access->info.i_update &= ~INPUT_UPDATE_META;
}
+ if( p_access->info.i_update & INPUT_UPDATE_SIGNAL )
+ {
+ double f_quality;
+ double f_strength;
+
+ if( access_Control( p_access, ACCESS_GET_SIGNAL, &f_quality, &f_strength ) )
+ f_quality = f_strength = -1;
+
+ var_SetFloat( p_input, "signal-quality", f_quality );
+ var_SetFloat( p_input, "signal-strength", f_strength );
+
+ p_access->info.i_update &= ~INPUT_UPDATE_SIGNAL;
+ }
p_access->info.i_update &= ~INPUT_UPDATE_SIZE;
}
}
- /* Try access_demux if no demux given */
- if( *psz_demux == '\0' )
- {
- in->p_demux = demux_New( p_input, psz_access, psz_demux, psz_path,
- NULL, p_input->p->p_es_out, false );
- }
+ /* Try access_demux first */
+ in->p_demux = demux_New( p_input, psz_access, psz_demux, psz_path,
+ NULL, p_input->p->p_es_out, false );
}
else
{
if( b_master )
input_ChangeState( p_input, BUFFERING_S );
+ /* Autodetect extra files if none specified */
+ char *psz_input_list = var_CreateGetNonEmptyString( p_input, "input-list" );
+ if( !psz_input_list )
+ {
+ char *psz_extra_files = InputGetExtraFiles( p_input, psz_access, psz_path );
+ if( psz_extra_files )
+ var_SetString( p_input, "input-list", psz_extra_files );
+ free( psz_extra_files );
+ }
+
/* Create the stream_t */
in->p_stream = stream_AccessNew( in->p_access, p_input->b_preparsing );
+
+ /* Restor old value */
+ if( !psz_input_list )
+ var_SetString( p_input, "input-list", "" );
+ free( psz_input_list );
+
if( in->p_stream == NULL )
{
msg_Warn( p_input, "cannot create a stream_t from access" );
{
int64_t i_time;
int i;
+ bool b_set_time = true;
if( demux_Control( p_input->p->input.p_demux, DEMUX_GET_TIME, &i_time ) )
{
- msg_Err( p_input, "demux doesn't like DEMUX_GET_TIME" );
- return;
+ /* msg_Err( p_input, "demux doesn't like DEMUX_GET_TIME" ); */
+ b_set_time = false;
}
for( i = 0; i < p_input->p->i_slave; i++ )
if( in->b_eof )
continue;
- if( demux_Control( in->p_demux, DEMUX_SET_NEXT_DEMUX_TIME, i_time ) )
+ if( b_set_time && demux_Control( in->p_demux, DEMUX_SET_NEXT_DEMUX_TIME, i_time ) )
{
for( ;; )
{
if( demux_Control( in->p_demux, DEMUX_SET_TIME, i_time ) )
{
- msg_Err( p_input, "seek failed for slave %d -> EOF", i );
+ if( !in->b_eof )
+ msg_Err( p_input, "seek failed for slave %d -> EOF", i );
in->b_eof = true;
}
+ else
+ {
+ in->b_eof = false;
+ }
}
}
#undef GET_META
}
+/*****************************************************************************
+ * InputGetExtraFiles
+ * Autodetect extra input list
+ *****************************************************************************/
+static char *InputGetExtraFiles( input_thread_t *p_input,
+ const char *psz_access, const char *psz_path )
+{
+ char *psz_list = NULL;
+
+ if( ( psz_access && *psz_access && strcmp( psz_access, "file" ) ) || !psz_path )
+ return NULL;
+
+
+ const char *psz_ext = strrchr( psz_path, '.' );
+ if( !psz_ext || strcmp( psz_ext, ".001" ) )
+ return NULL;
+
+ char *psz_file = strdup( psz_path );
+ if( !psz_file )
+ return NULL;
+
+ /* Try to list .xyz files */
+ for( int i = 2; i < 999; i++ )
+ {
+ char *psz_ext = strrchr( psz_file, '.' );
+ struct stat st;
+
+ snprintf( psz_ext, 5, ".%.3d", i );
+
+ if( utf8_stat( psz_file, &st )
+ || !S_ISREG( st.st_mode ) || !st.st_size )
+ continue;
+
+ msg_Dbg( p_input, "Detected extra file `%s'", psz_file );
+
+ if( psz_list )
+ {
+ char *psz_old = psz_list;
+ /* FIXME how to handle file with ',' ?*/
+ if( asprintf( &psz_list, "%s,%s", psz_old, psz_file ) < 0 )
+ {
+ psz_list = psz_old;
+ break;
+ }
+ }
+ else
+ {
+ psz_list = strdup( psz_file );
+ }
+ }
+ free( psz_file );
+
+ return psz_list;
+}
+
/*****************************************************************************
* InputUpdateMeta: merge p_item meta data with p_meta taking care of
* arturl and locking issue.
if(! p_demux->p_private )
return;
- p_id3 = module_Need( p_demux, "meta reader", NULL, 0 );
+ p_id3 = module_need( p_demux, "meta reader", NULL, 0 );
if( p_id3 )
{
demux_meta_t *p_demux_meta = (demux_meta_t *)p_demux->p_private;
p_demux_meta->i_attachments, p_demux_meta->attachments );
vlc_mutex_unlock( &p_input->p->input.p_item->lock );
}
- module_Unneed( p_demux, p_id3 );
+ module_unneed( p_demux, p_id3 );
}
free( p_demux->p_private );
}
/*****************************************************************************
* input_AddSubtitles: add a subtitles file and enable it
*****************************************************************************/
-bool input_AddSubtitles( input_thread_t *p_input, char *psz_subtitle,
- bool b_check_extension )
+static void SubtitleAdd( input_thread_t *p_input, char *psz_subtitle, bool b_forced )
{
input_source_t *sub;
vlc_value_t count;
vlc_value_t list;
char *psz_path, *psz_extension;
- if( b_check_extension && !subtitles_Filter( psz_subtitle ) )
- {
- return false;
- }
-
/* if we are provided a subtitle.sub file,
* see if we don't have a subtitle.idx and use it instead */
psz_path = strdup( psz_subtitle );
psz_extension = strrchr( psz_path, '.');
if( psz_extension && strcmp( psz_extension, ".sub" ) == 0 )
{
- FILE *f;
+ struct stat st;
strcpy( psz_extension, ".idx" );
- /* FIXME: a portable wrapper for stat() or access() would be more suited */
- if( ( f = utf8_fopen( psz_path, "rt" ) ) )
+
+ if( !utf8_stat( psz_path, &st ) && S_ISREG( st.st_mode ) )
{
- fclose( f );
msg_Dbg( p_input, "using %s subtitles file instead of %s",
psz_path, psz_subtitle );
strcpy( psz_subtitle, psz_path );
var_Change( p_input, "spu-es", VLC_VAR_CHOICESCOUNT, &count, NULL );
sub = InputSourceNew( p_input );
- if( !InputSourceInit( p_input, sub, psz_subtitle, "subtitle" ) )
+ if( InputSourceInit( p_input, sub, psz_subtitle, "subtitle" ) )
+ {
+ free( sub );
+ return;
+ }
+ TAB_APPEND( p_input->p->i_slave, p_input->p->slave, sub );
+
+ /* Select the ES */
+ if( b_forced && !var_Change( p_input, "spu-es", VLC_VAR_GETLIST, &list, NULL ) )
{
- TAB_APPEND( p_input->p->i_slave, p_input->p->slave, sub );
+ if( count.i_int == 0 )
+ count.i_int++;
+ /* if it was first one, there is disable too */
- /* Select the ES */
- if( !var_Change( p_input, "spu-es", VLC_VAR_GETLIST, &list, NULL ) )
+ if( count.i_int < list.p_list->i_count )
{
- if( count.i_int == 0 )
- count.i_int++;
- /* if it was first one, there is disable too */
+ int i_id = list.p_list->p_values[count.i_int].i_int;
- if( count.i_int < list.p_list->i_count )
- {
- input_ControlPush( p_input, INPUT_CONTROL_SET_ES,
- &list.p_list->p_values[count.i_int] );
- }
- var_Change( p_input, "spu-es", VLC_VAR_FREELIST, &list, NULL );
+ input_EsOutLock( p_input->p->p_es_out );
+ es_out_id_t *p_es = input_EsOutGetFromID( p_input->p->p_es_out, i_id );
+
+ es_out_Control( p_input->p->p_es_out, ES_OUT_SET_ES_DEFAULT, p_es );
+ es_out_Control( p_input->p->p_es_out, ES_OUT_SET_ES, p_es );
+ input_EsOutUnlock( p_input->p->p_es_out );
}
+ var_Change( p_input, "spu-es", VLC_VAR_FREELIST, &list, NULL );
}
- else free( sub );
+}
+
+bool input_AddSubtitles( input_thread_t *p_input, char *psz_subtitle,
+ bool b_check_extension )
+{
+ vlc_value_t val;
+
+ if( b_check_extension && !subtitles_Filter( psz_subtitle ) )
+ return false;
+
+ assert( psz_subtitle != NULL );
+ val.psz_string = strdup( psz_subtitle );
+ if( val.psz_string )
+ input_ControlPush( p_input, INPUT_CONTROL_ADD_SUBTITLE, &val );
return true;
}