]> git.sesse.net Git - vlc/blobdiff - src/input/input_programs.c
* ALL: changed the prototype of input_AddES() to include enough information so we...
[vlc] / src / input / input_programs.c
index 7e3bb8d398064594ba6f8ba148ffe0cabea9508b..3fac781c794972092019fbf23a6bcc3c8adfa739 100644 (file)
@@ -1,8 +1,8 @@
 /*****************************************************************************
  * input_programs.c: es_descriptor_t, pgrm_descriptor_t management
  *****************************************************************************
- * Copyright (C) 1999, 2000 VideoLAN
- * $Id: input_programs.c,v 1.42 2001/04/01 07:31:38 stef Exp $
+ * Copyright (C) 1999-2002 VideoLAN
+ * $Id: input_programs.c,v 1.106 2003/05/05 22:23:42 gbazin Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -10,7 +10,7 @@
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
-#include "defs.h"
-
 #include <stdlib.h>
+#include <string.h>                                    /* memcpy(), memset() */
 
-#include "config.h"
-#include "common.h"
-#include "threads.h"
-#include "mtime.h"
-#include "debug.h"
-
-#include "intf_msg.h"
+#include <vlc/vlc.h>
 
 #include "stream_control.h"
 #include "input_ext-intf.h"
 #include "input_ext-dec.h"
-#include "input.h"
-
-#include "main.h"                                     /* --noaudio --novideo */
+#include "input_ext-plugins.h"
 
 /*
  * NOTICE : all of these functions expect you to have taken the lock on
  * p_input->stream.lock
  */
 
+/* Navigation callbacks */
+static int ProgramCallback( vlc_object_t *, char const *,
+                            vlc_value_t, vlc_value_t, void * );
+static int TitleCallback( vlc_object_t *, char const *,
+                          vlc_value_t, vlc_value_t, void * );
+static int ChapterCallback( vlc_object_t *, char const *,
+                            vlc_value_t, vlc_value_t, void * );
+static int NavigationCallback( vlc_object_t *, char const *,
+                               vlc_value_t, vlc_value_t, void * );
+static int ESCallback( vlc_object_t *, char const *,
+                       vlc_value_t, vlc_value_t, void * );
+
 /*****************************************************************************
  * input_InitStream: init the stream descriptor of the given input
  *****************************************************************************/
 int input_InitStream( input_thread_t * p_input, size_t i_data_len )
 {
+    vlc_value_t text;
+
     p_input->stream.i_stream_id = 0;
+
+    /* initialized to 0 since we don't give the signal to the interface
+     * before the end of input initialization */
+    p_input->stream.b_changed = 0;
     p_input->stream.pp_es = NULL;
     p_input->stream.pp_selected_es = NULL;
+    p_input->stream.p_removed_es = NULL;
+    p_input->stream.p_newly_selected_es = NULL;
     p_input->stream.pp_programs = NULL;
+    p_input->stream.p_selected_program = NULL;
+    p_input->stream.p_new_program = NULL;
 
     if( i_data_len )
     {
         if ( (p_input->stream.p_demux_data = malloc( i_data_len )) == NULL )
         {
-            intf_ErrMsg( "Unable to allocate memory in input_InitStream");
+            msg_Err( p_input, "out of memory" );
             return 1;
         }
         memset( p_input->stream.p_demux_data, 0, i_data_len );
     }
+    else
+    {
+        p_input->stream.p_demux_data = NULL;
+    }
+
+    /* Create a few object variables used for navigation in the interfaces */
+    var_Create( p_input, "program", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Program");
+    var_Change( p_input, "program", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "title", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Title");
+    var_Change( p_input, "title", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "chapter", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Chapter");
+    var_Change( p_input, "chapter", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "navigation", VLC_VAR_VARIABLE | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Navigation");
+    var_Change( p_input, "navigation", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "video-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Video track");
+    var_Change( p_input, "video-es", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "audio-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Audio track");
+    var_Change( p_input, "audio-es", VLC_VAR_SETTEXT, &text, NULL );
+    var_Create( p_input, "spu-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE );
+    text.psz_string = _("Subtitle track");
+    var_Change( p_input, "spu-es", VLC_VAR_SETTEXT, &text, NULL );
+
+    var_AddCallback( p_input, "program", ProgramCallback, NULL );
+    var_AddCallback( p_input, "title", TitleCallback, NULL );
+    var_AddCallback( p_input, "chapter", ChapterCallback, NULL );
+    var_AddCallback( p_input, "video-es", ESCallback, NULL );
+    var_AddCallback( p_input, "audio-es", ESCallback, NULL );
+    var_AddCallback( p_input, "spu-es", ESCallback, NULL );
 
     return 0;
 }
@@ -88,18 +135,39 @@ void input_EndStream( input_thread_t * p_input )
         input_DelES( p_input, p_input->stream.pp_es[0] );
     }
 
+    /* Free all areas */
+    while( p_input->stream.i_area_nb )
+    {
+        input_DelArea( p_input, p_input->stream.pp_areas[0] );
+    }
+
+    /* Free selected ES */
+    if( p_input->stream.pp_selected_es != NULL )
+    {
+        free( p_input->stream.pp_selected_es );
+    }
+
     if( p_input->stream.p_demux_data != NULL )
     {
         free( p_input->stream.p_demux_data );
     }
+
+    /* Free navigation variables */
+    var_Destroy( p_input, "program" );
+    var_Destroy( p_input, "title" );
+    var_Destroy( p_input, "chapter" );
+    var_Destroy( p_input, "video-es" );
+    var_Destroy( p_input, "audio-es" );
+    var_Destroy( p_input, "spu-es" );
 }
 
 /*****************************************************************************
  * input_FindProgram: returns a pointer to a program described by its ID
  *****************************************************************************/
-pgrm_descriptor_t * input_FindProgram( input_thread_t * p_input, u16 i_pgrm_id )
+pgrm_descriptor_t * input_FindProgram( input_thread_t * p_input,
+                                       uint16_t i_pgrm_id )
 {
-    int     i;
+    unsigned int i;
 
     for( i = 0; i < p_input->stream.i_pgrm_number; i++ )
     {
@@ -109,7 +177,7 @@ pgrm_descriptor_t * input_FindProgram( input_thread_t * p_input, u16 i_pgrm_id )
         }
     }
 
-    return( NULL );
+    return NULL;
 }
 
 /*****************************************************************************
@@ -121,62 +189,52 @@ pgrm_descriptor_t * input_AddProgram( input_thread_t * p_input,
                                       u16 i_pgrm_id, size_t i_data_len )
 {
     /* Where to add the pgrm */
-    int i_pgrm_index = p_input->stream.i_pgrm_number;
-
-    intf_DbgMsg("Adding description for pgrm %d", i_pgrm_id);
+    pgrm_descriptor_t * p_pgrm = malloc( sizeof(pgrm_descriptor_t) );
+    vlc_value_t val;
 
-    /* Add an entry to the list of program associated with the stream */
-    p_input->stream.i_pgrm_number++;
-    p_input->stream.pp_programs = realloc( p_input->stream.pp_programs,
-                                           p_input->stream.i_pgrm_number
-                                            * sizeof(pgrm_descriptor_t *) );
-    if( p_input->stream.pp_programs == NULL )
-    {
-        intf_ErrMsg( "Unable to realloc memory in input_AddProgram" );
-        return( NULL );
-    }
-    
-    /* Allocate the structure to store this description */
-    p_input->stream.pp_programs[i_pgrm_index] =
-                                        malloc( sizeof(pgrm_descriptor_t) );
-    if( p_input->stream.pp_programs[i_pgrm_index] == NULL )
+    if( p_pgrm == NULL )
     {
-        intf_ErrMsg( "Unable to allocate memory in input_AddProgram" );
-        return( NULL );
+        msg_Err( p_input, "out of memory" );
+        return NULL;
     }
-    
-    /* Init this entry */
-    p_input->stream.pp_programs[i_pgrm_index]->i_number = i_pgrm_id;
-    p_input->stream.pp_programs[i_pgrm_index]->b_is_ok = 0;
-    p_input->stream.pp_programs[i_pgrm_index]->i_version = 0;
 
-    p_input->stream.pp_programs[i_pgrm_index]->i_es_number = 0;
-    p_input->stream.pp_programs[i_pgrm_index]->pp_es = NULL;
+    /* Init this entry */
+    p_pgrm->i_number = i_pgrm_id;
+    p_pgrm->b_is_ok = 0;
+    p_pgrm->i_version = 0;
 
-    input_ClockInit( p_input->stream.pp_programs[i_pgrm_index] );
+    p_pgrm->i_es_number = 0;
+    p_pgrm->pp_es = NULL;
 
-    p_input->stream.pp_programs[i_pgrm_index]->i_synchro_state
-                                                = SYNCHRO_START;
+    input_ClockInit( p_pgrm );
 
-    p_input->stream.pp_programs[i_pgrm_index]->p_vout
-                                            = p_input->p_default_vout;
-    p_input->stream.pp_programs[i_pgrm_index]->p_aout
-                                            = p_input->p_default_aout;
+    p_pgrm->i_synchro_state = SYNCHRO_START;
 
     if( i_data_len )
     {
-        p_input->stream.pp_programs[i_pgrm_index]->p_demux_data =
-            malloc( i_data_len );
-        if( p_input->stream.pp_programs[i_pgrm_index]->p_demux_data == NULL )
+        p_pgrm->p_demux_data = malloc( i_data_len );
+        if( p_pgrm->p_demux_data == NULL )
         {
-            intf_ErrMsg( "Unable to allocate memory in input_AddProgram" );
-            return( NULL );
+            msg_Err( p_input, "out of memory" );
+            return NULL;
         }
-        memset( p_input->stream.pp_programs[i_pgrm_index]->p_demux_data, 0,
-                i_data_len );
+        memset( p_pgrm->p_demux_data, 0, i_data_len );
+    }
+    else
+    {
+        p_pgrm->p_demux_data = NULL;
     }
 
-    return p_input->stream.pp_programs[i_pgrm_index];
+    /* Add an entry to the list of program associated with the stream */
+    INSERT_ELEM( p_input->stream.pp_programs,
+                 p_input->stream.i_pgrm_number,
+                 p_input->stream.i_pgrm_number,
+                 p_pgrm );
+
+    val.i_int = i_pgrm_id;
+    var_Change( p_input, "program", VLC_VAR_ADDCHOICE, &val, NULL );
+
+    return p_pgrm;
 }
 
 /*****************************************************************************
@@ -186,11 +244,26 @@ pgrm_descriptor_t * input_AddProgram( input_thread_t * p_input,
  *****************************************************************************/
 void input_DelProgram( input_thread_t * p_input, pgrm_descriptor_t * p_pgrm )
 {
-    int i_pgrm_index;
+    unsigned int i_pgrm_index;
+    vlc_value_t val;
+
+    /* Find the program in the programs table */
+    for( i_pgrm_index = 0; i_pgrm_index < p_input->stream.i_pgrm_number;
+         i_pgrm_index++ )
+    {
+        if( p_input->stream.pp_programs[i_pgrm_index] == p_pgrm )
+            break;
+    }
 
-    ASSERT( p_pgrm );
+    /* If the program wasn't found, do nothing */
+    if( i_pgrm_index == p_input->stream.i_pgrm_number )
+    {
+        msg_Err( p_input, "program does not belong to this input" );
+        return;
+    }
 
-    intf_DbgMsg("Deleting description for pgrm %d", p_pgrm->i_number);
+    val.i_int = i_pgrm_index;
+    var_Change( p_input, "program", VLC_VAR_DELCHOICE, &val, NULL );
 
     /* Free the structures that describe the es that belongs to that program */
     while( p_pgrm->i_es_number )
@@ -204,28 +277,10 @@ void input_DelProgram( input_thread_t * p_input, pgrm_descriptor_t * p_pgrm )
         free( p_pgrm->p_demux_data );
     }
 
-    /* Find the program in the programs table */
-    for( i_pgrm_index = 0; i_pgrm_index < p_input->stream.i_pgrm_number;
-         i_pgrm_index++ )
-    {
-        if( p_input->stream.pp_programs[i_pgrm_index] == p_pgrm )
-            break;
-    }
-
     /* Remove this program from the stream's list of programs */
-    p_input->stream.i_pgrm_number--;
-
-    p_input->stream.pp_programs[i_pgrm_index] =
-        p_input->stream.pp_programs[p_input->stream.i_pgrm_number];
-    p_input->stream.pp_programs = realloc( p_input->stream.pp_programs,
-                                           p_input->stream.i_pgrm_number
-                                            * sizeof(pgrm_descriptor_t *) );
-
-    if( p_input->stream.i_pgrm_number && p_input->stream.pp_programs == NULL)
-    {
-        intf_ErrMsg( "input error: unable to realloc program list"
-                     " in input_DelProgram" );
-    }
+    REMOVE_ELEM( p_input->stream.pp_programs,
+                 p_input->stream.i_pgrm_number,
+                 i_pgrm_index );
 
     /* Free the description of this program */
     free( p_pgrm );
@@ -236,43 +291,169 @@ void input_DelProgram( input_thread_t * p_input, pgrm_descriptor_t * p_pgrm )
  *****************************************************************************
  * This area descriptor will be referenced in the given stream descriptor
  *****************************************************************************/
-input_area_t * input_AddArea( input_thread_t * p_input )
+input_area_t * input_AddArea( input_thread_t * p_input,
+                              uint16_t i_area_id, uint16_t i_part_nb )
 {
     /* Where to add the pgrm */
-    int i_area_index = p_input->stream.i_area_nb;
+    input_area_t * p_area = malloc( sizeof(input_area_t) );
+    vlc_value_t val;
+    int i;
 
-    intf_DbgMsg("Adding description for area %d", i_area_index );
+    if( p_area == NULL )
+    {
+        msg_Err( p_input, "out of memory" );
+        return NULL;
+    }
+
+    /* Init this entry */
+    p_area->i_id = i_area_id;
+    p_area->i_part_nb = i_part_nb;
+    p_area->i_part= 0;
+    p_area->i_start = 0;
+    p_area->i_size = 0;
+    p_area->i_tell = 0;
+    p_area->i_seek = NO_SEEK;
 
     /* Add an entry to the list of program associated with the stream */
-    p_input->stream.i_area_nb++;
-    p_input->stream.pp_areas = realloc( p_input->stream.pp_areas,
-                                        p_input->stream.i_area_nb
-                                            * sizeof(input_area_t *) );
-    if( p_input->stream.pp_areas == NULL )
+    INSERT_ELEM( p_input->stream.pp_areas,
+                 p_input->stream.i_area_nb,
+                 p_input->stream.i_area_nb,
+                 p_area );
+
+    /* Don't add empty areas */
+    if( i_part_nb == 0 )
+        return NULL;
+
+    /* Take care of the navigation variables */
+    val.i_int = i_area_id;
+    var_Change( p_input, "title", VLC_VAR_ADDCHOICE, &val, NULL );
+
+    val.psz_string = malloc( sizeof("title ") + 5 );
+    if( val.psz_string )
     {
-        intf_ErrMsg( "Unable to realloc memory in input_AddArea" );
-        return( NULL );
+        vlc_value_t val2;
+
+        sprintf( val.psz_string, "title %2i", i_area_id );
+       var_Destroy( p_input, val.psz_string );
+       var_Create( p_input, val.psz_string, VLC_VAR_INTEGER |
+                   VLC_VAR_HASCHOICE | VLC_VAR_ISCOMMAND );
+       var_AddCallback( p_input, val.psz_string, NavigationCallback,
+                        (void *)(int)i_area_id );
+
+       var_Change( p_input, "navigation", VLC_VAR_ADDCHOICE, &val, NULL );
+
+       for( i = 1; i <= i_part_nb; i++ )
+       {
+           val2.i_int = i;
+           var_Change( p_input, val.psz_string,
+                        VLC_VAR_ADDCHOICE, &val2, NULL );
+       }
     }
-    
-    /* Allocate the structure to store this description */
-    p_input->stream.pp_areas[i_area_index] =
-                                        malloc( sizeof(input_area_t) );
-    if( p_input->stream.pp_areas[i_area_index] == NULL )
+
+    return p_area;
+}
+
+/*****************************************************************************
+ * input_SetProgram: changes the current program
+ *****************************************************************************/
+int input_SetProgram( input_thread_t * p_input, pgrm_descriptor_t * p_new_prg )
+{
+    unsigned int i_es_index;
+    int i_required_audio_es;
+    int i_required_spu_es;
+    int i_audio_es = 0;
+    int i_spu_es = 0;
+    vlc_value_t val;
+
+    if ( p_input->stream.p_selected_program )
+    {
+        for ( i_es_index = 1 ; /* 0 should be the PMT */
+                i_es_index < p_input->stream.p_selected_program->
+                i_es_number ;
+                i_es_index ++ )
+        {
+#define p_es p_input->stream.p_selected_program->pp_es[i_es_index]
+            if ( p_es->p_decoder_fifo ) /* if the ES was selected */
+            {
+                input_UnselectES( p_input , p_es );
+            }
+#undef p_es
+        }
+    }
+    /* Get the number of the required audio stream */
+    if( config_GetInt( p_input, "audio" ) )
     {
-        intf_ErrMsg( "Unable to allocate memory in input_AddArea" );
-        return( NULL );
+        /* Default is the first one */
+        i_required_audio_es = config_GetInt( p_input, "audio-channel" );
+        if( i_required_audio_es < 0 )
+        {
+            i_required_audio_es = 1;
+        }
     }
-    
-    /* Init this entry */
-    p_input->stream.pp_areas[i_area_index]->i_id = 0;
-    p_input->stream.pp_areas[i_area_index]->i_start = 0;
-    p_input->stream.pp_areas[i_area_index]->i_size = 0;
-    p_input->stream.pp_areas[i_area_index]->i_tell = 0;
-    p_input->stream.pp_areas[i_area_index]->i_seek = NO_SEEK;
-    p_input->stream.pp_areas[i_area_index]->i_part_nb = 1;
-    p_input->stream.pp_areas[i_area_index]->i_part= 0;
-
-    return p_input->stream.pp_areas[i_area_index];
+    else
+    {
+        i_required_audio_es = 0;
+    }
+
+    /* Same thing for subtitles */
+    if( config_GetInt( p_input, "video" ) )
+    {
+        /* for spu, default is none */
+        i_required_spu_es = config_GetInt( p_input, "spu-channel" );
+        if( i_required_spu_es < 0 )
+        {
+            i_required_spu_es = 0;
+        }
+    }
+    else
+    {
+        i_required_spu_es = 0;
+    }
+
+    for( i_es_index = 0 ; i_es_index < p_new_prg->i_es_number ; i_es_index ++ )
+    {
+        switch( p_new_prg->pp_es[i_es_index]->i_cat )
+        {
+            case VIDEO_ES:
+                msg_Dbg( p_input, "selecting ES %x",
+                         p_new_prg->pp_es[i_es_index]->i_id );
+                input_SelectES( p_input, p_new_prg->pp_es[i_es_index] );
+                break;
+            case AUDIO_ES:
+                i_audio_es += 1;
+                if( i_audio_es <= i_required_audio_es )
+                {
+                    msg_Dbg( p_input, "selecting ES %x",
+                             p_new_prg->pp_es[i_es_index]->i_id );
+                    input_SelectES( p_input, p_new_prg->pp_es[i_es_index]);
+                }
+                break;
+            /* Not sure this one is fully specification-compliant */
+            case SPU_ES :
+                i_spu_es += 1;
+                if( i_spu_es <= i_required_spu_es )
+                {
+                    msg_Dbg( p_input, "selecting ES %x",
+                             p_new_prg->pp_es[i_es_index]->i_id );
+                    input_SelectES( p_input, p_new_prg->pp_es[i_es_index] );
+                }
+            break;
+            default :
+                msg_Dbg( p_input, "ES %x has unknown type",
+                         p_new_prg->pp_es[i_es_index]->i_id );
+                break;
+        }
+
+    }
+
+
+    p_input->stream.p_selected_program = p_new_prg;
+
+    /* Update the navigation variables without triggering a callback */
+    val.i_int = p_new_prg->i_number;
+    var_Change( p_input, "program", VLC_VAR_SETVALUE, &val, NULL );
+
+    return( 0 );
 }
 
 /*****************************************************************************
@@ -282,11 +463,8 @@ input_area_t * input_AddArea( input_thread_t * p_input )
  *****************************************************************************/
 void input_DelArea( input_thread_t * p_input, input_area_t * p_area )
 {
-    int i_area_index;
-
-    ASSERT( p_area );
-
-    intf_DbgMsg("Deleting description for area %d", p_area->i_id );
+    unsigned int i_area_index;
+    vlc_value_t val;
 
     /* Find the area in the areas table */
     for( i_area_index = 0; i_area_index < p_input->stream.i_area_nb;
@@ -296,21 +474,27 @@ void input_DelArea( input_thread_t * p_input, input_area_t * p_area )
             break;
     }
 
-    /* Remove this area from the stream's list of areas */
-    p_input->stream.i_area_nb--;
-
-    p_input->stream.pp_areas[i_area_index] =
-        p_input->stream.pp_areas[p_input->stream.i_area_nb];
-    p_input->stream.pp_areas = realloc( p_input->stream.pp_areas,
-                                           p_input->stream.i_area_nb
-                                            * sizeof(input_area_t *) );
+    /* If the area wasn't found, do nothing */
+    if( i_area_index == p_input->stream.i_area_nb )
+    {
+        msg_Err( p_input, "area does not belong to this input" );
+        return;
+    }
 
-    if( p_input->stream.i_area_nb && p_input->stream.pp_areas == NULL)
+    /* Take care of the navigation variables */
+    val.psz_string = malloc( sizeof("title ") + 5 );
+    if( val.psz_string )
     {
-        intf_ErrMsg( "input error: unable to realloc area list"
-                     " in input_DelArea" );
+        sprintf( val.psz_string, "title %i", p_area->i_id );
+       var_Change( p_input, "navigation", VLC_VAR_DELCHOICE, &val, NULL );
+       var_Destroy( p_input, val.psz_string );
     }
 
+    /* Remove this area from the stream's list of areas */
+    REMOVE_ELEM( p_input->stream.pp_areas,
+                 p_input->stream.i_area_nb,
+                 i_area_index );
+
     /* Free the description of this area */
     free( p_area );
 }
@@ -319,9 +503,9 @@ void input_DelArea( input_thread_t * p_input, input_area_t * p_area )
 /*****************************************************************************
  * input_FindES: returns a pointer to an ES described by its ID
  *****************************************************************************/
-es_descriptor_t * input_FindES( input_thread_t * p_input, u16 i_es_id )
+es_descriptor_t * input_FindES( input_thread_t * p_input, uint16_t i_es_id )
 {
-    int     i;
+    unsigned int i;
 
     for( i = 0; i < p_input->stream.i_es_number; i++ )
     {
@@ -331,7 +515,7 @@ es_descriptor_t * input_FindES( input_thread_t * p_input, u16 i_es_id )
         }
     }
 
-    return( NULL );
+    return NULL;
 }
 
 /*****************************************************************************
@@ -343,43 +527,42 @@ es_descriptor_t * input_FindES( input_thread_t * p_input, u16 i_es_id )
  *****************************************************************************/
 es_descriptor_t * input_AddES( input_thread_t * p_input,
                                pgrm_descriptor_t * p_pgrm, u16 i_es_id,
+                               int i_category, char const *psz_desc,
                                size_t i_data_len )
 {
     es_descriptor_t * p_es;
-
-    intf_DbgMsg("Adding description for ES 0x%x", i_es_id);
+    vlc_value_t val, text;
+    char *psz_var = NULL;
 
     p_es = (es_descriptor_t *)malloc( sizeof(es_descriptor_t) );
     if( p_es == NULL )
     {
-        intf_ErrMsg( "Unable to allocate memory in input_AddES" );
+        msg_Err( p_input, "out of memory" );
         return( NULL);
     }
-    p_input->stream.i_es_number++;
-    p_input->stream.pp_es = realloc( p_input->stream.pp_es,
-                                     p_input->stream.i_es_number
-                                      * sizeof(es_descriptor_t *) );
-    if( p_input->stream.pp_es == NULL )
-    {
-        intf_ErrMsg( "Unable to realloc memory in input_AddES" );
-        return( NULL );
-    }
-    p_input->stream.pp_es[p_input->stream.i_es_number - 1] = p_es;
+
+    INSERT_ELEM( p_input->stream.pp_es,
+                 p_input->stream.i_es_number,
+                 p_input->stream.i_es_number,
+                 p_es );
 
     /* Init its values */
     p_es->i_id = i_es_id;
-    p_es->psz_desc[0] = '\0';
+    p_es->psz_desc = psz_desc ? strdup( psz_desc ) : NULL;
     p_es->p_pes = NULL;
     p_es->p_decoder_fifo = NULL;
-    p_es->b_audio = 0;
-    p_es->b_spu = 0;
+    p_es->i_cat = i_category;
+    p_es->i_demux_fd = 0;
+    p_es->c_packets = 0;
+    p_es->c_invalid_packets = 0;
+    p_es->b_force_decoder = VLC_FALSE;
 
     if( i_data_len )
     {
         p_es->p_demux_data = malloc( i_data_len );
         if( p_es->p_demux_data == NULL )
         {
-            intf_ErrMsg( "Unable to allocate memory in input_AddES" );
+            msg_Err( p_input, "out of memory" );
             return( NULL );
         }
         memset( p_es->p_demux_data, 0, i_data_len );
@@ -388,20 +571,16 @@ es_descriptor_t * input_AddES( input_thread_t * p_input,
     {
         p_es->p_demux_data = NULL;
     }
+    p_es->p_waveformatex     = NULL;
+    p_es->p_bitmapinfoheader = NULL;
 
     /* Add this ES to the program definition if one is given */
     if( p_pgrm )
     {
-        p_pgrm->i_es_number++;
-        p_pgrm->pp_es = realloc( p_pgrm->pp_es,
-                                 p_pgrm->i_es_number
-                                  * sizeof(es_descriptor_t *) );
-        if( p_pgrm->pp_es == NULL )
-        {
-            intf_ErrMsg( "Unable to realloc memory in input_AddES" );
-            return( NULL );
-        }
-        p_pgrm->pp_es[p_pgrm->i_es_number - 1] = p_es;
+        INSERT_ELEM( p_pgrm->pp_es,
+                     p_pgrm->i_es_number,
+                     p_pgrm->i_es_number,
+                     p_es );
         p_es->p_pgrm = p_pgrm;
     }
     else
@@ -409,6 +588,26 @@ es_descriptor_t * input_AddES( input_thread_t * p_input,
         p_es->p_pgrm = NULL;
     }
 
+    switch( i_category )
+    {
+    case AUDIO_ES:
+        psz_var = "audio-es";
+        break;
+    case SPU_ES:
+        psz_var = "spu-es";
+        break;
+    case VIDEO_ES:
+        psz_var = "video-es";
+        break;
+    }
+
+    if( psz_var )
+    {
+        val.i_int = p_es->i_id;
+        text.psz_string = (char *)psz_desc;
+        var_Change( p_input, psz_var, VLC_VAR_ADDCHOICE, &val, &text );
+    }
+
     return p_es;
 }
 
@@ -417,11 +616,42 @@ es_descriptor_t * input_AddES( input_thread_t * p_input,
  *****************************************************************************/
 void input_DelES( input_thread_t * p_input, es_descriptor_t * p_es )
 {
-    int                     i_index, i_es_index;
+    unsigned int            i_index, i_es_index;
     pgrm_descriptor_t *     p_pgrm;
+    char *                  psz_var;
+    vlc_value_t             val;
 
-    ASSERT( p_es );
-    p_pgrm = p_es->p_pgrm;
+    /* Find the ES in the ES table */
+    for( i_es_index = 0; i_es_index < p_input->stream.i_es_number;
+         i_es_index++ )
+    {
+        if( p_input->stream.pp_es[i_es_index] == p_es )
+            break;
+    }
+
+    /* If the ES wasn't found, do nothing */
+    if( i_es_index == p_input->stream.i_es_number )
+    {
+        msg_Err( p_input, "ES does not belong to this input" );
+        return;
+    }
+
+    /* Remove es from its associated variable */
+    switch( p_es->i_cat )
+    {
+    case AUDIO_ES:
+        psz_var = "audio-es";
+       break;
+    case SPU_ES:
+        psz_var = "spu-es";
+       break;
+    case VIDEO_ES:
+    default:
+        psz_var = "video-es";
+       break;
+    }
+    val.i_int = p_es->i_id;
+    var_Change( p_input, psz_var, VLC_VAR_DELCHOICE, &val, NULL );
 
     /* Kill associated decoder, if any. */
     if( p_es->p_decoder_fifo != NULL )
@@ -429,23 +659,18 @@ void input_DelES( input_thread_t * p_input, es_descriptor_t * p_es )
         input_EndDecoder( p_input, p_es );
     }
 
-    /* Remove this ES from the description of the program if it is associated to
-     * one */
+    /* Remove this ES from the description of the program if it is associated
+     * to one */
+    p_pgrm = p_es->p_pgrm;
     if( p_pgrm )
     {
         for( i_index = 0; i_index < p_pgrm->i_es_number; i_index++ )
         {
             if( p_pgrm->pp_es[i_index] == p_es )
             {
-                p_pgrm->i_es_number--;
-                p_pgrm->pp_es[i_index] = p_pgrm->pp_es[p_pgrm->i_es_number];
-                p_pgrm->pp_es = realloc( p_pgrm->pp_es,
-                                         p_pgrm->i_es_number
-                                          * sizeof(es_descriptor_t *));
-                if( p_pgrm->i_es_number && p_pgrm->pp_es == NULL )
-                {
-                    intf_ErrMsg( "Unable to realloc memory in input_DelES" );
-                }
+                REMOVE_ELEM( p_pgrm->pp_es,
+                             p_pgrm->i_es_number,
+                             i_index );
                 break;
             }
         }
@@ -456,6 +681,20 @@ void input_DelES( input_thread_t * p_input, es_descriptor_t * p_es )
     {
         free( p_es->p_demux_data );
     }
+    if( p_es->p_waveformatex )
+    {
+        free( p_es->p_waveformatex );
+    }
+    if( p_es->p_bitmapinfoheader )
+    {
+        free( p_es->p_bitmapinfoheader );
+    }
+
+    /* Free the description string */
+    if( p_es->psz_desc != NULL )
+    {
+        free( p_es->psz_desc );
+    }
 
     /* Find the ES in the ES table */
     for( i_es_index = 0; i_es_index < p_input->stream.i_es_number;
@@ -465,275 +704,248 @@ void input_DelES( input_thread_t * p_input, es_descriptor_t * p_es )
             break;
     }
 
+    /* Remove this ES from the stream's list of ES */
+    REMOVE_ELEM( p_input->stream.pp_es,
+                 p_input->stream.i_es_number,
+                 i_es_index );
+
     /* Free the ES */
     free( p_es );
-    p_input->stream.i_es_number--;
-    p_input->stream.pp_es[i_es_index] =
-                    p_input->stream.pp_es[p_input->stream.i_es_number];
-    p_input->stream.pp_es = realloc( p_input->stream.pp_es,
-                                     p_input->stream.i_es_number
-                                      * sizeof(es_descriptor_t *));
-    if( p_input->stream.i_es_number && p_input->stream.pp_es == NULL )
-    {
-        intf_ErrMsg( "Unable to realloc memory in input_DelES" );
-    }
-    
 }
 
 /*****************************************************************************
- * InitDecConfig: initializes a decoder_config_t
+ * input_SelectES: selects an ES and spawns the associated decoder
+ *****************************************************************************
+ * Remember we are still supposed to have stream_lock when entering this
+ * function ?
  *****************************************************************************/
-static int InitDecConfig( input_thread_t * p_input, es_descriptor_t * p_es,
-                          decoder_config_t * p_config )
+int input_SelectES( input_thread_t * p_input, es_descriptor_t * p_es )
 {
-    p_config->i_id = p_es->i_id;
-    p_config->i_type = p_es->i_type;
-    p_config->p_stream_ctrl =
-        &p_input->stream.control;
+    vlc_value_t val;
 
-    /* Decoder FIFO */
-    if( (p_config->p_decoder_fifo =
-            (decoder_fifo_t *)malloc( sizeof(decoder_fifo_t) )) == NULL )
+    if( p_es == NULL )
     {
-        intf_ErrMsg( "Out of memory" );
-        return( -1 );
+        msg_Err( p_input, "nothing to do in input_SelectES" );
+        return -1;
     }
 
-    vlc_mutex_init(&p_config->p_decoder_fifo->data_lock);
-    vlc_cond_init(&p_config->p_decoder_fifo->data_wait);
-    p_config->p_decoder_fifo->i_start = p_config->p_decoder_fifo->i_end = 0;
-    p_config->p_decoder_fifo->b_die = p_config->p_decoder_fifo->b_error = 0;
-    p_config->p_decoder_fifo->p_packets_mgt = p_input->p_method_data;
-    p_config->p_decoder_fifo->pf_delete_pes = p_input->pf_delete_pes;
-    p_es->p_decoder_fifo = p_config->p_decoder_fifo;
-
-    p_config->pf_init_bit_stream = InitBitstream;
-
-    p_input->stream.i_selected_es_number++;
-
-    p_input->stream.pp_selected_es = realloc(
-                                       p_input->stream.pp_selected_es,
-                                       p_input->stream.i_selected_es_number
-                                        * sizeof(es_descriptor_t *) );
-    if( p_input->stream.pp_selected_es == NULL )
+    if( ((p_es->i_cat == VIDEO_ES) || (p_es->i_cat == SPU_ES))
+        && !config_GetInt( p_input, "video" ) )
     {
-        intf_ErrMsg( "Unable to realloc memory in input_SelectES" );
-        return(-1);
+        msg_Dbg( p_input,
+                 "video is disabled, not selecting ES 0x%x", p_es->i_id );
+        return -1;
     }
-    p_input->stream.pp_selected_es[p_input->stream.i_selected_es_number - 1]
-            = p_es;
 
-    return( 0 );
-}
-
-/*****************************************************************************
- * GetVdecConfig: returns a valid vdec_config_t
- *****************************************************************************/
-static vdec_config_t * GetVdecConfig( input_thread_t * p_input,
-                                      es_descriptor_t * p_es )
-{
-    vdec_config_t *     p_config;
-
-    p_config = (vdec_config_t *)malloc( sizeof(vdec_config_t) );
-    if( p_config == NULL )
-    {
-        intf_ErrMsg( "Unable to allocate memory in GetVdecConfig" );
-        return( NULL );
-    }
-    p_config->p_vout = p_input->p_default_vout;
-    if( InitDecConfig( p_input, p_es, &p_config->decoder_config ) == -1 )
+    if( (p_es->i_cat == AUDIO_ES) && !config_GetInt( p_input, "audio" ) )
     {
-        free( p_config );
-        return( NULL );
+        msg_Dbg( p_input,
+                 "audio is disabled, not selecting ES 0x%x", p_es->i_id );
+        return -1;
     }
 
-    return( p_config );
-}
-
-/*****************************************************************************
- * GetAdecConfig: returns a valid adec_config_t
- *****************************************************************************/
-static adec_config_t * GetAdecConfig( input_thread_t * p_input,
-                                      es_descriptor_t * p_es )
-{
-    adec_config_t *     p_config;
+    msg_Dbg( p_input, "selecting ES 0x%x", p_es->i_id );
 
-    p_config = (adec_config_t *)malloc( sizeof(adec_config_t));
-    if( p_config == NULL )
+    if( p_es->p_decoder_fifo != NULL )
     {
-        intf_ErrMsg( "Unable to allocate memory in GetAdecConfig" );
-        return( NULL );
+        msg_Err( p_input, "ES 0x%x is already selected", p_es->i_id );
+        return -1;
     }
-    p_config->p_aout = p_input->p_default_aout;
-    if( InitDecConfig( p_input, p_es, &p_config->decoder_config ) == -1 )
+
+    /* Release the lock, not to block the input thread during
+     * the creation of the thread. */
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
+    p_es->p_decoder_fifo = input_RunDecoder( p_input, p_es );
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+
+    if( p_es->p_decoder_fifo == NULL )
     {
-        free( p_config );
-        return( NULL );
+        return -1;
     }
 
-    return( p_config );
+    /* Update the es variable without triggering a callback */
+    val.i_int = p_es->i_id;
+    var_Change( p_input, "audio-es", VLC_VAR_SETVALUE, &val, NULL );
+
+    return 0;
 }
 
 /*****************************************************************************
- * input_SelectES: selects an ES and spawns the associated decoder
- *****************************************************************************
- * Remember we are still supposed to have stream_lock when entering this
- * function ?
+ * input_UnselectES: removes an ES from the list of selected ES
  *****************************************************************************/
-/* FIXME */
-vlc_thread_t adec_CreateThread( void * );
-vlc_thread_t ac3dec_CreateThread( void * );
-vlc_thread_t vpar_CreateThread( void * );
-vlc_thread_t spudec_CreateThread( void * );
-
-int input_SelectES( input_thread_t * p_input, es_descriptor_t * p_es )
+int input_UnselectES( input_thread_t * p_input, es_descriptor_t * p_es )
 {
-    /* FIXME ! */
-    decoder_capabilities_t  decoder;
-    void *                  p_config;
+
+    unsigned int i_index = 0;
 
     if( p_es == NULL )
     {
-        intf_ErrMsg( "Nothing to do in input_SelectES" );
+        msg_Err( p_input, "nothing to do in input_UnselectES" );
         return -1;
     }
 
-#ifdef DEBUG_INPUT
-    intf_DbgMsg( "Selecting ES 0x%x", p_es->i_id );
-#endif
+    msg_Dbg( p_input, "unselecting ES 0x%x", p_es->i_id );
 
-    if( p_es->p_decoder_fifo != NULL )
+    if( p_es->p_decoder_fifo == NULL )
     {
-        intf_ErrMsg( "ES 0x%x is already selected", p_es->i_id );
+        msg_Err( p_input, "ES 0x%x is not selected", p_es->i_id );
         return( -1 );
     }
 
-    switch( p_es->i_type )
+    input_EndDecoder( p_input, p_es );
+    p_es->p_pes = NULL;
+
+    if( ( p_es->p_decoder_fifo == NULL ) &&
+        ( p_input->stream.i_selected_es_number > 0 ) )
     {
-    case MPEG1_AUDIO_ES:
-    case MPEG2_AUDIO_ES:
-        if( p_main->b_audio )
+        while( ( i_index < p_input->stream.i_selected_es_number - 1 ) &&
+               ( p_input->stream.pp_selected_es[i_index] != p_es ) )
         {
-            decoder.pf_create_thread = adec_CreateThread;
-            p_config = (void *)GetAdecConfig( p_input, p_es );
-
-            /* Release the lock, not to block the input thread during
-             * the creation of the thread. */
-            vlc_mutex_unlock( &p_input->stream.stream_lock );
-            p_es->thread_id = input_RunDecoder( &decoder, p_config );
-            vlc_mutex_lock( &p_input->stream.stream_lock );
+            i_index++;
         }
-        break;
 
-    case MPEG1_VIDEO_ES:
-    case MPEG2_VIDEO_ES:
-        if( p_main->b_video )
-        {
-            decoder.pf_create_thread = vpar_CreateThread;
-            p_config = (void *)GetVdecConfig( p_input, p_es );
-
-            /* Release the lock, not to block the input thread during
-             * the creation of the thread. */
-            vlc_mutex_unlock( &p_input->stream.stream_lock );
-            p_es->thread_id = input_RunDecoder( &decoder, p_config );
-            vlc_mutex_lock( &p_input->stream.stream_lock );
-        }
-        break;
+        /* XXX: no need to memmove, we have unsorted data */
+        REMOVE_ELEM( p_input->stream.pp_selected_es,
+                     p_input->stream.i_selected_es_number,
+                     i_index );
 
-    case AC3_AUDIO_ES:
-        if( p_main->b_audio )
+        if( p_input->stream.i_selected_es_number == 0 )
         {
-            decoder.pf_create_thread = ac3dec_CreateThread;
-            p_config = (void *)GetAdecConfig( p_input, p_es );
-
-            /* Release the lock, not to block the input thread during
-             * the creation of the thread. */
-            vlc_mutex_unlock( &p_input->stream.stream_lock );
-            p_es->thread_id = input_RunDecoder( &decoder, p_config );
-            vlc_mutex_lock( &p_input->stream.stream_lock );
+            msg_Dbg( p_input, "no more selected ES" );
+            return 1;
         }
-        break;
+    }
 
-    case DVD_SPU_ES:
-        if( p_main->b_video )
-        {
-            decoder.pf_create_thread = spudec_CreateThread;
-            p_config = (void *)GetVdecConfig( p_input, p_es );
-
-            /* Release the lock, not to block the input thread during
-             * the creation of the thread. */
-            vlc_mutex_unlock( &p_input->stream.stream_lock );
-            p_es->thread_id = input_RunDecoder( &decoder, p_config );
-            vlc_mutex_lock( &p_input->stream.stream_lock );
-        }
-        break;
+    return 0;
+}
 
-    default:
-        intf_ErrMsg( "Unknown stream type 0x%x", p_es->i_type );
-        return( -1 );
-        break;
-    }
+/*****************************************************************************
+ * Navigation callback: a bunch of navigation variables are used as an
+ *  alternative to the navigation API.
+ *****************************************************************************/
+static int ProgramCallback( vlc_object_t *p_this, char const *psz_cmd,
+                  vlc_value_t oldval, vlc_value_t newval, void *p_data )
+{
+    input_thread_t *p_input = (input_thread_t *)p_this;
 
-    if( p_es->thread_id == 0 )
+    if( oldval.i_int == newval.i_int )
+       return VLC_SUCCESS;
+
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+    if( ( newval.i_int > 0 ) )
     {
-        return( -1 );
+        vlc_mutex_unlock( &p_input->stream.stream_lock );
+        input_ChangeProgram( p_input, (uint16_t)newval.i_int );
+        input_SetStatus( p_input, INPUT_STATUS_PLAY );
+        vlc_mutex_lock( &p_input->stream.stream_lock );
     }
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
 
-    return( 0 );
+    return VLC_SUCCESS;
 }
 
-/*****************************************************************************
- * input_UnselectES: removes an ES from the list of selected ES
- *****************************************************************************/
-int input_UnselectES( input_thread_t * p_input, es_descriptor_t * p_es )
+static int TitleCallback( vlc_object_t *p_this, char const *psz_cmd,
+                  vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
+    input_thread_t *p_input = (input_thread_t *)p_this;
+    input_area_t *p_area;
 
-    int     i_index = 0;
+    if( oldval.i_int == newval.i_int )
+       return VLC_SUCCESS;
 
-    if( p_es == NULL )
+    /* Sanity check should have already be done by var_Set(). */
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+    p_area = p_input->stream.pp_areas[newval.i_int];
+    p_area->i_part = 1;
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
+    input_ChangeArea( p_input, p_area );
+    input_SetStatus( p_input, INPUT_STATUS_PLAY );
+
+    return VLC_SUCCESS;
+}
+
+static int ChapterCallback( vlc_object_t *p_this, char const *psz_cmd,
+                  vlc_value_t oldval, vlc_value_t newval, void *p_data )
+{
+    input_thread_t *p_input = (input_thread_t *)p_this;
+    input_area_t *p_area;
+
+    if( oldval.i_int == newval.i_int )
+       return VLC_SUCCESS;
+
+    /* Sanity check will have already be done by var_Set(). */
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+    p_area = p_input->stream.p_selected_area;
+    p_input->stream.p_selected_area->i_part = newval.i_int;
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
+
+    input_ChangeArea( p_input, p_area );
+    input_SetStatus( p_input, INPUT_STATUS_PLAY );
+
+    return VLC_SUCCESS;
+}
+
+static int NavigationCallback( vlc_object_t *p_this, char const *psz_cmd,
+                  vlc_value_t oldval, vlc_value_t newval, void *p_data )
+{
+    input_thread_t *p_input = (input_thread_t *)p_this;
+    uint16_t i_area_id = (int)p_data;
+
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+
+    if( p_input->stream.p_selected_area->i_id == i_area_id &&
+        oldval.i_int == newval.i_int )
     {
-        intf_ErrMsg( "Nothing to do in input_UnselectES" );
-        return -1;
+        /* Nothing to do */
+        vlc_mutex_unlock( &p_input->stream.stream_lock );
+        return VLC_SUCCESS;
     }
 
-#ifdef DEBUG_INPUT
-    intf_DbgMsg( "Unselecting ES 0x%x", p_es->i_id );
-#endif
-
-    if( p_es->p_decoder_fifo == NULL )
+    if( ( i_area_id < p_input->stream.i_area_nb ) && ( newval.i_int > 0 ) &&
+        ( (uint16_t)newval.i_int <=
+          p_input->stream.pp_areas[i_area_id]->i_part_nb ) )
     {
-        intf_ErrMsg( "ES 0x%x is not selected", p_es->i_id );
-        return( -1 );
+        input_area_t *p_area = p_input->stream.pp_areas[i_area_id];
+        p_input->stream.p_selected_area->i_part = newval.i_int;
+        vlc_mutex_unlock( &p_input->stream.stream_lock );
+        input_ChangeArea( p_input, p_area );
+        input_SetStatus( p_input, INPUT_STATUS_PLAY );
+        vlc_mutex_lock( &p_input->stream.stream_lock );
     }
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
 
-    input_EndDecoder( p_input, p_es );
+    return VLC_SUCCESS;
+}
 
-    if( ( p_es->p_decoder_fifo == NULL ) &&
-        ( p_input->stream.i_selected_es_number > 0 ) )
-    {
-        p_input->stream.i_selected_es_number--;
+static int ESCallback( vlc_object_t *p_this, char const *psz_cmd,
+                       vlc_value_t oldval, vlc_value_t newval, void *p_data )
+{
+    input_thread_t *p_input = (input_thread_t *)p_this;
+    unsigned int i;
 
-        while( ( i_index < p_input->stream.i_selected_es_number ) &&
-               ( p_input->stream.pp_selected_es[i_index] != p_es ) )
+    vlc_mutex_lock( &p_input->stream.stream_lock );
+
+    /* Unselect old ES */
+    for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
+    {
+        if( p_input->stream.pp_es[i]->i_id == oldval.i_int &&
+            p_input->stream.pp_es[i]->p_decoder_fifo != NULL )
         {
-            i_index++;
+            input_UnselectES( p_input, p_input->stream.pp_es[i] );
         }
+    }
 
-        p_input->stream.pp_selected_es[i_index] = 
-          p_input->stream.pp_selected_es[p_input->stream.i_selected_es_number];
-
-        p_input->stream.pp_selected_es = realloc(
-                                           p_input->stream.pp_selected_es,
-                                           p_input->stream.i_selected_es_number
-                                            * sizeof(es_descriptor_t *) );
-
-        if( p_input->stream.pp_selected_es == NULL )
+    /* Select new ES */
+    for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
+    {
+        if( p_input->stream.pp_es[i]->i_id == newval.i_int &&
+            p_input->stream.pp_es[i]->p_decoder_fifo == NULL )
         {
-            intf_ErrMsg( "No more selected ES in input_UnselectES" );
-            vlc_mutex_unlock( &p_input->stream.stream_lock );
-            return( 1 );
+            input_SelectES( p_input, p_input->stream.pp_es[i] );
         }
     }
 
-    return( 0 );
+    vlc_mutex_unlock( &p_input->stream.stream_lock );
+
+    return VLC_SUCCESS;
 }