Remove memleak in input_ItemAddInfo (check correctly vasprintf return value).

[vlc] / src / input / item.c

diff --git a/src/input/item.c b/src/input/item.c
index 8bed232c33adde6eb028759ca3ddcd544c83e11f..27f7a09db80f598b9918a083d7bb8f5ae9728cda 100644 (file)
--- a/src/input/item.c
+++ b/src/input/item.c
@@ -295,7 +295,7 @@ int input_ItemAddInfo( input_item_t *p_i,
     }
 
     va_start( args, psz_format );
-    if( vasprintf( &p_info->psz_value, psz_format, args) )
+    if( vasprintf( &p_info->psz_value, psz_format, args) == -1 )
         p_info->psz_value = NULL;
     va_end( args );
 
@@ -345,7 +345,7 @@ input_item_t *input_ItemNewWithType( vlc_object_t *p_obj, const char *psz_uri,
     DECMALLOC_NULL( p_input, input_item_t );
 
     input_ItemInit( p_obj, p_input );
-    vlc_gc_init( p_input, input_ItemDestroy, (void *)p_obj );
+    vlc_gc_init( p_input, input_ItemDestroy, (void *)p_obj->p_libvlc );
 
     vlc_object_lock( p_obj->p_libvlc );
     p_input->i_id = ++priv->i_last_input_id;