*****************************************************************************/
#include <vlc/vlc.h>
-#include <vlc/input.h>
+#include <vlc_input.h>
+#include <vlc_stream.h>
#include <vlc_meta.h>
-#include "vlc_playlist.h"
-#include "charset.h"
+#include <vlc_playlist.h>
+#include <vlc_charset.h>
+#include "../playlist/playlist_internal.h"
+#include <errno.h>
#ifdef HAVE_SYS_STAT_H
# include <sys/stat.h>
#endif
-int input_FindArtInCache( playlist_t *p_playlist, input_item_t *p_item );
+// FIXME be sure to not touch p_meta without lock on p_item
-vlc_bool_t input_MetaSatisfied( playlist_t *p_playlist, input_item_t *p_item,
- uint32_t *pi_mandatory, uint32_t *pi_optional,
- vlc_bool_t b_check_cache )
+static const char * meta_type_to_string[VLC_META_TYPE_COUNT] =
+{
+ [vlc_meta_Title] = N_("Title"),
+ [vlc_meta_Artist] = N_("Artist"),
+ [vlc_meta_Genre] = N_("Genre"),
+ [vlc_meta_Copyright] = N_("Copyright"),
+ [vlc_meta_Album] = N_("Album/movie/show title"),
+ [vlc_meta_TrackNumber] = N_("Track number/position in set"),
+ [vlc_meta_Description] = N_("Description"),
+ [vlc_meta_Rating] = N_("Rating"),
+ [vlc_meta_Date] = N_("Date"),
+ [vlc_meta_Setting] = N_("Setting"),
+ [vlc_meta_URL] = N_("URL"),
+ [vlc_meta_Language] = N_("Language"),
+ [vlc_meta_NowPlaying] = N_("Language"),
+ [vlc_meta_Publisher] = N_("Publisher"),
+ [vlc_meta_EncodedBy] = N_("Encoded by"),
+ [vlc_meta_ArtworkURL] = N_("Artwork URL"),
+ [vlc_meta_TrackID] = N_("Track ID"),
+};
+
+const char *
+input_MetaTypeToLocalizedString( vlc_meta_type_t meta_type )
{
- // FIXME don't var_Stuff at each loop
- int i_policy = var_CreateGetInteger( p_playlist, "album-art" );
- if( b_check_cache )
- input_FindArtInCache( p_playlist, p_item );
+ return _(meta_type_to_string[meta_type]);
+}
+
+#define input_FindArtInCache(a,b) __input_FindArtInCache(VLC_OBJECT(a),b)
+static int __input_FindArtInCache( vlc_object_t *, input_item_t *p_item );
- *pi_mandatory = VLC_META_ENGINE_TITLE | VLC_META_ENGINE_ARTIST |
- (i_policy == ALBUM_ART_ALL ? VLC_META_ENGINE_ART_URL : 0 );
+vlc_bool_t input_MetaSatisfied( playlist_t *p_playlist, input_item_t *p_item,
+ uint32_t *pi_mandatory, uint32_t *pi_optional )
+{
+ (void)p_playlist;
+ *pi_mandatory = VLC_META_ENGINE_TITLE | VLC_META_ENGINE_ARTIST;
uint32_t i_meta = input_CurrentMetaFlags( p_item->p_meta );
*pi_mandatory &= ~i_meta;
struct meta_engine_t *p_me;
uint32_t i_mandatory, i_optional;
- if( !p_item->p_meta ) return VLC_EGENERIC;
-
- input_MetaSatisfied( p_playlist, p_item,
- &i_mandatory, &i_optional, VLC_FALSE );
-
+ input_MetaSatisfied( p_playlist, p_item, &i_mandatory, &i_optional );
// Meta shouldn't magically appear
assert( i_mandatory );
+ /* FIXME: object creation is overkill, use p_private */
p_me = vlc_object_create( p_playlist, VLC_OBJECT_META_ENGINE );
p_me->i_flags |= OBJECT_FLAGS_NOINTERACT;
p_me->i_flags |= OBJECT_FLAGS_QUIET;
vlc_object_destroy( p_me );
return VLC_EGENERIC;
}
-
module_Unneed( p_me, p_me->p_module );
vlc_object_destroy( p_me );
+ input_item_SetMetaFetched( p_item, VLC_TRUE );
+
return VLC_SUCCESS;
}
-int input_ArtFetch( playlist_t *p_playlist, input_item_t *p_item )
+/* Return codes:
+ * 0 : Art is in cache
+ * 1 : Art found, need to download
+ * -X : Error/not found
+ */
+int input_ArtFind( playlist_t *p_playlist, input_item_t *p_item )
{
- if( !p_item->p_meta ) return VLC_EGENERIC;
+ int i_ret = VLC_EGENERIC;
+ module_t *p_module;
+ char *psz_name, *psz_title, *psz_artist, *psz_album;
+
+ if( !p_item->p_meta )
+ return VLC_EGENERIC;
+
+ psz_name = input_item_GetName( p_item );
+ psz_title = input_item_GetTitle( p_item );
+ psz_artist = input_item_GetArtist( p_item );
+ psz_album = input_item_GetAlbum( p_item );
- if( !p_item->p_meta->psz_arturl || !*p_item->p_meta->psz_arturl )
+ if( !psz_name && !psz_title && !psz_artist && !psz_album )
+ return VLC_EGENERIC;
+ free( psz_name );
+ free( psz_title );
+
+ /* If we already checked this album in this session, skip */
+ if( psz_artist && psz_album )
{
- module_t *p_module;
- PL_LOCK;
- p_playlist->p_private = p_item;
- p_module = module_Need( p_playlist, "art finder", 0, VLC_FALSE );
- if( !p_module )
- {
- msg_Dbg( p_playlist, "unable to find art" );
- PL_UNLOCK;
- return VLC_EGENERIC;
- }
- module_Unneed( p_playlist, p_module );
- p_playlist->p_private = NULL;
- PL_UNLOCK;
+ FOREACH_ARRAY( playlist_album_t album, p_playlist->p_fetcher->albums )
+ if( !strcmp( album.psz_artist, psz_artist ) &&
+ !strcmp( album.psz_album, psz_album ) )
+ {
+ msg_Dbg( p_playlist, " %s - %s has already been searched",
+ psz_artist, psz_album );
+ /* TODO-fenrir if we cache art filename too, we can go faster */
+ free( psz_artist );
+ free( psz_album );
+ if( album.b_found )
+ {
+ /* Actually get URL from cache */
+ input_FindArtInCache( p_playlist, p_item );
+ return 0;
+ }
+ else
+ {
+ return VLC_EGENERIC;
+ }
+ }
+ FOREACH_END();
+ }
+ free( psz_artist );
+ free( psz_album );
- if( !p_item->p_meta->psz_arturl || !*p_item->p_meta->psz_arturl )
- return VLC_EGENERIC;
+ char *psz_arturl = input_item_GetArtURL( p_item );
+ input_FindArtInCache( p_playlist, p_item );
+ if( !EMPTY_STR( psz_arturl ) )
+ {
+ free( psz_arturl );
+ return 0;
}
- return input_DownloadAndCacheArt( p_playlist, p_item );
+ free( psz_arturl );
+
+ PL_LOCK;
+ p_playlist->p_private = p_item;
+ psz_album = input_item_GetAlbum( p_item );
+ psz_artist = input_item_GetArtist( p_item );
+ psz_name = input_item_GetName( p_item );
+ psz_title = input_item_GetTitle( p_item );
+ if( psz_album && psz_artist )
+ {
+ msg_Dbg( p_playlist, "searching art for %s - %s",
+ psz_artist, psz_album );
+ }
+ else
+ {
+ msg_Dbg( p_playlist, "searching art for %s",
+ psz_title ? psz_title : psz_name );
+ }
+ free( psz_title );
+ free( psz_name );
+
+ p_module = module_Need( p_playlist, "art finder", 0, VLC_FALSE );
+
+ if( p_module )
+ i_ret = 1;
+ else
+ msg_Dbg( p_playlist, "unable to find art" );
+
+ /* Record this album */
+ if( psz_artist && psz_album )
+ {
+ playlist_album_t a;
+ a.psz_artist = psz_artist;
+ a.psz_album = psz_album;
+ a.b_found = (i_ret == VLC_EGENERIC ? VLC_FALSE : VLC_TRUE );
+ ARRAY_APPEND( p_playlist->p_fetcher->albums, a );
+ }
+ else
+ {
+ free( psz_artist );
+ free( psz_album );
+ }
+
+ if( p_module )
+ module_Unneed( p_playlist, p_module );
+ p_playlist->p_private = NULL;
+ PL_UNLOCK;
+
+ return i_ret;
}
#ifndef MAX_PATH
# define MAX_PATH 250
#endif
-int input_FindArtInCache( playlist_t *p_playlist, input_item_t *p_item )
+#define ArtCacheCreateName(a,b,c,d,e,f) __ArtCacheCreateName(VLC_OBJECT(a),b,c,d,e,f)
+static void __ArtCacheCreateName( vlc_object_t *p_obj,
+ char psz_filename[MAX_PATH+1],
+ const char *psz_title,
+ const char *psz_artist, const char *psz_album,
+ const char *psz_extension )
+{
+ if( psz_artist && psz_artist )
+ {
+ snprintf( psz_filename, MAX_PATH,
+ "file://%s" DIR_SEP CONFIG_DIR DIR_SEP "art" DIR_SEP "artistalbum"
+ DIR_SEP "%s" DIR_SEP "%s" DIR_SEP "art%s",
+ p_obj->p_libvlc->psz_homedir,
+ psz_artist, psz_album, psz_extension ? psz_extension : "" );
+ }
+ else
+ {
+ /* We will use the psz_title name to store the art */
+ snprintf( psz_filename, MAX_PATH,
+ "file://%s" DIR_SEP CONFIG_DIR DIR_SEP "art" DIR_SEP "title"
+ DIR_SEP "%s" DIR_SEP "art%s",
+ p_obj->p_libvlc->psz_homedir,
+ psz_title, psz_extension ? psz_extension : "" );
+ }
+}
+#define ArtCacheCreatePath(a,b,c,d) __ArtCacheCreatePath(VLC_OBJECT(a),b,c,d)
+static void __ArtCacheCreatePath( vlc_object_t *p_obj,
+ const char *psz_title,
+ const char *psz_artist, const char *psz_album )
+{
+ char psz_dir[MAX_PATH+1];
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR,
+ p_obj->p_libvlc->psz_homedir );
+ utf8_mkdir( psz_dir );
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP "art",
+ p_obj->p_libvlc->psz_homedir );
+ utf8_mkdir( psz_dir );
+
+ if( psz_artist && psz_artist )
+ {
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
+ "art" DIR_SEP "artistalbum",
+ p_obj->p_libvlc->psz_homedir );
+ utf8_mkdir( psz_dir );
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
+ "art" DIR_SEP "artistalbum" DIR_SEP "%s",
+ p_obj->p_libvlc->psz_homedir, psz_artist );
+ utf8_mkdir( psz_dir );
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
+ "art" DIR_SEP "artistalbum" DIR_SEP "%s" DIR_SEP "%s",
+ p_obj->p_libvlc->psz_homedir,
+ psz_artist, psz_album );
+ utf8_mkdir( psz_dir );
+ }
+ else
+ {
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
+ "art" DIR_SEP "title",
+ p_obj->p_libvlc->psz_homedir );
+ utf8_mkdir( psz_dir );
+ snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
+ "art" DIR_SEP "title" DIR_SEP "%s",
+ p_obj->p_libvlc->psz_homedir, psz_title );
+ utf8_mkdir( psz_dir );
+ }
+}
+static char *ArtCacheCreateString( const char *psz )
+{
+ char *dup = strdup(psz);
+ int i;
+
+ /* Doesn't create a filename with invalid characters
+ * TODO: several filesystems forbid several characters: list them all
+ */
+ for( i = 0; dup[i] != '\0'; i++ )
+ {
+ if( dup[i] == '/' )
+ dup[i] = ' ';
+ }
+ return dup;
+}
+
+static int __input_FindArtInCache( vlc_object_t *p_obj, input_item_t *p_item )
{
char *psz_artist;
char *psz_album;
- char psz_filename[MAX_PATH];
+ char *psz_title;
+ char psz_filename[MAX_PATH+1];
int i;
struct stat a;
const char *ppsz_type[] = { ".jpg", ".png", ".gif", ".bmp", "" };
if( !p_item->p_meta ) return VLC_EGENERIC;
- psz_artist = p_item->p_meta->psz_artist;
- psz_album = p_item->p_meta->psz_album;
+ psz_artist = input_item_GetArtist( p_item );
+ psz_album = input_item_GetAlbum( p_item );
+ psz_title = input_item_GetTitle( p_item );
+ if( !psz_title ) psz_title = input_item_GetName( p_item );
+
+ if( !psz_title && ( !psz_album || !psz_artist ) )
+ {
+ free( psz_artist );
+ free( psz_album );
+ free( psz_title );
+ return VLC_EGENERIC;
+ }
+ free( psz_title );
for( i = 0; i < 5; i++ )
{
- snprintf( psz_filename, MAX_PATH,
- "file://%s" DIR_SEP CONFIG_DIR DIR_SEP "art"
- DIR_SEP "%s" DIR_SEP "%s" DIR_SEP "art%s",
- p_playlist->p_libvlc->psz_homedir,
- psz_artist, psz_album, ppsz_type[i] );
+ ArtCacheCreateName( p_obj, psz_filename, psz_title /* Used if none artist nor album is defined */,
+ psz_artist, psz_album, ppsz_type[i] );
/* Check if file exists */
if( utf8_stat( psz_filename+7, &a ) == 0 )
{
- vlc_meta_SetArtURL( p_item->p_meta, psz_filename );
+ input_item_SetArtURL( p_item, psz_filename );
+ free( psz_artist );
+ free( psz_album );
return VLC_SUCCESS;
}
}
-
+ free( psz_artist );
+ free( psz_album );
return VLC_EGENERIC;
}
{
int i_status = VLC_EGENERIC;
stream_t *p_stream;
- char psz_filename[MAX_PATH], psz_dir[MAX_PATH];
- char *psz_artist;
- char *psz_album;
+ char psz_filename[MAX_PATH+1];
+ char *psz_artist = NULL;
+ char *psz_album = NULL;
+ char *psz_title = NULL;
+ char *psz_artist_m, *psz_album_m, *psz_title_m, *psz_name_m, *psz_arturl_m;
char *psz_type;
- psz_artist = p_item->p_meta->psz_artist;
- psz_album = p_item->p_meta->psz_album;
- /* You dummy ! How am I supposed to download NULL ? */
- if( !p_item->p_meta || !p_item->p_meta->psz_arturl
- || !*p_item->p_meta->psz_arturl )
- return VLC_EGENERIC;
+ psz_artist_m = input_item_GetArtist( p_item );
+ psz_album_m = input_item_GetAlbum( p_item );
+ psz_title_m = input_item_GetTitle( p_item );
+ psz_name_m = input_item_GetName( p_item );
+
+ if( psz_artist_m ) psz_artist = ArtCacheCreateString( psz_artist_m );
+ if( psz_album_m ) psz_album = ArtCacheCreateString( psz_album_m );
+ if( psz_title_m ) psz_title = ArtCacheCreateString( psz_title_m );
+ else if( psz_name_m ) psz_title = ArtCacheCreateString( psz_name_m );
+
+ free( psz_artist_m );
+ free( psz_album_m );
+ free( psz_title_m );
+ free( psz_name_m );
- /* FIXME: use an alternate saving filename scheme if we don't have
- * the artist or album name */
- if( !p_item->p_meta->psz_artist
- || !p_item->p_meta->psz_album )
+ if( !psz_title && (!psz_artist || !psz_album) )
+ {
+ free( psz_title );
+ free( psz_album );
+ free( psz_artist );
return VLC_EGENERIC;
+ }
- /* Check if file doesn't already exist */
- if( input_FindArtInCache( p_playlist, p_item ) == VLC_SUCCESS )
- return VLC_SUCCESS;
+ psz_arturl_m = input_item_GetArtURL( p_item );
+ assert( !EMPTY_STR( psz_arturl_m ) );
- psz_type = strrchr( p_item->p_meta->psz_arturl, '.' );
+ psz_type = strrchr( psz_arturl_m, '.' );
- /* Todo: get a helper to do this */
- snprintf( psz_filename, MAX_PATH,
- "file://%s" DIR_SEP CONFIG_DIR DIR_SEP "art"
- DIR_SEP "%s" DIR_SEP "%s" DIR_SEP "art%s",
- p_playlist->p_libvlc->psz_homedir,
- psz_artist, psz_album, psz_type );
+ /* */
+ ArtCacheCreateName( p_playlist, psz_filename, psz_title /* Used only if needed*/,
+ psz_artist, psz_album, psz_type );
- snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR,
- p_playlist->p_libvlc->psz_homedir );
- utf8_mkdir( psz_dir );
- snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP "art",
- p_playlist->p_libvlc->psz_homedir );
- utf8_mkdir( psz_dir );
- snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
- "art" DIR_SEP "%s",
- p_playlist->p_libvlc->psz_homedir, psz_artist );
- utf8_mkdir( psz_dir );
- snprintf( psz_dir, MAX_PATH, "%s" DIR_SEP CONFIG_DIR DIR_SEP
- "art" DIR_SEP "%s" DIR_SEP "%s",
- p_playlist->p_libvlc->psz_homedir,
- psz_artist, psz_album );
- utf8_mkdir( psz_dir );
+ /* */
+ ArtCacheCreatePath( p_playlist, psz_title, psz_artist, psz_album );
- /* Todo: check for stuff that needs a downloader module */
- p_stream = stream_UrlNew( p_playlist, p_item->p_meta->psz_arturl );
+ /* */
+ free( psz_artist );
+ free( psz_album );
+ free( psz_title );
+ if( !strncmp( psz_arturl_m , "APIC", 4 ) )
+ {
+ msg_Warn( p_playlist, "APIC fetch not supported yet" );
+ free( psz_arturl_m );
+ return VLC_EGENERIC;
+ }
+
+ p_stream = stream_UrlNew( p_playlist, psz_arturl_m );
if( p_stream )
{
- void *p_buffer = malloc( 1<<16 );
+ uint8_t p_buffer[65536];
long int l_read;
FILE *p_file = utf8_fopen( psz_filename+7, "w" );
- while( ( l_read = stream_Read( p_stream, p_buffer, 1<<16 ) ) )
+ int err = 0;
+ while( ( l_read = stream_Read( p_stream, p_buffer, sizeof (p_buffer) ) ) )
{
- fwrite( p_buffer, l_read, 1, p_file );
+ if( fwrite( p_buffer, l_read, 1, p_file ) != 1 )
+ {
+ err = errno;
+ break;
+ }
}
- free( p_buffer );
- fclose( p_file );
+ if( fclose( p_file ) && !err )
+ err = errno;
stream_Delete( p_stream );
- msg_Dbg( p_playlist, "album art saved to %s\n", psz_filename );
- free( p_item->p_meta->psz_arturl );
- p_item->p_meta->psz_arturl = strdup( psz_filename );
+
+ if( err )
+ msg_Err( p_playlist, "%s: %s", psz_filename, strerror( err ) );
+ else
+ msg_Dbg( p_playlist, "album art saved to %s\n", psz_filename );
+
+ input_item_SetArtURL( p_item, psz_filename );
i_status = VLC_SUCCESS;
}
+ free( psz_arturl_m );
return i_status;
}
+void input_ExtractAttachmentAndCacheArt( input_thread_t *p_input )
+{
+ input_item_t *p_item = p_input->p->input.p_item;
+ char *psz_arturl;
+ char *psz_artist = NULL;
+ char *psz_album = NULL;
+ char *psz_title = NULL;
+ char *psz_type = NULL;
+ char *psz_artist_m, *psz_album_m, *psz_title_m, *psz_name_m;
+ char psz_filename[MAX_PATH+1];
+ FILE *f;
+ input_attachment_t *p_attachment;
+ struct stat s;
+ int i_idx;
+
+ /* TODO-fenrir merge input_ArtFind with download and make it set the flags FETCH
+ * and then set it here to to be faster */
+
+ psz_arturl = input_item_GetArtURL( p_item );
+ if( !psz_arturl || strncmp( psz_arturl, "attachment://", strlen("attachment://") ) )
+ {
+ free( psz_arturl );
+ msg_Err( p_input, "internal input error with input_ExtractAttachmentAndCacheArt" );
+ return;
+ }
+ input_item_SetArtURL( p_item, NULL );
+
+ if( input_item_IsArtFetched( p_item ) )
+ {
+ /* XXX Weird, we should not have end up with attachment:// art url unless there is a race
+ * condition */
+ msg_Warn( p_input, "internal input error with input_ExtractAttachmentAndCacheArt" );
+ input_FindArtInCache( p_input, p_item );
+ free( psz_arturl );
+ return;
+ }
+
+ /* */
+ for( i_idx = 0, p_attachment = NULL; i_idx < p_input->p->i_attachment; i_idx++ )
+ {
+ if( !strcmp( p_input->p->attachment[i_idx]->psz_name,
+ &psz_arturl[strlen("attachment://")] ) )
+ {
+ p_attachment = p_input->p->attachment[i_idx];
+ break;
+ }
+ }
+ if( !p_attachment || p_attachment->i_data <= 0 )
+ {
+ msg_Warn( p_input, "internal input error with input_ExtractAttachmentAndCacheArt" );
+ goto end;
+ }
+
+ psz_artist_m = input_item_GetArtist( p_item );
+ psz_album_m = input_item_GetAlbum( p_item );
+ psz_title_m = input_item_GetTitle( p_item );
+ psz_name_m = input_item_GetName( p_item );
+
+ if( psz_artist_m ) psz_artist = ArtCacheCreateString( psz_artist_m );
+ if( psz_album_m ) psz_album = ArtCacheCreateString( psz_album_m );
+ if( psz_title_m ) psz_title = ArtCacheCreateString( psz_title_m );
+ else if( psz_name_m ) psz_title = ArtCacheCreateString( psz_name_m );
+
+ free( psz_artist_m );
+ free( psz_album_m );
+ free( psz_title_m );
+ free( psz_name_m );
+
+ if( (!psz_artist || !psz_album ) && !psz_title )
+ goto end;
+
+ /* */
+ psz_type = strrchr( psz_arturl, '.' );
+ ArtCacheCreateName( p_input, psz_filename, psz_title, psz_artist, psz_album, psz_type );
+
+ /* Check if we already dumped it */
+ if( !utf8_stat( psz_filename+7, &s ) )
+ goto end;
+
+ ArtCacheCreatePath( p_input, psz_title, psz_artist, psz_album );
+
+ f = utf8_fopen( psz_filename+7, "w" );
+ if( f )
+ {
+ if( fwrite( p_attachment->p_data, p_attachment->i_data, 1, f ) != 1 )
+ msg_Err( p_input, "%s: %s", psz_filename, strerror( errno ) );
+ else
+ msg_Dbg( p_input, "album art saved to %s\n", psz_filename );
+ fclose( f );
+ }
+
+end:
+ if( psz_artist ) free( psz_artist );
+ if( psz_album ) free( psz_album );
+ if( psz_title ) free( psz_title );
+ if( psz_arturl ) free( psz_arturl );
+}
+
+
uint32_t input_CurrentMetaFlags( vlc_meta_t *p_meta )
{
uint32_t i_meta = 0;
+ if( !p_meta )
+ return 0;
+
#define CHECK( a, b ) \
- if( p_meta->psz_ ## a && *p_meta->psz_ ## a ) \
+ if( !EMPTY_STR( vlc_meta_Get( p_meta, vlc_meta_ ## a ) ) ) \
i_meta |= VLC_META_ENGINE_ ## b;
- CHECK( title, TITLE )
- CHECK( artist, ARTIST )
- CHECK( genre, GENRE )
- CHECK( copyright, COPYRIGHT )
- CHECK( album, COLLECTION )
- CHECK( tracknum, SEQ_NUM )
- CHECK( description, DESCRIPTION )
- CHECK( rating, RATING )
- CHECK( date, DATE )
- CHECK( url, URL )
- CHECK( language, LANGUAGE )
- CHECK( arturl, ART_URL )
+ CHECK( Title, TITLE )
+ CHECK( Artist, ARTIST )
+ CHECK( Album, COLLECTION )
+#if 0
+ /* As this is not used at the moment, don't uselessly check for it.
+ * Re-enable this when it is used */
+ CHECK( Genre, GENRE )
+ CHECK( Copyright, COPYRIGHT )
+ CHECK( Tracknum, SEQ_NUM )
+ CHECK( Description, DESCRIPTION )
+ CHECK( Rating, RATING )
+ CHECK( Date, DATE )
+ CHECK( URL, URL )
+ CHECK( Language, LANGUAGE )
+#endif
+ CHECK( ArtworkURL, ART_URL )
return i_meta;
}
projects / vlc / blobdiff