]> git.sesse.net Git - vlc/blobdiff - src/input/stream.c
Compiler warnings rampage
[vlc] / src / input / stream.c
index da0d66894c5e4db47db7d8ea7af985f4eb216cee..223b6f16867e0c5bc61ab115faf52f77157d03bf 100644 (file)
@@ -23,8 +23,6 @@
 
 #include <stdlib.h>
 #include <vlc/vlc.h>
-#include <vlc/input.h>
-#include <assert.h>
 
 #include "input_internal.h"
 
@@ -193,18 +191,19 @@ static int  ASeek( stream_t *s, int64_t i_pos );
  ****************************************************************************/
 stream_t *__stream_UrlNew( vlc_object_t *p_parent, const char *psz_url )
 {
-    char *psz_access, *psz_demux, *psz_path, *psz_dup;
+    const char *psz_access, *psz_demux;
+    char *psz_path;
     access_t *p_access;
     stream_t *p_res;
 
     if( !psz_url ) return 0;
 
-    psz_dup = strdup( psz_url );
+    char psz_dup[strlen (psz_url) + 1];
+    strcpy (psz_dup, psz_url);;
     MRLSplit( p_parent, psz_dup, &psz_access, &psz_demux, &psz_path );
 
     /* Now try a real access */
     p_access = access2_New( p_parent, psz_access, psz_demux, psz_path, 0 );
-    free( psz_dup );
 
     if( p_access == NULL )
     {
@@ -236,7 +235,7 @@ stream_t *stream_AccessNew( access_t *p_access, vlc_bool_t b_quick )
     s->pf_block  = NULL;
     s->pf_read   = NULL;    /* Set up later */
     s->pf_peek   = NULL;
-    s->pf_control= AStreamControl;
+    s->pf_control = AStreamControl;
     s->pf_destroy = AStreamDestroy;
 
     s->p_sys = p_sys = malloc( sizeof( stream_sys_t ) );
@@ -1416,7 +1415,7 @@ char * stream_ReadLine( stream_t *s )
         {
             int i_bom_size = 0;
             char *psz_encoding = NULL;
-            
+
             if( p_data[0] == 0xEF && p_data[1] == 0xBB && p_data[2] == 0xBF )
             {
                 psz_encoding = strdup( "UTF-8" );
@@ -1489,16 +1488,70 @@ char * stream_ReadLine( stream_t *s )
 
         if( i_data % s->i_char_width )
         {
+            /* keep i_char_width boundary */
+            i_data = i_data - ( i_data % s->i_char_width );
             msg_Warn( s, "the read is not i_char_width compatible");
         }
 
+        if( i_data == 0 )
+            break;
+
         /* Check if there is an EOL */
-        if( ( psz_eol = memchr( p_data, '\n', i_data ) ) )
+        if( s->i_char_width == 1 )
+        {
+            /* UTF-8: 0A <LF> */
+            psz_eol = memchr( p_data, '\n', i_data );
+        }
+        else
         {
-            if( s->b_little_endian == VLC_TRUE && s->i_char_width > 1 )
+            uint8_t *p = p_data;
+            uint8_t *p_last = p + i_data - s->i_char_width;
+
+            if( s->i_char_width == 2 )
             {
-                psz_eol += ( s->i_char_width - 1 );
+                if( s->b_little_endian == VLC_TRUE)
+                {
+                    /* UTF-16LE: 0A 00 <LF> */
+                    while( p <= p_last && ( p[0] != 0x0A || p[1] != 0x00 ) )
+                        p += 2;
+                }
+                else
+                {
+                    /* UTF-16BE: 00 0A <LF> */
+                    while( p <= p_last && ( p[1] != 0x0A || p[0] != 0x00 ) )
+                        p += 2;
+                }
             }
+            else if( s->i_char_width == 4 )
+            {
+                if( s->b_little_endian == VLC_TRUE)
+                {
+                    /* UTF-32LE: 0A 00 00 00 <LF> */
+                    while( p <= p_last && ( p[0] != 0x0A || p[1] != 0x00 ||
+                           p[2] != 0x00 || p[3] != 0x00 ) )
+                        p += 4;
+                }
+                else
+                {
+                    /* UTF-32BE: 00 00 00 0A <LF> */
+                    while( p <= p_last && ( p[3] != 0x0A || p[2] != 0x00 ||
+                           p[1] != 0x00 || p[0] != 0x00 ) )
+                        p += 4;
+                }
+            }
+
+            if( p > p_last )
+            {
+                psz_eol = NULL;
+            }
+            else
+            {
+                psz_eol = (char *)p + ( s->i_char_width - 1 );
+            }
+        }
+
+        if(psz_eol)
+        {
             i_data = (psz_eol - (char *)p_data) + 1;
             p_line = realloc( p_line, i_line + i_data + s->i_char_width ); /* add \0 */
             i_data = stream_Read( s, &p_line[i_line], i_data );
@@ -1532,14 +1585,14 @@ char * stream_ReadLine( stream_t *s )
             const char * p_in = NULL;
             char * p_out = NULL;
             char * psz_new_line = NULL;
-            
+
             /* iconv */
             psz_new_line = malloc( i_line );
-            
+
             i_in = i_out = (size_t)i_line;
             p_in = p_line;
             p_out = psz_new_line;
-            
+
             if( vlc_iconv( s->conv, &p_in, &i_in, &p_out, &i_out ) == (size_t)-1 )
             {
                 msg_Err( s, "iconv failed" );
@@ -1551,7 +1604,7 @@ char * stream_ReadLine( stream_t *s )
         }
 
         /* Remove trailing LF/CR */
-        while( i_line > 0 && ( p_line[i_line-2] == '\r' ||
+        while( i_line >= 2 && ( p_line[i_line-2] == '\r' ||
             p_line[i_line-2] == '\n') ) i_line--;
 
         /* Make sure the \0 is there */
@@ -1575,7 +1628,7 @@ static int AReadStream( stream_t *s, void *p_read, int i_read )
     access_t *p_access = p_sys->p_access;
     input_thread_t *p_input = NULL;
     int i_read_orig = i_read;
-    int i_total;
+    int i_total = 0;
 
     if( s->p_parent && s->p_parent->p_parent &&
         s->p_parent->p_parent->i_object_type == VLC_OBJECT_INPUT )
@@ -1587,13 +1640,13 @@ static int AReadStream( stream_t *s, void *p_read, int i_read )
         if( p_input )
         {
             vlc_object_yield( p_input );
-            vlc_mutex_lock( &p_input->counters.counters_lock );
-            stats_UpdateInteger( s, p_input->counters.p_read_bytes, i_read,
+            vlc_mutex_lock( &p_input->p->counters.counters_lock );
+            stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, i_read,
                              &i_total );
-            stats_UpdateFloat( s, p_input->counters.p_input_bitrate,
+            stats_UpdateFloat( s, p_input->p->counters.p_input_bitrate,
                            (float)i_total, NULL );
-            stats_UpdateInteger( s, p_input->counters.p_read_packets, 1, NULL );
-            vlc_mutex_unlock( &p_input->counters.counters_lock );
+            stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL );
+            vlc_mutex_unlock( &p_input->p->counters.counters_lock );
             vlc_object_release( p_input );
         }
         return i_read;
@@ -1627,12 +1680,12 @@ static int AReadStream( stream_t *s, void *p_read, int i_read )
     if( p_input )
     {
         vlc_object_yield( p_input );
-        vlc_mutex_lock( &p_input->counters.counters_lock );
-        stats_UpdateInteger( s, p_input->counters.p_read_bytes, i_read, &i_total );
-        stats_UpdateFloat( s, p_input->counters.p_input_bitrate,
+        vlc_mutex_lock( &p_input->p->counters.counters_lock );
+        stats_UpdateInteger( s, p_input->p->counters.p_read_bytes, i_read, &i_total );
+        stats_UpdateFloat( s, p_input->p->counters.p_input_bitrate,
                        (float)i_total, NULL );
-        stats_UpdateInteger( s, p_input->counters.p_read_packets, 1, NULL );
-        vlc_mutex_unlock( &p_input->counters.counters_lock );
+        stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL );
+        vlc_mutex_unlock( &p_input->p->counters.counters_lock );
         vlc_object_release( p_input );
     }
     return i_read;
@@ -1645,7 +1698,7 @@ static block_t *AReadBlock( stream_t *s, vlc_bool_t *pb_eof )
     input_thread_t *p_input = NULL;
     block_t *p_block;
     vlc_bool_t b_eof;
-    int i_total;
+    int i_total = 0;
 
     if( s->p_parent && s->p_parent->p_parent &&
         s->p_parent->p_parent->i_object_type == VLC_OBJECT_INPUT )
@@ -1658,13 +1711,13 @@ static block_t *AReadBlock( stream_t *s, vlc_bool_t *pb_eof )
         if( p_input &&  p_block && p_access->p_libvlc->b_stats )
         {
             vlc_object_yield( p_input );
-            vlc_mutex_lock( &p_input->counters.counters_lock );
-            stats_UpdateInteger( s, p_input->counters.p_read_bytes,
+            vlc_mutex_lock( &p_input->p->counters.counters_lock );
+            stats_UpdateInteger( s, p_input->p->counters.p_read_bytes,
                                  p_block->i_buffer, &i_total );
-            stats_UpdateFloat( s, p_input->counters.p_input_bitrate,
+            stats_UpdateFloat( s, p_input->p->counters.p_input_bitrate,
                               (float)i_total, NULL );
-            stats_UpdateInteger( s, p_input->counters.p_read_packets, 1, NULL );
-            vlc_mutex_unlock( &p_input->counters.counters_lock );
+            stats_UpdateInteger( s, p_input->p->counters.p_read_packets, 1, NULL );
+            vlc_mutex_unlock( &p_input->p->counters.counters_lock );
             vlc_object_release( p_input );
         }
         return p_block;
@@ -1699,14 +1752,14 @@ static block_t *AReadBlock( stream_t *s, vlc_bool_t *pb_eof )
         if( p_input )
         {
             vlc_object_yield( p_input );
-            vlc_mutex_lock( &p_input->counters.counters_lock );
-            stats_UpdateInteger( s, p_input->counters.p_read_bytes,
+            vlc_mutex_lock( &p_input->p->counters.counters_lock );
+            stats_UpdateInteger( s, p_input->p->counters.p_read_bytes,
                                  p_block->i_buffer, &i_total );
-            stats_UpdateFloat( s, p_input->counters.p_input_bitrate,
+            stats_UpdateFloat( s, p_input->p->counters.p_input_bitrate,
                               (float)i_total, NULL );
-            stats_UpdateInteger( s, p_input->counters.p_read_packets,
+            stats_UpdateInteger( s, p_input->p->counters.p_read_packets,
                                  1 , NULL);
-            vlc_mutex_unlock( &p_input->counters.counters_lock );
+            vlc_mutex_unlock( &p_input->p->counters.counters_lock );
             vlc_object_release( p_input );
         }
     }