]> git.sesse.net Git - vlc/blobdiff - src/interface/interaction.c
Clean up coments.
[vlc] / src / interface / interaction.c
index 41ef1a183e0fd1a28e7078377066177bb7aebff6..2359516378e20d7fff93710105779f8c170d6365 100644 (file)
@@ -1,7 +1,7 @@
 /*****************************************************************************
  * interaction.c: User interaction functions
  *****************************************************************************
- * Copyright (C) 2005-2006 the VideoLAN team
+ * Copyright © 2005-2008 the VideoLAN team
  * $Id$
  *
  * Authors: Clément Stenac <zorglub@videolan.org>
 # include "config.h"
 #endif
 
-#include <vlc/vlc.h>
-
-#include <stdlib.h>                                      /* free(), strtol() */
-#include <stdio.h>                                                   /* FILE */
-#include <string.h>
+#include <vlc_common.h>
 
 #include <vlc_interface.h>
-#include <vlc_playlist.h>
 #include "interface.h"
+#include "libvlc.h"
+
+#include <assert.h>
 
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
-static void                  InteractionInit( playlist_t *p_playlist );
-static interaction_t *       InteractionGet( vlc_object_t *p_this );
-static void                  InteractionSearchInterface( interaction_t *
-                                                          p_interaction );
-static interaction_dialog_t *DialogGetById( interaction_t* , int );
-static void                  DialogDestroy( interaction_dialog_t *p_dialog );
-static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog );
-
-/**
- * Destroy the interaction system
- * \param The interaction object to destroy
- * \return nothing
- */
-void intf_InteractionDestroy( interaction_t *p_interaction )
-{
-    int i;
-    // Remove all dialogs - Interfaces must be able to clean up their data
-    for( i = p_interaction->i_dialogs -1 ; i >= 0; i-- )
-    {
-        interaction_dialog_t * p_dialog = p_interaction->pp_dialogs[i];
-        DialogDestroy( p_dialog );
-        REMOVE_ELEM( p_interaction->pp_dialogs, p_interaction->i_dialogs, i );
-    }
-    vlc_object_release( p_interaction );
-}
-
-/**
- * The main interaction processing loop
- * This function is called from the playlist loop
- *
- * \param p_playlist the parent playlist
- * \return nothing
- */
-void intf_InteractionManage( playlist_t *p_playlist )
-{
-    vlc_value_t val;
-    int i_index;
-    interaction_t *p_interaction = p_playlist->p_interaction;
-
-    // Nothing to do
-    if( p_interaction->i_dialogs == 0 ) return;
-
-    vlc_mutex_lock( &p_interaction->object_lock );
-
-    InteractionSearchInterface( p_interaction );
-    if( !p_interaction->p_intf )
-    {
-        // We mark all dialogs as answered with their "default" answer
-        for( i_index = 0 ; i_index < p_interaction->i_dialogs; i_index ++ )
-        {
-            interaction_dialog_t *p_dialog = p_interaction->pp_dialogs[i_index];
-            p_dialog->i_return = DIALOG_DEFAULT; // Give default answer
+static interaction_t *          InteractionGet( vlc_object_t * );
+static void                     InteractionSearchInterface( interaction_t * );
+static void*                    InteractionLoop( vlc_object_t * );
+static void                     InteractionManage( interaction_t * );
 
-            // Pretend we have hidden and destroyed it
-            if( p_dialog->i_status == HIDDEN_DIALOG )
-                p_dialog->i_status = DESTROYED_DIALOG;
-            else
-                p_dialog->i_status = HIDING_DIALOG;
-        }
-    }
-    else
-        vlc_object_yield( p_interaction->p_intf );
-
-    for( i_index = 0 ; i_index < p_interaction->i_dialogs; i_index ++ )
-    {
-        interaction_dialog_t *p_dialog = p_interaction->pp_dialogs[i_index];
-        switch( p_dialog->i_status )
-        {
-        case ANSWERED_DIALOG:
-            // Ask interface to hide it
-            p_dialog->i_action = INTERACT_HIDE;
-            val.p_address = p_dialog;
-            if( p_interaction->p_intf )
-                var_Set( p_interaction->p_intf, "interaction", val );
-            p_dialog->i_status = HIDING_DIALOG;
-            break;
-        case UPDATED_DIALOG:
-            p_dialog->i_action = INTERACT_UPDATE;
-            val.p_address = p_dialog;
-            if( p_interaction->p_intf )
-                var_Set( p_interaction->p_intf, "interaction", val );
-            p_dialog->i_status = SENT_DIALOG;
-            break;
-        case HIDDEN_DIALOG:
-            if( !(p_dialog->i_flags & DIALOG_GOT_ANSWER) ) break;
-            p_dialog->i_action = INTERACT_DESTROY;
-            val.p_address = p_dialog;
-            if( p_interaction->p_intf )
-                var_Set( p_interaction->p_intf, "interaction", val );
-            break;
-        case DESTROYED_DIALOG:
-            // Interface has now destroyed it, remove it
-            REMOVE_ELEM( p_interaction->pp_dialogs, p_interaction->i_dialogs,
-                         i_index);
-            i_index--;
-            DialogDestroy( p_dialog );
-            break;
-        case NEW_DIALOG:
-            // This is truly a new dialog, send it.
-            p_dialog->i_action = INTERACT_NEW;
-            val.p_address = p_dialog;
-            if( p_interaction->p_intf )
-                var_Set( p_interaction->p_intf, "interaction", val );
-            p_dialog->i_status = SENT_DIALOG;
-            break;
-        }
-    }
-
-    if( p_interaction->p_intf )
-    {
-        vlc_object_release( p_interaction->p_intf );
-    }
-
-    vlc_mutex_unlock( &p_playlist->p_interaction->object_lock );
-}
+static interaction_dialog_t    *DialogGetById( interaction_t* , int );
+static void                     DialogDestroy( interaction_dialog_t * );
+static int DialogSend( vlc_object_t *, interaction_dialog_t * );
 
 #define DIALOG_INIT( type ) \
-        DECMALLOC_ERR( p_new, interaction_dialog_t );                     \
-        memset( p_new, 0, sizeof( interaction_dialog_t ) );               \
-        p_new->b_cancelled = VLC_FALSE;                                   \
-        p_new->i_status = NEW_DIALOG;                                     \
-        p_new->i_flags = 0; \
-        p_new->i_type = INTERACT_DIALOG_##type;                           \
-        p_new->psz_returned[0] = NULL;                                    \
-        p_new->psz_returned[1] = NULL;
+        DECMALLOC_ERR( p_new, interaction_dialog_t );       \
+        memset( p_new, 0, sizeof( interaction_dialog_t ) ); \
+        p_new->b_cancelled = false;                     \
+        p_new->i_status = NEW_DIALOG;                       \
+        p_new->i_flags = 0;                                 \
+        p_new->i_type = INTERACT_DIALOG_##type;             \
+        p_new->psz_returned[0] = NULL;                      \
+        p_new->psz_returned[1] = NULL
 
 #define FORMAT_DESC \
         va_start( args, psz_format ); \
-        vasprintf( &p_new->psz_description, psz_format, args ); \
-        va_end( args );
-
-/** Send an error message, both in a blocking and non-blocking way
- *  \param p_this     Parent vlc_object
- *  \param b_blocking Is this dialog blocking or not?
- *  \param psz_title  Title for the dialog
- *  \param psz_format The message to display
- *  */
-int __intf_UserFatal( vlc_object_t *p_this, vlc_bool_t b_blocking,
+        if( vasprintf( &p_new->psz_description, psz_format, args ) == -1 ) \
+            return VLC_EGENERIC; \
+        va_end( args )
+
+/**
+ * Send an error message, both in a blocking and non-blocking way
+ *
+ * \param p_this     Parent vlc_object
+ * \param b_blocking Is this dialog blocking or not?
+ * \param psz_title  Title for the dialog
+ * \param psz_format The message to display
+ * \return           VLC_SUCCESS or VLC_EGENERIC
+ */
+int __intf_UserFatal( vlc_object_t *p_this, bool b_blocking,
                        const char *psz_title,
                        const char *psz_format, ... )
 {
@@ -203,11 +98,14 @@ int __intf_UserFatal( vlc_object_t *p_this, vlc_bool_t b_blocking,
     return DialogSend( p_this, p_new );
 }
 
-/** Helper function to send an warning, which is always shown non-blocking
- *  \param p_this     Parent vlc_object
- *  \param psz_title  Title for the dialog
- *  \param psz_format The message to display
- *  */
+/**
+ * Helper function to send a warning, which is always shown non-blocking
+ *
+ * \param p_this     Parent vlc_object
+ * \param psz_title  Title for the dialog
+ * \param psz_format The message to display
+ * \return           VLC_SUCCESS or VLC_EGENERIC
+ */
 int __intf_UserWarn( vlc_object_t *p_this,
                      const char *psz_title,
                      const char *psz_format, ... )
@@ -216,21 +114,23 @@ int __intf_UserWarn( vlc_object_t *p_this,
     DIALOG_INIT( ONEWAY );
 
     p_new->psz_title = strdup( psz_title );
-    FORMAT_DESC
+    FORMAT_DESC;
 
     p_new->i_flags = DIALOG_WARNING;
 
     return DialogSend( p_this, p_new );
 }
 
-/** Helper function to ask a yes-no-cancel question
- *  \param p_this           Parent vlc_object
- *  \param psz_title        Title for the dialog
- *  \param psz_description  A description
- *  \param psz_default      caption for the default button
- *  \param psz_alternate    caption for the alternate button
- *  \param psz_other        caption for the optional 3rd button (== cancel)
- *  \return                 Clicked button code
+/**
+ * Helper function to ask a yes-no-cancel question
+ *
+ * \param p_this           Parent vlc_object
+ * \param psz_title        Title for the dialog
+ * \param psz_description  A description
+ * \param psz_default      caption for the default button
+ * \param psz_alternate    caption for the alternate button
+ * \param psz_other        caption for the optional 3rd button (== cancel)
+ * \return                 Clicked button code
  */
 int __intf_UserYesNo( vlc_object_t *p_this,
                       const char *psz_title,
@@ -252,13 +152,15 @@ int __intf_UserYesNo( vlc_object_t *p_this,
     return DialogSend( p_this, p_new );
 }
 
-/** Helper function to create a dialogue showing a progress-bar with some info
- *  \param p_this           Parent vlc_object
- *  \param psz_title        Title for the dialog (NULL implies main intf )
- *  \param psz_status       Current status
- *  \param f_position       Current position (0.0->100.0)
- *  \param i_timeToGo       Time (in sec) to go until process is finished
- *  \return                 Dialog id, to give to UserProgressUpdate
+/**
+ * Helper function to create a dialogue showing a progress-bar with some info
+ *
+ * \param p_this           Parent vlc_object
+ * \param psz_title        Title for the dialog (NULL implies main intf )
+ * \param psz_status       Current status
+ * \param f_position       Current position (0.0->100.0)
+ * \param i_timeToGo       Time (in sec) to go until process is finished
+ * \return                 Dialog id, to give to UserProgressUpdate
  */
 int __intf_Progress( vlc_object_t *p_this, const char *psz_title,
                      const char *psz_status, float f_pos, int i_time )
@@ -281,13 +183,15 @@ int __intf_Progress( vlc_object_t *p_this, const char *psz_title,
     return p_new->i_id;
 }
 
-/** Update a progress bar in a dialogue
- *  \param p_this           Parent vlc_object
- *  \param i_id             Identifier of the dialog
- *  \param psz_status       New status
- *  \param f_position       New position (0.0->100.0)
- *  \param i_timeToGo       Time (in sec) to go until process is finished
- *  \return                 nothing
+/**
+ * Update a progress bar in a dialogue
+ *
+ * \param p_this           Parent vlc_object
+ * \param i_id             Identifier of the dialog
+ * \param psz_status       New status
+ * \param f_position       New position (0.0->100.0)
+ * \param i_timeToGo       Time (in sec) to go until process is finished
+ * \return                 nothing
  */
 void __intf_ProgressUpdate( vlc_object_t *p_this, int i_id,
                             const char *psz_status, float f_pos, int i_time )
@@ -297,12 +201,13 @@ void __intf_ProgressUpdate( vlc_object_t *p_this, int i_id,
 
     if( !p_interaction ) return;
 
-    vlc_mutex_lock( &p_interaction->object_lock );
+    vlc_object_lock( p_interaction );
     p_dialog  =  DialogGetById( p_interaction, i_id );
 
     if( !p_dialog )
     {
-        vlc_mutex_unlock( &p_interaction->object_lock ) ;
+        vlc_object_unlock( p_interaction );
+        vlc_object_release( p_interaction );
         return;
     }
 
@@ -313,58 +218,65 @@ void __intf_ProgressUpdate( vlc_object_t *p_this, int i_id,
     p_dialog->i_timeToGo = i_time;
 
     p_dialog->i_status = UPDATED_DIALOG;
-    vlc_mutex_unlock( &p_interaction->object_lock) ;
 
-    playlist_Signal( pl_Get( p_this ) );
+    vlc_object_signal_unlocked( p_interaction );
+    vlc_object_unlock( p_interaction );
+    vlc_object_release( p_interaction );
 }
 
-/** Helper function to communicate dialogue cancellations between the
- *  interface module and the caller
- *  \param p_this           Parent vlc_object
- *  \param i_id             Identifier of the dialogue
- *  \return                 Either true or false
+/**
+ * Helper function to communicate dialogue cancellations between the
+ * interface module and the caller
+ *
+ * \param p_this           Parent vlc_object
+ * \param i_id             Identifier of the dialogue
+ * \return                 Either true or false
  */
-vlc_bool_t __intf_UserProgressIsCancelled( vlc_object_t *p_this, int i_id )
+bool __intf_UserProgressIsCancelled( vlc_object_t *p_this, int i_id )
 {
     interaction_t *p_interaction = InteractionGet( p_this );
     interaction_dialog_t *p_dialog;
-    vlc_bool_t b_cancel;
+    bool b_cancel;
 
-    if( !p_interaction ) return VLC_TRUE;
+    if( !p_interaction ) return true;
 
-    vlc_mutex_lock( &p_interaction->object_lock );
+    vlc_object_lock( p_interaction );
     p_dialog  =  DialogGetById( p_interaction, i_id );
     if( !p_dialog )
     {
-        vlc_mutex_unlock( &p_interaction->object_lock ) ;
-        return VLC_TRUE;
+        vlc_object_unlock( p_interaction ) ;
+        vlc_object_release( p_interaction );
+        return true;
     }
 
     b_cancel = p_dialog->b_cancelled;
-    vlc_mutex_unlock( &p_interaction->object_lock );
+    vlc_object_unlock( p_interaction );
+    vlc_object_release( p_interaction );
     return b_cancel;
 }
 
-/** Helper function to make a login/password dialogue
- *  \param p_this           Parent vlc_object
- *  \param psz_title        Title for the dialog
- *  \param psz_description  A description
- *  \param ppsz_login       Returned login
- *  \param ppsz_password    Returned password
- *  \return                 Clicked button code
+/**
+ * Helper function to make a login/password dialogue
+ *
+ * \param p_this           Parent vlc_object
+ * \param psz_title        Title for the dialog
+ * \param psz_description  A description
+ * \param ppsz_login       Returned login
+ * \param ppsz_password    Returned password
+ * \return                 Clicked button code
  */
 int __intf_UserLoginPassword( vlc_object_t *p_this,
-                              const char *psz_title,
-                              const char *psz_description,
-                              char **ppsz_login,
-                              char **ppsz_password )
+        const char *psz_title,
+        const char *psz_description,
+        char **ppsz_login,
+        char **ppsz_password )
 {
     int i_ret;
     DIALOG_INIT( TWOWAY );
     p_new->i_type = INTERACT_DIALOG_TWOWAY;
     p_new->psz_title = strdup( psz_title );
     p_new->psz_description = strdup( psz_description );
-    p_new->psz_default_button = strdup( _("Ok" ) );
+    p_new->psz_default_button = strdup( _("OK" ) );
     p_new->psz_alternate_button = strdup( _("Cancel" ) );
 
     p_new->i_flags = DIALOG_LOGIN_PW_OK_CANCEL;
@@ -374,24 +286,26 @@ int __intf_UserLoginPassword( vlc_object_t *p_this,
     if( i_ret != DIALOG_CANCELLED && i_ret != VLC_EGENERIC )
     {
         *ppsz_login = p_new->psz_returned[0]?
-                                strdup( p_new->psz_returned[0] ) : NULL;
+            strdup( p_new->psz_returned[0] ) : NULL;
         *ppsz_password = p_new->psz_returned[1]?
-                                strdup( p_new->psz_returned[1] ) : NULL;
+            strdup( p_new->psz_returned[1] ) : NULL;
     }
     return i_ret;
 }
 
-/** Helper function to make a dialogue asking the user for !password string
- *  \param p_this           Parent vlc_object
- *  \param psz_title        Title for the dialog
- *  \param psz_description  A description
- *  \param ppsz_usersString Returned login
- *  \return                 Clicked button code
+/**
+ * Helper function to make a dialogue asking the user for !password string
+ *
+ * \param p_this           Parent vlc_object
+ * \param psz_title        Title for the dialog
+ * \param psz_description  A description
+ * \param ppsz_usersString Returned login
+ * \return                 Clicked button code
  */
 int __intf_UserStringInput( vlc_object_t *p_this,
-                              const char *psz_title,
-                              const char *psz_description,
-                              char **ppsz_usersString )
+        const char *psz_title,
+        const char *psz_description,
+        char **ppsz_usersString )
 {
     int i_ret;
     DIALOG_INIT( TWOWAY );
@@ -406,12 +320,14 @@ int __intf_UserStringInput( vlc_object_t *p_this,
     if( i_ret != DIALOG_CANCELLED )
     {
         *ppsz_usersString = p_new->psz_returned[0]?
-                                    strdup( p_new->psz_returned[0] ) : NULL;
+            strdup( p_new->psz_returned[0] ) : NULL;
     }
     return i_ret;
 }
 
-/** Hide an interaction dialog
+/**
+ * Hide an interaction dialog
+ *
  * \param p_this the parent vlc object
  * \param i_id the id of the item to hide
  * \return nothing
@@ -423,60 +339,82 @@ void __intf_UserHide( vlc_object_t *p_this, int i_id )
 
     if( !p_interaction ) return;
 
-    vlc_mutex_lock( &p_interaction->object_lock );
+    vlc_object_lock( p_interaction );
     p_dialog = DialogGetById( p_interaction, i_id );
 
-    if( !p_dialog )
+    if( p_dialog )
     {
-       vlc_mutex_unlock( &p_interaction->object_lock );
-       return;
+        p_dialog->i_status = ANSWERED_DIALOG;
+        vlc_object_signal_unlocked( p_interaction );
     }
 
-    p_dialog->i_status = ANSWERED_DIALOG;
-    vlc_mutex_unlock( &p_interaction->object_lock );
+    vlc_object_unlock( p_interaction );
+    vlc_object_release( p_interaction );
 }
 
-/**********************************************************************
- * The following functions are local
- **********************************************************************/
-
-/* Get the interaction object. Create it if needed */
-static interaction_t * InteractionGet( vlc_object_t *p_this )
+/**
+ * Create the initial interaction object
+ * (should only be used in libvlc_InternalInit, LibVLC private)
+ *
+ * \return a vlc_object_t that should be freed when done.
+ */
+interaction_t * interaction_Init( libvlc_int_t *p_libvlc )
 {
     interaction_t *p_interaction;
-    playlist_t *p_playlist = pl_Yield( p_this );
 
-    PL_LOCK;
-    if( p_playlist->p_interaction == NULL )
-       InteractionInit( p_playlist );
+    /* Make sure we haven't yet created an interaction object */
+    assert( libvlc_priv(p_libvlc)->p_interaction == NULL );
+
+    p_interaction = vlc_custom_create( VLC_OBJECT(p_libvlc),
+                                       sizeof( *p_interaction ),
+                                       VLC_OBJECT_GENERIC, "interaction" );
+    if( !p_interaction )
+        return NULL;
+
+    vlc_object_attach( p_interaction, p_libvlc );
+    p_interaction->i_dialogs = 0;
+    p_interaction->pp_dialogs = NULL;
+    p_interaction->p_intf = NULL;
+    p_interaction->i_last_id = 0;
 
-    p_interaction = p_playlist->p_interaction;
-    PL_UNLOCK;
+    if( vlc_thread_create( p_interaction, "Interaction control",
+                           InteractionLoop, VLC_THREAD_PRIORITY_LOW,
+                           false ) )
+    {
+        msg_Err( p_interaction, "Interaction control thread creation failed, "
+                 "interaction will not be displayed" );
+        vlc_object_detach( p_interaction );
+        vlc_object_release( p_interaction );
+        return NULL;
+    }
 
-    pl_Release( p_this );
     return p_interaction;
 }
 
-/* Create the interaction object in the given playlist object */
-static void InteractionInit( playlist_t *p_playlist )
+void interaction_Destroy( interaction_t *p_interaction )
 {
-    interaction_t *p_interaction = vlc_object_create( VLC_OBJECT( p_playlist ),
-                                                      sizeof( interaction_t ) );
     if( !p_interaction )
-    {
-        msg_Err( p_playlist,"out of memory" );
         return;
-    }
 
-    p_interaction->i_dialogs = 0;
-    p_interaction->pp_dialogs = NULL;
-    p_interaction->p_intf = NULL;
-    p_interaction->i_last_id = 0;
+    vlc_object_kill( p_interaction );
+    vlc_thread_join( p_interaction );
+    vlc_object_release( p_interaction );
+}
+
+/**********************************************************************
+ * The following functions are local
+ **********************************************************************/
 
-    vlc_mutex_init( p_interaction , &p_interaction->object_lock );
-    p_playlist->p_interaction  = p_interaction;
+/* Get the interaction object. Create it if needed */
+static interaction_t * InteractionGet( vlc_object_t *p_this )
+{
+    interaction_t *obj = libvlc_priv(p_this->p_libvlc)->p_interaction;
+    if( obj )
+        vlc_object_hold( obj );
+    return obj;
 }
 
+
 /* Look for an interface suitable for interaction */
 static void InteractionSearchInterface( interaction_t *p_interaction )
 {
@@ -535,27 +473,36 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
 {
     interaction_t *p_interaction = InteractionGet( p_this );
 
+    if( !p_interaction )
+        return VLC_EGENERIC;
+
     /* Get an id, if we don't already have one */
+    vlc_object_lock( p_interaction );
     if( p_dialog->i_id == 0 )
         p_dialog->i_id = ++p_interaction->i_last_id;
+    vlc_object_unlock( p_interaction );
 
-    if( p_this->i_flags & OBJECT_FLAGS_NOINTERACT ) return VLC_EGENERIC;
+    if( p_this->i_flags & OBJECT_FLAGS_NOINTERACT )
+    {
+        vlc_object_release( p_interaction );
+        return VLC_EGENERIC;
+    }
 
-    if( config_GetInt(p_this, "interact") ||
+    if( config_GetInt( p_this, "interact" ) ||
         p_dialog->i_flags & DIALOG_BLOCKING_ERROR ||
         p_dialog->i_flags & DIALOG_NONBLOCKING_ERROR )
     {
-        vlc_bool_t b_found = VLC_FALSE;
+        bool b_found = false;
         int i;
         p_dialog->p_interaction = p_interaction;
         p_dialog->p_parent = p_this;
 
         /* Check if we have already added this dialog */
-        vlc_mutex_lock( &p_interaction->object_lock );
+        vlc_object_lock( p_interaction );
         for( i = 0 ; i< p_interaction->i_dialogs; i++ )
         {
             if( p_interaction->pp_dialogs[i]->i_id == p_dialog->i_id )
-                b_found = VLC_TRUE;
+                b_found = true;
         }
         /* Add it to the queue, the main loop will send the orders to the
          * interface */
@@ -569,17 +516,17 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
         else
             p_dialog->i_status = UPDATED_DIALOG;
 
-        if( p_dialog->i_type == INTERACT_DIALOG_TWOWAY ) // Wait for answer
+        if( p_dialog->i_type == INTERACT_DIALOG_TWOWAY ) /* Wait for answer */
         {
-            playlist_Signal( pl_Get( p_this ) );
+            vlc_object_signal_unlocked( p_interaction );
             while( p_dialog->i_status != ANSWERED_DIALOG &&
                    p_dialog->i_status != HIDING_DIALOG &&
                    p_dialog->i_status != HIDDEN_DIALOG &&
                    !p_dialog->p_parent->b_die )
             {
-                vlc_mutex_unlock( &p_interaction->object_lock );
+                vlc_object_unlock( p_interaction );
                 msleep( 100000 );
-                vlc_mutex_lock( &p_interaction->object_lock );
+                vlc_object_lock( p_interaction );
             }
             if( p_dialog->p_parent->b_die )
             {
@@ -587,19 +534,132 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
                 p_dialog->i_status = ANSWERED_DIALOG;
             }
             p_dialog->i_flags |= DIALOG_GOT_ANSWER;
-            vlc_mutex_unlock( &p_interaction->object_lock );
-            playlist_Signal( pl_Get( p_this ) );
+            vlc_object_signal_unlocked( p_interaction );
+            vlc_object_unlock( p_interaction );
+            vlc_object_release( p_interaction );
             return p_dialog->i_return;
         }
         else
         {
-            // Pretend we already retrieved the "answer"
+            /* Pretend we already retrieved the "answer" */
             p_dialog->i_flags |=  DIALOG_GOT_ANSWER;
-            vlc_mutex_unlock( &p_interaction->object_lock );
-            playlist_Signal( pl_Get( p_this ) );
+            vlc_object_signal_unlocked( p_interaction );
+            vlc_object_unlock( p_interaction );
+            vlc_object_release( p_interaction );
             return VLC_SUCCESS;
         }
     }
     else
+    {
+        vlc_object_release( p_interaction );
         return VLC_EGENERIC;
+    }
+}
+
+static void* InteractionLoop( vlc_object_t *p_this )
+{
+    interaction_t *p_interaction = (interaction_t*) p_this;
+    int canc = vlc_savecancel ();
+
+    vlc_object_lock( p_this );
+    while( vlc_object_alive( p_this ) )
+    {
+        InteractionManage( p_interaction );
+        vlc_object_wait( p_this );
+    }
+    vlc_object_unlock( p_this );
+
+    /* Remove all dialogs - Interfaces must be able to clean up their data */
+    for( int i = p_interaction->i_dialogs -1 ; i >= 0; i-- )
+    {
+        interaction_dialog_t * p_dialog = p_interaction->pp_dialogs[i];
+        DialogDestroy( p_dialog );
+        REMOVE_ELEM( p_interaction->pp_dialogs, p_interaction->i_dialogs, i );
+    }
+    vlc_restorecancel (canc);
+    return NULL;
+}
+
+/**
+ * The main interaction processing loop
+ *
+ * \param p_interaction the interaction object
+ * \return nothing
+ */
+
+static void InteractionManage( interaction_t *p_interaction )
+{
+    vlc_value_t val;
+    int i_index;
+
+    /* Nothing to do */
+    if( p_interaction->i_dialogs == 0 ) return;
+
+    InteractionSearchInterface( p_interaction );
+    if( !p_interaction->p_intf )
+    {
+        /* We mark all dialogs as answered with their "default" answer */
+        for( i_index = 0 ; i_index < p_interaction->i_dialogs; i_index ++ )
+        {
+            interaction_dialog_t *p_dialog = p_interaction->pp_dialogs[i_index];
+            p_dialog->i_return = DIALOG_DEFAULT; /* Give default answer */
+
+            /* Pretend we have hidden and destroyed it */
+            if( p_dialog->i_status == HIDDEN_DIALOG )
+                p_dialog->i_status = DESTROYED_DIALOG;
+            else
+                p_dialog->i_status = HIDING_DIALOG;
+        }
+    }
+    else
+        vlc_object_hold( p_interaction->p_intf );
+
+    for( i_index = 0 ; i_index < p_interaction->i_dialogs; i_index ++ )
+    {
+        interaction_dialog_t *p_dialog = p_interaction->pp_dialogs[i_index];
+        switch( p_dialog->i_status )
+        {
+        case ANSWERED_DIALOG:
+            /* Ask interface to hide it */
+            p_dialog->i_action = INTERACT_HIDE;
+            val.p_address = p_dialog;
+            if( p_interaction->p_intf )
+                var_Set( p_interaction->p_intf, "interaction", val );
+            p_dialog->i_status = HIDING_DIALOG;
+            break;
+        case UPDATED_DIALOG:
+            p_dialog->i_action = INTERACT_UPDATE;
+            val.p_address = p_dialog;
+            if( p_interaction->p_intf )
+                var_Set( p_interaction->p_intf, "interaction", val );
+            p_dialog->i_status = SENT_DIALOG;
+            break;
+        case HIDDEN_DIALOG:
+            if( !(p_dialog->i_flags & DIALOG_GOT_ANSWER) ) break;
+            p_dialog->i_action = INTERACT_DESTROY;
+            val.p_address = p_dialog;
+            if( p_interaction->p_intf )
+                var_Set( p_interaction->p_intf, "interaction", val );
+            break;
+        case DESTROYED_DIALOG:
+            /* Interface has now destroyed it, remove it */
+            REMOVE_ELEM( p_interaction->pp_dialogs, p_interaction->i_dialogs,
+                         i_index);
+            i_index--;
+            DialogDestroy( p_dialog );
+            break;
+        case NEW_DIALOG:
+            /* This is truly a new dialog, send it. */
+
+            p_dialog->i_action = INTERACT_NEW;
+            val.p_address = p_dialog;
+            if( p_interaction->p_intf )
+                var_Set( p_interaction->p_intf, "interaction", val );
+            p_dialog->i_status = SENT_DIALOG;
+            break;
+        }
+    }
+
+    if( p_interaction->p_intf )
+        vlc_object_release( p_interaction->p_intf );
 }