Move __wgetmainargs into VLC's main.

[vlc] / src / libvlc-common.c

diff --git a/src/libvlc-common.c b/src/libvlc-common.c
index f21bf9f92ab8e581a33a9694697cd323eb60d198..b850e923ab7a5b8004401453cc250d51e27633d3 100644 (file)
--- a/src/libvlc-common.c
+++ b/src/libvlc-common.c
@@ -1215,7 +1215,6 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, char *ppsz_argv[] )
 
         /* TODO: write an internal function of this one, to avoid
          *       unnecessary lookups. */
-        /* FIXME: should we convert options to UTF-8 as well ?? */
 
 #ifdef WIN32
         if( GetVersion() < 0x80000000 )
@@ -1228,6 +1227,9 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, char *ppsz_argv[] )
         else
 #endif
         {
+            /* FIXME: it's too late to call FromLocale here. We should
+               convert ALL arguments to UTF8 before they get parsed */
+
             psz_target = FromLocale( ppsz_argv[ i_opt ] );
             VLC_AddTarget( p_vlc->i_object_id, psz_target,
                        (char const **)( i_options ? &ppsz_argv[i_opt + 1] :