]> git.sesse.net Git - vlc/blobdiff - src/misc/configuration.c
Fix typo
[vlc] / src / misc / configuration.c
index b6c8ff91045430fb7dc7b1d622efcf16f21f4f0c..212e1599d0c5ff11c18e9c0b5f03f545cdbec8aa 100644 (file)
 #include <string.h>                                              /* strdup() */
 #include <errno.h>                                                  /* errno */
 
+#ifdef HAVE_LIMITS_H
+#   include <limits.h>
+#endif
+
 #ifdef HAVE_UNISTD_H
 #    include <unistd.h>                                          /* getuid() */
 #endif
@@ -59,7 +63,6 @@
 #include <tchar.h>
 #endif
 
-
 static int ConfigStringToKey( char * );
 static char *ConfigKeyToString( int );
 
@@ -480,7 +483,7 @@ module_t *config_FindModule( vlc_object_t *p_this, const char *psz_name )
  * this module might be unloaded from memory at any time (remember HideModule).
  * This is why we need to create an exact copy of the config data.
  *****************************************************************************/
-void config_Duplicate( module_t *p_module, module_config_t *p_orig )
+void config_Duplicate( module_t *p_module, const module_config_t *p_orig )
 {
     int i, j, i_lines = 1;
     module_config_t *p_item;
@@ -717,7 +720,7 @@ void __config_ResetAll( vlc_object_t *p_this )
     module_t *p_module;
 
     /* Acquire config file lock */
-    vlc_mutex_lock( &p_this->p_vlc->config_lock );
+    vlc_mutex_lock( &p_this->p_libvlc->config_lock );
 
     p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE );
 
@@ -739,7 +742,7 @@ void __config_ResetAll( vlc_object_t *p_this )
     }
 
     vlc_list_release( p_list );
-    vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+    vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
 }
 
 /*****************************************************************************
@@ -759,10 +762,10 @@ int __config_LoadConfigFile( vlc_object_t *p_this, const char *psz_module_name )
     char *psz_filename, *psz_homedir, *psz_configfile;
     int i_index;
 
-    psz_configfile = p_this->p_vlc->psz_configfile;
+    psz_configfile = p_this->p_libvlc->psz_configfile;
     if( !psz_configfile || !psz_configfile )
     {
-        psz_homedir = p_this->p_vlc->psz_homedir;
+        psz_homedir = p_this->p_libvlc->psz_homedir;
         if( !psz_homedir )
         {
             msg_Err( p_this, "psz_homedir is null" );
@@ -771,7 +774,8 @@ int __config_LoadConfigFile( vlc_object_t *p_this, const char *psz_module_name )
         psz_filename = (char *)malloc( sizeof("/" CONFIG_DIR "/" CONFIG_FILE) +
                                        strlen(psz_homedir) );
         if( psz_filename )
-            sprintf( psz_filename, "%s/" CONFIG_DIR "/" CONFIG_FILE,
+            sprintf( psz_filename,
+                     "%s" DIR_SEP CONFIG_DIR DIR_SEP CONFIG_FILE,
                      psz_homedir );
     }
     else
@@ -788,14 +792,14 @@ int __config_LoadConfigFile( vlc_object_t *p_this, const char *psz_module_name )
     msg_Dbg( p_this, "opening config file %s", psz_filename );
 
     /* Acquire config file lock */
-    vlc_mutex_lock( &p_this->p_vlc->config_lock );
+    vlc_mutex_lock( &p_this->p_libvlc->config_lock );
 
     file = utf8_fopen( psz_filename, "rt" );
     if( !file )
     {
         msg_Warn( p_this, "config file %s does not exist yet", psz_filename );
         free( psz_filename );
-        vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+        vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
         return -1;
     }
 
@@ -890,7 +894,7 @@ int __config_LoadConfigFile( vlc_object_t *p_this, const char *psz_module_name )
                     case CONFIG_ITEM_FLOAT:
                         if( !*psz_option_value )
                             break;                    /* ignore empty option */
-                        p_item->f_value = (float)atof( psz_option_value);
+                        p_item->f_value = (float)i18n_atof( psz_option_value);
                         p_item->f_value_saved = p_item->f_value;
 #if 0
                         msg_Dbg( p_this, "option \"%s\", value %f",
@@ -943,7 +947,7 @@ int __config_LoadConfigFile( vlc_object_t *p_this, const char *psz_module_name )
     fclose( file );
     free( psz_filename );
 
-    vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+    vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
 
     return 0;
 }
@@ -999,34 +1003,34 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
     int i_index;
 
     /* Acquire config file lock */
-    vlc_mutex_lock( &p_this->p_vlc->config_lock );
+    vlc_mutex_lock( &p_this->p_libvlc->config_lock );
 
-    psz_configfile = p_this->p_vlc->psz_configfile;
+    psz_configfile = p_this->p_libvlc->psz_configfile;
     if( !psz_configfile || !psz_configfile )
     {
-        psz_homedir = p_this->p_vlc->psz_homedir;
+        psz_homedir = p_this->p_libvlc->psz_homedir;
         if( !psz_homedir )
         {
             msg_Err( p_this, "psz_homedir is null" );
-            vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+            vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
             return -1;
         }
         psz_filename = (char *)malloc( sizeof("/" CONFIG_DIR "/" CONFIG_FILE) +
                                        strlen(psz_homedir) );
 
         if( psz_filename )
-            sprintf( psz_filename, "%s/" CONFIG_DIR, psz_homedir );
+            sprintf( psz_filename, "%s" DIR_SEP CONFIG_DIR, psz_homedir );
 
         if( !psz_filename )
         {
             msg_Err( p_this, "out of memory" );
-            vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+            vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
             return -1;
         }
 
         config_CreateDir( p_this, psz_filename );
 
-        strcat( psz_filename, "/" CONFIG_FILE );
+        strcat( psz_filename, DIR_SEP CONFIG_FILE );
     }
     else
     {
@@ -1034,7 +1038,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
         if( !psz_filename )
         {
             msg_Err( p_this, "out of memory" );
-            vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+            vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
             return -1;
         }
     }
@@ -1060,7 +1064,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
         msg_Err( p_this, "out of memory" );
         if( file ) fclose( file );
         free( psz_filename );
-        vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+        vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
         return -1;
     }
     p_bigbuffer[0] = 0;
@@ -1136,7 +1140,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
                           psz_filename );
         free( psz_filename );
         vlc_list_release( p_list );
-        vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+        vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
         return -1;
     }
 
@@ -1161,7 +1165,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
 
         fprintf( file, "[%s]", p_parser->psz_object_name );
         if( p_parser->psz_longname )
-            fprintf( file, " # %s\n\n", p_parser->psz_longname );
+            utf8_fprintf( file, " # %s\n\n", p_parser->psz_longname );
         else
             fprintf( file, "\n\n" );
 
@@ -1180,6 +1184,10 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
             /* Ignore deprecated options */
             if( p_item->psz_current )
                 continue;
+            if( p_item->b_unsaveable )
+                /*obvious*/
+                continue;
+            
             if( b_autosave && !p_item->b_autosave )
             {
                 i_value = p_item->i_value_saved;
@@ -1197,7 +1205,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
             case CONFIG_ITEM_BOOL:
             case CONFIG_ITEM_INTEGER:
                 if( p_item->psz_text )
-                    fprintf( file, "# %s (%s)\n", p_item->psz_text,
+                    utf8_fprintf( file, "# %s (%s)\n", p_item->psz_text,
                              (p_item->i_type == CONFIG_ITEM_BOOL) ?
                              _("boolean") : _("integer") );
                 if( i_value == p_item->i_value_orig )
@@ -1209,7 +1217,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
 
             case CONFIG_ITEM_KEY:
                 if( p_item->psz_text )
-                    fprintf( file, "# %s (%s)\n", p_item->psz_text,
+                    utf8_fprintf( file, "# %s (%s)\n", p_item->psz_text,
                              _("key") );
                 if( i_value == p_item->i_value_orig )
                     fprintf( file, "#" );
@@ -1223,7 +1231,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
 
             case CONFIG_ITEM_FLOAT:
                 if( p_item->psz_text )
-                    fprintf( file, "# %s (%s)\n", p_item->psz_text,
+                    utf8_fprintf( file, "# %s (%s)\n", p_item->psz_text,
                              _("float") );
                 if( f_value == p_item->f_value_orig )
                     fprintf( file, "#" );
@@ -1234,7 +1242,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
 
             default:
                 if( p_item->psz_text )
-                    fprintf( file, "# %s (%s)\n", p_item->psz_text,
+                    utf8_fprintf( file, "# %s (%s)\n", p_item->psz_text,
                              _("string") );
                 if( (!psz_value && !p_item->psz_value_orig) ||
                     (psz_value && p_item->psz_value_orig &&
@@ -1267,7 +1275,7 @@ static int SaveConfigFile( vlc_object_t *p_this, const char *psz_module_name,
 
     fclose( file );
     free( psz_filename );
-    vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+    vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
 
     return 0;
 }
@@ -1280,7 +1288,7 @@ int config_AutoSaveConfigFile( vlc_object_t *p_this )
     int i_index, i_count;
 
     /* Check if there's anything to save */
-    vlc_mutex_lock( &p_this->p_vlc->config_lock );
+    vlc_mutex_lock( &p_this->p_libvlc->config_lock );
     p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE );
     i_count = p_list->i_count;
     for( i_index = 0; i_index < i_count; i_index++ )
@@ -1298,7 +1306,7 @@ int config_AutoSaveConfigFile( vlc_object_t *p_this )
         if( p_item->i_type != CONFIG_HINT_END ) break;
     }
     vlc_list_release( p_list );
-    vlc_mutex_unlock( &p_this->p_vlc->config_lock );
+    vlc_mutex_unlock( &p_this->p_libvlc->config_lock );
 
     if( i_index == i_count ) return VLC_SUCCESS;
     return SaveConfigFile( p_this, 0, VLC_TRUE );
@@ -1333,11 +1341,11 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
     char *psz_shortopts;
 
     /* Set default configuration and copy arguments */
-    p_this->p_vlc->i_argc    = *pi_argc;
-    p_this->p_vlc->ppsz_argv = ppsz_argv;
+    p_this->p_libvlc->i_argc    = *pi_argc;
+    p_this->p_libvlc->ppsz_argv = ppsz_argv;
 
 #ifdef __APPLE__
-    /* When vlc.app is run by double clicking in Mac OS X, the 2nd arg
+    /* When VLC.app is run by double clicking in Mac OS X, the 2nd arg
      * is the PSN - process serial number (a unique PID-ish thingie)
      * still ok for real Darwin & when run from command line */
     if ( (*pi_argc > 1) && (strncmp( ppsz_argv[ 1 ] , "-psn" , 4 ) == 0) )
@@ -1370,7 +1378,7 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
         p_parser = (module_t *)p_list->p_values[i_modules_index].p_object ;
 
         /* count the number of exported configuration options (to allocate
-         * longopts). We also need to allocate space for too options when
+         * longopts). We also need to allocate space for two options when
          * dealing with boolean to allow for --foo and --no-foo */
         i_opts += p_parser->i_config_items
                      + 2 * p_parser->i_bool_items;
@@ -1407,7 +1415,7 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
             vlc_list_release( p_list );
             return -1;
         }
-        memcpy( ppsz_argv, p_this->p_vlc->ppsz_argv,
+        memcpy( ppsz_argv, p_this->p_libvlc->ppsz_argv,
                 *pi_argc * sizeof(char *) );
     }
 
@@ -1559,83 +1567,83 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
                     p_conf = config_FindConfig( p_this, psz_name );
                 }
 
-            switch( p_conf->i_type )
+                switch( p_conf->i_type )
+                {
+                    case CONFIG_ITEM_STRING:
+                    case CONFIG_ITEM_FILE:
+                    case CONFIG_ITEM_DIRECTORY:
+                    case CONFIG_ITEM_MODULE:
+                    case CONFIG_ITEM_MODULE_LIST:
+                    case CONFIG_ITEM_MODULE_LIST_CAT:
+                    case CONFIG_ITEM_MODULE_CAT:
+                        config_PutPsz( p_this, psz_name, optarg );
+                        break;
+                    case CONFIG_ITEM_INTEGER:
+                        config_PutInt( p_this, psz_name, strtol(optarg, 0, 0));
+                        break;
+                    case CONFIG_ITEM_FLOAT:
+                        config_PutFloat( p_this, psz_name, (float)atof(optarg) );
+                        break;
+                    case CONFIG_ITEM_KEY:
+                        config_PutInt( p_this, psz_name, ConfigStringToKey( optarg ) );
+                        break;
+                    case CONFIG_ITEM_BOOL:
+                        config_PutInt( p_this, psz_name, !flag );
+                        break;
+                }
+                continue;
+            }
+        }
+
+        /* A short option has been recognized */
+        if( pp_shortopts[i_cmd] != NULL )
+        {
+            switch( pp_shortopts[i_cmd]->i_type )
             {
                 case CONFIG_ITEM_STRING:
                 case CONFIG_ITEM_FILE:
                 case CONFIG_ITEM_DIRECTORY:
                 case CONFIG_ITEM_MODULE:
+                case CONFIG_ITEM_MODULE_CAT:
                 case CONFIG_ITEM_MODULE_LIST:
                 case CONFIG_ITEM_MODULE_LIST_CAT:
-                case CONFIG_ITEM_MODULE_CAT:
-                    config_PutPsz( p_this, psz_name, optarg );
+                    config_PutPsz( p_this, pp_shortopts[i_cmd]->psz_name, optarg );
                     break;
                 case CONFIG_ITEM_INTEGER:
-                    config_PutInt( p_this, psz_name, strtol(optarg, 0, 0));
-                    break;
-                case CONFIG_ITEM_FLOAT:
-                    config_PutFloat( p_this, psz_name, (float)atof(optarg) );
-                    break;
-                case CONFIG_ITEM_KEY:
-                    config_PutInt( p_this, psz_name, ConfigStringToKey( optarg ) );
-                    break;
-                case CONFIG_ITEM_BOOL:
-                    config_PutInt( p_this, psz_name, !flag );
-                    break;
-            }
-
-            continue;
-        }
-    }
-    /* A short option has been recognized */
-    if( pp_shortopts[i_cmd] != NULL )
-    {
-        switch( pp_shortopts[i_cmd]->i_type )
-        {
-            case CONFIG_ITEM_STRING:
-            case CONFIG_ITEM_FILE:
-            case CONFIG_ITEM_DIRECTORY:
-            case CONFIG_ITEM_MODULE:
-            case CONFIG_ITEM_MODULE_CAT:
-            case CONFIG_ITEM_MODULE_LIST:
-            case CONFIG_ITEM_MODULE_LIST_CAT:
-                config_PutPsz( p_this, pp_shortopts[i_cmd]->psz_name, optarg );
-                break;
-            case CONFIG_ITEM_INTEGER:
-                if( i_cmd == 'v' )
-                {
-                    if( optarg )
+                    if( i_cmd == 'v' )
                     {
-                        if( *optarg == 'v' ) /* eg. -vvv */
+                        if( optarg )
                         {
-                            i_verbose++;
-                            while( *optarg == 'v' )
+                            if( *optarg == 'v' ) /* eg. -vvv */
                             {
                                 i_verbose++;
-                                optarg++;
+                                while( *optarg == 'v' )
+                                {
+                                    i_verbose++;
+                                    optarg++;
+                                }
+                            }
+                            else
+                            {
+                                i_verbose += atoi( optarg ); /* eg. -v2 */
                             }
                         }
                         else
                         {
-                            i_verbose += atoi( optarg ); /* eg. -v2 */
+                            i_verbose++; /* -v */
                         }
+                        config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name,
+                                               i_verbose );
                     }
                     else
                     {
-                        i_verbose++; /* -v */
+                        config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name,
+                                               strtol(optarg, 0, 0) );
                     }
-                    config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name,
-                                           i_verbose );
-                }
-                else
-                {
-                    config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name,
-                                           strtol(optarg, 0, 0) );
-                }
-                break;
-            case CONFIG_ITEM_BOOL:
-                config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name, 1 );
-                break;
+                    break;
+                case CONFIG_ITEM_BOOL:
+                    config_PutInt( p_this, pp_shortopts[i_cmd]->psz_name, 1 );
+                    break;
             }
 
             continue;
@@ -1646,7 +1654,7 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
         {
             fprintf( stderr, "%s: unknown option"
                      " or missing mandatory argument ",
-                     p_this->p_vlc->psz_object_name );
+                     p_this->p_libvlc->psz_object_name );
             if( optopt )
             {
                 fprintf( stderr, "`-%c'\n", optopt );
@@ -1656,7 +1664,7 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
                 fprintf( stderr, "`%s'\n", ppsz_argv[optind-1] );
             }
             fprintf( stderr, "Try `%s --help' for more information.\n",
-                             p_this->p_vlc->psz_object_name );
+                             p_this->p_libvlc->psz_object_name );
 
             for( i_index = 0; p_longopts[i_index].name; i_index++ )
                 free( (char *)p_longopts[i_index].name );
@@ -1676,6 +1684,30 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
     return 0;
 }
 
+/**
+ * config_GetDataDir: find directory where shared data is installed
+ *
+ * @return a string (always succeeds).
+ */
+const char *config_GetDataDir( const vlc_object_t *p_this )
+{
+#if defined (WIN32) || defined (UNDER_CE)
+    return p_this->p_libvlc_global->psz_vlcpath;
+#elif defined(__APPLE__) || defined (SYS_BEOS)
+    static char path[PATH_MAX] = "";
+
+    if( *path == '\0' )
+    {
+        snprintf( path, sizeof( path ), "%s/share",
+                  p_this->p_libvlc_global->psz_vlcpath );
+        path[sizeof( path ) - 1] = '\0';
+    }
+    return path;
+#else
+    return DATA_PATH;
+#endif
+}
+
 /*****************************************************************************
  * config_GetHomeDir, config_GetUserDir: find the user's home directory.
  *****************************************************************************
@@ -1685,7 +1717,7 @@ int __config_LoadCmdLine( vlc_object_t *p_this, int *pi_argc, char *ppsz_argv[],
  *****************************************************************************/
 static char *GetDir( vlc_bool_t b_appdata )
 {
-    char *psz_localhome = NULL;
+    const char *psz_localhome = NULL;
 
 #if defined(HAVE_GETPWUID)
     struct passwd *p_pw = NULL;
@@ -1693,7 +1725,7 @@ static char *GetDir( vlc_bool_t b_appdata )
 
 #if defined(WIN32) && !defined(UNDER_CE)
     typedef HRESULT (WINAPI *SHGETFOLDERPATH)( HWND, int, HANDLE, DWORD,
-                                               LPSTR );
+                                               LPWSTR );
 #ifndef CSIDL_FLAG_CREATE
 #   define CSIDL_FLAG_CREATE 0x8000
 #endif
@@ -1714,20 +1746,20 @@ static char *GetDir( vlc_bool_t b_appdata )
     if( ( shfolder_dll = LoadLibrary( _T("SHFolder.dll") ) ) != NULL )
     {
         SHGetFolderPath = (void *)GetProcAddress( shfolder_dll,
-                                                  _T("SHGetFolderPathA") );
+                                                  _T("SHGetFolderPathW") );
         if ( SHGetFolderPath != NULL )
         {
-            char psz_ACPhome[MAX_PATH];
+            wchar_t whomedir[MAX_PATH];
 
             /* get the "Application Data" folder for the current user */
             if( S_OK == SHGetFolderPath( NULL,
                                          (b_appdata ? CSIDL_APPDATA :
                                            CSIDL_PROFILE) | CSIDL_FLAG_CREATE,
                                          NULL, SHGFP_TYPE_CURRENT,
-                                         psz_ACPhome ) )
+                                         whomedir ) )
             {
                 FreeLibrary( shfolder_dll );
-                return FromLocaleDup( psz_ACPhome );
+                return FromWide( whomedir );
             }
         }
         FreeLibrary( shfolder_dll );
@@ -1739,16 +1771,11 @@ static char *GetDir( vlc_bool_t b_appdata )
 #   define CSIDL_APPDATA 0x1A
 #endif
 
-    wchar_t p_whomedir[MAX_PATH];
+    wchar_t whomedir[MAX_PATH];
 
     /* get the "Application Data" folder for the current user */
-    if( SHGetSpecialFolderPath( NULL, p_whomedir, CSIDL_APPDATA, 1 ) )
-    {
-        char psz_ACPhome[2 * MAX_PATH];
-
-        sprintf( psz_ACPhome, "%ls", p_whomedir );
-        return FromLocaleDup( p_ACPhome );
-    }
+    if( SHGetSpecialFolderPath( NULL, whomedir, CSIDL_APPDATA, 1 ) )
+        return FromWide( whomedir );
 #endif
 
 #if defined(HAVE_GETPWUID)