/*****************************************************************************
* objects.c: vlc_object_t handling
*****************************************************************************
- * Copyright (C) 2004-2008 the VideoLAN team
+ * Copyright (C) 2004-2008 VLC authors and VideoLAN
+ * Copyright (C) 2006-2010 Rémi Denis-Courmont
*
* Authors: Samuel Hocevar <sam@zoy.org>
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
*****************************************************************************/
/**
#include <vlc_common.h>
#include "../libvlc.h"
-#include <vlc_vout.h>
#include <vlc_aout.h>
#include "audio_output/aout_internal.h"
-#include <vlc_access.h>
-#include <vlc_demux.h>
-#include <vlc_stream.h>
-
-#include <vlc_sout.h>
-#include "stream_output/stream_output.h"
-
#include "vlc_interface.h"
#include "vlc_codec.h"
-#include "vlc_filter.h"
#include "variables.h"
-#ifndef WIN32
-# include <unistd.h>
-#else
+
+#ifdef HAVE_SEARCH_H
+# include <search.h>
+#endif
+
+#ifdef __OS2__
+# include <sys/socket.h>
+# include <netinet/in.h>
+# include <unistd.h> // close(), write()
+#elif defined(WIN32)
# include <io.h>
-# include <fcntl.h>
-# include <errno.h> /* ENOSYS */
+# include <winsock2.h>
+# include <ws2tcpip.h>
+# undef read
+# define read( a, b, c ) recv (a, b, c, 0)
+# undef write
+# define write( a, b, c ) send (a, b, c, 0)
+# undef close
+# define close( a ) closesocket (a)
+#else
+# include <vlc_fs.h>
+# include <unistd.h>
#endif
+
+#include <limits.h>
#include <assert.h>
+#if defined (HAVE_SYS_EVENTFD_H)
+# include <sys/eventfd.h>
+# ifndef EFD_CLOEXEC
+# define EFD_CLOEXEC 0
+# warning EFD_CLOEXEC missing. Consider updating libc.
+# endif
+#endif
+
+
/*****************************************************************************
* Local prototypes
*****************************************************************************/
static int DumpCommand( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
-static vlc_object_t * FindObject ( vlc_object_t *, int, int );
-static vlc_object_t * FindObjectName( vlc_object_t *, const char *, int );
-static void PrintObject ( vlc_object_t *, const char * );
-static void DumpStructure ( vlc_object_t *, int, char * );
+static vlc_object_t * FindName ( vlc_object_internals_t *, const char * );
+static void PrintObject( vlc_object_internals_t *, const char * );
+static void DumpStructure( vlc_object_internals_t *, unsigned, char * );
static vlc_list_t * NewList ( int );
-static void ListReplace ( vlc_list_t *, vlc_object_t *, int );
-/*static void ListAppend ( vlc_list_t *, vlc_object_t * );*/
-static int CountChildren ( vlc_object_t *, int );
-static void ListChildren ( vlc_list_t *, vlc_object_t *, int );
static void vlc_object_destroy( vlc_object_t *p_this );
-static void vlc_object_detach_unlocked (vlc_object_t *p_this);
-#ifndef NDEBUG
-static void vlc_object_dump( vlc_object_t *p_this );
-#endif
/*****************************************************************************
* Local structure lock
*****************************************************************************/
-static void close_nocancel (int fd)
-{
- int canc = vlc_savecancel ();
- close (fd);
- vlc_restorecancel (canc);
-}
-
static void libvlc_lock (libvlc_int_t *p_libvlc)
{
vlc_mutex_lock (&(libvlc_priv (p_libvlc)->structure_lock));
vlc_mutex_unlock (&(libvlc_priv (p_libvlc)->structure_lock));
}
-void *__vlc_custom_create( vlc_object_t *p_this, size_t i_size,
- int i_type, const char *psz_type )
+#undef vlc_custom_create
+void *vlc_custom_create (vlc_object_t *parent, size_t length,
+ const char *typename)
{
- vlc_object_t *p_new;
- vlc_object_internals_t *p_priv;
-
/* NOTE:
* VLC objects are laid out as follow:
* - first the LibVLC-private per-object data,
* This function initializes the LibVLC and common data,
* and zeroes the rest.
*/
- p_priv = calloc( 1, sizeof( *p_priv ) + i_size );
- if( p_priv == NULL )
- return NULL;
+ assert (length >= sizeof (vlc_object_t));
- assert (i_size >= sizeof (vlc_object_t));
- p_new = (vlc_object_t *)(p_priv + 1);
-
- p_new->i_object_type = i_type;
- p_new->psz_object_type = psz_type;
- p_new->psz_object_name = NULL;
-
- p_new->b_die = false;
- p_new->b_error = false;
- p_new->b_force = false;
-
- p_new->psz_header = NULL;
-
- if (p_this)
- p_new->i_flags = p_this->i_flags
- & (OBJECT_FLAGS_NODBG|OBJECT_FLAGS_QUIET|OBJECT_FLAGS_NOINTERACT);
-
- p_priv->p_vars = calloc( 16, sizeof( variable_t ) );
-
- if( !p_priv->p_vars )
- {
- free( p_priv );
+ vlc_object_internals_t *priv = malloc (sizeof (*priv) + length);
+ if (unlikely(priv == NULL))
return NULL;
+ priv->psz_name = NULL;
+ priv->var_root = NULL;
+ vlc_mutex_init (&priv->var_lock);
+ vlc_cond_init (&priv->var_wait);
+ priv->pipes[0] = priv->pipes[1] = -1;
+ vlc_spin_init (&priv->ref_spin);
+ priv->i_refcount = 1;
+ priv->pf_destructor = NULL;
+ priv->prev = NULL;
+ priv->first = NULL;
+
+ vlc_object_t *obj = (vlc_object_t *)(priv + 1);
+ obj->psz_object_type = typename;
+ obj->psz_header = NULL;
+ obj->b_die = false;
+ obj->b_force = false;
+ memset (obj + 1, 0, length - sizeof (*obj)); /* type-specific stuff */
+
+ if (likely(parent != NULL))
+ {
+ vlc_object_internals_t *papriv = vlc_internals (parent);
+
+ obj->i_flags = parent->i_flags;
+ obj->p_libvlc = parent->p_libvlc;
+
+ /* Attach the child to its parent (no lock needed) */
+ obj->p_parent = vlc_object_hold (parent);
+
+ /* Attach the parent to its child (structure lock needed) */
+ libvlc_lock (obj->p_libvlc);
+ priv->next = papriv->first;
+ if (priv->next != NULL)
+ priv->next->prev = priv;
+ papriv->first = priv;
+ libvlc_unlock (obj->p_libvlc);
}
-
- if( p_this == NULL )
+ else
{
- libvlc_int_t *self = (libvlc_int_t*)p_new;
- p_new->p_libvlc = self;
+ libvlc_int_t *self = (libvlc_int_t *)obj;
+
+ obj->i_flags = 0;
+ obj->p_libvlc = self;
+ obj->p_parent = NULL;
+ priv->next = NULL;
vlc_mutex_init (&(libvlc_priv (self)->structure_lock));
- p_this = p_priv->next = p_priv->prev = p_new;
- }
- else
- p_new->p_libvlc = p_this->p_libvlc;
-
- vlc_spin_init( &p_priv->ref_spin );
- p_priv->i_refcount = 1;
- p_priv->pf_destructor = NULL;
- p_priv->b_thread = false;
- p_new->p_parent = NULL;
- p_priv->pp_children = NULL;
- p_priv->i_children = 0;
-
- p_new->p_private = NULL;
-
- /* Initialize mutexes and condvars */
- vlc_mutex_init( &p_priv->lock );
- vlc_cond_init( &p_priv->wait );
- vlc_mutex_init( &p_priv->var_lock );
- vlc_cond_init( &p_priv->var_wait );
- vlc_spin_init( &p_priv->spin );
- p_priv->pipes[0] = p_priv->pipes[1] = -1;
-
- p_priv->next = p_this;
- libvlc_lock (p_new->p_libvlc);
- p_priv->prev = vlc_internals (p_this)->prev;
- vlc_internals (p_this)->prev = p_new;
- vlc_internals (p_priv->prev)->next = p_new;
- libvlc_unlock (p_new->p_libvlc);
-
- if (p_new == VLC_OBJECT(p_new->p_libvlc))
- { /* TODO: should be in src/libvlc.c */
+
+ /* TODO: should be in src/libvlc.c */
int canc = vlc_savecancel ();
- var_Create( p_new, "list", VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
- var_AddCallback( p_new, "list", DumpCommand, NULL );
- var_Create( p_new, "tree", VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
- var_AddCallback( p_new, "tree", DumpCommand, NULL );
- var_Create( p_new, "vars", VLC_VAR_STRING | VLC_VAR_ISCOMMAND );
- var_AddCallback( p_new, "vars", DumpCommand, NULL );
+ var_Create (obj, "tree", VLC_VAR_STRING | VLC_VAR_ISCOMMAND);
+ var_AddCallback (obj, "tree", DumpCommand, obj);
+ var_Create (obj, "vars", VLC_VAR_STRING | VLC_VAR_ISCOMMAND);
+ var_AddCallback (obj, "vars", DumpCommand, obj);
vlc_restorecancel (canc);
}
- return p_new;
+ return obj;
}
-
+#undef vlc_object_create
/**
* Allocates and initializes a vlc object.
*
- * @param i_type known object type (all of them are negative integer values),
- * or object byte size (always positive).
+ * @param i_size object byte size
*
* @return the new object, or NULL on error.
*/
-void * __vlc_object_create( vlc_object_t *p_this, int i_type )
+void *vlc_object_create( vlc_object_t *p_this, size_t i_size )
{
- const char * psz_type;
- size_t i_size;
-
- switch( i_type )
- {
- case VLC_OBJECT_INTF:
- i_size = sizeof(intf_thread_t);
- psz_type = "interface";
- break;
- case VLC_OBJECT_DECODER:
- i_size = sizeof(decoder_t);
- psz_type = "decoder";
- break;
- case VLC_OBJECT_PACKETIZER:
- i_size = sizeof(decoder_t);
- psz_type = "packetizer";
- break;
- case VLC_OBJECT_ENCODER:
- i_size = sizeof(encoder_t);
- psz_type = "encoder";
- break;
- case VLC_OBJECT_AOUT:
- i_size = sizeof(aout_instance_t);
- psz_type = "audio output";
- break;
- default:
- assert( i_type > 0 ); /* unknown type?! */
- i_size = i_type;
- i_type = VLC_OBJECT_GENERIC;
- psz_type = "generic";
- break;
- }
-
- return vlc_custom_create( p_this, i_size, i_type, psz_type );
+ return vlc_custom_create( p_this, i_size, "generic" );
}
-
+#undef vlc_object_set_destructor
/**
****************************************************************************
* Set the destructor of a vlc object
* when the object is destroyed when the its refcount reaches 0.
* (It is called by the internal function vlc_object_destroy())
*****************************************************************************/
-void __vlc_object_set_destructor( vlc_object_t *p_this,
- vlc_destructor_t pf_destructor )
+void vlc_object_set_destructor( vlc_object_t *p_this,
+ vlc_destructor_t pf_destructor )
{
vlc_object_internals_t *p_priv = vlc_internals(p_this );
+
+ vlc_spin_lock( &p_priv->ref_spin );
p_priv->pf_destructor = pf_destructor;
+ vlc_spin_unlock( &p_priv->ref_spin );
+}
+
+static vlc_mutex_t name_lock = VLC_STATIC_MUTEX;
+
+#undef vlc_object_set_name
+int vlc_object_set_name(vlc_object_t *obj, const char *name)
+{
+ vlc_object_internals_t *priv = vlc_internals(obj);
+ char *newname = name ? strdup (name) : NULL;
+ char *oldname;
+
+ vlc_mutex_lock (&name_lock);
+ oldname = priv->psz_name;
+ priv->psz_name = newname;
+ vlc_mutex_unlock (&name_lock);
+
+ free (oldname);
+ return (priv->psz_name || !name) ? VLC_SUCCESS : VLC_ENOMEM;
+}
+
+#undef vlc_object_get_name
+char *vlc_object_get_name(const vlc_object_t *obj)
+{
+ vlc_object_internals_t *priv = vlc_internals(obj);
+ char *name;
+
+ vlc_mutex_lock (&name_lock);
+ name = priv->psz_name ? strdup (priv->psz_name) : NULL;
+ vlc_mutex_unlock (&name_lock);
+
+ return name;
}
/**
- ****************************************************************************
- * Destroy a vlc object (Internal)
- *
- * This function destroys an object that has been previously allocated with
- * vlc_object_create. The object's refcount must be zero and it must not be
- * attached to other objects in any way.
+ * Destroys a VLC object once it has no more references.
*
* This function must be called with cancellation disabled (currently).
- *****************************************************************************/
+ */
static void vlc_object_destroy( vlc_object_t *p_this )
{
vlc_object_internals_t *p_priv = vlc_internals( p_this );
- /* Objects are always detached beforehand */
- assert( !p_this->p_parent );
-
- /* Send a kill to the object's thread if applicable */
- vlc_object_kill( p_this );
-
/* Call the custom "subclass" destructor */
if( p_priv->pf_destructor )
p_priv->pf_destructor( p_this );
- /* Any thread must have been cleaned up at this point. */
- assert( !p_priv->b_thread );
-
- /* Destroy the associated variables, starting from the end so that
- * no memmove calls have to be done. */
- while( p_priv->i_vars )
+ if (unlikely(p_this == VLC_OBJECT(p_this->p_libvlc)))
{
- var_Destroy( p_this, p_priv->p_vars[p_priv->i_vars - 1].psz_name );
+ /* TODO: should be in src/libvlc.c */
+ var_DelCallback (p_this, "tree", DumpCommand, p_this);
+ var_DelCallback (p_this, "vars", DumpCommand, p_this);
}
- free( p_priv->p_vars );
+ /* Destroy the associated variables. */
+ var_DestroyAll( p_this );
+
vlc_cond_destroy( &p_priv->var_wait );
vlc_mutex_destroy( &p_priv->var_lock );
free( p_this->psz_header );
- FREENULL( p_this->psz_object_name );
+ free( p_priv->psz_name );
vlc_spin_destroy( &p_priv->ref_spin );
- vlc_mutex_destroy( &p_priv->lock );
- vlc_cond_destroy( &p_priv->wait );
- vlc_spin_destroy( &p_priv->spin );
- if( p_priv->pipes[1] != -1 )
+ if( p_priv->pipes[1] != -1 && p_priv->pipes[1] != p_priv->pipes[0] )
close( p_priv->pipes[1] );
if( p_priv->pipes[0] != -1 )
close( p_priv->pipes[0] );
}
-/** Inter-object signaling */
-
-void __vlc_object_lock( vlc_object_t *obj )
-{
- vlc_mutex_lock( &(vlc_internals(obj)->lock) );
-}
-
-void __vlc_object_unlock( vlc_object_t *obj )
-{
- vlc_assert_locked( &(vlc_internals(obj)->lock) );
- vlc_mutex_unlock( &(vlc_internals(obj)->lock) );
-}
-void __vlc_object_assert_locked( vlc_object_t *obj )
-{
- vlc_assert_locked( &(vlc_internals(obj)->lock) );
-}
-
-#ifdef WIN32
-# include <winsock2.h>
-# include <ws2tcpip.h>
-
+#if defined(WIN32) || defined(__OS2__)
/**
* select()-able pipes emulated using Winsock
*/
-static int pipe (int fd[2])
+# define vlc_pipe selectable_pipe
+static int selectable_pipe (int fd[2])
{
- SOCKADDR_IN addr;
+ struct sockaddr_in addr;
int addrlen = sizeof (addr);
- SOCKET l = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP), a,
- c = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP);
- if ((l == INVALID_SOCKET) || (c == INVALID_SOCKET))
+ int l = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP),
+ c = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP);
+ if (l == -1 || c == -1)
goto error;
memset (&addr, 0, sizeof (addr));
addr.sin_family = AF_INET;
addr.sin_addr.s_addr = htonl (INADDR_LOOPBACK);
- if (bind (l, (PSOCKADDR)&addr, sizeof (addr))
- || getsockname (l, (PSOCKADDR)&addr, &addrlen)
+ if (bind (l, (struct sockaddr *)&addr, sizeof (addr))
+ || getsockname (l, (struct sockaddr *)&addr, &addrlen)
|| listen (l, 1)
- || connect (c, (PSOCKADDR)&addr, addrlen))
+ || connect (c, (struct sockaddr *)&addr, addrlen))
goto error;
- a = accept (l, NULL, NULL);
- if (a == INVALID_SOCKET)
+ int a = accept (l, NULL, NULL);
+ if (a == -1)
goto error;
- closesocket (l);
+ close (l);
//shutdown (a, 0);
//shutdown (c, 1);
fd[0] = c;
return 0;
error:
- if (l != INVALID_SOCKET)
- closesocket (l);
- if (c != INVALID_SOCKET)
- closesocket (c);
+ if (l != -1)
+ close (l);
+ if (c != -1)
+ close (c);
return -1;
}
+#endif /* WIN32 || __OS2__ */
-#undef read
-#define read( a, b, c ) recv (a, b, c, 0)
-#undef write
-#define write( a, b, c ) send (a, b, c, 0)
-#undef close
-#define close( a ) closesocket (a)
-#endif /* WIN32 */
+static vlc_mutex_t pipe_lock = VLC_STATIC_MUTEX;
/**
* Returns the readable end of a pipe that becomes readable once termination
*/
int vlc_object_waitpipe( vlc_object_t *obj )
{
- int pfd[2] = { -1, -1 };
vlc_object_internals_t *internals = vlc_internals( obj );
- bool killed = false;
- vlc_spin_lock (&internals->spin);
+ vlc_mutex_lock (&pipe_lock);
if (internals->pipes[0] == -1)
{
/* This can only ever happen if someone killed us without locking: */
assert (internals->pipes[1] == -1);
- vlc_spin_unlock (&internals->spin);
-
- if (pipe (pfd))
- return -1;
- vlc_spin_lock (&internals->spin);
+ /* pipe() is not a cancellation point, but write() is and eventfd() is
+ * unspecified (not in POSIX). */
+ int canc = vlc_savecancel ();
+#if defined (HAVE_SYS_EVENTFD_H)
+ internals->pipes[0] = internals->pipes[1] = eventfd (0, EFD_CLOEXEC);
if (internals->pipes[0] == -1)
+#endif
{
- internals->pipes[0] = pfd[0];
- internals->pipes[1] = pfd[1];
- pfd[0] = pfd[1] = -1;
+ if (vlc_pipe (internals->pipes))
+ internals->pipes[0] = internals->pipes[1] = -1;
}
- killed = obj->b_die;
- }
- vlc_spin_unlock (&internals->spin);
-
- if (killed)
- {
- /* Race condition: vlc_object_kill() already invoked! */
- int fd;
-
- vlc_spin_lock (&internals->spin);
- fd = internals->pipes[1];
- internals->pipes[1] = -1;
- vlc_spin_unlock (&internals->spin);
- msg_Dbg (obj, "waitpipe: object already dying");
- if (fd != -1)
- close (fd);
+ if (internals->pipes[0] != -1 && obj->b_die)
+ { /* Race condition: vlc_object_kill() already invoked! */
+ msg_Dbg (obj, "waitpipe: object already dying");
+ write (internals->pipes[1], &(uint64_t){ 1 }, sizeof (uint64_t));
+ }
+ vlc_restorecancel (canc);
}
-
- /* Race condition: two threads call pipe() - unlikely */
- if (pfd[0] != -1)
- close (pfd[0]);
- if (pfd[1] != -1)
- close (pfd[1]);
-
+ vlc_mutex_unlock (&pipe_lock);
return internals->pipes[0];
}
-
-/**
- * Suspends until another thread calls vlc_object_signal_unlocked().
- * The thread may be woken up earlier due to limitations of the underlying
- * implementation.
- *
- * In new code, please use vlc_cond_wait() instead.
- *
- * This function is a cancellation point. In case of cancellation, the object
- * will be in locked state.
- */
-void __vlc_object_wait( vlc_object_t *obj )
-{
- vlc_object_internals_t *priv = vlc_internals( obj );
- vlc_assert_locked( &priv->lock);
- vlc_cond_wait( &priv->wait, &priv->lock );
-}
-
-
+#undef vlc_object_kill
/**
- * Wakes up one thread waiting on the object. If no thread are (yet) waiting,
- * nothing happens.
- *
- * Please do not use this function in new code as we are trying to untangle
- * objects and threads. Use vlc_cond_wait() instead.
+ * Requests termination of an object, cancels the object thread, and make the
+ * object wait pipe (if it exists) readable. Not a cancellation point.
*/
-void __vlc_object_signal_unlocked( vlc_object_t *obj )
-{
- vlc_assert_locked (&(vlc_internals(obj)->lock));
- vlc_cond_signal( &(vlc_internals(obj)->wait) );
-}
-
-
-/**
- * Requests termination of an object.
- * If the object is LibVLC, also request to terminate all its children.
- */
-void __vlc_object_kill( vlc_object_t *p_this )
+void vlc_object_kill( vlc_object_t *p_this )
{
vlc_object_internals_t *priv = vlc_internals( p_this );
- int fd;
+ int fd = -1;
- vlc_thread_cancel( p_this );
- vlc_object_lock( p_this );
- p_this->b_die = true;
-
- vlc_spin_lock (&priv->spin);
- fd = priv->pipes[1];
- priv->pipes[1] = -1;
- vlc_spin_unlock (&priv->spin);
-
- if( fd != -1 )
+ vlc_mutex_lock( &pipe_lock );
+ if( !p_this->b_die )
{
- msg_Dbg (p_this, "waitpipe: object killed");
- close_nocancel (fd);
+ fd = priv->pipes[1];
+ p_this->b_die = true;
}
- vlc_cond_broadcast (&priv->wait);
/* This also serves as a memory barrier toward vlc_object_alive(): */
- vlc_object_unlock( p_this );
-}
-
-
-/*****************************************************************************
- * find a typed object and increment its refcount
- *****************************************************************************
- * This function recursively looks for a given object type. i_mode can be one
- * of FIND_PARENT, FIND_CHILD or FIND_ANYWHERE.
- *****************************************************************************/
-void * __vlc_object_find( vlc_object_t *p_this, int i_type, int i_mode )
-{
- vlc_object_t *p_found;
+ vlc_mutex_unlock( &pipe_lock );
- /* If we are of the requested type ourselves, don't look further */
- if( !(i_mode & FIND_STRICT) && p_this->i_object_type == i_type )
+ if (fd != -1)
{
- vlc_object_hold( p_this );
- return p_this;
- }
-
- /* Otherwise, recursively look for the object */
- if ((i_mode & 0x000f) == FIND_ANYWHERE)
- return vlc_object_find (p_this->p_libvlc, i_type,
- (i_mode & ~0x000f)|FIND_CHILD);
+ int canc = vlc_savecancel ();
- libvlc_lock (p_this->p_libvlc);
- p_found = FindObject( p_this, i_type, i_mode );
- libvlc_unlock (p_this->p_libvlc);
- return p_found;
+ /* write _after_ setting b_die, so vlc_object_alive() returns false */
+ write (fd, &(uint64_t){ 1 }, sizeof (uint64_t));
+ msg_Dbg (p_this, "waitpipe: object killed");
+ vlc_restorecancel (canc);
+ }
}
#undef vlc_object_find_name
*
* @param p_this object to search from
* @param psz_name name of the object to search for
- * @param i_mode search direction: FIND_PARENT, FIND_CHILD or FIND_ANYWHERE.
*
* @return a matching object (must be released by the caller),
* or NULL on error.
*/
-vlc_object_t *vlc_object_find_name( vlc_object_t *p_this,
- const char *psz_name, int i_mode )
+vlc_object_t *vlc_object_find_name( vlc_object_t *p_this, const char *psz_name )
{
vlc_object_t *p_found;
- /* If have the requested name ourselves, don't look further */
- if( !(i_mode & FIND_STRICT)
- && p_this->psz_object_name
- && !strcmp( p_this->psz_object_name, psz_name ) )
- {
- vlc_object_hold( p_this );
- return p_this;
- }
+ /* Reading psz_object_name from a separate inhibits thread-safety.
+ * Use a libvlc address variable instead for that sort of things! */
+ msg_Err( p_this, "%s(\"%s\") is not safe!", __func__, psz_name );
libvlc_lock (p_this->p_libvlc);
-
- /* Otherwise, recursively look for the object */
- if( (i_mode & 0x000f) == FIND_ANYWHERE )
- {
- vlc_object_t *p_root = p_this;
-
- /* Find the root */
- while( p_root->p_parent != NULL &&
- p_root != VLC_OBJECT( p_this->p_libvlc ) )
- {
- p_root = p_root->p_parent;
- }
-
- p_found = FindObjectName( p_root, psz_name,
- (i_mode & ~0x000f)|FIND_CHILD );
- if( p_found == NULL && p_root != VLC_OBJECT( p_this->p_libvlc ) )
- {
- p_found = FindObjectName( VLC_OBJECT( p_this->p_libvlc ),
- psz_name, (i_mode & ~0x000f)|FIND_CHILD );
- }
- }
- else
- {
- p_found = FindObjectName( p_this, psz_name, i_mode );
- }
-
+ vlc_mutex_lock (&name_lock);
+ p_found = FindName (vlc_internals (p_this), psz_name);
+ vlc_mutex_unlock (&name_lock);
libvlc_unlock (p_this->p_libvlc);
return p_found;
}
+#undef vlc_object_hold
/**
* Increment an object reference counter.
*/
-void * __vlc_object_hold( vlc_object_t *p_this )
+void * vlc_object_hold( vlc_object_t *p_this )
{
vlc_object_internals_t *internals = vlc_internals( p_this );
return p_this;
}
-/*****************************************************************************
- * Decrement an object refcount
- * And destroy the object if its refcount reach zero.
- *****************************************************************************/
-void __vlc_object_release( vlc_object_t *p_this )
+#undef vlc_object_release
+/**
+ * Drops a reference to an object (decrements the reference count).
+ * If the count reaches zero, the object is destroyed.
+ */
+void vlc_object_release( vlc_object_t *p_this )
{
vlc_object_internals_t *internals = vlc_internals( p_this );
vlc_object_t *parent = NULL;
if( b_should_destroy )
{
- /* We have no children */
- assert (internals->i_children == 0);
+ /* Detach from parent to protect against vlc_object_find_name() */
parent = p_this->p_parent;
-
-#ifndef NDEBUG
- if( VLC_OBJECT(p_this->p_libvlc) == p_this )
+ if (likely(parent))
{
- /* Test for leaks */
- vlc_object_t *leaked = internals->next;
- while( leaked != p_this )
- {
- /* We are leaking this object */
- fprintf( stderr,
- "ERROR: leaking object (%p, type:%s, name:%s)\n",
- leaked, leaked->psz_object_type,
- leaked->psz_object_name );
- /* Dump object to ease debugging */
- vlc_object_dump( leaked );
- fflush(stderr);
- leaked = vlc_internals (leaked)->next;
- }
-
- if( internals->next != p_this )
- /* Dump libvlc object to ease debugging */
- vlc_object_dump( p_this );
+ /* Unlink */
+ if (internals->prev != NULL)
+ internals->prev->next = internals->next;
+ else
+ vlc_internals(parent)->first = internals->next;
+ if (internals->next != NULL)
+ internals->next->prev = internals->prev;
}
-#endif
- /* Remove the object from object list
- * so that it cannot be encountered by vlc_object_get() */
- vlc_internals (internals->next)->prev = internals->prev;
- vlc_internals (internals->prev)->next = internals->next;
- if (parent)
- /* Detach from parent to protect against FIND_CHILDREN */
- vlc_object_detach_unlocked (p_this);
+ /* We have no children */
+ assert (internals->first == NULL);
}
libvlc_unlock (p_this->p_libvlc);
}
}
+#undef vlc_list_children
/**
- ****************************************************************************
- * attach object to a parent object
- *****************************************************************************
- * This function sets p_this as a child of p_parent, and p_parent as a parent
- * of p_this. This link can be undone using vlc_object_detach.
- *****************************************************************************/
-void __vlc_object_attach( vlc_object_t *p_this, vlc_object_t *p_parent )
-{
- if( !p_this ) return;
-
- vlc_object_hold (p_parent);
- libvlc_lock (p_this->p_libvlc);
-
- /* Attach the parent to its child */
- assert (!p_this->p_parent);
- p_this->p_parent = p_parent;
-
- /* Attach the child to its parent */
- vlc_object_internals_t *priv = vlc_internals( p_parent );
- INSERT_ELEM( priv->pp_children, priv->i_children, priv->i_children,
- p_this );
- libvlc_unlock (p_this->p_libvlc);
-}
-
-
-static void vlc_object_detach_unlocked (vlc_object_t *p_this)
+ * Gets the list of children of an objects, and increment their reference
+ * count.
+ * @return a list (possibly empty) or NULL in case of error.
+ */
+vlc_list_t *vlc_list_children( vlc_object_t *obj )
{
- if (p_this->p_parent == NULL)
- return;
-
- vlc_object_internals_t *priv = vlc_internals( p_this->p_parent );
-
- int i_index, i;
-
- /* Remove p_this's parent */
- p_this->p_parent = NULL;
+ vlc_list_t *l;
+ vlc_object_internals_t *priv;
+ unsigned count = 0;
- /* Remove all of p_parent's children which are p_this */
- for( i_index = priv->i_children ; i_index-- ; )
+ libvlc_lock (obj->p_libvlc);
+ for (priv = vlc_internals (obj)->first; priv; priv = priv->next)
+ count++;
+ l = NewList (count);
+ if (likely(l != NULL))
{
- if( priv->pp_children[i_index] == p_this )
- {
- priv->i_children--;
- for( i = i_index ; i < priv->i_children ; i++ )
- priv->pp_children[i] = priv->pp_children[i+1];
- }
- }
+ unsigned i = 0;
- if( priv->i_children )
- {
- vlc_object_t **pp_children = (vlc_object_t **)
- realloc( priv->pp_children,
- priv->i_children * sizeof(vlc_object_t *) );
- if( pp_children )
- priv->pp_children = pp_children;
- }
- else
- {
- /* Special case - don't realloc() to zero to avoid leaking */
- free( priv->pp_children );
- priv->pp_children = NULL;
+ for (priv = vlc_internals (obj)->first; priv; priv = priv->next)
+ l->p_values[i++].p_object = vlc_object_hold (vlc_externals (priv));
}
+ libvlc_unlock (obj->p_libvlc);
+ return l;
}
-
-/**
- ****************************************************************************
- * detach object from its parent
- *****************************************************************************
- * This function removes all links between an object and its parent.
- *****************************************************************************/
-void __vlc_object_detach( vlc_object_t *p_this )
+static void DumpVariable (const void *data, const VISIT which, const int depth)
{
- vlc_object_t *p_parent;
- if( !p_this ) return;
-
- libvlc_lock (p_this->p_libvlc);
- p_parent = p_this->p_parent;
- if (p_parent)
- vlc_object_detach_unlocked( p_this );
- libvlc_unlock (p_this->p_libvlc);
-
- if (p_parent)
- vlc_object_release (p_parent);
-}
-
+ if (which != postorder && which != leaf)
+ return;
+ (void) depth;
-/**
- ****************************************************************************
- * find a list typed objects and increment their refcount
- *****************************************************************************
- * This function recursively looks for a given object type. i_mode can be one
- * of FIND_PARENT, FIND_CHILD or FIND_ANYWHERE.
- *****************************************************************************/
-vlc_list_t * __vlc_list_find( vlc_object_t *p_this, int i_type, int i_mode )
-{
- vlc_list_t *p_list;
- int i_count = 0;
+ const variable_t *p_var = *(const variable_t **)data;
+ const char *psz_type = "unknown";
- /* Look for the objects */
- switch( i_mode & 0x000f )
+ switch( p_var->i_type & VLC_VAR_TYPE )
{
- case FIND_ANYWHERE:
- return vlc_list_find (p_this->p_libvlc, i_type, FIND_CHILD);
-
- case FIND_CHILD:
- libvlc_lock (p_this->p_libvlc);
- i_count = CountChildren( p_this, i_type );
- p_list = NewList( i_count );
-
- /* Check allocation was successful */
- if( p_list->i_count != i_count )
- {
- libvlc_unlock (p_this->p_libvlc);
- p_list->i_count = 0;
+#define MYCASE( type, nice ) \
+ case VLC_VAR_ ## type: \
+ psz_type = nice; \
break;
- }
-
- p_list->i_count = 0;
- ListChildren( p_list, p_this, i_type );
- libvlc_unlock (p_this->p_libvlc);
- break;
-
- default:
- msg_Err( p_this, "unimplemented!" );
- p_list = NewList( 0 );
- break;
+ MYCASE( VOID, "void" );
+ MYCASE( BOOL, "bool" );
+ MYCASE( INTEGER, "integer" );
+ MYCASE( HOTKEY, "hotkey" );
+ MYCASE( STRING, "string" );
+ MYCASE( VARIABLE, "variable" );
+ MYCASE( FLOAT, "float" );
+ MYCASE( TIME, "time" );
+ MYCASE( COORDS, "coords" );
+ MYCASE( ADDRESS, "address" );
+#undef MYCASE
}
-
- return p_list;
-}
-
-/**
- * Gets the list of children of an objects, and increment their reference
- * count.
- * @return a list (possibly empty) or NULL in case of error.
- */
-vlc_list_t *__vlc_list_children( vlc_object_t *obj )
-{
- vlc_list_t *l;
- vlc_object_internals_t *priv = vlc_internals( obj );
-
- libvlc_lock (obj->p_libvlc);
- l = NewList( priv->i_children );
- for (int i = 0; i < l->i_count; i++)
- {
- vlc_object_hold( priv->pp_children[i] );
- l->p_values[i].p_object = priv->pp_children[i];
+ printf( " *-o \"%s\" (%s", p_var->psz_name, psz_type );
+ if( p_var->psz_text )
+ printf( ", %s", p_var->psz_text );
+ fputc( ')', stdout );
+ if( p_var->i_type & VLC_VAR_HASCHOICE )
+ fputs( ", has choices", stdout );
+ if( p_var->i_type & VLC_VAR_ISCOMMAND )
+ fputs( ", command", stdout );
+ if( p_var->i_entries )
+ printf( ", %d callbacks", p_var->i_entries );
+ switch( p_var->i_type & VLC_VAR_CLASS )
+ {
+ case VLC_VAR_VOID:
+ break;
+ case VLC_VAR_BOOL:
+ printf( ": %s", p_var->val.b_bool ? "true" : "false" );
+ break;
+ case VLC_VAR_INTEGER:
+ printf( ": %"PRId64, p_var->val.i_int );
+ break;
+ case VLC_VAR_STRING:
+ printf( ": \"%s\"", p_var->val.psz_string );
+ break;
+ case VLC_VAR_FLOAT:
+ printf( ": %f", p_var->val.f_float );
+ break;
+ case VLC_VAR_TIME:
+ printf( ": %"PRIi64, (int64_t)p_var->val.i_time );
+ break;
+ case VLC_VAR_COORDS:
+ printf( ": %"PRId32"x%"PRId32,
+ p_var->val.coords.x, p_var->val.coords.y );
+ break;
+ case VLC_VAR_ADDRESS:
+ printf( ": %p", p_var->val.p_address );
+ break;
}
- libvlc_unlock (obj->p_libvlc);
- return l;
+ fputc( '\n', stdout );
}
/*****************************************************************************
static int DumpCommand( vlc_object_t *p_this, char const *psz_cmd,
vlc_value_t oldval, vlc_value_t newval, void *p_data )
{
- libvlc_int_t *p_libvlc = p_this->p_libvlc;
+ (void)oldval;
+ vlc_object_t *p_object = NULL;
- (void)oldval; (void)p_data;
- if( *psz_cmd == 'l' )
+ if( *newval.psz_string )
{
- vlc_object_t *cur = VLC_OBJECT (p_libvlc);
-
- libvlc_lock (p_this->p_libvlc);
- do
- {
- PrintObject (cur, "");
- cur = vlc_internals (cur)->next;
- }
- while (cur != VLC_OBJECT(p_libvlc));
- libvlc_unlock (p_this->p_libvlc);
+ /* try using the object's name to find it */
+ p_object = vlc_object_find_name( p_data, newval.psz_string );
+ if( !p_object )
+ return VLC_ENOOBJ;
}
- else
- {
- vlc_object_t *p_object = NULL;
- if( *newval.psz_string )
- {
- /* try using the object's name to find it */
- p_object = vlc_object_find_name( p_this, newval.psz_string,
- FIND_ANYWHERE );
- if( !p_object )
- {
- return VLC_ENOOBJ;
- }
- }
-
- libvlc_lock (p_this->p_libvlc);
- if( *psz_cmd == 't' )
- {
- char psz_foo[2 * MAX_DUMPSTRUCTURE_DEPTH + 1];
-
- if( !p_object )
- p_object = VLC_OBJECT(p_this->p_libvlc);
-
- psz_foo[0] = '|';
- DumpStructure( p_object, 0, psz_foo );
- }
- else if( *psz_cmd == 'v' )
- {
- int i;
-
- if( !p_object )
- p_object = p_this->p_libvlc ? VLC_OBJECT(p_this->p_libvlc) : p_this;
+ libvlc_lock (p_this->p_libvlc);
+ if( *psz_cmd == 't' )
+ {
+ char psz_foo[2 * MAX_DUMPSTRUCTURE_DEPTH + 1];
- PrintObject( p_object, "" );
+ if( !p_object )
+ p_object = VLC_OBJECT(p_this->p_libvlc);
- if( !vlc_internals( p_object )->i_vars )
- printf( " `-o No variables\n" );
- for( i = 0; i < vlc_internals( p_object )->i_vars; i++ )
- {
- variable_t *p_var = vlc_internals( p_object )->p_vars + i;
-
- const char *psz_type = "unknown";
- switch( p_var->i_type & VLC_VAR_TYPE )
- {
-#define MYCASE( type, nice ) \
- case VLC_VAR_ ## type: \
- psz_type = nice; \
- break;
- MYCASE( VOID, "void" );
- MYCASE( BOOL, "bool" );
- MYCASE( INTEGER, "integer" );
- MYCASE( HOTKEY, "hotkey" );
- MYCASE( STRING, "string" );
- MYCASE( MODULE, "module" );
- MYCASE( FILE, "file" );
- MYCASE( DIRECTORY, "directory" );
- MYCASE( VARIABLE, "variable" );
- MYCASE( FLOAT, "float" );
- MYCASE( TIME, "time" );
- MYCASE( ADDRESS, "address" );
- MYCASE( MUTEX, "mutex" );
- MYCASE( LIST, "list" );
-#undef MYCASE
- }
- printf( " %c-o \"%s\" (%s",
- i + 1 == vlc_internals( p_object )->i_vars ? '`' : '|',
- p_var->psz_name, psz_type );
- if( p_var->psz_text )
- printf( ", %s", p_var->psz_text );
- printf( ")" );
- if( p_var->i_type & VLC_VAR_HASCHOICE )
- printf( ", has choices" );
- if( p_var->i_type & VLC_VAR_ISCOMMAND )
- printf( ", command" );
- if( p_var->i_entries )
- printf( ", %d callbacks", p_var->i_entries );
- switch( p_var->i_type & VLC_VAR_CLASS )
- {
- case VLC_VAR_VOID:
- case VLC_VAR_MUTEX:
- break;
- case VLC_VAR_BOOL:
- printf( ": %s", p_var->val.b_bool ? "true" : "false" );
- break;
- case VLC_VAR_INTEGER:
- printf( ": %d", p_var->val.i_int );
- break;
- case VLC_VAR_STRING:
- printf( ": \"%s\"", p_var->val.psz_string );
- break;
- case VLC_VAR_FLOAT:
- printf( ": %f", p_var->val.f_float );
- break;
- case VLC_VAR_TIME:
- printf( ": %"PRIi64, (int64_t)p_var->val.i_time );
- break;
- case VLC_VAR_ADDRESS:
- printf( ": %p", p_var->val.p_address );
- break;
- case VLC_VAR_LIST:
- printf( ": TODO" );
- break;
- }
- printf( "\n" );
- }
- }
- libvlc_unlock (p_this->p_libvlc);
+ psz_foo[0] = '|';
+ DumpStructure( vlc_internals(p_object), 0, psz_foo );
+ }
+ else if( *psz_cmd == 'v' )
+ {
+ if( !p_object )
+ p_object = p_this->p_libvlc ? VLC_OBJECT(p_this->p_libvlc) : p_this;
- if( *newval.psz_string )
- {
- vlc_object_release( p_object );
- }
+ PrintObject( vlc_internals(p_object), "" );
+ vlc_mutex_lock( &vlc_internals( p_object )->var_lock );
+ if( vlc_internals( p_object )->var_root == NULL )
+ puts( " `-o No variables" );
+ else
+ twalk( vlc_internals( p_object )->var_root, DumpVariable );
+ vlc_mutex_unlock( &vlc_internals( p_object )->var_lock );
}
+ libvlc_unlock (p_this->p_libvlc);
+ if( *newval.psz_string )
+ {
+ vlc_object_release( p_object );
+ }
return VLC_SUCCESS;
}
free( p_list );
}
-/*****************************************************************************
- * dump an object. (Debug function)
- *****************************************************************************/
-#ifndef NDEBUG
-static void vlc_object_dump( vlc_object_t *p_this )
-{
- char psz_foo[2 * MAX_DUMPSTRUCTURE_DEPTH + 1];
- psz_foo[0] = '|';
-
- DumpStructure( p_this, 0, psz_foo );
-}
-#endif
-
/* Following functions are local */
-static vlc_object_t * FindObject( vlc_object_t *p_this, int i_type, int i_mode )
+static vlc_object_t *FindName (vlc_object_internals_t *priv, const char *name)
{
- int i;
- vlc_object_t *p_tmp;
+ if (priv->psz_name != NULL && !strcmp (priv->psz_name, name))
+ return vlc_object_hold (vlc_externals (priv));
- switch( i_mode & 0x000f )
+ for (priv = priv->first; priv != NULL; priv = priv->next)
{
- case FIND_PARENT:
- p_tmp = p_this->p_parent;
- if( p_tmp )
- {
- if( p_tmp->i_object_type == i_type )
- {
- vlc_object_hold( p_tmp );
- return p_tmp;
- }
- else
- {
- return FindObject( p_tmp, i_type, i_mode );
- }
- }
- break;
-
- case FIND_CHILD:
- for( i = vlc_internals( p_this )->i_children; i--; )
- {
- p_tmp = vlc_internals( p_this )->pp_children[i];
- if( p_tmp->i_object_type == i_type )
- {
- vlc_object_hold( p_tmp );
- return p_tmp;
- }
- else if( vlc_internals( p_tmp )->i_children )
- {
- p_tmp = FindObject( p_tmp, i_type, i_mode );
- if( p_tmp )
- {
- return p_tmp;
- }
- }
- }
- break;
-
- case FIND_ANYWHERE:
- /* Handled in vlc_object_find */
- break;
- }
-
- return NULL;
-}
-
-static vlc_object_t * FindObjectName( vlc_object_t *p_this,
- const char *psz_name,
- int i_mode )
-{
- int i;
- vlc_object_t *p_tmp;
-
- switch( i_mode & 0x000f )
- {
- case FIND_PARENT:
- p_tmp = p_this->p_parent;
- if( p_tmp )
- {
- if( p_tmp->psz_object_name
- && !strcmp( p_tmp->psz_object_name, psz_name ) )
- {
- vlc_object_hold( p_tmp );
- return p_tmp;
- }
- else
- {
- return FindObjectName( p_tmp, psz_name, i_mode );
- }
- }
- break;
-
- case FIND_CHILD:
- for( i = vlc_internals( p_this )->i_children; i--; )
- {
- p_tmp = vlc_internals( p_this )->pp_children[i];
- if( p_tmp->psz_object_name
- && !strcmp( p_tmp->psz_object_name, psz_name ) )
- {
- vlc_object_hold( p_tmp );
- return p_tmp;
- }
- else if( vlc_internals( p_tmp )->i_children )
- {
- p_tmp = FindObjectName( p_tmp, psz_name, i_mode );
- if( p_tmp )
- {
- return p_tmp;
- }
- }
- }
- break;
-
- case FIND_ANYWHERE:
- /* Handled in vlc_object_find */
- break;
+ vlc_object_t *found = FindName (priv, name);
+ if (found != NULL)
+ return found;
}
-
return NULL;
}
-
-static void PrintObject( vlc_object_t *p_this, const char *psz_prefix )
+static void PrintObject( vlc_object_internals_t *priv,
+ const char *psz_prefix )
{
- char psz_children[20], psz_refcount[20], psz_thread[30], psz_name[50],
- psz_parent[20];
+ char psz_refcount[20], psz_name[50], psz_parent[20];
int canc = vlc_savecancel ();
memset( &psz_name, 0, sizeof(psz_name) );
- if( p_this->psz_object_name )
+
+ vlc_mutex_lock (&name_lock);
+ if (priv->psz_name != NULL)
{
- snprintf( psz_name, 49, " \"%s\"", p_this->psz_object_name );
+ snprintf( psz_name, 49, " \"%s\"", priv->psz_name );
if( psz_name[48] )
psz_name[48] = '\"';
}
-
- psz_children[0] = '\0';
- switch( vlc_internals( p_this )->i_children )
- {
- case 0:
- break;
- case 1:
- strcpy( psz_children, ", 1 child" );
- break;
- default:
- snprintf( psz_children, 19, ", %i children",
- vlc_internals( p_this )->i_children );
- break;
- }
+ vlc_mutex_unlock (&name_lock);
psz_refcount[0] = '\0';
- if( vlc_internals( p_this )->i_refcount > 0 )
- snprintf( psz_refcount, 19, ", refcount %u",
- vlc_internals( p_this )->i_refcount );
-
- psz_thread[0] = '\0';
- if( vlc_internals( p_this )->b_thread )
- snprintf( psz_thread, 29, " (thread %lu)",
- (unsigned long)vlc_internals( p_this )->thread_id );
+ if( priv->i_refcount > 0 )
+ snprintf( psz_refcount, 19, ", %u refs", priv->i_refcount );
psz_parent[0] = '\0';
- if( p_this->p_parent )
- snprintf( psz_parent, 19, ", parent %p", p_this->p_parent );
-
- printf( " %so %p %s%s%s%s%s%s\n", psz_prefix,
- p_this, p_this->psz_object_type,
- psz_name, psz_thread, psz_refcount, psz_children,
- psz_parent );
+ /* FIXME: need structure lock!!! */
+ if( vlc_externals(priv)->p_parent )
+ snprintf( psz_parent, 19, ", parent %p",
+ vlc_externals(priv)->p_parent );
+
+ printf( " %so %p %s%s%s%s\n", psz_prefix,
+ vlc_externals(priv), vlc_externals(priv)->psz_object_type,
+ psz_name, psz_refcount, psz_parent );
vlc_restorecancel (canc);
}
-static void DumpStructure( vlc_object_t *p_this, int i_level, char *psz_foo )
+static void DumpStructure (vlc_object_internals_t *priv, unsigned i_level,
+ char *psz_foo)
{
- int i;
char i_back = psz_foo[i_level];
psz_foo[i_level] = '\0';
- PrintObject( p_this, psz_foo );
+ PrintObject (priv, psz_foo);
psz_foo[i_level] = i_back;
if( i_level / 2 >= MAX_DUMPSTRUCTURE_DEPTH )
{
- msg_Warn( p_this, "structure tree is too deep" );
+ msg_Warn( vlc_externals(priv), "structure tree is too deep" );
return;
}
- for( i = 0 ; i < vlc_internals( p_this )->i_children ; i++ )
+ for (priv = priv->first; priv != NULL; priv = priv->next)
{
if( i_level )
{
}
}
- if( i == vlc_internals( p_this )->i_children - 1 )
- {
- psz_foo[i_level] = '`';
- }
- else
- {
- psz_foo[i_level] = '|';
- }
-
+ psz_foo[i_level] = priv->next ? '|' : '`';
psz_foo[i_level+1] = '-';
psz_foo[i_level+2] = '\0';
- DumpStructure( vlc_internals( p_this )->pp_children[i], i_level + 2,
- psz_foo );
+ DumpStructure (priv, i_level + 2, psz_foo);
}
}
static vlc_list_t * NewList( int i_count )
{
- vlc_list_t * p_list = (vlc_list_t *)malloc( sizeof( vlc_list_t ) );
+ vlc_list_t * p_list = malloc( sizeof( vlc_list_t ) );
if( p_list == NULL )
- {
return NULL;
- }
p_list->i_count = i_count;
return p_list;
}
-
-static void ListReplace( vlc_list_t *p_list, vlc_object_t *p_object,
- int i_index )
-{
- if( p_list == NULL || i_index >= p_list->i_count )
- {
- return;
- }
-
- vlc_object_hold( p_object );
-
- p_list->p_values[i_index].p_object = p_object;
-
- return;
-}
-
-/*static void ListAppend( vlc_list_t *p_list, vlc_object_t *p_object )
-{
- if( p_list == NULL )
- {
- return;
- }
-
- p_list->p_values = realloc( p_list->p_values, (p_list->i_count + 1)
- * sizeof( vlc_value_t ) );
- if( p_list->p_values == NULL )
- {
- p_list->i_count = 0;
- return;
- }
-
- vlc_object_hold( p_object );
-
- p_list->p_values[p_list->i_count].p_object = p_object;
- p_list->i_count++;
-
- return;
-}*/
-
-static int CountChildren( vlc_object_t *p_this, int i_type )
-{
- vlc_object_t *p_tmp;
- int i, i_count = 0;
-
- for( i = 0; i < vlc_internals( p_this )->i_children; i++ )
- {
- p_tmp = vlc_internals( p_this )->pp_children[i];
-
- if( p_tmp->i_object_type == i_type )
- {
- i_count++;
- }
- i_count += CountChildren( p_tmp, i_type );
- }
-
- return i_count;
-}
-
-static void ListChildren( vlc_list_t *p_list, vlc_object_t *p_this, int i_type )
-{
- vlc_object_t *p_tmp;
- int i;
-
- for( i = 0; i < vlc_internals( p_this )->i_children; i++ )
- {
- p_tmp = vlc_internals( p_this )->pp_children[i];
-
- if( p_tmp->i_object_type == i_type )
- ListReplace( p_list, p_tmp, p_list->i_count++ );
-
- ListChildren( p_list, p_tmp, i_type );
- }
-}
projects / vlc / blobdiff