]> git.sesse.net Git - vlc/blobdiff - src/misc/stats.c
Use var_Inherit* instead of var_CreateGet*.
[vlc] / src / misc / stats.c
index 3cdaf9ddc34e259977fe5f7cdca0523907a16c7c..7a46306fa9322f9f11ec1fb01ae421b2c17cd772 100644 (file)
@@ -1,10 +1,10 @@
 /*****************************************************************************
  * stats.c: Statistics handling
  *****************************************************************************
- * Copyright (C) 1998-2005 the VideoLAN team
- * $Id: messages.c 12729 2005-10-02 08:00:06Z courmisch $
+ * Copyright (C) 2006 the VideoLAN team
+ * $Id$
  *
- * Authors: Clément Stenac <zorglub@videolan.org>
+ * Authors: Clément Stenac <zorglub@videolan.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
+
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
 #include <stdio.h>                                               /* required */
 
-#include <vlc/vlc.h>
-#include <vlc_input.h>
+#include "input/input_internal.h"
 
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
-static counter_t *GetCounter( stats_handler_t *p_handler, int i_object_id,
-                            char *psz_name );
-static int stats_CounterUpdate( stats_handler_t *p_handler,
-                                counter_t *p_counter,
-                                vlc_value_t val );
-static stats_handler_t* stats_HandlerCreate( vlc_object_t *p_this );
-static stats_handler_t *stats_HandlerGet( vlc_object_t *p_this );
+static int CounterUpdate( vlc_object_t *p_this,
+                          counter_t *p_counter,
+                          vlc_value_t val, vlc_value_t * );
+static void TimerDump( vlc_object_t *p_this, counter_t *p_counter, bool);
 
 /*****************************************************************************
  * Exported functions
  *****************************************************************************/
 
+#undef stats_CounterCreate
 /**
  * Create a statistics counter
- * \param p_this the object for which to create the counter
- * \param psz_name the name
+ * \param p_this a VLC object
  * \param i_type the type of stored data. One of VLC_VAR_STRING,
  * VLC_VAR_INTEGER, VLC_VAR_FLOAT
  * \param i_compute_type the aggregation type. One of STATS_LAST (always
@@ -55,101 +57,52 @@ static stats_handler_t *stats_HandlerGet( vlc_object_t *p_this );
  * STATS_MAX (keep the maximum passed value), STATS_MIN, or STATS_DERIVATIVE
  * (keep a time derivative of the value)
  */
-int __stats_Create( vlc_object_t *p_this, char *psz_name, int i_type,
-                    int i_compute_type )
+counter_t * stats_CounterCreate( vlc_object_t *p_this,
+                                   int i_type, int i_compute_type )
 {
-    counter_t *p_counter;
-    stats_handler_t *p_handler = stats_HandlerGet( p_this );
-    if( !p_handler ) return VLC_ENOMEM;
-
-    vlc_mutex_lock( &p_handler->object_lock );
+    counter_t *p_counter = (counter_t*) malloc( sizeof( counter_t ) ) ;
+    (void)p_this;
 
-    p_counter = (counter_t*) malloc( sizeof( counter_t ) ) ;
-
-    p_counter->psz_name = strdup( psz_name );
-    p_counter->i_source_object = p_this->i_object_id;
+    if( !p_counter ) return NULL;
     p_counter->i_compute_type = i_compute_type;
     p_counter->i_type = i_type;
     p_counter->i_samples = 0;
     p_counter->pp_samples = NULL;
+    p_counter->psz_name = NULL;
 
     p_counter->update_interval = 0;
     p_counter->last_update = 0;
 
-    INSERT_ELEM( p_handler->pp_counters,
-                 p_handler->i_counters,
-                 p_handler->i_counters,
-                 p_counter );
-
-    vlc_mutex_unlock( &p_handler->object_lock );
-
-    return VLC_SUCCESS;
+    return p_counter;
 }
 
 /** Update a counter element with new values
- * \param p_this the object in which to update
- * \param psz_name the name
+ * \param p_this a VLC object
+ * \param p_counter the counter to update
  * \param val the vlc_value union containing the new value to aggregate. For
- * more information on how data is aggregated, \see __stats_Create
+ * more information on how data is aggregated, \see stats_Create
+ * \param val_new a pointer that will be filled with new data
  */
-int __stats_Update( vlc_object_t *p_this, char *psz_name, vlc_value_t val )
+int stats_Update( vlc_object_t *p_this, counter_t *p_counter,
+                  vlc_value_t val, vlc_value_t *val_new )
 {
-    int i_ret;
-    counter_t *p_counter;
-
-    /* Get stats handler singleton */
-    stats_handler_t *p_handler = stats_HandlerGet( p_this );
-    if( !p_handler ) return VLC_ENOMEM;
-
-    vlc_mutex_lock( &p_handler->object_lock );
-
-    /* Look for existing element */
-    p_counter = GetCounter( p_handler, p_this->i_object_id,
-                            psz_name );
-    if( !p_counter )
-    {
-        vlc_mutex_unlock( &p_handler->object_lock );
-        vlc_object_release( p_handler );
-        return VLC_ENOOBJ;
-    }
-
-    i_ret = stats_CounterUpdate( p_handler, p_counter, val );
-    vlc_mutex_unlock( &p_handler->object_lock );
-
-    return i_ret;
+    if( !libvlc_stats (p_this) || !p_counter ) return VLC_EGENERIC;
+    return CounterUpdate( p_this, p_counter, val, val_new );
 }
 
+#undef stats_Get
 /** Get the aggregated value for a counter
  * \param p_this an object
- * \param i_object_id the object id from which we want the data
- * \param psz_name the name of the couner
+ * \param p_counter the counter
  * \param val a pointer to an initialized vlc_value union. It will contain the
  * retrieved value
  * \return an error code
  */
-int __stats_Get( vlc_object_t *p_this, int i_object_id, char *psz_name, vlc_value_t *val )
+int stats_Get( vlc_object_t *p_this, counter_t *p_counter, vlc_value_t *val )
 {
-    counter_t *p_counter;
-
-    /* Get stats handler singleton */
-    stats_handler_t *p_handler = stats_HandlerGet( p_this );
-    if( !p_handler ) return VLC_ENOMEM;
-    vlc_mutex_lock( &p_handler->object_lock );
-
-
-    /* Look for existing element */
-    p_counter = GetCounter( p_handler, i_object_id,
-                            psz_name );
-    if( !p_counter )
+    if( !libvlc_stats (p_this) || !p_counter || p_counter->i_samples == 0 )
     {
-        vlc_mutex_unlock( &p_handler->object_lock );
-        vlc_object_release( p_handler );
-        return VLC_ENOOBJ;
-    }
-
-    if( p_counter->i_samples == 0 )
-    {
-        vlc_mutex_unlock( &p_handler->object_lock );
+        val->i_int = 0;
         return VLC_EGENERIC;
     }
 
@@ -162,13 +115,19 @@ int __stats_Get( vlc_object_t *p_this, int i_object_id, char *psz_name, vlc_valu
         *val = p_counter->pp_samples[0]->value;
         break;
     case STATS_DERIVATIVE:
-       if( p_counter->i_type == VLC_VAR_INTEGER )
+        /* Not ready yet */
+        if( p_counter->i_samples < 2 )
+        {
+            val->i_int = 0;
+            return VLC_EGENERIC;
+        }
+        if( p_counter->i_type == VLC_VAR_INTEGER )
         {
             float f = ( p_counter->pp_samples[0]->value.i_int -
                         p_counter->pp_samples[1]->value.i_int ) /
                     (float)(  p_counter->pp_samples[0]->date -
                               p_counter->pp_samples[1]->date );
-            val->i_int = (int)f;
+            val->i_int = (int64_t)f;
         }
         else
         {
@@ -176,63 +135,96 @@ int __stats_Get( vlc_object_t *p_this, int i_object_id, char *psz_name, vlc_valu
                                p_counter->pp_samples[1]->value.f_float ) /
                       (float)( p_counter->pp_samples[0]->date -
                                p_counter->pp_samples[1]->date );
-            val->i_int = (int)f;
             val->f_float = f;
         }
         break;
     }
-    vlc_object_release( p_handler );
-
-    vlc_mutex_unlock( &p_handler->object_lock );
     return VLC_SUCCESS;;
 }
 
-/** Get a statistics counter structure. This allows for low-level modifications
- * \param p_this a parent object
- * \param i_object_id the object from which to retrieve data
- * \param psz_name the name
- * \return the counter, or NULL if not found (or handler not created yet)
- */
-counter_t *__stats_CounterGet( vlc_object_t *p_this, int i_object_id,
-                             char *psz_name )
+input_stats_t *stats_NewInputStats( input_thread_t *p_input )
 {
-    counter_t *p_counter;
-
-    /* Get stats handler singleton */
-    stats_handler_t *p_handler = stats_HandlerGet( p_this );
-    if( !p_handler ) return NULL;
-
-    vlc_mutex_lock( &p_handler->object_lock );
+    (void)p_input;
+    input_stats_t *p_stats = calloc( 1, sizeof(input_stats_t) );
+    if( !p_stats )
+        return NULL;
 
-    /* Look for existing element */
-    p_counter = GetCounter( p_handler, p_this->i_object_id,
-                            psz_name );
-    vlc_mutex_unlock( &p_handler->object_lock );
-    vlc_object_release( p_handler );
+    vlc_mutex_init( &p_stats->lock );
+    stats_ReinitInputStats( p_stats );
 
-    return p_counter;
+    return p_stats;
 }
 
-
-void stats_ComputeInputStats( input_thread_t *p_input,
-                              input_stats_t *p_stats )
+void stats_ComputeInputStats( input_thread_t *p_input, input_stats_t *p_stats )
 {
+    if( !libvlc_stats (p_input) ) return;
+
+    vlc_mutex_lock( &p_input->p->counters.counters_lock );
     vlc_mutex_lock( &p_stats->lock );
-    /* read_packets and read_bytes are common to all streams */
-    stats_GetInteger( p_input, p_input->i_object_id, "read_packets",
-                       &p_stats->i_read_packets );
-    stats_GetInteger( p_input, p_input->i_object_id, "read_bytes",
-                       &p_stats->i_read_bytes );
-    stats_GetFloat( p_input, p_input->i_object_id, "input_bitrate",
-                       &p_stats->f_bitrate );
+
+    /* Input */
+    stats_GetInteger( p_input, p_input->p->counters.p_read_packets,
+                      &p_stats->i_read_packets );
+    stats_GetInteger( p_input, p_input->p->counters.p_read_bytes,
+                      &p_stats->i_read_bytes );
+    stats_GetFloat( p_input, p_input->p->counters.p_input_bitrate,
+                    &p_stats->f_input_bitrate );
+    stats_GetInteger( p_input, p_input->p->counters.p_demux_read,
+                      &p_stats->i_demux_read_bytes );
+    stats_GetFloat( p_input, p_input->p->counters.p_demux_bitrate,
+                    &p_stats->f_demux_bitrate );
+    stats_GetInteger( p_input, p_input->p->counters.p_demux_corrupted,
+                      &p_stats->i_demux_corrupted );
+    stats_GetInteger( p_input, p_input->p->counters.p_demux_discontinuity,
+                      &p_stats->i_demux_discontinuity );
+
+    /* Decoders */
+    stats_GetInteger( p_input, p_input->p->counters.p_decoded_video,
+                      &p_stats->i_decoded_video );
+    stats_GetInteger( p_input, p_input->p->counters.p_decoded_audio,
+                      &p_stats->i_decoded_audio );
+
+    /* Sout */
+    if( p_input->p->counters.p_sout_send_bitrate )
+    {
+        stats_GetInteger( p_input, p_input->p->counters.p_sout_sent_packets,
+                          &p_stats->i_sent_packets );
+        stats_GetInteger( p_input, p_input->p->counters.p_sout_sent_bytes,
+                          &p_stats->i_sent_bytes );
+        stats_GetFloat  ( p_input, p_input->p->counters.p_sout_send_bitrate,
+                          &p_stats->f_send_bitrate );
+    }
+
+    /* Aout */
+    stats_GetInteger( p_input, p_input->p->counters.p_played_abuffers,
+                      &p_stats->i_played_abuffers );
+    stats_GetInteger( p_input, p_input->p->counters.p_lost_abuffers,
+                      &p_stats->i_lost_abuffers );
+
+    /* Vouts */
+    stats_GetInteger( p_input, p_input->p->counters.p_displayed_pictures,
+                      &p_stats->i_displayed_pictures );
+    stats_GetInteger( p_input, p_input->p->counters.p_lost_pictures,
+                      &p_stats->i_lost_pictures );
+
     vlc_mutex_unlock( &p_stats->lock );
+    vlc_mutex_unlock( &p_input->p->counters.counters_lock );
 }
 
 void stats_ReinitInputStats( input_stats_t *p_stats )
 {
+    vlc_mutex_lock( &p_stats->lock );
     p_stats->i_read_packets = p_stats->i_read_bytes =
-        p_stats->f_bitrate = p_stats->f_average_bitrate =
-        p_stats->i_displayed_pictures = p_stats->i_lost_pictures = 0;
+    p_stats->f_input_bitrate = p_stats->f_average_input_bitrate =
+    p_stats->i_demux_read_packets = p_stats->i_demux_read_bytes =
+    p_stats->f_demux_bitrate = p_stats->f_average_demux_bitrate =
+    p_stats->i_demux_corrupted = p_stats->i_demux_discontinuity =
+    p_stats->i_displayed_pictures = p_stats->i_lost_pictures =
+    p_stats->i_played_abuffers = p_stats->i_lost_abuffers =
+    p_stats->i_decoded_video = p_stats->i_decoded_audio =
+    p_stats->i_sent_bytes = p_stats->i_sent_packets = p_stats->f_send_bitrate
+     = 0;
+    vlc_mutex_unlock( &p_stats->lock );
 }
 
 void stats_DumpInputStats( input_stats_t *p_stats  )
@@ -240,12 +232,187 @@ void stats_DumpInputStats( input_stats_t *p_stats  )
     vlc_mutex_lock( &p_stats->lock );
     /* f_bitrate is in bytes / microsecond
      * *1000 => bytes / millisecond => kbytes / seconds */
-    fprintf( stderr, "Read packets : %i (%i bytes) - %f kB/s\n",
+    fprintf( stderr, "Input : %"PRId64" (%"PRId64" bytes) - %f kB/s - "
+                     "Demux : %"PRId64" (%"PRId64" bytes) - %f kB/s\n"
+                     " - Vout : %"PRId64"/%"PRId64" - Aout : %"PRId64"/%"PRId64" - Sout : %f\n",
                     p_stats->i_read_packets, p_stats->i_read_bytes,
-                    p_stats->f_bitrate * 1000 );
+                    p_stats->f_input_bitrate * 1000,
+                    p_stats->i_demux_read_packets, p_stats->i_demux_read_bytes,
+                    p_stats->f_demux_bitrate * 1000,
+                    p_stats->i_displayed_pictures, p_stats->i_lost_pictures,
+                    p_stats->i_played_abuffers, p_stats->i_lost_abuffers,
+                    p_stats->f_send_bitrate );
     vlc_mutex_unlock( &p_stats->lock );
 }
 
+#undef stats_TimerStart
+void stats_TimerStart( vlc_object_t *p_obj, const char *psz_name,
+                       unsigned int i_id )
+{
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+    counter_t *p_counter = NULL;
+
+    if( !priv->b_stats ) return;
+
+    vlc_mutex_lock( &priv->timer_lock );
+
+    for( int i = 0 ; i < priv->i_timers; i++ )
+    {
+        if( priv->pp_timers[i]->i_id == i_id
+            && priv->pp_timers[i]->p_obj == p_obj )
+        {
+            p_counter = priv->pp_timers[i];
+            break;
+        }
+    }
+    if( !p_counter )
+    {
+        counter_sample_t *p_sample;
+        p_counter = stats_CounterCreate( VLC_OBJECT(p_obj->p_libvlc),
+                                         VLC_VAR_TIME, STATS_TIMER );
+        if( !p_counter )
+            goto out;
+        p_counter->psz_name = strdup( psz_name );
+        p_counter->i_id = i_id;
+        p_counter->p_obj = p_obj;
+        INSERT_ELEM( priv->pp_timers, priv->i_timers,
+                     priv->i_timers, p_counter );
+
+        /* 1st sample : if started: start_date, else last_time, b_started */
+        p_sample = (counter_sample_t *)malloc( sizeof( counter_sample_t ) );
+        INSERT_ELEM( p_counter->pp_samples, p_counter->i_samples,
+                     p_counter->i_samples, p_sample );
+        p_sample->date = 0; p_sample->value.b_bool = 0;
+        /* 2nd sample : global_time, i_samples */
+        p_sample = (counter_sample_t *)malloc( sizeof( counter_sample_t ) );
+        INSERT_ELEM( p_counter->pp_samples, p_counter->i_samples,
+                     p_counter->i_samples, p_sample );
+        p_sample->date = 0; p_sample->value.i_int = 0;
+    }
+    if( p_counter->pp_samples[0]->value.b_bool == true )
+    {
+        msg_Warn( p_obj, "timer '%s' was already started !", psz_name );
+        goto out;
+    }
+    p_counter->pp_samples[0]->value.b_bool = true;
+    p_counter->pp_samples[0]->date = mdate();
+out:
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+#undef stats_TimerStop
+void stats_TimerStop( vlc_object_t *p_obj, unsigned int i_id )
+{
+    counter_t *p_counter = NULL;
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+
+    if( !priv->b_stats ) return;
+    vlc_mutex_lock( &priv->timer_lock );
+    for( int i = 0 ; i < priv->i_timers; i++ )
+    {
+        if( priv->pp_timers[i]->i_id == i_id
+            && priv->pp_timers[i]->p_obj == p_obj )
+        {
+            p_counter = priv->pp_timers[i];
+            break;
+        }
+    }
+    if( !p_counter || p_counter->i_samples != 2 )
+    {
+        msg_Err( p_obj, "timer does not exist" );
+        goto out;
+    }
+    p_counter->pp_samples[0]->value.b_bool = false;
+    p_counter->pp_samples[1]->value.i_int += 1;
+    p_counter->pp_samples[0]->date = mdate() - p_counter->pp_samples[0]->date;
+    p_counter->pp_samples[1]->date += p_counter->pp_samples[0]->date;
+out:
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+#undef stats_TimerDump
+void stats_TimerDump( vlc_object_t *p_obj, unsigned int i_id )
+{
+    counter_t *p_counter = NULL;
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+
+    if( !priv->b_stats ) return;
+    vlc_mutex_lock( &priv->timer_lock );
+    for( int i = 0 ; i < priv->i_timers; i++ )
+    {
+        if( priv->pp_timers[i]->i_id == i_id
+            && priv->pp_timers[i]->p_obj == p_obj )
+        {
+            p_counter = priv->pp_timers[i];
+            break;
+        }
+    }
+    TimerDump( p_obj, p_counter, true );
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+#undef stats_TimersDumpAll
+void stats_TimersDumpAll( vlc_object_t *p_obj )
+{
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+
+    if( !priv->b_stats ) return;
+    vlc_mutex_lock( &priv->timer_lock );
+    for ( int i = 0 ; i < priv->i_timers ; i++ )
+        TimerDump( p_obj, priv->pp_timers[i], false );
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+#undef stats_TimerClean
+void stats_TimerClean( vlc_object_t *p_obj, unsigned int i_id )
+{
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+
+    vlc_mutex_lock( &priv->timer_lock );
+    for ( int i = priv->i_timers -1 ; i >= 0; i-- )
+    {
+        counter_t *p_counter = priv->pp_timers[i];
+        if( p_counter->i_id == i_id && p_counter->p_obj == p_obj )
+        {
+            REMOVE_ELEM( priv->pp_timers, priv->i_timers, i );
+            stats_CounterClean( p_counter );
+        }
+    }
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+#undef stats_TimersCleanAll
+void stats_TimersCleanAll( vlc_object_t *p_obj )
+{
+    libvlc_priv_t *priv = libvlc_priv (p_obj->p_libvlc);
+
+    vlc_mutex_lock( &priv->timer_lock );
+    for ( int i = priv->i_timers -1 ; i >= 0; i-- )
+    {
+        counter_t *p_counter = priv->pp_timers[i];
+        REMOVE_ELEM( priv->pp_timers, priv->i_timers, i );
+        stats_CounterClean( p_counter );
+    }
+    vlc_mutex_unlock( &priv->timer_lock );
+}
+
+void stats_CounterClean( counter_t *p_c )
+{
+    if( p_c )
+    {
+        int i = p_c->i_samples - 1 ;
+        while( i >= 0 )
+        {
+            counter_sample_t *p_s = p_c->pp_samples[i];
+            REMOVE_ELEM( p_c->pp_samples, p_c->i_samples, i );
+            free( p_s );
+            i--;
+        }
+        free( p_c->psz_name );
+        free( p_c );
+    }
+}
+
 
 /********************************************************************
  * Following functions are local
@@ -255,14 +422,13 @@ void stats_DumpInputStats( input_stats_t *p_stats  )
  * Update a statistics counter, according to its type
  * If needed, perform a bit of computation (derivative, mostly)
  * This function must be entered with stats handler lock
- * \param p_handler stats handler singleton
  * \param p_counter the counter to update
  * \param val the "new" value
  * \return an error code
  */
-static int stats_CounterUpdate( stats_handler_t *p_handler,
-                                counter_t *p_counter,
-                                vlc_value_t val )
+static int CounterUpdate( vlc_object_t *p_handler,
+                          counter_t *p_counter,
+                          vlc_value_t val, vlc_value_t *new_val )
 {
     switch( p_counter->i_compute_type )
     {
@@ -278,7 +444,7 @@ static int stats_CounterUpdate( stats_handler_t *p_handler,
             p_counter->i_type != VLC_VAR_INTEGER &&
             p_counter->i_compute_type != STATS_LAST )
         {
-            msg_Err( p_handler, "Unable to compute MIN or MAX for this type");
+            msg_Err( p_handler, "unable to compute MIN or MAX for this type");
             return VLC_EGENERIC;
         }
 
@@ -314,17 +480,19 @@ static int stats_CounterUpdate( stats_handler_t *p_handler,
                     free( p_counter->pp_samples[0]->value.psz_string );
                 }
                 p_counter->pp_samples[0]->value = val;
+                *new_val = p_counter->pp_samples[0]->value;
             }
         }
         break;
     case STATS_DERIVATIVE:
     {
         counter_sample_t *p_new, *p_old;
-        if( mdate() - p_counter->last_update < p_counter->update_interval )
+        mtime_t now = mdate();
+        if( now - p_counter->last_update < p_counter->update_interval )
         {
             return VLC_EGENERIC;
         }
-        p_counter->last_update = mdate();
+        p_counter->last_update = now;
         if( p_counter->i_type != VLC_VAR_FLOAT &&
             p_counter->i_type != VLC_VAR_INTEGER )
         {
@@ -366,9 +534,14 @@ static int stats_CounterUpdate( stats_handler_t *p_handler,
             switch( p_counter->i_type )
             {
             case VLC_VAR_INTEGER:
-            case VLC_VAR_FLOAT:
                 p_counter->pp_samples[0]->value.i_int += val.i_int;
+                if( new_val )
+                    new_val->i_int = p_counter->pp_samples[0]->value.i_int;
                 break;
+            case VLC_VAR_FLOAT:
+                p_counter->pp_samples[0]->value.f_float += val.f_float;
+                if( new_val )
+                    new_val->f_float = p_counter->pp_samples[0]->value.f_float;
             default:
                 msg_Err( p_handler, "Trying to increment invalid variable %s",
                          p_counter->psz_name );
@@ -380,69 +553,43 @@ static int stats_CounterUpdate( stats_handler_t *p_handler,
     return VLC_SUCCESS;
 }
 
-static counter_t *GetCounter( stats_handler_t *p_handler, int i_object_id,
-                             char *psz_name )
+static void TimerDump( vlc_object_t *p_obj, counter_t *p_counter,
+                       bool b_total )
 {
-    int i;
-    for( i = 0; i< p_handler->i_counters; i++ )
+    if( !p_counter )
+        return;
+
+    mtime_t last, total;
+    int64_t i_total;
+    if( p_counter->i_samples != 2 )
     {
-        counter_t *p_counter = p_handler->pp_counters[i];
-        if( p_counter->i_source_object == i_object_id &&
-            !strcmp( p_counter->psz_name, psz_name ) )
-        {
-            return p_counter;
-        }
+        msg_Err( p_obj, "timer %s does not exist", p_counter->psz_name );
+        return;
     }
-    return NULL;
-}
-
-
-
-
-static stats_handler_t *stats_HandlerGet( vlc_object_t *p_this )
-{
-    stats_handler_t *p_handler = (stats_handler_t*)
-                          vlc_object_find( p_this->p_vlc, VLC_OBJECT_STATS,
-                                           FIND_ANYWHERE );
-    if( !p_handler )
+    i_total = p_counter->pp_samples[1]->value.i_int;
+    total = p_counter->pp_samples[1]->date;
+    if( p_counter->pp_samples[0]->value.b_bool == true )
     {
-        p_handler = stats_HandlerCreate( p_this );
-        if( !p_handler )
-        {
-            return NULL;
-        }
-        vlc_object_yield( p_handler );
+        last = mdate() - p_counter->pp_samples[0]->date;
+        i_total += 1;
+        total += last;
     }
-    return p_handler;
-}
-
-/**
- * Initialize statistics handler
- *
- * This function initializes the global statistics handler singleton,
- * \param p_this the parent VLC object
- */
-static stats_handler_t* stats_HandlerCreate( vlc_object_t *p_this )
-{
-    stats_handler_t *p_handler;
-
-    msg_Dbg( p_this, "creating statistics handler" );
-
-    p_handler = (stats_handler_t*) vlc_object_create( p_this,
-                                                      VLC_OBJECT_STATS );
-
-    if( !p_handler )
+    else
     {
-        msg_Err( p_this, "out of memory" );
-        return NULL;
+        last = p_counter->pp_samples[0]->date;
+    }
+    if( b_total )
+    {
+        msg_Dbg( p_obj,
+             "TIMER %s : %.3f ms - Total %.3f ms / %"PRId64" intvls (Avg %.3f ms)",
+             p_counter->psz_name, (float)last/1000, (float)total/1000, i_total,
+             (float)(total)/(1000*(float)i_total ) );
+    }
+    else
+    {
+        msg_Dbg( p_obj,
+             "TIMER %s : Total %.3f ms / %"PRId64" intvls (Avg %.3f ms)",
+             p_counter->psz_name, (float)total/1000, i_total,
+             (float)(total)/(1000*(float)i_total ) );
     }
-    p_handler->i_counters = 0;
-    p_handler->pp_counters = NULL;
-
-    /// \bug is it p_vlc or p_libvlc ?
-    vlc_object_attach( p_handler, p_this->p_vlc );
-
-    return p_handler;
 }
-
-