]> git.sesse.net Git - mlt/blobdiff - src/modules/avformat/producer_avformat.c
Improve previous fix (efebb3) to prevent infinite loop.
[mlt] / src / modules / avformat / producer_avformat.c
index a9f4ad64e2e057a93453e9f29f7bc6237a0471b3..49439f8cf35036ce888411ede87133fd742a0578 100644 (file)
@@ -34,7 +34,7 @@
 #ifdef SWSCALE
 #  include <libswscale/swscale.h>
 #endif
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
 #include <libavutil/samplefmt.h>
 #elif (LIBAVCODEC_VERSION_INT >= ((51<<16)+(71<<8)+0))
 const char *avcodec_get_sample_fmt_name(int sample_fmt);
@@ -57,7 +57,7 @@ const char *avcodec_get_sample_fmt_name(int sample_fmt);
 #define PIX_FMT_YUYV422 PIX_FMT_YUV422
 #endif
 
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
 #include <libavutil/opt.h>
 #define CODEC_TYPE_VIDEO      AVMEDIA_TYPE_VIDEO
 #define CODEC_TYPE_AUDIO      AVMEDIA_TYPE_AUDIO
@@ -91,9 +91,10 @@ struct producer_avformat_s
        int video_index;
        double start_time;
        int first_pts;
-       int last_position;
+       int64_t last_position;
        int seekable;
-       int current_position;
+       int64_t current_position;
+       mlt_position nonseek_position;
        int got_picture;
        int top_field_first;
        uint8_t *audio_buffer[ MAX_AUDIO_STREAMS ];
@@ -133,7 +134,7 @@ typedef struct producer_avformat_s *producer_avformat;
 
 // Forward references.
 static int list_components( char* file );
-static int producer_open( producer_avformat self, mlt_profile profile, const char *URL );
+static int producer_open( producer_avformat self, mlt_profile profile, const char *URL, int take_lock );
 static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int index );
 static void producer_avformat_close( producer_avformat );
 static void producer_close( mlt_producer parent );
@@ -184,7 +185,7 @@ mlt_producer producer_avformat_init( mlt_profile profile, const char *service, c
                        if ( strcmp( service, "avformat-novalidate" ) )
                        {
                                // Open the file
-                               if ( producer_open( self, profile, file ) != 0 )
+                               if ( producer_open( self, profile, file, 1 ) != 0 )
                                {
                                        // Clean up
                                        mlt_producer_close( producer );
@@ -201,14 +202,13 @@ mlt_producer producer_avformat_init( mlt_profile profile, const char *service, c
                                                av_close_input_file( self->video_format );
                                        self->video_format = NULL;
                                        avformat_unlock();
-
-                                       // Default the user-selectable indices from the auto-detected indices
-                                       mlt_properties_set_int( properties, "audio_index",  self->audio_index );
-                                       mlt_properties_set_int( properties, "video_index",  self->video_index );
                                }
                        }
                        if ( producer )
                        {
+                               // Default the user-selectable indices from the auto-detected indices
+                               mlt_properties_set_int( properties, "audio_index",  self->audio_index );
+                               mlt_properties_set_int( properties, "video_index",  self->video_index );
 #ifdef VDPAU
                                mlt_service_cache_set_size( MLT_PRODUCER_SERVICE(producer), "producer_avformat", 5 );
 #endif
@@ -342,7 +342,7 @@ static mlt_properties find_default_streams( producer_avformat self )
                                if ( self->audio_index < 0 )
                                        self->audio_index = i;
                                mlt_properties_set( meta_media, key, "audio" );
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
                                snprintf( key, sizeof(key), "meta.media.%d.codec.sample_fmt", i );
                                mlt_properties_set( meta_media, key, av_get_sample_fmt_name( codec_context->sample_fmt ) );
 #elif (LIBAVCODEC_VERSION_INT >= ((51<<16)+(71<<8)+0))
@@ -551,7 +551,7 @@ static char* parse_url( mlt_profile profile, const char* URL, AVInputFormat **fo
        char *url = strchr( protocol, ':' );
 
        // Only if there is not a protocol specification that avformat can handle
-#if LIBAVFORMAT_VERSION_MAJOR > 52
+#if LIBAVFORMAT_VERSION_MAJOR >= 53
        if ( url && avio_check( URL, 0 ) < 0 )
 #else
        if ( url && !url_exist( URL ) )
@@ -572,7 +572,8 @@ static char* parse_url( mlt_profile profile, const char* URL, AVInputFormat **fo
                        // These are required by video4linux2 (defaults)
                        params->width = profile->width;
                        params->height = profile->height;
-                       params->time_base= (AVRational){ profile->frame_rate_den, profile->frame_rate_num };
+                       if ( !strstr( URL, "&frame_rate" ) )
+                               params->time_base = (AVRational){ profile->frame_rate_den, profile->frame_rate_num };
                        params->channels = 2;
                        params->sample_rate = 48000;
 
@@ -582,7 +583,10 @@ static char* parse_url( mlt_profile profile, const char* URL, AVInputFormat **fo
                        {
                                url[0] = 0;
                                char *name = strdup( ++url );
-                               char *value = strchr( name, ':' );
+                               char *value = strchr( name, '=' );
+                               if ( !value )
+                                       // Also accept : as delimiter for backwards compatibility.
+                                       value = strchr( name, ':' );
                                if ( value )
                                {
                                        value[0] = 0;
@@ -616,8 +620,9 @@ static char* parse_url( mlt_profile profile, const char* URL, AVInputFormat **fo
                        }
                }
        }
+       result = strdup( result );
        free( protocol );
-       return strdup( result );
+       return result;
 }
 
 static int get_basic_info( producer_avformat self, mlt_profile profile, const char *filename )
@@ -665,8 +670,8 @@ static int get_basic_info( producer_avformat self, mlt_profile profile, const ch
        if ( format->pb )
        {
                // protocols can indicate if they support seeking
-#if LIBAVFORMAT_VERSION_MAJOR > 52
-               self->seekable = context->pb->seekable;
+#if LIBAVFORMAT_VERSION_MAJOR >= 53
+               self->seekable = format->pb->seekable;
 #else
                URLContext *uc = url_fileno( format->pb );
                if ( uc )
@@ -728,19 +733,22 @@ static int get_basic_info( producer_avformat self, mlt_profile profile, const ch
 /** Open the file.
 */
 
-static int producer_open( producer_avformat self, mlt_profile profile, const char *URL )
+static int producer_open( producer_avformat self, mlt_profile profile, const char *URL, int take_lock )
 {
        // Return an error code (0 == no error)
        int error = 0;
        mlt_properties properties = MLT_PRODUCER_PROPERTIES( self->parent );
 
        // Lock the service
-       pthread_mutex_init( &self->audio_mutex, NULL );
-       pthread_mutex_init( &self->video_mutex, NULL );
-       pthread_mutex_init( &self->packets_mutex, NULL );
+       if ( take_lock )
+       {
+               pthread_mutex_init( &self->audio_mutex, NULL );
+               pthread_mutex_init( &self->video_mutex, NULL );
+               pthread_mutex_init( &self->packets_mutex, NULL );
+               pthread_mutex_lock( &self->audio_mutex );
+               pthread_mutex_lock( &self->video_mutex );
+       }
        mlt_events_block( properties, self->parent );
-       pthread_mutex_lock( &self->audio_mutex );
-       pthread_mutex_lock( &self->video_mutex );
 
        // Parse URL
        AVInputFormat *format = NULL;
@@ -749,34 +757,33 @@ static int producer_open( producer_avformat self, mlt_profile profile, const cha
        char *filename = parse_url( profile, URL, &format, &params );
 
        // Now attempt to open the file or device with filename
-#if LIBAVFORMAT_VERSION_MAJOR > 52
-       self->video_format->flags |= AVFMT_FLAG_PRIV_OPT;
-#endif
        error = av_open_input_file( &self->video_format, filename, format, 0, &params ) < 0;
        if ( error )
                // If the URL is a network stream URL, then we probably need to open with full URL
                error = av_open_input_file( &self->video_format, URL, format, 0, &params ) < 0;
 
        // Set MLT properties onto video AVFormatContext
-       apply_properties( self->video_format, properties, AV_OPT_FLAG_DECODING_PARAM );
-#if LIBAVFORMAT_VERSION_MAJOR > 52
-       if ( self->video_format->iformat && self->video_format->iformat->priv_class && self->video_format->priv_data )
-               apply_properties( self->video_format->priv_data, properties, AV_OPT_FLAG_DECODING_PARAM );
-       av_demuxer_open( self->video_format, &params );
+       if ( !error && self->video_format )
+       {
+               apply_properties( self->video_format, properties, AV_OPT_FLAG_DECODING_PARAM );
+#if LIBAVFORMAT_VERSION_MAJOR >= 53
+               if ( self->video_format->iformat && self->video_format->iformat->priv_class && self->video_format->priv_data )
+                       apply_properties( self->video_format->priv_data, properties, AV_OPT_FLAG_DECODING_PARAM );
 #endif
+       }
 
        // Cleanup AVFormatParameters
        if ( params.standard )
                free( (void*) params.standard );
 
        // If successful, then try to get additional info
-       if ( !error )
+       if ( !error && self->video_format )
        {
                // Get the stream info
                error = av_find_stream_info( self->video_format ) < 0;
 
                // Continue if no error
-               if ( !error )
+               if ( !error && self->video_format )
                {
                        // Find default audio and video streams
                        find_default_streams( self );
@@ -786,40 +793,43 @@ static int producer_open( producer_avformat self, mlt_profile profile, const cha
                        self->first_pts = -1;
                        self->last_position = POSITION_INITIAL;
 
-                       // We're going to cheat here - for seekable A/V files, we will have separate contexts
-                       // to support independent seeking of audio from video.
-                       // TODO: Is this really necessary?
-                       if ( self->audio_index != -1 && self->video_index != -1 )
+                       if ( !self->audio_format )
                        {
-                               if ( self->seekable )
+                               // We're going to cheat here - for seekable A/V files, we will have separate contexts
+                               // to support independent seeking of audio from video.
+                               // TODO: Is this really necessary?
+                               if ( self->audio_index != -1 && self->video_index != -1 )
                                {
-                                       // And open again for our audio context
-                                       av_open_input_file( &self->audio_format, filename, NULL, 0, NULL );
-                                       apply_properties( self->audio_format, properties, AV_OPT_FLAG_DECODING_PARAM );
-#if LIBAVFORMAT_VERSION_MAJOR > 52
-                                       if ( self->audio_format->iformat && self->audio_format->iformat->priv_class && self->audio_format->priv_data )
-                                               apply_properties( self->audio_format->priv_data, properties, AV_OPT_FLAG_DECODING_PARAM );
+                                       if ( self->seekable )
+                                       {
+                                               // And open again for our audio context
+                                               av_open_input_file( &self->audio_format, filename, NULL, 0, NULL );
+                                               apply_properties( self->audio_format, properties, AV_OPT_FLAG_DECODING_PARAM );
+#if LIBAVFORMAT_VERSION_MAJOR >= 53
+                                               if ( self->audio_format->iformat && self->audio_format->iformat->priv_class && self->audio_format->priv_data )
+                                                       apply_properties( self->audio_format->priv_data, properties, AV_OPT_FLAG_DECODING_PARAM );
 #endif
-                                       av_find_stream_info( self->audio_format );
+                                               av_find_stream_info( self->audio_format );
+                                       }
+                                       else
+                                       {
+                                               self->audio_format = self->video_format;
+                                       }
                                }
-                               else
+                               else if ( self->audio_index != -1 )
                                {
+                                       // We only have an audio context
                                        self->audio_format = self->video_format;
+                                       self->video_format = NULL;
                                }
+                               else if ( self->video_index == -1 )
+                               {
+                                       // Something has gone wrong
+                                       error = -1;
+                               }
+                               if ( self->audio_format && !self->audio_streams )
+                                       get_audio_streams_info( self );
                        }
-                       else if ( self->audio_index != -1 )
-                       {
-                               // We only have an audio context
-                               self->audio_format = self->video_format;
-                               self->video_format = NULL;
-                       }
-                       else if ( self->video_index == -1 )
-                       {
-                               // Something has gone wrong
-                               error = -1;
-                       }
-                       if ( self->audio_format && !self->audio_streams )
-                               get_audio_streams_info( self );
                }
        }
        if ( filename )
@@ -832,13 +842,18 @@ static int producer_open( producer_avformat self, mlt_profile profile, const cha
 
        if ( self->dummy_context )
        {
+               avformat_lock();
                av_close_input_file( self->dummy_context );
+               avformat_unlock();
                self->dummy_context = NULL;
        }
 
        // Unlock the service
-       pthread_mutex_unlock( &self->audio_mutex );
-       pthread_mutex_unlock( &self->video_mutex );
+       if ( take_lock )
+       {
+               pthread_mutex_unlock( &self->audio_mutex );
+               pthread_mutex_unlock( &self->video_mutex );
+       }
        mlt_events_unblock( properties, self->parent );
 
        return error;
@@ -850,12 +865,9 @@ static void reopen_video( producer_avformat self, mlt_producer producer )
        mlt_service_lock( MLT_PRODUCER_SERVICE( producer ) );
        pthread_mutex_lock( &self->audio_mutex );
 
+       avformat_lock();
        if ( self->video_codec )
-       {
-               avformat_lock();
                avcodec_close( self->video_codec );
-               avformat_unlock();
-       }
        self->video_codec = NULL;
        if ( self->dummy_context )
                av_close_input_file( self->dummy_context );
@@ -863,16 +875,13 @@ static void reopen_video( producer_avformat self, mlt_producer producer )
        if ( self->video_format )
                av_close_input_file( self->video_format );
        self->video_format = NULL;
+       avformat_unlock();
 
        int audio_index = self->audio_index;
        int video_index = self->video_index;
 
-       pthread_mutex_unlock( &self->audio_mutex );
-       pthread_mutex_unlock( &self->video_mutex );
        producer_open( self, mlt_service_profile( MLT_PRODUCER_SERVICE(producer) ),
-               mlt_properties_get( properties, "resource" ) );
-       pthread_mutex_lock( &self->video_mutex );
-       pthread_mutex_lock( &self->audio_mutex );
+               mlt_properties_get( properties, "resource" ), 0 );
 
        self->audio_index = audio_index;
        if ( self->video_format && video_index > -1 )
@@ -886,7 +895,7 @@ static void reopen_video( producer_avformat self, mlt_producer producer )
 }
 
 static int seek_video( producer_avformat self, mlt_position position,
-       int req_position, int must_decode, int use_new_seek, int *ignore )
+       int64_t req_position, int must_decode, int use_new_seek, int *ignore )
 {
        mlt_producer producer = self->parent;
        int paused = 0;
@@ -933,7 +942,7 @@ static int seek_video( producer_avformat self, mlt_position position,
                                        ret = av_read_frame( context, &pkt );
                                        if ( ret >= 0 && ( pkt.flags & PKT_FLAG_KEY ) && pkt.stream_index == self->video_index )
                                        {
-                                               mlt_log_verbose( MLT_PRODUCER_SERVICE(producer), "first_pts %"PRId64" dts %"PRId64" pts_dts_delta %d\n", pkt.pts, pkt.dts, (int)(pkt.pts - pkt.dts) );
+                                               mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "first_pts %"PRId64" dts %"PRId64" pts_dts_delta %d\n", pkt.pts, pkt.dts, (int)(pkt.pts - pkt.dts) );
                                                self->first_pts = pkt.pts;
                                                toscan = 0;
                                        }
@@ -949,7 +958,7 @@ static int seek_video( producer_avformat self, mlt_position position,
                        {
                                timestamp = ( req_position - 0.1 / source_fps ) /
                                        ( av_q2d( stream->time_base ) * source_fps );
-                               mlt_log_verbose( MLT_PRODUCER_SERVICE(producer), "pos %d pts %"PRId64" ", req_position, timestamp );
+                               mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "pos %"PRId64" pts %"PRId64"\n", req_position, timestamp );
                                if ( self->first_pts > 0 )
                                        timestamp += self->first_pts;
                                else if ( context->start_time != AV_NOPTS_VALUE )
@@ -965,7 +974,7 @@ static int seek_video( producer_avformat self, mlt_position position,
                                timestamp -= AV_TIME_BASE;
                        if ( timestamp < 0 )
                                timestamp = 0;
-                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "seeking timestamp %"PRId64" position %d expected %d last_pos %d\n",
+                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "seeking timestamp %"PRId64" position %d expected %d last_pos %"PRId64"\n",
                                timestamp, position, self->video_expected, self->last_position );
 
                        // Seek to the timestamp
@@ -1303,18 +1312,20 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                mlt_properties_get_double( properties, "meta.media.frame_rate_den" );
 
        // This is the physical frame position in the source
-       int req_position = ( int )( position / mlt_producer_get_fps( producer ) * source_fps + 0.5 );
+       int64_t req_position = ( int64_t )( position / mlt_producer_get_fps( producer ) * source_fps + 0.5 );
 
        // Determines if we have to decode all frames in a sequence
        // Temporary hack to improve intra frame only
-       int must_decode = strcmp( codec_context->codec->name, "dnxhd" ) &&
+       int must_decode = !( codec_context->codec && codec_context->codec->name ) || (
+                                 strcmp( codec_context->codec->name, "dnxhd" ) &&
                                  strcmp( codec_context->codec->name, "dvvideo" ) &&
                                  strcmp( codec_context->codec->name, "huffyuv" ) &&
                                  strcmp( codec_context->codec->name, "mjpeg" ) &&
-                                 strcmp( codec_context->codec->name, "rawvideo" );
+                                 strcmp( codec_context->codec->name, "rawvideo" ) );
 
        // Turn on usage of new seek API and PTS for seeking
-       int use_new_seek = codec_context->codec_id == CODEC_ID_H264 && !strcmp( context->iformat->name, "mpegts" );
+       int use_new_seek = self->seekable &&
+               codec_context->codec_id == CODEC_ID_H264 && !strcmp( context->iformat->name, "mpegts" );
        if ( mlt_properties_get( properties, "new_seek" ) )
                use_new_seek = mlt_properties_get_int( properties, "new_seek" );
 
@@ -1327,7 +1338,7 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        codec_context = stream->codec;
 
        // Duplicate the last image if necessary
-       if ( self->av_frame && self->av_frame->linesize[0] && self->got_picture && self->seekable
+       if ( self->av_frame && self->av_frame->linesize[0] && self->got_picture
                 && ( paused
                          || self->current_position == req_position
                          || ( !use_new_seek && self->current_position > req_position ) ) )
@@ -1362,7 +1373,7 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        else
        {
                int ret = 0;
-               int int_position = 0;
+               int64_t int_position = 0;
                int decode_errors = 0;
                int got_picture = 0;
 
@@ -1408,7 +1419,7 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                                pts -= self->first_pts;
                                        else if ( context->start_time != AV_NOPTS_VALUE )
                                                pts -= context->start_time;
-                                       int_position = ( int )( av_q2d( stream->time_base ) * pts * source_fps + 0.1 );
+                                       int_position = ( int64_t )( av_q2d( stream->time_base ) * pts * source_fps + 0.1 );
                                        if ( pkt.pts == AV_NOPTS_VALUE )
                                        {
                                                self->invalid_pts_counter++;
@@ -1424,24 +1435,21 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                        {
                                                self->invalid_pts_counter = 0;
                                        }
-                                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "pkt.pts %"PRId64" req_pos %d cur_pos %d pkt_pos %d\n",
+                                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "pkt.pts %"PRId64" req_pos %"PRId64" cur_pos %"PRId64" pkt_pos %"PRId64"\n",
                                                pkt.pts, req_position, self->current_position, int_position );
                                }
                                else
                                {
-                                       if ( self->seekable && pkt.dts != AV_NOPTS_VALUE )
+                                       if ( pkt.dts != AV_NOPTS_VALUE )
                                        {
-                                               int_position = ( int )( av_q2d( stream->time_base ) * pkt.dts * source_fps + 0.5 );
+                                               double delay = mlt_properties_get_double( properties, "video_delay" );
+                                               int_position = ( int64_t )( ( av_q2d( stream->time_base ) * pkt.dts + delay ) * source_fps + 0.5 );
                                                if ( context->start_time != AV_NOPTS_VALUE )
-                                                       int_position -= ( int )( context->start_time * source_fps / AV_TIME_BASE + 0.5 );
+                                                       int_position -= ( int64_t )( context->start_time * source_fps / AV_TIME_BASE + 0.5 );
                                                if ( int_position == self->last_position )
                                                        int_position = self->last_position + 1;
                                        }
-                                       else
-                                       {
-                                               int_position = req_position;
-                                       }
-                                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "pkt.dts %"PRId64" req_pos %d cur_pos %d pkt_pos %d\n",
+                                       mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "pkt.dts %"PRId64" req_pos %"PRId64" cur_pos %"PRId64" pkt_pos %"PRId64"\n",
                                                pkt.dts, req_position, self->current_position, int_position );
                                        // Make a dumb assumption on streams that contain wild timestamps
                                        if ( abs( req_position - int_position ) > 999 )
@@ -1497,8 +1505,8 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                                        pts -= self->first_pts;
                                                else if ( context->start_time != AV_NOPTS_VALUE )
                                                        pts -= context->start_time;
-                                               int_position = ( int )( av_q2d( stream->time_base) * pts * source_fps + 0.1 );
-                                               mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "got frame %d, key %d\n", int_position, self->av_frame->key_frame );
+                                               int_position = ( int64_t )( av_q2d( stream->time_base) * pts * source_fps + 0.1 );
+                                               mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "got frame %"PRId64", key %d\n", int_position, self->av_frame->key_frame );
                                        }
                                        // Handle ignore
                                        if ( int_position < req_position )
@@ -1732,7 +1740,7 @@ static int video_codec_init( producer_avformat self, int index, mlt_properties p
 
                // Process properties as AVOptions
                apply_properties( codec_context, properties, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_DECODING_PARAM );
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
                if ( codec->priv_class && codec_context->priv_data )
                        apply_properties( codec_context->priv_data, properties, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_DECODING_PARAM );
 #endif
@@ -1853,7 +1861,7 @@ static void producer_set_up_video( producer_avformat self, mlt_frame frame )
        if ( !context && index > -1 )
        {
                producer_open( self, mlt_service_profile( MLT_PRODUCER_SERVICE(producer) ),
-                       mlt_properties_get( properties, "resource" ) );
+                       mlt_properties_get( properties, "resource" ), 1 );
                context = self->video_format;
        }
 
@@ -1878,13 +1886,11 @@ static void producer_set_up_video( producer_avformat self, mlt_frame frame )
        {
                // Reset the video properties if the index changed
                self->video_index = index;
+               avformat_lock();
                if ( self->video_codec )
-               {
-                       avformat_lock();
                        avcodec_close( self->video_codec );
-                       avformat_unlock();
-               }
                self->video_codec = NULL;
+               avformat_unlock();
        }
 
        // Get the frame properties
@@ -1968,7 +1974,7 @@ static int seek_audio( producer_avformat self, mlt_position position, double tim
 
 static int sample_bytes( AVCodecContext *context )
 {
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
        return av_get_bits_per_sample_fmt( context->sample_fmt ) / 8;
 #else
        return av_get_bits_per_sample_format( context->sample_fmt ) / 8;
@@ -2048,10 +2054,10 @@ static int decode_audio( producer_avformat self, int *ignore, AVPacket pkt, int
                        }
 
                        // Handle ignore
-                       while ( *ignore && audio_used > samples )
+                       while ( *ignore && audio_used )
                        {
                                *ignore -= 1;
-                               audio_used -= samples;
+                               audio_used -= audio_used > samples ? samples : audio_used;
                                memmove( audio_buffer, &audio_buffer[ samples * (resample? channels : codec_context->channels) * sizeof_sample ],
                                                 audio_used * sizeof_sample );
                        }
@@ -2062,17 +2068,21 @@ static int decode_audio( producer_avformat self, int *ignore, AVPacket pkt, int
        if ( pkt.pts >= 0 )
        {
                double current_pts = av_q2d( context->streams[ index ]->time_base ) * pkt.pts;
-               int req_position = ( int )( timecode * fps + 0.5 );
-               int int_position = ( int )( current_pts * fps + 0.5 );
+               int64_t req_position = ( int64_t )( timecode * fps + 0.5 );
+               int64_t int_position = ( int64_t )( current_pts * fps + 0.5 );
                if ( context->start_time != AV_NOPTS_VALUE )
-                       int_position -= ( int )( fps * context->start_time / AV_TIME_BASE + 0.5 );
+                       int_position -= ( int64_t )( fps * context->start_time / AV_TIME_BASE + 0.5 );
 
-               if ( self->seekable && *ignore == 0 )
+               if ( *ignore == 0 )
                {
                        if ( int_position < req_position )
                                // We are behind, so skip some
-                               *ignore = 1;
-                       else if ( int_position > req_position + 2 )
+                               *ignore = req_position - int_position;
+
+                       // We use total_channels in this test because the tolerance is dependent
+                       // on the interleaving of all streams esp. when there is more than
+                       // one audio stream.
+                       else if ( int_position > req_position + self->total_channels )
                                // We are ahead, so seek backwards some more
                                seek_audio( self, req_position, timecode - 1.0, ignore );
                }
@@ -2102,10 +2112,15 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
        double fps = mlt_producer_get_fps( self->parent );
 
        // Number of frames to ignore (for ffwd)
-       int ignore = 0;
+       int ignore[ MAX_AUDIO_STREAMS ] = { 0 };
 
        // Flag for paused (silence)
-       int paused = seek_audio( self, position, real_timecode, &ignore );
+       int paused = seek_audio( self, position, real_timecode, &ignore[0] );
+
+       // Initialize ignore for all streams from the seek return value
+       int i = MAX_AUDIO_STREAMS;
+       while ( i-- )
+               ignore[i] = ignore[0];
 
        // Fetch the audio_format
        AVFormatContext *context = self->audio_format;
@@ -2186,11 +2201,23 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                while ( ret >= 0 && !got_audio )
                {
                        // Check if the buffer already contains the samples required
-                       if ( self->audio_index != INT_MAX && self->audio_used[ self->audio_index ] >= *samples && ignore == 0 )
+                       if ( self->audio_index != INT_MAX &&
+                                self->audio_used[ self->audio_index ] >= *samples &&
+                                ignore[ self->audio_index ] == 0 )
                        {
                                got_audio = 1;
                                break;
                        }
+                       else if ( self->audio_index == INT_MAX )
+                       {
+                               // Check if there is enough audio for all streams
+                               got_audio = 1;
+                               for ( index = 0; got_audio && index < context->nb_streams; index++ )
+                                       if ( ( self->audio_codec[ index ] && self->audio_used[ index ] < *samples ) || ignore[ index ] )
+                                               got_audio = 0;
+                               if ( got_audio )
+                                       break;
+                       }
 
                        // Read a packet
                        pthread_mutex_lock( &self->packets_mutex );
@@ -2222,22 +2249,12 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                        {
                                int channels2 = ( self->audio_index == INT_MAX || !self->audio_resample[index] ) ?
                                        self->audio_codec[index]->channels : *channels;
-                               ret = decode_audio( self, &ignore, pkt, channels2, *samples, real_timecode, fps );
+                               ret = decode_audio( self, &ignore[index], pkt, channels2, *samples, real_timecode, fps );
                        }
 
                        if ( self->seekable || index != self->video_index )
                                av_free_packet( &pkt );
 
-                       if ( self->audio_index == INT_MAX && ret >= 0 )
-                       {
-                               // Determine if there is enough audio for all streams
-                               got_audio = 1;
-                               for ( index = 0; index < context->nb_streams; index++ )
-                               {
-                                       if ( self->audio_codec[ index ] && self->audio_used[ index ] < *samples )
-                                               got_audio = 0;
-                               }
-                       }
                }
 
                // Set some additional return values
@@ -2369,7 +2386,7 @@ static int audio_codec_init( producer_avformat self, int index, mlt_properties p
 
                // Process properties as AVOptions
                apply_properties( codec_context, properties, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_DECODING_PARAM );
-#if LIBAVCODEC_VERSION_MAJOR > 52
+#if LIBAVCODEC_VERSION_MAJOR >= 53
                if ( codec && codec->priv_class && codec_context->priv_data )
                        apply_properties( codec_context->priv_data, properties, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_DECODING_PARAM );
 #endif
@@ -2406,7 +2423,7 @@ static void producer_set_up_audio( producer_avformat self, mlt_frame frame )
        if ( !context && self->audio_index > -1 && index > -1 )
        {
                producer_open( self, mlt_service_profile( MLT_PRODUCER_SERVICE(producer) ),
-                       mlt_properties_get( properties, "resource" ) );
+                       mlt_properties_get( properties, "resource" ), 1 );
                context = self->audio_format;
        }
 
@@ -2428,13 +2445,11 @@ static void producer_set_up_audio( producer_avformat self, mlt_frame frame )
        // Update the audio properties if the index changed
        if ( context && index > -1 && index != self->audio_index )
        {
+               avformat_lock();
                if ( self->audio_codec[ self->audio_index ] )
-               {
-                       avformat_lock();
                        avcodec_close( self->audio_codec[ self->audio_index ] );
-                       avformat_unlock();
-               }
                self->audio_codec[ self->audio_index ] = NULL;
+               avformat_unlock();
        }
        if ( self->audio_index != -1 )
                self->audio_index = index;
@@ -2505,15 +2520,16 @@ static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int i
        // Update timecode on the frame we're creating
        mlt_frame_set_position( *frame, mlt_producer_position( producer ) );
 
-       // Set the position of this producer
-       mlt_properties_set_position( MLT_FRAME_PROPERTIES( *frame ), "avformat_position", mlt_producer_frame( producer ) );
-       
        // Set up the video
        producer_set_up_video( self, *frame );
 
        // Set up the audio
        producer_set_up_audio( self, *frame );
 
+       // Set the position of this producer
+       mlt_position position = self->seekable ? mlt_producer_frame( producer ) : self->nonseek_position++;
+       mlt_properties_set_position( MLT_FRAME_PROPERTIES( *frame ), "avformat_position", position );
+
        // Calculate the next timecode
        mlt_producer_prepare_next( producer );
 
@@ -2536,9 +2552,11 @@ static void producer_avformat_close( producer_avformat self )
                av_free( self->decode_buffer[i] );
                if ( self->audio_codec[i] )
                        avcodec_close( self->audio_codec[i] );
+               self->audio_codec[i] = NULL;
        }
        if ( self->video_codec )
                avcodec_close( self->video_codec );
+       self->video_codec = NULL;
        // Close the file
        if ( self->dummy_context )
                av_close_input_file( self->dummy_context );