]> git.sesse.net Git - mlt/blobdiff - src/modules/avformat/producer_avformat.c
Fix crash when repeating frames after failure to decode video.
[mlt] / src / modules / avformat / producer_avformat.c
index 738647e94f55ef3590d12ac38d8d45f92f338fa2..8f4274cbf42dd3e532f638c3edc57ab9ffe05620 100644 (file)
@@ -47,7 +47,6 @@
 #include <string.h>
 #include <pthread.h>
 #include <limits.h>
-#include <dlfcn.h>
 
 #if LIBAVUTIL_VERSION_INT < (50<<16)
 #define PIX_FMT_RGB32 PIX_FMT_RGBA32
@@ -57,7 +56,7 @@
 #define POSITION_INITIAL (-2)
 #define POSITION_INVALID (-1)
 
-#define MAX_AUDIO_STREAMS (8)
+#define MAX_AUDIO_STREAMS (10)
 #define MAX_VDPAU_SURFACES (10)
 
 void avformat_lock( );
@@ -95,6 +94,7 @@ struct producer_avformat_s
        int max_frequency;
        unsigned int invalid_pts_counter;
        double resample_factor;
+       mlt_cache image_cache;
 #ifdef VDPAU
        struct
        {
@@ -115,7 +115,6 @@ typedef struct producer_avformat_s *producer_avformat;
 // Forward references.
 static int producer_open( producer_avformat this, mlt_profile profile, char *file );
 static int producer_get_frame( mlt_producer this, mlt_frame_ptr frame, int index );
-static void producer_format_close( void *context );
 static void producer_avformat_close( producer_avformat );
 static void producer_close( mlt_producer parent );
 
@@ -126,7 +125,7 @@ static void producer_close( mlt_producer parent );
 /** Constructor for libavformat.
 */
 
-mlt_producer producer_avformat_init( mlt_profile profile, char *file )
+mlt_producer producer_avformat_init( mlt_profile profile, const char *service, char *file )
 {
        int skip = 0;
 
@@ -185,19 +184,42 @@ mlt_producer producer_avformat_init( mlt_profile profile, char *file )
                        // Register our get_frame implementation
                        producer->get_frame = producer_get_frame;
                        
-                       // Open the file
-                       if ( producer_open( this, profile, file ) != 0 )
+                       if ( strcmp( service, "avformat-novalidate" ) )
                        {
-                               // Clean up
-                               mlt_producer_close( producer );
-                               producer = NULL;
+                               // Open the file
+                               if ( producer_open( this, profile, file ) != 0 )
+                               {
+                                       // Clean up
+                                       mlt_producer_close( producer );
+                                       producer = NULL;
+                               }
+                               else
+                               {
+                                       // Close the file to release resources for large playlists - reopen later as needed
+                                       avformat_lock();
+                                       if ( this->dummy_context )
+                                               av_close_input_file( this->dummy_context );
+                                       this->dummy_context = NULL;
+                                       if ( this->audio_format )
+                                               av_close_input_file( this->audio_format );
+                                       this->audio_format = NULL;
+                                       if ( this->video_format )
+                                               av_close_input_file( this->video_format );
+                                       this->video_format = NULL;
+                                       avformat_unlock();
+       
+                                       // Default the user-selectable indices from the auto-detected indices
+                                       mlt_properties_set_int( properties, "audio_index",  this->audio_index );
+                                       mlt_properties_set_int( properties, "video_index",  this->video_index );
+                                       
+#ifdef VDPAU
+                                       mlt_service_cache_set_size( MLT_PRODUCER_SERVICE(producer), "producer_avformat", 5 );
+#endif
+                                       mlt_service_cache_put( MLT_PRODUCER_SERVICE(producer), "producer_avformat", this, 0, (mlt_destructor) producer_avformat_close );
+                               }
                        }
                        else
                        {
-                               // Default the user-selectable indices from the auto-detected indices
-                               mlt_properties_set_int( properties, "audio_index",  this->audio_index );
-                               mlt_properties_set_int( properties, "video_index",  this->video_index );
-                               
 #ifdef VDPAU
                                mlt_service_cache_set_size( MLT_PRODUCER_SERVICE(producer), "producer_avformat", 5 );
 #endif
@@ -290,42 +312,6 @@ static mlt_properties find_default_streams( mlt_properties meta_media, AVFormatC
        return meta_media;
 }
 
-/** Producer file destructor.
-*/
-
-static void producer_format_close( void *context )
-{
-       if ( context )
-       {
-               // Lock the mutex now
-               avformat_lock( );
-
-               // Close the file
-               av_close_input_file( context );
-
-               // Unlock the mutex now
-               avformat_unlock( );
-       }
-}
-
-/** Producer file destructor.
-*/
-
-static void producer_codec_close( void *codec )
-{
-       if ( codec )
-       {
-               // Lock the mutex now
-               avformat_lock( );
-
-               // Close the file
-               avcodec_close( codec );
-
-               // Unlock the mutex now
-               avformat_unlock( );
-       }
-}
-
 static inline int dv_is_pal( AVPacket *pkt )
 {
        return pkt->data[3] & 0x80;
@@ -463,8 +449,6 @@ static int producer_open( producer_avformat this, mlt_profile profile, char *fil
                        params->sample_rate = 48000;
                }
 
-               // XXX: this does not work anymore since avdevice
-               // TODO: make producer_avddevice?
                // Parse out params
                mrl = strchr( file, '?' );
                while ( mrl )
@@ -541,6 +525,7 @@ static int producer_open( producer_avformat this, mlt_profile profile, char *fil
 
                        // Check if we're seekable (something funny about mpeg here :-/)
                        if ( strncmp( file, "pipe:", 5 ) &&
+                                strncmp( file, "/dev/", 5 ) &&
                                 strncmp( file, "http:", 5 ) &&
                                 strncmp( file, "udp:", 4 )  &&
                                 strncmp( file, "tcp:", 4 )  &&
@@ -549,7 +534,6 @@ static int producer_open( producer_avformat this, mlt_profile profile, char *fil
                        {
                                this->seekable = av_seek_frame( context, -1, this->start_time, AVSEEK_FLAG_BACKWARD ) >= 0;
                                mlt_properties_set_int( properties, "seekable", this->seekable );
-                               producer_format_close( this->dummy_context );
                                this->dummy_context = context;
                                av_open_input_file( &context, file, NULL, 0, NULL );
                                av_find_stream_info( context );
@@ -611,9 +595,6 @@ static int producer_open( producer_avformat this, mlt_profile profile, char *fil
                        if ( av == 0 && audio_index != -1 && video_index != -1 )
                        {
                                // We'll use the open one as our video_format
-                               avformat_unlock();
-                               producer_format_close( this->video_format );
-                               avformat_lock();
                                this->video_format = context;
 
                                // And open again for our audio context
@@ -621,25 +602,16 @@ static int producer_open( producer_avformat this, mlt_profile profile, char *fil
                                av_find_stream_info( context );
 
                                // Audio context
-                               avformat_unlock();
-                               producer_format_close( this->audio_format );
-                               avformat_lock();
                                this->audio_format = context;
                        }
                        else if ( av != 2 && video_index != -1 )
                        {
                                // We only have a video context
-                               avformat_unlock();
-                               producer_format_close( this->video_format );
-                               avformat_lock();
                                this->video_format = context;
                        }
                        else if ( audio_index != -1 )
                        {
                                // We only have an audio context
-                               avformat_unlock();
-                               producer_format_close( this->audio_format );
-                               avformat_lock();
                                this->audio_format = context;
                        }
                        else
@@ -711,7 +683,7 @@ static inline void convert_image( AVFrame *frame, uint8_t *buffer, int pix_fmt,
        {
                *format = mlt_image_rgb24a;
                struct SwsContext *context = sws_getContext( width, height, pix_fmt,
-                       width, height, PIX_FMT_RGBA, SWS_FAST_BILINEAR, NULL, NULL, NULL);
+                       width, height, PIX_FMT_RGBA, SWS_BILINEAR, NULL, NULL, NULL);
                AVPicture output;
                avpicture_fill( &output, buffer, PIX_FMT_RGBA, width, height );
                sws_scale( context, frame->data, frame->linesize, 0, height,
@@ -721,7 +693,7 @@ static inline void convert_image( AVFrame *frame, uint8_t *buffer, int pix_fmt,
        else if ( *format == mlt_image_yuv420p )
        {
                struct SwsContext *context = sws_getContext( width, height, pix_fmt,
-                       width, height, PIX_FMT_YUV420P, SWS_FAST_BILINEAR, NULL, NULL, NULL);
+                       width, height, PIX_FMT_YUV420P, SWS_BILINEAR, NULL, NULL, NULL);
                AVPicture output;
                output.data[0] = buffer;
                output.data[1] = buffer + width * height;
@@ -736,7 +708,7 @@ static inline void convert_image( AVFrame *frame, uint8_t *buffer, int pix_fmt,
        else if ( *format == mlt_image_rgb24 )
        {
                struct SwsContext *context = sws_getContext( width, height, pix_fmt,
-                       width, height, PIX_FMT_RGB24, SWS_FAST_BILINEAR, NULL, NULL, NULL);
+                       width, height, PIX_FMT_RGB24, SWS_BILINEAR, NULL, NULL, NULL);
                AVPicture output;
                avpicture_fill( &output, buffer, PIX_FMT_RGB24, width, height );
                sws_scale( context, frame->data, frame->linesize, 0, height,
@@ -746,7 +718,7 @@ static inline void convert_image( AVFrame *frame, uint8_t *buffer, int pix_fmt,
        else if ( *format == mlt_image_rgb24a || *format == mlt_image_opengl )
        {
                struct SwsContext *context = sws_getContext( width, height, pix_fmt,
-                       width, height, PIX_FMT_RGBA, SWS_FAST_BILINEAR, NULL, NULL, NULL);
+                       width, height, PIX_FMT_RGBA, SWS_BILINEAR, NULL, NULL, NULL);
                AVPicture output;
                avpicture_fill( &output, buffer, PIX_FMT_RGBA, width, height );
                sws_scale( context, frame->data, frame->linesize, 0, height,
@@ -756,7 +728,7 @@ static inline void convert_image( AVFrame *frame, uint8_t *buffer, int pix_fmt,
        else
        {
                struct SwsContext *context = sws_getContext( width, height, pix_fmt,
-                       width, height, PIX_FMT_YUYV422, SWS_FAST_BILINEAR, NULL, NULL, NULL);
+                       width, height, PIX_FMT_YUYV422, SWS_BILINEAR, NULL, NULL, NULL);
                AVPicture output;
                avpicture_fill( &output, buffer, PIX_FMT_YUYV422, width, height );
                sws_scale( context, frame->data, frame->linesize, 0, height,
@@ -859,8 +831,6 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        // Get the producer properties
        mlt_properties properties = MLT_PRODUCER_PROPERTIES( producer );
 
-       avformat_lock();
-
        // Fetch the video format context
        AVFormatContext *context = this->video_format;
 
@@ -870,6 +840,53 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        // Get codec context
        AVCodecContext *codec_context = stream->codec;
 
+       // Get the image cache
+       if ( ! this->image_cache && ! mlt_properties_get_int( properties, "noimagecache" ) )
+               this->image_cache = mlt_cache_init();
+       if ( this->image_cache )
+       {
+               mlt_cache_item item = mlt_cache_get( this->image_cache, (void*) position );
+               *buffer = mlt_cache_item_data( item, format );
+               if ( *buffer )
+               {
+                       // Set the resolution
+                       *width = codec_context->width;
+                       *height = codec_context->height;
+                       mlt_properties_set_int( frame_properties, "width", *width );
+                       mlt_properties_set_int( frame_properties, "height", *height );
+
+                       // Cache hit
+                       int size;
+                       switch ( *format )
+                       {
+                               case mlt_image_yuv420p:
+                                       size = *width * 3 * ( *height + 1 ) / 2;
+                                       break;
+                               case mlt_image_rgb24:
+                                       size = *width * ( *height + 1 ) * 3;
+                                       break;
+                               case mlt_image_rgb24a:
+                               case mlt_image_opengl:
+                                       size = *width * ( *height + 1 ) * 4;
+                                       break;
+                               default:
+                                       *format = mlt_image_yuv422;
+                                       size = *width * ( *height + 1 ) * 2;
+                                       break;
+                       }
+                       mlt_properties_set_data( frame_properties, "avformat.image_cache", item, 0, ( mlt_destructor )mlt_cache_item_close, NULL );
+                       mlt_properties_set_data( frame_properties, "image", *buffer, size, NULL, NULL );
+                       this->top_field_first = mlt_properties_get_int( frame_properties, "top_field_first" );
+                       this->got_picture = 1;
+
+                       goto exit_get_image;
+               }
+       }
+       // Cache miss
+       int image_size = 0;
+
+       avformat_lock();
+
        // Packet
        AVPacket pkt;
 
@@ -988,13 +1005,13 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        }
 
        // Duplicate the last image if necessary (see comment on rawvideo below)
-       if ( this->av_frame && this->got_picture && this->seekable
+       if ( this->av_frame && this->av_frame->linesize[0] && this->got_picture && this->seekable
                 && ( paused
                          || this->current_position == req_position
                          || ( !use_new_seek && this->current_position > req_position ) ) )
        {
                // Duplicate it
-               if ( allocate_buffer( frame_properties, codec_context, buffer, format, width, height ) )
+               if ( ( image_size = allocate_buffer( frame_properties, codec_context, buffer, format, width, height ) ) )
 #ifdef VDPAU
                        if ( this->vdpau && this->vdpau->buffer )
                        {
@@ -1133,7 +1150,7 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                                else if ( context->start_time != AV_NOPTS_VALUE )
                                                        pts -= context->start_time;
                                                int_position = ( int )( av_q2d( stream->time_base) * pts * source_fps + 0.1 );
-                                               mlt_log_verbose( MLT_PRODUCER_SERVICE(producer), "got frame %d, key %d\n", int_position, this->av_frame->key_frame );
+                                               mlt_log_debug( MLT_PRODUCER_SERVICE(producer), "got frame %d, key %d\n", int_position, this->av_frame->key_frame );
                                        }
                                        // Handle ignore
                                        if ( int_position < req_position )
@@ -1162,7 +1179,7 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                        // Now handle the picture if we have one
                        if ( got_picture )
                        {
-                               if ( allocate_buffer( frame_properties, codec_context, buffer, format, width, height ) )
+                               if ( ( image_size = allocate_buffer( frame_properties, codec_context, buffer, format, width, height ) ) )
                                {
 #ifdef VDPAU
                                        if ( this->vdpau )
@@ -1204,8 +1221,6 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                        else
 #endif
                                        convert_image( this->av_frame, *buffer, codec_context->pix_fmt, format, *width, *height );
-                                       if ( !mlt_properties_get( properties, "force_progressive" ) )
-                                               mlt_properties_set_int( frame_properties, "progressive", !this->av_frame->interlaced_frame );
                                        this->top_field_first |= this->av_frame->top_field_first;
                                        this->current_position = int_position;
                                        this->got_picture = 1;
@@ -1216,24 +1231,32 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                                }
                        }
                }
-               if ( !got_picture )
-                       mlt_frame_get_image( frame, buffer, format, width, height, writable );
        }
 
-       // Very untidy - for rawvideo, the packet contains the frame, hence the free packet
-       // above will break the pause behaviour - so we wipe the frame now
-       if ( !strcmp( codec_context->codec->name, "rawvideo" ) )
-               av_freep( &this->av_frame );
-
        avformat_unlock();
 
+       if ( this->got_picture && image_size > 0 && this->image_cache )
+       {
+               // Copy buffer to image cache   
+               uint8_t *image = mlt_pool_alloc( image_size );
+               memcpy( image, *buffer, image_size );
+               mlt_cache_put( this->image_cache, (void*) position, image, *format, mlt_pool_release );
+       }
+
+exit_get_image:
+       // Set the progressive flag
+       if ( mlt_properties_get( properties, "force_progressive" ) )
+               mlt_properties_set_int( frame_properties, "progressive", !!mlt_properties_get_int( properties, "force_progressive" ) );
+       else if ( this->av_frame )
+               mlt_properties_set_int( frame_properties, "progressive", !this->av_frame->interlaced_frame );
+
        // Set the field order property for this frame
        mlt_properties_set_int( frame_properties, "top_field_first", this->top_field_first );
 
        // Regardless of speed, we expect to get the next frame (cos we ain't too bright)
        this->video_expected = position + 1;
 
-       return 0;
+       return !this->got_picture;
 }
 
 /** Process properties as AVOptions and apply to AV context obj
@@ -1247,14 +1270,17 @@ static void apply_properties( void *obj, mlt_properties properties, int flags )
        {
                const char *opt_name = mlt_properties_get_name( properties, i );
                const AVOption *opt = av_find_opt( obj, opt_name, NULL, flags, flags );
-               if ( opt )
+               if ( opt_name && mlt_properties_get( properties, opt_name ) )
+               {
+                       if ( opt )
 #if LIBAVCODEC_VERSION_INT >= ((52<<16)+(7<<8)+0)
-                       av_set_string3( obj, opt_name, mlt_properties_get( properties, opt_name), 0, NULL );
+                               av_set_string3( obj, opt_name, mlt_properties_get( properties, opt_name), 0, NULL );
 #elif LIBAVCODEC_VERSION_INT >= ((51<<16)+(59<<8)+0)
-                       av_set_string2( obj, opt_name, mlt_properties_get( properties, opt_name), 0 );
+                               av_set_string2( obj, opt_name, mlt_properties_get( properties, opt_name), 0 );
 #else
-                       av_set_string( obj, opt_name, mlt_properties_get( properties, opt_name) );
+                               av_set_string( obj, opt_name, mlt_properties_get( properties, opt_name) );
 #endif
+               }
        }
 }
 
@@ -1321,7 +1347,9 @@ static int video_codec_init( producer_avformat this, int index, mlt_properties p
                // Reset some image properties
                mlt_properties_set_int( properties, "width", this->video_codec->width );
                mlt_properties_set_int( properties, "height", this->video_codec->height );
-               mlt_properties_set_double( properties, "aspect_ratio", get_aspect_ratio( stream, this->video_codec, NULL ) );
+               // For DV, we'll just use the saved aspect ratio
+               if ( codec_context->codec_id != CODEC_ID_DVVIDEO )
+                       mlt_properties_set_double( properties, "aspect_ratio", get_aspect_ratio( stream, this->video_codec, NULL ) );
 
                // Determine the fps first from the codec
                double source_fps = (double) this->video_codec->time_base.den /
@@ -1373,7 +1401,12 @@ static void producer_set_up_video( producer_avformat this, mlt_frame frame )
                producer_open( this, mlt_service_profile( MLT_PRODUCER_SERVICE(producer) ),
                        mlt_properties_get( properties, "resource" ) );
                context = this->video_format;
-               producer_format_close( this->dummy_context );
+               if ( this->dummy_context )
+               {
+                       avformat_lock();
+                       av_close_input_file( this->dummy_context );
+                       avformat_unlock();
+               }
                this->dummy_context = NULL;
                mlt_events_unblock( properties, producer );
                if ( this->audio_format )
@@ -1404,7 +1437,12 @@ static void producer_set_up_video( producer_avformat this, mlt_frame frame )
        {
                // Reset the video properties if the index changed
                this->video_index = index;
-               producer_codec_close( this->video_codec );
+               if ( this->video_codec )
+               {
+                       avformat_lock();
+                       avcodec_close( this->video_codec );
+                       avformat_unlock();
+               }
                this->video_codec = NULL;
        }
 
@@ -1425,8 +1463,6 @@ static void producer_set_up_video( producer_avformat this, mlt_frame frame )
                mlt_properties_set_int( frame_properties, "real_width", this->video_codec->width );
                mlt_properties_set_int( frame_properties, "real_height", this->video_codec->height );
                mlt_properties_set_double( frame_properties, "aspect_ratio", aspect_ratio );
-               if ( mlt_properties_get( properties, "force_progressive" ) )
-                       mlt_properties_set_int( frame_properties, "progressive", mlt_properties_get_int( properties, "force_progressive" ) );
 
                // Add our image operation
                mlt_frame_push_service( frame, this );
@@ -1443,9 +1479,6 @@ static int seek_audio( producer_avformat this, mlt_position position, double tim
 {
        int paused = 0;
 
-       // Fetch the audio_format
-       AVFormatContext *context = this->audio_format;
-
        // Seek if necessary
        if ( position != this->audio_expected )
        {
@@ -1461,6 +1494,7 @@ static int seek_audio( producer_avformat this, mlt_position position, double tim
                }
                else if ( position < this->audio_expected || position - this->audio_expected >= 12 )
                {
+                       AVFormatContext *context = this->audio_format;
                        int64_t timestamp = ( int64_t )( timecode * AV_TIME_BASE + 0.5 );
                        if ( context->start_time != AV_NOPTS_VALUE )
                                timestamp += context->start_time;
@@ -1480,7 +1514,7 @@ static int seek_audio( producer_avformat this, mlt_position position, double tim
        return paused;
 }
 
-static int decode_audio( producer_avformat this, int *ignore, AVPacket *pkt, int channels, int samples, double timecode, double source_fps )
+static int decode_audio( producer_avformat this, int *ignore, AVPacket *pkt, int channels, int samples, double timecode, double fps )
 {
        // Fetch the audio_format
        AVFormatContext *context = this->audio_format;
@@ -1566,13 +1600,20 @@ static int decode_audio( producer_avformat this, int *ignore, AVPacket *pkt, int
        if ( pkt->pts >= 0 )
        {
                double current_pts = av_q2d( context->streams[ index ]->time_base ) * pkt->pts;
-               int req_position = ( int )( timecode * source_fps + 0.5 );
-               int int_position = ( int )( current_pts * source_fps + 0.5 );
-
+               int req_position = ( int )( timecode * fps + 0.5 );
+               int int_position = ( int )( current_pts * fps + 0.5 );
                if ( context->start_time != AV_NOPTS_VALUE )
-                       int_position -= ( int )( source_fps * context->start_time / AV_TIME_BASE + 0.5 );
-               if ( this->seekable && *ignore == 0 && int_position < req_position )
-                       *ignore = 1;
+                       int_position -= ( int )( fps * context->start_time / AV_TIME_BASE + 0.5 );
+
+               if ( this->seekable && *ignore == 0 )
+               {
+                       if ( int_position < req_position )
+                               // We are behind, so skip some
+                               *ignore = 1;
+                       else if ( int_position > req_position + 2 )
+                               // We are ahead, so seek backwards some more
+                               seek_audio( this, req_position, timecode - 1.0, ignore );
+               }
        }
 
        this->audio_used[ index ] = audio_used;
@@ -1594,8 +1635,8 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
        // Calculate the real time code
        double real_timecode = producer_time_of_frame( this->parent, position );
 
-       // Get the source fps
-       double source_fps = mlt_properties_get_double( MLT_PRODUCER_PROPERTIES( this->parent ), "source_fps" );
+       // Get the producer fps
+       double fps = mlt_producer_get_fps( this->parent );
 
        // Number of frames to ignore (for ffwd)
        int ignore = 0;
@@ -1668,6 +1709,12 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                AVPacket pkt;
 
                av_init_packet( &pkt );
+               
+               // If not resampling, give consumer more than requested.
+               // It requested number samples based on requested frame rate.
+               // Do not clean this up with a samples *= ...!
+               if ( this->audio_index != INT_MAX && ! this->audio_resample[ this->audio_index ] )
+                       *samples = *samples * this->audio_codec[ this->audio_index ]->sample_rate / *frequency;
 
                while ( ret >= 0 && !got_audio )
                {
@@ -1684,7 +1731,10 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                        // We only deal with audio from the selected audio index
                        if ( ret >= 0 && pkt.data && pkt.size > 0 && ( pkt.stream_index == this->audio_index ||
                                 ( this->audio_index == INT_MAX && context->streams[ pkt.stream_index ]->codec->codec_type == CODEC_TYPE_AUDIO ) ) )
-                               ret = decode_audio( this, &ignore, &pkt, *channels, *samples, real_timecode, source_fps );
+                       {
+                               int channels2 = this->audio_index == INT_MAX ? this->audio_codec[pkt.stream_index]->channels : *channels;
+                               ret = decode_audio( this, &ignore, &pkt, channels2, *samples, real_timecode, fps );
+                       }
                        av_free_packet( &pkt );
 
                        if ( this->audio_index == INT_MAX && ret >= 0 )
@@ -1698,7 +1748,7 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                                }
                        }
                }
-
+               
                // Allocate and set the frame's audio buffer
                int size = *samples * *channels * sizeof(int16_t);
                *buffer = mlt_pool_alloc( size );
@@ -1722,7 +1772,7 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                                }
                        }
                        for ( index = 0; index < index_max; index++ )
-                       if ( this->audio_codec[ index ] )
+                       if ( this->audio_codec[ index ] && this->audio_used[ index ] >= *samples )
                        {
                                int current_channels = this->audio_codec[ index ]->channels;
                                int16_t *src = this->audio_buffer[ index ] + *samples * current_channels;
@@ -1761,7 +1811,7 @@ static int producer_get_audio( mlt_frame frame, void **buffer, mlt_audio_format
                // Get silence and don't touch the context
                mlt_frame_get_audio( frame, buffer, format, frequency, channels, samples );
        }
-
+       
        // Regardless of speed (other than paused), we expect to get the next frame
        if ( !paused )
                this->audio_expected = position + 1;
@@ -1788,16 +1838,16 @@ static int audio_codec_init( producer_avformat this, int index, mlt_properties p
                if ( codec && avcodec_open( codec_context, codec ) >= 0 )
                {
                        // Now store the codec with its destructor
-                       avformat_unlock();
-                       producer_codec_close( this->audio_codec[index] );
+                       if ( this->audio_codec[ index ] )
+                               avcodec_close( this->audio_codec[ index ] );
                        this->audio_codec[ index ] = codec_context;
                }
                else
                {
                        // Remember that we can't use this later
                        this->audio_index = -1;
-                       avformat_unlock( );
                }
+               avformat_unlock( );
 
                // Process properties as AVOptions
                apply_properties( codec_context, properties, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_DECODING_PARAM );
@@ -1825,18 +1875,24 @@ static void producer_set_up_audio( producer_avformat this, mlt_frame frame )
        int index = mlt_properties_get_int( properties, "audio_index" );
 
        // Handle all audio tracks
-       if ( mlt_properties_get( properties, "audio_index" ) &&
-                !strcmp( mlt_properties_get( properties, "audio_index" ), "all" ) )
+       if ( this->audio_index > -1 &&
+            mlt_properties_get( properties, "audio_index" ) &&
+            !strcmp( mlt_properties_get( properties, "audio_index" ), "all" ) )
                index = INT_MAX;
 
        // Reopen the file if necessary
-       if ( !context && index > -1 )
+       if ( !context && this->audio_index > -1 && index > -1 )
        {
                mlt_events_block( properties, producer );
                producer_open( this, mlt_service_profile( MLT_PRODUCER_SERVICE(producer) ),
                        mlt_properties_get( properties, "resource" ) );
                context = this->audio_format;
-               producer_format_close( this->dummy_context );
+               if ( this->dummy_context )
+               {
+                       avformat_lock();
+                       av_close_input_file( this->dummy_context );
+                       avformat_unlock();
+               }
                this->dummy_context = NULL;
                mlt_events_unblock( properties, producer );
                get_audio_streams_info( this );
@@ -1853,17 +1909,25 @@ static void producer_set_up_audio( producer_avformat this, mlt_frame frame )
        if ( context && index > -1 && index < INT_MAX &&
                 context->streams[ index ]->codec->codec_type != CODEC_TYPE_AUDIO )
        {
-               index = -1;
+               index = this->audio_index;
                mlt_properties_set_int( properties, "audio_index", index );
        }
 
        // Update the audio properties if the index changed
-       if ( index > -1 && index != this->audio_index )
+       if ( context && index > -1 && index != this->audio_index )
        {
-               producer_codec_close( this->audio_codec[ this->audio_index ] );
+               if ( this->audio_codec[ this->audio_index ] )
+               {
+                       avformat_lock();
+                       avcodec_close( this->audio_codec[ this->audio_index ] );
+                       avformat_unlock();
+               }
                this->audio_codec[ this->audio_index ] = NULL;
        }
-       this->audio_index = index;
+       if ( this->audio_index != -1 )
+               this->audio_index = index;
+       else
+               index = -1;
 
        // Get the codec(s)
        if ( context && index == INT_MAX )
@@ -1899,16 +1963,32 @@ static void producer_set_up_audio( producer_avformat this, mlt_frame frame )
 static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int index )
 {
        // Access the private data
-       mlt_cache_item cache_item = mlt_service_cache_get( MLT_PRODUCER_SERVICE(producer), "producer_avformat" );
+       mlt_service service = MLT_PRODUCER_SERVICE( producer );
+       mlt_cache_item cache_item = mlt_service_cache_get( service, "producer_avformat" );
        producer_avformat this = mlt_cache_item_data( cache_item, NULL );
 
+       // If cache miss
+       if ( !this )
+       {
+               this = calloc( 1, sizeof( struct producer_avformat_s ) );
+               producer->child = this;
+               this->parent = producer;
+               mlt_service_cache_put( service, "producer_avformat", this, 0, (mlt_destructor) producer_avformat_close );
+               cache_item = mlt_service_cache_get( service, "producer_avformat" );
+       }
+
        // Create an empty frame
-       *frame = mlt_frame_init( MLT_PRODUCER_SERVICE( producer ) );
+       *frame = mlt_frame_init( service);
        
        if ( *frame )
+       {
                mlt_properties_set_data( MLT_FRAME_PROPERTIES(*frame), "avformat_cache", cache_item, 0, (mlt_destructor) mlt_cache_item_close, NULL );
+       }
        else
+       {
                mlt_cache_item_close( cache_item );
+               return 1;
+       }
 
        // Update timecode on the frame we're creating
        mlt_frame_set_position( *frame, mlt_producer_position( producer ) );
@@ -1916,15 +1996,6 @@ static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int i
        // Set the position of this producer
        mlt_properties_set_position( MLT_FRAME_PROPERTIES( *frame ), "avformat_position", mlt_producer_frame( producer ) );
        
-       // If cache miss
-       if ( !this )
-       {
-               this = calloc( 1, sizeof( struct producer_avformat_s ) );
-               producer->child = this;
-               this->parent = producer;
-               mlt_service_cache_put( MLT_PRODUCER_SERVICE(producer), "producer_avformat", this, 0, (mlt_destructor) producer_avformat_close );
-       }
-
        // Set up the video
        producer_set_up_video( this, *frame );
 
@@ -1939,9 +2010,10 @@ static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int i
 
 static void producer_avformat_close( producer_avformat this )
 {
-       mlt_log_debug( MLT_PRODUCER_SERVICE(this->parent), "producer_avformat_close\n" );
+       mlt_log_debug( NULL, "producer_avformat_close\n" );
        // Close the file
        av_free( this->av_frame );
+       avformat_lock();
        int i;
        for ( i = 0; i < MAX_AUDIO_STREAMS; i++ )
        {
@@ -1949,15 +2021,23 @@ static void producer_avformat_close( producer_avformat this )
                        audio_resample_close( this->audio_resample[i] );
                mlt_pool_release( this->audio_buffer[i] );
                av_free( this->decode_buffer[i] );
-               producer_codec_close( this->audio_codec[i] );
+               if ( this->audio_codec[i] )
+                       avcodec_close( this->audio_codec[i] );
        }
-       producer_codec_close( this->video_codec );
-       producer_format_close( this->dummy_context );
-       producer_format_close( this->audio_format );
-       producer_format_close( this->video_format );
+       if ( this->video_codec )
+               avcodec_close( this->video_codec );
+       if ( this->dummy_context )
+               av_close_input_file( this->dummy_context );
+       if ( this->audio_format )
+               av_close_input_file( this->audio_format );
+       if ( this->video_format )
+               av_close_input_file( this->video_format );
+       avformat_unlock();
 #ifdef VDPAU
        vdpau_producer_close( this );
 #endif
+       if ( this->image_cache )
+               mlt_cache_close( this->image_cache );
        free( this );
 }