]> git.sesse.net Git - mlt/blobdiff - src/modules/core/transition_composite.c
filter_resize,c, filter_composite.c: bugfix redundant rounding.
[mlt] / src / modules / core / transition_composite.c
index 6aef888c332af23ef8ffd7db2b66e6bcfc0ec678..87d013e9b6ec86fd89956aebbe41daf99e821797 100644 (file)
@@ -3,19 +3,19 @@
  * Copyright (C) 2003-2004 Ushodaya Enterprises Limited
  * Author: Dan Dennedy <dan@dennedy.org>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
  *
- * This program is distributed in the hope that it will be useful,
+ * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
 #include "transition_composite.h"
 #include <string.h>
 #include <math.h>
 
-typedef void ( *composite_line_fn )( uint8_t *dest, uint8_t *src, int width_src, uint8_t *alpha, int weight, uint16_t *luma, int softness );
-
-/* mmx function declarations */
-#ifdef USE_MMX
-       void composite_line_yuv_mmx( uint8_t *dest, uint8_t *src, int width_src, uint8_t *alpha, int weight, uint16_t *luma, int softness );
-       int composite_have_mmx( void );
-#endif
+typedef void ( *composite_line_fn )( uint8_t *dest, uint8_t *src, int width_src, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int softness );
 
 /** Geometry struct.
 */
@@ -70,18 +64,20 @@ static int alignment_parse( char* align )
 /** Calculate real geometry.
 */
 
-static void geometry_calculate( mlt_transition this, struct geometry_s *output, float position )
+static void geometry_calculate( mlt_transition this, struct geometry_s *output, double position )
 {
        mlt_properties properties = MLT_TRANSITION_PROPERTIES( this );
        mlt_geometry geometry = mlt_properties_get_data( properties, "geometries", NULL );
+       int mirror_off = mlt_properties_get_int( properties, "mirror_off" );
+       int repeat_off = mlt_properties_get_int( properties, "repeat_off" );
        int length = mlt_geometry_get_length( geometry );
 
        // Allow wrapping
-       if ( position >= length && length != 0 )
+       if ( !repeat_off && position >= length && length != 0 )
        {
                int section = position / length;
                position -= section * length;
-               if ( section % 2 == 1 )
+               if ( !mirror_off && section % 2 == 1 )
                        position = length - position;
        }
 
@@ -103,12 +99,20 @@ static mlt_geometry transition_parse_keys( mlt_transition this, int normalised_w
        // Get the in and out position
        mlt_position in = mlt_transition_get_in( this );
        mlt_position out = mlt_transition_get_out( this );
+       int length = out - in + 1;
+       double cycle = mlt_properties_get_double( properties, "cycle" );
 
        // Get the new style geometry string
        char *property = mlt_properties_get( properties, "geometry" );
 
+       // Allow a geometry repeat cycle
+       if ( cycle >= 1 )
+               length = cycle;
+       else if ( cycle > 0 )
+               length *= cycle;
+
        // Parse the geometry if we have one
-       mlt_geometry_parse( geometry, property, out - in + 1, normalised_width, normalised_height );
+       mlt_geometry_parse( geometry, property, length, normalised_width, normalised_height );
 
        // Check if we're using the old style geometry
        if ( property == NULL )
@@ -181,20 +185,16 @@ static int position_calculate( mlt_transition this, mlt_position position )
 /** Calculate the field delta for this frame - position between two frames.
 */
 
-static inline float delta_calculate( mlt_transition this, mlt_frame frame )
+static inline double delta_calculate( mlt_transition this, mlt_frame frame, mlt_position position )
 {
        // Get the in and out position
        mlt_position in = mlt_transition_get_in( this );
        mlt_position out = mlt_transition_get_out( this );
-       float length = out - in + 1;
-
-       // Get the position of the frame
-       char *name = mlt_properties_get( MLT_TRANSITION_PROPERTIES( this ), "_unique_id" );
-       mlt_position position = mlt_properties_get_position( MLT_FRAME_PROPERTIES( frame ), name );
+       double length = out - in + 1;
 
        // Now do the calcs
-       float x = ( float )( position - in ) / length;
-       float y = ( float )( position + 1 - in ) / length;
+       double x = ( double )( position - in ) / length;
+       double y = ( double )( position + 1 - in ) / length;
 
        return length * ( y - x ) / 2.0;
 }
@@ -366,46 +366,102 @@ static void luma_read_yuv422( uint8_t *image, uint16_t **map, int width, int hei
                *p++ = ( image[ i ] - 16 ) * 299; // 299 = 65535 / 219
 }
 
+static inline int calculate_mix( uint16_t *luma, int j, int soft, int weight, int alpha )
+{
+       return ( ( ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + soft, weight + soft ) ) * alpha ) >> 8;
+}
+
+static inline uint8_t sample_mix( uint8_t dest, uint8_t src, int mix )
+{
+       return ( src * mix + dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+}
 
 /** Composite a source line over a destination line
 */
 
-static inline
-void composite_line_yuv( uint8_t *dest, uint8_t *src, int width_src, uint8_t *alpha, int weight, uint16_t *luma, int softness )
+static void composite_line_yuv( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
 {
        register int j;
-       int a, mix;
-       
-       for ( j = 0; j < width_src; j ++ )
+       register int mix;
+
+       for ( j = 0; j < width; j ++ )
+       {
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ );
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *alpha_a = ( mix >> 8 ) | *alpha_a;
+               alpha_a ++;
+       }
+}
+
+static void composite_line_yuv_or( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
+{
+       register int j;
+       register int mix;
+
+       for ( j = 0; j < width; j ++ )
+       {
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ | *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *alpha_a ++ = mix >> 8;
+       }
+}
+
+static void composite_line_yuv_and( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
+{
+       register int j;
+       register int mix;
+
+       for ( j = 0; j < width; j ++ )
        {
-               a = ( alpha == NULL ) ? 255 : *alpha ++;
-               mix = ( luma == NULL ) ? weight : linearstep( luma[ j ], luma[ j ] + softness, weight );
-               mix = ( mix * ( a + 1 ) ) >> 8;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ & *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
+               *alpha_a ++ = mix >> 8;
+       }
+}
+
+static void composite_line_yuv_xor( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
+{
+       register int j;
+       register int mix;
+
+       for ( j = 0; j < width; j ++ )
+       {
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ ^ *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *dest = sample_mix( *dest, *src++, mix );
+               dest++;
+               *alpha_a ++ = mix >> 8;
        }
 }
 
 /** Composite function.
 */
 
-static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint8_t *p_src, int width_src, int height_src, uint8_t *p_alpha, struct geometry_s geometry, int field, uint16_t *p_luma, int32_t softness, composite_line_fn line_fn )
+static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint8_t *p_src, int width_src, int height_src, uint8_t *alpha_b, uint8_t *alpha_a, struct geometry_s geometry, int field, uint16_t *p_luma, int32_t softness, composite_line_fn line_fn )
 {
        int ret = 0;
        int i;
        int x_src = 0, y_src = 0;
-       int32_t weight = ( 1 << 16 ) * ( geometry.item.mix / 100 );
+       int32_t weight = ( ( 1 << 16 ) - 1 ) * ( geometry.item.mix / 100 );
        int step = ( field > -1 ) ? 2 : 1;
        int bpp = 2;
        int stride_src = width_src * bpp;
        int stride_dest = width_dest * bpp;
        
        // Adjust to consumer scale
-       int x = rint( 0.5 + geometry.item.x * width_dest / geometry.nw );
-       int y = rint( 0.5 + geometry.item.y * height_dest / geometry.nh );
-       int x_uneven = x & 1;
+       int x = rint( geometry.item.x * width_dest / geometry.nw );
+       int y = rint( geometry.item.y * height_dest / geometry.nh );
+       int uneven_x = ( x % 2 );
 
        // optimization points - no work to do
        if ( width_src <= 0 || height_src <= 0 )
@@ -445,8 +501,8 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        p_dest += ( x < 0 ? 0 : x ) * bpp + ( y < 0 ? 0 : y ) * stride_dest;
 
        // offset pointer into alpha channel based upon cropping
-       if ( p_alpha )
-               p_alpha += x_src + y_src * stride_src / bpp;
+       alpha_b += x_src + y_src * stride_src / bpp;
+       alpha_a += x + y * stride_dest / bpp;
 
        // offset pointer into luma channel based upon cropping
        if ( p_luma )
@@ -458,7 +514,6 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        // field 1 = upper field and y should be even.
        if ( ( field > -1 ) && ( y % 2 == field ) )
        {
-               //fprintf( stderr, "field %d y %d\n", field, y );
                if ( ( field == 1 && y < height_dest - 1 ) || ( field == 0 && y == 0 ) )
                        p_dest += stride_dest;
                else
@@ -469,50 +524,32 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        if ( field == 1 )
        {
                p_src += stride_src;
-               if ( p_alpha )
-                       p_alpha += stride_src / bpp;
+               alpha_b += stride_src / bpp;
+               alpha_a += stride_dest / bpp;
                height_src--;
        }
 
        stride_src *= step;
        stride_dest *= step;
-       int alpha_stride = stride_src / bpp;
+       int alpha_b_stride = stride_src / bpp;
+       int alpha_a_stride = stride_dest / bpp;
 
-       // Make sure than x and w are even
-       if ( x_uneven )
-       {
-               p_src += 2;
-               width_src --;
-       }
+       p_src += uneven_x * 2;
+       width_src -= 2 * uneven_x;
+       alpha_b += uneven_x;
+       uneven_x = 0;
 
        // now do the compositing only to cropped extents
-       if ( line_fn != NULL )
-       {
-               for ( i = 0; i < height_src; i += step )
-               {
-                       line_fn( p_dest, p_src, width_src, p_alpha, weight, p_luma, softness );
-       
-                       p_src += stride_src;
-                       p_dest += stride_dest;
-                       if ( p_alpha )
-                               p_alpha += alpha_stride;
-                       if ( p_luma )
-                               p_luma += alpha_stride;
-               }
-       }
-       else
+       for ( i = 0; i < height_src; i += step )
        {
-               for ( i = 0; i < height_src; i += step )
-               {
-                       composite_line_yuv( p_dest, p_src, width_src, p_alpha, weight, p_luma, softness );
-       
-                       p_src += stride_src;
-                       p_dest += stride_dest;
-                       if ( p_alpha )
-                               p_alpha += alpha_stride;
-                       if ( p_luma )
-                               p_luma += alpha_stride;
-               }
+               line_fn( p_dest, p_src, width_src, alpha_b, alpha_a, weight, p_luma, softness );
+
+               p_src += stride_src;
+               p_dest += stride_dest;
+               alpha_b += alpha_b_stride;
+               alpha_a += alpha_a_stride;
+               if ( p_luma )
+                       p_luma += alpha_b_stride;
        }
 
        return ret;
@@ -523,7 +560,7 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
 */
 
 static inline void
-scale_luma ( uint16_t *dest_buf, int dest_width, int dest_height, const uint16_t *src_buf, int src_width, int src_height )
+scale_luma ( uint16_t *dest_buf, int dest_width, int dest_height, const uint16_t *src_buf, int src_width, int src_height, int invert )
 {
        register int i, j;
        register int x_step = ( src_width << 16 ) / dest_width;
@@ -537,28 +574,42 @@ scale_luma ( uint16_t *dest_buf, int dest_width, int dest_height, const uint16_t
                
                for ( j = 0; j < dest_width; j++ )
                {
-                       *dest_buf++ = src[ x >> 16 ];
+                       *dest_buf++ = src[ x >> 16 ] ^ invert;
                        x += x_step;
                }
                y += y_step;
        }
 }
 
-static uint16_t* get_luma( mlt_properties properties, int width, int height )
+static uint16_t* get_luma( mlt_transition this, mlt_properties properties, int width, int height )
 {
        // The cached luma map information
        int luma_width = mlt_properties_get_int( properties, "_luma.width" );
        int luma_height = mlt_properties_get_int( properties, "_luma.height" );
        uint16_t *luma_bitmap = mlt_properties_get_data( properties, "_luma.bitmap", NULL );
+       int invert = mlt_properties_get_int( properties, "luma_invert" );
        
        // If the filename property changed, reload the map
        char *resource = mlt_properties_get( properties, "luma" );
 
        char temp[ 512 ];
 
+       if ( luma_width == 0 || luma_height == 0 )
+       {
+               luma_width = width;
+               luma_height = height;
+       }
+
        if ( resource != NULL && strchr( resource, '%' ) )
        {
-               sprintf( temp, "%s/lumas/%s/%s", mlt_factory_prefix( ), mlt_environment( "MLT_NORMALISATION" ), strchr( resource, '%' ) + 1 );
+               // TODO: Clean up quick and dirty compressed/existence check
+               FILE *test;
+               sprintf( temp, "%s/lumas/%s/%s", mlt_environment( "MLT_DATA" ), mlt_environment( "MLT_NORMALISATION" ), strchr( resource, '%' ) + 1 );
+               test = fopen( temp, "r" );
+               if ( test == NULL )
+                       strcat( temp, ".png" );
+               else
+                       fclose( test );
                resource = temp;
        }
 
@@ -571,7 +622,7 @@ static uint16_t* get_luma( mlt_properties properties, int width, int height )
                // Load the original luma once
                if ( orig_bitmap == NULL )
                {
-                       char *extension = extension = strrchr( resource, '.' );
+                       char *extension = strrchr( resource, '.' );
                        
                        // See if it is a PGM
                        if ( extension != NULL && strcmp( extension, ".pgm" ) == 0 )
@@ -596,7 +647,8 @@ static uint16_t* get_luma( mlt_properties properties, int width, int height )
                                char *factory = mlt_properties_get( properties, "factory" );
        
                                // Create the producer
-                               mlt_producer producer = mlt_factory_producer( factory, resource );
+                               mlt_profile profile = mlt_service_profile( MLT_TRANSITION_SERVICE( this ) );
+                               mlt_producer producer = mlt_factory_producer( profile, factory, resource );
        
                                // If we have one
                                if ( producer != NULL )
@@ -643,7 +695,7 @@ static uint16_t* get_luma( mlt_properties properties, int width, int height )
                }
                // Scale luma map
                luma_bitmap = mlt_pool_alloc( width * height * sizeof( uint16_t ) );
-               scale_luma( luma_bitmap, width, height, orig_bitmap, luma_width, luma_height );
+               scale_luma( luma_bitmap, width, height, orig_bitmap, luma_width, luma_height, invert * ( ( 1 << 16 ) - 1 ) );
 
                // Remember the scaled luma size to prevent unnecessary scaling
                mlt_properties_set_int( properties, "_luma.width", width );
@@ -664,37 +716,51 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
        // Get the properties objects
        mlt_properties b_props = MLT_FRAME_PROPERTIES( b_frame );
        mlt_properties properties = MLT_TRANSITION_PROPERTIES( this );
+       uint8_t resize_alpha = mlt_properties_get_int( b_props, "resize_alpha" );
 
-       if ( mlt_properties_get( properties, "distort" ) == NULL && mlt_properties_get( b_props, "distort" ) == NULL && geometry->item.distort == 0 )
+       if ( mlt_properties_get_int( properties, "aligned" ) && mlt_properties_get_int( properties, "distort" ) == 0 && mlt_properties_get_int( b_props, "distort" ) == 0 && geometry->item.distort == 0 )
        {
                // Adjust b_frame pixel aspect
                int normalised_width = geometry->item.w;
                int normalised_height = geometry->item.h;
                int real_width = get_value( b_props, "real_width", "width" );
                int real_height = get_value( b_props, "real_height", "height" );
-               double input_ar = mlt_frame_get_aspect_ratio( b_frame );
-               double output_ar = mlt_properties_get_double( b_props, "consumer_aspect_ratio" );
-               int scaled_width = input_ar / output_ar * real_width;
+               double input_ar = mlt_properties_get_double( b_props, "aspect_ratio" );
+               double consumer_ar = mlt_properties_get_double( b_props, "consumer_aspect_ratio" );
+               double background_ar = mlt_properties_get_double( b_props, "output_ratio" );
+               double output_ar = background_ar != 0.0 ? background_ar : consumer_ar;
+               int scaled_width = rint( ( input_ar == 0.0 ? output_ar : input_ar ) / output_ar * real_width );
                int scaled_height = real_height;
-                       
+// fprintf(stderr, "%s: scaled %dx%d norm %dx%d real %dx%d output_ar %f => %f\n", __FILE__,
+// scaled_width, scaled_height, normalised_width, normalised_height, real_width, real_height,
+// background_ar, output_ar);
+
                // Now ensure that our images fit in the normalised frame
                if ( scaled_width > normalised_width )
                {
-                       scaled_height = scaled_height * normalised_width / scaled_width;
+                       scaled_height = rint( scaled_height * normalised_width / scaled_width );
                        scaled_width = normalised_width;
                }
                if ( scaled_height > normalised_height )
                {
-                       scaled_width = scaled_width * normalised_height / scaled_height;
+                       scaled_width = rint( scaled_width * normalised_height / scaled_height );
                        scaled_height = normalised_height;
                }
 
-               // Now apply the fill
-               // TODO: Should combine fill/distort in one property
-               if ( mlt_properties_get( properties, "fill" ) != NULL )
+               // Honour the fill request - this will scale the image to fill width or height while maintaining a/r
+               // ????: Shouln't this be the default behaviour?
+               if ( mlt_properties_get_int( properties, "fill" ) && scaled_width > 0 && scaled_height > 0 )
                {
-                       scaled_width = ( geometry->item.w / scaled_width ) * scaled_width;
-                       scaled_height = ( geometry->item.h / scaled_height ) * scaled_height;
+                       if ( scaled_height < normalised_height && scaled_width * normalised_height / scaled_height <= normalised_width )
+                       {
+                               scaled_width = rint( scaled_width * normalised_height / scaled_height );
+                               scaled_height = normalised_height;
+                       }
+                       else if ( scaled_width < normalised_width && scaled_height * normalised_width / scaled_width < normalised_height )
+                       {
+                               scaled_height = rint( scaled_height * normalised_width / scaled_width );
+                               scaled_width = normalised_width;
+                       }
                }
 
                // Save the new scaled dimensions
@@ -708,34 +774,33 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
        }
 
        // We want to ensure that we bypass resize now...
-       mlt_properties_set( b_props, "distort", "true" );
+       if ( resize_alpha == 0 )
+               mlt_properties_set_int( b_props, "distort", mlt_properties_get_int( properties, "distort" ) );
 
-       // Take into consideration alignment for optimisation
+       // If we're not aligned, we want a non-transparent background
+       if ( mlt_properties_get_int( properties, "aligned" ) == 0 )
+               mlt_properties_set_int( b_props, "resize_alpha", 255 );
+
+       // Take into consideration alignment for optimisation (titles are a special case)
        if ( !mlt_properties_get_int( properties, "titles" ) )
                alignment_calculate( geometry );
 
        // Adjust to consumer scale
-       int x = geometry->item.x * *width / geometry->nw;
-       int y = geometry->item.y * *height / geometry->nh;
-       *width = geometry->sw * *width / geometry->nw;
-       *height = geometry->sh * *height / geometry->nh;
-
-       //x = ( x | 1 ) ^ 1;
-
-       // optimization points - no work to do
-       if ( *width < 1 || *height < 1 )
-               return 1;
-
-       if ( ( x < 0 && -x >= *width ) || ( y < 0 && -y >= *height ) )
-               return 1;
+       *width = rint( geometry->sw * *width / geometry->nw );
+       *height = rint( geometry->sh * *height / geometry->nh );
+// fprintf(stderr, "%s: scaled %dx%d norm %dx%d resize %dx%d\n", __FILE__,
+// geometry->sw, geometry->sh, geometry->nw, geometry->nh, *width, *height);
 
        ret = mlt_frame_get_image( b_frame, image, &format, width, height, 1 );
 
-       return ret;
+       // Set the frame back
+       mlt_properties_set_int( b_props, "resize_alpha", resize_alpha );
+
+       return ret && image != NULL;
 }
 
 
-static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s *result, mlt_frame a_frame, float position )
+static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s *result, mlt_frame a_frame, double position )
 {
        // Get the properties from the transition
        mlt_properties properties = MLT_TRANSITION_PROPERTIES( this );
@@ -750,27 +815,43 @@ static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s
        int normalised_width = mlt_properties_get_int( a_props, "normalised_width" );
        int normalised_height = mlt_properties_get_int( a_props, "normalised_height" );
 
-       // Now parse the geometries
-       if ( start == NULL )
-       {
-               // Parse the transitions properties
-               start = transition_parse_keys( this, normalised_width, normalised_height );
+       char *name = mlt_properties_get( properties, "_unique_id" );
+       char key[ 256 ];
 
-               // Assign to properties to ensure we get destroyed
-               mlt_properties_set_data( properties, "geometries", start, 0, ( mlt_destructor )mlt_geometry_close, NULL );
+       sprintf( key, "%s.in", name );
+       if ( mlt_properties_get( a_props, key ) )
+       {
+               sscanf( mlt_properties_get( a_props, key ), "%f,%f,%f,%f,%f,%d,%d", &result->item.x, &result->item.y, &result->item.w, &result->item.h, &result->item.mix, &result->nw, &result->nh );
        }
        else
        {
-               int length = mlt_transition_get_out( this ) - mlt_transition_get_in( this ) + 1;
-               mlt_geometry_refresh( start, mlt_properties_get( properties, "geometry" ), length, normalised_width, normalised_height );
-       }
+               // Now parse the geometries
+               if ( start == NULL )
+               {
+                       // Parse the transitions properties
+                       start = transition_parse_keys( this, normalised_width, normalised_height );
 
-       // Do the calculation
-       geometry_calculate( this, result, position );
+                       // Assign to properties to ensure we get destroyed
+                       mlt_properties_set_data( properties, "geometries", start, 0, ( mlt_destructor )mlt_geometry_close, NULL );
+               }
+               else
+               {
+                       int length = mlt_transition_get_out( this ) - mlt_transition_get_in( this ) + 1;
+                       double cycle = mlt_properties_get_double( properties, "cycle" );
+                       if ( cycle > 1 )
+                               length = cycle;
+                       else if ( cycle > 0 )
+                               length *= cycle;
+                       mlt_geometry_refresh( start, mlt_properties_get( properties, "geometry" ), length, normalised_width, normalised_height );
+               }
+
+               // Do the calculation
+               geometry_calculate( this, result, position );
 
-       // Assign normalised info
-       result->nw = normalised_width;
-       result->nh = normalised_height;
+               // Assign normalised info
+               result->nw = normalised_width;
+               result->nh = normalised_height;
+       }
 
        // Now parse the alignment
        result->halign = alignment_parse( mlt_properties_get( properties, "halign" ) );
@@ -779,20 +860,10 @@ static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s
        return start;
 }
 
-static inline void inline_memcpy( uint8_t *dest, uint8_t *src, int length )
-{
-       uint8_t *end = src + length;
-       while ( src < end )
-       {
-               *dest ++ = *src ++;
-               *dest ++ = *src ++;
-       }
-}
-
 mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_position frame_position )
 {
        // Create a frame to return
-       mlt_frame b_frame = mlt_frame_init( );
+       mlt_frame b_frame = mlt_frame_init( MLT_TRANSITION_SERVICE( this ) );
 
        // Get the properties of the a frame
        mlt_properties a_props = MLT_FRAME_PROPERTIES( a_frame );
@@ -803,6 +874,10 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        // Get the position
        int position = position_calculate( this, frame_position );
 
+       // Get the unique id of the transition
+       char *name = mlt_properties_get( MLT_TRANSITION_PROPERTIES( this ), "_unique_id" );
+       char key[ 256 ];
+
        // Destination image
        uint8_t *dest = NULL;
 
@@ -810,6 +885,7 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        uint8_t *image = mlt_properties_get_data( a_props, "image", NULL );
        int width = mlt_properties_get_int( a_props, "width" );
        int height = mlt_properties_get_int( a_props, "height" );
+       int format = mlt_properties_get_int( a_props, "format" );
 
        // Pointers for copy operation
        uint8_t *p;
@@ -826,30 +902,27 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        // Will need to know region to copy
        struct geometry_s result;
 
-       float delta = delta_calculate( this, a_frame );
-
        // Calculate the region now
-       composite_calculate( this, &result, a_frame, position + delta / 2 );
+       composite_calculate( this, &result, a_frame, position );
 
        // Need to scale down to actual dimensions
-       x = rint( 0.5 + result.item.x * width / result.nw );
-       y = rint( 0.5 + result.item.y * height / result.nh );
-       w = rint( 0.5 + result.item.w * width / result.nw );
-       h = rint( 0.5 + result.item.h * height / result.nh );
+       x = rint( result.item.x * width / result.nw );
+       y = rint( result.item.y * height / result.nh );
+       w = rint( result.item.w * width / result.nw );
+       h = rint( result.item.h * height / result.nh );
 
-       // Make sure that x and w are even
-       if ( x & 1 )
+       if ( x % 2 )
        {
                x --;
-               w += 2;
-               if ( w & 1 )
-                       w --;
-       }
-       else if ( w & 1 )
-       {
                w ++;
        }
 
+       // Store the key
+       sprintf( key, "%s.in=%d,%d,%d,%d,%f,%d,%d", name, x, y, w, h, result.item.mix, width, height );
+       mlt_properties_parse( a_props, key );
+       sprintf( key, "%s.out=%d,%d,%d,%d,%f,%d,%d", name, x, y, w, h, result.item.mix, width, height );
+       mlt_properties_parse( a_props, key );
+
        ds = w * 2;
        ss = width * 2;
 
@@ -860,6 +933,7 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        mlt_properties_set_data( b_props, "image", dest, w * h * 2, mlt_pool_release, NULL );
        mlt_properties_set_int( b_props, "width", w );
        mlt_properties_set_int( b_props, "height", h );
+       mlt_properties_set_int( b_props, "format", format );
 
        if ( y < 0 )
        {
@@ -878,19 +952,22 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
                x = 0;
        }
 
-       // Copy the region of the image
-       p = image + y * ss + x * 2;
-
-       while ( h -- )
+       if ( w > 0 && h > 0 )
        {
-               inline_memcpy( dest, p, w * 2 );
-               dest += ds;
-               p += ss;
+               // Copy the region of the image
+               p = image + y * ss + x * 2;
+
+               while ( h -- )
+               {
+                       memcpy( dest, p, w * 2 );
+                       dest += ds;
+                       p += ss;
+               }
        }
 
        // Assign this position to the b frame
        mlt_frame_set_position( b_frame, frame_position );
-       mlt_properties_set( b_props, "distort", "true" );
+       mlt_properties_set_int( b_props, "distort", 1 );
 
        // Return the frame
        return b_frame;
@@ -907,15 +984,26 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
        // Get the transition from the a frame
        mlt_transition this = mlt_frame_pop_service( a_frame );
 
-       // This compositer is yuv422 only
-       *format = mlt_image_yuv422;
-
-       // Get the image from the a frame
-       mlt_frame_get_image( a_frame, image, format, width, height, 1 );
+       // Get in and out
+       double position = mlt_deque_pop_back_double( MLT_FRAME_IMAGE_STACK( a_frame ) );
+       int out = mlt_frame_pop_service_int( a_frame );
+       int in = mlt_frame_pop_service_int( a_frame );
 
        // Get the properties from the transition
        mlt_properties properties = MLT_TRANSITION_PROPERTIES( this );
 
+       // TODO: clean up always_active behaviour
+       if ( mlt_properties_get_int( properties, "always_active" ) )
+       {
+               mlt_events_block( properties, properties );
+               mlt_properties_set_int( properties, "in", in );
+               mlt_properties_set_int( properties, "out", out );
+               mlt_events_unblock( properties, properties );
+       }
+
+       // This compositer is yuv422 only
+       *format = mlt_image_yuv422;
+
        if ( b_frame != NULL )
        {
                // Get the properties of the a frame
@@ -928,16 +1016,57 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
                struct geometry_s result;
 
                // Calculate the position
-               float position = mlt_properties_get_double( b_props, "relative_position" );
-               float delta = delta_calculate( this, a_frame );
+               double delta = delta_calculate( this, a_frame, position );
 
                // Get the image from the b frame
                uint8_t *image_b = NULL;
                int width_b = *width;
                int height_b = *height;
        
+               // Vars for alphas
+               uint8_t *alpha_a = NULL;
+               uint8_t *alpha_b = NULL;
+
+               // Composites always need scaling... defaulting to lowest
+               char *rescale = mlt_properties_get( a_props, "rescale.interp" );
+               if ( rescale == NULL || !strcmp( rescale, "none" ) )
+                       rescale = "nearest";
+               mlt_properties_set( a_props, "rescale.interp", rescale );
+               mlt_properties_set( b_props, "rescale.interp", rescale );
+
                // Do the calculation
+               // NB: Locks needed here since the properties are being modified
+               mlt_service_lock( MLT_TRANSITION_SERVICE( this ) );
                composite_calculate( this, &result, a_frame, position );
+               mlt_service_unlock( MLT_TRANSITION_SERVICE( this ) );
+
+               // Since we are the consumer of the b_frame, we must pass along these
+               // consumer properties from the a_frame
+               mlt_properties_set_int( b_props, "consumer_deinterlace", mlt_properties_get_int( a_props, "consumer_deinterlace" ) || mlt_properties_get_int( properties, "deinterlace" ) );
+               mlt_properties_set( b_props, "consumer_deinterlace_method", mlt_properties_get( a_props, "consumer_deinterlace_method" ) );
+               mlt_properties_set_double( b_props, "consumer_aspect_ratio", mlt_properties_get_double( a_props, "consumer_aspect_ratio" ) );
+
+               // TODO: Dangerous/temporary optimisation - if nothing to do, then do nothing
+               if ( mlt_properties_get_int( properties, "no_alpha" ) && 
+                        result.item.x == 0 && result.item.y == 0 && result.item.w == *width && result.item.h == *height && result.item.mix == 100 )
+               {
+                       mlt_frame_get_image( b_frame, image, format, width, height, 1 );
+                       if ( !mlt_frame_is_test_card( a_frame ) )
+                               mlt_frame_replace_image( a_frame, *image, *format, *width, *height );
+                       return 0;
+               }
+
+               if ( a_frame == b_frame )
+               {
+                       double aspect_ratio = mlt_frame_get_aspect_ratio( b_frame );
+                       get_b_frame_image( this, b_frame, &image_b, &width_b, &height_b, &result );
+                       alpha_b = mlt_frame_get_alpha_mask( b_frame );
+                       mlt_properties_set_double( a_props, "aspect_ratio", aspect_ratio );
+               }
+
+               // Get the image from the a frame
+               mlt_frame_get_image( a_frame, image, format, width, height, 1 );
+               alpha_a = mlt_frame_get_alpha_mask( a_frame );
 
                // Optimisation - no compositing required
                if ( result.item.mix == 0 || ( result.item.w == 0 && result.item.h == 0 ) )
@@ -957,50 +1086,67 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
                        mlt_properties_set_int( b_props, "dest_height", mlt_properties_get_int( a_props, "dest_height" ) );
                }
 
-               // Since we are the consumer of the b_frame, we must pass along these
-               // consumer properties from the a_frame
-               mlt_properties_set_double( b_props, "consumer_deinterlace", mlt_properties_get_double( a_props, "consumer_deinterlace" ) );
-               mlt_properties_set_double( b_props, "consumer_aspect_ratio", mlt_properties_get_double( a_props, "consumer_aspect_ratio" ) );
-               mlt_properties_set_int( b_props, "normalised_width", mlt_properties_get_double( a_props, "normalised_width" ) );
-               mlt_properties_set_int( b_props, "normalised_height", mlt_properties_get_double( a_props, "normalised_height" ) );
-
                // Special case for titling...
                if ( mlt_properties_get_int( properties, "titles" ) )
                {
                        if ( mlt_properties_get( b_props, "rescale.interp" ) == NULL )
                                mlt_properties_set( b_props, "rescale.interp", "hyper" );
-                       mlt_properties_set( properties, "fill", NULL );
                        width_b = mlt_properties_get_int( a_props, "dest_width" );
                        height_b = mlt_properties_get_int( a_props, "dest_height" );
                }
 
-               if ( get_b_frame_image( this, b_frame, &image_b, &width_b, &height_b, &result ) == 0 )
+               if ( *image != image_b && ( image_b != NULL || get_b_frame_image( this, b_frame, &image_b, &width_b, &height_b, &result ) == 0 ) )
                {
                        uint8_t *dest = *image;
                        uint8_t *src = image_b;
-                       uint8_t *alpha = mlt_frame_get_alpha_mask( b_frame );
                        int progressive = 
                                        mlt_properties_get_int( a_props, "consumer_deinterlace" ) ||
                                        mlt_properties_get_int( properties, "progressive" );
                        int field;
                        
                        int32_t luma_softness = mlt_properties_get_double( properties, "softness" ) * ( 1 << 16 );
-                       uint16_t *luma_bitmap = get_luma( properties, width_b, height_b );
-                       //composite_line_fn line_fn = mlt_properties_get_int( properties, "_MMX" ) ? composite_line_yuv_mmx : NULL;
-                       composite_line_fn line_fn = NULL;
+                       uint16_t *luma_bitmap = get_luma( this, properties, width_b, height_b );
+                       char *operator = mlt_properties_get( properties, "operator" );
+
+                       alpha_b = alpha_b == NULL ? mlt_frame_get_alpha_mask( b_frame ) : alpha_b;
+
+                       composite_line_fn line_fn = composite_line_yuv;
+
+                       // Replacement and override
+                       if ( operator != NULL )
+                       {
+                               if ( !strcmp( operator, "or" ) )
+                                       line_fn = composite_line_yuv_or;
+                               if ( !strcmp( operator, "and" ) )
+                                       line_fn = composite_line_yuv_and;
+                               if ( !strcmp( operator, "xor" ) )
+                                       line_fn = composite_line_yuv_xor;
+                       }
+
+                       // Allow the user to completely obliterate the alpha channels from both frames
+                       if ( mlt_properties_get( properties, "alpha_a" ) )
+                               memset( alpha_a, mlt_properties_get_int( properties, "alpha_a" ), *width * *height );
+
+                       if ( mlt_properties_get( properties, "alpha_b" ) )
+                               memset( alpha_b, mlt_properties_get_int( properties, "alpha_b" ), width_b * height_b );
 
                        for ( field = 0; field < ( progressive ? 1 : 2 ); field++ )
                        {
                                // Assume lower field (0) first
-                               float field_position = position + field * delta;
+                               double field_position = position + field * delta;
                                
                                // Do the calculation if we need to
+                               // NB: Locks needed here since the properties are being modified
+                               mlt_service_lock( MLT_TRANSITION_SERVICE( this ) );
                                composite_calculate( this, &result, a_frame, field_position );
+                               mlt_service_unlock( MLT_TRANSITION_SERVICE( this ) );
 
                                if ( mlt_properties_get_int( properties, "titles" ) )
                                {
-                                       result.nw = result.item.w = *width;
-                                       result.nh = result.item.h = *height;
+                                       result.item.w = rint( *width * ( result.item.w / result.nw ) );
+                                       result.nw = result.item.w;
+                                       result.item.h = rint( *height * ( result.item.h / result.nh ) );
+                                       result.nh = *height;
                                        result.sw = width_b;
                                        result.sh = height_b;
                                }
@@ -1009,10 +1155,14 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
                                alignment_calculate( &result );
 
                                // Composite the b_frame on the a_frame
-                               composite_yuv( dest, *width, *height, src, width_b, height_b, alpha, result, progressive ? -1 : field, luma_bitmap, luma_softness, line_fn );
+                               composite_yuv( dest, *width, *height, src, width_b, height_b, alpha_b, alpha_a, result, progressive ? -1 : field, luma_bitmap, luma_softness, line_fn );
                        }
                }
        }
+       else
+       {
+               mlt_frame_get_image( a_frame, image, format, width, height, 1 );
+       }
 
        return 0;
 }
@@ -1022,14 +1172,20 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 
 static mlt_frame composite_process( mlt_transition this, mlt_frame a_frame, mlt_frame b_frame )
 {
-       // Get a unique name to store the frame position
-       char *name = mlt_properties_get( MLT_TRANSITION_PROPERTIES( this ), "_unique_id" );
-
-       // Assign the current position to the name
-       mlt_properties_set_position( MLT_FRAME_PROPERTIES( a_frame ), name, mlt_frame_get_position( a_frame ) );
-
-       // Propogate the transition properties to the b frame
-       mlt_properties_set_double( MLT_FRAME_PROPERTIES( b_frame ), "relative_position", position_calculate( this, mlt_frame_get_position( a_frame ) ) );
+       // UGH - this is a TODO - find a more reliable means of obtaining in/out for the always_active case
+       if ( mlt_properties_get_int(  MLT_TRANSITION_PROPERTIES( this ), "always_active" ) == 0 )
+       {
+               mlt_frame_push_service_int( a_frame, mlt_properties_get_int( MLT_TRANSITION_PROPERTIES( this ), "in" ) );
+               mlt_frame_push_service_int( a_frame, mlt_properties_get_int( MLT_TRANSITION_PROPERTIES( this ), "out" ) );
+               mlt_deque_push_back_double( MLT_FRAME_IMAGE_STACK( a_frame ), position_calculate( this, mlt_frame_get_position( a_frame ) ) );
+       }
+       else
+       {
+               mlt_properties props = mlt_properties_get_data( MLT_FRAME_PROPERTIES( b_frame ), "_producer", NULL );
+               mlt_frame_push_service_int( a_frame, mlt_properties_get_int( props, "in" ) );
+               mlt_frame_push_service_int( a_frame, mlt_properties_get_int( props, "out" ) );
+               mlt_deque_push_back_double( MLT_FRAME_IMAGE_STACK( a_frame ), mlt_properties_get_int( props, "_frame" ) - mlt_properties_get_int( props, "in" ) );
+       }
        
        mlt_frame_push_service( a_frame, this );
        mlt_frame_push_frame( a_frame, b_frame );
@@ -1040,7 +1196,7 @@ static mlt_frame composite_process( mlt_transition this, mlt_frame a_frame, mlt_
 /** Constructor for the filter.
 */
 
-mlt_transition transition_composite_init( char *arg )
+mlt_transition transition_composite_init( mlt_profile profile, mlt_service_type type, const char *id, char *arg )
 {
        mlt_transition this = calloc( sizeof( struct mlt_transition_s ), 1 );
        if ( this != NULL && mlt_transition_init( this, NULL ) == 0 )
@@ -1050,14 +1206,16 @@ mlt_transition transition_composite_init( char *arg )
                this->process = composite_process;
                
                // Default starting motion and zoom
-               mlt_properties_set( properties, "start", arg != NULL ? arg : "85%,5%:10%x10%" );
+               mlt_properties_set( properties, "start", arg != NULL ? arg : "0,0:100%x100%" );
                
                // Default factory
                mlt_properties_set( properties, "factory", "fezzik" );
 
-#ifdef USE_MMX
-               //mlt_properties_set_int( properties, "_MMX", composite_have_mmx() );
-#endif
+               // Use alignment (and hence alpha of b frame)
+               mlt_properties_set_int( properties, "aligned", 1 );
+
+               // Inform apps and framework that this is a video only transition
+               mlt_properties_set_int( properties, "_transition_type", 1 );
        }
        return this;
 }