]> git.sesse.net Git - mlt/blobdiff - src/modules/frei0r/factory.c
Fix encoding audio distortion for planar codecs (3576437)
[mlt] / src / modules / frei0r / factory.c
index 83fc8441b587caea7b8fbeca03026a779c6d71fc..ea745c4087066b647c2da86468c803347aaa0d78 100644 (file)
 #include <dlfcn.h>
 #include <stdlib.h>
 #include <limits.h>
+#include <math.h>
 
+
+#if defined(WIN32)
+#define LIBSUF ".dll"
+#define FREI0R_PLUGIN_PATH "\\lib\\frei0r-1"
+#elif defined(__DARWIN__) && defined(RELOCATABLE)
+#define LIBSUF ".so"
+#define FREI0R_PLUGIN_PATH "/lib/frei0r-1"
+#else
+#define LIBSUF ".so"
 #define FREI0R_PLUGIN_PATH "/usr/lib/frei0r-1:/usr/lib64/frei0r-1:/opt/local/lib/frei0r-1:/usr/local/lib/frei0r-1:$HOME/.frei0r-1/lib"
+#endif
+
 #define GET_FREI0R_PATH (getenv("FREI0R_PATH") ? getenv("FREI0R_PATH") : getenv("MLT_FREI0R_PLUGIN_PATH") ? getenv("MLT_FREI0R_PLUGIN_PATH") : FREI0R_PLUGIN_PATH)
 
 extern mlt_filter filter_frei0r_init( mlt_profile profile, mlt_service_type type, const char *id, char *arg );
@@ -41,6 +53,41 @@ extern void producer_close( mlt_producer this );
 extern void transition_close( mlt_transition this );
 extern mlt_frame transition_process( mlt_transition transition, mlt_frame a_frame, mlt_frame b_frame );
 
+static char* get_frei0r_path()
+{
+#ifdef WIN32
+       char *dirname = malloc( strlen( mlt_environment( "MLT_APPDIR" ) ) + strlen( FREI0R_PLUGIN_PATH ) + 1 );
+       strcpy( dirname, mlt_environment( "MLT_APPDIR" ) );
+       strcat( dirname, FREI0R_PLUGIN_PATH );
+       return dirname;
+#elif defined(__DARWIN__) && defined(RELOCATABLE)
+       char *dirname = malloc( strlen( mlt_environment( "MLT_APPDIR" ) ) + strlen( FREI0R_PLUGIN_PATH ) + 1 );
+       strcpy( dirname, mlt_environment( "MLT_APPDIR" ) );
+       strcat( dirname, FREI0R_PLUGIN_PATH );
+       return dirname;
+#else
+       return strdup( GET_FREI0R_PATH );
+#endif
+}
+
+static void check_thread_safe( mlt_properties properties, const char *name )
+{
+       char dirname[PATH_MAX];
+       snprintf( dirname, PATH_MAX, "%s/frei0r/not_thread_safe.txt", mlt_environment( "MLT_DATA" ) );
+       mlt_properties not_thread_safe = mlt_properties_load( dirname );
+       int i;
+
+       for ( i = 0; i < mlt_properties_count( not_thread_safe ); i++ )
+       {
+               if ( strcmp( name, mlt_properties_get_name( not_thread_safe, i ) ) == 0 )
+               {
+                       mlt_properties_set_int( properties, "_not_thread_safe", 1 );
+                       break;
+               }
+       }
+       mlt_properties_close( not_thread_safe );
+}
+
 static mlt_properties fill_param_info ( mlt_service_type type, const char *service_name, char *name )
 {
        char file[ PATH_MAX ];
@@ -62,6 +109,7 @@ static mlt_properties fill_param_info ( mlt_service_type type, const char *servi
        };
 
        snprintf( file, PATH_MAX, "%s/frei0r/%s_%s.yml", mlt_environment( "MLT_DATA" ), servicetype, service_name );
+       memset(&stat_buff, 0, sizeof(stat_buff));
        stat(file,&stat_buff);
 
        if (S_ISREG(stat_buff.st_mode)){
@@ -85,10 +133,11 @@ static mlt_properties fill_param_info ( mlt_service_type type, const char *servi
 
        f0r_init();
        plginfo(&info);
-       snprintf ( string, sizeof(string) , "%d.%d" , info.major_version , info.minor_version );
-       mlt_properties_set ( metadata, "schema_version" , "0.1" );
+       snprintf ( string, sizeof(string) , "%d" , info.minor_version );
+       mlt_properties_set_double ( metadata, "schema_version" , 0.1 );
        mlt_properties_set ( metadata, "title" , info.name );
-       mlt_properties_set ( metadata, "version", string );
+       mlt_properties_set_double ( metadata, "version",
+               info.major_version +  info.minor_version / pow( 10, strlen( string ) ) );
        mlt_properties_set ( metadata, "identifier" , service_name );
        mlt_properties_set ( metadata, "description" , info.explanation );
        mlt_properties_set ( metadata, "creator" , info.author );
@@ -150,7 +199,7 @@ static mlt_properties fill_param_info ( mlt_service_type type, const char *servi
        return metadata;
 }
 
-static void * load_lib(  mlt_profile profile, mlt_service_type type , void* handle){
+static void * load_lib( mlt_profile profile, mlt_service_type type , void* handle, const char *name ){
 
        int i=0;
        void (*f0r_get_plugin_info)(f0r_plugin_info_t*),
@@ -163,7 +212,6 @@ static void * load_lib(  mlt_profile profile, mlt_service_type type , void* hand
                  const uint32_t* inframe2,const uint32_t* inframe3, uint32_t* outframe);
 
        if ( ( f0r_construct = dlsym(handle, "f0r_construct") ) &&
-                               (f0r_update = dlsym(handle,"f0r_update") ) &&
                                (f0r_destruct = dlsym(handle,"f0r_destruct") ) &&
                                (f0r_get_plugin_info = dlsym(handle,"f0r_get_plugin_info") ) &&
                                (f0r_get_param_info = dlsym(handle,"f0r_get_param_info") ) &&
@@ -173,6 +221,7 @@ static void * load_lib(  mlt_profile profile, mlt_service_type type , void* hand
                                (f0r_deinit= dlsym(handle,"f0r_deinit" ) )
                ){
 
+               f0r_update=dlsym(handle,"f0r_update");
                f0r_update2=dlsym(handle,"f0r_update2");
 
                f0r_plugin_info_t info;
@@ -180,9 +229,10 @@ static void * load_lib(  mlt_profile profile, mlt_service_type type , void* hand
 
                void* ret=NULL;
                mlt_properties properties=NULL;
+               char minor[12];
 
                if (type == producer_type && info.plugin_type == F0R_PLUGIN_TYPE_SOURCE ){
-                       mlt_producer this = mlt_producer_new( );
+                       mlt_producer this = mlt_producer_new( profile );
                        if ( this != NULL )
                        {
                                this->get_frame = producer_get_frame;
@@ -227,22 +277,26 @@ static void * load_lib(  mlt_profile profile, mlt_service_type type , void* hand
                                ret=transition;
                        }
                }
-               mlt_properties_set_data(properties, "_dlclose_handle", handle , sizeof (void*) , NULL , NULL );
+               check_thread_safe( properties, name );
+               mlt_properties_set_data(properties, "_dlclose_handle", handle , sizeof ( handle ) , NULL , NULL );
                mlt_properties_set_data(properties, "_dlclose", dlclose , sizeof (void*) , NULL , NULL );
-               mlt_properties_set_data(properties, "f0r_construct", f0r_construct , sizeof(void*),NULL,NULL);
-               mlt_properties_set_data(properties, "f0r_update", f0r_update , sizeof(void*),NULL,NULL);
+               mlt_properties_set_data(properties, "f0r_construct", f0r_construct , sizeof( f0r_construct ),NULL,NULL);
+               mlt_properties_set_data(properties, "f0r_update", f0r_update , sizeof( f0r_update ),NULL,NULL);
                if (f0r_update2)
-                       mlt_properties_set_data(properties, "f0r_update2", f0r_update2 , sizeof(void*),NULL,NULL);
-               mlt_properties_set_data(properties, "f0r_destruct", f0r_destruct , sizeof(void*),NULL,NULL);
+                       mlt_properties_set_data(properties, "f0r_update2", f0r_update2 , sizeof( f0r_update2 ),NULL,NULL);
+               mlt_properties_set_data(properties, "f0r_destruct", f0r_destruct , sizeof( f0r_destruct ),NULL,NULL);
                mlt_properties_set_data(properties, "f0r_get_plugin_info", f0r_get_plugin_info , sizeof(void*),NULL,NULL);
                mlt_properties_set_data(properties, "f0r_get_param_info", f0r_get_param_info , sizeof(void*),NULL,NULL);
                mlt_properties_set_data(properties, "f0r_set_param_value", f0r_set_param_value , sizeof(void*),NULL,NULL);
                mlt_properties_set_data(properties, "f0r_get_param_value", f0r_get_param_value , sizeof(void*),NULL,NULL);
 
+               // Let frei0r plugin version be serialized using same format as metadata
+               snprintf( minor, sizeof( minor ), "%d", info.minor_version );
+               mlt_properties_set_double( properties, "version", info.major_version +  info.minor_version / pow( 10, strlen( minor ) ) );
 
                return ret;
        }else{
-               printf("some was wrong\n");
+               mlt_log_error( NULL, "frei0r plugin \"%s\" is missing a function\n", name );
                dlerror();
        }
        return NULL;
@@ -251,37 +305,49 @@ static void * load_lib(  mlt_profile profile, mlt_service_type type , void* hand
 static void * create_frei0r_item ( mlt_profile profile, mlt_service_type type, const char *id, void *arg){
 
        mlt_tokeniser tokeniser = mlt_tokeniser_init ( );
+       char *frei0r_path = get_frei0r_path();
        int dircount=mlt_tokeniser_parse_new (
                tokeniser,
-               GET_FREI0R_PATH,
+               frei0r_path,
                 ":"
        );
        void* ret=NULL;
        while (dircount--){
                char soname[PATH_MAX];
+               char *myid = strdup( id );
 
+#ifdef WIN32
+               char *firstname = strtok( myid, "." );
+#else
                char *save_firstptr = NULL;
-               char *firstname=strtok_r(strdup(id),".",&save_firstptr);
+               char *firstname = strtok_r( myid, ".", &save_firstptr );
+#endif
                char* directory = mlt_tokeniser_get_string (tokeniser, dircount);
 
-               firstname=strtok_r(NULL,".",&save_firstptr);
+#ifdef WIN32
+               firstname = strtok( NULL, "." );
+#else
+               firstname = strtok_r( NULL, ".", &save_firstptr );
+#endif
                if (strncmp(directory, "$HOME", 5))
-                       snprintf(soname, PATH_MAX, "%s/%s.so", directory, firstname);
+                       snprintf(soname, PATH_MAX, "%s/%s" LIBSUF, directory, firstname );
                else
-                       snprintf(soname, PATH_MAX, "%s%s/%s.so", getenv("HOME"), strchr(directory, '/'), firstname);
+                       snprintf(soname, PATH_MAX, "%s%s/%s" LIBSUF, getenv("HOME"), strchr(directory, '/'), firstname );
 
                if (firstname){
 
                        void* handle=dlopen(soname,RTLD_LAZY);
 
                        if (handle ){
-                               ret=load_lib ( profile , type , handle );
+                               ret=load_lib ( profile , type , handle, firstname );
                        }else{
                                dlerror();
                        }
                }
+               free( myid );
        }
        mlt_tokeniser_close ( tokeniser );
+       free( frei0r_path );
        return ret;
 }
 
@@ -290,9 +356,10 @@ MLT_REPOSITORY
 {
        int i=0;
        mlt_tokeniser tokeniser = mlt_tokeniser_init ( );
+       char *frei0r_path = get_frei0r_path();
        int dircount=mlt_tokeniser_parse_new (
                tokeniser ,
-               GET_FREI0R_PATH,
+               frei0r_path,
                ":"
        );
        char dirname[PATH_MAX];
@@ -308,20 +375,25 @@ MLT_REPOSITORY
                        snprintf(dirname, PATH_MAX, "%s", directory);
                else
                        snprintf(dirname, PATH_MAX, "%s%s", getenv("HOME"), strchr(directory, '/'));
-               mlt_properties_dir_list(direntries, dirname ,"*.so",1);
+               mlt_properties_dir_list(direntries, dirname ,"*" LIBSUF, 1);
 
                for (i=0; i<mlt_properties_count(direntries);i++){
                        char* name=mlt_properties_get_value(direntries,i);
                        char* shortname=name+strlen(dirname)+1;
+#ifdef WIN32
+                       char* firstname = strtok( shortname, "." );
+#else
                        char *save_firstptr = NULL;
+                       char* firstname = strtok_r( shortname, ".", &save_firstptr );
+#endif
                        char pluginname[1024]="frei0r.";
-                       char* firstname = strtok_r ( shortname , "." , &save_firstptr );
-                       strcat(pluginname,firstname);
+                       if ( firstname )
+                               strncat( pluginname, firstname, sizeof( pluginname ) - strlen( pluginname ) -1 );
 
-                       if ( mlt_properties_get( blacklist, firstname ) )
+                       if ( firstname && mlt_properties_get( blacklist, firstname ) )
                                continue;
 
-                       void* handle=dlopen(strcat(name,".so"),RTLD_LAZY);
+                       void* handle=dlopen(strcat(name, LIBSUF),RTLD_LAZY);
                        if (handle){
                                void (*plginfo)(f0r_plugin_info_t*)=dlsym(handle,"f0r_get_plugin_info");
 
@@ -363,4 +435,5 @@ MLT_REPOSITORY
        }
        mlt_tokeniser_close ( tokeniser );
        mlt_properties_close( blacklist );
+       free( frei0r_path );
 }