]> git.sesse.net Git - mlt/blobdiff - src/modules/kdenlive/producer_framebuffer.c
Fix framebuffer producer preventing image conversion and crop.
[mlt] / src / modules / kdenlive / producer_framebuffer.c
index 9e6ba2da4e4be9d4fca83105732b900a73bbb493..6097243a039728b6a73ffc44b01434cce5579340 100644 (file)
@@ -18,7 +18,6 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#include "producer_framebuffer.h"
 #include <framework/mlt.h>
 
 #include <stdio.h>
@@ -39,170 +38,193 @@ static int framebuffer_get_image( mlt_frame this, uint8_t **image, mlt_image_for
 
        // Get the filter object and properties
        mlt_producer producer = mlt_frame_pop_service( this );
-       mlt_frame first_frame = mlt_frame_pop_service( this );
-
-       mlt_properties producer_properties = MLT_PRODUCER_PROPERTIES( producer );
+       int index = ( int )mlt_frame_pop_service( this );
+       mlt_properties properties = MLT_PRODUCER_PROPERTIES( producer );
 
        // Frame properties objects
        mlt_properties frame_properties = MLT_FRAME_PROPERTIES( this );
-       mlt_properties first_frame_properties = MLT_FRAME_PROPERTIES( first_frame );
+       mlt_frame first_frame = mlt_properties_get_data( properties, "first_frame", NULL );
+
+       // Get producer parameters
+       int strobe = mlt_properties_get_int( properties, "strobe" );
+       int freeze = mlt_properties_get_int( properties, "freeze" );
+       int freeze_after = mlt_properties_get_int( properties, "freeze_after" );
+       int freeze_before = mlt_properties_get_int( properties, "freeze_before" );
+
+       // Determine the position
+       mlt_position first_position = (first_frame != NULL) ? mlt_frame_get_position( first_frame ) : -1;
+       mlt_position need_first = freeze;
+
+       if ( !freeze || freeze_after || freeze_before )
+       {
+               double prod_speed = mlt_properties_get_double( properties, "_speed" );
+               double actual_position = prod_speed * (double) mlt_producer_position( producer );
+
+               if ( mlt_properties_get_int( properties, "reverse" ) )
+                       actual_position = mlt_producer_get_playtime( producer ) - actual_position;
 
+               if ( strobe < 2 )
+               {
+                       need_first = floor( actual_position );
+               }
+               else
+               {
+                       // Strobe effect wanted, calculate frame position
+                       need_first = floor( actual_position );
+                       need_first -= need_first % strobe;
+               }
+               if ( freeze )
+               {
+                       if ( freeze_after && need_first > freeze ) need_first = freeze;
+                       else if ( freeze_before && need_first < freeze ) need_first = freeze;
+               }
+       }
+       
+       // Determine output buffer size
        *width = mlt_properties_get_int( frame_properties, "width" );
        *height = mlt_properties_get_int( frame_properties, "height" );
-
-       // image stride
-       int size, xstride, ystride;
-       switch( *format ){
-               case mlt_image_yuv422:
-                       size = *width * *height * 2;
-                       xstride = 2;
-                       ystride = 2 * *width;
+       
+       int size;
+       switch ( *format )
+       {
+               case mlt_image_yuv420p:
+                       size = *width * 3 * ( *height + 1 ) / 2;
+                       break;
+               case mlt_image_rgb24:
+                       size = *width * ( *height + 1 ) * 3;
+                       break;
+               case mlt_image_rgb24a:
+               case mlt_image_opengl:
+                       size = *width * ( *height + 1 ) * 4;
                        break;
                default:
-                       fprintf(stderr, "Unsupported image format\n");
-                       return -1;
+                       *format = mlt_image_yuv422;
+                       size = *width * ( *height + 1 ) * 2;
+                       break;
        }
+       
 
-       uint8_t *output = mlt_properties_get_data( producer_properties, "output_buffer", 0 );
-       if( output == NULL )
+       // Get output buffer
+       int buffersize = 0;
+       uint8_t *output = mlt_properties_get_data( properties, "output_buffer", &buffersize );
+       if( buffersize == 0 || buffersize != size)
        {
-               output = mlt_pool_alloc( size );
+               // invalidate cached frame
+               first_position = -1;
+       }
 
-               // Let someone else clean up
-               mlt_properties_set_data( producer_properties, "output_buffer", output, size, mlt_pool_release, NULL ); 
+       if ( need_first != first_position )
+       {
+               // invalidate cached frame
+               first_position = -1;
+               
+               // Bust the cached frame
+               mlt_properties_set_data( properties, "first_frame", NULL, 0, NULL, NULL );
+               first_frame = NULL;
        }
 
-       uint8_t *first_image = mlt_properties_get_data( first_frame_properties, "image", NULL );
+       if (output != NULL && first_position != -1) {
+               // Using the cached frame
+               uint8_t *image_copy = mlt_pool_alloc( size );
+               memcpy( image_copy, output, size );
+
+               // Set the output image
+               *image = image_copy;
+               mlt_properties_set_data( frame_properties, "image", image_copy, size, ( mlt_destructor )mlt_pool_release, NULL );
 
-       // which frames are buffered?
+               // Make sure that no further scaling is done
+               mlt_properties_set( frame_properties, "rescale.interps", "none" );
+               mlt_properties_set( frame_properties, "scale", "off" );
+               return 0;
+       }
+
+       // Get the cached frame
+       if ( first_frame == NULL )
+       {
+               // Get the frame to cache from the real producer
+               mlt_producer real_producer = mlt_properties_get_data( properties, "producer", NULL );
+
+               // Seek the producer to the correct place
+               mlt_producer_seek( real_producer, need_first );
 
-       int error = 0;
+               // Get the frame
+               mlt_service_get_frame( MLT_PRODUCER_SERVICE( real_producer ), &first_frame, index );
+
+               // Cache the frame
+               mlt_properties_set_data( properties, "first_frame", first_frame, 0, ( mlt_destructor )mlt_frame_close, NULL );
+       }
+       mlt_properties first_frame_properties = MLT_FRAME_PROPERTIES( first_frame );
+       
 
+       // Which frames are buffered?
+       uint8_t *first_image = mlt_properties_get_data( first_frame_properties, "image", NULL );
        if( first_image == NULL )
        {
-               error = mlt_frame_get_image( first_frame, &first_image, format, width, height, writable );
+               mlt_properties_set_double( first_frame_properties, "consumer_aspect_ratio", mlt_properties_get_double( frame_properties, "consumer_aspect_ratio" ) );
+               mlt_properties_set( first_frame_properties, "rescale.interp", mlt_properties_get( frame_properties, "rescale.interp" ) );
+
+               int error = mlt_frame_get_image( first_frame, &first_image, format, width, height, writable );
 
-               if( error != 0 ) {
+               if ( error != 0 ) {
                        fprintf(stderr, "first_image == NULL get image died\n");
                        return error;
                }
+               output = mlt_pool_alloc( size );
+               memcpy( output, first_image, size );
+               // Let someone else clean up
+               mlt_properties_set_data( properties, "output_buffer", output, size, mlt_pool_release, NULL ); 
+       
        }
 
-       // Start with a base image
-       memcpy( output, first_image, size );
+       // Create a copy
+       uint8_t *image_copy = mlt_pool_alloc( size );
+       memcpy( image_copy, first_image, size );
 
-       *image = output;
-       mlt_properties_set_data( frame_properties, "image", output, size, NULL, NULL );
+       // Set the output image
+       *image = image_copy;
+       mlt_properties_set_data( frame_properties, "image", *image, size, ( mlt_destructor )mlt_pool_release, NULL );
 
        // Make sure that no further scaling is done
        mlt_properties_set( frame_properties, "rescale.interps", "none" );
        mlt_properties_set( frame_properties, "scale", "off" );
 
-       mlt_frame_close( first_frame );
-
        return 0;
 }
 
 static int producer_get_frame( mlt_producer this, mlt_frame_ptr frame, int index )
 {
        // Construct a new frame
-       *frame = mlt_frame_init( );
-       mlt_properties properties = MLT_PRODUCER_PROPERTIES(this);
-
+       *frame = mlt_frame_init( MLT_PRODUCER_SERVICE( this ) );
        if( frame != NULL )
        {
-               mlt_frame first_frame = mlt_properties_get_data( properties, "first_frame", NULL );
-
-               mlt_position first_position = (first_frame != NULL) ? mlt_frame_get_position( first_frame ) : -1;
-
-               // Get the real producer
-               mlt_producer real_producer = mlt_properties_get_data( properties, "producer", NULL );
-
-               // get properties               
-               int strobe = mlt_properties_get_int( properties, "strobe");
-               int freeze = mlt_properties_get_int( properties, "freeze");
-               int freeze_after = mlt_properties_get_int( properties, "freeze_after");
-               int freeze_before = mlt_properties_get_int( properties, "freeze_before");
-
-               mlt_position need_first;
-
-               if (!freeze || freeze_after || freeze_before) {
-                       double prod_speed = mlt_properties_get_double( properties, "_speed");
-                       double actual_position = prod_speed * (double) mlt_producer_position( this );
-
-                       if (mlt_properties_get_int( properties, "reverse")) actual_position = mlt_producer_get_playtime(this) - actual_position;
-
-                       if (strobe < 2)
-                       { 
-                               need_first = floor( actual_position );
-                       }
-                       else 
-                       {
-                               // Strobe effect wanted, calculate frame position
-                               need_first = floor( actual_position );
-                               need_first -= need_first%strobe;
-                       }
-                       if (freeze)
-                       {
-                               if (freeze_after && need_first > freeze) need_first = freeze;
-                               else if (freeze_before && need_first < freeze) need_first = freeze;
-                       }
-               }
-               else need_first = freeze;
-
-               if( need_first != first_position )
-               {
-                       mlt_frame_close( first_frame );
-                       first_position = -1;
-                       first_frame = NULL;
-               }
-
-               if( first_frame == NULL )
-               {
-                       // Seek the producer to the correct place
-                       mlt_producer_seek( real_producer, need_first );
-
-                       // Get the frame
-                       mlt_service_get_frame( MLT_PRODUCER_SERVICE( real_producer ), &first_frame, index );
-
-                       double ratio = (double) mlt_properties_get_int( MLT_FRAME_PROPERTIES( first_frame ), "width" ) / (double) mlt_properties_get_int( MLT_FRAME_PROPERTIES( first_frame ), "height" ) / ( (double) mlt_properties_get_int(MLT_FRAME_PROPERTIES( *frame ), "width" ) / (double) mlt_properties_get_int( MLT_FRAME_PROPERTIES( *frame ), "height" ));
-               }
-
-               // Make sure things are in their place
-               mlt_properties_set_data( properties, "first_frame", first_frame, 0, NULL, NULL );
-
                // Stack the producer and producer's get image
-               mlt_frame_push_service( *frame, first_frame );
-               mlt_properties_inc_ref( MLT_FRAME_PROPERTIES( first_frame ) );
-
+               mlt_frame_push_service( *frame, (void*) index );
                mlt_frame_push_service( *frame, this );
                mlt_frame_push_service( *frame, framebuffer_get_image );
 
-
                // Give the returned frame temporal identity
                mlt_frame_set_position( *frame, mlt_producer_position( this ) );
-               mlt_properties_set_double( MLT_FRAME_PROPERTIES(*frame), "aspect_ratio", mlt_properties_get_double( properties, "ratio_fix" ));
        }
 
        return 0;
 }
 
 
-mlt_producer producer_framebuffer_init( char *arg )
+mlt_producer producer_framebuffer_init( mlt_profile profile, mlt_service_type type, const char *id, char *arg )
 {
-
+       if ( !arg ) return NULL;
        mlt_producer this = NULL;
        this = calloc( 1, sizeof( struct mlt_producer_s ) );
-        mlt_producer_init( this, NULL );
+       mlt_producer_init( this, NULL );
 
-       // Wrap fezzik
+       // Wrap loader
        mlt_producer real_producer;
        
        // Check if a speed was specified.
        /** 
 
-       * Speed must be appended to the filename with ':'. To play your video at 50%:
-        inigo framebuffer:my_video.mpg:0.5
+       * Speed must be appended to the filename with '?'. To play your video at 50%:
+        melt framebuffer:my_video.mpg?0.5
 
        * Stroboscope effect can be obtained by adding a stobe=x parameter, where
         x is the number of frames that will be ignored.
@@ -214,46 +236,49 @@ mlt_producer producer_framebuffer_init( char *arg )
 
        **/
 
-       double speed;
-
-       int count;
+       double speed = 0.0;
        char *props = strdup( arg );
-       char *ptr = props;
-       count = strcspn( ptr, ":" );
-       ptr[count] = '\0';
-
-       real_producer = mlt_factory_producer( "fezzik", props );
-
-       ptr += count + 1;
-       ptr += strspn( ptr, ":" );
-       count = strcspn( ptr, ":" );
-       ptr[count] = '\0';
-       speed = atof(ptr);
-       free( props );
+       char *ptr = strrchr( props, '?' );
        
-       if (speed == 0.0) speed = 1.0;
+       if ( ptr )
+       {
+               speed = atof( ptr + 1 );
+               if ( speed != 0.0 )
+                       // If speed was valid, then strip it and the delimiter.
+                       // Otherwise, an invalid speed probably means this '?' was not a delimiter.
+                       *ptr = '\0';
+       }
+               
+       real_producer = mlt_factory_producer( profile, NULL, props );
+       free( props );
 
+       if (speed == 0.0) speed = 1.0;
 
        if ( this != NULL && real_producer != NULL)
        {
                // Get the properties of this producer
                mlt_properties properties = MLT_PRODUCER_PROPERTIES( this );
 
-               // Fezzik normalised it for us already
-               mlt_properties_set_int( properties, "fezzik_normalised", 1);
+               mlt_properties_set( properties, "resource", arg);
 
                // Store the producer and fitler
                mlt_properties_set_data( properties, "producer", real_producer, 0, ( mlt_destructor )mlt_producer_close, NULL );
 
                // Grab some stuff from the real_producer
-               mlt_properties_pass_list( properties, MLT_PRODUCER_PROPERTIES( real_producer ), "length,resource,width,height" );
+               mlt_properties_pass_list( properties, MLT_PRODUCER_PROPERTIES( real_producer ), "length, width,height" );
 
+               if ( speed < 0 )
+               {
+                       speed = -speed;
+                       mlt_properties_set_int( properties, "reverse", 1 );
+               }
 
                if ( speed != 1.0 )
                {
-                       double real_length = (double)  mlt_producer_get_length( real_producer );
-                       mlt_properties_set_position( properties, "length", real_length / speed );
+                       double real_length = ( (double)  mlt_producer_get_length( real_producer ) ) / speed;
+                       mlt_properties_set_position( properties, "length", real_length );
                }
+               mlt_properties_set_position( properties, "out", mlt_producer_get_length( this ) - 1 );
 
                // Since we control the seeking, prevent it from seeking on its own
                mlt_producer_set_speed( real_producer, 0 );