# include "config.h"
#endif
-#include <vlc/vlc.h>
+#include <vlc_common.h>
+#include <vlc_plugin.h>
#include "libvlc.h"
/* Some faulty libcs have a broken struct dirent when _FILE_OFFSET_BITS
#include "config/configuration.h"
#include "vlc_charset.h"
+#include "vlc_arrays.h"
#include "modules/modules.h"
#include "modules/builtin.h"
static module_t * AllocatePlugin( vlc_object_t *, char * );
#endif
static int AllocateBuiltinModule( vlc_object_t *, int ( * ) ( module_t * ) );
-static int DeleteModule ( module_t *, bool );
+static void DeleteModule ( module_t *, bool );
#ifdef HAVE_DYNAMIC_PLUGINS
static void DupModule ( module_t * );
static void UndupModule ( module_t * );
if( p_libvlc_global->p_module_bank == NULL )
{
- p_bank = vlc_object_create( p_this, sizeof(module_bank_t) );
- p_bank->psz_object_name = "module bank";
+ p_bank = vlc_custom_create( p_this, sizeof(module_bank_t),
+ VLC_OBJECT_GENERIC, "module bank");
p_bank->i_usage = 1;
p_bank->i_cache = p_bank->i_loaded_cache = 0;
p_bank->pp_cache = p_bank->pp_loaded_cache = NULL;
vlc_object_detach( p_libvlc_global->p_module_bank );
- while( p_libvlc_global->p_module_bank->i_children )
+ while( vlc_internals( p_libvlc_global->p_module_bank )->i_children )
{
- p_next = (module_t *)p_libvlc_global->p_module_bank->pp_children[0];
-
- if( DeleteModule( p_next, true ) )
- {
- /* Module deletion failed */
- msg_Err( p_this, "module \"%s\" can't be removed, trying harder",
- p_next->psz_object_name );
-
- /* We just free the module by hand. Niahahahahaha. */
- vlc_object_detach( p_next );
- vlc_object_release( p_next );
- }
+ p_next = (module_t *)vlc_internals( p_libvlc_global->p_module_bank )->pp_children[0];
+ DeleteModule( p_next, true );
}
vlc_object_release( p_libvlc_global->p_module_bank );
{
typedef struct module_list_t module_list_t;
+ stats_TimerStart( p_this, "module_Need()", STATS_TIMER_MODULE_NEED );
+
struct module_list_t
{
module_t *p_module;
/* Deal with variables */
if( psz_name && psz_name[0] == '$' )
{
- vlc_value_t val;
- var_Create( p_this, psz_name + 1, VLC_VAR_MODULE | VLC_VAR_DOINHERIT );
- var_Get( p_this, psz_name + 1, &val );
- psz_var = val.psz_string;
- psz_name = psz_var;
+ psz_name = psz_var = var_CreateGetString( p_this, psz_name + 1 );
}
/* Count how many different shortcuts were asked for */
if( !strcmp( psz_name, "none" ) )
{
free( psz_var );
+ stats_TimerStop( p_this, STATS_TIMER_MODULE_NEED );
+ stats_TimerDump( p_this, STATS_TIMER_MODULE_NEED );
+ stats_TimerClean( p_this, STATS_TIMER_MODULE_NEED );
return NULL;
}
/* This assumes that p_this is the object which will be using the
* module. That's not always the case ... but it is in most cases.
*/
- p_this->psz_object_name = p_module->psz_object_name;
+ if( psz_alias )
+ p_this->psz_object_name = strdup( psz_alias );
+ else
+ p_this->psz_object_name = strdup( p_module->psz_object_name );
}
free( psz_shortcuts );
free( psz_var );
+ stats_TimerStop( p_this, STATS_TIMER_MODULE_NEED );
+ stats_TimerDump( p_this, STATS_TIMER_MODULE_NEED );
+ stats_TimerClean( p_this, STATS_TIMER_MODULE_NEED );
+
/* Don't forget that the module is still locked */
return p_module;
}
msg_Dbg( p_this, "removing module \"%s\"", p_module->psz_object_name );
vlc_object_release( p_module );
-
- return;
}
/**
static char * copy_next_paths_token( char * paths, char ** remaining_paths )
{
char * path;
- int i;
+ int i, done;
bool escaped = false;
assert( paths );
if( !path ) return NULL;
/* Look for PATH_SEP_CHAR (a ':' or a ';') */
- for( i = 0; paths[i]; i++ ) {
+ for( i = 0, done = 0 ; paths[i]; i++ )
+ {
/* Take care of \\ and \: or \; escapement */
- if( escaped ) {
+ if( escaped )
+ {
escaped = false;
- path[i] = paths[i];
+ path[done++] = paths[i];
}
+#ifdef WIN32
+ else if( paths[i] == '/' )
+ escaped = true;
+#else
else if( paths[i] == '\\' )
escaped = true;
+#endif
else if( paths[i] == PATH_SEP_CHAR )
break;
else
- path[i] = paths[i];
+ path[done++] = paths[i];
}
- path[i] = 0;
+ path[done++] = 0;
/* Return the remaining paths */
if( remaining_paths ) {
#ifdef HAVE_DYNAMIC_PLUGINS
static void AllocateAllPlugins( vlc_object_t *p_this )
{
- char *paths, *path, *paths_iter;
- char * extra_path;
+ const char *vlcpath = vlc_global()->psz_vlcpath;
+ int count,i;
+ char * path;
+ vlc_array_t *arraypaths = vlc_array_new();
/* Contruct the special search path for system that have a relocatable
* executable. Set it to <vlc path>/modules and <vlc path>/plugins. */
-#if defined( WIN32 ) || defined( UNDER_CE ) || defined( __APPLE__ ) || defined( SYS_BEOS )
- if( asprintf( &extra_path,
- "%s" DIR_SEP "modules" PATH_SEP
- "%s" DIR_SEP "plugins"
- "%s",
- vlc_global()->psz_vlcpath,
- vlc_global()->psz_vlcpath,
-# if defined( WIN32 ) || defined( UNDER_CE )
- "" ) < 0 )
-# else
- PATH_SEP PLUGIN_PATH ) < 0 )
-# endif
- {
- msg_Err( p_this, "Not enough memory" );
- return;
- }
-#else
- extra_path = strdup( PLUGIN_PATH );
+ if( vlcpath && asprintf( &path, "%s" DIR_SEP "modules", vlcpath ) != -1 )
+ vlc_array_append( arraypaths, path );
+ if( vlcpath && asprintf( &path, "%s" DIR_SEP "plugins", vlcpath ) != -1 )
+ vlc_array_append( arraypaths, path );
+#ifndef WIN32
+ vlc_array_append( arraypaths, strdup( PLUGIN_PATH ) );
#endif
/* If the user provided a plugin path, we add it to the list */
- char * userpaths = config_GetPsz( p_this, "plugin-path" );
+ char *userpaths = config_GetPsz( p_this, "plugin-path" );
+ char *paths_iter;
- if( asprintf( &paths, "modules" PATH_SEP "%s" PATH_SEP "plugins%s%s",
- extra_path,
- userpaths ? PATH_SEP : "",
- userpaths ? userpaths : "" ) < 0 )
+ for( paths_iter = userpaths; paths_iter; )
{
- msg_Err( p_this, "Not enough memory" );
- free( userpaths );
- free( extra_path );
- return;
+ path = copy_next_paths_token( paths_iter, &paths_iter );
+ if( path )
+ vlc_array_append( arraypaths, path );
}
- /* Free plugin-path and extra path */
- free( userpaths );
- free( extra_path );
-
- msg_Dbg( p_this, "We will be looking for modules in `%s'", paths );
-
- for( paths_iter = paths; paths_iter; )
+ count = vlc_array_count( arraypaths );
+ for( i = 0 ; i < count ; i++ )
{
- path = copy_next_paths_token( paths_iter, &paths_iter );
+ path = vlc_array_item_at_index( arraypaths, i );
if( !path )
- {
- msg_Err( p_this, "Not enough memory" );
- return;
- }
+ continue;
msg_Dbg( p_this, "recursively browsing `%s'", path );
free( path );
}
- free( paths );
+ vlc_array_destroy( arraypaths );
+ free( userpaths );
}
/*****************************************************************************
p_bank->pp_cache[p_bank->i_cache]->b_used = true;
p_bank->pp_cache[p_bank->i_cache]->p_module = p_module;
p_bank->i_cache++;
+#undef p_bank
}
return p_module ? 0 : -1;
p_module = vlc_module_create( p_this );
if( p_module == NULL )
{
- msg_Err( p_this, "out of memory" );
module_Unload( handle );
return NULL;
}
*****************************************************************************/
static void DupModule( module_t *p_module )
{
- const char **pp_shortcut;
+ char **pp_shortcut;
int i_submodule;
for( pp_shortcut = p_module->pp_shortcuts ; *pp_shortcut ; pp_shortcut++ )
/* We strdup() these entries so that they are still valid when the
* module is unloaded. */
- p_module->psz_object_name = strdup( p_module->psz_object_name );
p_module->psz_capability = strdup( p_module->psz_capability );
p_module->psz_shortname = p_module->psz_shortname ?
strdup( p_module->psz_shortname ) : NULL;
p_module->psz_help = p_module->psz_help ? strdup( p_module->psz_help )
: NULL;
- for( i_submodule = 0; i_submodule < p_module->i_children; i_submodule++ )
+ for( i_submodule = 0; i_submodule < vlc_internals( p_module )->i_children; i_submodule++ )
{
- DupModule( (module_t*)p_module->pp_children[ i_submodule ] );
+ DupModule( (module_t*)vlc_internals( p_module )->pp_children[ i_submodule ] );
}
}
*****************************************************************************/
static void UndupModule( module_t *p_module )
{
- const char **pp_shortcut;
+ char **pp_shortcut;
int i_submodule;
- for( i_submodule = 0; i_submodule < p_module->i_children; i_submodule++ )
+ for( i_submodule = 0; i_submodule < vlc_internals( p_module )->i_children; i_submodule++ )
{
- UndupModule( (module_t*)p_module->pp_children[ i_submodule ] );
+ UndupModule( (module_t*)vlc_internals( p_module )->pp_children[ i_submodule ] );
}
for( pp_shortcut = p_module->pp_shortcuts ; *pp_shortcut ; pp_shortcut++ )
{
- free( (void*)*pp_shortcut );
+ free( *pp_shortcut );
}
- free( (void*)p_module->psz_object_name );
+ FREENULL( p_module->psz_object_name );
free( p_module->psz_capability );
- free( (void*)p_module->psz_shortname );
- free( (void*)p_module->psz_longname );
- free( (void*)p_module->psz_help );
+ free( p_module->psz_shortname );
+ free( p_module->psz_longname );
+ free( p_module->psz_help );
}
#endif /* HAVE_DYNAMIC_PLUGINS */
* allocate a structure for it */
p_module = vlc_module_create( p_this );
if( p_module == NULL )
- {
- msg_Err( p_this, "out of memory" );
return -1;
- }
/* Initialize the module : fill p_module->psz_object_name, etc. */
if( pf_entry( p_module ) != 0 )
*****************************************************************************
* This function can only be called if the module isn't being used.
*****************************************************************************/
-static int DeleteModule( module_t * p_module, bool b_detach )
+static void DeleteModule( module_t * p_module, bool b_detach )
{
- if( !p_module ) return VLC_EGENERIC;
+ assert( p_module );
+
if( b_detach )
vlc_object_detach( p_module );
#endif
/* Free and detach the object's children */
- while( p_module->i_children )
+ while( vlc_internals( p_module )->i_children )
{
- vlc_object_t *p_this = p_module->pp_children[0];
+ vlc_object_t *p_this = vlc_internals( p_module )->pp_children[0];
vlc_object_detach( p_this );
vlc_object_release( p_this );
}
config_Free( p_module );
vlc_object_release( p_module );
- p_module = NULL;
- return 0;
}
projects / vlc / blobdiff