# include "config.h"
#endif
-#include <vlc/vlc.h>
+#include <vlc_common.h>
#include <vlc_plugin.h>
#include "libvlc.h"
#include "modules/modules.h"
#include "modules/builtin.h"
+module_bank_t *p_module_bank;
+
/*****************************************************************************
* Local prototypes
*****************************************************************************/
static module_t * AllocatePlugin( vlc_object_t *, char * );
#endif
static int AllocateBuiltinModule( vlc_object_t *, int ( * ) ( module_t * ) );
-static int DeleteModule ( module_t *, bool );
+static void DeleteModule ( module_t *, bool );
#ifdef HAVE_DYNAMIC_PLUGINS
static void DupModule ( module_t * );
static void UndupModule ( module_t * );
void __module_InitBank( vlc_object_t *p_this )
{
module_bank_t *p_bank = NULL;
- libvlc_global_data_t *p_libvlc_global = vlc_global();
vlc_mutex_t *lock = var_AcquireMutex( "libvlc" );
- if( p_libvlc_global->p_module_bank == NULL )
+ if( p_module_bank == NULL )
{
p_bank = vlc_custom_create( p_this, sizeof(module_bank_t),
VLC_OBJECT_GENERIC, "module bank");
p_bank->pp_cache = p_bank->pp_loaded_cache = NULL;
p_bank->b_cache = p_bank->b_cache_dirty =
p_bank->b_cache_delete = false;
+ p_bank->head = NULL;
/* Everything worked, attach the object */
- p_libvlc_global->p_module_bank = p_bank;
- vlc_object_attach( p_bank, p_libvlc_global );
+ p_module_bank = p_bank;
/* Fills the module bank structure with the main module infos.
* This is very useful as it will allow us to consider the main
AllocateBuiltinModule( p_this, vlc_entry__main );
}
else
- p_libvlc_global->p_module_bank->i_usage++;
+ p_module_bank->i_usage++;
vlc_mutex_unlock( lock );
}
void __module_EndBank( vlc_object_t *p_this )
{
module_t * p_next = NULL;
- libvlc_global_data_t *p_libvlc_global = vlc_global();
vlc_mutex_t *lock = var_AcquireMutex( "libvlc" );
- if( !p_libvlc_global->p_module_bank )
+ if( !p_module_bank )
{
vlc_mutex_unlock( lock );
return;
}
- if( --p_libvlc_global->p_module_bank->i_usage )
+ if( --p_module_bank->i_usage )
{
vlc_mutex_unlock( lock );
return;
config_AutoSaveConfigFile( p_this );
#ifdef HAVE_DYNAMIC_PLUGINS
-# define p_bank p_libvlc_global->p_module_bank
+# define p_bank p_module_bank
if( p_bank->b_cache ) CacheSave( p_this );
while( p_bank->i_loaded_cache-- )
{
# undef p_bank
#endif
- vlc_object_detach( p_libvlc_global->p_module_bank );
-
- while( p_libvlc_global->p_module_bank->i_children )
+ while( vlc_internals( p_module_bank )->i_children )
{
- p_next = (module_t *)p_libvlc_global->p_module_bank->pp_children[0];
-
- if( DeleteModule( p_next, true ) )
- {
- /* Module deletion failed */
- msg_Err( p_this, "module \"%s\" can't be removed, trying harder",
- p_next->psz_object_name );
-
- /* We just free the module by hand. Niahahahahaha. */
- vlc_object_detach( p_next );
- vlc_object_release( p_next );
- }
+ p_next = (module_t *)vlc_internals( p_module_bank )->pp_children[0];
+ DeleteModule( p_next, true );
}
- vlc_object_release( p_libvlc_global->p_module_bank );
- p_libvlc_global->p_module_bank = NULL;
+ vlc_object_release( p_module_bank );
+ p_module_bank = NULL;
}
/**
*/
void __module_LoadBuiltins( vlc_object_t * p_this )
{
- libvlc_global_data_t *p_libvlc_global = vlc_global();
-
vlc_mutex_t *lock = var_AcquireMutex( "libvlc" );
- if( p_libvlc_global->p_module_bank->b_builtins )
+ if( p_module_bank->b_builtins )
{
vlc_mutex_unlock( lock );
return;
}
- p_libvlc_global->p_module_bank->b_builtins = true;
+ p_module_bank->b_builtins = true;
vlc_mutex_unlock( lock );
msg_Dbg( p_this, "checking builtin modules" );
void __module_LoadPlugins( vlc_object_t * p_this )
{
#ifdef HAVE_DYNAMIC_PLUGINS
- libvlc_global_data_t *p_libvlc_global = vlc_global();
-
vlc_mutex_t *lock = var_AcquireMutex( "libvlc" );
- if( p_libvlc_global->p_module_bank->b_plugins )
+ if( p_module_bank->b_plugins )
{
vlc_mutex_unlock( lock );
return;
}
- p_libvlc_global->p_module_bank->b_plugins = true;
+ p_module_bank->b_plugins = true;
vlc_mutex_unlock( lock );
msg_Dbg( p_this, "checking plugin modules" );
if( config_GetInt( p_this, "plugins-cache" ) )
- p_libvlc_global->p_module_bank->b_cache = true;
+ p_module_bank->b_cache = true;
- if( p_libvlc_global->p_module_bank->b_cache ||
- p_libvlc_global->p_module_bank->b_cache_delete ) CacheLoad( p_this );
+ if( p_module_bank->b_cache ||
+ p_module_bank->b_cache_delete ) CacheLoad( p_this );
AllocateAllPlugins( p_this );
#endif
* \param cap the capability to check
* \return TRUE if the module have the capability
*/
-bool module_IsCapable( const module_t *m, const char *cap )
+bool module_provides( const module_t *m, const char *cap )
{
return !strcmp( m->psz_capability, cap );
}
* \param m the module
* \return the module name
*/
-const char *module_GetObjName( const module_t *m )
+const char *module_get_object( const module_t *m )
{
return m->psz_object_name;
}
* \param long_name TRUE to have the long name of the module
* \return the short or long name of the module
*/
-const char *module_GetName( const module_t *m, bool long_name )
+const char *module_get_name( const module_t *m, bool long_name )
{
if( long_name && ( m->psz_longname != NULL) )
return m->psz_longname;
* \param m the module
* \return the help
*/
-const char *module_GetHelp( const module_t *m )
+const char *module_get_help( const module_t *m )
{
return m->psz_help;
}
+module_t *module_hold (module_t *m)
+{
+ vlc_hold (&m->vlc_gc_data);
+ return m;
+}
+
+void module_release (module_t *m)
+{
+ vlc_release (&m->vlc_gc_data);
+}
+
+/**
+ * Frees the flat list of VLC modules.
+ * @param list list obtained by module_list_get
+ * @param length number of items on the list
+ * @return nothing.
+ */
+void module_list_free (module_t **list)
+{
+ if (list == NULL)
+ return;
+
+ for (size_t i = 0; list[i] != NULL; i++)
+ module_release (list[i]);
+ free (list);
+}
+
+/**
+ * Gets the flat list of VLC modules.
+ * @param n [OUT] pointer to the number of modules or NULL
+ * @return NULL-terminated table of module pointers
+ * (release with module_list_free()), or NULL in case of error.
+ */
+module_t **module_list_get (size_t *n)
+{
+ /* TODO: this whole module lookup is quite inefficient */
+ /* Remove this and improve module_need */
+ module_t **tab = NULL;
+ size_t i = 0;
+
+ for (module_t *mod = p_module_bank->head; mod; mod = mod->next)
+ {
+ module_t **nt;
+ nt = realloc (tab, (i + 2 + mod->submodule_count) * sizeof (*tab));
+ if (nt == NULL)
+ {
+ module_list_free (tab);
+ return NULL;
+ }
+
+ tab = nt;
+ tab[i++] = module_hold (mod);
+ for (module_t *subm = mod->submodule; subm; subm = subm->next)
+ tab[i++] = module_hold (subm);
+ tab[i] = NULL;
+ }
+ if (n != NULL)
+ *n = i;
+ return tab;
+}
+
/**
* module Need
*
* Return the best module function, given a capability list.
+ *
+ * If the p_this object doesn't have it's psz_object_name set, then
+ * psz_object_name will be set to the module's name, unless the user
+ * provided an alias using the "module name@alias" syntax in which case
+ * psz_object_name will be set to the alias.
+ *
* \param p_this the vlc object
* \param psz_capability list of capabilities needed
* \param psz_name name of the module asked
* \param b_strict TRUE yto use the strict mode
* \return the module or NULL in case of a failure
*/
-module_t * __module_Need( vlc_object_t *p_this, const char *psz_capability,
+module_t * __module_need( vlc_object_t *p_this, const char *psz_capability,
const char *psz_name, bool b_strict )
{
typedef struct module_list_t module_list_t;
- stats_TimerStart( p_this, "module_Need()", STATS_TIMER_MODULE_NEED );
+ stats_TimerStart( p_this, "module_need()", STATS_TIMER_MODULE_NEED );
struct module_list_t
{
};
module_list_t *p_list, *p_first, *p_tmp;
- vlc_list_t *p_all;
int i_which_module, i_index = 0;
/* Deal with variables */
if( psz_name && psz_name[0] == '$' )
{
- vlc_value_t val;
- var_Create( p_this, psz_name + 1, VLC_VAR_MODULE | VLC_VAR_DOINHERIT );
- var_Get( p_this, psz_name + 1, &val );
- psz_var = val.psz_string;
- psz_name = psz_var;
+ psz_name = psz_var = var_CreateGetString( p_this, psz_name + 1 );
}
/* Count how many different shortcuts were asked for */
}
/* Sort the modules and test them */
- p_all = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE );
- p_list = malloc( p_all->i_count * sizeof( module_list_t ) );
+ size_t count;
+ module_t **p_all = module_list_get (&count);
+ p_list = malloc( count * sizeof( module_list_t ) );
p_first = NULL;
unsigned i_cpu = vlc_CPU();
/* Parse the module list for capabilities and probe each of them */
- for( i_which_module = 0; i_which_module < p_all->i_count; i_which_module++ )
+ for( i_which_module = 0; i_which_module < count; i_which_module++ )
{
int i_shortcut_bonus = 0;
-
- p_module = (module_t *)p_all->p_values[i_which_module].p_object;
+ p_module = p_all[i_which_module];
/* Test that this module can do what we need */
- if( !module_IsCapable( p_module, psz_capability ) )
+ if( !module_provides( p_module, psz_capability ) )
{
/* Don't recurse through the sub-modules because vlc_list_find()
* will list them anyway. */
p_tmp = p_first;
while( p_tmp != NULL )
{
- vlc_object_yield( p_tmp->p_module );
+ module_hold( p_tmp->p_module );
p_tmp = p_tmp->p_next;
}
- /* We can release the list, interesting modules were yielded */
- vlc_list_release( p_all );
+ /* We can release the list, interesting modules were held */
+ module_list_free (p_all);
/* Parse the linked list and use the first successful module */
p_tmp = p_first;
/* Make sure the module is loaded in mem */
module_t *p_module = p_tmp->p_module;
if( p_module->b_submodule )
- p_module = (module_t *)p_module->p_parent;
+ p_module = p_module->parent;
if( !p_module->b_builtin && !p_module->b_loaded )
{
if( p_new_module )
{
CacheMerge( p_this, p_module, p_new_module );
- vlc_object_attach( p_new_module, p_module );
- DeleteModule( p_new_module, true );
+ DeleteModule( p_new_module, false );
}
}
#endif
break;
}
- vlc_object_release( p_tmp->p_module );
+ module_release( p_tmp->p_module );
p_tmp = p_tmp->p_next;
}
/* Unlock the remaining modules */
while( p_tmp != NULL )
{
- vlc_object_release( p_tmp->p_module );
+ module_release( p_tmp->p_module );
p_tmp = p_tmp->p_next;
}
/**
* Module unneed
*
- * This function must be called by the thread that called module_Need, to
+ * This function must be called by the thread that called module_need, to
* decrease the reference count and allow for hiding of modules.
* \param p_this vlc object structure
* \param p_module the module structure
* \return nothing
*/
-void __module_Unneed( vlc_object_t * p_this, module_t * p_module )
+void __module_unneed( vlc_object_t * p_this, module_t * p_module )
{
/* Use the close method */
if( p_module->pf_deactivate )
msg_Dbg( p_this, "removing module \"%s\"", p_module->psz_object_name );
- vlc_object_release( p_module );
+ module_release( p_module );
}
/**
* \param psz_name the name of the module
* \return a pointer to the module or NULL in case of a failure
*/
-module_t *__module_Find( vlc_object_t *p_this, const char * psz_name )
+module_t *__module_find( vlc_object_t *p_this, const char * psz_name )
{
- vlc_list_t *p_list;
- int i;
- p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE );
- for( i = 0 ; i < p_list->i_count; i++)
+ module_t **list, *module;
+
+ list = module_list_get (NULL);
+ if (!list)
+ return NULL;
+
+ for (size_t i = 0; (module = list[i]) != NULL; i++)
{
- module_t *p_module = ((module_t *) p_list->p_values[i].p_object);
- const char *psz_module_name = p_module->psz_object_name;
+ const char *psz_module_name = module->psz_object_name;
+
if( psz_module_name && !strcmp( psz_module_name, psz_name ) )
{
- /* We can release the list, and return yes */
- vlc_object_yield( p_module );
- vlc_list_release( p_list );
- return p_module;
+ module_hold (module);
+ break;
}
}
- vlc_list_release( p_list );
- return NULL;
-}
-
-
-/**
- * Release a module_t pointer from module_Find().
- *
- * \param module the module to release
- * \return nothing
- */
-void module_Put( module_t *module )
-{
- vlc_object_release( module );
+ module_list_free (list);
+ return module;
}
-
/**
* Tell if a module exists and release it in thic case
*
* \param psz_name th name of the module
* \return TRUE if the module exists
*/
-bool __module_Exists( vlc_object_t *p_this, const char * psz_name )
+bool __module_exists( vlc_object_t *p_this, const char * psz_name )
{
- module_t *p_module = __module_Find( p_this, psz_name );
+ module_t *p_module = __module_find( p_this, psz_name );
if( p_module )
- {
- module_Put( p_module );
- return true;
- }
- else
- {
- return false;
- }
+ module_release (p_module);
+ return true != NULL;
}
/**
const char *psz_capability,
char ***pppsz_longname )
{
- vlc_list_t *p_list;
- int i, j, count = 0;
+ size_t count = 0;
char **psz_ret;
+ module_t **list = module_list_get (NULL);
+
/* Do it in two passes : count the number of modules before */
- p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE );
- for( i = 0 ; i < p_list->i_count; i++)
+ for (size_t i = 0; list[i]; i++)
{
- module_t *p_module = ((module_t *) p_list->p_values[i].p_object);
+ module_t *p_module = list[i];
const char *psz_module_capability = p_module->psz_capability;
+
if( psz_module_capability && !strcmp( psz_module_capability, psz_capability ) )
count++;
}
free( psz_ret );
free( *pppsz_longname );
*pppsz_longname = NULL;
- vlc_list_release( p_list );
+ module_list_free (list);
return NULL;
}
- j = 0;
- for( i = 0 ; i < p_list->i_count; i++)
+ for (size_t i = 0, j = 0; list[i]; i++)
{
- module_t *p_module = ((module_t *) p_list->p_values[i].p_object);
+ module_t *p_module = list[i];
const char *psz_module_capability = p_module->psz_capability;
+
if( psz_module_capability && !strcmp( psz_module_capability, psz_capability ) )
{
int k = -1; /* hack to handle submodules properly */
psz_ret[j] = strdup( k>=0?p_module->pp_shortcuts[k]
:p_module->psz_object_name );
if( pppsz_longname )
- (*pppsz_longname)[j] = strdup( module_GetName( p_module, true ) );
+ (*pppsz_longname)[j] = strdup( module_get_name( p_module, true ) );
j++;
}
}
psz_ret[count] = NULL;
- vlc_list_release( p_list );
+ module_list_free (list);
return psz_ret;
}
* \param psize the size of the configuration returned
* \return the configuration as an array
*/
-module_config_t *module_GetConfig( const module_t *module, unsigned *restrict psize )
+module_config_t *module_config_get( const module_t *module, unsigned *restrict psize )
{
unsigned i,j;
unsigned size = module->confsize;
* \param the configuration
* \return nothing
*/
-void module_PutConfig( module_config_t *config )
+void module_config_free( module_config_t *config )
{
free( config );
}
if( !path ) return NULL;
/* Look for PATH_SEP_CHAR (a ':' or a ';') */
- for( i = 0, done = 0 ; paths[i]; i++ ) {
+ for( i = 0, done = 0 ; paths[i]; i++ )
+ {
/* Take care of \\ and \: or \; escapement */
- if( escaped ) {
+ if( escaped )
+ {
escaped = false;
path[done++] = paths[i];
}
+#ifdef WIN32
+ else if( paths[i] == '/' )
+ escaped = true;
+#else
else if( paths[i] == '\\' )
escaped = true;
+#endif
else if( paths[i] == PATH_SEP_CHAR )
break;
else
#ifdef HAVE_DYNAMIC_PLUGINS
static void AllocateAllPlugins( vlc_object_t *p_this )
{
+ const char *vlcpath = vlc_global()->psz_vlcpath;
int count,i;
char * path;
vlc_array_t *arraypaths = vlc_array_new();
/* Contruct the special search path for system that have a relocatable
* executable. Set it to <vlc path>/modules and <vlc path>/plugins. */
-#define RETURN_ENOMEM \
- { \
- msg_Err( p_this, "Not enough memory" ); \
- return; \
- }
- vlc_array_append( arraypaths, strdup( "modules" ) );
-#if defined( WIN32 ) || defined( UNDER_CE ) || defined( __APPLE__ ) || defined( SYS_BEOS )
- if( asprintf( &path, "%s" DIR_SEP "modules",
- vlc_global()->psz_vlcpath ) < 0 )
- RETURN_ENOMEM
- vlc_array_append( arraypaths, path );
- if( asprintf( &path, "%s" DIR_SEP "plugins",
- vlc_global()->psz_vlcpath ) < 0 )
- RETURN_ENOMEM
- vlc_array_append( arraypaths, path );
-#if ! defined( WIN32 ) && ! defined( UNDER_CE )
- if( asprintf( &path, "%s", PLUGIN_PATH ) < 0 )
- RETURN_ENOMEM
- vlc_array_append( arraypaths, path );
-#endif
-#else
+ if( vlcpath && asprintf( &path, "%s" DIR_SEP "modules", vlcpath ) != -1 )
+ vlc_array_append( arraypaths, path );
+ if( vlcpath && asprintf( &path, "%s" DIR_SEP "plugins", vlcpath ) != -1 )
+ vlc_array_append( arraypaths, path );
+#ifndef WIN32
vlc_array_append( arraypaths, strdup( PLUGIN_PATH ) );
#endif
- vlc_array_append( arraypaths, strdup( "plugins" ) );
/* If the user provided a plugin path, we add it to the list */
- char * userpaths = config_GetPsz( p_this, "plugin-path" );
+ char *userpaths = config_GetPsz( p_this, "plugin-path" );
char *paths_iter;
for( paths_iter = userpaths; paths_iter; )
{
path = copy_next_paths_token( paths_iter, &paths_iter );
- if( !path )
- RETURN_ENOMEM
- vlc_array_append( arraypaths, strdup( path ) );
+ if( path )
+ vlc_array_append( arraypaths, path );
}
count = vlc_array_count( arraypaths );
{
path = vlc_array_item_at_index( arraypaths, i );
if( !path )
- {
continue;
- }
msg_Dbg( p_this, "recursively browsing `%s'", path );
}
vlc_array_destroy( arraypaths );
-#undef RETURN_ENOMEM
+ free( userpaths );
}
/*****************************************************************************
* AllocatePluginFile: load a module into memory and initialize it.
*****************************************************************************
* This function loads a dynamically loadable module and allocates a structure
- * for its information data. The module can then be handled by module_Need
- * and module_Unneed. It can be removed by DeleteModule.
+ * for its information data. The module can then be handled by module_need
+ * and module_unneed. It can be removed by DeleteModule.
*****************************************************************************/
static int AllocatePluginFile( vlc_object_t * p_this, char * psz_file,
int64_t i_file_time, int64_t i_file_size )
if( p_module )
{
- libvlc_global_data_t *p_libvlc_global = vlc_global();
-
/* Everything worked fine !
* The module is ready to be added to the list. */
p_module->b_builtin = false;
/* msg_Dbg( p_this, "plugin \"%s\", %s",
p_module->psz_object_name, p_module->psz_longname ); */
+ p_module->next = p_module_bank->head;
+ p_module_bank->head = p_module;
- vlc_object_attach( p_module, p_libvlc_global->p_module_bank );
-
- if( !p_libvlc_global->p_module_bank->b_cache )
+ if( !p_module_bank->b_cache )
return 0;
-#define p_bank p_libvlc_global->p_module_bank
+#define p_bank p_module_bank
/* Add entry to cache */
p_bank->pp_cache =
realloc( p_bank->pp_cache, (p_bank->i_cache + 1) * sizeof(void *) );
p_bank->pp_cache[p_bank->i_cache]->b_used = true;
p_bank->pp_cache[p_bank->i_cache]->p_module = p_module;
p_bank->i_cache++;
+#undef p_bank
}
return p_module ? 0 : -1;
* AllocatePlugin: load a module into memory and initialize it.
*****************************************************************************
* This function loads a dynamically loadable module and allocates a structure
- * for its information data. The module can then be handled by module_Need
- * and module_Unneed. It can be removed by DeleteModule.
+ * for its information data. The module can then be handled by module_need
+ * and module_unneed. It can be removed by DeleteModule.
*****************************************************************************/
static module_t * AllocatePlugin( vlc_object_t * p_this, char * psz_file )
{
p_module = vlc_module_create( p_this );
if( p_module == NULL )
{
- msg_Err( p_this, "out of memory" );
module_Unload( handle );
return NULL;
}
p_module->b_loaded = true;
/* Initialize the module: fill p_module, default config */
- if( module_Call( p_module ) != 0 )
+ if( module_Call( p_this, p_module ) != 0 )
{
/* We couldn't call module_init() */
- vlc_object_release( p_module );
+ module_release( p_module );
module_Unload( handle );
return NULL;
}
static void DupModule( module_t *p_module )
{
char **pp_shortcut;
- int i_submodule;
for( pp_shortcut = p_module->pp_shortcuts ; *pp_shortcut ; pp_shortcut++ )
{
p_module->psz_help = p_module->psz_help ? strdup( p_module->psz_help )
: NULL;
- for( i_submodule = 0; i_submodule < p_module->i_children; i_submodule++ )
- {
- DupModule( (module_t*)p_module->pp_children[ i_submodule ] );
- }
+ for (module_t *subm = p_module->submodule; subm; subm = subm->next)
+ DupModule (subm);
}
/*****************************************************************************
static void UndupModule( module_t *p_module )
{
char **pp_shortcut;
- int i_submodule;
- for( i_submodule = 0; i_submodule < p_module->i_children; i_submodule++ )
- {
- UndupModule( (module_t*)p_module->pp_children[ i_submodule ] );
- }
+ for (module_t *subm = p_module->submodule; subm; subm = subm->next)
+ UndupModule (subm);
for( pp_shortcut = p_module->pp_shortcuts ; *pp_shortcut ; pp_shortcut++ )
{
* AllocateBuiltinModule: initialize a builtin module.
*****************************************************************************
* This function registers a builtin module and allocates a structure
- * for its information data. The module can then be handled by module_Need
- * and module_Unneed. It can be removed by DeleteModule.
+ * for its information data. The module can then be handled by module_need
+ * and module_unneed. It can be removed by DeleteModule.
*****************************************************************************/
static int AllocateBuiltinModule( vlc_object_t * p_this,
int ( *pf_entry ) ( module_t * ) )
* allocate a structure for it */
p_module = vlc_module_create( p_this );
if( p_module == NULL )
- {
- msg_Err( p_this, "out of memory" );
return -1;
- }
/* Initialize the module : fill p_module->psz_object_name, etc. */
if( pf_entry( p_module ) != 0 )
/* With a well-written module we shouldn't have to print an
* additional error message here, but just make sure. */
msg_Err( p_this, "failed calling entry point in builtin module" );
- vlc_object_release( p_module );
+ module_release( p_module );
return -1;
}
/* Everything worked fine ! The module is ready to be added to the list. */
p_module->b_builtin = true;
+ /* LOCK */
+ p_module->next = p_module_bank->head;
+ p_module_bank->head = p_module;
+ /* UNLOCK */
/* msg_Dbg( p_this, "builtin \"%s\", %s",
p_module->psz_object_name, p_module->psz_longname ); */
- vlc_object_attach( p_module, vlc_global()->p_module_bank );
-
return 0;
}
*****************************************************************************
* This function can only be called if the module isn't being used.
*****************************************************************************/
-static int DeleteModule( module_t * p_module, bool b_detach )
+static void DeleteModule( module_t * p_module, bool b_detach )
{
- if( !p_module ) return VLC_EGENERIC;
- if( b_detach )
- vlc_object_detach( p_module );
+ assert( p_module );
/* We free the structures that we strdup()ed in Allocate*Module(). */
#ifdef HAVE_DYNAMIC_PLUGINS
#endif
/* Free and detach the object's children */
- while( p_module->i_children )
+ while (p_module->submodule)
{
- vlc_object_t *p_this = p_module->pp_children[0];
- vlc_object_detach( p_this );
- vlc_object_release( p_this );
+ module_t *submodule = p_module->submodule;
+ p_module->submodule = submodule->next;
+ module_release (submodule);
}
config_Free( p_module );
- vlc_object_release( p_module );
- p_module = NULL;
- return 0;
+ module_release( p_module );
}
projects / vlc / blobdiff